[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry guys.. this is a fail for me.

I think you need to move the function call from Koha::Account::pay to
Koha::Account::Line::apply.. that way you'll catch any and all calls to apply
payments (where you have it now, you'll miss any calls directly to apply, or
calls to payin_amount.. and you'll miss cases where there's any additional
outstanding credit to be applied from the payment).

Also, when autorenewal of items upon payment was added (a similar feature in my
opinion).. we required that the user was given feedback of the change.. I'd
love to see that here too.

I realise this is an old development being worked through.. but at least the
first issue needs resolving prior to push in my opinion.. though I'd love to
see the second dealt with.. I'd personally be OK with that being in a follow-up
bug.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.