[Koha-bugs] [Bug 28068] Cash register should not record writeoff as cash received

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28068

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24786

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Fixed in master by 24786

Before that bug, we had:
 80 my $cash_register_id;
 81 if ( C4::Context->preference('UseCashRegisters') ) {
 82     $cash_register_id = $input->param('cash_register');
...
 93         if ( !$cash_register_id ) {
 94             my $default_register = Koha::Cash::Registers->find(
 95                 { branch => $library_id, branch_default => 1 } );
 96             $cash_register_id = $default_register->id if $default_register;
 97         }
 98         $cash_register_id = $registers->next->id if !$cash_register_id;


Which would set the cash register even for a write-off

After that patch we get the value from the template - and don't set it for
WRITEOFF

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.