[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #12)
> We already have "KohaTable", isn't this more ambiguous?

I think the difference between `KohaTable('selector', settings)` and
`$('selector').kohaTable(settings)` is clearer than the current
`$('selector').api(settings)`.. what is `.api()`.. the jQuery API, the selected
elements api.. it also doesn't help that datatables itself has an api() method
to get back the datatables api object.

I think we should slowly be migrating from template-driven datatables
(KohaTable) to api driven datatable (kohaTable).. so to me, the similarity is
deliberate and the distinction is clear.

Also, by starting to add JSDoc, my hope is people will reach for kohaTable
first in the future ;)

-- 
You are receiving this mail because:
You are watching all bug changes.