[Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #89 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #81)
> (In reply to Jonathan Druart from comment #80)
> > 1. I may be missing something but I don't understand why we are setting
> > OpacNav from the .tt when we need it in .inc. Why don't we
> > AdditionalContents.get from there?
> 
> Is there any best practice about the place of TT's [% USE %] directives?
> Note that we still didnt tackle the load aborted errors on template plugins
> where we also use includes..

The correct answer was: to avoid double fetch. We are actually doing:

SET OpacNav = AdditionalContents.get
[...]
[% IF OpacNav %]
  [% INCLUDE navigation.inc %]
[% END %]

And reusing OpacNav from navigation.inc

-- 
You are receiving this mail because:
You are watching all bug changes.