[Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Nov 5 12:05:27 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #4)
> Out of scope, just seeing this:
> 
> {
>     last unless ($op eq 'add');
> # ETC
> }
> 
> Normally we only use last in a loop (for, while). Perl allows this and says:
> "Note that a block by itself is semantically identical to a loop that
> executes once. Thus last can be used to effect an early exit out of such a
> block."
> 
> But surely this should just have been:
> 
> if( $op eq 'add' ) {
> # ETC
> }

Please add a bug report for that.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list