[Koha-bugs] [Bug 29441] We should make our method returns consistent in Koha::Biblio

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29441

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
On first look.. I feel like 'MARCXML' strings or 'MARC::Record' objects would
be the right thing to return from the `get_marc_` accessors.. and then the
consumer uses this response to do the next thing.. be that parse the string
with XSLT for display, or get the Koha::Biblio using the data within.. I
suggest this as it's what's returned from the search engine used for the two
existing calls and thus reduces reduces further calls internally that may not
be required.

As for get_marc_notes.. perhaps we would be better going back to 'get_notes' or
'get_notes_from_marc' to set a distinction between 'something that returns a
MARC thing' and 'something that returns string/s from inside the MARC'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.