[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Yes, I will make sure to mark the other patches (will probably only be one or
two more besides 25539) as depending on this one, as far as I understand this
is all I have to do to make this an omnibus bug?

For reviewers of this patch, here is a short summary of the changes:

Added an option 'defer_search_engine_indexing' to ModBiblio/Modbiblio marc,
which is used in the script for avoiding indexing each item individually and to
do so in bulk when changes are committed to the database. This is more
efficient, and you don't run the same risk of ending up with junk data in the
index if the script crashes and the current database transaction is rolled
back.

Instead of processing records in one loop, the processing is split up into two
loops. The first one for pre-processing tasks (transcoding, filtering out
broken records etc) that does not touch the database. This makes the code in
the import loop cleaner, and it's also nice to have the option of bailing out
before any database changes are committed (could for example add the option to
abort the whole import if contains one or more invalid records).

The rest of the changes more or less of fixing formatting/indentation, renaming
some variables for clarity purposes, making error/log messages more consistent
and generally just cleaning up the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.