[Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The logic is currently:

CAN_user_updatecharges_discount && account.is_debit && (
account.amountoutstanding == account.amount ) && !(account.debit_type_code ==
'PAYOUT')

But a void is pretty much always applied immediately so the
`account.amountoutstanding == account.amount` sohuldn't ever pass..  I have a
feeling when I wrote this that there was a particular way to end up with it
showing.. like a series of actions that would partially undo the void.. maybe
now.

I've rebased anyway.. but maybe leave this one for now.. marking back to minor.

-- 
You are receiving this mail because:
You are watching all bug changes.