[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #13)
> I wasn't aware of this behaviour, but it does not sound correct. "Branch"
> must contain the branchcode, and be a foreign key. If we want to keep this
> additional information it should be stored into a separate column.

The change should be then done for the statistics table as well, in this same
bug report, since there is only one syspref, OpacRenewalBranch, for both the
tables (statistics and pseudonymized_transactions). In addition to that the
OpacRenewalBranch syspref needs to be updated to described that if opacrenewal
is used then it is stored into another column. Another thing we might wanna fix
here is that if the user actually selects "NULL" as the OpacRenewalBranch
syspref value then we store empty string and not null really (I wonder if this
NULL/empty string is actually a regression?).

> Note that Marcel's workaround should work, if you create a branch with
> branchcode="OPACRenew" that should be inserted instead of NULL.

Not suitable for production.

-- 
You are receiving this mail because:
You are watching all bug changes.