[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #56 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
1. Some of the patches are missing check if there is any transfer at all before
proceeding to check in_transit status:

+        my $transfer = $item->get_transfer;
+        if ( $transfer->in_transit ) {

This results to such errors as this:

> Can't call method "in_transit" on an undefined value at /kohadevbox/koha/catalogue/detail.pl line 350

2.  The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation"
needs to come last in the patch series, so just reorder and reattach the
patches.

3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches that
use the output_pref function here.

4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and minutes,
please bring them back :)

5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the
in_transit transfers, it used to return all transfers previously, even those
not yet sent (so in queue). Could you double check on this? I think it is okay
and the previous behaviour was buggy as it says they are IN_TRANSIT transfers,
not queued ones.

-- 
You are receiving this mail because:
You are watching all bug changes.