[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Joonas Kylmälä from comment #2)
> If you remove the unless ... makes the code much simpler.

Done

> Please also move the cron return right after the call to 
> > $auto_renew = _CanBookBeAutoRenewed({

I don't believe I can. That is inside "unless ($override_limit)" so it would
make 'too_soon' subject to override

> Please include stats too, but maybe you are at it, I noticed that this bug
> is not even yet for sign-off and I'm here reviewing ;D

Yes, seeing what else I can improve first, will add when ready.

Feel free to add to/alter my patches - I appreciate the help!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.