[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474

--- Comment #13 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Joonas Kylmälä from comment #12)
> In the first patch you added the comment:
> 
> # override_limit will override anything else except on_reserve or too_soon
> 
> This is actually not what the code does, but it should do this I think, it
> used to do this but after the patch "Bug 19014: Return auto_too_soon before
> on_reserve" (51f5f6) the behaviour was changed. It was unadvertised change
> so it seems like a regression introduced by bug 19014. So actually the
> too_soon return should be outside the $override_limit if block as you had it
> the first time but before that we need to fix the regression from bug 19014.

Hmm, actually there is no regression, there was the $override_limit check also
before bug 19014. So the comment you added should be removed. Sorry for the
noise, the code is just so hard to understand...

-- 
You are receiving this mail because:
You are watching all bug changes.