[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127618|0                           |1
        is obsolete|                            |

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 127619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127619&action=edit
Bug 29476: Correct soonest renewal date calculation for checkouts with
auto-renewal

If a checkout with auto-renewal enabled doesn't have a
"norenewalbefore" circulation rule set the code in CanBookBeRenewed()
falls back to using due date (to verify this please look for the
string "auto_too_soon" in C4/Circulation.pm), the calculation result
of GetSoonestRenewDate() however didn't do this, though luckily it was
not used in CanBookBeRenewed so we didn't get any issues
there. However, GetSoonestRenewDate() is used for display the soonest
renewal date in the staff interface on the circ/renew.pl page so you
would have gotten wrong results there.

This patch moves additionally the tests made for Bug 14395 under a new
subtest for GetSoonestRenewDate() as they should have been like that
already before.

To test:
  1) prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.