[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This looks good.. My one query is around the `||
!C4::Context->preference('CalculateFinesOnReturn')` introduction..

I'm not sure if that's the behaviour we want/expect.. should we still increment
a fine after return here?  I realise, it's to do with the job being long
running and so the patron has 'got away with it' as it were.. but we could be
introducing questions if the patron returns their item, pays their fine and
then finds they have a bit more to pay after the fact because the calculations
were still running?

Otherwise, I think this is a great little improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.