[Koha-bugs] [Bug 29531] New: CanBookBeRenewed is inconsistent when checking AllowRenewalIfOtherItemsAvailable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29531

            Bug ID: 29531
           Summary: CanBookBeRenewed is inconsistent when checking
                    AllowRenewalIfOtherItemsAvailable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In working on bug 29483 it was found that the logic of CanBookBeRenewed can be
flawed when relating to AllowRenewalIfOtherItemsAvailable

At checkin we call 'CheckReserves' to find holds on the current item and will
fill only holds that obey hold 'policies' - but we will also fill a hold that
violates the 'rules'

To recreate:
1 - Set circ rules to allow 5 holds for All/All
2 - Set an itemtype level circ rule to allow 0 holds
3 - Place a title level hold on a record with an item of that type and one of
another type
4 - Note while placing hold that you cannot select the item of that type
5 - Check in the item with that type - the hold is trapped - ignore it for now
6 - Check out the other item to a patron
7 - Note the renew column in checkouts says 'On hold'
8 - Set AllowRenewalIfOtherItemsAvailable to 'Allow'
9 - Note the renew column still says 'On hold' despite the fact that that item
will fill the existing hold

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.