[Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 127924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127924&action=edit
Bug 29387: [21.05] Stringify exception when logging error during a batch mod
biblio

If an exception is raised by one the methods/subroutines called when batch
biblio update, the job will fail in the middle and some records won't be
processed.

Test plan:
0. Don't apply the patch
In KTD you can run the a batch mod biblio on the 100 first records and
the worker will fail with
"""
countered object 'C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception:
DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at
/kohadevbox/koha/C4/Biblio.pm line 423
', but neither allow_blessed, convert_blessed nor allow_tags settings are
enabled (or TO_JSON/FREEZE method missing) at
/kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 120.
"""
The UI is not saying anything about this problem.

Generate 100 biblionumbers: perl -e 'for (1..100){print "$_\n"}'
1. Apply the patch and confirm than now you see the detail of the batch
update and that biblionumber 72 is marked as not been modified with the
correct error (raw DBI error)

JK: add executable bit to BatchUpdateBiblio.t
Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 29387: Stringify exceptions for other background job modules

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 29387: (QA follow-up) Fix modules in test

Can't locate object method "new" via package
"Koha::BackgroundJob::BatchUpdateBiblio" (perhaps you forgot to load
"Koha::BackgroundJob::BatchUpdateBiblio"?) at
t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t line 45.

How did it pass at signoff?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.