[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #8 from David Nind <david at davidnind.com> ---
With no patch applied and using the latest master, if only 500 is hidden using
the NotesToHide system preference then it works as expected.

As per comment #2, if I have two 5XX fields with data (say 500 and 504, but I
tested and it can be any two fields) and hide all of them 500 still displays.

>From what I can tell, if all the available 5XX fields are added to NotesToHide,
then the first available field still displays. That is, it needs to display at
least one field under the description tab in the OPAC and staff interface, and
you can't hide them all.

To replicate (using koha-testing-docker (KTD) and the default book framework):
1. Add data to each available field for a record (with KTD I used record 262 -
Programming Perl).
2. Progressively hide each field until all the 5XX fields available are
included in NotesToHide (500,504,505,520,521,522,526,538,541,546,583,586).
3. Up until 586 was added to NotesToHide, everything worked as expected.
4. However, once I added 586, 500 was no longer hidden (all the other fields
remained hidden).
5. If I only have data in two fields, say 504 and 526, then 504 is still
displayed.

The patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17127: Remove notes from detail.tt to only use MARCNOTES
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
M       koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 17127: Remove notes from detail.tt to only use
MARCNOTES

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.