From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 22:09:43 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Depends on| |24488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 22:09:43 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 [Bug 29148] Holds to Pull doesn't reflect item-level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:16:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 22:16:09 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:16:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 22:16:12 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125566|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 125572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125572&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:25:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 22:25:55 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 01:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 23:28:40 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125572|0 |1 is obsolete| | --- Comment #5 from sandboxes at biblibre.com --- Created attachment 125573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125573&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 01:29:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Sep 2021 23:29:08 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Azucena Aguayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 02:45:18 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 02:45:23 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124231|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 125574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125574&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 02:45:27 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #9 from Aleisha Amohia --- Created attachment 125575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125575&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 02:45:53 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Biblio->get_marc_note |Koha::Biblio->get_marc_note |s should use |s should parse authorised |XSLTParse4Display |values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 08:43:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 06:43:28 +0000 Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout when Pseudonymization is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011 --- Comment #6 from JanMueck --- It states the following: DBIx::Class::Storage::DBI::_do_query(): DBI Exception: DBD::mysql::db do failed: Lost connection to backend server: network error (zd-dbsrv-5: 111, Connection refused) [for Statement "set NAMES 'utf8mb4'"] at /usr/share/koha/lib/C4/Context.pm line 624 Maybe this helps.. Kind regards Jan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:39:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 07:39:01 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #7 from Jonathan Druart --- Thanks a lot, Ere, for your reactivity! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:41:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 07:41:48 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125570|0 |1 is obsolete| | --- Comment #8 from Ere Maijala --- Created attachment 125576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125576&action=edit Bug 29135: Fix handling of deleted items in OAI-PMH provider Test plan: 1. Make sure this scenario now works properly: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0 2. Run prove -v t/db_dependent/OAI/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:44:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 07:44:59 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #9 from Ere Maijala --- Jonathan, no problem, it was my bad anyway.. I've added a couple more tests. I'll run a harvesting job to verify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:59:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 07:59:15 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #47 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:07:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:07:08 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #86 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #84) > (In reply to Jonathan Druart from comment #81) > > 3. > > > > + if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) { > > + push @messages, {type => 'error', code => > > 'article_request_numeric_limit' }; > > + $op = 'add_form'; > > + } elsif ($article_request_limit ne '' && $article_request_limit < 0) { > > + push @messages, {type => 'error', code => > > 'article_request_negative_limit' }; > > + $op = 'add_form'; > > + } else { > > > > Why that? > > I am expecting to see a JS validation and an exception raised in > > Koha::Category->store. But not in the controller. > > Is this a blocker for inclusion? I think so, it does not make sense to have it there. It may be better to just remove this check as we have the JS validation. If it is really what you need, you must use a "int unsigned" at DB level. Btw why do you use tinyint(4) when other "limit" columns in the same table are smallint(6)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:21:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:21:00 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #87 from Jonathan Druart --- I am not convinced by the COMPLETED, updated_on code: 965 Returns true if the patron can request articles. As limits apply for the patron 966 on on the same day, those completed the same day are considered as current. 976 my $dtf = Koha::Database->new->schema->storage->datetime_parser; 977 my $compdate = dt_from_string->add( days => -1 ); 978 my $count = Koha::ArticleRequests->search([ 979 { borrowernumber => $self->borrowernumber, status => ['REQUESTED','PENDING','PROCESSING'] }, 980 { borrowernumber => $self->borrowernumber, status => 'COMPLETED', updated_on => { '>', $dtf->format_date($compdate) }}, if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and updated_on > 2021-09-30 will return the rows updated yesterday as well. There is no test coverage for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:28:56 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #88 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #86) > I think so, it does not make sense to have it there. It may be better to > just remove this check as we have the JS validation. > > If it is really what you need, you must use a "int unsigned" at DB level. Agustin added the test with \d+ before there was js validation. I agree to remove it now. Not sure if we should really specify unsigned in SQL; did we do that more often? We could just check !value < 0 in js as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:29:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:29:30 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #89 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #87) > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and > updated_on > 2021-09-30 will return the rows updated yesterday as well. Read 'same day' here as last 24 hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:34:36 +0000 Subject: [Koha-bugs] [Bug 21303] XSLT should look in LDR/18 to know whether to add punctuation or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand at biblibre.com --- Comment #2 from marion.durand at biblibre.com --- I'm working on this bug, but I'm not sure what the result should be for this example 100 1# a Goscinny, René, d 1926-1977-, e author. About the comma near the date, should it look like: 1) Goscinny, René, 1926-1977- [author.]. (Without any comma after the date) or 2) Goscinny, René, 1926-1977-, [author.]. (With a comma after the date) About the two periods at the end, should it look like: 3) Goscinny, René, 1926-1977- [author.] (With the period inside the bracket) 4) Goscinny, René, 1926-1977- [author]. (With the period outside the bracket) 5) Goscinny, René, 1926-1977- [author.]. (With two periods) 6) Goscinny, René, 1926-1977- [author] (Without any period) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:34:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:34:38 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125470|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 125577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125577&action=edit Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:35:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:35:15 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125404|0 |1 is obsolete| | Attachment #125405|0 |1 is obsolete| | Attachment #125406|0 |1 is obsolete| | Attachment #125577|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 125578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125578&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:35:29 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #27 from Jonathan Druart --- Patches squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:40:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:40:28 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #13 from Martin Renvoize --- This is a lovely improvement... it simplifies and reduces code and adds direct access to checkouts from patron results page. I'd love to see a follow-on bug to do the same for holds searching and then we can ditch some more code :). However, I do think Fridolin raises a good point about the 'cardnumber' field being one you can hide which could cause confusion. The button styling isn't complete and I agree it's a little jarring to see it outside of the 'actions' field. I'd be tempted move the button to the actions column and perhaps update the cardnumber text to be a link directly to checkout (with a tooltip preferably). If you think that would fulfil all your customers requirements, I'd be happy to make that change in a follow-up Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:41:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:41:07 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #28 from Jonathan Druart --- Created attachment 125579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125579&action=edit Bug 23678: Don't display code of the job type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:43:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:43:51 +0000 Subject: [Koha-bugs] [Bug 29149] New: Background job detail view needs more flexibility Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Bug ID: 29149 Summary: Background job detail view needs more flexibility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:44:18 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Depends on| |29149 Assignee|agustinmoyano at theke.io |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 [Bug 29149] Background job detail view needs more flexibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:44:18 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 [Bug 23678] Cancel holds in bulk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:49:29 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:49:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:49:29 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 [Bug 29149] Background job detail view needs more flexibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:53:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:53:30 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #48 from Marcel de Rooy --- It might be completely obvious for people using this feature daily how it works, but since not everybody does, a little bit more test plan would have been helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:57:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:57:47 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #49 from Marcel de Rooy --- I read the discussion. Yes, there is a trend to put values in the prefs and no longer on the cmdline. We are in a hybrid situation now (as we are with many things). Asking to put something in koha-conf too would be rather tedious imo. This looks good to me. Adding just a small follow-up including my test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:57:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 08:57:56 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:06 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:08 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125489|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 125580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125580&action=edit Bug 15812: Use patron search in place of circ search The 'Checkout' search hijacks some of the DataTables searching code used for 'Search patrons' Rather than try to implement the search again on another page, we can simply send the user to the patron search if the cardnumber is not found Additionally, this patch adds a 'Check out' button to the patron search results to allow going to checkotus directly To test: 1 - Apply patch 2 - Perform a 'Checkout' search from the header 3 - Note that: For a cardnumber, you are redirected directly to checkouts page for the borrower For a search with one result, you are redirected directly to the checkout page for the borrower For a search with many results, you are redirected to the patron search results and there is a 'Checkout' button under the cardnumber 4 - Confirm circulation page works as expected (i.e. checkout to a patron) Signed-off-by: Kyle M Hall Signed-off-by: George Williams Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:10 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 --- Comment #1 from Jonathan Druart --- Created attachment 125581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125581&action=edit Bug 29149: Add the capability to provide more info to the background job detail view (Patch extracted from bug 28445 to make it reusable for bug 23678) We already had the need for that, when bibliographic records are modified in batch we wanted to add a "Add to list" feature, and so pass a list of lists/virtual shelves to the template. Here (in 28445) we will want to pass the infos of the items that have been modified to display a table. Test plan: 0. Create at least one list (virtual shelf) 1. batch update biblios 2. Go to the job detail 3. Notice that dropdown list to add the record to a list => No regression found! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:12 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125490|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 125582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125582&action=edit Bug 15812: (follow-up) Add permission check for 'Check out' button Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:16 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #16 from Martin Renvoize --- Created attachment 125583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125583&action=edit Bug 15812: (follow-up) Tweaks to patron results display Move the button into the actions column and make 'cardnumber' a link to checkout, with a tooltip. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:22 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:00:56 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #17 from Martin Renvoize --- Code speaks.. let me know what you think of that final followup. Otherwise, I'm happy to PQA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:36 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:40 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120927|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy --- Created attachment 125584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125584&action=edit Bug 25429: Cleanup Database - remove resolved claims returned from db after X days Add option to cleanup_database script to removed 'resolved' return claims from the database after a specified number of days. Test Plan: 1) Apply this patch 2) Set the new syspref CleanUpDatabaseReturnClaims to a number of days 3) Run cleanup_database.pl 4) Note resolved claims older than the specified number of days are removed from the database Bug 25429: Implement system preference, remove command line switch Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:44 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120928|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 125585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125585&action=edit Bug 25429: Script should be able to run with only return claims Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:49 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120929|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy --- Created attachment 125586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125586&action=edit Bug 25429: Use filter_by_last_update Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:53 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120930|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy --- Created attachment 125587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125587&action=edit Bug 25429: Require command line switch to enable, control DAYS via syspref Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:02:57 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #54 from Marcel de Rooy --- Created attachment 125588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125588&action=edit Bug 25429: (QA follow-up) Add extra variable for days I think it is a bit more clear to use another variable for the number of days from the preferences than overwriting the flag variable. Signed-off-by: Marcel de Rooy Tested by adding an authval for LOST. Filling prefs ClaimReturnedLostValue, CleanUpDatabaseReturnClaims. Claiming a return, resolving it. Setting date back via SQL. Running the script with -v --return-claims, toggling --confirm. The claim is counted and deleted with confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:03:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:03:40 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #90 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #89) > (In reply to Jonathan Druart from comment #87) > > > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and > > updated_on > 2021-09-30 will return the rows updated yesterday as well. > > Read 'same day' here as last 24 hours. Are you sure this is correct? Sept 30th 16pm is yesterday for me, and it's Oct 1st 11am now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:10:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:10:17 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #18 from Fridolin Somers --- Whaou for me it is awesome. Thanks a lot Martin ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:05 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125578|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 125589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125589&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm JD Amended patch: Full rebase and adjustements made on top of bug 26080. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:10 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125579|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 125590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125590&action=edit Bug 23678: Don't display code of the job type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:34 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125576|0 |1 is obsolete| | --- Comment #10 from Ere Maijala --- Created attachment 125591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125591&action=edit Bug 29135: Fix handling of deleted items in OAI-PMH provider Test plan: 1. Make sure this scenario now works properly: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0 2. Run prove -v t/db_dependent/OAI/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:53 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125509|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 125592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125592&action=edit Bug 29139: $line->debit_offsets doesn't honor list context Being based on _new_from_dbic (discussion on bug 28883), makes the assignment incorrect: my @account_offsets = $payment->debit_offsets; This patch explicitly makes the resultset be assigned as a list by calling *as_list*. To test: 1. Have UseEmailReceipts disabled 2. Have a patron with a debt of 6 3. Make a payment of 2 => SUCCESS: All good 4. Enable UseEmailReceipts 5. Repeat 3 => FAIL: You get something like: ERROR PROCESSING TEMPLATE: undef error - The method Koha::Account::Offsets->debit is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595 Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called at input text line 6 eval {...} at input text line 6 eval {...} at input text line 23 6. Apply this patch 7. Repeat 3 => SUCCESS: It doesn't explode anymore! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:54 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #31 from Jonathan Druart --- Patches rebased and reworked on top of bug 26080 (PQA for a month already). It refactored some of the background job code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:16:57 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125510|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 125593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125593&action=edit Bug 29139: Fix incorrect relation call The bug here was worse than originally thought. We were calling the wrong relation too.. we should probably add some exceptions to catch this, it confuses me every single time! Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:17:01 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125511|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 125594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125594&action=edit Bug 29139: Add exceptions to relation accessors We already had exceptions on the many-to-many links, but we didn't have them for the middle table. The underlying dbic relations make it clear which id's are being used for linking. A 'credit' has 'credit_offsets', a 'debit' has 'debit_offsets'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:17:05 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125512|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 125595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125595&action=edit Bug 29139: Add regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:17:09 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125513|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 125596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125596&action=edit Bug 29139: Only pass the offsets for lines the credit was applied to On writing the regression tests, I noticed the CREATE offset was added to the template. The idea behind passing the offsets is that we can print information about the lines that got the credit applied. Having the CREATE offset is meaningless, and (worse) would require users to add logic to skip it. And all the payment information is already passed in the 'credit' variable anyway. This patch filters the credit_offsets by type, leaving the APPLY ones only. To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: 3 offsets, including the CREATE one, boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Only the two APPLY offsets are returned! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:17:13 +0000 Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #38 from Marcel de Rooy --- @RM: What holds you back from pushing this development? This makes me doubt if I should QA things that depend on it. If you have doubts on this one, please indicate so on the report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:17:35 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize --- Final QA run done over the whole patchset... nice work everyone. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:18:06 +0000 Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 --- Comment #14 from Marcel de Rooy --- Asked a question about one of the base reports still not pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:24:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:24:48 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125583|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 125597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125597&action=edit Bug 15812: (follow-up) Tweaks to patron results display Move the button into the actions column and make 'cardnumber' a link to checkout, with a tooltip. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:26:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:26:47 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:27:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:27:16 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #20 from Martin Renvoize --- Last little tweak made the action button prettier ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:27:35 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:39:06 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- I dont want to disappoint you but the whole discussion on bug 28883 will have a bearing on this one too. The point is that TT calls methods in list context. Which is what you dont want when chaining. So e.g. object.filterbyX.count does not even work when filter returns a list while in perl would return an iterator here. And specific to this bug, how would a 'power user' editing a notice know that difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:42:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:42:38 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #1 from Martin Renvoize --- Created attachment 125598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125598&action=edit Bug 29005: Enable welcome email from patron imports This patch was updated from work done by Evangelische Theologische Faculteit to allow the patron import to send welcome emails to users when enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:43:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:43:01 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:43:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:43:08 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:44:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:44:46 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #32 from Jonathan Druart --- 99 error => defined $hold 100 ? ( $@ ? $@ : 0 ) 101 : 'No hold with id ' . $hold_id . ' found', Caught a non translatable error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:50:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:50:13 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- I would recommend to use this opportunity to sort the various message settings, at least on the OPAC side. It is a bit strange to see Hold reminder now below under Item checkout. But this definitely has a multi language aspect ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:54:42 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:54:45 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123447|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 125599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125599&action=edit Bug 28352: Only check authorised values mapped to DB fields The errors reported seem to be caused by authorised values mapped to MARC fields but not mapped to a koha field. We should additionally make sure to check the Default framework Also, adding comment to indicate we only check records with items, because we do TO test: 1 - In a framework that is not the default map a MARC field to an authorised value, but not a koha field 2 - In SQL, force the kohafield to NULL for the mapping you just make UPDATE marc_subfield_structure SET kohafield = NULL WHERE frameworkcode='BKS' and authorised_value='HINGS_AS' 3 - perl misc/maintenance/search_for_data_inconsistencies.pl 4 - get the following errors: Use of uninitialized value $tmp_kohafield in pattern match (m//) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 151. Use of uninitialized value $tmp_kohafield in substitution (s///) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 154. Can't call method "get_column" on an undefined value at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 157. 5 - Apply patch 6 - Repeat 7 - No more errors Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 09:54:59 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:01:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:01:00 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #33 from Jonathan Druart --- Created attachment 125600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125600&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:01:59 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #34 from Jonathan Druart --- Tomas, have a look at the current version and the dependent bugs. I moved code out of bug 28445 to reuse it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:02:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:02:18 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |agustinmoyano at theke.io |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:42:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:42:29 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #21 from Owen Leonard --- I like the change to the buttons but I'm sorry to see Bug 28081 undone. I'd like to argue that the link is redundant since the button has been added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:46:06 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:46:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:46:28 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #22 from Martin Renvoize --- Good catch Owen.. I wasn't aware of the label stuff.. I thought it had been added here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:51:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 10:51:56 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:08:55 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:09:00 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125311|0 |1 is obsolete| | Attachment #125312|0 |1 is obsolete| | Attachment #125313|0 |1 is obsolete| | --- Comment #5 from Peter Vashchuk --- Created attachment 125601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125601&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:09:05 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #6 from Peter Vashchuk --- Created attachment 125602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125602&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:09:10 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #7 from Peter Vashchuk --- Created attachment 125603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125603&action=edit Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:26:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:26:58 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #23 from Martin Renvoize --- Created attachment 125604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125604&action=edit Bug 15812: (follow-up) Enable click row to select This patch adds handling to allow clicking anywhere in the table row to select/deselect the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:03 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:07 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:12 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:17 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:22 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:27 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:31 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:35 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:40 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:46 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:52 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:29:57 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:30:02 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:30:07 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:30:13 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:30:17 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:31:34 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:31:41 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch replaces the release notes| |special case patron results | |page from circulation | |searches and instead | |redirects to the standard | |patron search results page. | | | |To enable quick onward | |navigation to checkout, we | |add a link to the | |cardnumber field and a | |button to the actions | |column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:05 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #102 from Tomás Cohen Arazi --- Created attachment 125605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125605&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:13 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #103 from Tomás Cohen Arazi --- Created attachment 125606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125606&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:23 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #104 from Tomás Cohen Arazi --- Created attachment 125607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125607&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:31 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #105 from Tomás Cohen Arazi --- Created attachment 125608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125608&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:41 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 125609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125609&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:32:51 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #107 from Tomás Cohen Arazi --- Created attachment 125610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125610&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:01 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 125611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125611&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:15 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #109 from Tomás Cohen Arazi --- Created attachment 125612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125612&action=edit Bug 27526: Fix Add & duplicate Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:22 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #110 from Tomás Cohen Arazi --- Created attachment 125613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125613&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:29 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #111 from Tomás Cohen Arazi --- Created attachment 125614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125614&action=edit Bug 27526: Fix incorrect condition The barcode was always prefilled! Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:37 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #112 from Tomás Cohen Arazi --- Created attachment 125615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125615&action=edit Bug 27526: Fix empty string vs undef Empty strings must be removed, not inserted as empty strings in DB. The relevant code is in TransformHtmlToXml, $skip variable. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:45 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #113 from Tomás Cohen Arazi --- Created attachment 125616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125616&action=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:33:53 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #114 from Tomás Cohen Arazi --- Created attachment 125617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125617&action=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:34:02 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #115 from Tomás Cohen Arazi --- Created attachment 125618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125618&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:34:10 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #116 from Tomás Cohen Arazi --- Created attachment 125619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125619&action=edit Bug 27526: Add missing POD Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:34:16 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #117 from Tomás Cohen Arazi --- Created attachment 125620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125620&action=edit Bug 27526: Add tests for columns_to_str and host_items Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:37:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:37:25 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #118 from Tomás Cohen Arazi --- Ok, I already tested and signed this before. Tests were added as requested and they pass. All found issues by testers addressed in follow-up patches. No QA issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:39:15 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:39:41 +0000 Subject: [Koha-bugs] [Bug 29150] New: hold pickup sent two patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29150 Bug ID: 29150 Summary: hold pickup sent two patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:39:47 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #24 from Martin Renvoize --- Created attachment 125621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125621&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to allow clicking anywhere in the table cell to select/deselect the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:47:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:47:04 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125621|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 125622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125622&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to allow clicking anywhere in the table cell to select/deselect the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:47:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:47:32 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:49:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 11:49:42 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #26 from Martin Renvoize --- OK, I think we're all done now. I restored the label, but made it a visually hidden one inside the check column for accessibility and I made the whole table cell clickable for the checkbox to restore the larger click handling area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:00:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 12:00:11 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125622|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 125623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125623&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to allow clicking anywhere in the table cell to select/deselect the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 12:04:03 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125623|0 |1 is obsolete| | --- Comment #28 from Owen Leonard --- Created attachment 125624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125624&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to allow clicking anywhere in the table cell to select/deselect the patron Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:17:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 12:17:18 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:55:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 12:55:38 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #11 from Ere Maijala --- Test harvesting completed successfully and record counts match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:03:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:03:08 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic update of exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:03:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:03:35 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:03:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:03:39 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:04:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:04:00 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 125625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125625&action=edit Bug 29149: Add the capability to provide more info to the background job detail view (Patch extracted from bug 28445 to make it reusable for bug 23678) We already had the need for that, when bibliographic records are modified in batch we wanted to add a "Add to list" feature, and so pass a list of lists/virtual shelves to the template. Here (in 28445) we will want to pass the infos of the items that have been modified to display a table. Test plan: 0. Create at least one list (virtual shelf) 1. batch update biblios 2. Go to the job detail 3. Notice that dropdown list to add the record to a list => No regression found! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:04:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:04:04 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 125626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125626&action=edit Bug 29149: (QA follow-up) Reorganize mapping This patch changes the mapping so it is more readable, and also allows adding things there more easily, like allowing to add code => class mappings from plugins, when time comes. To test: 1. Just verify things still work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:19:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:19:36 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:19:41 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:19:44 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:19:48 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:20:40 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 125627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125627&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm JD Amended patch: Full rebase and adjustements made on top of bug 26080. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:20:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:20:46 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 125628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125628&action=edit Bug 23678: Don't display code of the job type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:20:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:20:54 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 125629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125629&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:22:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:22:48 +0000 Subject: [Koha-bugs] [Bug 29151] New: Display issues for exchange rates with a lot of decimals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29151 Bug ID: 29151 Summary: Display issues for exchange rates with a lot of decimals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org Created attachment 125630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125630&action=edit Currencies Menu › Exchange rates display issue with Rial After updating Koha from 18.05 to 20.11, we face a problem with the Iranian Rial currency : exchange rate is 1,00 Rial = 0,000020509699 Euros. Before, rate was saved as "0.00002" (only 5 decimals). Now, on 20.11.10 and master 21.06.00.025, rate is saved as "2e-05" (see screenshot attached from master). Calculation on basket is still correct, but I think this new display in the Currencies menu can be disturbing for users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:29:40 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #91 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #88) > (In reply to Jonathan Druart from comment #86) > > I think so, it does not make sense to have it there. It may be better to > > just remove this check as we have the JS validation. > > > > If it is really what you need, you must use a "int unsigned" at DB level. > > Agustin added the test with \d+ before there was js validation. I agree to > remove it now. Not sure if we should really specify unsigned in SQL; did we > do that more often? We could just check !value < 0 in js as well. The DB structure and data types should help us avoid useless manual validations. But as we don't use STRICT_TRANS_TABLES, even marking the column as UNSIGNED INT will allow setting even a string... This is one of the reasons we should push for the API instead of this controller scripts (for data entry at least), because we can add the rules to the spec, and the OpenAPI plugin validates all the things for us. That said, I believe we can either keep or remove the validation. Keeping it prevents passing bad data manually, removing it cleans the controller a tiny bit. I would say let's do whatever the RM is more comfortable with so we move on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:31:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:31:23 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #92 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #87) > I am not convinced by the COMPLETED, updated_on code: > > 965 Returns true if the patron can request articles. As limits apply for > the patron > 966 on on the same day, those completed the same day are considered as > current. > > 976 my $dtf = Koha::Database->new->schema->storage->datetime_parser; > 977 my $compdate = dt_from_string->add( days => -1 ); > 978 my $count = Koha::ArticleRequests->search([ > 979 { borrowernumber => $self->borrowernumber, status => > ['REQUESTED','PENDING','PROCESSING'] }, > 980 { borrowernumber => $self->borrowernumber, status => > 'COMPLETED', updated_on => { '>', $dtf->format_date($compdate) }}, > > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and > updated_on > 2021-09-30 will return the rows updated yesterday as well. > > There is no test coverage for that. So this is the main blocker for this dev. I will add tests: Marcel: what is the right behavior? 24 hours timespan? same day? I feel like 'same day' is the right thing. But will implement it as you want, so: how? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:32:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:32:30 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #93 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #88) > do that more often? We could just check !value < 0 in js as well. The JS validation I added already checks the min value is 1. So no negative values allowed (in the form) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:35:25 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- +1 on this, it'd be a really handy option to have -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:45:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:45:14 +0000 Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 15:47:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 13:47:41 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #94 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #91) > The DB structure and data types should help us avoid useless manual > validations. But as we don't use STRICT_TRANS_TABLES, even marking the > column as UNSIGNED INT will allow setting even a string... (nitpicky mode) It will actually raise a non-blocker warnings and the value will be ignored. The DBMS won't store a string into a int ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:09:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:09:45 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125629|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 125631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125631&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:17:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:17:29 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart --- +sub type_to_class_mapping { FAIL Koha/BackgroundJob.pm FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 253) False positive, fixed by https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/40 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:18:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:18:59 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #373 from David Gustafsson --- Created attachment 125632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125632&action=edit Bug 14957: Fix regression, rules must be refetched on add/edit/deletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:19:11 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #374 from David Gustafsson --- Created attachment 125633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125633&action=edit Bug 14957: Fix imports in marc-overlay-rules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:22:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:22:21 +0000 Subject: [Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- sub article_requests_current { return $self->article_requests->filter_by_current; sub article_requests_finished { return $self->article_requests->filter_by_finished; How are they useful? Callers can call $biblio->article_requests->filter_by_* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:25:51 +0000 Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #16 from Jonathan Druart --- Reverting "Bug 28510: Remove unnecessary conditional" fixes the problem. I am going to revert this patch as a first step, but feel free to submit a better fix if you understand what's going on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:26:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:26:38 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #375 from David Gustafsson --- Fixed a regression introduced in commit, "Bug 14957: Clean controller". There was reason for that kludgy code even though it could be somewhat simplified. Also some imports that needed to be fixed after some subs no longer exported by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:29:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:29:58 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:02 +0000 Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #39 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:06 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:09 +0000 Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #21 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:11 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:14 +0000 Subject: [Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:16 +0000 Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent access to the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:19 +0000 Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent access to the plugins list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:22 +0000 Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:25 +0000 Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:29 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:33 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 --- Comment #25 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:38 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:30:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:30:42 +0000 Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more flexibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:34:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:34:45 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:34:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:34:50 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125574|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 125634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125634&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:34:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:34:57 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125575|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 125635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125635&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:37:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:37:58 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #376 from David Gustafsson --- Appears to be some failing tests. I think I know why as encountered the same issue with another patch. Part of the leader field is now modified in Koha in ModBiblio, which was not the case before, so records appears to have changed when the data has not as the whole record is now checked, when only specific fields where before. Will have a look at this at monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:38:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:38:18 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:48:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:48:23 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #377 from David Gustafsson --- Created attachment 125636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125636&action=edit Bug 14957: Exclude leader from saved/updated record comparison in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:48:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:48:59 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #378 from David Gustafsson --- Realized was very easy to fix, now tests should be working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:50:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:50:44 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #379 from Jonathan Druart --- Thanks David for your follow-ups. Martin and I are ready to help you here. We have enough time before the 21.11 freeze to make this new feature part of the next release :) Can you reply to the other open questions please? See below. I am volunteering to write the patches needed. (In reply to Martin Renvoize from comment #327) > (In reply to Jonathan Druart from comment #324) > > 2. We don't hide the admin page if the pref is off, is that expected? > > Whilst I agree with what you're saying here, I think if memory serves this > was discussed earlier in the bug and the authors wanted the ability to > create their rules and then enable them.. so they wanted to display the page > regardless or whether the pref was on or off (the page does warn you at the > top if the pref is off).. having said that.. I'd be happy to follow-up to > change that.. or, in my opinion in a later bug we could drop the pref and > instead have an 'enabled' flag at the rule level. It seems weird to have the pref off but the link to the admin page visible. > > 3. Should we link the pref to the admin page? > > Not sure what you're saying here? I meant, should we have a link to the admin page of the feature in the syspref's description. I can do it. > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( Need to be investigated. (In reply to Jonathan Druart from comment #331) > I know librarians can have weird needs but, should we really offer the > "custom" preset? I am reading the tests right now and some combinations are > doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 > "action" column with the predefined ones? (not considering this question a > blocker, but I would be happy to get an answer). Still waiting for an answer. See also the "warning"s and "fixme"s from the patch "Improve readbility of tests". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:59:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:59:39 +0000 Subject: [Koha-bugs] [Bug 29152] New: Change to default search behavior when limiting by branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 Bug ID: 29152 Summary: Change to default search behavior when limiting by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 21249 Prior to bug 21249, branch limits in searching were enforced based on the item homebranch. Bug 21249 introduces a syspref to control how those limits are enforced. That's good. But on update the syspref is set to limit based on BOTH homebranch and holdingbranch. That's bad. >From 21249: $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SearchLimitLibrary', 'both', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice')}); Should we not make that default to homebranch in order to not silently change how searches work? This makes a *huge* difference in search results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 16:59:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 14:59:39 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29152 [Bug 29152] Change to default search behavior when limiting by branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 17:02:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 15:02:29 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #95 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #92) > Marcel: what is the right behavior? Thats a good question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 17:05:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 15:05:20 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #380 from David Gustafsson --- (And I think it's probably much better to compare the whole record in the tests, you don't get as detailed feedback on failure, but on the other hand catches if there are unexpected modifications of other parts of the record which is more important). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 17:25:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 15:25:14 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #381 from David Gustafsson --- Hi again! > It seems weird to have the pref off but the link to the admin page visible. I have not made any active decision regarding this, it's been like this since before I got involved and have never given it much thought. Don't have any strong opinions either way. Elasticsearch settings seems to work the same way, that is if SearchEngine is Zebra, you still have a "Search engine configuration (Elasticsearch)" link in Administration with a "Elasticsearch is currently disabled" notice at the top. So personally I would probably keep it as it is just to avoid the extra work (even though should be pretty easy to change). > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( I don't have time to look at this today but can do on Monday. > I know librarians can have weird needs but, should we really offer the > "custom" preset? I am reading the tests right now and some combinations are > doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 > "action" column with the predefined ones? (not considering this question a > blocker, but I would be happy to get an answer). I see no reason to remove this, I just don't see the harm of having the option if there is some weird scenario where it could be useful. I don't see the "custom" option as complicating the UI, it's just an extra choice in a dropdown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 17:29:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 15:29:02 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #96 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #95) > (In reply to Tomás Cohen Arazi from comment #92) > > Marcel: what is the right behavior? > > Thats a good question. I'm about to resubmit this patchset with some requests from the RM, and I will make it 'same day' as it was at some point. Sand promise to work on another approach on another bug if it is filed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 17:38:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 15:38:41 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #382 from David Gustafsson --- And I think there are pedagogical reasons to keep the columns with the action choices and being able to see which ones are selected for each preset. Even though I understand it will be challenging for must librarians to understand the current rules concept, if we where to remove the separate actions (which now also have pretty good explanations), I think it would be much harder for people to understand exactly how rules are applied, and a higher risk for assuming work in some different way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 18:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 16:57:26 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 18:57:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 16:57:30 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122944|0 |1 is obsolete| | Attachment #122955|0 |1 is obsolete| | --- Comment #25 from Lucas Gass --- Created attachment 125637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125637&action=edit Bug 28717: Fix additional content logs The logging for additional contents added by bug 26205 has been broken by but 22544. This patch is a revisited version as bug 24387 has been pushed. It does not log MODIFY if no modification has been made on a template (useful when only 1 version/lang of a content has been modified) Test plan: Turn on NewsLog Add/modify and delete additional contents/News and confirm that modification are logged. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:00:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:00:32 +0000 Subject: [Koha-bugs] [Bug 29153] New: CodeMirror broken on additional-contents.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Bug ID: 29153 Summary: CodeMirror broken on additional-contents.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: -Go to Tools and open either addtional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:28:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:28:42 +0000 Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:29:54 +0000 Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:31:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:31:15 +0000 Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:32:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:32:25 +0000 Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:33:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:33:15 +0000 Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:39:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:39:13 +0000 Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #19 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:42:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:42:40 +0000 Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:43:37 +0000 Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 19:44:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 17:44:41 +0000 Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not defined for key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:04:41 +0000 Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:07:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:07:15 +0000 Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained when using fast add In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:08:55 +0000 Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:08:55 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Bug 22605 depends on bug 28847, which changed state. Bug 28847 Summary: Branch limits while searching should be expanded in query building and not in CGI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:16:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:16:09 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle at bywatersolutions.com --- Comment #115 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:18:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:18:32 +0000 Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:20:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:20:57 +0000 Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:21:53 +0000 Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:24:14 +0000 Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:26:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:26:37 +0000 Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:27:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:27:26 +0000 Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:28:01 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #12 from David Nind --- For me the tests fail: not ok 33 - Tests for timestamp handling # Failed test 'Tests for timestamp handling' # at t/db_dependent/OAI/Server.t line 849. # Looks like you failed 1 test of 33. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/33 subtests Testing notes (koha-testing-docker started with ku): - Enable OAI-PMH - Before the patch is replied there is an incomplete item record listed at the end of the metadata section for the item deleted, after the patch nothing is shown for the deleted item, for example: 0 0 0 _ 0 REF 313 FPL FPL GEN 2014-09-04 39999000006117 2014-09-04 2014-09-04 BK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:28:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:28:09 +0000 Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:29:10 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:29:10 +0000 Subject: [Koha-bugs] [Bug 25916] Create function and UI to modify budgets and funds. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 Bug 25916 depends on bug 24190, which changed state. Bug 24190 Summary: Add additional Acquisition logging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:29:33 +0000 Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:29:49 +0000 Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request metadata in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:30:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:30:04 +0000 Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:30:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:30:48 +0000 Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:31:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:31:24 +0000 Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:31:43 +0000 Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:33:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:33:34 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #42 from Kyle M Hall --- Please add patches for 21.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:33:35 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Bug 28803 depends on bug 28870, which changed state. Bug 28870 Summary: Cart shipping fails because of Non-ASCII characters in display-name of reply-to address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:34:39 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:34:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:34:39 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Bug 28803 depends on bug 28870, which changed state. Bug 28870 Summary: Cart shipping fails because of Non-ASCII characters in display-name of reply-to address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:34:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:34:52 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:35:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:35:06 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:35:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:35:15 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:35:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:35:23 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:35:33 +0000 Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:35:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:35:56 +0000 Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #52 from Kyle M Hall --- Please add patches for 21.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:36:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:36:32 +0000 Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 20:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 18:41:11 +0000 Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when DefaultHoldExpirationdate turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 21:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 19:08:53 +0000 Subject: [Koha-bugs] [Bug 26776] Authorities: Replace authority with Z3950 does not update existing record when duplicate check is triggered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26776 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 21:20:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 19:20:38 +0000 Subject: [Koha-bugs] [Bug 26776] Authorities: Replace authority with Z3950 does not update existing record when duplicate check is triggered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26776 --- Comment #3 from Andrew Fuerste-Henry --- I can confirm this is still true in 21.05 and is still a point of frustration. We need an option to replace the existing authority with what we've just fetched from z39.50 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 21:28:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 19:28:52 +0000 Subject: [Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > sub article_requests_current { > return $self->article_requests->filter_by_current; > > sub article_requests_finished { > return $self->article_requests->filter_by_finished; > > How are they useful? Callers can call $biblio->article_requests->filter_by_* Agreed. My plan was to remove them. But it felt like it was better to keep them to prove no behavior change. And then remove them while refactoring the controllers. And why not just remove the controllers if I had the chance :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 22:27:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 20:27:10 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #97 from Tomás Cohen Arazi --- Created attachment 125638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125638&action=edit Bug 27945: Clarify 'same day' behavior This patch introduces tests for the 'same day' check of the ability to place article requests for a patron. The limit goes against current requests, and those that have been completed on the same day. The tests cover this specific situation. The current behavior is that it takes into account a 24 hr timespan, but consensus on the QA step was that we should do it as 'same day' and use a separate feature request to change this, if required. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 22:29:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 20:29:06 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 22:33:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 20:33:57 +0000 Subject: [Koha-bugs] [Bug 29154] New: Add hold cancellation reason to Holds Awaiting Pickup page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154 Bug ID: 29154 Summary: Add hold cancellation reason to Holds Awaiting Pickup page Change sponsored?: --- Product: Koha Version: 21.05 Hardware: Macintosh OS: Mac OS Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: pnavarrete at cca.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Using the authorized value "HOLD_CANCELLATION" allows us to choose a reason a hold was cancelled, which then triggers a patron notice. However, the option to choose a reason does not appear on the Holds Awaiting Pickup page, which is where we cancel holds from often. Can the hold cancellation options be added to this page? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:08:58 +0000 Subject: [Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125263|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi --- Created attachment 125639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125639&action=edit Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:09:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:09:58 +0000 Subject: [Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 --- Comment #11 from Tomás Cohen Arazi --- Rebased on top of bug 27945 changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:11:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:11:02 +0000 Subject: [Koha-bugs] [Bug 29155] New: upgrade jquery version Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Bug ID: 29155 Summary: upgrade jquery version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha currently jQuery version 2.2.3 on the staff client and 3.4.1 on the OPAC. There are known vulnerabilities in versions less than 3.5.0: https://www.cvedetails.com/cve/CVE-2020-11023/ Perhaps it is time to upgrade to a more secure version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:28:22 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125268|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi --- Created attachment 125640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125640&action=edit Bug 29083: Unit tests This patch adds missing tests for Koha::Patron->article_requests and moves (and extends) tests for 'article_requests_current' and 'article_requests_finished' that were originally in ArticleRequests.t into Koha/Patron.t as we now do. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:28:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:28:27 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125269|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi --- Created attachment 125641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125641&action=edit Bug 29083: Update article requests-related Koha::Patron methods to use relationships This patch makes Koha::Patron->article_requests use the underlying DBIC relationship and _new_from_dbic instead of a plain search. It also refactors 'article_requests_current' and 'article_requests_finished' to use ->article_requests, as well as the new methods introduced by bug 29082 for filtering. No behavior change should take place. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => SUCCESS: Tests pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:28:32 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125270|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi --- Created attachment 125642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125642&action=edit Bug 29083: (QA follow-up) Remove unused param Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:28:37 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125271|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi --- Created attachment 125643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125643&action=edit Bug 29083: Fix OPAC listing of article requests This patch makes the OPAC template reuse a precalculated value for the active article requests for the patron (and its count). The original code relied on the methods returning a list, which is not the case for _new_from_dbic until bug 28883 is pushed. This patch fixes that. Note: there was an odd behavior when ArticleRequests was enabled but no active article requests were present: the tab wasn't rendered but the 'empty table' with the 'You have no article requests currently.' message was displayed below the Checkouts tab. I'm not sure that was caused by this patches, or other. Fixed on this patch. To test: 1. In the OPAC, go to 'your summary' => FAIL: Things don't show for article requests 2. Add some article requests and repeat 1 => FAIL: Something's wrong there 3. Apply this patch and repeat 1 => Yes! Things show correctly! 4. Cancel all your article requests => SUCCESS: Things render as they should 5. Re-enter the 'your summary' page (to force re-rendering) => SUCCESS: Things render correctly for empty article requests 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:59:38 +0000 Subject: [Koha-bugs] [Bug 29156] New: File missing warning in Koha::UploadedFile should be for permanent files only Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Bug ID: 29156 Summary: File missing warning in Koha::UploadedFile should be for permanent files only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 00:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 22:59:48 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:01:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:01:26 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to update and create biblio record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7613 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:01:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:01:26 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:01:59 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to update and create biblio record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #1 from Fridolin Somers --- Maybe this is close to svc/import_bib from Bug 7613 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:03:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:03:05 +0000 Subject: [Koha-bugs] [Bug 29157] New: REST API - cannot update patron & leave date_of_birth null Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 Bug ID: 29157 Summary: REST API - cannot update patron & leave date_of_birth null Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: ephetteplace at cca.edu Created attachment 125644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125644&action=edit diff of patron record after REST PUT action I noticed when trying to update patrons with a Python script that Koha set everyone's birthday to the current date. For each patron, I sent a Python dict where patron['date_of_birth'] was None (Python's null value). I can send an ISO 8601 date and DOB updates appropriately but I cannot find a way to leave the date empty, which is desirable (we don't care about age). Here's what I tried: date_of_birth = '' (empty string) date_of_birth = "null" date_of_birth = "undef" All these receive the same formatting error response: 400 Response {'errors': [{'message': '/anyOf/0 Does not match date format.', 'path': '/body/date_of_birth'}], 'status': 400} As I said, setting birthdate to None (which translates to `null` in JSON) updates the DOB to the current date, which I don't think makes sense since it's a nullable field in the database. I'll attach a diff of a minimal test patron where I added a "1" to their cardnumber and did nothing else. The steps were: - create a minimal patron record (e.g. with email, userid, names) - HTTP GET $API/patrons/username=$USERNAME (I did not test HTTP GET $API/patrons/$BORROWERNUMBER but I assume it works the same) - update cardnumber e.g. patron['cardnumber'] = patron['cardnumber'] + 1 - PUT $API/patrons/$BORROWERNUMBER with json=patron A few fields other than cardnumber changed. Both last_seen and updated_on make sense, I find it odd date_renewed was set to the current date since I was not renewing the patron but that's at least not problematic in our use case. It's the DOB I'd like to avoid updating, though. Let me know if I can provide more example data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:10:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:10:30 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:10:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:10:35 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 --- Comment #1 from Fridolin Somers --- Created attachment 125645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125645&action=edit Bug 29156: File missing warning in Koha::UploadedFile for permanent files only When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. Test plan : 1) Upload a temporary and a permanent file via Tools > Upload 2) Delete the file on server 3) Delete the two files from Tools > Upload 4) Look at warning in log files => You see only warning for permanent file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 01:43:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Oct 2021 23:43:10 +0000 Subject: [Koha-bugs] [Bug 29157] REST API - cannot update patron & leave date_of_birth null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 --- Comment #1 from Eric Phetteplace --- Small update to this - looks like DOB is not one of the fields that can be bulk updated with /cgi-bin/koha/tools/modborrowers.pl either so that makes the problem more annoying. We can't bulk update a bunch of users and then erase all the DOB data afterwards. I know ByWater could run a SQL query for us but it just adds one extra step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 08:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 06:27:21 +0000 Subject: [Koha-bugs] [Bug 29009] Attempting to Koha-restore shows unnecessary SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29009 Mike Lake changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel at speleonics.com.au --- Comment #2 from Mike Lake --- I can confirm that this patch removed that error for me using Debian 11.0 and koha-common 21.05.04-1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 08:52:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 06:52:54 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Please enter assignee, future RM :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 08:57:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 06:57:28 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #98 from Marcel de Rooy --- But rhetorical questions dont need an answer ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 10:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 08:43:22 +0000 Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 10:43:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 08:43:25 +0000 Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125460|0 |1 is obsolete| | Attachment #125461|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 125646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125646&action=edit Bug 29133: Correct select2 strings We are using 'max'/'min' when the arguments are 'maximum'/'minimum'. Also using %n, %d when only %s is working in .format() Have a look at https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js It's Select2 v.4.0.13, the one we are using. We should match what's there. Test plan: Bug 29002 is using minimumInputLength, you can see the difference when selecting a patron: "Please enter %s or more characters" vs "Please enter 3 or more characters" Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 10:43:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 08:43:30 +0000 Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 --- Comment #6 from Joonas Kylmälä --- Created attachment 125647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125647&action=edit Bug 29133: (follow-up) Fix for argument mismatch Signed-off-by: Martin Renvoize JK: fix typo in commit message Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 10:43:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 08:43:48 +0000 Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 11:11:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 09:11:41 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #3 from Fridolin Somers --- Oups, corrected :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 12:06:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 10:06:07 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #7 from Joonas Kylmälä --- I was checking up what old bug reports I have done and came across this. Definitely a bug in the community version as well and a bug that still exists to this day! Seems pretty major as these are the prices you might send via EDI to the vendor. The bug is probably hard to reproduce but if you read the code you see the problem clearly. The GetImportRecordsRange function might return the imported records in whatever order and we are not matching them in anyway with the parameter data we are getting here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 12:14:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 10:14:26 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 12:43:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 10:43:42 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|upgrade jquery version |Upgrade jquery version CC| |oleonard at myacpl.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 12:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 10:51:11 +0000 Subject: [Koha-bugs] [Bug 29157] REST API - cannot update patron & leave date_of_birth null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 13:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 11:55:10 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #2 from Katrin Fischer --- ... and why don't we use the internal id? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 14:11:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 12:11:58 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #8 from Joonas Kylmälä --- So this turned out to be tricky to reproduce but I finally found at least one bug where this happens! So if there is a duplicate matched then we have not shifted away for the previous biblio to be added the replacement and price parameters: > replacementprice => shift( @orderreplacementprices ), > my $price= shift( @prices ) || GetMarcPrice($marcrecord, C4::Context->preference('marcflavour')); So when the line: > $duplinbatch = $import_batch_id and next if $duplifound; is called we are leaving the shifts undone. I wonder if we should go with the originally proposed patch here or just move the shifts to the beginning. If we just move the shifts to the beginning then I feel like it could be a bit more prone to someone re-introducing this bug later if a new field is added. To reproduce this bug: 1) Download two records from koha to marcxml file, then cat those cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Add new basket -> import from a staged file 5) Select both bib1 and bib2 and set price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong price, 99.00!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 14:39:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 12:39:07 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 14:39:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 12:39:12 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43364|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä --- Created attachment 125648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125648&action=edit Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 14:44:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 12:44:03 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi --- Comment #10 from Joonas Kylmälä --- Adding Emmi to CC here since you are using the original patch submitted here 6 years ago. I think this should fix now all problems and if this is merged you should be able to drop the original patch so if you could sign-off that would be nice :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:26:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:26:25 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- It groups the entries together. Like you have news_1 that is translated in different languages, the code will be the same for the different rows and the system will know they represent the same content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:26:54 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #4 from Jonathan Druart --- It's the same behaviour we have for notice templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:32:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:32:38 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #5 from Katrin Fischer --- I wonder if we could not do better solving this with an additional ID or generated code instead of relying on user entry here if that's the only use case. But if we keep it, should we not make it visible in the table too? For the notices the code is also used in the code, so we have to rely on the codes being right for activating/deactivating the functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:46:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:46:59 +0000 Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:47:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:47:03 +0000 Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125453|0 |1 is obsolete| | Attachment #125568|0 |1 is obsolete| | --- Comment #11 from Joonas Kylmälä --- Created attachment 125649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125649&action=edit Bug 29134: Use a subquery to increase performance of patron attributes search This patch generates a subquery and checks if a borrowrnumber is in the results to add patrons to search results To test: 1 - Generate a bunch of patrons: SELECT surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT categorycode FROM borrowers ORDER BY rand() ) d LIMIT 50000 2 - Add a patron attribute to the system and make it searchable - I used code 'TEST' 3 - Add a value for this attribute to many patrons: INSERT INTO borrower_attributes (borrowernumber,code,attribute) SELECT borrowernumber, 'TEST','alphabet' FROM borrowers LIMIT 10000; 4 - In staff client got 'Patrons' 5 - Open the browser console (F12) and view the netwrok tab 6 - Perform a patron search for 'a' 7 - Note the time it takes for 'search' to complete in console 8 - Apply patch, restart_all 9 - Repeat search 10 - Note it is much faster 11 - prove -v t/db_dependent/Utils/Datatables_Members.t NOTE: I tested with 500k patrons and 100k attributes - search returned in ~2 seconds with patch and did not return before I got impatient without patch Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 15:47:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 13:47:35 +0000 Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 16:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 14:06:30 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #8 from Joonas Kylmälä --- (In reply to Fridolin Somers from comment #7) > Looks great. > > But : > Koha/Item.pm > - : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " > . Dumper( $self->unblessed ) ); > + : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " > . $self ); > > This is a string concatenation, seems wrong. Yup, it's a bug. Marking as FQA to get Petro's attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:00:22 +0000 Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:00:27 +0000 Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124977|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 125650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125650&action=edit Bug 29041: Improve specificity of breadcrumbs in Additional Contents This patch adds a link to news or HTML customizations in the breadcrumbs navigation depending on which category of content you're adding or editing. To test, apply the patch and go to Tools -> News. - Begin the process of adding a news item. - In the breadcrumbs menu you should see: Additional contents > News > Add additional content - Clicking "News" should return you to the view of news items. - Test the same process in "HTML customizations." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:00:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:00:33 +0000 Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125368|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 125651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125651&action=edit Bug 29041: (follow-up) Expand the scope of changes This patch expands the scope of the original changes to add consistency to the non-edit views. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:00:53 +0000 Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041 --- Comment #7 from Katrin Fischer --- Nice improvement - thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:15:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:15:13 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #8 from Katrin Fischer --- I've also tested the ordering, receiving, adding and batch modifying items in cataloguing and adding items from the serial module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:16:18 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:16:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:16:22 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125601|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 125652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125652&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:16:27 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125602|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 125653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125653&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:16:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:16:32 +0000 Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125603|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 125654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125654&action=edit Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:22:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:22:25 +0000 Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 --- Comment #3 from Katrin Fischer --- Almost sad to see this line removed :)
[%# FIXME We should remove list-style:none; and use class="rows" here but it does not work. Owen please help! %]> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:23:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:23:49 +0000 Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:23:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:23:54 +0000 Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in Additional Contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125403|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 125655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125655&action=edit Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:32:48 +0000 Subject: [Koha-bugs] [Bug 29158] New: Web installer fails to load account_offset_types.sql Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Bug ID: 29158 Summary: Web installer fails to load account_offset_types.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, martin.renvoize at ptfs-europe.com There is an error running the web installer on current master: account_offset_types.sql Something went wrong loading file /home/vagrant/kohaclone/installer/data/mysql/mandatory/account_offset_types.sql (Couldn't read '/home/vagrant/kohaclone/installer/data/mysql/mandatory/account_offset_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 174. ) at /home/vagrant/kohaclone/C4/Installer.pm line 584. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:37:07 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:37:12 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #4 from Katrin Fischer --- Created attachment 125656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125656&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:38:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:38:13 +0000 Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:38:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:38:19 +0000 Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125502|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 125657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125657&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=28982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:38:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:38:39 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 22:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 20:40:26 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from Katrin Fischer --- This appears to work quite well, but there is a small glitch I am wondering about: * Onboarding, where you set up a patron category * Set an until date for the expiration date * The date in the input field shows in the database format (2021-10-19) * Below is a format with: (MM/DD/YYYY) Could you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:10:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:10:08 +0000 Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 --- Comment #44 from Katrin Fischer --- Hi Kyle, it looks like you left the atomic update file / forgot moving it to updatedatabase.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:37:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:37:56 +0000 Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- I am sorry, but the table configuration is broken with this patch applied and the preference set to "don't record". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:38:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:38:40 +0000 Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out by field in Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #6 from Katrin Fischer --- Uncaught TypeError: b.settings()[0].aoColumns[d] is undefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:42:04 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:42:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:42:08 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125221|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 125658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125658&action=edit Bug 28919: Select logged in library as pickup for multi holds When placing multiple holds from the result list, the pick-up location is empty now, which makes it a more tedious process than it needs to be. Logged in library must be selected to match the single hold logic. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:45:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:45:22 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer --- Ok, this works as I think it should, pre-selecting the right branch. BUT: When you try to save the holds, it complains: Please make sure all selected titles have a pickup location set If you switch the pick-up location to another, they will all be set below as well. So I think we do not only need to pre-select for the one on top, but for all holds displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:55:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:55:40 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #5 from Katrin Fischer --- There was no test plan... Should these files be updated as well? debian/templates/plack.psgi:use Koha::DateUtils; t/db_dependent/Circulation/IsItemIssued.t:use Koha::DateUtils; t/db_dependent/Items.t:use Koha::DateUtils; t/db_dependent/Koha/SearchEngine/Indexer.t:use Koha::DateUtils; t/db_dependent/Koha/Template/Plugin/TablesSettings.t:use Koha::DateUtils; t/db_dependent/Log.t:use Koha::DateUtils; t/db_dependent/SIP/ILS.t:use Koha::DateUtils; t/db_dependent/Search/History.t:use_ok('Koha::DateUtils'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 2 23:58:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 21:58:23 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer --- Can you please rebase? CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 00:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 22:00:27 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 00:06:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 22:06:15 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 00:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 22:06:42 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 00:06:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Oct 2021 22:06:46 +0000 Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125637|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 125659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125659&action=edit Bug 28717: Fix additional content logs The logging for additional contents added by bug 26205 has been broken by but 22544. This patch is a revisited version as bug 24387 has been pushed. It does not log MODIFY if no modification has been made on a template (useful when only 1 version/lang of a content has been modified) Test plan: Turn on NewsLog Add/modify and delete additional contents/News and confirm that modification are logged. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 09:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 07:27:37 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi Status|Signed Off |Patch doesn't apply --- Comment #79 from Joonas Kylmälä --- Doesn't apply anymore :| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:21:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:21:11 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:29:35 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:29:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:29:38 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125634|0 |1 is obsolete| | Attachment #125635|0 |1 is obsolete| | --- Comment #12 from Joonas Kylmälä --- Created attachment 125660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125660&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:29:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:29:42 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #13 from Joonas Kylmälä --- Created attachment 125661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125661&action=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:29:46 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #14 from Joonas Kylmälä --- Created attachment 125662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125662&action=edit Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:29:49 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #15 from Joonas Kylmälä --- Created attachment 125663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125663&action=edit Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:31:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:31:55 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #16 from Joonas Kylmälä --- Looks good to me, passing QA. Aleisha, btw, please in the future don't add unrelated changes to the same commit, ("xml_escape" -> "C4::Koha::xml_escape"), it takes more reviewer's time when the change is not explained and it makes harder to backport the patch to stable releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:35:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:35:04 +0000 Subject: [Koha-bugs] [Bug 29159] New: UNIMARC update from IFLA for new Koha installations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159 Bug ID: 29159 Summary: UNIMARC update from IFLA for new Koha installations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org Hello! Field 181, 182, 183 UNIMARK contains encoded data. It is now a simple text box. Please, add "Tag editor". https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_181_new2016.pdf https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_182_new2016.pdf https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_183_new2016.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 10:39:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 08:39:35 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #10 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #8) > hmm, this disables the hide_patron_infos_if_needed variable which is > probably not wanted, though the feature is quite broken anyways but this > makes it more broken. Just to make it clear and try to get this moving here, I'm holding off from signing-off on this until we have some clarity to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:02:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:02:13 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:02:16 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125573|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä --- Created attachment 125664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125664&action=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:47:59 +0000 Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:48:01 +0000 Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124320|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 125665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125665&action=edit Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. Test plan: - Enable the system preference PatronSelfRegistration - Make sure PatronSelfRegistrationBorrowerUnwantedField does not contain cardnumber. - Set the system preference GDPR_Policy to "Enforce". - In the OPAC click "Log in to your account" and "Register here". - Fill out the form with valid data, but make sure you leave the checkbox under "GDPR consent" unchecked. - Submit the form - You will get back the form with the error message "You have not filled out all required fields. Please fill in all missing fields and resubmit." - Without patch: cardnumber is not editable, and there is no input element for borrower_cardnumber (so the cardnumber will be lost when resubmitting the form) - With patch: cardnumber is editable. Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:50:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:50:05 +0000 Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #4 from Joonas Kylmälä --- Passing QA. This bug was actually "Fixed" already by bug 28934 which was pushed just recently but this fixes the situation where a librarian changes the Opac registration form mandatory values after the patron doing the registration has already loaded the registration page. So if GDPR option became mandatory whilst the patron was inputting the registration info this fixes it now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 11:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 09:50:15 +0000 Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:06:02 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi --- Comment #29 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #26) > OK, I think we're all done now. > > I restored the label, but made it a visually hidden one inside the check > column for accessibility and I made the whole table cell clickable for the > checkbox to restore the larger click handling area. Hmm, I'm not able to do this still even with this patch (firefox esr on debian 11). Could you double-check it works and if it does could you explain me how to test more specifically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:06:24 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:08:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:08:22 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124819|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 125666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125666&action=edit Bug 28180: Fix bug with AdLibris If Adlibris is first and there is no image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:22:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:22:54 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala at iki.fi --- Comment #7 from Joonas Kylmälä --- Looks good but missing unit test and fails QA script: * Commit title does not start with 'Bug XXXXX: ' - b73fd7c915 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:58:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:58:46 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:59:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:59:45 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:59:48 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123444|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 125667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125667&action=edit Bug 28303: Add unit test for badtemplatecheck This tests that pluginsdir value is not modified by the call to badtemplatecheck to make sure badtemplatecheck operates with its own copy of pluginsdir configuration value. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 12:59:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 10:59:52 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #9 from Joonas Kylmälä --- Created attachment 125668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125668&action=edit Bug 28303: Fix plugins system with multiple pluginsdir settings C4/Templates::badtemplatecheck mucks with the config('pluginsdir') array ref. This makes sure it operates on a copy of the array. To test: 1) $ prove t/db_dependent/Templates.t Signed-off-by: David Nind JK: Fix commit message styling and add test plan Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 13:00:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 11:00:26 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #10 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #7) > Looks good but missing unit test and fails QA script: > > * Commit title does not start with 'Bug XXXXX: ' - b73fd7c915 I added the unit test and fixed the commit title. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:12:48 +0000 Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #11 from Katrin Fischer --- Thank you, Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:32:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:32:47 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124437|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 125669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125669&action=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:32:51 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #4 from Joonas Kylmälä --- Created attachment 125670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125670&action=edit Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced The original patch "Bug 24698: Add plugin and template files for unimarc authority leader" doesn't work without explictly importing the methods from C4::Auth and C4::Output due to the default exports being changed in those modules after the patch was made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:32:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:32:55 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #5 from Joonas Kylmälä --- Created attachment 125671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125671&action=edit Bug 24698: (QA follow-up) Remove debug info being outputted to the template This is only needed during development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:32:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:32:58 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #6 from Joonas Kylmälä --- Created attachment 125672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125672&action=edit Bug 24698: (QA follow-up) Align variables with whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:02 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #7 from Joonas Kylmälä --- Created attachment 125673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125673&action=edit Bug 24698: (QA follow-up) Remove dead code These were left off from the copy&paste taken from unimarc_field_100_authorities.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:06 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #8 from Joonas Kylmälä --- Created attachment 125674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125674&action=edit Bug 24698: (QA follow-up) Fix formatting and typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:10 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #9 from Joonas Kylmälä --- Created attachment 125675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125675&action=edit Bug 24698: (QA follow-up) Remove passing of authnotrequired parameter It should only be used when we want to override the default of auth being required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:13 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #10 from Joonas Kylmälä --- Created attachment 125676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125676&action=edit Bug 24698: (QA follow-up) Make plugin script executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:17 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #11 from Joonas Kylmälä --- Created attachment 125677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125677&action=edit Bug 24698: (QA follow-up) Use spaces instead of tabs This makes the QA script happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:21 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #12 from Joonas Kylmälä --- Created attachment 125678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125678&action=edit Bug 24698: (QA follow-up) Filter untrusted input to prevent XSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:25 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #13 from Joonas Kylmälä --- Created attachment 125679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125679&action=edit Bug 24698: (QA follow-up) Don't specify select element's size if it is 1 This is to make the QA script happy, in order to not to break Bootstrap CSS rules, see Bug 28066 for more info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:33:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:33:29 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #14 from Joonas Kylmälä --- Created attachment 125680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125680&action=edit Bug 24698: (QA follow-up) Don't specify script type explictly It's makes the QA script complain because the option doesn't have any effect nowadays: https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-obsolete-but-conforming-features -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 14:37:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 12:37:17 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi |y.org | CC| |joonas.kylmala at iki.fi --- Comment #15 from Joonas Kylmälä --- Don't mind the follow-ups ;D I'm willing to Pass QA after checking one thing that is unclear to me: The spec from that ifla.org website only defines as possible values for "9 Type of entity" the letters a-l but here this adds the option for "Series" with an blank value (space). Is this supposed to be allowed? Where is it mentioned as being a possible value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:27:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:27:56 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:28:01 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123201|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 125681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125681&action=edit Bug 28720: Update the process of adding a checkout note in the OPAC This patch moves the entry of checkout notes into a modal window with the goal of making note entry easier. To test, apply the patch and make sure the AllowCheckoutNotes system preference is enabled. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, confirm that the table listing your checkouts has a "Report a problem" column with "Add note" buttons. - Click an "Add note" button. A modal window should be shown which includes the title of the item, a textarea for writing a note, and a hint, "Your note will be shown to the librarian when the item is checked in." - Add a note and submit it. - The modal should close and a note at the top of the page should tell you your note has been saved. The contents of your note should be shown below that along with an "Edit note" link. - Confirm that the "Edit note" link works as expected. - Confirm that the "Add note" button you clicked in the table of checkouts now reads "Edit note." - You should be able to click this button and edit your note. - Confirm that each note button works to add a note to the correct title. - Confirm that the "Renew selected" and "Renew all" controls work. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:28:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:28:06 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124631|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 125682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125682&action=edit Bug 28720: (follow-up) Improve string translation This patch fixes the following issues raised by QA: - It modifies the markup so that "Add note" and "Edit note" can be translated more easily. - It adds display of existing notes back to the table of checkouts. - It adds to the table configuration so that a "plain" view of the notes (without buttons) is shown in print view and in CSV export. - It improves handling of notes containing quotation marks which would previously have broken some edit interactions. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:35:33 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:35:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:35:37 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123913|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 125683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125683&action=edit Bug 27725: Use JavaScript to set history state during patron search This patch modifies the patron search page so that clicks on the "Browse by last name" letters add an entry to the browser history, allowing the user to click back and forth from results while preserving their search. To test, apply the patch and go to Patrons in the staff interface. - Click one of the "Browse by last name" letters. - The table of search results should load the correct data. - In the browser's location bar you should see a query string added to the URL, e.g. /cgi-bin/koha/members/members-home.pl?firstletter=Q - Click another letter. - Click the back button. You should be returned to the search results for your first letter choice. - Clicking the forward button should work correctly as well. - Other patron searches (header search, sidebar search) should continue to work as expected. EDIT: Clear single-letter querystring history item if only one result was returned. EDIT 2: Fixed handling of history state changes so that forward and back buttons work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 16:36:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 14:36:07 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 --- Comment #12 from Katrin Fischer --- Nice improvement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 17:05:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 15:05:05 +0000 Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 17:05:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 15:05:10 +0000 Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125398|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 125684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125684&action=edit Bug 28321: Use template block for display of items in search results This patch updates the staff interface catalog search results to use a new reusable BLOCK for displaying item information: Available items, checked-out items, and unavailable items. Some style has been updated, and an old GIF image has been replaced with an SVG. The hold ratios template has been updated to accommodate this change. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the staff interface which will return multiple results with multiple items each. For thorough testing, some records should have items which are checked out, available, or lost/notforloan. - On the search results page, confirm that item information is accurate and readable. - Test with item-level_itypes on and off. - Test with noItemTypeImages on and off. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 3 17:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 15:20:13 +0000 Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Katrin Fischer --- No problems spotted, can you please add my sign-offs as well? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 01:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 23:13:32 +0000 Subject: [Koha-bugs] [Bug 29157] REST API - cannot update patron & leave date_of_birth null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Tomás Cohen Arazi --- I confirm the bug exists. Will take a look tomorrow. It affect date/date-time attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 01:13:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Oct 2021 23:13:56 +0000 Subject: [Koha-bugs] [Bug 29157] Cannot set date/date-time attributes to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29157 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API - cannot update |Cannot set date/date-time |patron & leave |attributes to NULL |date_of_birth null | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 04:17:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 02:17:13 +0000 Subject: [Koha-bugs] [Bug 29160] New: Default Framework Report Yields Empty Download Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29160 Bug ID: 29160 Summary: Default Framework Report Yields Empty Download Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: cmkelleymls at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 125685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125685&action=edit Shows missing downloaded report for default framework I have created a report for getting a list of bibliographic reports based on the framework. Here's the SQL instruction: SELECT biblio.biblionumber AS 'Bib. Record No.', biblio.author AS 'Author', biblio.title AS 'Title' FROM biblio WHERE biblio.frameworkcode = <> ORDER BY biblio.biblionumber ASC This instruction yields a report in the website. But when I check the Download button and/or when I select a new page" in a multipage list AND the choosen framework is the default, the downloaded list is empty excepting for the list headers. This happens to all three download file options: CSV, TAB, and ODS. In contrast, when another framework is choosen, the downloaded list includes all the findings; and list continues onto the next page when another page number is choosen. A PDF of screenshots collected is attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 07:34:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 05:34:40 +0000 Subject: [Koha-bugs] [Bug 29161] New: Holds to pull should show item level holds only if available Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 Bug ID: 29161 Summary: Holds to pull should show item level holds only if available Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Holds to pull list shows now item level hold on the list if there are other items available. Item level hold should show on the list only when requested item is available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 10:45:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 08:45:51 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #11 from Emmi Takkinen --- (In reply to Joonas Kylmälä from comment #10) > Adding Emmi to CC here since you are using the original patch submitted here > 6 years ago. I think this should fix now all problems and if this is merged > you should be able to drop the original patch so if you could sign-off that > would be nice :) We no longer use this feature (most libraries are now using EDitX etc). But I'm happy sign-off nonetheless as soon as I have time :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 10:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 08:55:14 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #6 from Jonathan Druart --- Created attachment 125686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125686&action=edit Bug 28931: Remove unuse Koha::DateUtils from tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 10:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 08:56:09 +0000 Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > There was no test plan... It's impossible to provide a full test plan for this kind of patches. If the QA script passes it's already a good step for this one, as the compilation will be checked. > Should these files be updated as well? > t/db_dependent/Circulation/IsItemIssued.t:use Koha::DateUtils; > t/db_dependent/Items.t:use Koha::DateUtils; > t/db_dependent/Koha/SearchEngine/Indexer.t:use Koha::DateUtils; > t/db_dependent/Koha/Template/Plugin/TablesSettings.t:use Koha::DateUtils; > t/db_dependent/Log.t:use Koha::DateUtils; > t/db_dependent/SIP/ILS.t:use Koha::DateUtils; > t/db_dependent/Search/History.t:use_ok('Koha::DateUtils'); We can remove the use statement as it's not used. > debian/templates/plack.psgi:use Koha::DateUtils; I don't know about this one, we preload it but without the import. I prefer to keep it like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 11:45:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 09:45:04 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #17 from Jonathan Druart --- 1. -use Koha::AuthorisedValueCategories; -use Koha::AuthorisedValues; +use Koha::AuthorisedValueCategory; +use Koha::AuthorisedValue; Joonas, Aleisha was correct. We load the plurals modules, which will load the singulars. 2. I first got the tests fail: # Failed test 'Authorised value is correctly parsed to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 617. # got: 'CODE' # expected: 'Description should show' # Failed test 'Authorised value is correctly parsed for OPAC to show description rather than code' # at t/db_dependent/Koha/Biblio.t line 624. # got: 'CODE' # expected: 'Description should show OPAC' # Looks like you failed 2 tests of 13. After a restart_all they passed. We should deal with the cache. 3. - $value = GetAuthorisedValueDesc( $tag, $letter, $value, '', $tagslib ) + $value = GetAuthorisedValueDesc( $tag, $letter, $value, $frameworkcode, $tagslib, undef, $opac ) Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode (especially when it's used at 75 my $av = getAuthorisedValues4MARCSubfields($frameworkcode)), but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 11:45:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 09:45:51 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #18 from Jonathan Druart --- About 3. actually GetAuthorisedValueDesc does not case about $framework (it does not do anything with it). To prevent confusion we should not modify it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 11:51:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 09:51:39 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #19 from Jonathan Druart --- Created attachment 125687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125687&action=edit Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Remove uneeded C4::Koha:: prefix 3. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 11:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 09:52:03 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > 2. I first got the tests fail: Hum, cannot longer recreate that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 11:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 09:52:29 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #21 from Jonathan Druart --- Patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:14:56 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:15:01 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125591|0 |1 is obsolete| | --- Comment #13 from Ere Maijala --- Created attachment 125688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125688&action=edit Bug 29135: Fix handling of deleted items in OAI-PMH provider Test plan: 1. Make sure this scenario now works properly: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0 2. Run prove -v t/db_dependent/OAI/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:17:56 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #14 from Ere Maijala --- David, Oops, silly me. I somehow thought it was clever that I made the timestamps start from an hour ago. This was fine until you created a dev box and ran the tests in an hour.. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:27:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:27:15 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125648|0 |1 is obsolete| | --- Comment #12 from Emmi Takkinen --- Created attachment 125689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125689&action=edit Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:27:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:27:22 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:34:15 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #16 from George Veranis --- No it is not allowed base ifla instructions you are right. I forgot to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:36:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:36:47 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #99 from Jonathan Druart --- Created attachment 125690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125690&action=edit Bug 27945: (follow-up) Clarify 'same day' behavior Don't use MySQLism -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:37:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:37:48 +0000 Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:42:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:42:07 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #100 from Jonathan Druart --- Why is it a category's attribute and not a circ rule? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:45:49 +0000 Subject: [Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 --- Comment #12 from Jonathan Druart --- Created attachment 125691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125691&action=edit Bug 29082: Simplify tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:48:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:48:02 +0000 Subject: [Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #19 from Jonathan Druart --- Same as bug 29084 comment 8. I don't think we need $patron->article_requests_finished, callers can $patron->article_requests->filter_by_finished (or ->finished as the filter_by methods are not correctly named in this module). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:55:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:55:51 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 12:55:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 10:55:56 +0000 Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122782|0 |1 is obsolete| | --- Comment #9 from Peter Vashchuk --- Created attachment 125692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125692&action=edit Bug 28692: log without indentation to decrease DB action_log table size Indentation symbols like spaces and newlines take up a large amount of extra space. Example: fully indented action_log item MODIFY record weighs from 1.6 to 370 KB while the version of it without any indentation takes 1.1 to 46 KB accordingly. This changes logaction subroutine to perform a special transformation, if$info came as known object, that adds Indent(0) parameter of Data::Dumper to output without indentation. To reproduce for item: 1) edit any item you see fit, save it. 2) check the action_logs table and find there a newly created MODIFY item row, "info" column of that contains dumped data, see that it has indentation, optional: check and note about the size of it. 3) apply the patch. 4) edit that item again and save it afterwards. 5) "info" column of the newly created row should contain non-indented text now. If you did check the size of the previous dump, compare it with this new one, check the difference it makes. To reproduce for hold: 1) in syspref set HoldsLog to Log. 1) go to the biblio page and suspend and resume any hold you see fit. 2) check the action_logs table and find there a newly created SUSPEND item row, "info" column of that contains dumped data, see that it has indentation, optional: check and note about the size of it. 3) apply the patch. 4) edit that item again and save it afterwards. 5) "info" column of the newly created row should contain non-indented text now. If you did check the size of the previous dump, compare it with this new one, check the difference it makes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 13:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 11:15:06 +0000 Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #10 from Owen Leonard --- (In reply to Katrin Fischer from comment #9) > No problems spotted, can you please add my sign-offs as well? :) Remote branch updated to add Katrin's signoff. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 14:28:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 12:28:38 +0000 Subject: [Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Agreed, that's an unfortunate oversight. Right now, cancelling a hold from the bib record pops up a modal that asks for a reason. On the other hand, if you're cancelling from the patron record you're given a dropdown with which to pick a reason before clicking cancel. Which option do you think would be more helpful here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 14:29:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 12:29:38 +0000 Subject: [Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to specifying and store a reason when cancelling a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 14:29:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 12:29:38 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154 [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:08:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:08:46 +0000 Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart --- Regression found: if you are using the patron search in the header, the search is not triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:20:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:20:26 +0000 Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- Shouldn't the input in the modal have the focus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:23:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:23:53 +0000 Subject: [Koha-bugs] [Bug 29162] New: Change template structure on OPAC library page so that a single library can easily be hidden Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162 Bug ID: 29162 Summary: Change template structure on OPAC library page so that a single library can easily be hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org At the moment the structur of the OPAC libraries page doesn't allow to change the information of one library easily or to hide one library using an id or similar as there is no "wrapping" HTML element for each entry. It would be nice if a div or span could be added around each library element + hr. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:30:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:30:40 +0000 Subject: [Koha-bugs] [Bug 29163] New: Lost items should optionally be excluded from automatic renewals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29163 Bug ID: 29163 Summary: Lost items should optionally be excluded from automatic renewals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If an item cannot be renewed for some time (there is a hold) and it remains checkout out until it is lost, when the blocking status is removed (hold is filled or cancelled) the item could be renewed again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:37:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:37:34 +0000 Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- Question (not related only to this patch, but other flatpickr ones as well): Why don't you set the flatpickrto class when needed? For instance: + var billingdatefrom = $("#billingdatefrom").flatpickr({ + onClose: function( selectedDates, dateText, instance) { + validate_date( selectedDates, instance ); + billingdateto.set('minDate', selectedDates[0]); + } + }); + var billingdateto = $("#billingdateto").flatpickr({ + onClose: function( selectedDates, dateText, instance) { + validate_date( selectedDates, instance ); + }, + }); You need billingdatefrom, but you could use .flatpickrto for #billintdateto. Also I think we could improve it a bit more, .flatpickrfrom could have a data containing the name of its "to". We could only have: And a couple of line in calendar.inc to link them. I won't ofc block this patch series for that, but it would be great to have a follow-up bug on top to clean it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:53:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:53:42 +0000 Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125484|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 125693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125693&action=edit Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 15:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 13:54:31 +0000 Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #12 from Jonathan Druart --- Adjusted patch's author, as agreed with Jeremy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:00:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:00:40 +0000 Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125693|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 125694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125694&action=edit Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:31:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:31:29 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:31:32 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #6 from Jonathan Druart --- Created attachment 125695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125695&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:32:17 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:42:01 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:32 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:41 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:45 +0000 Subject: [Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:49 +0000 Subject: [Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:51 +0000 Subject: [Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:43:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:43:54 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:44:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:44:13 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:44:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:44:21 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:44:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:44:23 +0000 Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:48:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:48:19 +0000 Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Jonathan Druart --- I haven't done it in the first iteration because it's a bit tricky. A user who enqueued a job should be able to access to page, and view their jobs. Should we have the view available for any staff users? Only those with admin access? Otherwise we need to list the permissions of the different pages that allow background jobs. But I don't like this solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:49:23 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125695|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 125696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125696&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:51:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:51:10 +0000 Subject: [Koha-bugs] [Bug 29164] New: MARC21: Result page display empty Square brackets when 711 $e is filed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29164 Bug ID: 29164 Summary: MARC21: Result page display empty Square brackets when 711 $e is filed Change sponsored?: --- Product: Koha Version: 21.05 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: marion.durand at biblibre.com QA Contact: testopia at bugs.koha-community.org Created attachment 125697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125697&action=edit An instance of the bug In the results page of search the catalog (both in the opac and the staff interface), I notice a stage behavior for field 711. When $e is filed koha display square bracket even when there is nothing inside ($j and $4 are empty) Example: 711 $aMostly Mozart Festival $eOrchestra result: Orchestra Mostly Mozart Festival []. behavior check on master 21.05 Test plan: 1- Be sure to use koha with MARC21 2- Find or create a record with a 711 $e field but no 711 $j and no 711 $4 3- Search the catalog for your record (be sure to have more than one result) 4- On the results page see that empty square bracket are displayed after 711 field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:53:11 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:53:15 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117346|0 |1 is obsolete| | Attachment #117347|0 |1 is obsolete| | Attachment #122035|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 125698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125698&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Michael Sutherland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:53:18 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #13 from Nick Clemens --- Created attachment 125699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125699&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Michael Sutherland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:53:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:53:21 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #14 from Nick Clemens --- Created attachment 125700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125700&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 16:53:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 14:53:25 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #15 from Nick Clemens --- Created attachment 125701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125701&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:29 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:34 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:38 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:42 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125690|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:46 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:49 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:53 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:13:57 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:01 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125143|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:05 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:09 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125145|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:12 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:16 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:19 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:23 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:14:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:14:26 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:22 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #101 from Tomás Cohen Arazi --- Created attachment 125702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125702&action=edit Bug 27945: Add tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:29 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #102 from Tomás Cohen Arazi --- Created attachment 125703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125703&action=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Edit: This patchset originally changed the 'categories' table structure and relied on that for limit calculation. I removed all that code and squashed into this one, as we moved everything to the circulation_rules table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:37 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #103 from Tomás Cohen Arazi --- Created attachment 125704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125704&action=edit Bug 27945: Clarify 'same day' behavior This patch introduces tests for the 'same day' check of the ability to place article requests for a patron. The limit goes against current requests, and those that have been completed on the same day. The tests cover this specific situation. The current behavior is that it takes into account a 24 hr timespan, but consensus on the QA step was that we should do it as 'same day' and use a separate feature request to change this, if required. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:44 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #104 from Tomás Cohen Arazi --- Created attachment 125705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125705&action=edit Bug 27945: Add max_daily_article_requests circulation rule Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:51 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #105 from Tomás Cohen Arazi --- Created attachment 125706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125706&action=edit Bug 27945: Implement limits using circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:15:58 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #106 from Tomás Cohen Arazi --- Created attachment 125707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125707&action=edit Bug 27945: Fix error handling and translatability This patch adds better error handling and reporting when placing an article request fails. It also makes the error messages translatable. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:19:52 +0000 Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 --- Comment #3 from Caroline Cyr La Rose --- I think superlibrarians should be able to see all background jobs. As for other users, could it be a permission? The other links in the Administration page or Tools page are all linked to permissions. We could maybe emulate the items_batchmod and items_batchmod_restricted permissions? background_jobs : access to all background jobs background_jobs_restricted : access to background jobs limited to jobs started by user ? I'm not sure what appears in that page and what are the implications of having access to it (I don't even remember in what context I had to have access to it when I wrote this bug lol!). Can we stop background jobs from there? If that is the case, should we also have a permission to stop jobs? Or is that ability implied when having access to the page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:41:31 +0000 Subject: [Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 17:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 15:41:35 +0000 Subject: [Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #4 from Owen Leonard --- Created attachment 125708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125708&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 18:25:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 16:25:06 +0000 Subject: [Koha-bugs] [Bug 29165] New: Allow patron modification request notifications to be branch specific Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29165 Bug ID: 29165 Summary: Allow patron modification request notifications to be branch specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron makes request via the OPAC to change some of their patron details librarians get a notification on the staff main page about the request. Some multi-branch systems find this confusing because they see all the requests across all the branches. It would be nice if this were filtered to only the current logged in branch. But maybe some libraries like the current behavior, so maybe this could be a system pref? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 18:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 16:34:30 +0000 Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 18:34:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 16:34:33 +0000 Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 --- Comment #3 from Owen Leonard --- Created attachment 125709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125709&action=edit Bug 28963: Use Flatpickr on calendar page This patch replaces the use of jQueryUI's datepicker widget on the Calendar page. In order to ease customization of the static calendar which shows the current calendar, I've converted the calendar.css file to SCSS. This allows us to define new SCSS variables to pass to the Flatpickr SCSS. Also changed: Removed some unecessary comments in the template. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Calendar. - Confirm that entering holidays works correctly for all types: Single, weekly, yearly, ranges, repeated ranges. - Confirm that holidays are deleted as expected. - Confirm that the colors of each type of holiday is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 18:51:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 16:51:08 +0000 Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Joonas Kylmälä --- (In reply to George Veranis from comment #16) > No it is not allowed base ifla instructions you are right. I forgot to > delete it. Could you please send a follow-up for that and sign-off the ones I did? (even though they are pretty trivial – but many in count). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 18:51:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 16:51:50 +0000 Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Nick Clemens --- If i add a new item, defining several languages on the initial save then the code is set as NULL for all entries Adding a second does the same and they are all grouped as a single entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 19:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 17:06:18 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #22 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #17) > 1. > -use Koha::AuthorisedValueCategories; > -use Koha::AuthorisedValues; > +use Koha::AuthorisedValueCategory; > +use Koha::AuthorisedValue; > > Joonas, Aleisha was correct. We load the plurals modules, which will load > the singulars. Oh, I didn't know this was the preferred way, we could add it maybe to the coding guidelines? To me it seemed more logical to always import directly the modules we are using and not trust that the other module will do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 19:35:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 17:35:52 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 19:35:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 17:35:55 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 --- Comment #6 from Owen Leonard --- Created attachment 125710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125710&action=edit Bug 28982: (follow-up) Ensure that date format is correctly checked This patch modifies the global calendar include so that it doesn't use the potentially-undefined template variable "dateformat." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 19:54:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 17:54:30 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 19:54:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 17:54:33 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123535|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 125711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125711&action=edit Bug 28816: Improve the display of multiple holds during hold process This patch updates the appearance of the "confirm holds" page, shown during the process of placing a hold for someone in the staff interface. Most of the changes affect the appearance of the page when placing multiple holds on titles which have one or more holds on them already. The changes are intended to make the page clearer and easier to scan, especially when placing multiple holds at once. Also changed: The page heading when placing multiple holds now changes based on whether you've selected a patron or not. It says "Search patrons or clubs" when it's waiting for a patron/club selection. It says "Place holds" after the patron/club has been selected. This is instead of "Confirm holds" on both pages. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and set HoldsSplitQueue to "nothing." - Perform a search in the staff client catalog and place multiple holds titles from that result set on hold for a patron. - Perform the same search and select one or more of the titles you selected before in addition to one or more titles with no holds. - After clicking the "Place hold" button you should see a page with the heading "Search patrons or clubs" showing information about existing holds. This section of the page should be clear and readable, with clear distinction between each section of information about each hold. - Test this page again under each different option for the "HoldsSplitQueue" system preference by changing the preference and reloading the page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 20:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 18:44:18 +0000 Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 20:44:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 18:44:22 +0000 Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 --- Comment #4 from Nick Clemens --- Created attachment 125712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125712&action=edit Bug 29062: (follow-up) Adjust SendCirculationAlert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 20:59:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 18:59:13 +0000 Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 --- Comment #5 from Nick Clemens --- (In reply to Marcel de Rooy from comment #3) > This might be hard to find another occurrence. > But look at this code in SendCirculationAlert > This should no longer work. Fixed > > How do you know if there no other occurrences like that one? according to tools/letters.pl only CHECKIN and CHECKINSLIP have the old_issues table, infact, in printslip we don't even pass the old_issues table, but we send it using the 'loops' parameter I added a patch that fixes that call, I could find no others, and we don't indicate support elsewhere The sample notices make no use of the old_issues table, so another option would be to remove it from the options all together -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 21:06:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 19:06:33 +0000 Subject: [Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 21:29:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 19:29:00 +0000 Subject: [Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 21:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 19:29:03 +0000 Subject: [Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162 --- Comment #1 from Owen Leonard --- Created attachment 125713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125713&action=edit Bug 29162: Change template structure on OPAC library page so that a single library can easily be hidden This patch adds markup to the OPAC library page so that CSS or JS can more easily target elements of the page: - Each library is wrapped in a div, e.g.
- Classes are added to the paragraphs containing phone, fax, URL, and library description. - An ID has been added to the menu of libraries in the sidebar so that they can be targetted individually. To test, apply the patch and go to Administration -> System prefernces. - Add some testing CSS to the OPACUserCSS system preference, if necessary replacing "CPL" with a branchcode in your system: div#section_CPL, li#menu_CPL { font-size: 80%; } - In the OPAC, view the "Libraries" page. - In the view of all libraries you should see your CSS reflected in the section for that library. - In the individual library view you should see the menu item for that library affected by your custom CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 22:24:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 20:24:55 +0000 Subject: [Koha-bugs] [Bug 29166] New: Browse system logs: add itemnumber to search limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29166 Bug ID: 29166 Summary: Browse system logs: add itemnumber to search limit Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: wdeschamps at prospertx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the Browse System Logs, "Object" limits search to borrowernumber." It would be great to also have the option to limit the search to itemnumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 23:03:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 21:03:14 +0000 Subject: [Koha-bugs] [Bug 29167] New: Patron Search - Data Export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29167 Bug ID: 29167 Summary: Patron Search - Data Export Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: tgoatley at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 125714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125714&action=edit Default number does not export all data A partner library noticed that when exporting data from a patron search (Address) that the export only exports what is showing in the search results. Previously when they exported it would export all data without having to select the "All" from the quantity dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 23:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 21:48:12 +0000 Subject: [Koha-bugs] [Bug 28019] Script "process_message_queue.pl" no more accepting comma separated addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 4 23:50:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 21:50:01 +0000 Subject: [Koha-bugs] [Bug 28019] Script "process_message_queue.pl" no more accepting comma separated addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28019 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Tomás Cohen Arazi --- I found a case of passing --to with multiple addresses to runreports.pl that stopped working, and might be related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 00:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 22:33:10 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27994 --- Comment #1 from Fridolin Somers --- Looks like it is fixed by Bug 27994 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 00:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 22:33:10 +0000 Subject: [Koha-bugs] [Bug 27994] Replace obsolete title-string sorting: Reports templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27994 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28349 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 01:27:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 23:27:34 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 --- Comment #2 from Fridolin Somers --- I see it is Bug 26234 that removed : { "sType": "title-string", "aTargets" : [ "title-string" ] } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 01:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 23:27:42 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26234 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 01:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Oct 2021 23:27:42 +0000 Subject: [Koha-bugs] [Bug 26234] Default DataTables must know our own classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28349 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:03:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:03:47 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:03:58 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125411|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 125715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125715&action=edit Bug 27173: Add plugin hooks for authority record changes 2021-09-28 Updated version Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:04:12 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125412|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 125716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125716&action=edit Bug 27173: Add tests Test plan: Run t/db_dependent/Koha/Plugins/authority_hooks.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:05:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:05:39 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #7 from David Nind --- Testing notes (koha-testing-docker): - Test plan was to apply patch and run tests - Hopefully that is sufficient -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:16:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:16:53 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #14 from David Cook --- I'm not sure what I think about "Legal name" in this context. I suppose if there are any cases where they have something other than their legal name in first name when also using a preferred name it just becomes a data problem which can be fixed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:35:20 +0000 Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:35:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:35:24 +0000 Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125462|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 125717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125717&action=edit Bug 29138: Use zero instead of no in LoadSearchHistoryToTheFirstLoggedUser To test: - apply patch - set LoadSearchHistoryToTheFirstLoggedUser to 'Don't add' - confirm via sql that value=0 - confirm on OPAC that search history is not loaded to account on login Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 03:38:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 01:38:45 +0000 Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): 1. Check that LoadSearchHistoryToTheFirstLoggedUser is not working as expected when set to 'Don't add': a. Set LoadSearchHistoryToTheFirstLoggedUser to 'Add' b. In the OPAC make sure you are logged out c. Perform some searches d. Check search history is recorded by selecting "Search history" in the top-right navigation menu e. Log in as a user f. Check search history recorded (From the top-right navigation menu select Welcome, [username] > Search history) g. Search history should be populated with searches from when not logged in h. Select all then select 'Remove selected searches' i. Change LoadSearchHistoryToTheFirstLoggedUser to 'Don't add' j. Repeat from b-g k. Search history will still be shown, even though it should be empty 2. Check database to see what value is recorded: a. koha-mysql kohadev b. SQL query: select * from systempreferences where variable='LoadSearchHistoryToTheFirstLoggedUser'; c. When LoadSearchHistoryToTheFirstLoggedUser is set to 'Don't add' value = "no" 3. Apply the patch. 4. Update the database (updatedatabase) and restart services (restart_all) 5. Check value in database again from step 2 - value should now be 0 6. Repeat the steps from 1 - this time it should work as expected, that is: . When LoadSearchHistoryToTheFirstLoggedUser is set to 'Don't add' . Search history should be empty when you log in 7. Sign-off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 05:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 03:11:15 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 05:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 03:22:38 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #15 from David Nind --- 8-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 05:23:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 03:23:30 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 05:23:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 03:23:37 +0000 Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125688|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 125718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125718&action=edit Bug 29135: Fix handling of deleted items in OAI-PMH provider Test plan: 1. Make sure this scenario now works properly: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0 2. Run prove -v t/db_dependent/OAI/ Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 08:48:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 06:48:35 +0000 Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 --- Comment #8 from Marcel de Rooy --- (In reply to David Nind from comment #7) > Testing notes (koha-testing-docker): > > - Test plan was to apply patch and run tests > - Hopefully that is sufficient Thanks David. The test script proves that a plugin on top of this action works. Which is sufficient. We have been running a plugin based on this action for a year now in production. It copies the CREATE UPDATE DELETE actions to an external system where we try to reconcile authorities from several subsystems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:01:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:01:29 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Hi David, that seems to work correctly for me on master, with en-GB and dateformat=dd/mm/yyyy On which version of Koha do you see that problem? Can you recreate on a sandbox? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:02:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:02:02 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 --- Comment #4 from Jonathan Druart --- (In reply to Fridolin Somers from comment #2) > I see it is Bug 26234 that removed : > { "sType": "title-string", "aTargets" : [ "title-string" ] } Not related and not a bug, title-string has been moved to columns_settings.inc (not removed). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:02:25 +0000 Subject: [Koha-bugs] [Bug 26234] Default DataTables must know our own classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28349 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:02:25 +0000 Subject: [Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26234 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:51:49 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:51:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:51:55 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125465|0 |1 is obsolete| | --- Comment #30 from David Nind --- Created attachment 125719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125719&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:52:03 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125466|0 |1 is obsolete| | --- Comment #31 from David Nind --- Created attachment 125720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125720&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:52:21 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125467|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 125721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125721&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:52:27 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125468|0 |1 is obsolete| | --- Comment #33 from David Nind --- Created attachment 125722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125722&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:52:32 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125469|0 |1 is obsolete| | --- Comment #34 from David Nind --- Created attachment 125723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125723&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 09:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 07:55:27 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125660|0 |1 is obsolete| | Attachment #125661|0 |1 is obsolete| | Attachment #125662|0 |1 is obsolete| | Attachment #125663|0 |1 is obsolete| | Attachment #125687|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 125724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125724&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Remove uneeded C4::Koha:: prefix 3. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:03:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:03:13 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #63 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch' to see the failed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:03:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:03:30 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:23:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:23:16 +0000 Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:25:34 +0000 Subject: [Koha-bugs] [Bug 15430] MARC21: Abbreviated names missing ending . in XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15430 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand at biblibre.com --- Comment #2 from marion.durand at biblibre.com --- I think it is the same bug as Bug 28976 (or at least close to it). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:36:28 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #18 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 24370: Don't reset library when editing a suggestion Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 24370: Don't reset library when editing a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:36:46 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:56:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:56:50 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #24 from Jonathan Druart --- I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected but I failed to understand what's going on. (In reply to Joonas Kylmälä from comment #22) > (In reply to Jonathan Druart from comment #17) > > 1. > > -use Koha::AuthorisedValueCategories; > > -use Koha::AuthorisedValues; > > +use Koha::AuthorisedValueCategory; > > +use Koha::AuthorisedValue; > > > > Joonas, Aleisha was correct. We load the plurals modules, which will load > > the singulars. > > Oh, I didn't know this was the preferred way, we could add it maybe to the > coding guidelines? To me it seemed more logical to always import directly > the modules we are using and not trust that the other module will do it. For Koha::Object-based objects, all plurals needs their respective singular. It avoid to have the 2 use statements. We could indeed add that to the guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 10:57:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 08:57:39 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125724|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 125725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125725&action=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Bug 28734: (QA follow-up) Fix test imports and readability Signed-off-by: Joonas Kylmälä Bug 28734: (QA follow-up) Update documentation about function usage We are now using the function from Koha::Biblio. Signed-off-by: Joonas Kylmälä Bug 28734: Remove unadvertised changes 1. Using $frameworkcode instead of the default '' is an unadvertised change. It would make sense to use $frameworkcode, but actually we must remove this parameter and always use the default, as we decided to make the default authoritative. I would prefer to not introduce this change, just in case.. 2. Restore good import (use plurals) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:12:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:12:18 +0000 Subject: [Koha-bugs] [Bug 29168] New: Disable "Request article" links when limit is reached Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Bug ID: 29168 Summary: Disable "Request article" links when limit is reached Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Since bug 27945 we can limit article request per patron's category. However the "request article" links (detail and search views) are still active. We could disable them and add a tooltip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:12:24 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 [Bug 27945] Limit the number of active article requests per patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:12:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:12:24 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 [Bug 29168] Disable "Request article" links when limit is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:19:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:19:13 +0000 Subject: [Koha-bugs] [Bug 29169] New: Wrong "daily limit" warning when article request is not available Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169 Bug ID: 29169 Summary: Wrong "daily limit" warning when article request is not available Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org If you have reached the daily limit (bug 27945) and article request are not possible, the error will be "daily limit reached" when it should be "No article requests can be made for this record" Step to recreate: - Turn the syspref "ArticleRequests" on - Circ rule "Article requests" => No - "Default article requests limits" for your patron's category => 0 /cgi-bin/koha/opac-request-article.pl?biblionumber=1 => "You reached your article requests daily limit." The ELSIF ELSE in opac-request-article.tt need to be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:19:18 +0000 Subject: [Koha-bugs] [Bug 29169] Wrong "daily limit" warning when article request is not available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 [Bug 27945] Limit the number of active article requests per patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:19:18 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169 [Bug 29169] Wrong "daily limit" warning when article request is not available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:26:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:26:13 +0000 Subject: [Koha-bugs] [Bug 29170] New: MARC21 Field 100$t is not display in the results page and record detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29170 Bug ID: 29170 Summary: MARC21 Field 100$t is not display in the results page and record detail page Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: marion.durand at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In koha MARC21, the field 100$t is not displayed in the results page (neither in the detailed record page). In the code that display 700$t for the results page I found this: (file: ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl) ... The comment clearly states that the next portion of code should display title for 700 and 100 fields (field 100$c which is displayed earlier, or field 100$t) but the code actually only display title for 700 field. (Field 700$t is correctly displayed.) Should we add the code to display field 100$t or should we change the comment so it's more accurate with what the code do ? To test: 1- Be sure to use koha MARC21 2- Find or create a record that have a field 100$t 3- Search the catalog for this record (be sure to hav at least two results) 4- See that field 100$t is not displayed 5- Click on your record to go to the detail page 6- See that field 100$t is not displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:31:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:31:21 +0000 Subject: [Koha-bugs] [Bug 29171] New: Offline circulation file date due Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29171 Bug ID: 29171 Summary: Offline circulation file date due Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Now the string has the form: 2015-05-27 14:59:13 issue 23821000000033 13821000268800 How can I specify the date(date due) in the line when the instance should be returned? Converting data from a third-party ILS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:32:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:32:27 +0000 Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #107 from Jonathan Druart --- Created attachment 125726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125726&action=edit Bug 27945: Don't save rule if not defined The DB rev added a row with NULL (unlimited), and the UI a row with '' (unlimited as well) when saved without value. Better is to not have a row (still unlimited) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:55:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:55:55 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #124 from Katrin Fischer --- I did't manage to use 001 - is there a special syntax to use for control fields? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:57:41 +0000 Subject: [Koha-bugs] [Bug 29172] New: Can't use controlfiels with CustomCoverImagesURL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 Bug ID: 29172 Summary: Can't use controlfiels with CustomCoverImagesURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 22445 I've been trying to use the controlnumber from 001 in CustomCoverImagesURL, but didn't manage to make it work: {001} {001$@} - internal server error {001$} Mabe it's possible and I don't have the right syntax? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 [Bug 22445] Ability to define a URL for custom cover images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:57:41 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 [Bug 29172] Can't use controlfiels with CustomCoverImagesURL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 11:57:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 09:57:52 +0000 Subject: [Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:06:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:06:34 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- Are we doing the same for holds now? I think we didnt, we only calculated if we allow when the user clicked further? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:08:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:08:54 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:10:31 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #2 from Marcel de Rooy --- Note that we may not even be able to say if a request is possible. We are doing sort of intelligent guess now. You have biblio and item level requests. You depend on multiple circ rules. Etc. It will be too costly to calculate beforehand? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:12:39 +0000 Subject: [Koha-bugs] [Bug 25838] Sort facets values by number of occurrences (Zebra) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #13 from Fridolin Somers --- *** This bug has been marked as a duplicate of bug 28826 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:12:39 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- *** Bug 25838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:12:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:12:59 +0000 Subject: [Koha-bugs] [Bug 23036] Optionally order facets by result hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23036 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |fridolin.somers at biblibre.co | |m Status|NEW |RESOLVED --- Comment #1 from Fridolin Somers --- *** This bug has been marked as a duplicate of bug 28826 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:12:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:12:59 +0000 Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search engines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhannert at nmc.edu --- Comment #9 from Fridolin Somers --- *** Bug 23036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:15:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:15:02 +0000 Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #65 from Jonathan Druart --- I think there is something wrong with the notice. >From the DBrev: 28 $dbh->do(q{ 29 UPDATE letter SET content=REPLACE(content, '<>', '<>') 30 WHERE module = 'circulation' AND code = 'AR_CANCELED' 31 }); when the installer file is still using notes 233 - "Your request for an article from <> (<>) has been canceled for the following reason:" 234 - "" 235 - "<>" By the way, shouldn't we copy the notes to the cancellation_reason when the article request has been canceled? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:20:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:20:42 +0000 Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 29057: Use font awesome icons on request.pl Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:21:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:21:44 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #3 from Jonathan Druart --- Not a lot of cost for the detail view (and we try to do it for holds on this view). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 12:25:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 10:25:20 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|When a librarian is |When a librarian is release notes|cataloguing a bibliographic |cataloguing a bibliographic |record and needs a new |record and needs a new |authorised value, they will |authorised value, they will |now be able to create it |now be able to create it |directly from the edit |directly from the edit |form. |form. |It also works on the |It also works on the |item and authority editing |item and authority editing |forms. |forms. |They will need the |They will need the |necessary permission: |necessary permission: |manage_authorised_values. |manage_auth_values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:05:59 +0000 Subject: [Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > Not a lot of cost for the detail view (and we try to do it for holds on this > view). True. I had the results view in mind. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:26:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:26:34 +0000 Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy --- + $issues_id = $item->{itemnumber}; I am having serious doubts about that change ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:28:18 +0000 Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 --- Comment #7 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > + $issues_id = $item->{itemnumber}; > > I am having serious doubts about that change ;) Especially the way it reads btw. Maybe find a good rename.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:31:36 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122314|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 125727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125727&action=edit Bug 3142: Add itemlost, withdrawn and notforloan Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:31:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:31:42 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122315|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 125728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125728&action=edit Bug 3142: Exclude damaged items Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:31:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:31:48 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122316|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 125729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125729&action=edit Bug 3142: Add itype Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:31:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:31:53 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122317|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 125730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125730&action=edit Bug 3142: Use filter_by_for_holds where holdability is calculated Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:32:17 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:33:28 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #21 from Martin Renvoize --- This works well and certainly clarifies the code.. it does need tests still though ;) Whilst I see David's point about on shelf holds, I think we can defer that piece to a next step in a follow-up bug. Signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:36:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:36:19 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|tomascohen at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #16 from Marcel de Rooy --- + require C4::Items; Why? There is a use in the module already. Formally, we should add 'use Koha::Items' though.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:39:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:39:22 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #22 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #21) > This works well and certainly clarifies the code.. it does need tests still > though ;) If it does, we cant get it further from here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 13:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 11:41:01 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy --- + my @hold_not_allowed_itypes = Koha::CirculationRules->search( + { + rule_name => 'holdallowed', + branchcode => undef, + categorycode => undef, + rule_value => 'not_allowed', + } + )->get_column('itemtype'); I have my doubts here btw. This is too simple. You are looking at circ rules with exception for various combinations of category, itemtype etc. You cant just do a get_column here. This depends on context. Please clarify and add tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:00:34 +0000 Subject: [Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:00:39 +0000 Subject: [Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 --- Comment #1 from Jonathan Druart --- Created attachment 125731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125731&action=edit Bug 29172: Make CustomCoverImagesURL compatible with control fields Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but control fields were not supported. Test plan: Turn CustomCoverImages on Fill CustomCoverImagesURL with https://covers.openlibrary.org/b/isbn/{006}-M.jpg Add an isbn in 006 (0596001738 will work) Go to the detail page of the bibliographic record and confirm that you see a cover image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:02:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:02:08 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #24 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > (In reply to Martin Renvoize from comment #21) > > This works well and certainly clarifies the code.. it does need tests still > > though ;) > > If it does, we cant get it further from here? What do you suggest? I didn't get what suggested David in comment 9. The unique ambition of these patches is to reuse an existing method and avoid duplication of code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:07:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:07:53 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #25 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #23) > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > + { > + rule_name => 'holdallowed', > + branchcode => undef, > + categorycode => undef, > + rule_value => 'not_allowed', > + } > + )->get_column('itemtype'); > > I have my doubts here btw. > This is too simple. You are looking at circ rules with exception for various > combinations of category, itemtype etc. > You cant just do a get_column here. This depends on context. > Please clarify and add tests. Which context? The logged in branch? Here we are not in C4::Reserves, we don't want to offer all the complexity of CanItemBeReserved. As said previously I am not adding new code of functionality (apart for the additional damaged check). Tests are definitely missing, agreed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:14:22 +0000 Subject: [Koha-bugs] [Bug 29173] New: Button "replace authority record via Z39/50/SRU" doesn't work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Bug ID: 29173 Summary: Button "replace authority record via Z39/50/SRU" doesn't work Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: marion.durand at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To replace an authority record via Z39.50/SRU there are two buttons on differents pages but their behaviour is not the same. One pre-fill the search form but the other don't. If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Replace record via Z39.50/SRU" Then: "Z39.50 authority search points" pop up but all field are empty. But If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Edit record" 3- Click on the button "Replace record via Z39.50/SRU search" Then: "Z39.50 authority search points" pop up with usefull values already filled (for example the Author) There is the same two button for bibliographic record and both of them pre-fill the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:17:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:17:45 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #26 from Jonathan Druart --- Created attachment 125732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125732&action=edit Bug 3142: Add tests And fix a bug! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:21:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:21:26 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > (In reply to Marcel de Rooy from comment #23) > > + my @hold_not_allowed_itypes = Koha::CirculationRules->search( > > + { > > + rule_name => 'holdallowed', > > + branchcode => undef, > > + categorycode => undef, > > + rule_value => 'not_allowed', > > + } > > + )->get_column('itemtype'); > > > > I have my doubts here btw. > > This is too simple. You are looking at circ rules with exception for various > > combinations of category, itemtype etc. > > You cant just do a get_column here. This depends on context. > > Please clarify and add tests. > > Which context? The logged in branch? > Here we are not in C4::Reserves, we don't want to offer all the complexity > of CanItemBeReserved. As said previously I am not adding new code of > functionality (apart for the additional damaged check). Ok. If this is a reflection of what we did already, I cant justify to fail it :) Koha never fails! Back to SO -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:22:45 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #28 from Marcel de Rooy --- Will QA this one soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:22:52 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:23:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:23:18 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:33:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:33:14 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #29 from Jonathan Druart --- Created attachment 125733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125733&action=edit Bug 3142: Add test for the circ rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:33:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:33:18 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #30 from Jonathan Druart --- Created attachment 125734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125734&action=edit Bug 3142: Add note about imprecision of filter_by_for_hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:34:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:34:00 +0000 Subject: [Koha-bugs] [Bug 29131] Row striping breaks color coding on item circulation alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 5 14:34:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Oct 2021 12:34:05 +0000 Subject: [Koha-bugs] [Bug 29131] Row striping breaks color coding on item circulation alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 --- Comment #1 from Owen Leonard --- Created attachment 125735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125735&action=edit Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the