From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:09:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 22:09:43 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
Depends on| |24488
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
[Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:09:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 22:09:43 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
'first patron' details
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29148
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
[Bug 29148] Holds to Pull doesn't reflect item-level holds
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:16:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 22:16:09 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:16:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 22:16:12 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125566|0 |1
is obsolete| |
--- Comment #4 from Lucas Gass ---
Created attachment 125572
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125572&action=edit
Bug 29148: Check if hold is item or bib level
To test:
1 - place an item level hold, it says: [one of the barcodes] or any available
2 - place a bib level hold, it says: [one of the barcodes] or any available
3 - Apply patch
4 - item level hold should say: Only [barcode]
5 - bib level hold should say: [one of the barcodes] or any available
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 00:25:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 22:25:55 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 01:28:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 23:28:40 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
sandboxes at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125572|0 |1
is obsolete| |
--- Comment #5 from sandboxes at biblibre.com ---
Created attachment 125573
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125573&action=edit
Bug 29148: Check if hold is item or bib level
To test:
1 - place an item level hold, it says: [one of the barcodes] or any available
2 - place a bib level hold, it says: [one of the barcodes] or any available
3 - Apply patch
4 - item level hold should say: Only [barcode]
5 - bib level hold should say: [one of the barcodes] or any available
Signed-off-by: Azucena
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 01:29:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 23:29:08 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148
Azucena Aguayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 02:45:18 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use
XSLTParse4Display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 02:45:23 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use
XSLTParse4Display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #124231|0 |1
is obsolete| |
--- Comment #8 from Aleisha Amohia ---
Created attachment 125574
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125574&action=edit
Bug 28734: Parse display in $biblio->get_marc_notes
1. Go to Koha Administration, MARC bibliographic frameworks
2. Edit a framework, find tag 590, edit the $z subfield to use an
authorised value.
3. Do a catalogue search and edit a record using this framework. Edit
590$z and select an authorised value. Save the record.
4. Add the record to your cart.
5. View your cart. Click More Details.
6. Scroll down to the Notes section. Notice the authorised value code is
displayed instead of the description.
7. Apply the patch, restart services.
8. Refresh your cart. Click More Details again if you need to.
9. Scroll down to the Notes section. The description of the authorised
value should now be displayed.
Sponsored-by: Catalyst IT
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 02:45:27 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use
XSLTParse4Display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
--- Comment #9 from Aleisha Amohia ---
Created attachment 125575
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125575&action=edit
Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests
Confirm the following tests pass:
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/XSLT.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 04:45:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 02:45:53 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse
authorised values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Koha::Biblio->get_marc_note |Koha::Biblio->get_marc_note
|s should use |s should parse authorised
|XSLTParse4Display |values
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 08:43:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 06:43:28 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout when
Pseudonymization is used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011
--- Comment #6 from JanMueck ---
It states the following:
DBIx::Class::Storage::DBI::_do_query(): DBI Exception: DBD::mysql::db do
failed: Lost connection to backend server: network error (zd-dbsrv-5: 111,
Connection refused) [for Statement "set NAMES 'utf8mb4'"] at
/usr/share/koha/lib/C4/Context.pm line 624
Maybe this helps..
Kind regards
Jan
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:39:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 07:39:01 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
deleteditems when determining deletedbiblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
--- Comment #7 from Jonathan Druart ---
Thanks a lot, Ere, for your reactivity!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:41:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 07:41:48 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
deleteditems when determining deletedbiblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125570|0 |1
is obsolete| |
--- Comment #8 from Ere Maijala ---
Created attachment 125576
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125576&action=edit
Bug 29135: Fix handling of deleted items in OAI-PMH provider
Test plan:
1. Make sure this scenario now works properly:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0
2. Run prove -v t/db_dependent/OAI/
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:44:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 07:44:59 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
deleteditems when determining deletedbiblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
--- Comment #9 from Ere Maijala ---
Jonathan, no problem, it was my bad anyway.. I've added a couple more tests.
I'll run a harvesting job to verify.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 09:59:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 07:59:15 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |BLOCKED
--- Comment #47 from Marcel de Rooy ---
QA: Looking here
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:07:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:07:08 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
per patron category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #86 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #84)
> (In reply to Jonathan Druart from comment #81)
> > 3.
> >
> > + if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
> > + push @messages, {type => 'error', code =>
> > 'article_request_numeric_limit' };
> > + $op = 'add_form';
> > + } elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> > + push @messages, {type => 'error', code =>
> > 'article_request_negative_limit' };
> > + $op = 'add_form';
> > + } else {
> >
> > Why that?
> > I am expecting to see a JS validation and an exception raised in
> > Koha::Category->store. But not in the controller.
>
> Is this a blocker for inclusion?
I think so, it does not make sense to have it there. It may be better to just
remove this check as we have the JS validation.
If it is really what you need, you must use a "int unsigned" at DB level.
Btw why do you use tinyint(4) when other "limit" columns in the same table are
smallint(6)?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:21:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:21:00 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
per patron category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #87 from Jonathan Druart ---
I am not convinced by the COMPLETED, updated_on code:
965 Returns true if the patron can request articles. As limits apply for the
patron
966 on on the same day, those completed the same day are considered as
current.
976 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
977 my $compdate = dt_from_string->add( days => -1 );
978 my $count = Koha::ArticleRequests->search([
979 { borrowernumber => $self->borrowernumber, status =>
['REQUESTED','PENDING','PROCESSING'] },
980 { borrowernumber => $self->borrowernumber, status => 'COMPLETED',
updated_on => { '>', $dtf->format_date($compdate) }},
if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and
updated_on > 2021-09-30 will return the rows updated yesterday as well.
There is no test coverage for that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:28:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:28:56 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
per patron category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #88 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #86)
> I think so, it does not make sense to have it there. It may be better to
> just remove this check as we have the JS validation.
>
> If it is really what you need, you must use a "int unsigned" at DB level.
Agustin added the test with \d+ before there was js validation. I agree to
remove it now. Not sure if we should really specify unsigned in SQL; did we do
that more often? We could just check !value < 0 in js as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:29:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:29:30 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
per patron category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #89 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #87)
> if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and
> updated_on > 2021-09-30 will return the rows updated yesterday as well.
Read 'same day' here as last 24 hours.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:34:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:34:36 +0000
Subject: [Koha-bugs] [Bug 21303] XSLT should look in LDR/18 to know whether
to add punctuation or not
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303
marion.durand at biblibre.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marion.durand at biblibre.com
--- Comment #2 from marion.durand at biblibre.com ---
I'm working on this bug, but I'm not sure what the result should be for this
example
100 1#
a Goscinny, René,
d 1926-1977-,
e author.
About the comma near the date, should it look like:
1) Goscinny, René, 1926-1977- [author.]. (Without any comma after the date)
or
2) Goscinny, René, 1926-1977-, [author.]. (With a comma after the date)
About the two periods at the end, should it look like:
3) Goscinny, René, 1926-1977- [author.] (With the period inside the bracket)
4) Goscinny, René, 1926-1977- [author]. (With the period outside the bracket)
5) Goscinny, René, 1926-1977- [author.]. (With two periods)
6) Goscinny, René, 1926-1977- [author] (Without any period)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:34:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:34:38 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125470|0 |1
is obsolete| |
--- Comment #25 from Jonathan Druart ---
Created attachment 125577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125577&action=edit
Bug 23678: (QA follow-up) Use correct indentation
Signed-off-by: Tomas Cohen Arazi
JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:35:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:35:15 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125404|0 |1
is obsolete| |
Attachment #125405|0 |1
is obsolete| |
Attachment #125406|0 |1
is obsolete| |
Attachment #125577|0 |1
is obsolete| |
--- Comment #26 from Jonathan Druart ---
Created attachment 125578
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125578&action=edit
Bug 23678: Allow cancel holds in bulk
This patch allows staff patrons to cancel multiple holds in bulk.
To test:
1. Apply this patch
2. restart_all
3. In cataloge go to a book and place many holds
CHECK => Holds table shows a column of checkboxes
4. Play with checkboxes (have some fun ;-P)
CHECK => When you manually check all checkboxes, the checkbox in the
header also gets checked.
=> When you uncheck one of the checkboxes, the one in the header also
gets unchecked.
=> If no checkbox is checked and you check the one in the header,
all checkboxes get checked.
=> If there are some checkboxes that are checked and others are
not, when you click on the checkbox in the header all checkboxes get
unchecked.
=> If all checkboxes are checked, when you uncheck the one in the
header, all checkboxes get unchecked.
=> Every time you play with checkboxes, the number in the button
"Cancel selected" changes.
5. Check some of the checkboxes and click on cancel selected.
SUCCESS => A background job gets fired to cancel all selected holds.
=> A message should appear with a link to the job.
6. Wait a few seconds and click on the link
SUCCESS => A message appears with the report of the execution of the
background job.
7. Grab a patron and search to hold
8. Select multiple biblios and click on "place hold for "
CHECK => After holds are confirmed, multiple holds table are shown.. one for
each record. Checkboxes work exactly the same as before, but scoped
for each individual table. Checkboxes from one table will not affect
checkboxes from other tables.
9. Repeat steps 4 to 6.
10. Check In some of the items so the get in Waiting state.
11. Update expirationdate os some of those holds and set it to
ReservesMaxPickUpDelay + 1 days earlier
NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update
would be
=> update reserves set expirationdate = date_sub(expirationdate, interval
8 day) where reserve_id in (...)
12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Add missing template filter
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Add missing filters
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Use correct indentation
Signed-off-by: Tomas Cohen Arazi
JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:35:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:35:29 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
--- Comment #27 from Jonathan Druart ---
Patches squashed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:40:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:40:28 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #13 from Martin Renvoize ---
This is a lovely improvement... it simplifies and reduces code and adds direct
access to checkouts from patron results page. I'd love to see a follow-on bug
to do the same for holds searching and then we can ditch some more code :).
However, I do think Fridolin raises a good point about the 'cardnumber' field
being one you can hide which could cause confusion. The button styling isn't
complete and I agree it's a little jarring to see it outside of the 'actions'
field.
I'd be tempted move the button to the actions column and perhaps update the
cardnumber text to be a link directly to checkout (with a tooltip preferably).
If you think that would fulfil all your customers requirements, I'd be happy to
make that change in a follow-up Nick?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:41:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:41:07 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
--- Comment #28 from Jonathan Druart ---
Created attachment 125579
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125579&action=edit
Bug 23678: Don't display code of the job type
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:43:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:43:51 +0000
Subject: [Koha-bugs] [Bug 29149] New: Background job detail view needs more
flexibility
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
Bug ID: 29149
Summary: Background job detail view needs more flexibility
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:44:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:44:18 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |ASSIGNED
Depends on| |29149
Assignee|agustinmoyano at theke.io |jonathan.druart+koha at gmail.
| |com
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
[Bug 29149] Background job detail view needs more flexibility
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:44:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:44:18 +0000
Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more
flexibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23678
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
[Bug 23678] Cancel holds in bulk
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:49:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:49:29 +0000
Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more
flexibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |26080
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080
[Bug 26080] Use the task queue for the batch delete records tool
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:49:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:49:29 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
records tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29149
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
[Bug 29149] Background job detail view needs more flexibility
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:53:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:53:30 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
--- Comment #48 from Marcel de Rooy ---
It might be completely obvious for people using this feature daily how it
works, but since not everybody does, a little bit more test plan would have
been helpful.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:57:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:57:47 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
--- Comment #49 from Marcel de Rooy ---
I read the discussion. Yes, there is a trend to put values in the prefs and no
longer on the cmdline. We are in a hybrid situation now (as we are with many
things).
Asking to put something in koha-conf too would be rather tedious imo.
This looks good to me.
Adding just a small follow-up including my test plan.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 10:57:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 08:57:56 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:06 +0000
Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more
flexibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:08 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125489|0 |1
is obsolete| |
--- Comment #14 from Martin Renvoize ---
Created attachment 125580
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125580&action=edit
Bug 15812: Use patron search in place of circ search
The 'Checkout' search hijacks some of the DataTables searching code used for
'Search patrons'
Rather than try to implement the search again on another page, we can simply
send the user
to the patron search if the cardnumber is not found
Additionally, this patch adds a 'Check out' button to the patron search results
to allow
going to checkotus directly
To test:
1 - Apply patch
2 - Perform a 'Checkout' search from the header
3 - Note that:
For a cardnumber, you are redirected directly to checkouts page for the
borrower
For a search with one result, you are redirected directly to the checkout
page for the borrower
For a search with many results, you are redirected to the patron search
results
and there is a 'Checkout' button under the cardnumber
4 - Confirm circulation page works as expected (i.e. checkout to a patron)
Signed-off-by: Kyle M Hall
Signed-off-by: George Williams
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:10 +0000
Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more
flexibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
--- Comment #1 from Jonathan Druart ---
Created attachment 125581
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125581&action=edit
Bug 29149: Add the capability to provide more info to the background job detail
view
(Patch extracted from bug 28445 to make it reusable for bug 23678)
We already had the need for that, when bibliographic records are
modified in batch we wanted to add a "Add to list" feature, and so pass
a list of lists/virtual shelves to the template.
Here (in 28445) we will want to pass the infos of the items that have been
modified
to display a table.
Test plan:
0. Create at least one list (virtual shelf)
1. batch update biblios
2. Go to the job detail
3. Notice that dropdown list to add the record to a list
=> No regression found!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:12 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125490|0 |1
is obsolete| |
--- Comment #15 from Martin Renvoize ---
Created attachment 125582
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125582&action=edit
Bug 15812: (follow-up) Add permission check for 'Check out' button
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:16 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #16 from Martin Renvoize ---
Created attachment 125583
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125583&action=edit
Bug 15812: (follow-up) Tweaks to patron results display
Move the button into the actions column and make 'cardnumber' a link to
checkout, with a tooltip.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:22 +0000
Subject: [Koha-bugs] [Bug 29149] Background job detail view needs more
flexibility
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
|ity.org |com
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:00:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:00:56 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #17 from Martin Renvoize ---
Code speaks.. let me know what you think of that final followup. Otherwise,
I'm happy to PQA :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:36 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|BLOCKED |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:40 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120927|0 |1
is obsolete| |
--- Comment #50 from Marcel de Rooy ---
Created attachment 125584
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125584&action=edit
Bug 25429: Cleanup Database - remove resolved claims returned from db after X
days
Add option to cleanup_database script to removed 'resolved' return claims from
the database after a specified number of days.
Test Plan:
1) Apply this patch
2) Set the new syspref CleanUpDatabaseReturnClaims to a number of days
3) Run cleanup_database.pl
4) Note resolved claims older than the specified number of days are removed
from the database
Bug 25429: Implement system preference, remove command line switch
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Rebecca Coert
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:44 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120928|0 |1
is obsolete| |
--- Comment #51 from Marcel de Rooy ---
Created attachment 125585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125585&action=edit
Bug 25429: Script should be able to run with only return claims
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Rebecca Coert
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:49 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120929|0 |1
is obsolete| |
--- Comment #52 from Marcel de Rooy ---
Created attachment 125586
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125586&action=edit
Bug 25429: Use filter_by_last_update
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:53 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120930|0 |1
is obsolete| |
--- Comment #53 from Marcel de Rooy ---
Created attachment 125587
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125587&action=edit
Bug 25429: Require command line switch to enable, control DAYS via syspref
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:02:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:02:57 +0000
Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims
returned from db after X days
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429
--- Comment #54 from Marcel de Rooy ---
Created attachment 125588
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125588&action=edit
Bug 25429: (QA follow-up) Add extra variable for days
I think it is a bit more clear to use another variable for the
number of days from the preferences than overwriting the flag
variable.
Signed-off-by: Marcel de Rooy
Tested by adding an authval for LOST.
Filling prefs ClaimReturnedLostValue, CleanUpDatabaseReturnClaims.
Claiming a return, resolving it. Setting date back via SQL.
Running the script with -v --return-claims, toggling --confirm.
The claim is counted and deleted with confirm.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:03:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:03:40 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
per patron category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #90 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #89)
> (In reply to Jonathan Druart from comment #87)
>
> > if today is Oct 1st, $dtf->format_date($compdate) will be Sept 30th and
> > updated_on > 2021-09-30 will return the rows updated yesterday as well.
>
> Read 'same day' here as last 24 hours.
Are you sure this is correct?
Sept 30th 16pm is yesterday for me, and it's Oct 1st 11am now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:10:17 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #18 from Fridolin Somers ---
Whaou for me it is awesome.
Thanks a lot Martin ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:05 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125578|0 |1
is obsolete| |
--- Comment #29 from Jonathan Druart ---
Created attachment 125589
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125589&action=edit
Bug 23678: Allow cancel holds in bulk
This patch allows staff patrons to cancel multiple holds in bulk.
To test:
1. Apply this patch
2. restart_all
3. In cataloge go to a book and place many holds
CHECK => Holds table shows a column of checkboxes
4. Play with checkboxes (have some fun ;-P)
CHECK => When you manually check all checkboxes, the checkbox in the
header also gets checked.
=> When you uncheck one of the checkboxes, the one in the header also
gets unchecked.
=> If no checkbox is checked and you check the one in the header,
all checkboxes get checked.
=> If there are some checkboxes that are checked and others are
not, when you click on the checkbox in the header all checkboxes get
unchecked.
=> If all checkboxes are checked, when you uncheck the one in the
header, all checkboxes get unchecked.
=> Every time you play with checkboxes, the number in the button
"Cancel selected" changes.
5. Check some of the checkboxes and click on cancel selected.
SUCCESS => A background job gets fired to cancel all selected holds.
=> A message should appear with a link to the job.
6. Wait a few seconds and click on the link
SUCCESS => A message appears with the report of the execution of the
background job.
7. Grab a patron and search to hold
8. Select multiple biblios and click on "place hold for "
CHECK => After holds are confirmed, multiple holds table are shown.. one for
each record. Checkboxes work exactly the same as before, but scoped
for each individual table. Checkboxes from one table will not affect
checkboxes from other tables.
9. Repeat steps 4 to 6.
10. Check In some of the items so the get in Waiting state.
11. Update expirationdate os some of those holds and set it to
ReservesMaxPickUpDelay + 1 days earlier
NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update
would be
=> update reserves set expirationdate = date_sub(expirationdate, interval
8 day) where reserve_id in (...)
12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Add missing template filter
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Add missing filters
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Bug 23678: (QA follow-up) Use correct indentation
Signed-off-by: Tomas Cohen Arazi
JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm
JD Amended patch: Full rebase and adjustements made on top of bug 26080.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:10 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125579|0 |1
is obsolete| |
--- Comment #30 from Jonathan Druart ---
Created attachment 125590
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125590&action=edit
Bug 23678: Don't display code of the job type
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:34 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
deleteditems when determining deletedbiblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125576|0 |1
is obsolete| |
--- Comment #10 from Ere Maijala ---
Created attachment 125591
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125591&action=edit
Bug 29135: Fix handling of deleted items in OAI-PMH provider
Test plan:
1. Make sure this scenario now works properly:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0
2. Run prove -v t/db_dependent/OAI/
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:53 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125509|0 |1
is obsolete| |
--- Comment #19 from Martin Renvoize ---
Created attachment 125592
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125592&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context
Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:
my @account_offsets = $payment->debit_offsets;
This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.
To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:
ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23
6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:54 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
--- Comment #31 from Jonathan Druart ---
Patches rebased and reworked on top of bug 26080 (PQA for a month already).
It refactored some of the background job code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:16:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:16:57 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125510|0 |1
is obsolete| |
--- Comment #20 from Martin Renvoize ---
Created attachment 125593
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125593&action=edit
Bug 29139: Fix incorrect relation call
The bug here was worse than originally thought. We were calling the
wrong relation too.. we should probably add some exceptions to catch
this, it confuses me every single time!
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:17:01 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125511|0 |1
is obsolete| |
--- Comment #21 from Martin Renvoize ---
Created attachment 125594
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125594&action=edit
Bug 29139: Add exceptions to relation accessors
We already had exceptions on the many-to-many links, but we didn't have
them for the middle table. The underlying dbic relations make it clear
which id's are being used for linking. A 'credit' has 'credit_offsets',
a 'debit' has 'debit_offsets'.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:17:05 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125512|0 |1
is obsolete| |
--- Comment #22 from Martin Renvoize ---
Created attachment 125595
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125595&action=edit
Bug 29139: Add regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:17:09 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125513|0 |1
is obsolete| |
--- Comment #23 from Martin Renvoize ---
Created attachment 125596
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125596&action=edit
Bug 29139: Only pass the offsets for lines the credit was applied to
On writing the regression tests, I noticed the CREATE offset was added
to the template. The idea behind passing the offsets is that we can
print information about the lines that got the credit applied. Having
the CREATE offset is meaningless, and (worse) would require users to add
logic to skip it. And all the payment information is already passed in
the 'credit' variable anyway.
This patch filters the credit_offsets by type, leaving the APPLY ones
only.
To test:
1. Apply up to the regression tests
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Account.t
=> FAIL: 3 offsets, including the CREATE one, boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Only the two APPLY offsets are returned!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:17:13 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #38 from Marcel de Rooy ---
@RM: What holds you back from pushing this development?
This makes me doubt if I should QA things that depend on it.
If you have doubts on this one, please indicate so on the report?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:17:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:17:35 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #24 from Martin Renvoize ---
Final QA run done over the whole patchset... nice work everyone.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:18:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:18:06 +0000
Subject: [Koha-bugs] [Bug 28211] Replace use of call_recursive() with call()
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211
--- Comment #14 from Marcel de Rooy ---
Asked a question about one of the base reports still not pushed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:24:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:24:48 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125583|0 |1
is obsolete| |
--- Comment #19 from Martin Renvoize ---
Created attachment 125597
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125597&action=edit
Bug 15812: (follow-up) Tweaks to patron results display
Move the button into the actions column and make 'cardnumber' a link to
checkout, with a tooltip.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:26:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:26:47 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:27:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:27:16 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #20 from Martin Renvoize ---
Last little tweak made the action button prettier ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:27:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:27:35 +0000
Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results
when using EasyAnalytics
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:39:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:39:06 +0000
Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to
slips and notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #12 from Marcel de Rooy ---
I dont want to disappoint you but the whole discussion on bug 28883 will have a
bearing on this one too.
The point is that TT calls methods in list context. Which is what you dont want
when chaining. So e.g. object.filterbyX.count does not even work when filter
returns a list while in perl would return an iterator here.
And specific to this bug, how would a 'power user' editing a notice know that
difference?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:42:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:42:38 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
--- Comment #1 from Martin Renvoize ---
Created attachment 125598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125598&action=edit
Bug 29005: Enable welcome email from patron imports
This patch was updated from work done by Evangelische Theologische
Faculteit to allow the patron import to send welcome emails to users
when enabled.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:43:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:43:01 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
|ity.org |.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:43:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:43:08 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:44:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:44:46 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
--- Comment #32 from Jonathan Druart ---
99 error => defined $hold
100 ? ( $@ ? $@ : 0 )
101 : 'No hold with id ' . $hold_id . ' found',
Caught a non translatable error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:50:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:50:13 +0000
Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #3 from Marcel de Rooy ---
I would recommend to use this opportunity to sort the various message settings,
at least on the OPAC side.
It is a bit strange to see Hold reminder now below under Item checkout.
But this definitely has a multi language aspect !
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:54:42 +0000
Subject: [Koha-bugs] [Bug 28352] Errors in
search_for_data_inconsistencies.pl relating to authorised values and
frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:54:45 +0000
Subject: [Koha-bugs] [Bug 28352] Errors in
search_for_data_inconsistencies.pl relating to authorised values and
frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123447|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 125599
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125599&action=edit
Bug 28352: Only check authorised values mapped to DB fields
The errors reported seem to be caused by authorised values mapped to MARC
fields
but not mapped to a koha field.
We should additionally make sure to check the Default framework
Also, adding comment to indicate we only check records with items, because we
do
TO test:
1 - In a framework that is not the default map a MARC field to an authorised
value, but not a koha field
2 - In SQL, force the kohafield to NULL for the mapping you just make
UPDATE marc_subfield_structure SET kohafield = NULL WHERE
frameworkcode='BKS' and authorised_value='HINGS_AS'
3 - perl misc/maintenance/search_for_data_inconsistencies.pl
4 - get the following errors:
Use of uninitialized value $tmp_kohafield in pattern match (m//) at
/kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 151.
Use of uninitialized value $tmp_kohafield in substitution (s///) at
/kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 154.
Can't call method "get_column" on an undefined value at
/kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 157.
5 - Apply patch
6 - Repeat
7 - No more errors
Signed-off-by: Fridolin Somers
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 11:54:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 09:54:59 +0000
Subject: [Koha-bugs] [Bug 28352] Errors in
search_for_data_inconsistencies.pl relating to authorised values and
frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:01:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:01:00 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
--- Comment #33 from Jonathan Druart ---
Created attachment 125600
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125600&action=edit
Bug 23678: Include file for batch_hold_cancel
Use additional_report to retrieve patron and biblio's info.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:01:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:01:59 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Signed Off
--- Comment #34 from Jonathan Druart ---
Tomas, have a look at the current version and the dependent bugs. I moved code
out of bug 28445 to reuse it here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:02:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:02:18 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jonathan.druart+koha at gmail. |agustinmoyano at theke.io
|com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:42:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:42:29 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #21 from Owen Leonard ---
I like the change to the buttons but I'm sorry to see Bug 28081 undone. I'd
like to argue that the link is redundant since the button has been added.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:46:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:46:06 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:46:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:46:28 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #22 from Martin Renvoize ---
Good catch Owen.. I wasn't aware of the label stuff.. I thought it had been
added here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 12:51:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 10:51:56 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
basket/list by email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345
Didier Gautheron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |didier.gautheron at biblibre.c
| |om
Status|Needs Signoff |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:08:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:08:55 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:09:00 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125311|0 |1
is obsolete| |
Attachment #125312|0 |1
is obsolete| |
Attachment #125313|0 |1
is obsolete| |
--- Comment #5 from Peter Vashchuk ---
Created attachment 125601
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125601&action=edit
Bug 29111: Remove dead code from acqui/addorderiso2709.pl
Test plan:
1) open acqui/addorderiso2709.pl in your code editor and make sure
nothing references $item in the if block where it was removed from
Signed-off-by: Petro Vashchuk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:09:05 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111
--- Comment #6 from Peter Vashchuk ---
Created attachment 125602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125602&action=edit
Bug 29111: Remove unused indicator modification code for items
The indicator value for 952 was hard coded in every case to " ". In
order to achieve that we can simply pass undef to TransformHtmlToXml()
and it will set the indicator values to " ".
To test:
1) Make sure the submission of (at least some) the modified files
still work, e.g. test that making a new item via
cataloguing/additem.pl works.
Signed-off-by: Petro Vashchuk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:09:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:09:10 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111
--- Comment #7 from Peter Vashchuk ---
Created attachment 125603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125603&action=edit
Bug 29111: Remove unused function from cataloguing/additem.pl
To test:
1) Open cataloguing/additem.pl and search for any usages of
find_value, you should find 0 usages.
Signed-off-by: Petro Vashchuk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:26:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:26:58 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #23 from Martin Renvoize ---
Created attachment 125604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125604&action=edit
Bug 15812: (follow-up) Enable click row to select
This patch adds handling to allow clicking anywhere in the table row to
select/deselect the patron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:03 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125069|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:07 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123757|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:12 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123758|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:17 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123759|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:22 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123760|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:27 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123761|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:31 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123762|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:35 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123763|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:40 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123764|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:46 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123765|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:52 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123766|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:29:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:29:57 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123767|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:30:02 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123768|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:30:07 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123769|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:30:13 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123770|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:30:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:30:17 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #123771|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:31:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:31:34 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:31:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:31:41 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |This patch replaces the
release notes| |special case patron results
| |page from circulation
| |searches and instead
| |redirects to the standard
| |patron search results page.
| |
| |To enable quick onward
| |navigation to checkout, we
| |add a link to the
| |cardnumber field and a
| |button to the actions
| |column.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:05 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #102 from Tomás Cohen Arazi ---
Created attachment 125605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125605&action=edit
Bug 27526: Remove ModItemFromMarc from additem
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:13 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #103 from Tomás Cohen Arazi ---
Created attachment 125606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125606&action=edit
Bug 27526: Remove AddItemFromMarc from additem
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:23 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #104 from Tomás Cohen Arazi ---
Created attachment 125607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125607&action=edit
Bug 27526: Adjust code to use Koha::Items
Not that we removed all the transformations of the item and are using
Koha::Item from DB to TT (and the other way around), some code needs
adjustments.
- Retrieve host items can be simplified (see Koha::Biblio->host_items)
- Some TT variables have been renamed for better understanding
- Koha::Item->columns_to_str return a hashref with the representation
string of the columns. A date will return the value how it must be
displayed, using output_pref. A subfield linked with a AV will be
replaced with the AV's description.
- LastCreatedItem cookie serializes and stores Koha::Item->unblessed,
no longer the MARC::Record
Change in behaviour: If a subfield is linked with a AV cat and the value
is not a valid AV, before this patch the column was displayed with an
empty value. Now the column is hidden, it's considered empty.
In the sample data it happens with itemlost (0) and withdrawn (0).
Test plan:
1. Test the Prefill
a. Turn PrefillItem on
b. Fill in SubfieldsToUseWhenPrefill with some subfield codes
c. Catalogue an item, save
=> The values from subfields listed in SubfieldsToUseWhenPrefill must be
kept
2. more subfields
a. Add subfields that are not linked with a koha field (k is available)
b. Create an item and fill in all the values
c. Confirm that non linked subfields are stored and displayed correctly
d. Try with a "more subfield" that is linked with an authorised value
category
3. Test barcode values
4. Test the different "Add" buttons at the bottom of the form
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:31 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #105 from Tomás Cohen Arazi ---
Created attachment 125608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125608&action=edit
Bug 27526: Improve grep for date fields
'replacementpricedate' should not catch 'price'
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:41 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #106 from Tomás Cohen Arazi ---
Created attachment 125609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125609&action=edit
Bug 27526: Fix repeatable more subfields
We retrieved always the first value.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:32:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:32:51 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #107 from Tomás Cohen Arazi ---
Created attachment 125610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125610&action=edit
Bug 27526: Fix mandatory and important checks
The input names have been changed from "field_value" to $kohafield.
Modifying this could have an impact in other area, where
CheckMandatorySubfields and CheckImportantSubfields are called.
Using .input_marceditor let us fix the additem.tt form and prevent to
break the other ones.
Note that the other ones are actually broken (!)
Also note that there is a typo in the error message
alertString2 += "\n- " + "%s " +
MSG_MANDATORY_FIELDS_EMPTY.format(total_errors);
There is an extra %s
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:01 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #108 from Tomás Cohen Arazi ---
Created attachment 125611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125611&action=edit
Bug 27526: Fix PrefillItem
We are basically adding:
$current_item = $item->unblessed;
Other changes are for readability
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:15 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #109 from Tomás Cohen Arazi ---
Created attachment 125612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125612&action=edit
Bug 27526: Fix Add & duplicate
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:22 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #110 from Tomás Cohen Arazi ---
Created attachment 125613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125613&action=edit
Bug 27526: Fix Add multiple copies
This has been moved to Koha::Item->store by bug 27545.
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:29 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #111 from Tomás Cohen Arazi ---
Created attachment 125614
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125614&action=edit
Bug 27526: Fix incorrect condition
The barcode was always prefilled!
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:37 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #112 from Tomás Cohen Arazi ---
Created attachment 125615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125615&action=edit
Bug 27526: Fix empty string vs undef
Empty strings must be removed, not inserted as empty strings in DB.
The relevant code is in TransformHtmlToXml, $skip variable.
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:45 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #113 from Tomás Cohen Arazi ---
Created attachment 125616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125616&action=edit
Bug 27526: Remove uneeded call to TransformMarcToKoha
And also clean some imports.
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:33:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:33:53 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #114 from Tomás Cohen Arazi ---
Created attachment 125617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125617&action=edit
Bug 27526: Fix encoding issue on subfield
If you have a "é" subfield it should work!
Note that VARCHAR(1) for binary means 1-byte (from MySQL doc):
"For example, if the default character set is utf8mb4, CHAR(5) BINARY is
treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This
differs from BINARY(5), which stores 5-byte binary strings that have the
binary character set and collation."
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:34:02 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #115 from Tomás Cohen Arazi ---
Created attachment 125618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125618&action=edit
Bug 27526: Fix cn_source display
For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are
calling from Koha::Item->columns_to_str) does not deal with class
sources.
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:34:10 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #116 from Tomás Cohen Arazi ---
Created attachment 125619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125619&action=edit
Bug 27526: Add missing POD
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:34:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:34:16 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #117 from Tomás Cohen Arazi ---
Created attachment 125620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125620&action=edit
Bug 27526: Add tests for columns_to_str and host_items
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:37:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:37:25 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #118 from Tomás Cohen Arazi ---
Ok, I already tested and signed this before.
Tests were added as requested and they pass.
All found issues by testers addressed in follow-up patches.
No QA issues.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:39:15 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:39:41 +0000
Subject: [Koha-bugs] [Bug 29150] New: hold pickup sent two patrons
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29150
Bug ID: 29150
Summary: hold pickup sent two patrons
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: amy at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:39:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:39:47 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #24 from Martin Renvoize ---
Created attachment 125621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125621&action=edit
Bug 15812: (follow-up) Enable click cell to select
This patch adds handling to allow clicking anywhere in the table cell to
select/deselect the patron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:47:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:47:04 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125621|0 |1
is obsolete| |
--- Comment #25 from Martin Renvoize ---
Created attachment 125622
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125622&action=edit
Bug 15812: (follow-up) Enable click cell to select
This patch adds handling to allow clicking anywhere in the table cell to
select/deselect the patron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:47:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:47:32 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125604|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 13:49:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 11:49:42 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
--- Comment #26 from Martin Renvoize ---
OK, I think we're all done now.
I restored the label, but made it a visually hidden one inside the check column
for accessibility and I made the whole table cell clickable for the checkbox to
restore the larger click handling area.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:00:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 12:00:11 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125622|0 |1
is obsolete| |
--- Comment #27 from Martin Renvoize ---
Created attachment 125623
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125623&action=edit
Bug 15812: (follow-up) Enable click cell to select
This patch adds handling to allow clicking anywhere in the table cell to
select/deselect the patron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Oct 1 14:04:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Oct 2021 12:04:03 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
(single character search) causes poor performance or timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125623|0 |1
is obsolete| |
--- Comment #28 from Owen Leonard