[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #86 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #84)
> (In reply to Jonathan Druart from comment #81)
> > 3. 
> > 
> > +    if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
> > +        push @messages, {type => 'error', code =>
> > 'article_request_numeric_limit' };
> > +        $op = 'add_form';
> > +    } elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> > +        push @messages, {type => 'error', code =>
> > 'article_request_negative_limit' };
> > +        $op = 'add_form';
> > +    } else {
> > 
> > Why that?
> > I am expecting to see a JS validation and an exception raised in
> > Koha::Category->store. But not in the controller.
> 
> Is this a blocker for inclusion?

I think so, it does not make sense to have it there. It may be better to just
remove this check as we have the JS validation.

If it is really what you need, you must use a "int unsigned" at DB level.

Btw why do you use tinyint(4) when other "limit" columns in the same table are
smallint(6)?

-- 
You are receiving this mail because:
You are watching all bug changes.