[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #379 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Thanks David for your follow-ups.

Martin and I are ready to help you here. We have enough time before the 21.11
freeze to make this new feature part of the next release :)

Can you reply to the other open questions please? See below.

I am volunteering to write the patches needed.

(In reply to Martin Renvoize from comment #327)
> (In reply to Jonathan Druart from comment #324)
> > 2. We don't hide the admin page if the pref is off, is that expected?
> 
> Whilst I agree with what you're saying here, I think if memory serves this
> was discussed earlier in the bug and the authors wanted the ability to
> create their rules and then enable them.. so they wanted to display the page
> regardless or whether the pref was on or off (the page does warn you at the
> top if the pref is off).. having said that.. I'd be happy to follow-up to
> change that.. or, in my opinion in a later bug we could drop the pref and
> instead have an 'enabled' flag at the rule level.

It seems weird to have the pref off but the link to the admin page visible.

> > 3. Should we link the pref to the admin page?
> 
> Not sure what you're saying here?

I meant, should we have a link to the admin page of the feature in the
syspref's description. I can do it.

> > 6. How does it interface with the marc modification templates when batch
> > editing bibliographic records?
> 
> Investigating.. I have a feeling his patchset predates it and I missed this
> case ! :(

Need to be investigated.

(In reply to Jonathan Druart from comment #331)
> I know librarians can have weird needs but, should we really offer the
> "custom" preset? I am reading the tests right now and some combinations are
> doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1
> "action" column with the predefined ones? (not considering this question a
> blocker, but I would be happy to get an answer).

Still waiting for an answer.

See also the "warning"s and "fixme"s from the patch "Improve readbility of
tests".

-- 
You are receiving this mail because:
You are watching all bug changes.