[Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 1 21:28:52 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #8)
> sub article_requests_current {
> return $self->article_requests->filter_by_current;
> 
> sub article_requests_finished {
> return $self->article_requests->filter_by_finished;
> 
> How are they useful? Callers can call $biblio->article_requests->filter_by_*

Agreed. My plan was to remove them. But it felt like it was better to keep them
to prove no behavior change. And then remove them while refactoring the
controllers. And why not just remove the controllers if I had the chance :-D

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list