[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat Oct 2 00:28:27 CEST 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
Tomás Cohen Arazi <tomascohen at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125269|0 |1
is obsolete| |
--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125641
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125641&action=edit
Bug 29083: Update article requests-related Koha::Patron methods to use
relationships
This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.
No behavior change should take place.
To test:
1. Apply the unit tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Patron.t \
t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list