[Koha-bugs] [Bug 29133] Wrong string format in select2.inc

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125460|0                           |1
        is obsolete|                            |
 Attachment #125461|0                           |1
        is obsolete|                            |

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125646&action=edit
Bug 29133: Correct select2 strings

We are using 'max'/'min' when the arguments are 'maximum'/'minimum'.
Also using %n, %d when only %s is working in .format()

Have a look at
https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js
It's Select2 v.4.0.13, the one we are using. We should match what's
there.

Test plan:
Bug 29002 is using minimumInputLength, you can see the difference when
selecting a patron:
 "Please enter %s or more characters"
vs
 "Please enter 3 or more characters"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.