[Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> There was no test plan... 

It's impossible to provide a full test plan for this kind of patches. If the QA
script passes it's already a good step for this one, as the compilation will be
checked.

> Should these files be updated as well?

> t/db_dependent/Circulation/IsItemIssued.t:use Koha::DateUtils;
> t/db_dependent/Items.t:use Koha::DateUtils;
> t/db_dependent/Koha/SearchEngine/Indexer.t:use Koha::DateUtils;
> t/db_dependent/Koha/Template/Plugin/TablesSettings.t:use Koha::DateUtils;
> t/db_dependent/Log.t:use Koha::DateUtils;
> t/db_dependent/SIP/ILS.t:use Koha::DateUtils;
> t/db_dependent/Search/History.t:use_ok('Koha::DateUtils');

We can remove the use statement as it's not used.

> debian/templates/plack.psgi:use Koha::DateUtils;

I don't know about this one, we preload it but without the import. I prefer to
keep it like that.

-- 
You are receiving this mail because:
You are watching all bug changes.