[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    my @hold_not_allowed_itypes = Koha::CirculationRules->search(
+        {
+            rule_name    => 'holdallowed',
+            branchcode   => undef,
+            categorycode => undef,
+            rule_value   => 'not_allowed',
+        }
+    )->get_column('itemtype');

I have my doubts here btw.
This is too simple. You are looking at circ rules with exception for various
combinations of category, itemtype etc.
You cant just do a get_column here. This depends on context.
Please clarify and add tests.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.