[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Marcel de Rooy from comment #23)
> > +    my @hold_not_allowed_itypes = Koha::CirculationRules->search(
> > +        {
> > +            rule_name    => 'holdallowed',
> > +            branchcode   => undef,
> > +            categorycode => undef,
> > +            rule_value   => 'not_allowed',
> > +        }
> > +    )->get_column('itemtype');
> > 
> > I have my doubts here btw.
> > This is too simple. You are looking at circ rules with exception for various
> > combinations of category, itemtype etc.
> > You cant just do a get_column here. This depends on context.
> > Please clarify and add tests.
> 
> Which context? The logged in branch?
> Here we are not in C4::Reserves, we don't want to offer all the complexity
> of CanItemBeReserved. As said previously I am not adding new code of
> functionality (apart for the additional damaged check).

Ok. If this is a reflection of what we did already, I cant justify to fail it
:) Koha never fails!
Back to SO

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.