[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This is really ugly.

my $scriptFile = "$scriptDir/../../../misc/cronjobs/advance_notices.pl";
open my $scriptfh, "<", $scriptFile or die "Failed to open $scriptFile: $!";
while (<$scriptfh>) {
    $scriptContent .= $_;
}
etc
eval $script; ## no critic (StringyEval)

What about moving stuff from scripts into a module, and test it properly?

imho we should never pqa/push this kind of stuff. Surely, we dont need a rule
for all bad coding practices? :)

-- 
You are receiving this mail because:
You are watching all bug changes.