[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 while ( my $item = $items->next ) {
-    $norequests = 0
-      if $norequests
-        && !$item->withdrawn
-        && !$item->itemlost
-        && ($item->notforloan < 0 || not $item->notforloan )
-        && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan
-        && $item->itemnumber;
-
     $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( {
item => $item, patron => $patron } )
       unless $allow_onshelf_holds;

Could this loop be done smarter now?

opac/opac-ISBDdetail.pl
-        && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan
opac/opac-MARCdetail.pl
-        && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan
opac-detail.pl
-        && !$itemtypes->{$itm->{'itype'}}->{notforloan}
Added a follow-up that looks at notforloan but effective is still another
story.

-- 
You are receiving this mail because:
You are watching all bug changes.