[Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but besides the small change David pointed out, there are a couple
of smaller issues here:

$("#cancellation-text").html(`Are you sure you want to cancel hold of
<b>${biblio_title}</b> for <b>${borrower_name}</b>?`);

At the moment, this message is not translatable. Please have a look at how to
use _() to make sure that the strings are picked up for translation by our
tools.

the <b> mark-up is also not recommended as this will break the strings into
pieces and leaves you with a single "for" to translate. That is really hard to
get right without further context (at least in German it is :) ). Better to not
highlight single parts of sentences like this.

I believe we did have a rule about quotes... but I cannot find it :( The rule I
remember was to use double quotes around JS, as languages like French need to
be able to use single quotes in their translations and single quotes often
broke things for them as for the translators it's not obvious when they are
translating JS and need to escape.

Please let me know if we can help you making these adjustments!

-- 
You are receiving this mail because:
You are watching all bug changes.