[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Thanks Nick!

(In reply to Nick Clemens from comment #35)
> On additem.pl attempting to edit a repeated field only adds the value from
> the first field to all the repeated attempts, this is true on master as well

I don't understand. Can you detail please?
I made 952$u repeatable and I can create several subfields, edit, save. And it
is working as I expect.

> Blockers:
> - Checkbox to 'delete' a subfield does not work, no changes are made

Will be fixed!

> - If number of items to edit is over MaxItemsToDisplayForBatchMod, but below
> MaxItemsToProcessForBatchMod the form does not show and no edits can be made

Cannot recreate.
Set MaxItemsToDisplayForBatchMod=2, MaxItemsToProcessForBatchMod=4, edit 3
barcodes.

I see "Too many items (3): You are editing more than 2 items in a batch, items
will not be shown." and there is the form.

> - MaxItemsToDisplayForBatchMod is not respected on background_jobs.pl, all
> items are displayed

On purpose, do you think we should restore it? In my understanding it was to
avoid the table on the first screen.

> - Progress may not be updated - hard to tell, was 0 until page reload loaded
> the full item list

It actually hide something different, the transaction was not made at the
correct level. I think we should commit when an item has been modified. The
previous behaviour was failing the whole job if something went wrong for an
item. It's fixed now.

> - Batch deletion failed: Cannot enqueue this job. (The error was: Can't use
> string ("on") as an ARRAY ref while "strict refs" in use at
> /kohadevbox/koha/Koha/BackgroundJob/BatchDeleteItem.pm line 214. , see the
> Koha log file for more information).

Hum, cannot recreate that, but line 214 is: 
  214     my $delete_biblios = @{ $args->{delete_biblios} || [] };

That does not seem related at all, can you retry please?

Note that I have tested on top of the bug 27526 follow-up, not pushed yet. So
results may vary.

-- 
You are receiving this mail because:
You are watching all bug changes.