[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #18)
> (In reply to Jonathan Druart from comment #16)
> > Still not working for me
> > 
> > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Truncated
> > incorrect DOUBLE value: 'no' at /kohadevbox/koha/C4/Installer.pm line 736
> > 
> > 10.5.12-MariaDB-1
> 
> Obscure message, caused by strict SQL.
> 
> > Why not simply:
> > 
> > UPDATE systempreferences SET value=0 WHERE
> > variable='LoadSearchHistoryToTheFirstLoggedUser' and value="no";
> 
> Current condition catches everything outside '1'

Yes, and so it catches "yes". I won't block the patch because of that, but I
don't understand how it can be more correct than setting to "0" when was "no".

The problem was with "no":
-                   no : "Don't add"
+                   0: "Don't add"

-- 
You are receiving this mail because:
You are watching all bug changes.