[Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 13 15:13:51 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #18)
> Trying to revive the discussion here. What about this patch?

kidclamp> should we just address this per case? do we need a global solution?
i.e. we know if we touch an object variable we can introduce this problem, so
we should know to fetch from storage if an unblessed is need
Joubu> kidclamp: do you mean we should call ->get_from_storage->unblessed
before we call actionlog? 
Joubu> basically what my patch does but explicitely
kidclamp> yes, asking why we want to build it into logging rather than place
responsibility on the caller
Joubu> to not forget occurrences :)
Joubu> we could create a new object instead of modifying the one passed

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list