[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #47)
> (In reply to Jonathan Druart from comment #38)
> > (In reply to Nick Clemens from comment #35)
> > > On additem.pl attempting to edit a repeated field only adds the value from
> > > the first field to all the repeated attempts, this is true on master as well
> > 
> > I don't understand. Can you detail please?
> > I made 952$u repeatable and I can create several subfields, edit, save. And
> > it is working as I expect.
> 
> I added new subfield "A" - the values repeat
> On master I also made "o" repeatable and had same issue
> With these patches "o" worked fine, "A" always repeated first value and
> during batch mod when I used the "A" field with two values a single record
> was often skipped (18 of 19 items updated), or all 19 would be updated, but
> 18 would repeat first value and the 19th would get the second
> Something is weird there 

I do recreate, but it's the expected behaviour I think.
If you have "A" defined for the default framework, but not for BK, then the
items using BK won't have the values added to "A".

> > > - MaxItemsToDisplayForBatchMod is not respected on background_jobs.pl, all
> > > items are displayed
> > 
> > On purpose, do you think we should restore it? In my understanding it was to
> > avoid the table on the first screen.
> 
> On master the items are not shown in results, I think we should do the same
> here - don't show more items than allowed in a batch modify job result

Ok, will follow-up.

> > > - Batch deletion failed: Cannot enqueue this job. (The error was: Can't use
> > > string ("on") as an ARRAY ref while "strict refs" in use at
> > > /kohadevbox/koha/Koha/BackgroundJob/BatchDeleteItem.pm line 214. , see the
> > > Koha log file for more information).
> > 
> > Hum, cannot recreate that, but line 214 is: 
> >   214     my $delete_biblios = @{ $args->{delete_biblios} || [] };
> > 
> > That does not seem related at all, can you retry please?
> 
> I get the error when I check "Delete records if no items remain."

Oops, silly mistake. Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.