[Koha-bugs] [Bug 29238] Cataloging cron jobs are not logged

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29238

--- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> ---
Created attachment 126242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126242&action=edit
Bug 29238 - Cataloging cron jobs are not logged

Here's an example patch. Is misc/migration_tools/remove_unused_authorities.pl
maybe broken on master? Perl complained that DelAuthority() on line 102 was
undefined, so I changed the "use" statement. But otherwise, the patch just adds
a cronlogaction import and call when the script is run.

Generally, `cronlogaction()` is called during dry runs like
`remove_unused_authorities.pl --test` but not if the script is printing its
usage information (e.g. `remove_unused_authorities.pl --help`). It'd be much
more complicated to only log when data actually changes.

Testing plan:

1. set CronjobLog to "Log"
2. Run the three cron jobs
   `perl misc/link_bibs_to_authorities.pl; perl
misc/cronjobs/merge_authorities.pl -b; perl
misc/migration_tools/remove_unused_authorities.pl --confirm`
3. Visit the log viewer /cgi-bin/koha/tools/viewlog.pl, select the "Cron jobs"
module, & note it's empty
4. apply the patch
5. Repeat steps 2 & 3 but note the cron logs aren't empty

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.