[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

--- Comment #32 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Jonathan Druart from comment #31)
> Any good reasons to not have '! $self->expiration' instead of the not
> defined, eq '' checks?
> 
> +    if ( C4::Context->preference('DefaultHoldExpirationdate')
> +        and ( not defined $self->expirationdate or $self->expirationdate eq
> '' ) ){

Hmm, most likely I have first used just not defined, then after testing
realized we also need to check empty values and just added it without
remembering !$self->expirationdate. So probably no good reasons there.

-- 
You are receiving this mail because:
You are watching all bug changes.