[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Victor Grousset/tuxayo from comment #7)
> 'Can\'t locate Search/Elasticsearch/CxnPool/Fluid.pm in @INC (you may need
> to install the Search::Elasticsearch::CxnPool::Fluid module)
> 
> This Fluid module seems to not exists.
> 
> In
> t/db_dependent/Koha/SearchEngine/Elasticsearch.t
> line 110
> if we change
> cxn_pool => 'Fluid'
> to
> cxn_pool => 'Fluid_LOL_LOL_LOL'
> 
> we get
> 'Can\'t locate Search/Elasticsearch/CxnPool/Fluid_LOL_LOL_LOL.pm in @INC
> (you may need to install the
> Search::Elasticsearch::CxnPool::Fluid_LOL_LOL_LOL module)
> 
> No idea what this means o_o

Well, the second makes sense, you have made up a moduel that doesn't exist :-)

For the first, I suspect a configuration issue, I cannot recreate the failures

(In reply to Victor Grousset/tuxayo from comment #9)
> Not ready for QA, the two tests on sandboxes can't have ran the test and the 
> test on comment 7 was a failure.

Cannot recreate, passing QA

I will note, there is some duplicated code here, but I think fixing the issue
is important, handling these fields separately makes sense. Could generate a
subroutine with options in future, but I think this is straightforward and
readable.

-- 
You are receiving this mail because:
You are watching all bug changes.