[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #389 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #388)
> Regression found, the order of the subfields (introduced by bug 7882) is not
> kept.
> 
> To recreate:
> Turn on MARCOverlayRules
> Edit a record
> Change the order of subfields
> Save
> Edit again
> => The order hasn't been saved.

diff --git a/Koha/MarcOverlayRules.pm b/Koha/MarcOverlayRules.pm
index 11b33d1928b..70500d00d2f 100644
--- a/Koha/MarcOverlayRules.pm
+++ b/Koha/MarcOverlayRules.pm
@@ -149,7 +149,7 @@ sub merge_records {
     my $hash_field_data = sub {
         my ($field) = @_;
         my $indicators = join("\x1E", map { $field->indicator($_) } (1, 2));
-        return $indicators . "\x1E" . join("\x1E", sort map { join "\x1E",
@{$_} } $field->subfields());
+        return $indicators . "\x1E" . join("\x1E", map { join "\x1E", @{$_} }
$field->subfields());
     };

     my $diff_by_key = sub {

I think it's because of this 'sort', but there are 2 other sort calls in this
method, not sure how/why they are useful.

-- 
You are receiving this mail because:
You are watching all bug changes.