[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #781 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I planned to run qa tools on every patch. But I would recommend that you would
have done the same. It is just too much..
So just pasting the last few, and leaving it there.

 FAIL   svc/recall
   FAIL   critic
                Subroutine "new" called using indirect syntax at line 30,
column 13. See page 349 of PBP.
   OK     file permissions
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   FAIL   valid
                Bareword "dt_from_string" not allowed while "strict subs" in
use
                Bareword "dt_from_string" not allowed while "strict subs" in
use

 FAIL   recalls/request.pl
   OK     critic
   OK     file permissions
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 33)
   OK     git manipulation
   OK     pod
   SKIP   spelling
   FAIL   valid
                Bareword "dt_from_string" not allowed while "strict subs" in
use
                Bareword "dt_from_string" not allowed while "strict subs" in
use

 FAIL   recalls/recalls_waiting.pl
   FAIL   critic
                Subroutine "new" called using indirect syntax at line 28,
column 13. See page 349 of PBP.
   OK     file permissions
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 34)
   OK     git manipulation
   OK     pod
   SKIP   spelling
   FAIL   valid
                Bareword "dt_from_string" not allowed while "strict subs" in
use
                Bareword "dt_from_string" not allowed while "strict subs" in
use

-- 
You are receiving this mail because:
You are watching all bug changes.