[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #783 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
All appreciation for your hard work and perseverance. This feature will be
welcomed by many libraries. So it is great that you share it.

I am just stumbling over its size. It might be a reason why this patch set
takes so long too.

Just picking the largest patches:

 7 files changed, 1093 insertions(+), 1 deletion(-)
 16 files changed, 1153 insertions(+), 12 deletions(-)
 15 files changed, 665 insertions(+), 4 deletions(-)
 44 files changed, 2090 insertions(+), 12 deletions(-)

We're adding over 5000 lines here on one report. Clearly, this report should
have broken down in several reports under an omnibus (imho).
Certainly, making a good split is (much) more work for you. But how much time
did you spend on rebasing the whole thing over and over again?

How should we do a good QA job when adding so much code. I did a "diagonal" QA
now. Few comments, asked a few questions now. Most looks good to me. But I cant
do a full QA in some hours on such large patches. My intuition tells me that
there will be quite a few bugs coming in now. And at a bad time, since we are
close to release date..

Note that I am not asking you to split it up now. But perhaps we should define
some guidelines on handling this kind of larger developments, making it easier
to push well split portions and allowing still 'unused' code to go in already
when there is a community commitment to finish the job?

Since we need more people to test this code, I am putting the status back to
Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.