[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #391 from David Gustafsson <glasklas at gmail.com> ---
(In reply to David Gustafsson from comment #390)
> > I think it's because of this 'sort', but there are 2 other sort calls in
> > this method, not sure how/why they are useful.
> 
> There might be some other issue that causes this issue, but it's not those
> sorts if I'm not completely misguided. That's a hash function for comparing
> field data, and the data sorted will not be written back to the record.

Just realized it might actually be the reason, but in a round-about way. If
just changing the order of fields without modifying the data, they will still
be considered identical so the old value will be kept. This is most likely the
cause. If we remove the sort we risk writing an extra entry if for example the
order has been changed for a record in Koha, and an external record with the
same data in a different order is imported, as it will be considered a new
field entry. Will think about how to handle this, hopefully without not
complicating the merge algorithm too much.

-- 
You are receiving this mail because:
You are watching all bug changes.