[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #360 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 120644
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120644
Bug 15516: Relevant controller changes and tests

Review of attachment 120644:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15516&attachment=120644)
-----------------------------------------------------------------

::: C4/Reserves.pm
@@ +1113,4 @@
>      logaction( 'HOLDS', 'MODIFY', $hold->reserve_id, Dumper($hold->unblessed) )
>          if C4::Context->preference('HoldsLog');
>  
> +    # if this hold was part of a group, cancel other holds in the group

This causes every hold with a null hold_group_id to be cancelled. This needs to
be wrapped in a check for $hold_group_id first!

@@ +1222,5 @@
>          # Complete transfer if one exists
>          my $transfer = $hold->item->get_transfer;
>          $transfer->receive if $transfer;
> +
> +        # if this hold was part of a group, cancel other holds in the group

This causes every hold with a null hold_group_id to be cancelled. This needs to
be wrapped in a check for $hold_group_id first!

-- 
You are receiving this mail because:
You are watching all bug changes.