[Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 26 12:31:50 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I should note.. my final patch there is an alternative to all that preceded
it.. the idea being that we throw an exception and thus force developers to
consider their unblessed uses and call get_from_storage appropriately
themselves.

No.. it does NOT fix the specific issue here.. but rather catches it so we can
fix it in all the right locations methodically and prevent future occurrences
from coming up..

I think this would be very helpful for spotting the exact same case that comes
up in API responses as well as logging.. and perhaps some template issues too
as we seem to call unblessed a fair bit in controller code (in a lot of cases I
think needlessly).

I'd be tempted to push my version for the beginning of next cycle to catch the
errant cases it's bound to surface.. and push Peter's this cycle for just this
branch as a temporary middle step for the next stable.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list