[Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Oct 26 15:19:38 CEST 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. I think for this bug description.. we should either properly unbless
everything in the object or throw an exception for cases where unbless is
likely to pass back unexpected nested objects.
I think we should move the middle two patches of Jonathans to bug 28692 for
handling the logaction case.. in that case I like the idea of passing
Koha::Objects wherever we can and handling the storage/stringification/diffing
inside that logaction method. My vote, at the moment, is to use json with utf8
and canonical enabled.. thus sidestepping some of the flaws of unblessed (as
TO_JSON handles them). Longer term, for log size issues I feel like
json-patch, json-merge-patch or perhaps our custom json based diff from
Koha::Patron store should be used.. but I'm not sure how that looks when output
in the log viewer.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list