[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #19)
> (In reply to Martin Renvoize from comment #18)
> > I still think it might be a good idea to pass the search string from the
> > controller instead of constructing it in two places.. keeps it dry.
> 
> Not sure what you mean here.
> Constructing the query for components and volumes kind of the same? The
> shared logic could be moved?

Constructing the queries for 'components parts' and 'volumes' is similar, but
not the same.. it makes sense to have methods for the two distinctly.

What I'm talking about is that the XSLT's also construct the same search query
strings.. it would be cleaner to pass the constructed query string to the xslt
as a parameter so we're re-using the code that builds the query.

-- 
You are receiving this mail because:
You are watching all bug changes.