[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 29 08:20:09 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > +sub multivalue_preference {
> > +    my ( $self, $preference ) = @_;
> > +
> > +    my $syspref = $self->preference($preference) // q{};
> > +    my $values  = [ split qr{\|}, $syspref ];
> > +
> > +    return $values;
> > +}
> > 
> > I agree that we need a parameter here to pass other separators.
> > Multi value, multi sepa :)
> 
> Counter proposal:
> 1. Accept this as-is
> 2. Implement a nice UI to abstract users from the separator being used
> 3. Migrate sysprefs into  using this

Point 1: No ! :)
Point 2: Fine with me.
Point 3: Great. (Just gradually move away from sending the sepa param.)

You need 5 mins to do the thing. We need 5 years for the rest ;)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list