[Koha-bugs] [Bug 28729] Return-path header not set in emails

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729

--- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #53)
> The fix works fine on itself, but it feels like a fix on the wrong place.
> And a fix that more or less assumes that we are not calling send_or_die with
> the from parameter; this seems to the case in the current codebase where we
> only pass transport.

Not sure what you mean here.. we account for 'from' being passed... the key
challenge is understanding that the 'from' you might pass send_or_die is the
envelope address and not the email from.

> We should be fixing create too (origin of this problem). I will postpone
> these things to 29365. The test passes, could be improved too.
> 
> This serves as a minimal fix, allowing backports.

I'm not sure what you mean about fixing create?  Sender is a bad name for this
parameter and it was used due to a weird internal workaround provided by
Mail::Sendmail..  I don't know that you could easily move the fix into create..
short of create producing the wrapper and returning a structure that's all
nested one level deeper.

-- 
You are receiving this mail because:
You are watching all bug changes.