From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 08:09:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 06:09:17 +0000
Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
In-Reply-To: <bug-28279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28279-70-EPnvEvQFN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ah, I think we need someone else testing.
Maybe Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 08:28:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 06:28:01 +0000
Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record
 metadata
In-Reply-To: <bug-28902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28902-70-FEjRloBaZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |In record search or
      release notes|                            |details, label is now with
                   |                            |grey color (for example
                   |                            |"Author:") and metadata
                   |                            |with black color (for
                   |                            |example "J.R.R Tolkien").
                   |                            |For both OPAC and staff
                   |                            |interface.
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 08:50:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 06:50:18 +0000
Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-E8ygKgSQU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Is it at least OK to change submit button "Login" to "Log in" ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 10:16:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 08:16:17 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
 Koha::Plugins
In-Reply-To: <bug-28026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28026-70-GeQ20KxxEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026

--- Comment #36 from Mark Hofstetter <koha at trust-box.at> ---
this is a rehash of my previous argument, I'll look at the code. 

How to you gurantee that the plugins are executed in a certain order because
that's what you somehow imply by "method that takes the output of
the first plugin and uses it as the input for the next plugin [..]"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 10:19:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 08:19:15 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-OmxEVtcUXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmmm, if that's the case I'm not sure I understand why there are tests for the
search helper.. surely that will generally return multiple results?

I'm vaguely feeling like a single page web app would actually grab the full AV
list when it first needs it and cache it locally to use for subsequent uses..
but as Koha isn't at that point yet we're unlikely to be able to really utilise
that methodology..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:01:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:01:36 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-0jbyQWxnz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22844


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
[Bug 22844] Simplify the process of selecting database columns for system
preferences
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:01:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:01:36 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-nvaObY0wzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28392


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392
[Bug 28392] streettype and B_streettype cannot be hidden via
BorrowerUnwantedField
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:06:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:06:38 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-IdEoz9ItnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124267|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 124318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124318&action=edit
Since preference OpacMainUserBlock is an HTML customization, there is an HTML
tags with id="opacmainuserblock" and one with id="OpacMainUserBlock".

I think template block "koha_news_block" should add a class (lowercase) instead
of an id.
It fixes the bug and also it may be used several times in same page in the
future.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock"

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:06:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:06:54 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-UfyiyBFmuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:26:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:26:49 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-Os9XbTC5pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|andrew.isherwood at ptfs-europ |
                   |e.com                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 11:55:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 09:55:25 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-VzlpZwXlj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #201 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I sent the following email to Chris yesterday:

"""
A couple of questions:
  * Having the FK means the ON UPDATE SET NULL clause will apply. We
will "lose" the links but as the ids can be reused several times I
think it makes sense.
  * We will need to update existing entries (set to NULL when 0 or
deleted), we can take the opportunity to remove the rows with
biblionumber=null, itemnumber=null, biblionumber=null.
"""

his reply:
"""
The table is mainly just report the usage of electronic resources. So
if the resource is deleted it doesn't make sense to keep how many
times it whats viewed, so I think the FK will be fine
"""

Maybe we should then have a delete cascade on the biblionumber.

Please help here, I am not willing to follow-up myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:23:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:23:20 +0000
Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self
 registration form is submited to the server,
 and the server side form validation fails.
In-Reply-To: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28930-70-mDevV0JT72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master
           Assignee|oleonard at myacpl.org         |andreas.jonsson at kreablo.se
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:25:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:25:49 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-ldIiY4D1SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #202 from Ere Maijala <ere.maijala at helsinki.fi> ---
Jonathan, I've lost track of things a bit here, but since linktracker also
tracks clicks per borrower, would it still be useful to keep the records? Also,
if cascade delete would be used, would it only affect biblionumber, not
itemnumber or borrowernumber? 
Or to put it another way, if we don't want to keep the records after the biblio
is deleted, why is biblionumber nullable in the table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:29:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:29:03 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
 Koha::Plugins
In-Reply-To: <bug-28026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28026-70-3t81TUGg97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Mark Hofstetter from comment #36)
> this is a rehash of my previous argument, I'll look at the code. 
> 
> How to you gurantee that the plugins are executed in a certain order because
> that's what you somehow imply by "method that takes the output of
> the first plugin and uses it as the input for the next plugin [..]"

There is no guarantee, and plugins should be written with that understanding.
It would be possible to some day give all plugins a "priority" but at this time
every plugin author should understand their plugin could be run first, last and
or anywhere in between.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:49:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:49:52 +0000
Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module
In-Reply-To: <bug-28903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28903-70-KzhZO890BN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to pierre.genty from comment #11)
> In 19.11, the arrow keys use to directly pull down the menu

Confirmed. This appears to be a known bug in Select2:
https://github.com/select2/select2/issues/3472.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:54:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:54:49 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7FjaMeYXeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124319&action=edit
Bug 28854: Add ability to create and circulate item bundles

This patch adds the ability to attach item bundles to biblio records. Item
bundles can then be circulated as with normal items.

Upon attaching an item to one of these item bundles, the item is automatically
marked as not for loan at it's original host biblio record.

When returning a bundle, the list of items that are part of this bundle
will be displayed, and a verification form is exposed requireing the
librarian to scan item barcodes to verify their presence. Should a bundle
be found to have items missing they will be marked as lost.

Bundles can also be used in the inventory tool as a filter.

Test plan:
0.  Apply the patch, run updatedatabase + update_dbix_class_files
1.  Create a new bundle record.
1a. Create a biblio record with leader position 7 set to 'c' for collection.
1b. Create an item for this biblio record.
1c. You should now see a new 'Bundle' button next to the item in the holdings
    table.
    Test: Verify that this 'Bundle' button only appears for biblio's where
leader
    position 7 is not 'c' for collection
1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items
    to the bundle.
    Test: Enter a non-existant barcode, submit and confirm you recieve an error
message.
    Test: Enter an existing barcode, submit and note the success message.
    Test: Enter the same barcode as above, submit and note the warning message.
    Test: Add a second item to the bib and try bundling one of the above
    items into this second item, note the error message.
2.  Open a new tab and look at the holdings data for one of the items you
attached
    to a bundle in step 1.
    Test: Verify that the holdings status displays 'Not for loan'.
    Test: Verify that the holdings status show which bundle the item has been
    attached to.
3.  Perform a checkout on the first bundle item.
    Test: Checkout should proceed as normal, obeying the circulation
    rules for the item type you chose to convert into a bundle.
4.  Perform a checkin on the first bundle item.
    Test: You should be presented with a modal that contains a list of items
    contained in the bundle and a test box for entering item barcodes.
    Test: Enter some of the barcodes for items in the bundle into the box and
submit.
    The bundle item should have been marked as returned, you should also
    have been notified of missing items and have the ability to print an
    updated contents list.
    Test: Verify that the items you did not enter barcodes for are now
    marked as lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:56:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:56:28 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-L7JrniQqD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I wanted to start getting feedback for this so have uploaded a patch for
testing.

It includes a basic test plan, but I'm sure I've missed some area's :( so would
appreciate feedback.

I also realise it still needs unit tests adding for the various object methods
introduced before it'll go through QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 12:56:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 10:56:38 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-0KCASbvRa4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:00:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:00:16 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Wp62CfylHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new feature adds the
      release notes|                            |ability to create item
                   |                            |bundles for loans.
                   |                            |
                   |                            |One can
                   |                            |create a new collection
                   |                            |level biblio record and add
                   |                            |items to it as normal.
                   |                            |Those items can then be
                   |                            |converted to bundles by
                   |                            |adding existing items to
                   |                            |them using their barcodes.
                   |                            |The items will be marked as
                   |                            |'not for loan' in their
                   |                            |original parent records.
                   |                            |
                   |                            |Bundle items follow normal
                   |                            |circulation rules for
                   |                            |checkout. Upon check-in a
                   |                            |new verification step is
                   |                            |added where by the
                   |                            |librarian is expected to
                   |                            |scan each constituent item
                   |                            |to varify it's presence in
                   |                            |the bundle. If an item is
                   |                            |missing from the bundle it
                   |                            |is marked as lost with a
                   |                            |new lost - Missing from
                   |                            |bundle value.  If an item
                   |                            |is found that is not
                   |                            |expected to be in the
                   |                            |bundle it it highlighted to
                   |                            |the librarian after
                   |                            |check-in so it can be
                   |                            |placed to one side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:01:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:01:03 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KlM442VoWE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:01:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:01:24 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nH5SMarp22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:01:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:01:37 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-HLEPCJTOTO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:07:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:07:31 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-S2ednZH1OY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:38:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:38:40 +0000
Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self
 registration form is submited to the server,
 and the server side form validation fails.
In-Reply-To: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28930-70-4COsrreOI3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:38:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:38:43 +0000
Subject: [Koha-bugs] [Bug 28930] Cardnumber is lost if an invalid self
 registration form is submited to the server,
 and the server side form validation fails.
In-Reply-To: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28930-70-JJAAZH6WGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124278|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124320&action=edit
Bug 28930: Keep cardnumber be editable after server side form validation fails
during self registration.

Test plan:

- Enable the system preference PatronSelfRegistration
- Make sure  PatronSelfRegistrationBorrowerUnwantedField does not
  contain cardnumber.
- Set the system preference  GDPR_Policy to "Enforce".
- In the OPAC click "Log in to your account" and "Register here".
- Fill out the form with valid data, but make sure you leave the
  checkbox under "GDPR consent" unchecked.
- Submit the form
- You will get back the form with the error message "You have not filled
  out all required fields. Please fill in all missing fields and
  resubmit."
- Without patch: cardnumber is not editable, and there is no input
  element for borrower_cardnumber (so the cardnumber will be lost when
  resubmitting the form)
- With patch: cardnumber is editable.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:41:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:41:35 +0000
Subject: [Koha-bugs] [Bug 28934] New: Correct markup of GDPR consent in OPAC
 patron entry
Message-ID: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

            Bug ID: 28934
           Summary: Correct markup of GDPR consent in OPAC patron entry
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 20819

The markup around the GDPR checkbox in the OPAC self registration/update form
could be improved to make it more consistent with other form fields.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
[Bug 20819] GDPR: Add a consent field for processing personal data in account
menu and self-registration
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:41:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:41:35 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-HPPRoC0EGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28934


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934
[Bug 28934] Correct markup of GDPR consent in OPAC patron entry
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 13:47:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 11:47:16 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-CEFWpdJZGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Tomás Cohen Arazi from comment #19)
> > $template->param(
> >     outstanding_debits => scalar $patron->account->outstanding_debits,
> >     items              => scalar $biblio->items,
> > );
> 
> I'd personally prefer to not have to forget the "scalar" (and almost always
> use iterator) and explicitly ask for the list when I need it (->as_list).
> 
> Not blocking, just expressing my opinion :)

I'm of two minds.. in some ways perls contextual returns are lovely and DWIM..
but in other cases I'd really rather it required me to be specific.

DBIC actually gets around this by having a context ignorant accessor.. adding
_rs to accessor methods (search, relationships) will force list context and
give you back an iterator rather than getting clever with wantarray.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:07:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:07:36 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-dWwEewkw3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #292 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124321&action=edit
Bug 20256: (follow-up) Don't filter if no libraries are restricted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:14:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:14:28 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-k7OLh9IoLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:14:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:14:31 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-xNfOVugPy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #23)
> (In reply to Jonathan Druart from comment #21)
> > (In reply to Tomás Cohen Arazi from comment #19)
> > > $template->param(
> > >     outstanding_debits => scalar $patron->account->outstanding_debits,
> > >     items              => scalar $biblio->items,
> > > );
> > 
> > I'd personally prefer to not have to forget the "scalar" (and almost always
> > use iterator) and explicitly ask for the list when I need it (->as_list).
> > 
> > Not blocking, just expressing my opinion :)
> 
> I'm of two minds.. in some ways perls contextual returns are lovely and
> DWIM.. but in other cases I'd really rather it required me to be specific.
> 
> DBIC actually gets around this by having a context ignorant accessor..
> adding _rs to accessor methods (search, relationships) will force list
> context and give you back an iterator rather than getting clever with
> wantarray.

I understand and agree Koha::Objects being too clever might be counter
productive. What I found was an inconsistent behavior. Getting rid of the use
of wantarray should be discussed broadly, as a big behavior change (think
plugins, etc).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:14:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:14:32 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-aFy7CKrEbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124322&action=edit
Bug 28934: Correct markup of GDPR consent in OPAC patron entry

This patch makes changes to the markup around the GDPR consent checkbox
in the OPAC self-registration / update page to make it more consistent
with other form fields on the page.

The patch also adds some missing attributes which are required to enable
JavaScript validation of the checkbox.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and Enable the system
  preference PatronSelfRegistration.
- Set the system preference GDPR_Policy to "Enforce".
- Go to the OPAC and click the "Register here" link.
- Under the "GDPR consent" heading near the bottom of the page,
  confirm that the "I agree" checkbox lines up with other form fields on
  the page, and that the "Required" label lines up below it.
- Submit the form without checking the GDPR consent checkbox.
- The form should not be submitted, and a "This field is
  required" message should appear next to the checkbox label.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:24:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:24:22 +0000
Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden
In-Reply-To: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22866-70-5YqOTPxvvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:24:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:24:26 +0000
Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden
In-Reply-To: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22866-70-VfcZyfyMlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124324&action=edit
Bug 22866: Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:27:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:27:58 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-UziTOBiCzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124193|0                           |1
        is obsolete|                            |

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 124328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124328&action=edit
Bug 18747: Select All in Add Patron Option in Patron Lists only selects the
first 20 entries

This patch corrects the JavaScript functions for the "select all" and
"clear all" action when viewing patrons in a list. Before this
correction, checkboxes which were previously in hidden table rows would
not be checked.

To test, apply the patch and go to Patrons -> Patron Lists

- View a patron list
- If necessary, add multiple patrons to the list so that the number
  exceeds 20.
- Change the number of entries shown by the DataTable: Show [ 50 ]
  entries.
- Click "Select all." All visible checkboxes should be checked.
- Click "Clear all." All checkboxes should be unchecked.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:28:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:28:37 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-SsYj9kIboh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #8 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:46:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:46:53 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-tqtDeBzJEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #203 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Ere Maijala from comment #202)
> Jonathan, I've lost track of things a bit here, but since linktracker also
> tracks clicks per borrower, would it still be useful to keep the records?
> Also, if cascade delete would be used, would it only affect biblionumber,
> not itemnumber or borrowernumber? 

In my understanding we want to keep track of the number of clicks on the
records, so even if the patron of item is deleted we should keep the entry.

> Or to put it another way, if we don't want to keep the records after the
> biblio is deleted, why is biblionumber nullable in the table?

Correct, that is not consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:51:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:51:15 +0000
Subject: [Koha-bugs] [Bug 28936] New: Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
Message-ID: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

            Bug ID: 28936
           Summary: Sort1 and Sort2 should be included in
                    BorrowerUnwantedField and related sysprefs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 22844

Sort1 and Sort2 are not included in the checkboxes for BorrowerUnwatedField,
PatronSelfRegistrationBorrowerUnwantedField,
PatronSelfModificationBorrowerUnwantedField, BorrowerMandatoryField, and
PatronSelfRegistrationBorrowerMandatoryField. We should include them as options
on these sysprefs.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
[Bug 22844] Simplify the process of selecting database columns for system
preferences
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:51:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:51:15 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-nrM5xgbGb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936
[Bug 28936] Sort1 and Sort2 should be included in BorrowerUnwantedField and
related sysprefs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:52:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:52:05 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-HVB1vxSqmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28936

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I made a separate bug for sort1 and sort2, since they're just not in these
sysprefs at all. That's bug 28936.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 14:52:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 12:52:05 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-CgaI7H8D9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28392

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:01:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:01:44 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-CXFDeLyueE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:01:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:01:48 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-bLnh6wWvg6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122736|0                           |1
        is obsolete|                            |
 Attachment #122751|0                           |1
        is obsolete|                            |

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124329&action=edit
Bug 20529: Fix "Return to results" link broken by a double quote

(in the search query)

cause: decodeURIComponent used when URI encoding was necessary. (At
least in main usecase of this feature)
It could have been a copy and paste error. From the above
browseRecords() function.

== Test plan ==
1. Search in the staff catalogue «a "alice"»
     Replace a and alice with whatever than will return a result for you
2. Click on the first result
3. Check the "Return to results" link
     It should be like
     staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a
     This is the bug. Because when clicking the link, your search will be
     'kw,wrdl: a'
     instead of
     'kw,wrdl: a "alice"'
4. Apply this patch.
5. Search in the staff catalogue «a "alice"»
     Replace a and alice with whatever than will return a result for you
6. Click on the first result
7. Check the "Return to results" link
     The link should preserve the full query

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:01:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:01:52 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-1fYxtevN3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124330&action=edit
Bug 20529: Remove other occurrences of decodeURIComponent from browser.js

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:04:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:04:04 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-fyN2of3JaO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
Moving to PQA - I tested with as many odd searches as I could, easier to break
search and get no results than to break this.

Any search with ccode will break without these patches as we double quote their
values in the search code (in case they contain strange values, but we don't
care about other auth_values?) so I think we should get this in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:07:44 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-8o5o4pp016@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124032|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:07:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:07:52 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-SiWbbtGVAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124033|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:01 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-EWGkVut5s3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124034|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:17 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-n2HfehSpFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124035|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:32 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-9pWcjLaaKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124036|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:42 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Sbn3AU5jWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124037|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:51 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-4RJLCJYCBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124038|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:08:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:08:59 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-TAhyo0zA9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124039|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:08 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-42cK8dTxS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124040|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:19 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-IZqWPsIfjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124041|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:29 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-3ObCUAcJLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124042|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:38 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-GJDpXsIHOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124043|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-LmEbAcEIn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124044|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:09:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:09:57 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-T82CD5Q32o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124045|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-YpA3L12VQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124046|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ms2rgymwwN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124047|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:24 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ZLoTQuBghL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124048|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:34 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-raJfG8mtxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124049|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:43 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2YLqUiKE6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124050|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:10:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:10:53 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-lmrv4vDc3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124051|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:11:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:11:22 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-dXIb3trhIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124052|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:11:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:11:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-7Aua98GXt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124053|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:11:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:11:57 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-C7nyvnRVIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124021|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:09 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Jr7DcaFd2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124022|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:19 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-XkWwxoPCIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124023|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:29 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Rbmir1lbEQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124024|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-bRrSIkqvBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124025|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-IlIdgQcTwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124026|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:12:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:12:55 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-zafzaowNEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124027|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:13:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:13:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Anwos28I02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124028|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:13:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:13:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-zmG0QLXJqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124029|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:13:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:13:22 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-NtbdXfKJi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124030|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:13:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:13:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-lhEHf5aGBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124031|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:14:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:14:36 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2AHp0PHGcC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #387 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124331&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:14:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:14:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-T4Idzsi0pU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #388 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124332&action=edit
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:14:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:14:58 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-MQqZErOYcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #389 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124333&action=edit
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:04 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-SviKq1L98p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Signed Off                  |Failed QA

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
All the repeated fields need to be spliced off for this to work. Now for
example this breaks the regex replace functionality. If I try to change the
copynumber with:

 t - Copy number s/.*/ TTT /

using the batchmod tool it doesn't work after this patch. I think the indicator
field modification might be broken now as well (didn't check but looking at the
batchMod.pl code it seems so)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:17 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-T6GzK9G8IA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #390 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124334&action=edit
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:27 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-tgtMlYqzmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #391 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124335&action=edit
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-iMcC1PQMSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #392 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124336&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-XHFNuW207J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #393 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124337&action=edit
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:15:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:15:59 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-TJqZljmGZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #394 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124338&action=edit
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:16:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:16:10 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-FkQqUXMukh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #395 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124339&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:16:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:16:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-0bu5LWCCyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #396 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124340&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:16:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:16:34 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-IGqcmwb67Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #397 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124341&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:16:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:16:44 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-iP8ota4a2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #398 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124342&action=edit
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:16:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:16:55 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-9IowVqcfgF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #399 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124343&action=edit
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:17:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:17:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2K8Xpy38eM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #400 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124344&action=edit
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:17:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:17:16 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-4jB9DwUdeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #401 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124345&action=edit
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:17:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:17:27 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-vJcgwr3hSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #402 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124346&action=edit
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:17:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:17:38 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-bt1aG7d2pk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #403 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124347&action=edit
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:17:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:17:52 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-tmvYXr8zHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #404 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124348&action=edit
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:18:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:18:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-6WePKOUBHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #405 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124349&action=edit
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:18:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:18:15 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ypHxkkrOFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #406 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124351&action=edit
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:18:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:18:26 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-NPG0R4fHBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #407 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124352&action=edit
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:18:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:18:37 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-oFhBC1TcTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #408 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124353&action=edit
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:18:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:18:49 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-u974OOG1LL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #409 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124354&action=edit
Bug 24857: (QA follow-up) Fix unit tests and code for changes in
Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:00 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-eM3XXn2m2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #410 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124355&action=edit
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:11 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-pL8V4oJivk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #411 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124356&action=edit
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:22 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-f8jdtejCSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #412 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124357&action=edit
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-gMsLc4sHKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #413 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124358&action=edit
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-6by4rUoCcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #414 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124359&action=edit
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:19:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:19:59 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-PFlssRdH54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #415 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124360&action=edit
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:20:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:20:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-LqTk9bcjww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #416 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124361&action=edit
Bug 24857: Rename Volumes => Item groups (DB)

This patch renames Volumes => Item groups in the DB structure, and also
on permissions and sysprefs.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:20:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:20:38 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-W4ICD9mrqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #417 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124362&action=edit
Bug 24857: Adapt code to the volumes => item_groups change

This patch updates the code so all references to 'volumes' are
translated into 'item groups'.

Relevant changes:
- API routes and specs
- Permission name is changed
- Syspref name changed

Note: I removed a behavior that felt unnatural (at least in the place it
was put): deleting the item group if the linked item is deleted. It
feels like a controller thing, and also something that could be offered
to the staff on the UI on item deletion. To avoid blocking the feature,
I suggest this removal, and discuss it in its own context.

To test:
1. Run:
   $ reset_all
2. Apply this patchset
3. Run:
   $ updatedatabase
=> SUCCESS: Update works
4. Repeat 1 (with the patches applied)
=> SUCCESS: Install works with this DB structure
5. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
6. Follow the original plan (with the Volume=>ItemGRoup change in mind)
=> SUCCESS: All good!
7. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:20:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:20:57 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-8P3R2SGq6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #418 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124363&action=edit
Bug 24857: item_group_items.item_id must be unique

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:39:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:39:49 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-MVpNBxlFza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123615|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124367&action=edit
Bug 26314: Only display volumes link when required

This patch makes C4::XSLT query for volumes the same way it would do
with the generated link (i.e. based on UseControlNumber) and passes
a flag to the XSLT so it displays (or not) the 'Show volumes' link.

To test:
1. Apply the first patch
2. Have a known record without volumes
3. Open the record in the OPAC
=> FAIL: It shows the 'Show volumes' link
4. Have a record known to have volumes
5. Open the record in the OPAC
=> SUCCESS: It shows the 'Show volumes' link
6. Apply this patch and restart_all
7. Reload the above records
=> SUCCESS: It shows the link where it has to, and hides it where it
   shouldn't be displayed.
8. Repeat for Intranet
9. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:45:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:45:31 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-Yq2FSc4RaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124368&action=edit
Bug 28928: Minor follow-ups to Bug 28376 - Flatpickr introduction

This patch corrects three errors in the original Flatpickr introduction
patch:

- Missing document.ready() in borrowers_stats.tt.
- Redundant calendarFirstDayOfWeek setting in caregories.js
- Missing preventDefault() in calendar.inc

The first two issues don't appear to cause any malfunction but are best
practices. The third issue can cause the page to scroll unexpectedly.

To reproduce this bug, go to (for instance) Administration -> Patron
categories -> New category.

 - If necessary, narrow the height of your browser window so that there
   is a vertical scrollbar.
 - Scroll down the page so that the "Until date" field is at the top.
 - Click the "X" next to the field.
 - The page will scroll to the top.

Apply the patch and test again. The page jump should not occur.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:46:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:46:24 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-ygTKQYsxwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124368|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:46:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:46:29 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-wjNuCdc3Y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:46:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:46:33 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-gvRa6SjxYb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124276|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124369&action=edit
Bug 28928: Minor follow-ups to Bug 28376 - Flatpickr introduction

This patch corrects three errors in the original Flatpickr introduction
patch:

- Missing document.ready() in borrowers_stats.tt.
- Redundant calendarFirstDayOfWeek setting in caregories.js
- Missing preventDefault() in calendar.inc

The first two issues don't appear to cause any malfunction but are best
practices. The third issue can cause the page to scroll unexpectedly.

To reproduce this bug, go to (for instance) Administration -> Patron
categories -> New category.

 - If necessary, narrow the height of your browser window so that there
   is a vertical scrollbar.
 - Scroll down the page so that the "Until date" field is at the top.
 - Click the "X" next to the field.
 - The page will scroll to the top.

Apply the patch and test again. The page jump should not occur.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:46:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:46:44 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-PpiXZrhxhX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:48:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:48:46 +0000
Subject: [Koha-bugs] [Bug 28920] Guided Reports
In-Reply-To: <bug-28920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28920-70-tbEMCjsaku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28920

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Which exact version of Koha?
What's the error you get?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:49:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:49:47 +0000
Subject: [Koha-bugs] [Bug 28922] Vendor search has poor performance when
 system has many vendors
In-Reply-To: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28922-70-dz9oc8wZg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28922

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How many is many? 100, 1000, 10000?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:50:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:50:21 +0000
Subject: [Koha-bugs] [Bug 28922] Vendor search has poor performance when
 system has many vendors
In-Reply-To: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28922-70-Cr2LzFGOTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28922

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> How many is many? 100, 1000, 10000?

Depends on the hardware.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:52:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:52:37 +0000
Subject: [Koha-bugs] [Bug 28908] Bug 18017 removed indexing field 245
In-Reply-To: <bug-28908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28908-70-y3zPIlQw0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Fridolin, you are the author of bug 18017!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 15:58:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 13:58:45 +0000
Subject: [Koha-bugs] [Bug 28922] Vendor search has poor performance when
 system has many vendors
In-Reply-To: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28922-70-oDe6g9FyuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28922

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Kyle M Hall from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > How many is many? 100, 1000, 10000?
> 
> Depends on the hardware.

Lol yes, I know, but it's good to have an idea to recreate the problem locally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:05:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:05:07 +0000
Subject: [Koha-bugs] [Bug 28937] New: Use Flatpickr on circulation and
 patron pages
Message-ID: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

            Bug ID: 28937
           Summary: Use Flatpickr on circulation and patron pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28928

Bug 28376 added Flatpickr for date and time-picker widgets, with the goal of
replacing all usage of jQueryUI's datepicker widget.

This bug will cover Flatpickr additions to these pages/files:

 includes/borrower_debarments.inc
 includes/calendar.inc
 includes/holds_table.inc
 circ/circulation.tt
 circ/overdue.tt
 circ/pendingreserves.tt
 circ/reserveratios.tt
 members/memberentrygen.tt
 members/moremember.tt
 reserve/request.tt
 prog/js/checkouts.js
 prog/js/holds.js


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928
[Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:05:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:05:07 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-El01EpXkUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:08:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:08:53 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-wwdN3mcaTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:19:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:19:49 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-QbVfxriPvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:19:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:19:52 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-z8j3QPdCx7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124370&action=edit
Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField

To test:
1. Add values to the AV ROADTYPE
2. Go to the BorrowerUnwantedField system preference and attempt to hide
streettype and B_streettype.
3. It doesn't work, the fields still show.
4. Apply patch
5. Repeat step 2, it should work now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:21:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:21:17 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-nYi9ZTV3pN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:26:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:26:13 +0000
Subject: [Koha-bugs] [Bug 28922] Vendor search has poor performance when
 system has many vendors
In-Reply-To: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28922-70-U29mxVdTi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28922

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13371

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:26:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:26:13 +0000
Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view
In-Reply-To: <bug-13371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13371-70-Wn2INvfmDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28922

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:34:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:34:50 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-E0WDF10UCM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Regarding the eval Fridolin mentions.. I'm tempted to switch the
get_volumes_query routine to using build_query_compat internally instead which
should yield us a more reliably constructed search query string with special
characters removed. That way, with bug 28316 work progressing we will get the
advantages it brings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:38:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:38:26 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-vN3j5Cjyjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 16:38:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 14:38:30 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-Chgumn992C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124370|0                           |1
        is obsolete|                            |

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124371&action=edit
Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField

To test:
1. Add values to the AV ROADTYPE
2. Go to the BorrowerUnwantedField system preference and attempt to hide
streettype and B_streettype.
3. It doesn't work, the fields still show.
4. Apply patch
5. Repeat step 2, it should work now.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:00:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:00:52 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-VtmEaNyH4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123601|0                           |1
        is obsolete|                            |

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124372&action=edit
Bug 28316: add tests

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:00:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:00:57 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-vrBxnvGQHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123602|0                           |1
        is obsolete|                            |

--- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124373&action=edit
Bug 28316: screen unquoted semicolons and all followup colons

Currently searches like: "book:", ":book" and "host-item:test:n"
cause internal server errors.

This patch adds additional regexes that remove the colons at the start
and end of the query, and another regex that screens all follow-up
colons that go after the first colon to avoid errors when searching for
"host-item:test:n".

To reproduce:
1) using ES, search for the book with title that contains
semicolon at the start or at the end of the line, separated with spaces,
this should cause internal server error.
2) try doing the same with something like "host-item:test:n", it should
result in error as well.
3) apply the patch.
4) repeat steps 1-2, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:01:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:01:03 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-iSyw8u5VXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123603|0                           |1
        is obsolete|                            |

--- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124374&action=edit
Bug 28316: escape brackets in the search query

This patch screens square and curly brackets which have no special
language meaning.

To reproduce:
1) using ES, search for the book with title that contains
square and/or curly brackets, like "book [second edition]", which will
result in error.
2) apply the patch.
3) search for that book again, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:01:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:01:09 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-EaW6Dsg9kP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123604|0                           |1
        is obsolete|                            |

--- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124375&action=edit
Bug 28316: escape exclamation signs in the query

Currently having exclamation sign at the end of the query makes ES
search fail, and when you try to search for a book that has exclamation
sign in the tittle (something like "Words! words") won't show results
correctly as it tries to negate everything that is after exclamation
sign, making it impossible to search for books that have in in the title

This patch escapes exclamation signs if it's at the end of the query or
has a space after it, resolving both of the issues listed above.

To reproduce:
1) with ES enabled, search for the book with title that contains
exclamation sight at the end, like "book!", this search should result
 in error.
2) do another search, but this time find/prepare beforehand book with a
title that has exclamation sign with a space after it,
e.g "exclamation! sign", it shouldn't find it as ES treats everything
after that exclamation sign as negation.
2) apply the patch.
3) perform searches from the steep one and two again.
Search from step one should no longer fail, while search from the step
two should find that book.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:01:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:01:14 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-xZJfysUDif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123605|0                           |1
        is obsolete|                            |

--- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124376&action=edit
Bug 28316: avoid messing up regexes in the search queries

This patch ensures that the behavior with
QueryRegexEscapeOptions set to values other than
"Escape" still will works as expected.

It does so by storing the contents of regexes
before escaping special characters and
then restores the contents of regexes back to how
it was before, ensuring that searching with regex is possible.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:01:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:01:20 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-80qGcTLfIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123606|0                           |1
        is obsolete|                            |

--- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124377&action=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled

if QueryAutoTruncate enabled we will have any special operators ruined
for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]"
so no reason to keep ranges when QueryAutoTruncate set to "enabled"

1) enable QueryAutoTruncate at your sysprefs.
2) perform a search using range, for example: "[1999 TO 2020]",
it shouldn't work the way it's supposed to.
3) apply the patch.
4) perform the same search with range, ensure that it works correctly.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:01:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:01:25 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-3RhwfRvO0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124378&action=edit
Bug 28316: (QA follow-up) Make clean_search_term public

With all the work that's gone into improving the internal
_clean_search_term method I feel we should expose it publically as it's
going to be more widely helpful

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:02:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:02:51 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-tK7hwOMBoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Wow, this is a pretty rigorous treatment.. I'm impressed.

I've tested to the extent of my knowledge and am really happy with the results.
No regressions found, but I'd love to see it pushed and tested with various
configurations in the wild with quick fixes to follow.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:04:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:04:42 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-rt8y7KDek4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123607|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124379&action=edit
Bug 28484: ES clean title in biblio detail

Test plan:
 - Create a biblio with title like "osteuropa:" or "osteuropa!"
 - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl)
   => Error
 - Apply bug 28316 and this one
 - test again

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:05:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:05:18 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-0bl9Tzsqtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial patch after the work carried out by bug 28316.. passing QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:05:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:05:23 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-IdyDrA7stE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:07:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:07:09 +0000
Subject: [Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to
 edit or save records with ' ES reserved charset' like []
In-Reply-To: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28326-70-WkNbOnyCPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think this is now superseded by bug 28316

*** This bug has been marked as a duplicate of bug 28316 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:07:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:07:09 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-EFQu0N9srE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 28326 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:07:44 +0000
Subject: [Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to
 edit or save records with ' ES reserved charset' like []
In-Reply-To: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28326-70-cvKC2DFu2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 28484 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:07:44 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-lhlBY5Oo5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 28326 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:08:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:08:20 +0000
Subject: [Koha-bugs] [Bug 28326] If ElasticSearch enable is not possible to
 edit or save records with ' ES reserved charset' like []
In-Reply-To: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28326-70-HupKrS1vhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry.. bug 28484 which uses the work from bug 28316

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:09:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:09:13 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-GufVQZBXXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
[Bug 28316] Fix ES crashes related to various punctuation characters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:09:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:09:13 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-F6IiXwd8D8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |26314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314
[Bug 26314] "Volumes: show volumes" showing regardless of whether there are
volumes linked to the record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:14:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:14:01 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-8lC5ElS5TS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124367|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124380&action=edit
Bug 26314: Only display volumes link when required

This patch makes C4::XSLT query for volumes the same way it would do
with the generated link (i.e. based on UseControlNumber) and passes
a flag to the XSLT so it displays (or not) the 'Show volumes' link.

To test:
1. Apply the first patch
2. Have a known record without volumes
3. Open the record in the OPAC
=> FAIL: It shows the 'Show volumes' link
4. Have a record known to have volumes
5. Open the record in the OPAC
=> SUCCESS: It shows the 'Show volumes' link
6. Apply this patch and restart_all
7. Reload the above records
=> SUCCESS: It shows the link where it has to, and hides it where it
   shouldn't be displayed.
8. Repeat for Intranet
9. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:14:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:14:05 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-Gi4H8ow6rr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124381&action=edit
Bug 26314: (follow-up) Use clean_search_term

This patch uses the now public clean_search_term from bug 28316 to
sanitize the title string and prevent crashes in elastic search when
title contain reserved characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:17:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:17:50 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-q14tpCn7VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124134|0                           |1
        is obsolete|                            |

--- Comment #301 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124382&action=edit
Bug 11175: Show record component parts in the detail view

Shows the component records of a host, on the hosts detail view in
staff client or OPAC, with clickable links to the component records.

The host does not require linking entries to the components, but
components do require a link to the host record via 773$w.

Adds a new search index, Control-number-identifier (aka cni), which
indexes the 003 controlfield.

Adds 'Yet Another System Preference', ShowComponentRecords, which can
be used to turn this feature on or off in staff client and/or OPAC,
and defaults to off.

When looking up the component part records, the code searches for
records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'
or, if the 003 is not defined in the Host, 773$w=Host001.

Does not use easyanalytics or useControlNumber.

Only for MARC21 biblios - UNIMARC has not been updated.

staff-global.css and opac.css have not been recreated, so you need
to use sass to recreate those from staff-global.scss and opac.scss

Test plan:

0) Apply patch
1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML
   (This file is an attachment on the bug)
2) rebuild the zebra biblio index
3) Search for "easy piano" in staff client, and go to
   the biblio detail page. You should not see anything different
   in the record detail page.
4) Do the same on OPAC.
5) Change the ShowComponentRecords syspref appropriately and check
   the record detail page in staff client and OPAC.
   You should see a list of component part records.

Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:17:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:17:58 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-TNKHEgdjET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124135|0                           |1
        is obsolete|                            |

--- Comment #302 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124383&action=edit
Bug 11175: (follow-up) Don't return explicitly undef

This would create in list context an list of one element that is
undef, which we don't want, we want empty list if there are no
components.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:05 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-UVlwhFSr6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124136|0                           |1
        is obsolete|                            |

--- Comment #303 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124384&action=edit
Bug 11175: (follow-up) Return empty array if no components

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:12 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-iNsRv7PRRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124137|0                           |1
        is obsolete|                            |

--- Comment #304 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124385&action=edit
Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref
description

The syspref is not only affecting staff interface so moving it to
Cataloguing section. Added also notes about UNIMARC and Elasticsearch
not being supported.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:19 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-MPn1V2Tvvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124138|0                           |1
        is obsolete|                            |

--- Comment #305 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124386&action=edit
Bug 11175: Add Elasticsearch support

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:27 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-2o6fHxU3QD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124139|0                           |1
        is obsolete|                            |

--- Comment #306 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124387&action=edit
Bug 11175: Keep component part record list items inside the box

Without this the number denoting the component part item in the list
will overflow and is partly hidden.

To test:
 1) Create 100 component parts
 2) Notice without this patch the number next to the component part is
    not fully shown

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:34 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-CkjsXwBTDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124140|0                           |1
        is obsolete|                            |

--- Comment #307 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124388&action=edit
Bug 11175: Limit the amount of component parts returned

There was already before this a limit of 100 results when using
Elasticsearch but then the list of component parts was truncated
silently. This change now limits the amount to hard coded limit of 300
which is still fast to render. Also when the 300 component part record
limit is reached there is a link in the list now to list all the
records via the cataloging search.

To test:
   1) Create 300+ component part records and see if the link to list
      all the component part records shows up
   2) Make sure prove t/Koha/Util/Search.t passes

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:41 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-kGDRHypYvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124141|0                           |1
        is obsolete|                            |

--- Comment #308 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124389&action=edit
Bug 11175: Search using double quotes to support Elasticsearch

With Elasticsearch if you would use the search string here without the
change to double quotes, i.e.

(rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234'

then the search would somehow manage to return a record with 001 =
1234 and 003 = FI-XXX. Using double quotes prevents that. Also using
parenthesis around the latter part of the OR seems to work:

(rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234')

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:48 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-g0gvW6XoIC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124142|0                           |1
        is obsolete|                            |

--- Comment #309 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124390&action=edit
Bug 11175: Remove outdated info about Elasticsearch not being suppported

Support for Elasticsearch was added in commit "Bug 11175: Add
Elasticsearch support".

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:18:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:18:55 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-x3m73uVSOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124143|0                           |1
        is obsolete|                            |

--- Comment #310 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124391&action=edit
Bug 11175: (follow-up) Add tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:03 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-2YLUPhAH5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124144|0                           |1
        is obsolete|                            |

--- Comment #311 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124392&action=edit
Bug 11175: (follow-up) make atomic update idempotent

Atomic update tries to insert line into system preferences even if it's
already there. This patch fixes that by adding 'IGNORE' to the query,
making it idempotent.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:10 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-eYj7xNoWMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124145|0                           |1
        is obsolete|                            |

--- Comment #312 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124393&action=edit
Bug 11175: (follow-up) Rename routine get_marc_components

For consistency with other marc data accessor methods rename the new
'components' method to 'get_marc_components'.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:17 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-z8AvzsWVMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124146|0                           |1
        is obsolete|                            |

--- Comment #313 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124394&action=edit
Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc

This fixes the QA tool failure.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:25 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-4sAI6m06ZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124147|0                           |1
        is obsolete|                            |

--- Comment #314 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124395&action=edit
Bug 11175: (QA follow-up) Move preference to 'Display'

The 'ShowComponentRecords' preference was displaying under the 'Export'
section in the cataloging system preferences tab. As a display related
feature, I felt it was more appropriate to put it into the 'Display'
section.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:32 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-phSGIJ1glT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124148|0                           |1
        is obsolete|                            |

--- Comment #315 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124396&action=edit
Bug 11175: (QA follow-up) We lost Encode somewhere

This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it
somewhere along the way and broke the feature as it uses 'decode'.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:40 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-SLnXlfUtwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124149|0                           |1
        is obsolete|                            |

--- Comment #316 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124397&action=edit
Bug 11175: (QA follow-up) Take account of bug 15851

We can simplify the code introduced by bug 15851 by moving the
'show_analytics_link' variable assignment into C4::XSLT and thus making
the code more DRY.

Taking the code in bug 15851 as inspiration this patch also adds proper
handling for UseControlNumber vs EasyAnalytics style 773 linking and
ensures we only return analytic component parts and no other records
containing 773's.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:47 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-WFfMpLzd0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124150|0                           |1
        is obsolete|                            |

--- Comment #317 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124398&action=edit
Bug 11175: (QA follow-up) Move get_component_part_query

This patch removes Koha::Util::Search in preference to embedding the
search query builder in Koha::Biblio as get_analytics_query.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:19:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:19:54 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-TJLFf3NoUE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124151|0                           |1
        is obsolete|                            |

--- Comment #318 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124399&action=edit
Bug 11175: (QA follow-up) Only get biblio once

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:20:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:20:02 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-uI4m2NrJLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124152|0                           |1
        is obsolete|                            |

--- Comment #319 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124400&action=edit
Bug 11175: (QA follow-up) Fix queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:20:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:20:09 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-2Bd8b2itle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124153|0                           |1
        is obsolete|                            |

--- Comment #320 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124401&action=edit
Bug 11175: Display components in own tab

This patch updates the display so that rather than displaying the
components using the main XSLT and then using CSS to move them into a
box on the right side for display, which causes issues with RTL records;
We instead add them in a new tab beneath the rest of the record details
alongside holdings and other details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:20:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:20:18 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-MN8Eq2eNSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124154|0                           |1
        is obsolete|                            |

--- Comment #321 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124402&action=edit
Bug 11175: (QA follow-up) Rename back to get_marc_components

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:20:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:20:26 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-6niyUQOmm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124155|0                           |1
        is obsolete|                            |

--- Comment #322 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124403&action=edit
Bug 11175: (QA follow-up) Fixes for bug 12561

Bug 12561 changed the prototype for XSLTParse4Display so this patcha
accounts for the additional calls to that method introduced in this
patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:20:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:20:34 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-zsUoLh668L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #323 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124404&action=edit
Bug 11175: (follow-up) Use clean_search_term

This patch uses the now public clean_search_term from bug 28316 to
sanitize the title string and prevent crashes in elastic search when
title contain reserved characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:21:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:21:06 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-LpNxYCnfpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
[Bug 28316] Fix ES crashes related to various punctuation characters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:21:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:21:06 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-o0mqx1nwdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
[Bug 11175] Show the parent record's component parts in the detailed views
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:22:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:22:37 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-rF2XrQJtE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28484


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484
[Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is
in 245$a
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:22:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:22:37 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-Dx5MzUVgGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
[Bug 11175] Show the parent record's component parts in the detailed views
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:23:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:23:25 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-6L67OWrFK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28484


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484
[Bug 28484] Elasticsearch fails to parse query if colon or exclamation point is
in 245$a
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:23:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:23:25 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-9H92GI6mLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |26314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314
[Bug 26314] "Volumes: show volumes" showing regardless of whether there are
volumes linked to the record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:25:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:25:01 +0000
Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with
 search for analytics
In-Reply-To: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28682-70-TRNBLueyLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower level
by cleaning the search query so you yield the right results rather than hiding
any results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:26:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:26:02 +0000
Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with
 search for analytics
In-Reply-To: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28682-70-aw6xAfFbkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28316

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:26:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:26:02 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-pN23maxam6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28682

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:26:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:26:34 +0000
Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with
 search for analytics
In-Reply-To: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28682-70-G5mh87Eg1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28484

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:26:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:26:34 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-CBKUxDKjO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28682

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:48:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:48:04 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-h8unqbzxGf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|kyle at bywatersolutions.com   |testopia at bugs.koha-communit
                   |                            |y.org
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 17:58:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 15:58:40 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-a9J4Ga1URA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
There's an XML problem I noticed with the syntax highlighter: 

✔ ~/git/koha [qa_25716 ↑·2|✚ 1⚑ 33] 
12:57 $ xmllint etc/koha-conf.xml 
etc/koha-conf.xml:271: parser error : Double hyphen within comment: <!--
 <z3950_responder_options>
 <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options>
                          ^
I suggest we move this into the z3950/ files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:18:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:18:37 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-4fdbxlvpkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:06 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-FXQVb8nrHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:08 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-jVlAPza7nF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123989|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:11 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-Q7ERoW9Y61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123990|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:14 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-i7G8tRBF6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123991|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:39 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-S0xIa8sEvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124408&action=edit
Bug 26080: Use the task queue for batch delete biblios

This patch takes advantage of the task queue to delegate the batch
delete biblios tool.

Test plan:
Delete bibliographic records using the batch record deletion tool
Confirm that the job is now delegated to the task queue and that
everything else is working as before

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:45 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-5cMKIDYyu2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124409&action=edit
Bug 26080: Some refactoring

A new include file is created per background job to avoid
background_jobs.tt to grow too much

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:51 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-Suu5nTtFNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124410&action=edit
Bug 26080: Use the task queue for batch delete authorities

Same as the first patch, for authorities

Test plan:
Delete authority records using the batch record deletion tool
Confirm that the job is now delegated to the task queue and that
everything else is working as before

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:25:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:25:57 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-gO5JhsX8DO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124411&action=edit
Bug 26080: (QA follow-up) Minor template issues

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:26:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:26:03 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
 records tool
In-Reply-To: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26080-70-AYNsBdip06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124412&action=edit
Bug 26080: (QA follow-up) Add POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:26:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:26:29 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-oRn5SRAQV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 18:26:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 16:26:32 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-1BfTHI0Wc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124413&action=edit
Bug 28936: Add sort1/sort2 to borrowers.json

To Test:
1. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences, sort1 and sort2 cannot be hidden or required
2. Apply patch
3. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences again, you should see sort1 and sort2
4. Since sort1 and sort2 are now added to borrowers.json we must also check the
system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
5. They should both now include sort1 and sort2, check to make sure they work
with these two system preferences
6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField,
PatronSelfRegistrationBorrowerUnwantedField, and
PatronSelfModificationBorrowerUnwantedField
7. sort1 and sort2 should be disabled in these OPAC system preferences

This patch does not attempt to add sort1 or sort2 to the self reg or borrower
mod pages. If they should be added, which I am not sure they should, we should
do so in a seperate bug

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 19:03:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 17:03:20 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-Dsed69jMEr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:08:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:08:27 +0000
Subject: [Koha-bugs] [Bug 28938] New: Correct Flatpickr's default 12hr time
 formatting
Message-ID: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

            Bug ID: 28938
           Summary: Correct Flatpickr's default 12hr time formatting
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart+koha at gmail.com,
                    testopia at bugs.koha-community.org
        Depends on: 28937

In calendar.inc we define the variable "flatpickr_timeformat_string" using this
string: "h:i K"

This results in times which don't include a leading zero
(https://flatpickr.js.org/formatting/), a format which doesn't seem to be
expected by the Perl script. It should be "G"

To reproduce: 

- Set the TimeFormat system preference to "12 hour"
- Find an item which is checked out and renewable.
- Go to Circulation -> Renew and use the date picker to select a time < 12,
e.g. 9:00 AM
- Submit the barcode for renewal.
- Check the patron's account to see the due date: Instead of being due on your
selected date at 9:00AM it will be due on your selected date at 12:00AM.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:08:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:08:27 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-eZKB73K5B8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:20:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:20:19 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-cP9jVZVNcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:20:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:20:22 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-V6d1xgWfUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124414&action=edit
Bug 28938: Correct Flatpickr's default 12hr time formatting

This patch corrects Flatpickr's default 12 time formatting so that it
uses the formatting token "G" ("Hours, 2 digits with leading zeros")
instead of "h" ("Hours, 2 digits without leading zeros").

This will prevent incorrect times from being saved when the submitted
time is before 12.

- To test, apply the patch go to Administration -> System preferences.
- Set the TimeFormat system preference to "12 hour"
- Find an item which is checked out and renewable.
- Go to Circulation -> Renew and use the date picker to select a time <
  12, e.g. 9:00 AM
- Submit the barcode for renewal.
- Check the patron's account to see the due date of the renewed item: It
  should match the date and time you selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:30:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:30:53 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-qc7X04lC54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28937                       |28928


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928
[Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:30:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:30:53 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-QucY4LG5JU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:30:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:30:53 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-dy1Ik6ajBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28938                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:32:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:32:38 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-MEwb4TQ4Mh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28937                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:32:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:32:38 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-eZZekH9MUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28928                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928
[Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:33:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:33:08 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-IxXd33rZXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:33:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:33:08 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-3WRTyTmOso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:34:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:34:33 +0000
Subject: [Koha-bugs] [Bug 28939] New: Subscription formatting should not
 start at 0
Message-ID: <bug-28939-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939

            Bug ID: 28939
           Summary: Subscription formatting should not start at 0
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In subscription numbering patterns, one can set Koha to sub in season, month,
or day of week in place of a number. But those substitutions all start with
zero (so for months, 0=January, 1=February, and so on).

This adds extra confusion to what's already an complicated module. We should
make these values start at 1, as human counting works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:34:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:34:56 +0000
Subject: [Koha-bugs] [Bug 28939] Subscription formatting should not start at
 0
In-Reply-To: <bug-28939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28939-70-65sbn9h4sf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |sbrown at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:51:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:51:45 +0000
Subject: [Koha-bugs] [Bug 28939] Subscription formatting should not start at
 0
In-Reply-To: <bug-28939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28939-70-6lVsR65LtD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28939

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 28710 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:51:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:51:45 +0000
Subject: [Koha-bugs] [Bug 28710] Formatting values startng with 0 in
 numbering patterns are confusing to users
In-Reply-To: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28710-70-cG8gaYd7Ok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28710

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 28939 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 20:59:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 18:59:24 +0000
Subject: [Koha-bugs] [Bug 28940] New: IntranetUserJS will fire off twice
Message-ID: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

            Bug ID: 28940
           Summary: IntranetUserJS will fire off twice
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

TO recreate:

Add some IntranetUserJS that will target spinelabel-print.tt. I added this:

if ( $('#labels_spinelabel-print').length ) {
  $('#labels_spinelabel-print').append('<div>TEST</div>');
  console.log('TEST');
}

Try to do a quick spine label. Once you have entered a barcode the JS will go
off 2x. With the jQuery added you will see 2 div's with the word 'TEST'.

Look at the console and you will also see TEST console logged 2x.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:05:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:05:57 +0000
Subject: [Koha-bugs] [Bug 28908] Bug 18017 removed indexing field 245
In-Reply-To: <bug-28908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28908-70-K7VqCoL2Eu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28908

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #1)
> Fridolin, you are the author of bug 18017!

Yes but I ask for a non-technic point of view.
People are discussing it at Biblibre, I will report it here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:10:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:10:37 +0000
Subject: [Koha-bugs] [Bug 28682] Record detail page fails if error with
 search for analytics
In-Reply-To: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28682-70-5CLYeoaAQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682

--- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Martin Renvoize from comment #8)
> I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower
> level by cleaning the search query so you yield the right results rather
> than hiding any results.

OK maybe we just keep this fix for versions < 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:14:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:14:39 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-ysgqbUjwFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:15:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:15:15 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-qUKmb6yk8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |lucas at bywatersolutions.com
                   |u                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:20:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:20:22 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-qE572hO7Ur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:20:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:20:25 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS will fire off twice
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-4SzXJ1PhCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124415&action=edit
Bug 28940: In spinelabel-print.tt call IntranetUserJS only once

1. In IntranetUser add some JS that will target spinelabel-print.tt, I used
this:
    if ( $('#labels_spinelabel-print').length ) {
      $('#labels_spinelabel-print').append('<div>TEST</div>');
      console.log('TEST');
    }
2. Generate a quick spine label
3. Once you have entered a barcode the JS will go off 2x. With the jQuery added
you will see 2 div's with the word 'TEST'. Look at the console and you will
also see TEST console logged 2x.
4. Apply patch
5. Try seto 2 and 3 again, the JS should only be called once.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  1 21:20:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 19:20:56 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-mkD4O7Caok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|IntranetUserJS will fire    |IntranetUserJS is called
                   |off twice                   |twice on
                   |                            |spinelable-print.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 00:43:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Sep 2021 22:43:23 +0000
Subject: [Koha-bugs] [Bug 28710] Formatting values startng with 0 in
 numbering patterns are confusing to users
In-Reply-To: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28710-70-ffxtsFwoqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28710

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
+1! This would be a huge help.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 06:29:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 04:29:39 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-m3npQuJcYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz
             Status|NEW                         |ASSIGNED
           Assignee|kyle.m.hall at gmail.com       |aleisha at catalyst.net.nz

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hi all, this is a required feature for one of our libraries so I will give it a
go!

Just wanting to clarify some behaviour - would we prefer for the item to be due
at closing time, or does their loan period get extended to opening time the
following open day?

For example, my library closes at midnight (12am) and opens at 8am tomorrow. If
I issue a 2 hour loan at 11pm, should the item be due in one hour at 12am
(closing time), or at 8am tomorrow (opening time)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 08:50:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 06:50:38 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-XiDXh9xU39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 08:50:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 06:50:42 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-Df7hPgSdrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124414|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124417&action=edit
Bug 28938: Correct Flatpickr's default 12hr time formatting

This patch corrects Flatpickr's default 12 time formatting so that it
uses the formatting token "G" ("Hours, 2 digits with leading zeros")
instead of "h" ("Hours, 2 digits without leading zeros").

This will prevent incorrect times from being saved when the submitted
time is before 12.

- To test, apply the patch go to Administration -> System preferences.
- Set the TimeFormat system preference to "12 hour"
- Find an item which is checked out and renewable.
- Go to Circulation -> Renew and use the date picker to select a time <
  12, e.g. 9:00 AM
- Submit the barcode for renewal.
- Check the patron's account to see the due date of the renewed item: It
  should match the date and time you selected.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 08:50:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 06:50:53 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-7JysoNHxry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 08:57:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 06:57:20 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-9jECiOFC41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |unspecified
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:00:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:00:41 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-RY42kXRBCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't recreate the work on master, can you provide more details please.

I don't really see the point of the new method this patch adds:

sub clean_search_term {
    my ( $self, $term ) = @_;

    return $term;
}

...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:14:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:14:06 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-W7NS58NIKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #91 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+        $term =~ s/(?<!\\)((?:[\\]{2})*)(\{|\[)([^\s\[\]\{\}]+ TO
[^\s\[\]\{\}]+(?<!\\)(?:[\\]{2})*)(\}|\])/$1.'~~L'.($2 eq '[' ?
'S':'C').'~~'.$3.'~~R'.($4 eq ']' ? 'S':'C').'~~'/ge;



+            $term =~ s@(
+                (?<!\\)(?:[\\]{2})*/
+                (?:[^/]+|(?<=\\)(?:[\\]{2})*/)+
+                (?<!\\)(?:[\\]{2})*/
+            )$lookahead@"~~XI$rgx_i~~"@ex


I can push this kind of stuffs if everybody agrees, but I must warn that we are
opening a sensible door. If we find regressions that will be a mess to
maintain, or even to enhance.

Questions and suggestions:
1. Could we use named capture in the regexs?
2. What means XI?
3. Why do we need the 'e' modifier in the second one?
4. Can we split on several lines the regexs to make them more readable? (/xms)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:20:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:20:01 +0000
Subject: [Koha-bugs] [Bug 28710] Formatting values starting with 0 in
 numbering patterns are confusing to users
In-Reply-To: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28710-70-hlz1GI70V6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28710

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Formatting values startng   |Formatting values starting
                   |with 0 in numbering         |with 0 in numbering
                   |patterns are confusing to   |patterns are confusing to
                   |users                       |users

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:21:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:21:19 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-SUne4MVPPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> I don't really see the point of the new method this patch adds:
> 
> sub clean_search_term {
>     my ( $self, $term ) = @_;
> 
>     return $term;
> }
> 
> ...

Never mind, it's for Zebra.

Still cannot recreate the problem however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:33:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:33:56 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-YZMa1ejWvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #12 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > I don't really see the point of the new method this patch adds:
> > 
> > sub clean_search_term {
> >     my ( $self, $term ) = @_;
> > 
> >     return $term;
> > }
> > 
> > ...
> 
> Never mind, it's for Zebra.
> 
> Still cannot recreate the problem however.

hmm, seems like the dependency here, bug 28316, does the cleaning already so
this seems to just call the cleaning function another time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:50:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:50:19 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-1NKb0HHYMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124419&action=edit
Bug 28919: Select logged in library as pickup for multi holds

When placing multiple holds from the result list, the pick-up location is empty
now, which makes it a more tedious process than it needs to be.

Logged in library must be selected to match the single hold logic.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:50:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:50:44 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-jqomma5myE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
The very happy with the patch but it's working.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:50:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:50:52 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-9u3yF0lON3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:53:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:53:41 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-sPLMDlV5Ju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't recreate *on master*:

 - Create a biblio with title like "osteuropa:" or "osteuropa!"
 - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl)
   => Error

There is no error for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:57:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:57:06 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-0J3buscnfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #92 from Andrew Nugged <nugged at gmail.com> ---
1: yes, naming can be added

2: this is a "placeholder" which:
    a) first: part of text removed and replaced by placeholders (~~XI1~~ /
~~LC1~~ for example and others, life "LC for LeftCurly" and so on). This is for
temporary hiding out current brackets from "next RegExs"
    b) then text processed expecting that all others curly/square brackets and
regex and what must be kept – removed and hidden, so we can clean up and be
brave with all other not-replaced-by-placeholders brackets,
    c) so we cleaning up text, screening, removing or whatever those special
characters,
    d) and now we replacing BACK those placeholders with their saved in step a)
values back to keep unscreened and working special characters we wanted to be
kept

3: because it has " .. ? .. : .." depending of what bracket was found, but
otherwise if you speaking security-wise and don't want to have "e"'s at all
this RE probably can be split to few "just with different brackets" each,
should Petro split this regex to two without "e"? We discussed this too, I also
pointed that this is less secure "if something changes", but in this case, I
don't see how this can be hacked (how?)

4: for sure, this is good point. And some more comments in code. Let's do this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 09:57:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 07:57:46 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-pHtnp17G2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This messes with calls to Koha::Template::Plugin::Scalar.. I feel like ::Scalar
was introduced as a work around for the problems this attempts to resolve at a
lower level perhaps.

Anyway.. I'm seeing the following error in the logs when trying to look at the
record details page for various bibs with this patch applied:

[Thu Sep 02 08:55:44.032397 2021] [cgi:error] [pid 14881] [client
84.71.180.109:37036] AH01215: Template process failed: undef error - Can't call
method "filter_by_for_hold" on unblessed reference at
/home/martin/kohaclone/Koha/Template/Plugin/Context.pm line 50.:
/home/martin/kohaclone/catalogue/detail.pl, referer:
http://mrdev-zebra-staff.koha-ptfs.co.uk/cgi-bin/koha/catalogue/search.pl?idx=kw&q=spin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:03:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:03:11 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-grTxGIPK8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #93 from Andrew Nugged <nugged at gmail.com> ---
> This is for temporary hiding out current brackets from "next RegExs"

I agree that this is not the best solution: with 0.00..1% probability that some
books can have in the name "~~LC1~~" and this then will make code work
unexpectedly for that book ... but then we need to have ES to allow to index
"~~..~~" things, ... :).

I also pointed this to Petro but we thought together that then the best
solution is to scan text for placeholders and change placeholder (i.e.
"generate placeholder" to be unique) but oh – that then will make code so
complicated... we will create our own MIME then :)... 

If think from perfectionism POV this not solved yet, but other way – ... )...
eh?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:21:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:21:28 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-7YKMKNmn5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #94 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Andrew Nugged from comment #92)
> 1: yes, naming can be added
> 
> 2: this is a "placeholder" which:

Yes, I got that, and L for Left and R for Right. But then XI for... what? :)

> 3: because it has " .. ? .. : .." depending of what bracket was found

No, the second regex does not have it.

> , but
> otherwise if you speaking security-wise and don't want to have "e"'s at all
> this RE probably can be split to few "just with different brackets" each,
> should Petro split this regex to two without "e"? We discussed this too, I
> also pointed that this is less secure "if something changes", but in this
> case, I don't see how this can be hacked (how?)

Looks ok for now. But if it can be avoided I should do it.

> 4: for sure, this is good point. And some more comments in code. Let's do
> this.

Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:22:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:22:54 +0000
Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system
 preferences in standard and dev installs is broken
In-Reply-To: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28236-70-p05pOmPW8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johanna.raisa at koha-suomi.fi

--- Comment #3 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
We have finally started our upgrading process to the newest Koha release and
this problem came out when our superlibrarian was trying to set again
systempreferences. 

This is a kind of show stopper. Maybe we could open those json-files from
Apache?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:49:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:49:11 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-m7bk846Sm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:57:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:57:20 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-uOEJW0DAid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124420&action=edit
Bug 28883: (QA follow-up) Update use of Scalar

This patch updates the use of the TT Scalar plugin and clarifies
resultset objects vs arrays in the variable naming.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 10:58:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 08:58:32 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-psMsHOXiRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That patch seems to resolve it.. the general approach for this in the dbic
world is to use _rs to force scalar context at the object level.. but out
Scalar plugin does pretty much the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 11:12:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 09:12:08 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Q5yoJdgR8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #419 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124421&action=edit
Bug 24857: (QA follow-up) Fix for missing Scalar context

Template Toolkit will generally assume list context and so we get the
wrong result when chaning relationships. We must force scalar context
using the Scalar plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 11:18:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 09:18:32 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-60VElFC6xC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, the more I delve into this the more scary I find it actually.. :(

I'm coming to a similar conclusion to Jonathan, that we should always return
the object iterator and rely on as_list to get an array or arrayref when
required.  As I try to QA 24857 I keep running into new issues in TT where we'd
need to start calling the Scalar plugin to get back the object... I'm kinda
torn here..

DBIC does the magic wantarray handling and then adds an _rs version of methods
to force return of a scalar ignoring context.. we're doing the opposite here by
having 'as_list' which forces return of an array (or arrayref) but again doing
magic in the core return.

Perhaps we should keep this but replace our as_list function with _rs or
as_object or something along those lines?  We loose some magic because we
always have to re-add the relationships back in manually when we write out
objects.. so adding an _rs equivalent for every relationship accessor could be
a bit of a pain :(.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 11:24:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 09:24:10 +0000
Subject: [Koha-bugs] [Bug 22321] Make it possible to edit
 illrequests.borrowernumber
In-Reply-To: <bug-22321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22321-70-82A5n9qtAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
If the ILL request is connected to a bibliographic record and that record has a
reservation connected to the original patron, that reservation also needs to be
moved to the new patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 11:42:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 09:42:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-LrHc4S1hj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #420 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I presume it's deliberate to not expose any of this on the OPAC at all at this
time?  That comes with the holds work etc?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 11:57:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 09:57:28 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ektB0GDebe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #421 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I probably would have used the rowGroup plugin for DataTables to visually group
the grouped items.. but that can be done in a followup bug maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:00:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:00:23 +0000
Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system
 preferences in standard and dev installs is broken
In-Reply-To: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28236-70-LLJkphPQcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #4 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
Created attachment 124424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124424&action=edit
Bug 28236: Selecting database columns for system preferences  in standard and
dev installs is broken

This patch grants json files from koha-tmpl. Otherwise systempreferences won't
be able to fetch them.

TEST PLAN:

1) Try to set systempreference BorrowerUnwantedField.
2) The modal is empty.
3) Modify Apache configurations like in this patch.
4) Try again set the systempreference.
5) The modal should show list of parameters.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:00:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:00:44 +0000
Subject: [Koha-bugs] [Bug 28236] Selecting database columns for system
 preferences in standard and dev installs is broken
In-Reply-To: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28236-70-bHtHWIkic8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:03:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:03:39 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-T4UpFsPsoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #324 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another rebase and update of dependencies to account for issue found during QA
and testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:05:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:05:54 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-xLBinwyK24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
It's not something we can/should do in one patch (either way we pick).

But we can start moving some, bit by bit, and add a deprecation notice (like:
we won't support wantarray in 2 major versions anymore).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:10:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:10:51 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-mokFXfjmXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:10:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:10:54 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-Et5PskojxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

--- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:10:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:10:57 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-QNP4YH7pXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:10:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:10:59 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-hiVDLpvQBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:11:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:11:02 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-1IMDSmv11B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 12:11:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 10:11:04 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-HKQUx358zP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:12:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:12:00 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-tlgZaW4GP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124426&action=edit
Bug 21469: Add 003 into 773$w when required

This patch looks at the MarcOrgCode preference and if present it will
prepend the host 003 data in brackets to the 773$w link field in the
child record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:20:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:20:41 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-Sj5jgnRmYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124426|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124427&action=edit
Bug 21469: Add 003 into 773$w when required

This patch looks at the MarcOrgCode preference and if present it will
prepend the host 003 data in brackets to the 773$w link field in the
child record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:21:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:21:35 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-JuSMpsJ4f1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:23:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:23:16 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-wx3DB8Yenf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd love your help with writing a test plan for this Katrin..

I think it should work as expected, but I'm not even actually sure if we need
to bind it on the presence of MARCOrgCodes being defined.. we might actually be
OK just always prepending 003 if/when it's present in the host record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:23:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:23:37 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-c8AtccorJ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 13:23:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 11:23:53 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-Am7G8KnFWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nugged at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 14:47:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 12:47:49 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-6AJSa9DL30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 14:47:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 12:47:52 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-ldd7zM8l5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124428&action=edit
Bug 28937: Use Flatpickr on circulation and patron pages

This patch replaces the use of jQueryUI's datepicker on circulation and
patron-related pages.

The patch modifies Flatpickr's default configuration (in calendar.inc)
so that it has the following features:

 - A Flatpickr input with a "futuredate" class will require that the
   selected date be after today.
 - The Flatpickr input field will be wrapped in a container to
   facilitate better CSS styling.
 - Generic handling of paired date fields is enabled using
   ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the
   same feature we have for jQueryUI datepickers using ".datepickerfrom"
   and ".datepickerto".

This patch also removes an unused function which was repeated in three
templates: validate1.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check out to a patron.
  - Open the Restrictions tab and click "Add manual restriction."
    - In the "Expiration" field, test that the Flatpickr widget works
      correctly and limits to dates after today.
  - Enable the SpecifyDueDate preference if necessary.
    - Test the behavior of the SpecifyDueDate controls: Setting a date,
      clearing a date, session persistence.
- Enable the SuspendHoldsIntranet system preference if necessary.
  - Check out to a patron with existing holds.
    - Open the Holds tab and click the "Suspend" button for one of the
      holds.
      - In the modal window which appears, check that the Flatpickr
        widget works correctly and limits to dates after today.
      - At the bottom of the table of holds, test that the "Suspend all
        holds" Flatpickr works correctly and limits to dates after
        today.
        - Perform this same test from the patron details page.
- Enable the  BatchCheckouts system preference if necessary.
  - Open a patron record and click "Batch check out" in the left-hand
    sidebar menu.
    - Test that the "Hard due date" Flatpickr works correctly as a date
      and time picker.
- Go to Circulation -> Overdues.
  - Test that the date due filters in the sidebar work correctly and
    are linked, e.g. the "to" field cannot be before the "from" field.
     - Perform the same test here: Circulation -> Holds to pull; and
       here: Circulation -> Hold ratios.
- Enable the  HouseboundModule system preference if necessary.
  - Check out to or view details of a patron.
    - Click "Housebound" in the sidebar menu.
      - Save delivery day and frequency settings for that patron.
      - Click "Add a new delivery."
      - Test that the "Date" Flatpickr widget works correctly.
- Go to Patrons -> A patron record -> Edit.
  - Test that Flatpickr widgets work on the following fields:
    - Date of birth
    - Registration date & Expiration date (linked).
    - Patron restrictions -> Add manual restriction -> Expiration.
- View a bibliographic record and start the process of placing a hold.
  - After selecting a patron, test the "Hold starts on" and "Hold
    expires on" date fields. The fields should be linked and each
    should limit to future dates.
  - Confirm that the dates are saved correctly when you submit the
    hold.
- Locate a bibliographic record with multiple holds and view the holds.
  - In the table of holds, test each date field: Date, expiration, and
    suspend-until.
- Test that Flatpickr's static "formatDate" method is working
  correctly:
  - Locate a bibliographic record's item so that there is text in both
    the "Public note" and "Non-public note" field.
  - Check that item out to a patron.
  - After the page reloads the public and non-public notes should be
    shown under the checkout title highlighted in red.
- Check for references to a "validate1" function. There should be none.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 15:10:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 13:10:12 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-ZL79U7piOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm a bit concerned by the way this patch set is handling the UI. A UI form
builder module feels pretty regressive. I'm even seeing CSS embedded in a Perl
module, which feels like it should be a hard no.

What I'm seeing here is re-enforces the problem that we are coming up on in
Koha over and over. Scalability. For 20 years Koha has been processing all data
monolithically on the back end, and then presenting it to the user on page
load. This worked fine when Koha was being used by small libraries. Now, Koha
is being adopted by huge library system, and those designs that were great in
the past are showing their age. Time and time again we find areas of Koha where
a page simply cannot load because a library has so much data.

That is why we as a community chose to implement a REST API. This is what
allows us to make pages load quickly and dynamically using DataTables and other
tools.

I guess my question is, why? Why add a Perl module that's so tightly integrated
with html generation that it has CSS embedded in it's code? Why not use the
API? Why not make smarter objects and make cleaner TT templates?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 15:30:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 13:30:05 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-WWHZ4g8i59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I think we should discuss what we want. And draw a plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 15:43:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 13:43:29 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-znZwxBiVKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Noticed this warning just recently.

What is the suggested work flow here then? Should every registered patron be
moved to another category? Cant this be done more intelligently?

We are using the verification step too. So why should we remove patrons from
borrowers table? If they do not accept, they are just in some temporary table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 15:56:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 13:56:06 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-C2BMxKVGZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #20 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
> Should every registered patron be
> moved to another category? 

Yes, that's the intended workflow.

> Cant this be done more intelligently?

The assumption among libraries I've worked with is that staff need to manually
verify validity of the account, which generally means physically checking some
proof of address. In theory, one could automate the category change using the
update_patrons_category cronjob, but I'm not sure more automated is more
intelligently.

> We are using the verification step too. So why should we remove patrons from
> borrowers table? If they do not accept, they are just in some temporary
> table?

If you're also using the email verification step, then you're correct, those
patrons aren't in the borrowers table at all until they click the link in their
email.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:00:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:00:48 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-R00DhZ8seX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe that for reasons of data privacy and such libraries often still
require that something is signed in order to finish the registration process.
The suggestion with update_patrons_category is a good one I think if you want
to automate the process. You could also just NOT delete the patrons in the
temporary category by disabling the cron. Empty pref might also work, not sure
there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:07:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:07:45 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-W6q8HX73X5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Andrew Fuerste-Henry from comment #20)

Hi Andrew,
Thx for your fast reply.

> > Should every registered patron be
> > moved to another category? 
> 
> Yes, that's the intended workflow.

We are actually not interested to check each of these accounts (in our special
library). We only check patrons that also register with us for a library card
and come to our desk. Until now we had no need to change patron category at
that time.

But running cleanup with 'del-exp-selfreg' would indeed be a disaster.. I still
have the idea that this needs more attention. Especially when hearing that
several libraries unfortunately did so already. Is putting a warning on an
Admin page all we can do?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:10:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:10:52 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-iZZ80cVvdo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #21)
> I believe that for reasons of data privacy and such libraries often still
> require that something is signed in order to finish the registration
> process. The suggestion with update_patrons_category is a good one I think
> if you want to automate the process. You could also just NOT delete the
> patrons in the temporary category by disabling the cron. Empty pref might
> also work, not sure there.

As long as you dont add the specific flag, you are safe. But I do no longer
feel so safe as I did :)

Will open up a new report to think about some solution out of here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:15:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:15:36 +0000
Subject: [Koha-bugs] [Bug 28942] New: Use Flatpickr on acquisitions pages
Message-ID: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

            Bug ID: 28942
           Summary: Use Flatpickr on acquisitions pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28376

This bug will cover Flatpickr additions to these pages/files:

- includes/filter-orders.inc
- acqui/invoice.tt
- acqui/invoices.tt
- acqui/lateorders.tt
- acqui/orderreceive.tt
- acqui/parcels.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:15:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:15:37 +0000
Subject: [Koha-bugs] [Bug 28943] New: cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
Message-ID: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

            Bug ID: 28943
           Summary: cleanup_database: Can we make del-exp-selfreg less
                    disastrous ?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

See the discussion on bug 27395.

If you do not want to change the patron category for self registrations, you
should not use this flag.
But can we do something to prevent accidents which seemed to have happened
already?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:15:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:15:36 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-62jM28QlQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:15:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:15:46 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-oCp1lCXbEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27395

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:15:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:15:46 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-RmjBczzQs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28943

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:20:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:20:21 +0000
Subject: [Koha-bugs] [Bug 27395] Add warning to
 PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
In-Reply-To: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27395-70-L9jV3pS9pR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
So bug 28943.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:24:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:24:05 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-YP418gh9OK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
My first idea (biased a bit by what we do ourselves..):

If you have enabled Verification by mail and you would set a new pref like
PreventAccidentalRemoval [needs a better name], then cleanup_database will not
remove patrons enrolled in category X before certain date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:25:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:25:48 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-GXwaOhmzJh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #1)
> My first idea (biased a bit by what we do ourselves..):
> 
> If you have enabled Verification by mail and you would set a new pref like
> PreventAccidentalRemoval [needs a better name], then cleanup_database will
> not remove patrons enrolled in category X before certain date.

This comes down to moving the cmd line flag to a preference. I have seen that
transition happen much more already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:35:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:35:20 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-iqf1pjxeFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28938


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 16:35:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 14:35:20 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-xh3mQISw8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 17:11:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 15:11:36 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-t0Yff792ON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 18:13:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 16:13:29 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-vW64iZ5OBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Thanks for your input.
These patches are more from perfect, I agree. But the idea is to improve the
current situation. And I think this move goes toward the following goals:
isolate the code, centralise it, make it more robust by providing tests.
These item form and table are used in several places over the code, and having
this code in a module makes it reusable easily.
After this move the idea is to reuse it where this code is duplicated.
Once everything will use the same code it will be easier to move to a better
solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 18:46:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 16:46:37 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-5fc0Uqiq80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 18:46:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 16:46:41 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-iM2apWLP4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122653|0                           |1
        is obsolete|                            |

--- Comment #3 from Phil Ringnalda <phil at chetcolibrary.org> ---
Created attachment 124430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124430&action=edit
Bug 28676: Unit test

Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 18:46:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 16:46:45 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-hoN2MjouyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122654|0                           |1
        is obsolete|                            |

--- Comment #4 from Phil Ringnalda <phil at chetcolibrary.org> ---
Created attachment 124431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124431&action=edit
Bug 28676: Cache and retrieve match_count when searching a cached heading

We use match_count to determine if a new authority record should be created,
however,
we were not adding this count to the cache, so if a record returned too many
matches on first
lookup, we would create a new record on the second lookup

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and 
CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add two headings for that authority to a bib record (e.g. a 610 and 710)
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 19:06:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 17:06:12 +0000
Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery
 preferences when scheduling
In-Reply-To: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26544-70-0AWpt14i07@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 19:06:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 17:06:15 +0000
Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery
 preferences when scheduling
In-Reply-To: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26544-70-KytWz2KxF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123334|0                           |1
        is obsolete|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124432&action=edit
Bug 26544: Add housebound details to delivery page

To test:
1. Turn on the housebound module
2. go to the housebound for a given patron
/cgi-bin/koha/members/housebound.pl?borrowernumber=X
3. add some housebound details, fill out all the fields
4. Go to 'Add a new delivery'
5. No housebound details, hard to know what the patron likes or days to
deliver!
6. apply patch
7. Go to 'Add a delivery'
8. See the housebound details, yay! All the line breaks should be preserved.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 19:31:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 17:31:37 +0000
Subject: [Koha-bugs] [Bug 28944] New: Holds Awaiting Pickup - Incorrect
 Location
Message-ID: <bug-28944-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28944

            Bug ID: 28944
           Summary: Holds Awaiting Pickup - Incorrect Location
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joe at flo.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

1. Go to Circulation > Holds awaiting pickup
2. The holds list will default to your home library and the title says "Holds
awaiting pickup for your library on:"
3. Click View all libraries
4. The title of the page still says "Holds awaiting pickup for your library
on:"

The title in the second case should say something like "Holds awaiting pickup
for all libraries on:"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 19:39:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 17:39:57 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-El6ZT0SaUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #18)
> These patches are more from perfect, I agree.

*Far* from perfect! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:12:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:12:48 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-FPCNoAfVzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123973|0                           |1
        is obsolete|                            |

--- Comment #10 from Phil Ringnalda <phil at chetcolibrary.org> ---
Created attachment 124433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124433&action=edit
Bug 27461: Move hardcoded value to module

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:12:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:12:52 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-JYaRRcz7f4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123974|0                           |1
        is obsolete|                            |

--- Comment #11 from Phil Ringnalda <phil at chetcolibrary.org> ---
Created attachment 124434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124434&action=edit
Bug 27461: Add tests for biblio_008

Test plan:
Run  t/db_dependent/FrameworkPlugin.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:12:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:12:56 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-F5eS7nlWcI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123975|0                           |1
        is obsolete|                            |

--- Comment #12 from Phil Ringnalda <phil at chetcolibrary.org> ---
Created attachment 124435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124435&action=edit
Bug 27461: Right pad with default elements for too short 008s

Note that we treat the elements 18-34 as one block of elements,
since its subdivision may vary.
E.g. if you pass 24 characters to the form, it will use the first
18 chars (until the last complete element) and pad with default
elements from position 18-39.

Test plan:
[1] Go to addbiblio. Make sure that 008 is connected to the plugin.
[2] Backspace field 008 a bit, click on the plugin button.
[3] Verify that the last elements come from the default.
[4] Repeat for a few different lengths.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:13:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:13:14 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-8KjgFCTaeI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:32:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:32:32 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-eU37CO24oH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 20:32:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 18:32:35 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-GHYDRv8mpx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124314|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124436&action=edit
Bug 28933: Add subscription class to each subscription in opac-detail

To Test:
1. Go to a record with some subscriptions, have some closed and some
   open.
2. Go to the opac-detail page, click on the subscription tab and use
   your developer tools to inscept the element.
3. Notice the hierarchy of HTML structure, everything is a sibling of
   the next.
4. Apply patch
5. Reload the same opac-detail page and again inscept the element.
6. Now every individual subscription should be wrapped in an element
   with the class name of 'subscription'.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 21:06:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 19:06:59 +0000
Subject: [Koha-bugs] [Bug 28945] New: Use Flatpickr on administration pages
Message-ID: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

            Bug ID: 28945
           Summary: Use Flatpickr on administration pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28376, 28938, 28942

This bug will cover Flatpickr additions to these pages/files:

- admin/aqbudgetperiods.tt
- admin/aqcontract.tt
- admin/smart-rules.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 21:06:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 19:06:59 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-i60KESxYxX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 21:06:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 19:06:59 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-Rvjukja510@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 21:06:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 19:06:59 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-MkgD4JycAC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 21:57:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 19:57:04 +0000
Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
In-Reply-To: <bug-24698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24698-70-nwrsb5GfxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118186|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 124437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124437&action=edit
Bug 24698: Add plugin and template files for unimarc authority leader

In Unimarc installations when adding/editing an authority record there is no
Tag Editor for the leader field ( 000 ).

This patch fixes that.

Test plan:

1) Try to catalogue a new authoritry and check if on field 000 you can find
the Tag Editor.
2) Apply the patch.
3) In the authorities framework view the subfields of field 000 and select for
plugin option the value unimarc_leader_authorities.pl.
4) Restart memcached / plack if needed.
5) Repeat step 1 and notice if the Tag Editor is visible and click it to open
new window in order to manage the field contents and press OK.
6) Check the value of the generated leader.

Signed-off-by: Esther <estherm at sodapsringsid.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 22:00:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 20:00:27 +0000
Subject: [Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin
In-Reply-To: <bug-24698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24698-70-84PtTShouF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698

Esther Melander <estherm at sodaspringsid.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |estherm at sodaspringsid.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 23:40:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 21:40:46 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-iM3LaTFfvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124212|0                           |1
        is obsolete|                            |

--- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 124438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124438&action=edit
Bug 28898: Context for translation: term (word) vs. term (semester)

This patch add context to the term Term in the context of course reserves.

To test:
0- Apply patch
Set up course reserves
1- Enable UseCourseReserves
2- Create at least one authorized value for DEPARTMENT
3- Create at least one authorized value for TERM
4- Create a course
5- Add at least one item to the course

Check the terms:
6- Go to the OPAC
7- Go to Course reserves
** 8- In the list of courses, check the Term column heading
9- Go to the staff interface
10- Go to Course reserves
** 11- In the list of courses, check the Term column heading
12- Click on the course name
** 13- Check the Term line in the course description

Add a new language (fr-CA in the example, change for whatever language code you
want)
14- In a terminal, run
gulp po:create --lang fr-CA
15- Then, run
gulp po:update --lang fr-CA
16- In system preferences, enable the new language in language and
OpacLanguages
17- Switch the language in staff interface and OPAC

Change the translations
18- In your favourite text editor, open fr-CA-messages.po
19- Find the string 'msgctxt Semester'
20- Enter a word in msgstr
21- Save the file
22- In a terminal, go to misc/translator
23- Run
./translate install fr-CA

Check the translations
24- Redo the steps to check the terms (6-16) and make sure the terms in steps
8, 11, and 13 are changed for the word you put in step 20.
25- Optionally, check the following pages to make sure the terms are not the
word you put in step 20 (these pages shouldn't have been changed)
- opac-tags (your account > your tags)
- opac-authorities (search for an authority in Authority search)
- review (tags in staff interface)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 23:41:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 21:41:56 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-PCMYD9tgJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124213|0                           |1
        is obsolete|                            |

--- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 124439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124439&action=edit
Bug 28898: (follow-up) Remove comment lines before PROCESS statements

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 23:41:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 21:41:59 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-D8rPwccBB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124214|0                           |1
        is obsolete|                            |

--- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 124440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124440&action=edit
Bug 28898: (follow-up) Add context to some more occurrences of Term in course
reserves

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  2 23:43:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 21:43:16 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-BTpbWvxlyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
This was my first time signing off a patch of a set and I ran into errors. I
hope I did everything ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 01:09:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 23:09:44 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-WCQaVx9M2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleypelham at catalyst.net.n
                   |                            |z

--- Comment #2 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124441&action=edit
Issue with GDPR checkbox at smaller widths and with Required field text

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 01:09:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 23:09:56 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-IFNqZsgaNE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Hi Owen,

This looks good at larger browser widths and the checkbox and Required text
lines up with the rest of the form, but at smaller browser widths the checkbox
becomes misaligned, and when the form is submitted without checking the
checkbox and the This field is required text appears, some weird interaction
happens.

I have attached a screenshot illustrating this issue.

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 01:55:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 23:55:48 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-nx5Hu4l1zq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124055|0                           |1
        is obsolete|                            |

--- Comment #6 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124442&action=edit
Bug 21794: Fix display of addresses on details tab in staff when city is empty

If the city field was not filled out on the main or alternate address,
the content of state, country and zipcode wouldn't display on the
Details tab in the patron account in staff.

To test:
- Enter main contact and alternate address without city
- Verify that the address information isn't shown on the details
  tab after saving
- Apply patch
- Verify that the information is displayed now
- Toggle AddressFormat and check display is correct for all settings
- Switch back to US address format
- Try several combinations of empty fields for city, zipcode, country
  and state. The punctuation and whitespace should always appear
  correctly.

Examples:
- Enter just country
- Enter zipcode and country
- ...

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 01:56:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 Sep 2021 23:56:26 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-ceGCnYWBRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |hayleypelham at catalyst.net.n
                   |                            |z

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 02:22:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 00:22:43 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-cI3kL6zAEm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |hayleypelham at catalyst.net.n
                   |                            |z

--- Comment #6 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Patch doesn't apply

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 03:16:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 01:16:52 +0000
Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong
In-Reply-To: <bug-28263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28263-70-UlVpaT9omR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleypelham at catalyst.net.n
                   |                            |z

--- Comment #4 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Hi Lucas,

Can you please elaborate on how you can 'run auto_renew'?

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 03:28:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 01:28:45 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-GzwKdtH2tX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 03:28:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 01:28:50 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-5Zepw2wnPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123972|0                           |1
        is obsolete|                            |

--- Comment #5 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124443&action=edit
Bug 28882: permission UI allows selection of superlibrarian permission

With bug 20100 and 22150 we allow to select all the permissions but the
superlibrarian permission, to ease the selection. And we also forbid a
non-superlibrarian user to add superlibrarian permission.

However there is something wrong in the JS code and it's possible to add
the superlibrarian permission. The user is getting an ugly 500 and so
the permission change is not done, but the UI checks must be fixed.

To recreate:
Login with a non-superlibrarian user
Edit permission
Clear all
=> You can select the "superlibrarian" permission

Test plan:
Login with a non-superlibrarian user
Try to set the superlibrarian permissions to a user
=> not possible
Try the select all/clear all
=> still cannot set the superlibrarian permission

Work to be done:
Login with a non-superlibrarian user
Edit permissions for a superlibrarian user
=> You can remove it, then cannot add it back
Should we allow removal of superlibrarian permission by
non-superlibrarian user?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 03:30:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 01:30:38 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-nMEurvs6xO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124082|0                           |1
        is obsolete|                            |
 Attachment #124443|0                           |1
        is obsolete|                            |

--- Comment #6 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124444&action=edit
Bug 28882: permission UI allows selection of superlibrarian permission

With bug 20100 and 22150 we allow to select all the permissions but the
superlibrarian permission, to ease the selection. And we also forbid a
non-superlibrarian user to add superlibrarian permission.

However there is something wrong in the JS code and it's possible to add
the superlibrarian permission. The user is getting an ugly 500 and so
the permission change is not done, but the UI checks must be fixed.

To recreate:
Login with a non-superlibrarian user
Edit permission
Clear all
=> You can select the "superlibrarian" permission

Test plan:
Login with a non-superlibrarian user
Try to set the superlibrarian permissions to a user
=> not possible
Try the select all/clear all
=> still cannot set the superlibrarian permission

Work to be done:
Login with a non-superlibrarian user
Edit permissions for a superlibrarian user
=> You can remove it, then cannot add it back
Should we allow removal of superlibrarian permission by
non-superlibrarian user?

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 03:31:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 01:31:15 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-mzIzGHUPgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

--- Comment #7 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124445&action=edit
Bug 28882: Disable select/hide all links

We want to prevent non-superlibrarian users to remove superlibrarian
flag.
It's handled already in the controller, but needs to be done
client-side.

Here we are disabling the select/hide all links to remove the remaining
possibility to remove the superlibrarian flag from non-superlibrarian
users.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 04:25:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 02:25:16 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-X9PwkWkYQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleypelham at catalyst.net.n
                   |                            |z
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Hi Lucas,

I can confirm that the patch fixes the Status of the course reserve item to
show whether it is withdrawn, damaged, etc.

However, if it is none of those, the status column no longer shows Available,
but instead is blank.

I am assuming it should say available if none of those values you listed are
true?

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 05:18:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 03:18:44 +0000
Subject: [Koha-bugs] [Bug 28946] New: 500 error when choosing patron for
 purchase suggestion
Message-ID: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

            Bug ID: 28946
           Summary: 500 error when choosing patron for purchase suggestion
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jstallings at tsas.org
        QA Contact: testopia at bugs.koha-community.org

Running 21.05.02 on Debian stretch 9.13. When selecting "set to patron" or
"select manager" when entering a purchase suggestion from the staff console, a
500 error rather than a search box appears in the popup.

This issue seems related to bug 26738, where suggestion managers and patrons
were unable to be saved, but I'm unable to get even that far.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:22:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:22:11 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-ZbPMafRyBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:22:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:22:15 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-r9nXW22t5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124453&action=edit
Bug 28942: Use Flatpickr on acquisitions pages

This patch modifies several acquisitions pages replacing jQuery
datepickers with Flatpickr widgets.

To test, apply the patch and test datepickers on the following
Acquisitions pages:

 - Acquisitions -> Late orders (linked date fields in the sidebar)
 - Acquisitions -> Invoices (linked date fields in the sidebar)
 - Acquisitions -> Invoices -> Invoice details (shipment date and
   billing date)
 - Acquisitions -> Vendor -> Receive shipment (shipment date)
 - Acquisitions -> Vendor -> Receive shipment -> Receive (on order line)
   -> Date received field under "Accounting details
 - Acquisitions -> Orders search tab in the header -> Advanced search:
   Linked date fields in the search form."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:26:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:26:52 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-MgMnP7kIS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123843|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124454&action=edit
Bug 27358: Add a generic way to handle API privileged access attributes
deny-list

This patch introduces a way for Koha::Object(s)->to_api to filter out
attributes that require privileged access. It is done in a way that the
'public' parameter is recursively passed to nested objects in recursive
to_api() calls.

This way, Koha::Object-based classes can determine how they will render
depending on this parameter. For example, for implementing a
route for fetching an item looks like:

GET /items

The controller will look like:

my $item = Koha::Items->find( $c->validation->param('item_id') );
return $c->render(
    status  => 200,
    openapi => $item->to_api
);

Implementing an unprivileged (public) route would look like:

GET /public/items/:item_id

The controller will look like:

my $item = Koha::Items->find( $c->validation->param('item_id') );
return $c->render(
    status  => 200,
    openapi => $item->to_api({ public => 1  })
);

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object*.t
=> SUCCESS: Tests pass (i.e. current behaviour is kept, new behaviour
        passes the tests)
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:26:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:26:56 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-GXFo3ZrXbT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123844|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124455&action=edit
Bug 27358: Make is_public stashed on public routes

This patch makes the API authentication code stash the 'is_public' value
when public routes are hit.

This will be particularly useful to have $c->objects->search generically
pass this info down to the ->to_api method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass! When a public route is reached, the controller
has the 'is_public' value stashed
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:27:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:27:00 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-mPhv10Qx06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123845|0                           |1
        is obsolete|                            |

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124456&action=edit
Bug 27358: Teach objects.search about public requests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:27:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:27:04 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-IXXuLXFEDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123846|0                           |1
        is obsolete|                            |

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124457&action=edit
Bug 27358: Add GET /public/biblios/:biblio_id/items

This patch introduces a route to fetch items belonging to a biblio. It
is expected to return the 'public' representation of the Koha::Item
objects.

It is also enforcing the visibility rules, by using
Koha::Items->filter_by_visible_in_opac.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Test pass and they cover all the cases!
3. Try your favourite REST tool against the new route.
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:27:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:27:08 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-oO2zvsA1Cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123847|0                           |1
        is obsolete|                            |

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124458&action=edit
Bug 27358: Unit tests for public items retrieval

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:27:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:27:12 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-OuBZBJb1sl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124459&action=edit
Bug 27358: (QA follow-up) Convert to allow-list

This patch converts the code to use an allow-list as aposed to a
deny-list.  This is more 'fail safe' than requireing maintanence of a
deny-list.

We also switch to using db fields names for the list as aposed to api
mapped names. This way, the list can be re-used for non-api related
sanitising if required.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:35:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:35:28 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-P6uqmY7AjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|28942                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:35:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:35:28 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-gWZoFgk2mo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28945                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:47:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:47:16 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-GECMK0gek3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:47:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:47:19 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-bTQIVZ0hIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124460&action=edit
Bug 28945: Use Flatpickr on administration pages

This patch updates administration templates to use Flatpickr instead of
jQueryUI datepickers.

To test, apply the patch and test date fields on the following pages:

- Administration -> Budgets ->
  - New budget: Linked "Start date" and "End  date" fields.
  - Duplicate budget: Linked "Start date" and "End  date" fields.
- Acquisitions -> Vendor -> New contract: Linked "Start date" and "End
  date" fields.
- Administration -> Circulation and fine rules: "Hard due date" and "No
  automatic renewal after" fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:52:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:52:50 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-ZLa43TN4hj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 13:52:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 11:52:50 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-YPX9kuSq0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:04:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:04:08 +0000
Subject: [Koha-bugs] [Bug 28948] New: Add a /public counterpart for the
 libraries REST endpoints
Message-ID: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

            Bug ID: 28948
           Summary: Add a /public counterpart for the libraries REST
                    endpoints
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com

This bug will add the public facing libraries endpoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:04:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:04:21 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-ZgMC3aFSX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:05:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:05:10 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-QtKMPBq3xP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm going to grab the foundations from bug 27358 to push here so we can get
those in but based on a simpler final goal with the libraries table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:05:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:05:24 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-msSM8NeWA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27358

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:05:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:05:24 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-Rtfm6owB0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28948

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 14:42:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 12:42:25 +0000
Subject: [Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description
 to explain consequences of setting in Koha
In-Reply-To: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27448-70-GsY32mLhwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:12:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:12:06 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-G8Rwl3EmOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24857                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:12:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:12:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-lkgttS1kxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28883                       |

--- Comment #422 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Removing dependency on bug 28883 as it is only relevant for the tests (not)
using ->as_list. And is not fair for this bug to be blocked by it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883
[Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list
context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:17:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:17:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-09tUOAN5vU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124421|0                           |1
        is obsolete|                            |

--- Comment #423 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124463&action=edit
Bug 24857: Do not depend on bug 28883

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:50:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:50:08 +0000
Subject: [Koha-bugs] [Bug 28949] New: Use Flatpickr on reports pages
Message-ID: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

            Bug ID: 28949
           Summary: Use Flatpickr on reports pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28376, 28937

This bug will cover Flatpickr additions to these pages/files:

* reports/acquisitions_stats.tt
* reports/bor_issues_top.tt
* reports/borrowers_out.tt
* reports/cash_register_stats.tt
* reports/cat_issues_top.tt
* reports/catalogue_stats.tt
* reports/dictionary.tt
* reports/guided_reports_start.tt
* reports/issues_avg_stats.tt
* reports/issues_stats.tt
* reports/reserves_stats.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:50:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:50:08 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-zo4yy0IM9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949
[Bug 28949] Use Flatpickr on reports pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:50:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:50:08 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-xi1HjbdARO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949
[Bug 28949] Use Flatpickr on reports pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:50:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:50:44 +0000
Subject: [Koha-bugs] [Bug 26195] Add a way to specify authorised values
 should be expanded [OAI]
In-Reply-To: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26195-70-aXi2waewh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a new
      release notes|                            |option to the OAI
                   |                            |configuration file, to tell
                   |                            |it to expand authorised
                   |                            |values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:53:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:53:41 +0000
Subject: [Koha-bugs] [Bug 23861] Add authorised value categories description
 option
In-Reply-To: <bug-23861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23861-70-6TgAvDGDb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:56:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:56:11 +0000
Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order
 receive page
In-Reply-To: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28881-70-sUtw6BzeZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:57:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:57:21 +0000
Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item
 information
In-Reply-To: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26223-70-33rsAEKPRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.03
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:59:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:59:04 +0000
Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item
 information
In-Reply-To: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26223-70-73fa1Xbxzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.03           |21.11.00,21.05.04
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 15:59:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 13:59:51 +0000
Subject: [Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong
In-Reply-To: <bug-28263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28263-70-e4f2F6LwcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Hayley Pelham from comment #4)
> Hi Lucas,
> 
> Can you please elaborate on how you can 'run auto_renew'?
> 
> Cheers,
> Hayley

Hi Hayley,

I'm sorry, that wasn't very clear. What I mean by 'run auto_renew' is to run
the automatic renewal script ( /misc/cronjobs/automatic_renewals.pl ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:01:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:01:58 +0000
Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting
 hold won't save
In-Reply-To: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25619-70-5qLLVm7uYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:04:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:04:42 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-EilTqBwaTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #204 from Kyle M Hall <kyle at bywatersolutions.com> ---
Does not apply cleanly to 21.05.x. If this is needed for 21.05 please create a
21.05 patch. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:04:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:04:44 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-q1OaEIG3D4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Bug 20447 depends on bug 22690, which changed state.

Bug 22690 Summary: Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:27:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:27:09 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-njWXHto67R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Can we add a new table for the 2FA secrets please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:29:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:29:31 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-U8DbT25HpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:29:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:29:34 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-WY7hjEh7j0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120293|0                           |1
        is obsolete|                            |

--- Comment #3 from George Veranis <gveranis at dataly.gr> ---
Created attachment 124464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124464&action=edit
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:31:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:31:04 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-iNMxnw83tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124464|0                           |1
        is obsolete|                            |

--- Comment #4 from George Veranis <gveranis at dataly.gr> ---
Created attachment 124465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124465&action=edit
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:37:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:37:24 +0000
Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be
 XSLT Driven
In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11083-70-ppD3BboPo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gveranis at dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:43:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:43:58 +0000
Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a from
 record to search form
In-Reply-To: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28812-70-lXqcDqUALi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:47:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:47:32 +0000
Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description
In-Reply-To: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28554-70-8ov0IGWofp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:49:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:49:15 +0000
Subject: [Koha-bugs] [Bug 28902] Grey color should be on label for record
 metadata
In-Reply-To: <bug-28902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28902-70-Y2OayTKkOH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:50:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:50:17 +0000
Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search
 results if some items can't be placed on hold
In-Reply-To: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7703-70-Dm3JnmU19s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:51:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:51:40 +0000
Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new
 column but default sort column isn't changed
In-Reply-To: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28891-70-TxXah3UYf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:53:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:53:24 +0000
Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should
 generate an empty from_api_mapping
In-Reply-To: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28744-70-tBm8dVgc57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:53:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:53:45 +0000
Subject: [Koha-bugs] [Bug 28893] Unused opac/rss directory can be removed
In-Reply-To: <bug-28893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28893-70-GOOAdohsYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:54:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:54:01 +0000
Subject: [Koha-bugs] [Bug 28695] Add shelving location column to overdue
 report (overdue.tt)
In-Reply-To: <bug-28695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28695-70-VDb2BqwwsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:54:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:54:55 +0000
Subject: [Koha-bugs] [Bug 28810] Housebound details should be textarea not
 text inputs
In-Reply-To: <bug-28810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28810-70-n5bZeVf05W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:54:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:54:55 +0000
Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery
 preferences when scheduling
In-Reply-To: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26544-70-4gxDuU30uN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544
Bug 26544 depends on bug 28810, which changed state.

Bug 28810 Summary: Housebound details should be textarea not text inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:21 +0000
Subject: [Koha-bugs] [Bug 28838] SCO impossible errors are hard to target
 with CSS/JS
In-Reply-To: <bug-28838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28838-70-pJAOpxQsyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28838

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:55 +0000
Subject: [Koha-bugs] [Bug 28830] Add CNI (Control Number Identifier) search
 index (MARC21)
In-Reply-To: <bug-28830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28830-70-ATIdCAfYSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:56 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-X7YIxpTXe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
Bug 11175 depends on bug 28830, which changed state.

Bug 28830 Summary: Add CNI (Control Number Identifier) search index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:57 +0000
Subject: [Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in
 'Enhanced Analytics Workflow'
In-Reply-To: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21469-70-vsStnb5R9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469
Bug 21469 depends on bug 28830, which changed state.

Bug 28830 Summary: Add CNI (Control Number Identifier) search index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:57 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-AklkAoawx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314
Bug 26314 depends on bug 28830, which changed state.

Bug 28830 Summary: Add CNI (Control Number Identifier) search index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:55:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:55:57 +0000
Subject: [Koha-bugs] [Bug 27507] Search host record using control number
 identifier / organization code
In-Reply-To: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27507-70-vJtuZw3ULk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507
Bug 27507 depends on bug 28830, which changed state.

Bug 28830 Summary: Add CNI (Control Number Identifier) search index (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28830

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:56:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:56:51 +0000
Subject: [Koha-bugs] [Bug 20688] Add accesskeys for hold confirmation boxes
In-Reply-To: <bug-20688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20688-70-PLHiYGuw1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:58:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:58:13 +0000
Subject: [Koha-bugs] [Bug 28456] Add option to use a WHERE statement in
 membership_expiry.pl cronjob
In-Reply-To: <bug-28456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28456-70-sON3KB3QyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28456

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:58:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:58:42 +0000
Subject: [Koha-bugs] [Bug 24019] Patron batch modification based on
 borrowernumber
In-Reply-To: <bug-24019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24019-70-EikMHgUnPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:01 +0000
Subject: [Koha-bugs] [Bug 28843] Add view and edit buttons to result of MARC
 record import
In-Reply-To: <bug-28843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28843-70-XhOvugvFhO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:18 +0000
Subject: [Koha-bugs] [Bug 28736] Better error message when ES fails to
 understand the syntax of the search query
In-Reply-To: <bug-28736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28736-70-E5zcniS36y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:41 +0000
Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of
 itemcallnumbers
In-Reply-To: <bug-26302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26302-70-ERhGTKPbwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:41 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-JuwP4RDmJQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831
Bug 28831 depends on bug 26302, which changed state.

Bug 26302 Summary: OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:44 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-byaLLX2VsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123128|0                           |1
        is obsolete|                            |

--- Comment #37 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124466&action=edit
Bug 18138: Rename system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:48 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-8BKrusoUBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123129|0                           |1
        is obsolete|                            |

--- Comment #38 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124467&action=edit
Bug 18138: Add system preference to sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:53 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-JO2t4KCCEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123130|0                           |1
        is obsolete|                            |

--- Comment #39 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124468&action=edit
Bug 18138: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:57 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-FQ1hjB3LMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123131|0                           |1
        is obsolete|                            |

--- Comment #40 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124469&action=edit
Bug 18138: (follow-up) Add Objects for MarcModificationTemplates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:58 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-TeX4VuSF38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:59 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-Ia9FjyVGEF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928
Bug 28928 depends on bug 28376, which changed state.

Bug 28376 Summary: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:59 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-UUY7L6wvrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
Bug 28942 depends on bug 28376, which changed state.

Bug 28376 Summary: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:59 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-ai416QKNgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
Bug 28945 depends on bug 28376, which changed state.

Bug 28376 Summary: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 16:59:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 14:59:59 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-ZJe7MIzawf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949
Bug 28949 depends on bug 28376, which changed state.

Bug 28376 Summary: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:00:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:00:02 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-GOkUAP1a4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123132|0                           |1
        is obsolete|                            |

--- Comment #41 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124470&action=edit
Bug 18138: (QA follow-up) Fix QA script issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:00:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:00:07 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-y0VejttzYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123137|0                           |1
        is obsolete|                            |

--- Comment #42 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124471&action=edit
Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a
modification template

Rather than expecting the librarian to add an ID or a name we should provide a
dropdown

To test:
1 - Apply all patches
2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate'
3 - Note it list all defined Marc modification templates
4 - Select one
5 - confirm value in DB is the template id

Works fine for me

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:24 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-0NLT39o4Kq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123127|0                           |1
        is obsolete|                            |

--- Comment #43 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124472&action=edit
Bug 18138: Use MARC modification template when adding/updating bibliographic
records

Add a preference that enables a specific marc modification template to be
applied on bibliographic records saved using simple or advanced MARC editor or
the HTTP API.

To test:
1) Create a MARC modification template containg one or more actions.
2) Under "Global system preferences" and "Cataloging" set the
"EditBiblioMarcModificationTemplate" preference to the name of the previously
created template.
3) Edit (or create) a bibliographic record using either the simple or advanced
MARC editor.
4) Save the record.
5) Verify that the action(s) have been applied.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:29 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-U133G6jsH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124466|0                           |1
        is obsolete|                            |

--- Comment #44 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124473&action=edit
Bug 18138: Rename system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:34 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-JU9NwfOlAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124467|0                           |1
        is obsolete|                            |

--- Comment #45 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124474&action=edit
Bug 18138: Add system preference to sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:38 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-17HoidZWMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124468|0                           |1
        is obsolete|                            |

--- Comment #46 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124475&action=edit
Bug 18138: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:43 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-UVnYmYh5oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124469|0                           |1
        is obsolete|                            |

--- Comment #47 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124476&action=edit
Bug 18138: (follow-up) Add Objects for MarcModificationTemplates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:47 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-Kw2w6MQXuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124470|0                           |1
        is obsolete|                            |

--- Comment #48 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124477&action=edit
Bug 18138: (QA follow-up) Fix QA script issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:02:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:02:52 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-UDO1pWJTaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124471|0                           |1
        is obsolete|                            |

--- Comment #49 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124478&action=edit
Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a
modification template

Rather than expecting the librarian to add an ID or a name we should provide a
dropdown

To test:
1 - Apply all patches
2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate'
3 - Note it list all defined Marc modification templates
4 - Select one
5 - confirm value in DB is the template id

Works fine for me

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:05:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:05:05 +0000
Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad
 search indexes
In-Reply-To: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28885-70-FUEcFUTNox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:05:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:05:08 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-9ohDJhTdAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #50 from David Gustafsson <glasklas at gmail.com> ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:08:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:08:43 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-UF0z4u4cTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124479&action=edit
Bug 28948: Add a generic way to handle API privileged access attributes
deny-list

This patch introduces a way for Koha::Object(s)->to_api to filter out
attributes that require privileged access. It is done in a way that the
'public' parameter is recursively passed to nested objects in recursive
to_api() calls.

This way, Koha::Object-based classes can determine how they will render
depending on this parameter. For example, for implementing a
route for fetching an library looks like:

GET /libraries

The controller will look like:

my $library = Koha::Libraries->find( $c->validation->param('library_id') );
return $c->render(
    status  => 200,
    openapi => $library->to_api
);

Implementing an unprivileged (public) route would look like:

GET /public/libraries/:library_id

The controller will look like:

my $library = Koha::Libraries->find( $c->validation->param('library_id') );
return $c->render(
    status  => 200,
    openapi => $library->to_api({ public => 1  })
);

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object*.t
=> SUCCESS: Tests pass (i.e. current behaviour is kept, new behaviour
        passes the tests)
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:08:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:08:46 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-RokDQ3P4mG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124480&action=edit
Bug 28948: Make is_public stashed on public routes

This patch makes the API authentication code stash the 'is_public' value
when public routes are hit.

This will be particularly useful to have $c->objects->search generically
pass this info down to the ->to_api method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> SUCCESS: Tests pass! When a public route is reached, the controller
has the 'is_public' value stashed
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:08:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:08:49 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-fplyktI9WC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124481&action=edit
Bug 28948: Teach objects.search about public requests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:08:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:08:53 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-6dAVFelnpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124482&action=edit
Bug 28948: Add GET /public/libraries routes

This patch introduces a route to fetch a list of libraries or a single
library as expected on the /public namespace. It is expected to return
the 'public' representation of the Koha::Library objects.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/libraries.t
=> SUCCESS: Test pass and they cover all the cases!
3. Try your favourite REST tool against the new route.
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:08:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:08:56 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-oEFQSAskF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124483&action=edit
Bug 28948: (QA follow-up) Convert to allow-list

This patch converts the code to use an allow-list as aposed to a
deny-list.  This is more 'fail safe' than requireing maintanence of a
deny-list.

We also switch to using db fields names for the list as aposed to api
mapped names. This way, the list can be re-used for non-api related
sanitising if required.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:11:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:11:41 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-isOFZTFqXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:12:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:12:41 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-eNGkEJCsFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. grabbed the patches from bug 27358 as agreed and reworked them for the
libraries endpoints.. just minor alterations to tests to use the alternate
route really.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:12:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:12:48 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-Ea6f3rN5Yv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:18 +0000
Subject: [Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental
 discount is not set
In-Reply-To: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28774-70-wsXjuErBqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:25 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-JhQ2Yxj0xG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124472|0                           |1
        is obsolete|                            |
 Attachment #124473|0                           |1
        is obsolete|                            |
 Attachment #124474|0                           |1
        is obsolete|                            |
 Attachment #124475|0                           |1
        is obsolete|                            |

--- Comment #51 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124484&action=edit
Bug 18138: Use MARC modification template when adding/updating bibliographic
records

Add a preference that enables a specific marc modification template to be
applied on bibliographic records saved using simple or advanced MARC editor or
the HTTP API.

To test:
1) Create a MARC modification template containg one or more actions.
2) Under "Global system preferences" and "Cataloging" set the
"EditBiblioMarcModificationTemplate" preference to the name of the previously
created template.
3) Edit (or create) a bibliographic record using either the simple or advanced
MARC editor.
4) Save the record.
5) Verify that the action(s) have been applied.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:30 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-0Z7i6aTNw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124478|0                           |1
        is obsolete|                            |

--- Comment #52 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124485&action=edit
Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a
modification template

Rather than expecting the librarian to add an ID or a name we should provide a
dropdown

To test:
1 - Apply all patches
2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate'
3 - Note it list all defined Marc modification templates
4 - Select one
5 - confirm value in DB is the template id

Works fine for me

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:35 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-UbPlzNYOQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124476|0                           |1
        is obsolete|                            |

--- Comment #53 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124486&action=edit
Bug 18138: (follow-up) Add Objects for MarcModificationTemplates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:42 +0000
Subject: [Koha-bugs] [Bug 28306] Allow to query database with minimal memory
 footprint
In-Reply-To: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28306-70-jAlOfOpG6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:14:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:14:42 +0000
Subject: [Koha-bugs] [Bug 28410] Reduce memory footprint
In-Reply-To: <bug-28410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28410-70-e7u4QixVcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410
Bug 28410 depends on bug 28306, which changed state.

Bug 28306 Summary: Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:16:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:16:04 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-Euzajl3nLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124477|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:18:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:18:17 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-26Ru9F50rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124486|0                           |1
        is obsolete|                            |

--- Comment #54 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124492&action=edit
Bug 18138: (follow-up) Add Objects for MarcModificationTemplates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:18:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:18:22 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-Lsa0HCnPFo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124485|0                           |1
        is obsolete|                            |

--- Comment #55 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124493&action=edit
Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a
modification template

Rather than expecting the librarian to add an ID or a name we should provide a
dropdown

To test:
1 - Apply all patches
2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate'
3 - Note it list all defined Marc modification templates
4 - Select one
5 - confirm value in DB is the template id

Works fine for me

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:18:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:18:27 +0000
Subject: [Koha-bugs] [Bug 26195] Add a way to specify authorised values
 should be expanded [OAI]
In-Reply-To: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26195-70-Wh5t6PI1Fw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|                            |21.05.04
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04 by request.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:19:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:19:02 +0000
Subject: [Koha-bugs] [Bug 26195] Add a way to specify authorised values
 should be expanded [OAI]
In-Reply-To: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26195-70-A1iXCl482j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.05.04                    |21.11.00,21.05.04
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:19:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:19:43 +0000
Subject: [Koha-bugs] [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr
 introduction
In-Reply-To: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28928-70-ofNX5fsMAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:19:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:19:44 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-BiteqMiBzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
Bug 28938 depends on bug 28928, which changed state.

Bug 28928 Summary: Minor follow-ups to Bug 28376 - Flatpickr introduction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:20:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:20:39 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-zPLfFxmCUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:21:39 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-WrnvLJAONC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:21:39 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-Eyc6f2vGo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
Bug 28937 depends on bug 28938, which changed state.

Bug 28938 Summary: Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:21:39 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-e7FuinLReE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
Bug 28942 depends on bug 28938, which changed state.

Bug 28938 Summary: Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:21:39 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-FD5XRiyPXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
Bug 28945 depends on bug 28938, which changed state.

Bug 28938 Summary: Correct Flatpickr's default 12hr time formatting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:21:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:21:54 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-cj6pG5BwWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #56 from David Gustafsson <glasklas at gmail.com> ---
Did some squashing to clean things up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:22:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:22:11 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-iq6Wzd2Gnc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #37 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124495&action=edit
Bug 28373: [21.05.x] Add PassItemMarcToXSLT system preference

Default stylesheets do not reference item fields for XSLT display, however, we
spend time translating the values in the item fields.

This patch adds a system preference, PassItemMarcToXSLT. and unless enabled we
remove
item fields before processing

To test:
1 - Perform some search on the staff client and opac
2 - Use the console (F12) to view the time spent on the network tab
3 - Note performance
4 - Apply patch, updatedatabase, restart_all
5 - Repeat searches
6 - Note that display has not changed
7 - Note performance, results should display slightly faster

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 28373: Unit test

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 28373: (QA follow-up) Fix typo in system preference description

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 28373: (follow-up) QA fixes

Use fully qualified subroutine name
Don't return explicit undef

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 28373: (QA follow-up) Add . to end of system preference description

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Bug 28373: Add note to XSLT prefs about the new pref

Bug 28373: Add warning if custom stylesheets are defined

This patch adds a check of the current XSLT prefs and warns to check the new
pref
if any are not set to default

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:26:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:26:49 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-cNhtwacJfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124496&action=edit
Bug 28373: (follow-up) Fix copy error

Previous commit linked all 'default' buttons for sysprefs to
OPACXSLTListsDisplay

This adjusts the links

To test:
Click "default" for all 6 XSLT preferences
Confirm the syspref relating to the link is marked 'modified' when clicked

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:27:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:27:26 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-z7pWMiahy2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
After playing with this in a few ways I think I like the plan of doing as dbic
does with the standard returns.. i.e. using wantarray and taking note of
context.

I don't hugely like the use of Context.Scalar in templates.. it feels
cumbersome somehow, but Tomas showed me a core tt plugin that allows
thingy.scalar.relationship.. i.e adding scalar into the chain. That seems to
work OK in my testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:36:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:36:13 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-sYrXdeXUr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #29)
> +    my $group_by =
> +      [ map { 'me.' . $_ } $self->_resultset->result_source->columns ];
> +
> +    my $attrs = {
> +        join     => 'accountlines',
> +        group_by => $group_by,
> 
> You probably dont want to group by on all patron columns, heh ?

Actually, that's required by strict mode SQL.. we're already doing it all over
the place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:40:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:40:52 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-gjtWKKJkrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124497&action=edit
Bug 15156: Add filter_by_amount_owed that's chainable

This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.

The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:41:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:41:19 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-fPU9i1xsqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122392|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:41:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:41:29 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-4OLNlrIXwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122534|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:41:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:41:39 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-mqbd7cOpyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:42:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:42:42 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-S6zr6uucyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #28)
> +    return $self
> +      unless ( defined($options)
> +        && ( $options->{less_than} || $options->{more_than} ) );
> 
> Would this raise questions if people only pass library or debit_type and get
> much more than expected ?

Hmm, I'm not so sure.. we could throw an exception I suppose.. the filter
expects/requires these options to be passed to make any sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:47:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:47:07 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-jSZm8jZnBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Cloned the foundational code to bug 28948 so we can keep this public allow list
stuff moving.

Lets come back to this once that's pushed and just add the API route and
additional filter by framework visibility stuff in this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:50:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:50:40 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-1WZ2jNm4FN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124319|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124498&action=edit
Bug 28854: Add ability to create and circulate item bundles

This patch adds the ability to attach item bundles to biblio records. Item
bundles can then be circulated as with normal items.

Upon attaching an item to one of these item bundles, the item is automatically
marked as not for loan at it's original host biblio record.

When returning a bundle, the list of items that are part of this bundle
will be displayed, and a verification form is exposed requireing the
librarian to scan item barcodes to verify their presence. Should a bundle
be found to have items missing they will be marked as lost.

Bundles can also be used in the inventory tool as a filter.

Test plan:
0.  Apply the patch, run updatedatabase + update_dbix_class_files
1.  Create a new bundle record.
1a. Create a biblio record with leader position 7 set to 'c' for collection.
1b. Create an item for this biblio record.
1c. You should now see a new 'Bundle' button next to the item in the holdings
    table.
    Test: Verify that this 'Bundle' button only appears for biblio's where
leader
    position 7 is not 'c' for collection
1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items
    to the bundle.
    Test: Enter a non-existant barcode, submit and confirm you recieve an error
message.
    Test: Enter an existing barcode, submit and note the success message.
    Test: Enter the same barcode as above, submit and note the warning message.
    Test: Add a second item to the bib and try bundling one of the above
    items into this second item, note the error message.
2.  Open a new tab and look at the holdings data for one of the items you
attached
    to a bundle in step 1.
    Test: Verify that the holdings status displays 'Not for loan'.
    Test: Verify that the holdings status show which bundle the item has been
    attached to.
3.  Perform a checkout on the first bundle item.
    Test: Checkout should proceed as normal, obeying the circulation
    rules for the item type you chose to convert into a bundle.
4.  Perform a checkin on the first bundle item.
    Test: You should be presented with a modal that contains a list of items
    contained in the bundle and a test box for entering item barcodes.
    Test: Enter some of the barcodes for items in the bundle into the box and
submit.
    The bundle item should have been marked as returned, you should also
    have been notified of missing items and have the ability to print an
    updated contents list.
    Test: Verify that the items you did not enter barcodes for are now
    marked as lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:53:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:53:19 +0000
Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items
In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24023-70-pDiBJJ4qQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've created a modernised version of this in bug 28854... it uses the Koha
namespace and API as much as it can and improves on the UX I believe.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:54:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:54:45 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-iyRyNPWsLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28874

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 17:54:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 15:54:45 +0000
Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of
 our TT plugins
In-Reply-To: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28874-70-NKm4H3r0mK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26635

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 18:54:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 16:54:07 +0000
Subject: [Koha-bugs] [Bug 28950] New: serialsUpdate cron does not mark an
 issue late until the next issue is expected
Message-ID: <bug-28950-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950

            Bug ID: 28950
           Summary: serialsUpdate cron does not mark an issue late until
                    the next issue is expected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When running the cron it does this:
1 - Get all issues with a published date + grace period before today
2 - Loop the related subscriptions
3 - Check the next published date for the serial
4 - Compare the next issues publisheddate to today
5 - Mark late/generate the next issue if the next issue should already be
published

For a monthly serial with a 30 day grace period, this is usually ok

For a yearly serial this is a problem
1 - Issue expected 2021-07-01, 30 day grace period
2 - As of 2021-08-01 that serial is past the grace period
3 - Next issue is planned for 2022-07-01
4 - Serial not marked late for a year

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 18:54:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 16:54:59 +0000
Subject: [Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue
 late until the next issue is expected
In-Reply-To: <bug-28950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28950-70-Kw1E78dzTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |,
                   |                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |sbrown at bywatersolutions.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27499

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 18:54:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 16:54:59 +0000
Subject: [Koha-bugs] [Bug 27499] serialsUpdate doesn't create all late issues
In-Reply-To: <bug-27499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27499-70-XHjFAZsDZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27499

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28950

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 19:05:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 17:05:28 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-1stCeWaRTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 19:16:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 17:16:56 +0000
Subject: [Koha-bugs] [Bug 28951] New: Parental Controls
Message-ID: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28951

            Bug ID: 28951
           Summary: Parental Controls
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Parents have the ability to filter content when it comes to kids browsing their
streaming services, but they have no control when it comes to the catalog.

There should be some way for a parent to login to their account, and set
filters for the linked children accounts.  Filtered settings should have some
way to be verified for plugins and other 3rd party add-ons.

Technically, this could be circumvented by not logging in and browsing the
catalog, if the catalog is open to the public.  But there should be some
mechanism in place to be able to do this if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 19:53:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 17:53:01 +0000
Subject: [Koha-bugs] [Bug 28952] New: Item Checkout History fails
Message-ID: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28952

            Bug ID: 28952
           Summary: Item Checkout History fails
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: beardst at rlasd.net
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 124504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124504&action=edit
MySQL output

We are getting an error whenever trying to view an item's checkout history.
This is happening on all items that we have tested

/cgi-bin/koha/circ/bookcount.pl?&biblionumber=33518&itm=18222

Results in a 500 error

The Plack error log reports

CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_circ_bookcount_2epl::issuessince():
DBI Exception: DBD::mysql::st execute failed: Incorrect TIMESTAMP value: '0'
[for Statement "SELECT SUM(count) FROM (
                        SELECT COUNT(*) AS count FROM issues WHERE itemnumber =
? and timestamp > ?
                        UNION ALL
                        SELECT COUNT(*) AS count FROM old_issues WHERE
itemnumber = ? and timestamp > ?
                     ) tmp" with ParamValues: 0="18222", 1=0, 2="18222", 3=0]
at /usr/share/koha/intranet/cgi-bin/circ/bookcount.pl line 63


If I run the above sql statement with the variables populated it returns
information. Screenshot is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:09:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:09:33 +0000
Subject: [Koha-bugs] [Bug 28953] New: Incorrect behavior when voiding a
 payment on an fine that was paid while accruing and later backdated at
 return such that it should not have been fined
Message-ID: <bug-28953-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28953

            Bug ID: 28953
           Summary: Incorrect behavior when voiding a payment on an fine
                    that was paid while accruing and later backdated at
                    return such that it should not have been fined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Apologies, I can't figure out how to say any of this concisely.

To recreate:
- Have an overdue item with an accruing fine
- pay the fine
- check in the item, backdated to before its due date
- confirm that your patron shows a credit for overpayment of a fine
- void your payment
- confirm patron's account is not right

The fine shows amount=0 and amountoutstanding = [whatever the original fine
was]. The patron shouldn't owe us anything here.

Further complicating things, the fine doesn't show on the Make a Payment tab at
all -- seems like the logic here must be to only show fines where the
amountoutstanding > amount?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:09:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:09:58 +0000
Subject: [Koha-bugs] [Bug 28953] Incorrect behavior when voiding a payment
 on an fine that was paid while accruing and later backdated at return such
 that it should not have been fined
In-Reply-To: <bug-28953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28953-70-DBq9uTU2jG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28953

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:51:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:51:13 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-PAnWFCKg0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:51:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:51:43 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-UyUPkcVIeA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124505&action=edit
Bug 28529: Add BiblioHoldItemTypeUseForRules system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:51:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:51:47 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-EiNKtopPY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124506&action=edit
Bug 28529: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:51:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:51:51 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-BypFsGrxjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124507&action=edit
Bug 28529: Make biblio-level hold itemtype count against max rules

The current situation is that biblio-level holds can be assigned an item
type, so they can only be fulfilled by items matching that specified
item type (be it item-level itype or the fallback to biblio-level).

But there's the situation in which max holds limits for a specific item
type can be overridden by using biblio-level holds with item type
selection (AllowHoldItemTypeSelection) enabled.

To test:
1. Have a patron of category 'Staff' (S)
2. Have 3 records with items with the 'BK' item type, and maybe others
3. Enable AllowHoldItemTypeSelection
4. Set a limit of 2 max holds for that category+item type
5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on
those 3 records
=> FAIL: You can place the 3 holds
6. Cancel the holds
7. Apply this patch and restart all
8. Repeat 5
=> SUCCESS: You can only place 2 holds
9. Run:
   $ kshell t/db_dependent/Reserves.t
=> SUCCESS: Tests pass!
10. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:52:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:52:09 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-gOnV7nvroQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:52:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:52:47 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-0X97WYVkod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 21:54:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 19:54:36 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-BoST0awNkl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #2)
> Hi Tomas,
> I seem to remember that the biblio-level itemtype played into the max holds
> setting as well (which poses a problem to us, as we usually don't set it).
> 
> In your test, was there a biblio-level itemtype (942$c) set?

I did some digging about this. The biblio-level itype is used for item-level
holds, when item-level_itypes is disabled. So it doesn't seem to be the same
thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep  3 22:48:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 20:48:25 +0000
Subject: [Koha-bugs] [Bug 28953] Incorrect behavior when voiding a payment
 on an fine that was paid while accruing and later backdated at return such
 that it should not have been fined
In-Reply-To: <bug-28953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28953-70-P6op85ldXx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28953

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 00:36:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 22:36:41 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-na42dzYpVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #8 from David Nind <david at davidnind.com> ---
I couldn't reproduce the issue before the patch is applied
(koha-testing-docker):

- For step 4 I setup a circulation and fines rule for patron category=Staff and
item type = Books, with holds allowed (total) = 2
- Using the OPAC, I placed holds with "Request specific item type" set to Books
- I can't place a third hold (message was "There are no items that can be
placed on hold.")
- AllowHoldItemTypeSelection is enabled
- The records I placed holds on all have 942$c set to Books and each item is
also set to Books and have multiple items

Is there something else or other system preference setting needed?

I'm guessing it is something with the circulation and fines rules that I'm not
getting right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 00:49:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 22:49:31 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-Hzc6spp0ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 00:49:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 22:49:37 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-9QGd1tFJho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124497|0                           |1
        is obsolete|                            |

--- Comment #34 from David Nind <david at davidnind.com> ---
Created attachment 124508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124508&action=edit
Bug 15156: Add filter_by_amount_owed that's chainable

This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.

The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 00:51:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 22:51:45 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-twJzQEpuF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #35 from David Nind <david at davidnind.com> ---
Tested by running prove t/db_dependent/Koha/Patrons.t before and after patch
applied - tests pass (using koha-testing-docker).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 01:13:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 23:13:41 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-RaxfPxiBD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 01:13:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 23:13:46 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-dcIgbJGUgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124246|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 124509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124509&action=edit
Bug 28921: Argument "" isn't numeric in numeric gt (>) at
/home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line
23.

To test:
1 - Open OPAC main page
2 - Check opac-error.log or plack-opac-error.log for message as above
3 - Apply patch
4 - Open OPAC main page
5 - Check opac-error.log again, there should be no more warnings

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 01:18:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 23:18:00 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-a3Qd891WbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (koha-testing-docker):

- I could only get the warning message to appear once (the first time I opened
the OPAC home page, flush_memcached and restart_all didn't make any difference,
using different browsers didn't either)
- After applying the patch I closed down koha-testing-docker and started things
up again, there was no warning message in the logs when accessing the OPAC home
page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 01:41:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 03 Sep 2021 23:41:24 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-bUfnsiibsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement
      release notes|                            |significantly improves the
                   |                            |performance when merging
                   |                            |records with many items
                   |                            |(for an installation using
                   |                            |Elasticsearch).
                   |                            |
                   |                            |Before
                   |                            |this enhancement the web
                   |                            |server would time out as
                   |                            |the search engine was
                   |                            |reindexing the origin
                   |                            |record and the destination
                   |                            |record for each item
                   |                            |moving.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:42:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:42:29 +0000
Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC
 (updates existing)
In-Reply-To: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20390-70-BYT3n4LCOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:47:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:47:32 +0000
Subject: [Koha-bugs] [Bug 28894] Boost search results by date published,
 acquisition date or latest edition
In-Reply-To: <bug-28894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28894-70-YjYIv3VAjn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28894

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:47:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:47:53 +0000
Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items
In-Reply-To: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26860-70-HuwGmtQ01Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:48:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:48:09 +0000
Subject: [Koha-bugs] [Bug 28781] Elasticsearch facets may be inaccurate
In-Reply-To: <bug-28781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28781-70-DX65CFQwL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28781

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:48:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:48:13 +0000
Subject: [Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of
 non-suppressed titles that contain punctuation
In-Reply-To: <bug-28801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28801-70-i3qvqnObxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:48:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:48:22 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-pmlPOrMiDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:48:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:48:29 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-3L7tuhu1gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:48:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:48:36 +0000
Subject: [Koha-bugs] [Bug 24129] Add ability to configure some indexes to
 not autotruncate
In-Reply-To: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24129-70-mPO5LIG2E6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24129

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:49:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:49:23 +0000
Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#,
 .NET, C++ in searching
In-Reply-To: <bug-9729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9729-70-DeswqdvC1O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:49:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:49:46 +0000
Subject: [Koha-bugs] [Bug 22636] Elasticsearch admin page design enhancement
In-Reply-To: <bug-22636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22636-70-9InfiFxr44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22636

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:49:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:49:55 +0000
Subject: [Koha-bugs] [Bug 24678] Add missing search fields to Elasticsearch
 mappings
In-Reply-To: <bug-24678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24678-70-UEJ5zelbAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24678

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 13:50:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 11:50:26 +0000
Subject: [Koha-bugs] [Bug 28915] MARC Modification Templates should allow
 specification of a position or range within a control field
In-Reply-To: <bug-28915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28915-70-3O3v0T9Bk1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 19:35:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 17:35:16 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-pgoU2omviI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 19:35:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 17:35:22 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-XrXdmPnqRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123313|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124510&action=edit
Bug 28782: Use query param list instead of splitting elements using '/'

This removes the need to handle single and multiple cases separately,
thus removing bunch if-else cases and simplifying our code. This
coding style is also in line with our other .pl scripts.

To test:
 1) Make sure placing a hold still works from the following pages:

   /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX

   /cgi-bin/koha/catalogue/search.pl?q=a

   /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX

   /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron
   there and through the clubs.pl create a hold to a bib)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 19:35:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 17:35:45 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-fbLlMzJSto@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Hayley Pelham from comment #6)
> Patch doesn't apply

Rebased, ready for testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 20:29:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 18:29:25 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-qreQyyyJ3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 20:29:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 18:29:29 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-MobKTkXFxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124442|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124511&action=edit
Bug 21794: Fix display of addresses on details tab in staff when city is empty

If the city field was not filled out on the main or alternate address,
the content of state, country and zipcode wouldn't display on the
Details tab in the patron account in staff.

To test:
- Enter main contact and alternate address without city
- Verify that the address information isn't shown on the details
  tab after saving
- Apply patch
- Verify that the information is displayed now
- Toggle AddressFormat and check display is correct for all settings
- Switch back to US address format
- Try several combinations of empty fields for city, zipcode, country
  and state. The punctuation and whitespace should always appear
  correctly.

Examples:
- Enter just country
- Enter zipcode and country
- ...

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 20:29:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 18:29:33 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-jsPOB9Qlf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124512&action=edit
Bug 21794: (QA follow-up) Separate city and country with a comma

If only the city and country address information was provided they ended
up being glued together like this: CityCountry. (AddressFormat=US style)

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 20:34:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 18:34:10 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-4yxqU49osb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep  4 22:22:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 20:22:29 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-FBGn0vSwRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #325 from Andrew Nugged <nugged at gmail.com> ---
Martin, your rebase applies on master silently,
but conflicts (catalogue/detail.pl) when to apply over dependant (as in ticket 
Bug 28484).

Ah, now I figured more: patch 124397 removes most of Bug 28484 changed code,


... so it looks like we just need to remove dependency reference from this BZ
ticket?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 01:08:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 04 Sep 2021 23:08:07 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-c2Rw5Rq2lv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you Hayley and Joonas :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 11:03:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 09:03:48 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
 change for backwards compatibility
In-Reply-To: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28200-70-BbhmC0bxEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #34 from Mason James <mtj at kohaaloha.com> ---
(In reply to wainuiwitikapark from comment #33)
> Not backported to 19.11.x 
> 
> Please see Victor's comment above.

hi Wainui
i have added a jenkins build for 19.11 on deb11

can you please add this patch to 19.11, so the jenkins tests pass?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 11:04:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 09:04:19 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
 change for backwards compatibility
In-Reply-To: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28200-70-PWbzd4xfHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 11:32:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 09:32:37 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-hnXhXJREor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
This patch breaks the group selection in OPAC advanced search, i.e. with this
patch applied if you go to the URL

http://localhost:8080/cgi-bin/koha/opac-search.pl?advsearch=1&weight_search=1&multibranchlimit=1&sort_by=relevance&do=Search 

then the group doesn't get selected in the search menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 12:21:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 10:21:56 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-ObXl4Tku88@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Thanks, I think this change looks reasonable, though some things to fix.

1) Could you fix up the commit message, you mention that this fixes a bug but
don't say which one, also mention in the commit message what the change does
and use the format "Bug XXXX: Change X thing". I'm guessing you are doing this
change to simplify (custom) CSS rules?

2) It seems to break the OpacHeader / opacheader CSS rule defined in the line

koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 14:16:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 12:16:14 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-oHzNWLyHzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 14:16:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 12:16:18 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-niW8CtlChe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124129|0                           |1
        is obsolete|                            |

--- Comment #18 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124513&action=edit
Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21)

At the moment the punctuation entered for $n $p and is
removed in the part template, which leads to displaying the subfields
without any punctuation and spaces in between.

To test:
- Catalog records with various combinations of 8xx series added
  entry fields. Subfield a, t, n, p and v are the most important.
- Verify the display in OPAC and staff is not great.
- Apply the patch.
- Verify the display in OPAC and staff is improved.

For examples see:
https://www.loc.gov/marc/bibliographic/bd80x83x.html

Important note: At the moment 8xx series added entry fields will only display,
when
there is also a 490 ind. 1 = 1 field present.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 14:16:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 12:16:21 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-KptsOKKTNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

--- Comment #19 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124514&action=edit
Bug 10265: (QA follow-up) Make if-else checks consistent

The != '' version doesn't check for the whitespace existing and thus
might have added the punctuation without the partNumber or partName being
inserted at all.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 14:16:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 12:16:53 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-fObpbRInpI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |joonas.kylmala at iki.fi
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 15:00:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 13:00:40 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-00MPPd1a9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 15:00:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 13:00:44 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-l8A0VIRkKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124371|0                           |1
        is obsolete|                            |

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124515&action=edit
Bug 28392: make streettype and B_streettype work with BorrowerUnwantedField

To test:
1. Add values to the AV ROADTYPE
2. Go to the BorrowerUnwantedField system preference and attempt to hide
streettype and B_streettype.
3. It doesn't work, the fields still show.
4. Apply patch
5. Repeat step 2, it should work now.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 15:01:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 13:01:13 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-6zgaP7RFXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 15:54:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 13:54:00 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-qgCfSdEHoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 15:54:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 13:54:04 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-XLEYZTCxnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124413|0                           |1
        is obsolete|                            |

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124516&action=edit
Bug 28936: Add sort1/sort2 to borrowers.json

To Test:
1. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences, sort1 and sort2 cannot be hidden or required
2. Apply patch
3. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences again, you should see sort1 and sort2
4. Since sort1 and sort2 are now added to borrowers.json we must also check the
system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
5. They should both now include sort1 and sort2, check to make sure they work
with these two system preferences
6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField,
PatronSelfRegistrationBorrowerUnwantedField, and
PatronSelfModificationBorrowerUnwantedField
7. sort1 and sort2 should be disabled in these OPAC system preferences

This patch does not attempt to add sort1 or sort2 to the self reg or borrower
mod pages. If they should be added, which I am not sure they should, we should
do so in a seperate bug

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 16:03:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 14:03:46 +0000
Subject: [Koha-bugs] [Bug 28951] Parental Controls
In-Reply-To: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28951-70-Itw69aaKUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28951

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 16:35:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 14:35:08 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-3jRRIzVmS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 16:35:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 14:35:13 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-g8CboRPjcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123983|0                           |1
        is obsolete|                            |
 Attachment #123984|0                           |1
        is obsolete|                            |

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124517&action=edit
Bug 28149: Improve internationalization and formatting on background jobs page

This patch adds some logic to the background jobs template in order to
make job status and job type translatable. Output of dates has been
changed to use the KohaDates plugin, using the "with_hours" flag.

This patch also modifies the page title and breadcrumbs so that if one
is viewing the details of a background job the page title and
breadcrumbs reflect this.

I've also added inclusion of the preferences search form in the header,
the default for administration pages which don't have their own search.

To test, apply the patch and go to Administration -> Background jobs.

 - If there are no background jobs listed, submit at least one batch of
   bibliograhpic records and at least one batch of authorty records for
   modification (Tools -> Batch record modification).
   - In the table of background jobs, the status should be shown
     correctly. If you see it capitalized ("Finished") you're seeing the
     new string in the template which will be used for translation.
   - In the "Type" column, you should see either "Batch authority record
     modification" or "Batch bibliographic record modification"
   - In the "Queued," "Started," and "Ended" columns the date should be
     formatted according to your system's dateformat system preference,
     including the time.
  - View the details of a background job. The same changes to status and
    type should be seen on this page, as well as the date formatting of
    the date fields.
    - In the breadcrumbs, confirm that it shows a link to the
      background jobs page followed by "Details if job #X".

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 16:35:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 14:35:17 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-9DPZkCWGf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124518&action=edit
Bug 28149: (follow-up) Add string for job status "new"

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 17:03:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 15:03:22 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-oDaa2Dx00L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 17:03:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 15:03:26 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-Jq01QJ2NsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124236|0                           |1
        is obsolete|                            |
 Attachment #124237|0                           |1
        is obsolete|                            |

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124519&action=edit
Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set

If Pseudonymization is set but the bcrypt_settings config used by the
feature is not set, then there is an ugly 500 on checking out.

bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line
116.

However it's pretty hard to handle correctly this exception (and that's
why it hasn't be done initially). However we could prevent the pref to
be turned on if the config entry is not present.

Test plan:
Remove the bcrypt_settings from the config
Try to turn the syspref on
Add the config
Try to turn the syspref on/off

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

JD amended patch: fix qa failures

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 17:03:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 15:03:30 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-SdXcSjxMfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124520&action=edit
Bug 28912: Remove duplicated warnings on the about page

Bad conflict resolution

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep  5 17:05:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 15:05:21 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-LgCMju44zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #12 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
This is a nice improvement and blocks the common case where the ISE might
happen. If someone wants to further improve this the specification for the
bcrypt setting string is defined in 

https://metacpan.org/pod/Crypt::Eksblowfish::Bcrypt#bcrypt(PASSWORD,-SETTINGS)

and we could handle the error more gracefully if it doesn't follow the format.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 00:04:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 22:04:37 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-cRqmkFkSsi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, we already have PatronSelfRegistrationExpireTemporaryAccountsDelay for the
number of days.

It seems like a double up to introduce an additional pref to secure another
one. Maybe we need to make sure that this one can also be used to deactivate?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 01:58:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 23:58:31 +0000
Subject: [Koha-bugs] [Bug 28951] Parental Controls
In-Reply-To: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28951-70-3liJrxQ1e9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28951

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 01:59:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 05 Sep 2021 23:59:23 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-wCDt1vlnwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 02:09:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 00:09:28 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
 change for backwards compatibility
In-Reply-To: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28200-70-3GyJglDiwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200

--- Comment #35 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 02:15:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 00:15:12 +0000
Subject: [Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor
 change for backwards compatibility
In-Reply-To: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28200-70-YIfD4PTg0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.05.00,20.11.07,20.05.13  |21.05.00,20.11.07,20.05.13,
        released in|                            |19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 04:25:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 02:25:25 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-cFWFknB0Qv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 04:25:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 02:25:41 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-tBoadMdO15@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124510|0                           |1
        is obsolete|                            |

--- Comment #9 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124521&action=edit
Bug 28782: Use query param list instead of splitting elements using '/'

This removes the need to handle single and multiple cases separately,
thus removing bunch if-else cases and simplifying our code. This
coding style is also in line with our other .pl scripts.

To test:
 1) Make sure placing a hold still works from the following pages:

   /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX

   /cgi-bin/koha/catalogue/search.pl?q=a

   /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX

   /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron
   there and through the clubs.pl create a hold to a bib)

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 08:02:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 06:02:52 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-yxReWRZ4pE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124516|0                           |1
        is obsolete|                            |
                 CC|                            |emmi.takkinen at koha-suomi.fi

--- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124522&action=edit
Bug 28936: Add sort1/sort2 to borrowers.json

To Test:
1. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences, sort1 and sort2 cannot be hidden or required
2. Apply patch
3. Check the BorrowerMandatoryField and BorrowerUnwantedField system
preferences again, you should see sort1 and sort2
4. Since sort1 and sort2 are now added to borrowers.json we must also check the
system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
5. They should both now include sort1 and sort2, check to make sure they work
with these two system preferences
6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField,
PatronSelfRegistrationBorrowerUnwantedField, and
PatronSelfModificationBorrowerUnwantedField
7. sort1 and sort2 should be disabled in these OPAC system preferences

This patch does not attempt to add sort1 or sort2 to the self reg or borrower
mod pages. If they should be added, which I am not sure they should, we should
do so in a seperate bug

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:35:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:35:15 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-FnGqX33UBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11175                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
[Bug 11175] Show the parent record's component parts in the detailed views
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:35:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:35:15 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-3CaG6HhzuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28316                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
[Bug 28316] Fix ES crashes related to various punctuation characters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:39:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:39:32 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-HFcUoyWj0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124382|0                           |1
        is obsolete|                            |

--- Comment #326 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124534&action=edit
Bug 11175: Show record component parts in the detail view

Shows the component records of a host, on the hosts detail view in
staff client or OPAC, with clickable links to the component records.

The host does not require linking entries to the components, but
components do require a link to the host record via 773$w.

Adds a new search index, Control-number-identifier (aka cni), which
indexes the 003 controlfield.

Adds 'Yet Another System Preference', ShowComponentRecords, which can
be used to turn this feature on or off in staff client and/or OPAC,
and defaults to off.

When looking up the component part records, the code searches for
records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'
or, if the 003 is not defined in the Host, 773$w=Host001.

Does not use easyanalytics or useControlNumber.

Only for MARC21 biblios - UNIMARC has not been updated.

staff-global.css and opac.css have not been recreated, so you need
to use sass to recreate those from staff-global.scss and opac.scss

Test plan:

0) Apply patch
1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML
   (This file is an attachment on the bug)
2) rebuild the zebra biblio index
3) Search for "easy piano" in staff client, and go to
   the biblio detail page. You should not see anything different
   in the record detail page.
4) Do the same on OPAC.
5) Change the ShowComponentRecords syspref appropriately and check
   the record detail page in staff client and OPAC.
   You should see a list of component part records.

Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:39:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:39:39 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-85moTrPmbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124383|0                           |1
        is obsolete|                            |

--- Comment #327 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124535&action=edit
Bug 11175: (follow-up) Don't return explicitly undef

This would create in list context an list of one element that is
undef, which we don't want, we want empty list if there are no
components.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:39:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:39:47 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-pYMFum485z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124384|0                           |1
        is obsolete|                            |

--- Comment #328 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124536&action=edit
Bug 11175: (follow-up) Return empty array if no components

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:39:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:39:53 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-KattjA8lvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124385|0                           |1
        is obsolete|                            |

--- Comment #329 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124537&action=edit
Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref
description

The syspref is not only affecting staff interface so moving it to
Cataloguing section. Added also notes about UNIMARC and Elasticsearch
not being supported.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:00 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-RUjA0ghGT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124386|0                           |1
        is obsolete|                            |

--- Comment #330 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124538&action=edit
Bug 11175: Add Elasticsearch support

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:08 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-vBeXjbiXzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124387|0                           |1
        is obsolete|                            |

--- Comment #331 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124539&action=edit
Bug 11175: Keep component part record list items inside the box

Without this the number denoting the component part item in the list
will overflow and is partly hidden.

To test:
 1) Create 100 component parts
 2) Notice without this patch the number next to the component part is
    not fully shown

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:15 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-4eAnL1ktNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124388|0                           |1
        is obsolete|                            |

--- Comment #332 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124540&action=edit
Bug 11175: Limit the amount of component parts returned

There was already before this a limit of 100 results when using
Elasticsearch but then the list of component parts was truncated
silently. This change now limits the amount to hard coded limit of 300
which is still fast to render. Also when the 300 component part record
limit is reached there is a link in the list now to list all the
records via the cataloging search.

To test:
   1) Create 300+ component part records and see if the link to list
      all the component part records shows up
   2) Make sure prove t/Koha/Util/Search.t passes

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:23 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-UZQY1jgRH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124389|0                           |1
        is obsolete|                            |

--- Comment #333 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124541&action=edit
Bug 11175: Search using double quotes to support Elasticsearch

With Elasticsearch if you would use the search string here without the
change to double quotes, i.e.

(rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234'

then the search would somehow manage to return a record with 001 =
1234 and 003 = FI-XXX. Using double quotes prevents that. Also using
parenthesis around the latter part of the OR seems to work:

(rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234')

Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:30 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-HLwbmRiOrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124390|0                           |1
        is obsolete|                            |

--- Comment #334 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124542&action=edit
Bug 11175: Remove outdated info about Elasticsearch not being suppported

Support for Elasticsearch was added in commit "Bug 11175: Add
Elasticsearch support".

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:33 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-pK23ik4Ycx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:38 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-RSdKfkjGev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124509|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124543&action=edit
Bug 28921: Argument "" isn't numeric in numeric gt (>) at
/home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line
23.

To test:
1 - Open OPAC main page
2 - Check opac-error.log or plack-opac-error.log for message as above
3 - Apply patch
4 - Open OPAC main page
5 - Check opac-error.log again, there should be no more warnings

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:40 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-nPs9oQdSzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124391|0                           |1
        is obsolete|                            |

--- Comment #335 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124544&action=edit
Bug 11175: (follow-up) Add tests

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:47 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-qtbgjAASSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124392|0                           |1
        is obsolete|                            |

--- Comment #336 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124545&action=edit
Bug 11175: (follow-up) make atomic update idempotent

Atomic update tries to insert line into system preferences even if it's
already there. This patch fixes that by adding 'IGNORE' to the query,
making it idempotent.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:55 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-kL5mD8E573@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124393|0                           |1
        is obsolete|                            |

--- Comment #337 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124546&action=edit
Bug 11175: (follow-up) Rename routine get_marc_components

For consistency with other marc data accessor methods rename the new
'components' method to 'get_marc_components'.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:40:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:40:55 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-Dy9aF9GbUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:03 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-ric0iBpA3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124394|0                           |1
        is obsolete|                            |

--- Comment #338 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124547&action=edit
Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc

This fixes the QA tool failure.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:10 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-QxPKD0npsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124395|0                           |1
        is obsolete|                            |

--- Comment #339 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124548&action=edit
Bug 11175: (QA follow-up) Move preference to 'Display'

The 'ShowComponentRecords' preference was displaying under the 'Export'
section in the cataloging system preferences tab. As a display related
feature, I felt it was more appropriate to put it into the 'Display'
section.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:17 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-qFZ5r2rQC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124396|0                           |1
        is obsolete|                            |

--- Comment #340 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124549&action=edit
Bug 11175: (QA follow-up) We lost Encode somewhere

This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it
somewhere along the way and broke the feature as it uses 'decode'.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:27 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-hKesqy4Zeg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124397|0                           |1
        is obsolete|                            |

--- Comment #341 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124550&action=edit
Bug 11175: (QA follow-up) Take account of bug 15851

We can simplify the code introduced by bug 15851 by moving the
'show_analytics_link' variable assignment into C4::XSLT and thus making
the code more DRY.

Taking the code in bug 15851 as inspiration this patch also adds proper
handling for UseControlNumber vs EasyAnalytics style 773 linking and
ensures we only return analytic component parts and no other records
containing 773's.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:35 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-i8zh9abinM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124398|0                           |1
        is obsolete|                            |

--- Comment #342 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124551&action=edit
Bug 11175: (QA follow-up) Move get_component_part_query

This patch removes Koha::Util::Search in preference to embedding the
search query builder in Koha::Biblio as get_analytics_query.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:43 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-TrEVgjgHVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124399|0                           |1
        is obsolete|                            |

--- Comment #343 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124552&action=edit
Bug 11175: (QA follow-up) Only get biblio once

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:51 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-bIzO5EPofu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124400|0                           |1
        is obsolete|                            |

--- Comment #344 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124553&action=edit
Bug 11175: (QA follow-up) Fix queries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:41:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:41:58 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-qB9bap5lF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124401|0                           |1
        is obsolete|                            |

--- Comment #345 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124554&action=edit
Bug 11175: Display components in own tab

This patch updates the display so that rather than displaying the
components using the main XSLT and then using CSS to move them into a
box on the right side for display, which causes issues with RTL records;
We instead add them in a new tab beneath the rest of the record details
alongside holdings and other details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:42:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:42:06 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-h9H7VWuY3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124402|0                           |1
        is obsolete|                            |

--- Comment #346 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124555&action=edit
Bug 11175: (QA follow-up) Rename back to get_marc_components

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:42:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:42:13 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-Eb1PNH4NNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124403|0                           |1
        is obsolete|                            |

--- Comment #347 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124556&action=edit
Bug 11175: (QA follow-up) Fixes for bug 12561

Bug 12561 changed the prototype for XSLTParse4Display so this patcha
accounts for the additional calls to that method introduced in this
patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:42:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:42:21 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-3cqllqo6hV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124404|0                           |1
        is obsolete|                            |

--- Comment #348 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124557&action=edit
Bug 11175: (follow-up) Use clean_search_term

This patch uses the now public clean_search_term from bug 28316 to
sanitize the title string and prevent crashes in elastic search when
title contain reserved characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 09:57:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 07:57:07 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-R8yJmAj47X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:04:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:04:50 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-Vt7dIIAHOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:04:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:04:54 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-muxb1ausn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124444|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124558&action=edit
Bug 28882: permission UI allows selection of superlibrarian permission

With bug 20100 and 22150 we allow to select all the permissions but the
superlibrarian permission, to ease the selection. And we also forbid a
non-superlibrarian user to add superlibrarian permission.

However there is something wrong in the JS code and it's possible to add
the superlibrarian permission. The user is getting an ugly 500 and so
the permission change is not done, but the UI checks must be fixed.

To recreate:
Login with a non-superlibrarian user
Edit permission
Clear all
=> You can select the "superlibrarian" permission

Test plan:
Login with a non-superlibrarian user
Try to set the superlibrarian permissions to a user
=> not possible
Try the select all/clear all
=> still cannot set the superlibrarian permission

Work to be done:
Login with a non-superlibrarian user
Edit permissions for a superlibrarian user
=> You can remove it, then cannot add it back
Should we allow removal of superlibrarian permission by
non-superlibrarian user?

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:04:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:04:57 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-kD9uraDOk8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124445|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124559&action=edit
Bug 28882: Disable select/hide all links

We want to prevent non-superlibrarian users to remove superlibrarian
flag.
It's handled already in the controller, but needs to be done
client-side.

Here we are disabling the select/hide all links to remove the remaining
possibility to remove the superlibrarian flag from non-superlibrarian
users.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:05:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:05:18 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-3IMN78febT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:08:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:08:30 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-2VW5qvLq4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #349 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Andrew Nugged from comment #325)
> Martin, your rebase applies on master silently,
> but conflicts (catalogue/detail.pl) when to apply over dependant (as in
> ticket  Bug 28484).
> 
> Ah, now I figured more: patch 124397 removes most of Bug 28484 changed code,
> 
> 
> ... so it looks like we just need to remove dependency reference from this
> BZ ticket?

There was a BZ dependency chain issue, your right.

All sorted now and rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 10:13:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 08:13:04 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-TwxgB8qPcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
What remains for me is the question: Should we allow a non-superlibrarian to
give him or herself the privilege to change systemprefs?
Because you can disable ProtectSuperlib etc..
But this should be solved on another report imo.

Should we only protect that pref, or a specific set of prefs, or actually not
allow changing sysprefs at all by non superlibs? I tend to choose the latter.
Even a few other options on the Admin menu like Koha to MARC mapping (among
others) might be candidates too for restricting them to superlibrarians only.
What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:06:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:06:02 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-ZLlpzjGREx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi
                   |ity.org                     |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Adjusted assignee. Good habit to fill in ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:08:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:08:37 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-LlzM3qCbgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Should this be an enhancement?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:17:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:17:57 +0000
Subject: [Koha-bugs] [Bug 28955] New: We need a way to set default branch
 from apache
Message-ID: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

            Bug ID: 28955
           Summary: We need a way to set default branch from apache
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

With the moved of some system preferences to News blocks we need a way to set
the default branch from apache such that we can display the right block prior
to users login.

We used to use SetEnvIf to set various prefs per domain.. it would be great to
be able to do the same from branchcode so the News blocks behave as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:19:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:19:00 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-nygvc0SBlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #16)
> Can we add a new table for the 2FA secrets please?

Why?
Adding it means that the code needs to be adjusted as well, to deal with 1-N
relationship at DB level. IMO the DB structure should reflect the UI. If we
need it later it will be easy to move it to a separate table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:23:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:23:02 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-1MX2HPIMq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Last patch needed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:24:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:24:16 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-DzW2bUVWKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

Mohamad Barham <mbarham at birzeit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #3 from Mohamad Barham <mbarham at birzeit.edu> ---
not fresh copy.

current version 21.05

upgrade from old version , I have changed koha.list to be 
deb http://debian.koha-community.org/koha stable main bullseye

update && upgrade && restart services 


I dont know exactly at which stage of upgrade happened (between which versions)

but problem 404 still exist, 

should I change smth manually regarding this route?
or should I wait till another release ?

note that its in production now


Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:36:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:36:37 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-xGAENbGH38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
If you are using debian 9, your apt source shouldn't contain "bullseye" (which
is the codename for debian 11).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 11:42:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 09:42:26 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-867IhJtJHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #5 from Mohamad Barham <mbarham at birzeit.edu> ---
removed,

my debian  is exactly 9.13

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 12:33:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 10:33:06 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-KEb9RuyGqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
So use:
deb http://debian.koha-community.org/koha stable main stretch

% apt update && apt install koha-common

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 12:50:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 10:50:29 +0000
Subject: [Koha-bugs] [Bug 20277] Link to host item doesn't work in
 analytical records if 773$a is present
In-Reply-To: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20277-70-BtDgbr0GzL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20277

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, would it be possible to also get this added to the corresponding search
which sets whether the 'Show analytics' link it visible or not (or depend on
11175 and update the search string method there?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 12:51:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 10:51:46 +0000
Subject: [Koha-bugs] [Bug 20277] Link to host item doesn't work in
 analytical records if 773$a is present
In-Reply-To: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20277-70-CMxqUVpDSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20277

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd love to DRY this search string out a bit honestly.. constructing it within
the XSLT and also having an accessor for it in the Koha::Biblio objects isn't
great practice.. perhaps we should pass it as an XSLT variable from the Biblio
object and thus only have it built in one place.?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:07:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:07:45 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-9CcYqbeMTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #530 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Ere Maijala from comment #521)
> Eww... As far as I can see, bug 24857 looks like a subset of proper holdings
> records. It's a lot of semi-duplicate work...
> 
> I'll pick up from where Joonas got things.

There are a whole set of bugs around item grouping at the moment.. all doing
similar things but not exactly the same.

* The volumes one, which has now been renamed to 'Item groups' for clarity is
for grouping items within a bib record so you can place a group level hold.
* The bundles one is for grouping items from different bibs into a new bib for
loaning as a set with automatic withdrawal from normal circulation otherwise.

I'm not entirely sure I'm close enough to MARC Holdings to know how/where it is
used or how it may overlap, be a superset or subset of the other two bugs.

There's also been lots of work to improve our handling of Component Parts and
Volume linked records (i.e. 773 and friends)  See bug 11175.

I'll try to take another look at this soon but my brain is a bit of a mess
trying to distinguish between all these features.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:56:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:56:47 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-I7dKGmxTXb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11175

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:56:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:56:47 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-3kubkNIaSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20447

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:57:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:57:08 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-DKqPiWyVf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28854

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:57:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:57:08 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wXkYAheKvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20447

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:57:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:57:50 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-yU68OPY51t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24860

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 13:57:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 11:57:50 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-IxFsjvUObT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20447

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:00:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:00:36 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-7mtVG1yIyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #531 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry.. doesn't apply again.. Koha is moving fast in this area at the moment!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:16:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:16:46 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-89odqz3dy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Tomás Cohen Arazi from comment #16)
> > Can we add a new table for the 2FA secrets please?
> 
> Why?
> Adding it means that the code needs to be adjusted as well, to deal with 1-N
> relationship at DB level. IMO the DB structure should reflect the UI. If we
> need it later it will be easy to move it to a separate table.

2FA secrets (and the same for overdrive tokens, etc) are not part of the
'patron' entity. Changing the model like this to avoid a new table has another
side effects: you will need to remove it in Koha::Patron::to_api_mapping, and
if we want to add routes for dealing with them, the code will look weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:22:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:22:54 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-r1GeNi5bZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26314

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:22:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:22:54 +0000
Subject: [Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless
 of whether there are volumes linked to the record
In-Reply-To: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26314-70-fZVID7vIDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11175

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:23:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:23:42 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-VWoyv9mBB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20277

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:23:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:23:42 +0000
Subject: [Koha-bugs] [Bug 20277] Link to host item doesn't work in
 analytical records if 773$a is present
In-Reply-To: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20277-70-0cyX33F1VY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20277

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11175

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 14:24:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 12:24:20 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in
 the detailed views
In-Reply-To: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-KOcDIdpV2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #350 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The search changes introduced in bug 20277 will also need to be applied here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:51:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:51:45 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-V0haXpkkPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Peter Vashchuk <stalkernoid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:51:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:51:50 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-6N0eWBLO1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Peter Vashchuk <stalkernoid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124372|0                           |1
        is obsolete|                            |
 Attachment #124373|0                           |1
        is obsolete|                            |
 Attachment #124374|0                           |1
        is obsolete|                            |
 Attachment #124375|0                           |1
        is obsolete|                            |
 Attachment #124376|0                           |1
        is obsolete|                            |
 Attachment #124377|0                           |1
        is obsolete|                            |
 Attachment #124378|0                           |1
        is obsolete|                            |

--- Comment #95 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124560&action=edit
Bug 28316: add tests

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:51:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:51:57 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-40uLd3Sodc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #96 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124561&action=edit
Bug 28316: screen unquoted semicolons and all followup colons

Currently searches like: "book:", ":book" and "host-item:test:n"
cause internal server errors.

This patch adds additional regexes that remove the colons at the start
and end of the query, and another regex that screens all follow-up
colons that go after the first colon to avoid errors when searching for
"host-item:test:n".

To reproduce:
1) using ES, search for the book with title that contains
semicolon at the start or at the end of the line, separated with spaces,
this should cause internal server error.
2) try doing the same with something like "host-item:test:n", it should
result in error as well.
3) apply the patch.
4) repeat steps 1-2, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:52:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:52:04 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-I1nqA4W9LP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #97 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124562&action=edit
Bug 28316: escape brackets in the search query

This patch screens square and curly brackets which have no special
language meaning.

To reproduce:
1) using ES, search for the book with title that contains
square and/or curly brackets, like "book [second edition]", which will
result in error.
2) apply the patch.
3) search for that book again, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:52:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:52:10 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-HwImSyPjzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #98 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124563&action=edit
Bug 28316: escape exclamation signs in the query

Currently having exclamation sign at the end of the query makes ES
search fail, and when you try to search for a book that has exclamation
sign in the tittle (something like "Words! words") won't show results
correctly as it tries to negate everything that is after exclamation
sign, making it impossible to search for books that have in in the title

This patch escapes exclamation signs if it's at the end of the query or
has a space after it, resolving both of the issues listed above.

To reproduce:
1) with ES enabled, search for the book with title that contains
exclamation sight at the end, like "book!", this search should result
 in error.
2) do another search, but this time find/prepare beforehand book with a
title that has exclamation sign with a space after it,
e.g "exclamation! sign", it shouldn't find it as ES treats everything
after that exclamation sign as negation.
2) apply the patch.
3) perform searches from the steep one and two again.
Search from step one should no longer fail, while search from the step
two should find that book.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:52:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:52:16 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-kSNE61hvuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #99 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124564&action=edit
Bug 28316: avoid messing up regexes in the search queries

This patch ensures that the behavior with
QueryRegexEscapeOptions set to values other than
"Escape" still will works as expected.

It does so by storing the contents of regexes
before escaping special characters and
then restores the contents of regexes back to how
it was before, ensuring that searching with regex is possible.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:52:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:52:22 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-k9KPeccFIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #100 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124565&action=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled

if QueryAutoTruncate enabled we will have any special operators ruined
for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]"
so no reason to keep ranges when QueryAutoTruncate set to "enabled"

1) enable QueryAutoTruncate at your sysprefs.
2) perform a search using range, for example: "[1999 TO 2020]",
it shouldn't work the way it's supposed to.
3) apply the patch.
4) perform the same search with range, ensure that it works correctly.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 15:52:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 13:52:29 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-HiJsJFl54h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #101 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 124566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124566&action=edit
Bug 28316: (QA follow-up) Make clean_search_term public

With all the work that's gone into improving the internal
_clean_search_term method I feel we should expose it publically as it's
going to be more widely helpful

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 16:04:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 14:04:39 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-Bxj5K46sux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #102 from Peter Vashchuk <stalkernoid at gmail.com> ---
(In reply to Jonathan Druart from comment #91)
> Questions and suggestions:
> 1. Could we use named capture in the regexs?
> 2. What means XI?
> 3. Why do we need the 'e' modifier in the second one?
> 4. Can we split on several lines the regexs to make them more readable?
> (/xms)

I implemented those changes and pushed the changed version of the patches,
please take a look :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 16:56:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 14:56:17 +0000
Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
In-Reply-To: <bug-25539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25539-70-RRqFankuHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

--- Comment #23 from David Gustafsson <glasklas at gmail.com> ---
Sorry about the late reply, I posted the commit in comment #20, not sure it
applies to the current Koha master, we regularly rebase our patch-set but have
not done so in a while. Even though I think it could be useful to have a look
at I hope to work more on cleaning this mess up, but not sure when will able to
do so. Some changes might be easier to break out than others.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 17:19:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 15:19:41 +0000
Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year
 limit in _fix_limit_special_cases
In-Reply-To: <bug-20492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20492-70-aFuwI0Ua2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from David Gustafsson <glasklas at gmail.com> ---
Thing this have now been fixed in
https://github.com/Koha-Community/Koha/commit/2293e6597c69d55ce5916b7a31029f13d65d4fea
so closing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 17:20:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 15:20:58 +0000
Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year
 limit in _fix_limit_special_cases
In-Reply-To: <bug-20492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20492-70-o3viqT53AI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |DUPLICATE

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---


*** This bug has been marked as a duplicate of bug 22524 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 17:20:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 15:20:58 +0000
Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced
 search
In-Reply-To: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22524-70-m8uOGpEKqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #33 from David Gustafsson <glasklas at gmail.com> ---
*** Bug 20492 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 17:27:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 15:27:48 +0000
Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials
 statistics wizard
In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28216-70-Q9ja9iBwdA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216

Hinet Romain <romain.hinet-debain at univ-amu.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |romain.hinet-debain at univ-am
                   |                            |u.fr

--- Comment #5 from Hinet Romain <romain.hinet-debain at univ-amu.fr> ---
I have a message "Error trace" when i click to "Serials statistics wizard"
https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 17:39:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 15:39:43 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-YKyWjUr0WH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #16 from skaman.tx at gmail.com ---
Mason's reply was the answer.  Instead of going through all the patching above,
merely running the following two sql queries on the library database allowed
the koha-common upgrade to complete without error.

ALTER TABLE `deleteditems` ROW_FORMAT=DYNAMIC;
ALTER TABLE `items` ROW_FORMAT=DYNAMIC;

Thank you, Mason!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep  6 18:31:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 16:31:30 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-NAl325alqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
We don't have a metric tonne, because we review and remove ours periodically,
but it would be brilliant to have lists be sortable on the OPAC.

It'd be even better if the staff client could control the default order (e.g.
date added, date desc).  

We don't have a preference over 1, 2, 3 or 4 - they're all workable solutions.  

2 might be nice for consistency; I think the Charges table uses DataTables on
the OPAC?  We can always target a DataTable with jQuery to set the default
sort.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 01:25:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 23:25:41 +0000
Subject: [Koha-bugs] [Bug 28956] New: Acquisitions: select correct default
 tax rate when receiving orders
Message-ID: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956

            Bug ID: 28956
           Summary: Acquisitions: select correct default tax rate when
                    receiving orders
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wainuiwitikapark at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

When there is more than one tax rate defined in system preferences, and a
vendor has a tax rate that is not 0%, then when you are receiving an order in a
basket for that vendor, the default tax rate should be the correct non 0 rate.
This should be seen in acqui/orderreceive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 01:27:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 23:27:46 +0000
Subject: [Koha-bugs] [Bug 28956] Acquisitions: select correct default tax
 rate when receiving orders
In-Reply-To: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28956-70-ffoEv4cx3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |wainuiwitikapark at catalyst.n
                   |ity.org                     |et.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 01:49:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 23:49:29 +0000
Subject: [Koha-bugs] [Bug 28956] Acquisitions: select correct default tax
 rate when receiving orders
In-Reply-To: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28956-70-NoKM5tI0zn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956

--- Comment #1 from wainuiwitikapark at catalyst.net.nz ---
Created attachment 124567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124567&action=edit
Bug 28956: correct default tax rate on orderreceive

When there is more than one tax rate defined in system preferences, and
a vendor has a tax rate that is not 0%, then when you are receiving an
order in a basket for that vendor, the default tax rate should be the
correct non 0 rate. This should be seen in acqui/orderreceive.

To test:
1) Go to staff client
2) Go to Koha administration
3) Search for "tax rate" in system preferences
4) Add 0|0.15 into the preference
5) Create a vendor
6) Set vendor tax rate to 15%
7) Add a new basket to vendor
8) Add to basket
9) Add any sample order to basket - add actual cost
10) Close basket
11) Receive shipment
12) Make invoice
13) Click on Receive in the table
14) Should be on orderreceive.pl page
15) Observe tax rate default is 0%
16) Apply patch
17) Refresh page
18) Observe tax rate default is 15%

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 01:49:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 06 Sep 2021 23:49:53 +0000
Subject: [Koha-bugs] [Bug 28956] Acquisitions: select correct default tax
 rate when receiving orders
In-Reply-To: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28956-70-4KM3QrEUag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 02:47:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 00:47:03 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-eN9c3mUTHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #155 from David Cook <dcook at prosentient.com.au> ---
We're interested in this one too. I might be able to take a look at this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:44:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:44:38 +0000
Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the
 translator tool
In-Reply-To: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28462-70-eqGVwoqZjj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462

--- Comment #25 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:46:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:46:08 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
 undefined value at C4/Reserves.pm line 607
In-Reply-To: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28644-70-wtT9U4QWMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644

--- Comment #9 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:46:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:46:58 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-xsZIw4bM81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

--- Comment #16 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:47:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:47:54 +0000
Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes
In-Reply-To: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28632-70-iG30CB36RJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632

--- Comment #18 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:48:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:48:20 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-GnQK0Q07VW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to wainuiwitikapark from comment #16)
> Should this be backported to 19.11.x for 19.11.22?

If it applies, backport it. It has no string changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:53:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:53:42 +0000
Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and
 biblioitemnumber in request.pl
In-Reply-To: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28057-70-fl1xerpZKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #26 from wainuiwitikapark at catalyst.net.nz ---
(In reply to Nick Clemens from comment #25)
> (In reply to wainuiwitikapark from comment #24)
> > Should this be backported to 19.11.x for 19.11.21?
> > 
> > Or if it contains string changes, backported to 19.11.22? As we are
> > currently in a string freeze.
> 
> Not urgent, so 22 is fine if it applies

Hi Nick,

Unfortunately there are conflicts when applying these patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:54:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:54:37 +0000
Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js
In-Reply-To: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28802-70-Vlu2zocieM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

--- Comment #13 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 03:56:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 01:56:13 +0000
Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in
 all pages of the OPAC
In-Reply-To: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26847-70-waUzSUjKU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

--- Comment #21 from wainuiwitikapark at catalyst.net.nz ---
Should this be backported to 19.11.x for 19.11.22?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 06:12:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 04:12:29 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-rUGkJGqxtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldoldstable      |Pushed to oldoldoldstable
         Version(s)|21.11.00,21.05.02,20.11.09, |21.11.00,21.05.02,20.11.09,
        released in|20.05.15                    |20.05.15,19.11.22

--- Comment #18 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 08:54:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 06:54:01 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-7PvS1HLrCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #156 from David Cook <dcook at prosentient.com.au> ---
The bug_8367-add_holds_pickup_period_circrule.perl script is not idempotent. It
shouldn't re-add the rule on subsequent runs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 08:54:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 06:54:08 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-bT4QkUnAQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #7 from Mohamad Barham <mbarham at birzeit.edu> ---
problem still exist

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 09:00:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 07:00:08 +0000
Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a from
 record to search form
In-Reply-To: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28812-70-KAHDaaGTYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #17 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x, will be in 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 09:13:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 07:13:51 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-aSPtohSdrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #157 from David Cook <dcook at prosentient.com.au> ---
Created attachment 124568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124568&action=edit
Bug 8367: Make database update idempotent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 09:23:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 07:23:47 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-5r8iecfbRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #158 from David Cook <dcook at prosentient.com.au> ---
I'm finding this test plan a bit difficult to follow.

What does "7) Revert the waiting status" mean?

--

Repeating Rhonda's mention that the pickup message doesn't change for "8)
Re-place the hold on the biblio on the OPAC. Notice that when you change the
pick up location, the number of days in the pickup message below the dropdown
changes based on the circ rules." 

Not seeing any relevant Javascript errors. I'll look into that next...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 09:27:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 07:27:55 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-buX5o0eTUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #159 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 118021
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021
Bug 8367: Add holds_pickup_period circulation rule

Review of attachment 118021:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8367&attachment=118021)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ +486,5 @@
>          $(radios).first().attr("checked", "checked");
>      }
>  
> +    function calculate_delay_days(){
> +        var selected_branch = $("#branch_1").val();

This #branch_1 is wrong, as the HTML is populated using "branch_[%
bibitemloo.biblionumber | html %]". The current code would only ever work for
biblio 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 09:40:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 07:40:20 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-Db5G9fUKsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #160 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 118021
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021
Bug 8367: Add holds_pickup_period circulation rule

Review of attachment 118021:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8367&attachment=118021)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ +272,5 @@
>                                          </ul>
>  
> +                                        [% IF pickup_delays %]
> +                                            <p id="pickup_delay" style="display:none;">When your item is ready for pickup, you will have <span id="pickup_delay_days"></span> days to pick it up from this library.</p>
> +                                        [% END %]

This doesn't display for any bibs but the first one if you have multiple bibs
to place holds on.

@@ +490,5 @@
> +        var selected_branch = $("#branch_1").val();
> +        [% FOREACH branchcode IN pickup_delays.keys %]
> +            var branchcode = "[% branchcode | html %]";
> +            if ( branchcode == selected_branch ) {
> +                $("#pickup_delay_days").text([% pickup_delays.$branchcode | html %]);

#pickup_delay_days can't work because it's not biblio-specific, so this will
break if you're placing holds on more than 1 bib at a time.

@@ +499,4 @@
>      $(document).ready(function() {
> +        calculate_delay_days();
> +        $("#pickup_delay").show();
> +        $("#branch_1").change(function(){

This has the same selector problem because it's hard-coded to biblionumber 1.

::: opac/opac-reserve.pl
@@ +694,5 @@
> +    });
> +    $hold_pickup_delay_by_branch{$branch->branchcode} = $rule->rule_value if ( $rule and $rule->rule_value );
> +}
> +
> +$template->param( pickup_delays => \%hold_pickup_delay_by_branch );

"pickup_delays" is a confusing name, and it looks like there's no consideration
of ReservesMaxPickUpDelay here, even though Hold.pm seems to take it into
consideration... which could lead to confusing displays.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 10:06:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 08:06:00 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-hIQBd4bK4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #161 from David Cook <dcook at prosentient.com.au> ---
I don't think this patch takes into account C4::Reserves::CancelExpiredReserves
which gets called by the cronjob
/usr/share/koha/bin/cronjobs/holds/cancel_expired_holds.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 11:03:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 09:03:55 +0000
Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes
In-Reply-To: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28632-70-BLXoATYoq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to wainuiwitikapark from comment #18)
> Should this be backported to 19.11.x for 19.11.22?

If it applies, yes please.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 11:33:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 09:33:15 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Sep6vHMelE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Are you suggesting a one-column table with a list of secrets or a ('secret',
'auth_type') that would contain ('my_secret_passphrase', 'totp') with a uniq on
auth_type?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 11:33:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 09:33:35 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-bGvZXXfTHC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #32)
> Hmmm, if that's the case I'm not sure I understand why there are tests for
> the search helper.. surely that will generally return multiple results?
> 
> I'm vaguely feeling like a single page web app would actually grab the full
> AV list when it first needs it and cache it locally to use for subsequent
> uses.. but as Koha isn't at that point yet we're unlikely to be able to
> really utilise that methodology..

If you need to render a list of (say) items, you will need to be able to make
the GET /items call return not only the 'damaged' attribute, but also a way to
return the linked AV, for rendering purposes.

The only thing that I'm not sure about this dev, is that (maybe) we want more
fine-grained control of what objects should have their AVs expanded. For
example, if we wanted the list of the items on a bib to display them grouped by
the library they were checked out (I know, rare example heh):

GET /biblio/123
x-koha-av-expand: true
x-koha-embed: items.checkouts

would mean we expand AVs for biblio, items, but also for the related checkouts
(a probably expensive thing, as we don't have relationships in place for
prefetching).

I would prefer a syntax that allows us to do:

GET /biblio/123
x-koha-embed: items+av,items.checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 11:40:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 09:40:11 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Br4kO7gGHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124569&action=edit
Example UI

I'm not sure the 'app' should be only one or not, I guess the answer is yes.
But  I like Github's page, and it points us towards this 'several 2FA methods'
thinking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:32:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:32:07 +0000
Subject: [Koha-bugs] [Bug 18637] Handle Free Text vendor notes on EDIFACT
 Quotes
In-Reply-To: <bug-18637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18637-70-t8LanVPge0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|NEW                         |RESOLVED

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 27793 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:32:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:32:07 +0000
Subject: [Koha-bugs] [Bug 27793] Store Contents of FTX segment of EDI quotes
 for inclusion in orders
In-Reply-To: <bug-27793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27793-70-LT89yIxoQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27793

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 18637 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:51:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:51:21 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-obGZoRk0aG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #33)
> (In reply to Martin Renvoize from comment #32)
> > Hmmm, if that's the case I'm not sure I understand why there are tests for
> > the search helper.. surely that will generally return multiple results?
> > 
> > I'm vaguely feeling like a single page web app would actually grab the full
> > AV list when it first needs it and cache it locally to use for subsequent
> > uses.. but as Koha isn't at that point yet we're unlikely to be able to
> > really utilise that methodology..
> 
> If you need to render a list of (say) items, you will need to be able to
> make the GET /items call return not only the 'damaged' attribute, but also a
> way to return the linked AV, for rendering purposes.
> 
> The only thing that I'm not sure about this dev, is that (maybe) we want
> more fine-grained control of what objects should have their AVs expanded.
> For example, if we wanted the list of the items on a bib to display them
> grouped by the library they were checked out (I know, rare example heh):
> 
> GET /biblio/123
> x-koha-av-expand: true
> x-koha-embed: items.checkouts
> 
> would mean we expand AVs for biblio, items, but also for the related
> checkouts (a probably expensive thing, as we don't have relationships in
> place for prefetching).
> 
> I would prefer a syntax that allows us to do:
> 
> GET /biblio/123
> x-koha-embed: items+av,items.checkouts

Where will this be documented? I think the biggest weakness with our API is a
derth of documentation for end users. We have some much great functionality
that most API users don't even know exists let alone how to use it! This is a
great example.

I'd really love to see at a minimum, this be documented on a wiki page. We
could start there, and perhaps build an API User's Handbook, or even just an
API User's Cookbook just like the SQL Reports and Javscript library pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:52:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:52:09 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-pORrFVGApc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
It would also be nice if it could be embedded in the self-documentation
somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:53:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:53:15 +0000
Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and
 biblioitemnumber in request.pl
In-Reply-To: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28057-70-YI8G7egifp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #27 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to wainuiwitikapark from comment #26)
> (In reply to Nick Clemens from comment #25)
> > (In reply to wainuiwitikapark from comment #24)
> > > Should this be backported to 19.11.x for 19.11.21?
> > > 
> > > Or if it contains string changes, backported to 19.11.22? As we are
> > > currently in a string freeze.
> > 
> > Not urgent, so 22 is fine if it applies
> 
> Hi Nick,
> 
> Unfortunately there are conflicts when applying these patches

It looks like this is not in 19.11 and can be skipped

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:53:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:53:32 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-FWSJE1pdyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:53:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:53:35 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-kgnHHMN0tH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124570&action=edit
Bug 28949: Use Flatpickr on reports pages

This patch replaces the use of jQueryUI's datepicker on reports pages.

To test, apply the patch and test the following reports pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Acquisitions statistic wizard: Linked pairs of fields for
  "placed on" and "received on."
- Patrons with the most checkouts: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Patrons who haven't checked out: "Not checked out since"
  field.
- Cash register statistics wizard: Linked "From" and "To"
  fields.
- Most-circulated items: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Catalog statistics wizard: Linked pairs of fields for "Date acquired
  (item)" and "Date deleted (item)" The latter is shown by checking the
  "Count deleted items" radio button.
- View dictionary -> New definition:
  - Enter a definition name
  - Select table Circulation
  - Choose a date column, e.g. "Date of birth" or "Registration date"
  - Select "Date range"
    - Test that the "Start of date range" and "End of date range" fields
      are linked correctly.
- Create guided report:
  - Module: catalog
  - Type: Tabular
  - Select columns (any)
  - Select criteria to limit on: There should be three pairs of linked
    fields, "Creation date," "Modification date," and "Due date."
  - Confirm that the report is saved correctly with the dates you chose.
- Create from SQL -> Test a report with one or more date
  fields, e.g.
https://wiki.koha-community.org/wiki/SQL_Reports_Library#Items_added_by_Collection
- Average loan time: Linke pairs of fields for "Checkout
  date" and "Returns."
- Reports -> Circulation statistics wizard: Linked "Period" fields.
- Reports -> Holds statistics wizard: Linked pairs of fields "Hold
  date," "Notification date," "Reminder date," "Waiting date," and
  "Cancellation date."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:57:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:57:30 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-R7aZqIePjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28958


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958
[Bug 28958] Use Flatpickr on serials pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:57:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:57:30 +0000
Subject: [Koha-bugs] [Bug 28958] New: Use Flatpickr on serials pages
Message-ID: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

            Bug ID: 28958
           Summary: Use Flatpickr on serials pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28937, 28376

This bug will cover Flatpickr additions to these pages/files:

* serials/checkexpiration.tt
* serials/claims.tt
* serials/serials-edit.tt
* serials/serials-search.tt
* serials/subscription-add.tt
* serials/subscription-batchedit.tt
* serials/subscription-history.tt
* serials/subscription-numberpatterns.tt
* serials/subscription-renew.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:57:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:57:30 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-Qqao2YcxZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28958


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958
[Bug 28958] Use Flatpickr on serials pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 12:59:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 10:59:36 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
 undefined value at C4/Reserves.pm line 607
In-Reply-To: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28644-70-MzYKDQYhHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124571&action=edit
Bug 28644: [19.11.x] Fix calling borrowernumber on undefined value

If the hold is not found (e.g. already cancelled), we should
return earlier without crashing:
    Can't call method "borrowernumber" on an undefined value at
/usr/share/koha/C4/Reserves.pm line 521
    (Note: line number from 19.11)

Test plan:
Run t/db_dependent/Reserves.t
Add a hold, go to user menu with holds in OPAC.
At the same time, cancel this hold from staff.
Now click the Cancel in OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:00:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:00:06 +0000
Subject: [Koha-bugs] [Bug 28959] New: virtualshelves.category is really a
 boolean
Message-ID: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

            Bug ID: 28959
           Summary: virtualshelves.category is really a boolean
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Somehow it got more complicated than required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:09:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:09:56 +0000
Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache
In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28955-70-xyqEl33Pt6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|We need a way to set        |Add option to set default
                   |default branch from apache  |branch from Apache
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:12:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:12:40 +0000
Subject: [Koha-bugs] [Bug 28960] New: EDI transfer_items uses a relationship
 where it's looking for a field
Message-ID: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

            Bug ID: 28960
           Summary: EDI transfer_items uses a relationship where it's
                    looking for a field
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

In Koha::EDI::transfer_items we do a branchcode comparison. Unfortunately, the
comparison is called against a DBIx::Class relationship accessor instead of
explicitly calling get_column to get the corresponding field value instead of a
full fledged DBIx::Class::Result object.

This can cause issues in proceedings.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:15:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:15:31 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-g9k2NyZTnC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124572&action=edit
Bug 28960: Explicitly call get_column

This patch adds get_column to ensure we are returning a string value of
a field rather than accidentally triggering a relationship accessor.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:16:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:16:55 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-lkIaCsJej7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:17:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:17:00 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-8vGOK0rjIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:29:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:29:31 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-sunmD0bzI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:32:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:32:16 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-vmus2wUozW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:32:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:32:22 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-mFz646AygH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:32:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:32:27 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-LNZ1b8ceu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 13:44:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 11:44:31 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-Vu17ED1gtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #3)
> Hm, we already have PatronSelfRegistrationExpireTemporaryAccountsDelay for
> the number of days.
> 
> It seems like a double up to introduce an additional pref to secure another
> one. Maybe we need to make sure that this one can also be used to deactivate?

my $delay =
C4::Context->preference('PatronSelfRegistrationExpireTemporaryAccountsDelay');

return 0 if not $category_code or not defined $delay or $delay eq q||;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:00:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:00:27 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-laWKYfBbtx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:00:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:00:30 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-tNT4zaWAAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124573&action=edit
Bug 28845: (follow-up) Retain selection when using advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:02:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:02:04 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-P8Hi29aqGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123835|0                           |1
        is obsolete|                            |

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124574&action=edit
Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules

This patch removes the code from the search scripts into QueryBuilder
modules.

To test:
1 - Have a library group defined as a search group for both staff and opac
2 - Search on staff client and opac with that group limit and a single branch
limit
3 - Note your results/counts
4 - Note the visuals of the search description
5 - Apply patch
6 - Repeat searches
7 - All should work as before

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:02:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:02:08 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-4PKXcJddHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123836|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124575&action=edit
Bug 28847: Unit tests

Note: tests are very similar between ES and Zebra, however, ES requires the
uppercase
OR and doesn't use '=' in the same way. I feel having test coverage in each
module is fair and more future
proof in case of changes to search engine

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:02:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:02:11 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-oviB95jtrh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123837|0                           |1
        is obsolete|                            |

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124576&action=edit
Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT

The opac had 'branch_group_limit' parameters which can be simplified to more
closely match intranet code.

Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate

Expand JS to prevent selection of single and multibranch limits

To test:
1 - Enable OpacAddMastheadLibraryPulldown system preference
2 - Ensure branches and groups show as before patch
3 - Ensure single and multibranch limits from masthead apply as expected
4 - Test advanced search page, ensure you cannot select both single and
multibranch limit
5 - Follow test plan on 28845 - ensure multibranch limit still correctly
pre-selected

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:02:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:02:14 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-bf4YWC6ncf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123841|0                           |1
        is obsolete|                            |

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124577&action=edit
Bug 28847: Only apply JS to branch/multibranch selection if there are search
groups

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:02:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:02:40 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-KzoYe3Gi7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Joonas Kylmälä from comment #3)
> This patch breaks the group selection in OPAC advanced search, i.e. with
> this patch applied if you go to the URL
> 
> http://localhost:8080/cgi-bin/koha/opac-search.
> pl?advsearch=1&weight_search=1&multibranchlimit=1&sort_by=relevance&do=Search
> 
> 
> then the group doesn't get selected in the search menu.

Updated, stole a change from 28847 :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:36:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:36:41 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-XEm3eZdCzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 14:36:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 12:36:45 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-2UoyCYH6kB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124572|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124578&action=edit
Bug 28960: Explicitly call get_column

This patch adds get_column to ensure we are returning a string value of
a field rather than accidentally triggering a relationship accessor.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:04:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:04:46 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-LHRY471kkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:04:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:04:51 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-LemNxk5mcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |tomascohen at gmail.com
                   |.com                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:04:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:04:55 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-R5J2YQKxSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:04:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:04:58 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-wPYZ250w5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124579&action=edit
Bug 28943: Lower the risk of accidental patron deletion

If you do not use a temporary self registration patron category,
you should actually make the preference
PatronSelfRegistrationExpireTemporaryAccountsDelay empty.

This patch adds a comment in the subroutine that does the deletion
to not remove the test on empty delay.
It also adds a test in Members.t for the same reason.

It corrects the wrong explanation and default value in the
sysprefs.sql file.

Also it adds further explanation to both related sysprefs.

Test plan:
Run t/db_dependent/Members.
Check in Administration the two adjusted OPAC pref descriptions.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:05:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:05:04 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-IzQrxaCnRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:05:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:05:55 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-zdvlIcF6nW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:07:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:07:33 +0000
Subject: [Koha-bugs] [Bug 28943] cleanup_database: Can we make
 del-exp-selfreg less disastrous ?
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-DcNbF0yT3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124579|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124580&action=edit
Bug 28943: Lower the risk of accidental patron deletion

If you do not use a temporary self registration patron category,
you should actually make the preference
PatronSelfRegistrationExpireTemporaryAccountsDelay empty.

This patch adds a comment in the subroutine that does the deletion
to not remove the test on empty delay.
It also adds a test in Members.t for the same reason.

It corrects the wrong explanation and default value in the
sysprefs.sql file.

Also it adds further explanation to both related sysprefs.

Test plan:
Run t/db_dependent/Members.t
Check in Administration the two adjusted OPAC pref descriptions.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:08:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:08:03 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-HEzVDSJeGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jon.turner at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:08:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:08:21 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-exGivHmvyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|cleanup_database: Can we    |The del-exp-selfreg flag in
                   |make del-exp-selfreg less   |cleanup_database can be
                   |disastrous ?                |really disastrous

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:12:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:12:45 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-8yNrAGuN5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
NOTE: I have intentionally set the importance to Normal since I do not only
consider this as an enhancement.
See the other bug. It refers to a case where accidentally patrons were deleted.

Note that correcting the default of the syspref here may prevent accidents in
new libraries. And the adjusted pref descriptions may help too.

Could we do more? Probably, but not per se on this report. I was thinking about
some limit to be used in the delete sub to not inadvertently remove a large
number of patrons. If you agree, you are invited to open up a new report and
add me in CC ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:16:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:16:25 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-3Lat6Ut6X0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:16:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:16:29 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-VOpzW37w7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121462|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124581&action=edit
Bug 28412: Add information about supported authentication methods

This patch adds an initial text explaining the valid authentication
mechanisms Koha has for the API.

My first approach included information about the controlling sysprefs,
but I decided to remove it, as it is not usual for API consumers to be
presented such detailed internal information which is probably
confusing. We could add a link to the manual, but that's not the point I
think.

I've added an entry about error messages and how we thougth about them.
It is copied from Docker Engine's API docs.

This is my 2 cents.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:18:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:18:32 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-VmQ6CcEBxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
For discussion: Do we need a preference that indicates that a library uses a
temporary patron category for self registration or not?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:20:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:20:35 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-BLDUfN5AcK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #8)
> For discussion: Do we need a preference that indicates that a library uses a
> temporary patron category for self registration or not?

Or should that be a flag on patron categories ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:25:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:25:02 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-rE6qQnflF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |If you use self
      release notes|                            |registration but you do not
                   |                            |use a temporary self
                   |                            |registration patron
                   |                            |category,
                   |                            |you should
                   |                            |actually make the
                   |                            |preference
                   |                            |PatronSelfRegistrationExpir
                   |                            |eTemporaryAccountsDelay
                   |                            |EMPTY (and do not set it to
                   |                            |zero).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:33:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:33:19 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-tFAFKgQttS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
root at kohadevbox:koha(bug28948-qa)$ prove t/db_dependent/Koha/Objects.t
t/db_dependent/Koha/Objects.t .. 18/24
    #   Failed test at t/db_dependent/Koha/Objects.t line 1214.

    #   Failed test at t/db_dependent/Koha/Objects.t line 1226.
    # Looks like you failed 2 tests of 13.
t/db_dependent/Koha/Objects.t .. 20/24
#   Failed test 'filter_by_last_update'
#   at t/db_dependent/Koha/Objects.t line 1234.
# Looks like you failed 1 test of 24.
t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/24 subtests

Test Summary Report
-------------------
t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 24 Failed: 1)
  Failed test:  20
  Non-zero exit status: 1
Files=1, Tests=24, 17 wallclock secs ( 0.05 usr  0.01 sys + 12.17 cusr  2.62
csys = 14.85 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:33:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:33:30 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-hOwu8OtDSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:36:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:36:16 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-AKJBKa5E1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:36:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:36:19 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-3FyzbFiVOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124582&action=edit
Bug 28958: Use Flatpickr on serials pages

This patch replaces the use of jQueryUI's datepicker on serials pages.

To test, apply the patch and test the following serials pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Claims -> Choose vendor -> Filter missing issues (linked "from" and
  "to" fields).
- Check expiration -> "Expiring before" field.
- Manage numbering patterns -> New numbering pattern -> "First issue
  publication date" field.
- Serials advanced search -> "Expires before" field.
- Subscription search results -> Check multiple checkboxes -> Edit
  selected serials: "Expiration date" field.
- Subscription details -> Serial collection -> Edit serials ->
  "Published on" and "Expected on" fields.
- Subscription details -> Renew -> "Start date" field in the popup
  window.
- Subscription details -> Edit subscription -> Page 2 -> "First issue
  publication date," "Subscription start date," and "Subscription end
  date" fields.
- Locate a subscription with manual history enabled. From the
  subscription detail page, click the "Planning" tab, then "Edit
  history" -> Linked fields "Subscription start date" and "Subscription
  end date."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:38:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:38:52 +0000
Subject: [Koha-bugs] [Bug 28961] New: Use Flatpickr on tools pages
Message-ID: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

            Bug ID: 28961
           Summary: Use Flatpickr on tools pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28937, 28376

This bug will cover Flatpickr additions to these pages/files:

* tools/additional-contents.tt
* tools/batch_extend_due_dates.tt
* tools/cleanborrowers.tt
* tools/export.tt
* tools/holidays.tt
* tools/import_borrowers.tt
* tools/inventory.tt
* tools/modborrowers.tt
* tools/scheduler.tt
* tools/viewlog.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:38:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:38:52 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-2vSXzYp6vN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28961


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961
[Bug 28961] Use Flatpickr on tools pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:38:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:38:52 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-x9V1t1YCXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28961


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961
[Bug 28961] Use Flatpickr on tools pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 15:59:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 13:59:01 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-bffSkysNYb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:08:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:08:38 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-dbI55E1nTs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124331|0                           |1
        is obsolete|                            |

--- Comment #424 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124583&action=edit
Bug 24857: Update Database

We have a partner that needs Volume Level Holds.
This is a feature that some ILSs have that allows the creation of volumes at
the bibliographic level,
with items being optionally assigned to a given volume. This facilitates the
ability to place holds
at a volume level, rather than on a specific item or any available item on a
record.

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableVolumes
5) Browse to detail.pl for a record with items
6) Note the new volumes tab
7) Test creating, editing and deleting volumes
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting a volume for items,
   and for clearing a volume for items.
9) Test adding and clearing the volume set for items

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:08:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:08:45 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-9SUneqhzEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124332|0                           |1
        is obsolete|                            |

--- Comment #425 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124584&action=edit
Bug 24857: Add new Schema files

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:08:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:08:52 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-6l8aYOy9DS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124333|0                           |1
        is obsolete|                            |

--- Comment #426 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124585&action=edit
Bug 24857: Add Koha Object(s)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:00 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Zp6y9BaIAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124334|0                           |1
        is obsolete|                            |

--- Comment #427 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124586&action=edit
Bug 24857: Add Object Methods

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:07 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-bJSYqLdnmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124335|0                           |1
        is obsolete|                            |

--- Comment #428 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124587&action=edit
Bug 24857: API spec

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:16 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-W0fveLPi9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124336|0                           |1
        is obsolete|                            |

--- Comment #429 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124588&action=edit
Bug 24857: Koha::Biblio::Volume methods

This patch introduces the following methods:
- add_item
- del_item
- items
- to_api_mapping
- store (overloaded)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-GX92UXhqKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124337|0                           |1
        is obsolete|                            |

--- Comment #430 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124589&action=edit
Bug 24857: Implement volume related controllers

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:32 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-QnrJxKMumD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124338|0                           |1
        is obsolete|                            |

--- Comment #431 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124590&action=edit
Bug 24857: Add volume management to detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:40 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-H2rPJmEyrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124339|0                           |1
        is obsolete|                            |

--- Comment #432 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124591&action=edit
Bug 24857: Add ability to attach newly cataloged items to a volume

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:49 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-kweysekPwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124340|0                           |1
        is obsolete|                            |

--- Comment #433 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124592&action=edit
Bug 24857: Add ability to manage item's volumes from detail.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:09:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:09:56 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-f0h25C0fnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124341|0                           |1
        is obsolete|                            |

--- Comment #434 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124593&action=edit
Bug 24857: Delete a volume when the last item on that volume is deleted

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Z71I7cOMY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124342|0                           |1
        is obsolete|                            |

--- Comment #435 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124594&action=edit
Bug 24857: Copy the volume to the item's enumchron

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-aTikE3uQwL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124343|0                           |1
        is obsolete|                            |

--- Comment #436 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124595&action=edit
Bug 24857: Add user permission for volumes management

Signed-off-by: Rebecca  Coert <rcoert at arlingtonva.us>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:20 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-4ofxUHO6To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124344|0                           |1
        is obsolete|                            |

--- Comment #437 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124596&action=edit
Bug 24857: Fix license statements

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:28 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-dLrKXfS2OV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124345|0                           |1
        is obsolete|                            |

--- Comment #438 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124597&action=edit
Bug 24857: Fix POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:35 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-2ylVjM9a1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124346|0                           |1
        is obsolete|                            |

--- Comment #439 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124598&action=edit
Bug 24857: Add missing filter and move js to footer on additem.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:42 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Gy8jSQTk5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124347|0                           |1
        is obsolete|                            |

--- Comment #440 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124599&action=edit
Bug 24857: Fix simple-quote string

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:50 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-J0ZjfJVg0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124348|0                           |1
        is obsolete|                            |

--- Comment #441 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124600&action=edit
Bug 24857: Remove doubled 'use Koha::Biblio::Volumes'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:10:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:10:58 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-rtidBFTyWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124349|0                           |1
        is obsolete|                            |

--- Comment #442 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124601&action=edit
Bug 24857: Fix sorting of new syspref

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:08 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-DkfAu8feCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124351|0                           |1
        is obsolete|                            |

--- Comment #443 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124602&action=edit
Bug 24857: Change button text from "Create new" to "New volume"

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:17 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-3PjvjiDt30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124352|0                           |1
        is obsolete|                            |

--- Comment #444 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124603&action=edit
Bug 24857: (QA follow-up) Add volume to table settings

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:24 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-i8R6LaWwIZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124353|0                           |1
        is obsolete|                            |

--- Comment #445 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124604&action=edit
Bug 24857: (QA follow-up) Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:32 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-XBvfrqeeZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124354|0                           |1
        is obsolete|                            |

--- Comment #446 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124605&action=edit
Bug 24857: (QA follow-up) Fix unit tests and code for changes in
Koha::Item::delete

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:40 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-EyFfZjzols@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124355|0                           |1
        is obsolete|                            |

--- Comment #447 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124606&action=edit
Bug 24857: (QA follow-up) Fix QA script issues

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:47 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-t4F1lCvdum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124356|0                           |1
        is obsolete|                            |

--- Comment #448 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124607&action=edit
Bug 24857: (follow-up) Use $c->unhandled_exception

This patch makes the controller up to date with the currently used style
and codebase.

It also sinlences a useless warning, and makes it return 404 (instead of
409) when trying to add items to a volume on a non-existing biblio.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Some warnings
2. Apply this patch
3. Repeat 1
=> SUCCESS: No errors, no warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:11:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:11:55 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-61ci0RDsDD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124357|0                           |1
        is obsolete|                            |

--- Comment #449 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124608&action=edit
Bug 24857: Use $c->objects->find

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:02 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-nFsSZP6Doh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124358|0                           |1
        is obsolete|                            |

--- Comment #450 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124609&action=edit
Bug 24857: Fix permissions in spec

This patch corrects the spec so it requires the right permissions.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:09 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-L0nufPZz7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124359|0                           |1
        is obsolete|                            |

--- Comment #451 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124610&action=edit
Bug 24857: (QA follow-up) Adding items should check volume linked to biblio

I noticed some tests included /biblios/{biblio_id}/volumes... in the
URL. And they passed :-D This means the biblio_id is never tested.

This patch fixes those two tests so they have valid biblio_id in the
path, and adds a proper regression test for the expected behavior (409).

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/volumes.t
=> FAIL: Notice the tests pass, even with bad data on the request
2. Apply this patch, notice a test is added for the bad biblio_id case
   and the other two tests are fixed so they have the intended
   biblio_id.
3. Repeat 1
=> SUCCESS: Tests pass! This means things are correctly tested in the
   controller and the unit tests cover teh 'bad case' returning 409.
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:16 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-wqbGSFgwAk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124360|0                           |1
        is obsolete|                            |

--- Comment #452 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124611&action=edit
Bug 24857: (QA follow-up) Further spec fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:24 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-s2u7T5uzvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124361|0                           |1
        is obsolete|                            |

--- Comment #453 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124612&action=edit
Bug 24857: Rename Volumes => Item groups (DB)

This patch renames Volumes => Item groups in the DB structure, and also
on permissions and sysprefs.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:31 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-bT8mLi5fl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124362|0                           |1
        is obsolete|                            |

--- Comment #454 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124613&action=edit
Bug 24857: Adapt code to the volumes => item_groups change

This patch updates the code so all references to 'volumes' are
translated into 'item groups'.

Relevant changes:
- API routes and specs
- Permission name is changed
- Syspref name changed

Note: I removed a behavior that felt unnatural (at least in the place it
was put): deleting the item group if the linked item is deleted. It
feels like a controller thing, and also something that could be offered
to the staff on the UI on item deletion. To avoid blocking the feature,
I suggest this removal, and discuss it in its own context.

To test:
1. Run:
   $ reset_all
2. Apply this patchset
3. Run:
   $ updatedatabase
=> SUCCESS: Update works
4. Repeat 1 (with the patches applied)
=> SUCCESS: Install works with this DB structure
5. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
6. Follow the original plan (with the Volume=>ItemGRoup change in mind)
=> SUCCESS: All good!
7. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:40 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-EYaZIqtz4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124363|0                           |1
        is obsolete|                            |

--- Comment #455 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124614&action=edit
Bug 24857: item_group_items.item_id must be unique

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:12:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:12:48 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-BazrzAnsrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124463|0                           |1
        is obsolete|                            |

--- Comment #456 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124615&action=edit
Bug 24857: Do not depend on bug 28883

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:18:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:18:21 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-UE8Jc7vnnq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #457 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That was quite a QA effort.. all works as expected, though I'm sure some future
polishing of the UI is likely to take place down the line.

Tests pass, QA script is happy and functionality works

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:21:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:21:12 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Iu47eI85E2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124498|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124616&action=edit
Bug 28854: Add ability to create and circulate item bundles

This patch adds the ability to attach item bundles to biblio records. Item
bundles can then be circulated as with normal items.

Upon attaching an item to one of these item bundles, the item is automatically
marked as not for loan at it's original host biblio record.

When returning a bundle, the list of items that are part of this bundle
will be displayed, and a verification form is exposed requireing the
librarian to scan item barcodes to verify their presence. Should a bundle
be found to have items missing they will be marked as lost.

Bundles can also be used in the inventory tool as a filter.

Test plan:
0.  Apply the patch, run updatedatabase + update_dbix_class_files
1.  Create a new bundle record.
1a. Create a biblio record with leader position 7 set to 'c' for collection.
1b. Create an item for this biblio record.
1c. You should now see a new 'Bundle' button next to the item in the holdings
    table.
    Test: Verify that this 'Bundle' button only appears for biblio's where
leader
    position 7 is not 'c' for collection
1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items
    to the bundle.
    Test: Enter a non-existant barcode, submit and confirm you recieve an error
message.
    Test: Enter an existing barcode, submit and note the success message.
    Test: Enter the same barcode as above, submit and note the warning message.
    Test: Add a second item to the bib and try bundling one of the above
    items into this second item, note the error message.
2.  Open a new tab and look at the holdings data for one of the items you
attached
    to a bundle in step 1.
    Test: Verify that the holdings status displays 'Not for loan'.
    Test: Verify that the holdings status show which bundle the item has been
    attached to.
3.  Perform a checkout on the first bundle item.
    Test: Checkout should proceed as normal, obeying the circulation
    rules for the item type you chose to convert into a bundle.
4.  Perform a checkin on the first bundle item.
    Test: You should be presented with a modal that contains a list of items
    contained in the bundle and a test box for entering item barcodes.
    Test: Enter some of the barcodes for items in the bundle into the box and
submit.
    The bundle item should have been marked as returned, you should also
    have been notified of missing items and have the ability to print an
    updated contents list.
    Test: Verify that the items you did not enter barcodes for are now
    marked as lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:23:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:23:04 +0000
Subject: [Koha-bugs] [Bug 28962] New: Make deleting unverified self
 registrations standard (see del-unv-selfreg /
 DeleteUnverifiedOpacRegistrations)
Message-ID: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

            Bug ID: 28962
           Summary: Make deleting unverified self registrations standard
                    (see del-unv-selfreg /
                    DeleteUnverifiedOpacRegistrations)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The flag del-unv-selfreg could be inserted into the standard set of the cleanup
database cron job.

The verification mail tells us:
If you did not initiate this request, you may safely ignore this one-time
message. The request will expire shortly.

This actually is not true. But we could make it a bit more true when deleting
them by default within say 14 days? Of course this could always become a
syspref one day :)

Note that running this sub when you do not use self registration does not hurt.
It only selects the records without a borrowernumber.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:25:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:25:42 +0000
Subject: [Koha-bugs] [Bug 28943] The del-exp-selfreg flag in
 cleanup_database can be really disastrous
In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28943-70-nRm1FKK4d1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
"A zero will remove all patrons; but if you make the pref EMPTY, it will not
delete any patron."

This sentence needs to be reworked for specificity and to keep the style
consistent with other similar sysprefs. I'd recommend:

"Leave this field empty if you don't want to activate this feature. A zero in
this system preference will delete all patrons in the associated category."

I'd be inclined not to add new wording to PatronSelfRegistrationDefaultCategory
as well, that seems a little redundant. If you maintain a new message there, it
should also be updated to not use all caps for "UNLESS" and "EMPTY."

CCing Katrin on this for wording and style guidance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:35:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:35:26 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-xSWCiQrYB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Ha, the advertized

--del-unv-selfreg  DAYS  Delete unverified self registrations older than DAYS

does not even work !
The cmdline value is silently ignored.
Will fix that too now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:40:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:40:05 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-ovbBdwZvvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:40:08 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-3NadE1aZ39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124617&action=edit
Bug 28962: Add del-unv-selfreg to crontab

We also add a test by inserting a simulated borrower modification
record in the same table which should not be deleted.

NOTE: This patch fixes the del-unv-selfreg parameter in the
cleanup db script. It did not even do what it promised :)

Test plan:
Verify if the crontab change is correct.
Run t/db_dependent/Members.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:40:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:40:24 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-ldKJt924ZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:42:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:42:12 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-ken88Sjt7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This report makes the
      release notes|                            |del-unv-selfreg flag of the
                   |                            |cleanup_database script
                   |                            |part of the standard
                   |                            |crontab of Koha.
                   |                            |
                   |                            |It
                   |                            |defaults to 14 days.
                   |                            |
                   |                            |Note:
                   |                            |If you do not use self
                   |                            |registration with
                   |                            |verification mail, this
                   |                            |does not affect you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 16:43:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 14:43:24 +0000
Subject: [Koha-bugs] [Bug 28962] Make deleting unverified self registrations
 standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28962-70-gOeQS7J5wr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I have intentionally kept the BUG flag instead of ENH since this fixes a tiny
but very sloppy bug in the cleanup_database parameter setting of this flag.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:12:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:12:45 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-kT3e9dIP4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:12:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:12:49 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-fVMOJ6frv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124618&action=edit
Bug 28961: Use Flatpickr on tools pages

This patch replaces the use of jQueryUI's datepicker on tools pages.

To test, apply the patch and test the following tools pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

 - News -> New entry: Linked fields "Published date" and "Expiration
   date".
 - Batch extend due dates: Linked fields "Due date from" and  "Due date
   to"; "Hard due date" field.
 - Batch patron deletion: "who have not borrowed since," "whose
   expiration date is before," and "Permanently delete checkout history
   older than."
 - Export: Linked "Start date" and "End date" fields.
 - Import patrons -> Enter default values: "Date of birth,"
   "Registration date," and "Expiry date."
 - Inventory: "Set inventory date to."
 - Batch patron modification -> Submit a batch of cardnumbers or a
   patron list: "Registration date," "Expiry date," and "Restriction
   expiration."
 - Task scheduler: "Date" field.
 - Log viewer: "Display from" and "Display to" linked fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:23:22 +0000
Subject: [Koha-bugs] [Bug 28963] New: Use Flatpickr on calendar page
Message-ID: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

            Bug ID: 28963
           Summary: Use Flatpickr on calendar page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28937, 28376

This bug will replace the use of jQueryUI's datepicker widget on the Calendar
page under Tools.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:23:22 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-qityEDH3a9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963
[Bug 28963] Use Flatpickr on calendar page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:23:22 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-Exfze386RG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963
[Bug 28963] Use Flatpickr on calendar page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:23:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:23:58 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-UmclEblEMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:24:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:24:02 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-XFpkigM7kr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124619&action=edit
Bug 28959: Move category => public

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:24:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:24:06 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-zrhfCpGS0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124620&action=edit
Bug 28959: DBIC update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:24:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:24:10 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-jD4jcCHGQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124621&action=edit
Bug 28959: Add virtualshelves.public as a boolean

This patchset moves the 'category' attribute for virtual shelves, that
takes values of 1 and 2 (private and public respectively) into a boolean
for public.

The DBRev is trivial, and the changes to the code are as well.

To test:
1. have some known public and private lists
2. Apply this patches
3. Run:
   $ updatedatabase
=> SUCCESS: Public lists have public=1, private have public=0
4. Run:
   $ kshell
  k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Try the feature in staff and OPAC
=> SUCCESS: All good
6. Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 17:55:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 15:55:16 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-YppkIyMvH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:14:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:14:11 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-1z4C4wROqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Sally from comment #6)
> 2 might be nice for consistency; I think the Charges table uses DataTables
> on the OPAC?  We can always target a DataTable with jQuery to set the
> default sort.

Truth is, 4 implies 2. i.e. implement using DataTables, but against the API
instead of a custom script in svc.

Let's do it :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:14:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:14:37 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-kLdjbTziMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28959


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959
[Bug 28959] virtualshelves.category is really a boolean
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:14:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:14:37 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-7Bf7EstIbr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18148


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148
[Bug 18148] Make list of lists in OPAC sortable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:17:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:17:10 +0000
Subject: [Koha-bugs] [Bug 28964] New: request.pl slow to load when there are
 many holds on a record
Message-ID: <bug-28964-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28964

            Bug ID: 28964
           Summary: request.pl slow to load when there are many holds on a
                    record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In a large consortium popular titles have many holds  - a record with 700 holds
takes about 24 seconds to load

When trying to place a hold we shouldn't have to wait for all holds to load.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:22 +0000
Subject: [Koha-bugs] [Bug 28965] New: Add public routes for lists
Message-ID: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

            Bug ID: 28965
           Summary: Add public routes for lists
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:38 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-tfvQNosHPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28959                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959
[Bug 28959] virtualshelves.category is really a boolean
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:38 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-aZkTEC8aml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|18148                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148
[Bug 18148] Make list of lists in OPAC sortable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:42 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-Mpt7HZo2Gu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18148
         Depends on|                            |28959


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148
[Bug 18148] Make list of lists in OPAC sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959
[Bug 28959] virtualshelves.category is really a boolean
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:42 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-VxxApzx0Nu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965
[Bug 28965] Add public routes for lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:42 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-gMJ3ZkXJot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965
[Bug 28965] Add public routes for lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:23:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:23:49 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-P3R3SNL8rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:39:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:39:41 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-6VuCXP2G5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124619|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124622&action=edit
Bug 28959: Move category => public

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:39:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:39:46 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-g1OOSEwwUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124620|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124623&action=edit
Bug 28959: DBIC update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:39:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:39:52 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-b0LOr3Hf3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124621|0                           |1
        is obsolete|                            |

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124624&action=edit
Bug 28959: Add virtualshelves.public as a boolean

This patchset moves the 'category' attribute for virtual shelves, that
takes values of 1 and 2 (private and public respectively) into a boolean
for public.

The DBRev is trivial, and the changes to the code are as well.

To test:
1. have some known public and private lists
2. Apply this patches
3. Run:
   $ updatedatabase
=> SUCCESS: Public lists have public=1, private have public=0
4. Run:
   $ kshell
  k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Try the feature in staff and OPAC
=> SUCCESS: All good
6. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:39:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:39:58 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-M6Hjk9Dmqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124625&action=edit
WIP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:40:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:40:37 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-sF44zoeiMy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124625|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:54:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:54:50 +0000
Subject: [Koha-bugs] [Bug 28966] New: Holds queue viewer too slow to load
 for large numbers of holds
Message-ID: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

            Bug ID: 28966
           Summary: Holds queue viewer too slow to load for large numbers
                    of holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:57:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:57:57 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-Z7AQBvpuOs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 18:58:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 16:58:01 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-NWMzCB9I4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124626&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 19:24:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 17:24:54 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-qRAhsFcQLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124626|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124627&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 19:47:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 17:47:14 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-DrTSkZGmWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124627|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124628&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 20:08:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 18:08:24 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-85OHgK1nY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124628|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124629&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 20:12:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 18:12:13 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-SChqROFn8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 20:12:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 18:12:16 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-5ulN8sahL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124428|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124630&action=edit
Bug 28937: Use Flatpickr on circulation and patron pages

This patch replaces the use of jQueryUI's datepicker on circulation and
patron-related pages.

The patch modifies Flatpickr's default configuration (in calendar.inc)
so that it has the following features:

 - A Flatpickr input with a "futuredate" class will require that the
   selected date be after today.
 - The Flatpickr input field will be wrapped in a container to
   facilitate better CSS styling.
 - Generic handling of paired date fields is enabled using
   ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the
   same feature we have for jQueryUI datepickers using ".datepickerfrom"
   and ".datepickerto".

This patch also removes an unused function which was repeated in three
templates: validate1.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check out to a patron.
  - Open the Restrictions tab and click "Add manual restriction."
    - In the "Expiration" field, test that the Flatpickr widget works
      correctly and limits to dates after today.
  - Enable the SpecifyDueDate preference if necessary.
    - Test the behavior of the SpecifyDueDate controls: Setting a date,
      clearing a date, session persistence.
- Enable the SuspendHoldsIntranet system preference if necessary.
  - Check out to a patron with existing holds.
    - Open the Holds tab and click the "Suspend" button for one of the
      holds.
      - In the modal window which appears, check that the Flatpickr
        widget works correctly and limits to dates after today.
      - At the bottom of the table of holds, test that the "Suspend all
        holds" Flatpickr works correctly and limits to dates after
        today.
        - Perform this same test from the patron details page.
- Enable the  BatchCheckouts system preference if necessary.
  - Open a patron record and click "Batch check out" in the left-hand
    sidebar menu.
    - Test that the "Hard due date" Flatpickr works correctly as a date
      and time picker.
- Go to Circulation -> Overdues.
  - Test that the date due filters in the sidebar work correctly and
    are linked, e.g. the "to" field cannot be before the "from" field.
     - Perform the same test here: Circulation -> Holds to pull; and
       here: Circulation -> Hold ratios.
- Enable the  HouseboundModule system preference if necessary.
  - Check out to or view details of a patron.
    - Click "Housebound" in the sidebar menu.
      - Save delivery day and frequency settings for that patron.
      - Click "Add a new delivery."
      - Test that the "Date" Flatpickr widget works correctly.
- Go to Patrons -> A patron record -> Edit.
  - Test that Flatpickr widgets work on the following fields:
    - Date of birth
    - Registration date & Expiration date (linked).
    - Patron restrictions -> Add manual restriction -> Expiration.
- View a bibliographic record and start the process of placing a hold.
  - After selecting a patron, test the "Hold starts on" and "Hold
    expires on" date fields. The fields should be linked and each
    should limit to future dates.
  - Confirm that the dates are saved correctly when you submit the
    hold.
- Locate a bibliographic record with multiple holds and view the holds.
  - In the table of holds, test each date field: Date, expiration, and
    suspend-until.
- Test that Flatpickr's static "formatDate" method is working
  correctly:
  - Locate a bibliographic record's item so that there is text in both
    the "Public note" and "Non-public note" field.
  - Check that item out to a patron.
  - After the page reloads the public and non-public notes should be
    shown under the checkout title highlighted in red.
- Check for references to a "validate1" function. There should be none.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 20:13:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 18:13:56 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-tbVwGJwo4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
This seems to be working nicely, I tested on all the pages with each of the
different 'dateformat' options. 

Love the look of Flatpickr!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 21:49:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 19:49:37 +0000
Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout
 note in the OPAC
In-Reply-To: <bug-28720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28720-70-LIxAbRhFBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 21:49:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 19:49:41 +0000
Subject: [Koha-bugs] [Bug 28720] Update the process of adding a checkout
 note in the OPAC
In-Reply-To: <bug-28720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28720-70-80TxEkKyxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123971|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 124631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124631&action=edit
Bug 28720: (follow-up) Improve string translation

This patch fixes the following issues raised by QA:

- It modifies the markup so that "Add note" and "Edit note" can be
  translated more easily.
- It adds display of existing notes back to the table of checkouts.
- It adds to the table configuration so that a "plain" view of the notes
  (without buttons) is shown in print view and in CSV export.
- It improves handling of notes containing quotation marks which would
  previously have broken some edit interactions.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:10:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:10:02 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-mH6N2U14Fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:10:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:10:05 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-MMX2yfF9aa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124618|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124632&action=edit
Bug 28961: Use Flatpickr on tools pages

This patch replaces the use of jQueryUI's datepicker on tools pages.

To test, apply the patch and test the following tools pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

 - News -> New entry: Linked fields "Published date" and "Expiration
   date".
 - Batch extend due dates: Linked fields "Due date from" and  "Due date
   to"; "Hard due date" field.
 - Batch patron deletion: "who have not borrowed since," "whose
   expiration date is before," and "Permanently delete checkout history
   older than."
 - Export: Linked "Start date" and "End date" fields.
 - Import patrons -> Enter default values: "Date of birth,"
   "Registration date," and "Expiry date."
 - Inventory: "Set inventory date to."
 - Batch patron modification -> Submit a batch of cardnumbers or a
   patron list: "Registration date," "Expiry date," and "Restriction
   expiration."
 - Task scheduler: "Date" field.
 - Log viewer: "Display from" and "Display to" linked fields.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:24:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:24:27 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-bz6fShowpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:54:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:54:58 +0000
Subject: [Koha-bugs] [Bug 28967] New: Patrons with no checkouts report shows
 patrons from other libraries with IndependentBranches
Message-ID: <bug-28967-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

            Bug ID: 28967
           Summary: Patrons with no checkouts report shows patrons from
                    other libraries with IndependentBranches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When IndependentBranches is activated and a non-superlibrarian user looks at
the "Patrons with no checkouts" report, it shows patrons from other libraries.

To recreate:
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including reports permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (if using
an existing patron, make sure they have no checkouts or checkout history)
4) Log in as your limited staff patron
5) Go to Reports > Inactive > Patrons who haven't checked out
6) Don't put in any limitations and click Submit
-- The patron from the other library appears in the list
7) Try to search for that other patron in the patron module
-- The patron from the other library is inaccessible

The current behaviour should stay the same for superlibrarians, but I don't
think non-superlibrarians should see other libraries' patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:55:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:55:26 +0000
Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows
 patrons from other libraries with IndependentBranches
In-Reply-To: <bug-28967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28967-70-uhW8rckwAh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12599

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:55:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:55:26 +0000
Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes
In-Reply-To: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12599-70-0Axb5Ph5WK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28967

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 22:57:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 20:57:56 +0000
Subject: [Koha-bugs] [Bug 28967] Patrons with no checkouts report shows
 patrons from other libraries with IndependentBranches
In-Reply-To: <bug-28967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28967-70-KW3P5BcIgN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:00:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:00:16 +0000
Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
 other items and libraries
In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28642-70-ThLpo7owjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I think this needs to be rebased, I wasn't able to apply the patch cleanly.

Also, Michael, could you provide a test plan for your patch? I was going to try
to test it, but without a test plan, it's a bit hard to know what to look at
specifically, especially the "Also don't show other libraries in the many
library selects" part. Which many library selects?

Thank you!

Caroline

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:01:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:01:56 +0000
Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes
In-Reply-To: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12599-70-p1ywxpKuPb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23356
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:01:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:01:56 +0000
Subject: [Koha-bugs] [Bug 23356] IndependentBranches: overdues list
In-Reply-To: <bug-23356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23356-70-9rbwrZakhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23356

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12599

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:23:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:23:04 +0000
Subject: [Koha-bugs] [Bug 28968] New: recreateIssueStatistics.pl should
 (optionally?) ignore the anonymous borrower
Message-ID: <bug-28968-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28968

            Bug ID: 28968
           Summary: recreateIssueStatistics.pl should (optionally?) ignore
                    the anonymous borrower
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The script recreateIssueStatistics.pl compares issues/old_issues to statistics
to determine if there are any borrowernumber/itemnumber/date combinations
present in the former that are not present in the latter. If it finds anything
in (old_)issues that's not in statistics, it writes it into statistics to
correct things.

However, this goes awry really quickly if one is anonymizing reading history.
In those cases, we expect to have a bunch of entries in old_issues tied to the
anonymous borrower, but we never expect to find the anonymous borrower in the
statistics table because we're maintaining the actual patron's borrowernumber
there.

recreateIssueStatistics.pl should have the option to *not* copy/recreate issues
tied to the anonymous borrower.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:25:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:25:07 +0000
Subject: [Koha-bugs] [Bug 28969] New: Document recreateIssueStatistics.pl
 script
Message-ID: <bug-28969-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28969

            Bug ID: 28969
           Summary: Document recreateIssueStatistics.pl script
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28968

We have a script recreateIssueStatistics.pl to find and re-create transactions
missing from statistics. It's not mentioned in the manual at all. We should
document its usage (preferably after we make it less likely to erroneously
duplicate a bunch of stuff, per bug 28968).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28968
[Bug 28968] recreateIssueStatistics.pl should (optionally?) ignore the
anonymous borrower
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:25:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:25:07 +0000
Subject: [Koha-bugs] [Bug 28968] recreateIssueStatistics.pl should
 (optionally?) ignore the anonymous borrower
In-Reply-To: <bug-28968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28968-70-UQ8x2mgqWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28968

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28969


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28969
[Bug 28969] Document recreateIssueStatistics.pl script
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:30:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:30:26 +0000
Subject: [Koha-bugs] [Bug 21093] Problem when using specify due date with
 fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-Wc8CNDvsF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
           Severity|enhancement                 |normal

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Still valid in master. I'm changing this from enhancement to bug, setting it to
normal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep  7 23:32:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 21:32:25 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-c4AuHCyvTY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Problem when using specify  |Specified due date
                   |due date with fast add      |incorrectly retained when
                   |                            |using fast add

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:28:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:28:53 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-pWfQuZLnVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:28:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:28:58 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-dazrTpPcw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #52 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 124633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124633&action=edit
Bug 27945: (follow-up) Fix tests for the adjusted check

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:36:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:36:41 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-ylfuDpFSQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
In additem.pl when doing a fast add we always set the value for
stickyduedate=1, instead we should pass it the actual value from
$fa_stickyduedate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:40:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:40:56 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-9RwzJnPVMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:41:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:41:00 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-qcEzq4GI9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124634&action=edit
Bug 21093: In additem.pl set the right stickyduedate for fast add

To test:
-1 Set the specify due date option to a date, don't check the checkbox
-2 Enter an unknown barcode
-3 Click on fast add
-4 Add a record
-5 Add an item (don't change the barcode!)
-6 The item is checked out to the patron
-7 Verify: The checkbox is "Remember for session" is checked now
-8 APPLY patch
-9 Do steps 1-6 again, this time "Remember for session" should be unchecked
-10 Do steps 1-6 again but this time do check the "Remember for session"
checkbox.
-11 It should be properly checked

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:41:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:41:45 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-7bSx6vTSuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:42:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:42:05 +0000
Subject: [Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly
In-Reply-To: <bug-28728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28728-70-u9GWzYMvKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728

--- Comment #13 from Galen Charlton <gmcharlt at gmail.com> ---
For what it's worth, the bit about clicking the ratio to populate the form
field dates back to 2009 in commit de38cf6df from bug 3130. However, _why_ this
was done is currently lost to the mists of time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:44:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:44:50 +0000
Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js
In-Reply-To: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28802-70-skQB6Zuqef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Even if the severity is "normal" I backported it since it's about translation
and it applied without issues. I do that with accessibility stuff also. Your
call if you feel backporting some additional things those.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:44:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:44:56 +0000
Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the
 translator tool
In-Reply-To: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28462-70-oZKEiEAYd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462

--- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I would say the policy for oldoldoldstable should be the same as for
oldoldstable, thus by default trying to backport any patches for bugs >= major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:46:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:46:13 +0000
Subject: [Koha-bugs] [Bug 28970] New: Create runtime parameters on the fly
Message-ID: <bug-28970-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970

            Bug ID: 28970
           Summary: Create runtime parameters on the fly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: george at nekls.org
        QA Contact: testopia at bugs.koha-community.org

I was just thinking how helpful it would be if we could create runtime
parameters inside of a report.  What I'm thinking is something like this

WHERE biblio.title LIKE CONCAT("%", <<Title contains one of these
words|["good", "box", "friend"]>>, "%")

creating a drop-down that has the three options: free, good, box.

Being able to create parameters would open up a lot of new options with writing
reports.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:48:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:48:36 +0000
Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports
In-Reply-To: <bug-5920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5920-70-PQZy14yY94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #4 from George Williams (NEKLS) <george at nekls.org> ---
I would want to be able to decide if the HTML was scrubbed or not.  Sometimes I
want the HTML output in the csv I download.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 00:56:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 22:56:42 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-DC5XFvX43b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #8)
> root at kohadevbox:koha(bug28948-qa)$ prove t/db_dependent/Koha/Objects.t
> t/db_dependent/Koha/Objects.t .. 18/24
>     #   Failed test at t/db_dependent/Koha/Objects.t line 1214.
> 
>     #   Failed test at t/db_dependent/Koha/Objects.t line 1226.
>     # Looks like you failed 2 tests of 13.
> t/db_dependent/Koha/Objects.t .. 20/24
> #   Failed test 'filter_by_last_update'
> #   at t/db_dependent/Koha/Objects.t line 1234.
> # Looks like you failed 1 test of 24.
> t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/24 subtests

That's a failure in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 01:58:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 23:58:20 +0000
Subject: [Koha-bugs] [Bug 28970] Create runtime parameters on the fly
In-Reply-To: <bug-28970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28970-70-p40ywyItUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 01:58:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Sep 2021 23:58:29 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-83pRkeySCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 02:01:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 00:01:37 +0000
Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache
In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28955-70-B7osA5X5uQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
With a Plack-enabled site, I imagine we'd need to send a custom http header to
achieve that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 03:16:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 01:16:30 +0000
Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and
 biblioitemnumber in request.pl
In-Reply-To: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28057-70-y90UCvIawL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #28 from wainuiwitikapark at catalyst.net.nz ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:22:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:22:03 +0000
Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in
 all pages of the OPAC
In-Reply-To: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26847-70-MkdZgzsryO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847

--- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
the request was only for 20.05.x
severity is not >= to major
so you don't have to try to backport

But it's your call to try to backport some things anyway if they are low risk.
I tend to do that for accessibility and translatability.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:23:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:23:50 +0000
Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the
 translator tool
In-Reply-To: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28462-70-CkheOKViPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldoldstable      |Pushed to oldoldoldstable
         Version(s)|21.11.00,21.05.02,20.11.09, |21.11.00,21.05.02,20.11.09,
        released in|20.05.15                    |20.05.15,19.11.22

--- Comment #27 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:29:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:29:59 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
 undefined value at C4/Reserves.pm line 607
In-Reply-To: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28644-70-dxWkkDyXUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.02,20.11.09, |21.11.00,21.05.02,20.11.09,
        released in|20.05.15                    |20.05.15,19.11.22
             Status|Pushed to oldoldstable      |Pushed to oldoldoldstable

--- Comment #11 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:31:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:31:59 +0000
Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes
In-Reply-To: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28632-70-myHPxC5Aq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.03,20.11.09, |21.11.00,21.05.03,20.11.09,
        released in|20.05.15                    |20.05.15,19.11.22
             Status|Pushed to oldoldstable      |Pushed to oldoldoldstable

--- Comment #20 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:38:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:38:37 +0000
Subject: [Koha-bugs] [Bug 28802] Untranslatable strings in browser.js
In-Reply-To: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28802-70-HvARGH3XT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.03,20.11.10, |21.11.00,21.05.03,20.11.10,
        released in|20.05.16                    |20.05.16,19.11.22
             Status|Pushed to oldoldstable      |Pushed to oldoldoldstable

--- Comment #15 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:49:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:49:28 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-zPnhyoJKst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28965, 27358
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=27358                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358
[Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965
[Bug 28965] Add public routes for lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:49:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:49:28 +0000
Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
In-Reply-To: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27358-70-k9KH8z5Xyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28948
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=28948                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948
[Bug 28948] Add a /public counterpart for the libraries REST endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:49:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:49:28 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-neleYZNCcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28948


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948
[Bug 28948] Add a /public counterpart for the libraries REST endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:55:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:55:04 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-qN1b24Evlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124635&action=edit
Bug 28965: filter_by_public() and filter_by_readable()

This patch adds helper methods for lists resultsets. Tests are added for
their behavior.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:55:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:55:08 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-sS88PUWreG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124636&action=edit
Bug 28965: Add /public/lists

This patch adds a route for publicly retrieving lists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 04:57:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 02:57:18 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-bE0gWueIk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com
             Status|NEW                         |Needs Signoff

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Submitting early to highlight the coolness of what we did on bug 28948. It
still needs tests.

I will file a separate bug for all the CRUD (staff/public). The barebones are
done anyway :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 10:54:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 08:54:25 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-qKR5cWaaFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Joonas Kylmälä from comment #4)
> Thanks, I think this change looks reasonable, though some things to fix.
> 
> 1) Could you fix up the commit message, you mention that this fixes a bug
> but don't say which one, also mention in the commit message what the change
> does and use the format "Bug XXXX: Change X thing". I'm guessing you are
> doing this change to simplify (custom) CSS rules?

Oups sorry i did a git mistake.

> 
> 2) It seems to break the OpacHeader / opacheader CSS rule defined in the line
> 
> koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {

Good point i'm on it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 10:56:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 08:56:29 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-vK9QZW0vro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124637&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is an HTML customization, there is an HTML
tags with id="opacmainuserblock" and one with id="OpacMainUserBlock".

I think template block "koha_news_block" should add a class (lowercase) instead
of an id.
It fixes the bug and also it may be used several times in same page in the
future.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock"

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 11:02:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 09:02:12 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-1Rv9ZWIyEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124318|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 11:04:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 09:04:32 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-zdZZrGHKci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Joonas Kylmälä from comment #4)
> 
> 2) It seems to break the OpacHeader / opacheader CSS rule defined in the line
> 
> koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {

Actually this rule does nothing, it defines same background color as "body" :
#opacheader {
    background-color: #fcf9fc;
}

I propose de remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 11:07:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 09:07:16 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-fq6wu2Zsca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 11:07:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 09:07:20 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-e5TTaV4YML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124638&action=edit
Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS

Actually this rule does nothing, it defines same background color as "body" :
#fcf9fc

Test plan :
1) Without patch look at OPAC header
2) With patch OPAC header should have same background color

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 11:56:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 09:56:33 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Qz9jPRWUE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #20)
> Created attachment 124569 [details]
> Example UI
> 
> I'm not sure the 'app' should be only one or not, I guess the answer is yes.
> But  I like Github's page, and it points us towards this 'several 2FA
> methods' thinking.

The "Security keys" is not implemented in this development, I can understand
the 1-N you would need in this case (you can have several keys), but not with
the TOTP. You have only one TOTP secret that you could regenerate, but that
will invalidate the existing one. How is the secret different than the
password? Are you suggesting we should have the password in this new table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:03:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:03:08 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-JOyRHfX1At@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123178|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:03:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:03:39 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-8DN6jQMzBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patches still apply, CSS changes need to be rebuilt with `yarn build
--view=opac`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:04:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:04:55 +0000
Subject: [Koha-bugs] [Bug 28800] Library list at
 /cgi-bin/koha/admin/branches.pl appears empty
In-Reply-To: <bug-28800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28800-70-9QGvqXQkOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:06:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:06:17 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-lUmJR4BaXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Then provide us more information. What's the output of the following commands?

pmvers Mojolicious::Plugin::OpenAPI
pmvers Mojolicious
pmvers JSON::Validator
pmvers YAML::XS
apt-cache policy libjson-validator-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:12:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:12:29 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
 preference descriptions if a cronjob is required
In-Reply-To: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21158-70-GpGx5Loegg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Why PatronSelfRegistrationVerifyByEmail?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:15:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:15:50 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
 preference descriptions if a cronjob is required
In-Reply-To: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21158-70-tWE7EwX3uv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28971

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 12:54:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 10:54:53 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-VTlsJKAaCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #9 from Mohamad Barham <mbarham at birzeit.edu> ---
root at libkoha:~# pmvers Mojolicious::Plugin::OpenAPI
4.05
root at libkoha:~# pmvers Mojolicious
9.20
root at libkoha:~# pmvers JSON::Validator
4.21
root at libkoha:~# pmvers YAML::XS
0.83
root at libkoha:~# apt-cache policy libjson-validator-perl
libjson-validator-perl:
  Installed: 3.25+dfsg-1+koha3
  Candidate: 3.25+dfsg-1+koha3
  Version table:
 *** 3.25+dfsg-1+koha3 500
        500 http://debian.koha-community.org/koha stable/main amd64 Packages
        100 /var/lib/dpkg/status
     0.92+dfsg-1 500
        500 http://deb.debian.org/debian stretch/main amd64 Packages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 13:05:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 11:05:31 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-ByIo5xsE8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #69 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Shouldn't we have a single 'allowed_to_change' column as an
ENUM('owner','everyone','staff') ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 13:06:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 11:06:07 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-HrEXqPrcMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124629|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124639&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:00:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:00:30 +0000
Subject: [Koha-bugs] [Bug 28972] New: Add missing foreign key constraints to
 holds queue table
Message-ID: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

            Bug ID: 28972
           Summary: Add missing foreign key constraints to holds queue
                    table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The table tmp_holdsqueue is missing a couple key constraints that should be
there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:02:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:02:12 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-T6XmgMo9Ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:02:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:02:15 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-LvKQqzjyqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:06:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:06:27 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-XGdpEgMjyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:06:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:06:31 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-apM7Sf3Fxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124651&action=edit
Bug 28972: Add missing foreign key constraints to holds queue table

The table tmp_holdsqueue is missing a couple key constraints that should
be there, one for biblio and one for borrowers.

Test Plan:
1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or
borrowers
2) Apply this patch
3) Run updatedatabase.pl
4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or
borrowers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:17:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:17:36 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-2iyJtYqD3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124639|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124652&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:17:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:17:54 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-g6z14QF5gH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28966

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:17:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:17:54 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-PZ93rEVbC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28972

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:31:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:31:34 +0000
Subject: [Koha-bugs] [Bug 28973] New: Improve
 Koha::Patron::can_see_patron_infos efficiency
Message-ID: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973

            Bug ID: 28973
           Summary: Improve Koha::Patron::can_see_patron_infos efficiency
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The method can_see_patron_infos looks up a row in the branches table by
branchcode just to get the branchcode it already has. This seems inefficient.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:31:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:31:39 +0000
Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos
 efficiency
In-Reply-To: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28973-70-iVO0h4B9VR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:32:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:32:08 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-EDh03WMYzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:32:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:32:12 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-2j8UemMe4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124634|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124653&action=edit
Bug 21093: In additem.pl set the right stickyduedate for fast add

To test:
-1 Set the specify due date option to a date, don't check the checkbox
-2 Enter an unknown barcode
-3 Click on fast add
-4 Add a record
-5 Add an item (don't change the barcode!)
-6 The item is checked out to the patron
-7 Verify: The checkbox is "Remember for session" is checked now
-8 APPLY patch
-9 Do steps 1-6 again, this time "Remember for session" should be unchecked
-10 Do steps 1-6 again but this time do check the "Remember for session"
checkbox.
-11 It should be properly checked

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:32:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:32:38 +0000
Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos
 efficiency
In-Reply-To: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28973-70-YtlHA5g998@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:32:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:32:41 +0000
Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos
 efficiency
In-Reply-To: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28973-70-ijme4HpP2J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124654&action=edit
Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency

The method can_see_patron_infos looks up a row in the branches table by
branchcode just to get the branchcode it already has. This seems inefficient.

Test Plan:
1) Apply this patch
2) No changes should be noted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:40:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:40:25 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-LiTPuHqF1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:40:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:40:28 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-CQ2kU36N66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124655&action=edit
Bug 28436: Add local cache to Template Plugins for branches and itemtypes

This patch simply stores the branches an itemtypes in a hash for lookup.
This improves efficiency on pages where we are loading many items

To test:
1 - Add ~1000 items to a record
2 - Note load time
3 - Apply patch
4 - Reload and note faster load
5 - Edit a branchname/itemtype description
6 - Reload page
7 - Confirm the updated name is reflected in display

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:40:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:40:42 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-UyXPLcANsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:42:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:42:28 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-lan0aHnJqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
We can definitely add more plugins here.

This feels a bit hacky, however, it reduces to a single lookup per page, avoids
problems with cache coherence and is readable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 14:46:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 12:46:16 +0000
Subject: [Koha-bugs] [Bug 28973] Improve Koha::Patron::can_see_patron_infos
 efficiency
In-Reply-To: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28973-70-q1kLuphT79@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124654|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124656&action=edit
Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency

The method can_see_patron_infos looks up a row in the branches table by
branchcode just to get the branchcode it already has. This seems inefficient.

Test Plan:
1) Apply this patch
2) No changes should be noted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 15:02:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 13:02:35 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-TLZYvY3gqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124581|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124657&action=edit
Bug 28412: Add information about supported authentication methods

This patch adds an initial text explaining the valid authentication
mechanisms Koha has for the API.

My first approach included information about the controlling sysprefs,
but I decided to remove it, as it is not usual for API consumers to be
presented such detailed internal information which is probably
confusing. We could add a link to the manual, but that's not the point I
think.

I've added an entry about error messages and how we thougth about them.
It is copied from Docker Engine's API docs.

This is my 2 cents.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 15:02:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 13:02:46 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-TZDKXPJHO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 15:45:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 13:45:38 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-F58vblsdcA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124570|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124658&action=edit
Bug 28949: Use Flatpickr on reports pages

This patch replaces the use of jQueryUI's datepicker on reports pages.

To test, apply the patch and test the following reports pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Acquisitions statistic wizard: Linked pairs of fields for
  "placed on" and "received on."
- Patrons with the most checkouts: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Patrons who haven't checked out: "Not checked out since"
  field.
- Cash register statistics wizard: Linked "From" and "To"
  fields.
- Most-circulated items: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Catalog statistics wizard: Linked pairs of fields for "Date acquired
  (item)" and "Date deleted (item)" The latter is shown by checking the
  "Count deleted items" radio button.
- View dictionary -> New definition:
  - Enter a definition name
  - Select table Circulation
  - Choose a date column, e.g. "Date of birth" or "Registration date"
  - Select "Date range"
    - Test that the "Start of date range" and "End of date range" fields
      are linked correctly.
- Create guided report:
  - Module: catalog
  - Type: Tabular
  - Select columns (any)
  - Select criteria to limit on: There should be three pairs of linked
    fields, "Creation date," "Modification date," and "Due date."
  - Confirm that the report is saved correctly with the dates you chose.
- Create from SQL -> Test a report with one or more date
  fields, e.g.
https://wiki.koha-community.org/wiki/SQL_Reports_Library#Items_added_by_Collection
- Average loan time: Linke pairs of fields for "Checkout
  date" and "Returns."
- Reports -> Circulation statistics wizard: Linked "Period" fields.
- Reports -> Holds statistics wizard: Linked pairs of fields "Hold
  date," "Notification date," "Reminder date," "Waiting date," and
  "Cancellation date."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 15:52:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 13:52:50 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-NiPPVJIjim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 17:03:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 15:03:54 +0000
Subject: [Koha-bugs] [Bug 28974] New: Add pagination to holds queue viewer
Message-ID: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

            Bug ID: 28974
           Summary: Add pagination to holds queue viewer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 17:41:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 15:41:56 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-OrFbfotq9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 17:59:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 15:59:55 +0000
Subject: [Koha-bugs] [Bug 13706] Deduping authorities script
 (dedup_authorities.pl)
In-Reply-To: <bug-13706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13706-70-blkUy0xbSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122049|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124659&action=edit
Bug 13706: New script dedup_authorities.pl

This script allow to deduplicate authorities automatically.

Script is in misc/maintenance/

It works this way:
 1) authorities are fetched from the database. You can limit fetched
 results by authtypecode, or directly by specifying WHERE clause
 2) for each authority:
  2.1) build a Zebra query using the 'search_form' for the heading
  2.2) run the query, retrieve the results
  2.3) among duplicates, choose the one we want to keep (use
  --choose-method option).
  2.5) use C4::Authorities::merge to merge authorities
 3) delete the merged authorities

Use --help for more informations on options

To be done:
1 - Move to module and cover with tests
2 - Add option to only merge unused authorities
3 - Expand 'ppn' option to be 'control-number' option and allow specifying
field
4 - More?

1 & 2 I will attempt - 3 & 4 may be future enhancements

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 18:00:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 16:00:44 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-ZeBNpMtiPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 18:00:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 16:00:48 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-wbDIK9Wipd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124660&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 18:02:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 16:02:21 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-KxjlPIbVxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966
[Bug 28966] Holds queue viewer too slow to load for large numbers of holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 18:02:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 16:02:21 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-nmMoP08fUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974
[Bug 28974] Add pagination to holds queue viewer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 18:09:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 16:09:36 +0000
Subject: [Koha-bugs] [Bug 28970] Create runtime parameters on the fly
In-Reply-To: <bug-28970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28970-70-aoG3D8utp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 19:02:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 17:02:48 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-uqbk8nMWFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 19:02:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 17:02:54 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-KVAOWOVdLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124661&action=edit
Bug 28762: (follow-up) fix template logic with Available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 19:03:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 17:03:50 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-WEglasfsXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Hayley Pelham from comment #5)
> Hi Lucas,
> 
> I can confirm that the patch fixes the Status of the course reserve item to
> show whether it is withdrawn, damaged, etc.
> 
> However, if it is none of those, the status column no longer shows
> Available, but instead is blank.
> 
> I am assuming it should say available if none of those values you listed are
> true?
> 
> Cheers,
> Hayley

Thanks Haley! I am have made a correction and I am reseting the status of this
one to 'Needs sign-off'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 20:30:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 18:30:33 +0000
Subject: [Koha-bugs] [Bug 28951] Parental Controls
In-Reply-To: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28951-70-SDf3R4IiDg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28951

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Another approach, or option for more sensitive or age appropriate materials
might be to have an option in settings if a library wants to require a login to
see those types of materials.  If some materials are left out because of this
setting, a banner could appear at the top of the results stating that a login
is required to see the age sensitive materials.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:24:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:24:08 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-R4PDHR5f5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:24:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:24:14 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-qjsBWSQT2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124651|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 124662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124662&action=edit
Bug 28972: Add missing foreign key constraints to holds queue table

The table tmp_holdsqueue is missing a couple key constraints that should
be there, one for biblio and one for borrowers.

Test Plan:
1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or
borrowers
2) Apply this patch
3) Run updatedatabase.pl
4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or
borrowers

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:33:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:33:25 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-4HT6GxOOh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from David Nind <david at davidnind.com> ---
Tests fail for me after applying patch (and dependencies) 8-(...

root at kohadevbox:koha(bz28965)$ prove t/db_dependent/Virtualshelves.t
t/db_dependent/Virtualshelves.t .. No method count found for
Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Unknown column 'public' in 'where clause' at
/kohadevbox/koha/Koha/Objects.pm line 601
 at /kohadevbox/koha/Koha/Virtualshelf.pm line 99.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'public' in 'field list' at
/kohadevbox/koha/Koha/Object.pm line 170
    # Looks like you planned 13 tests but ran 1.
t/db_dependent/Virtualshelves.t .. 1/8 
#   Failed test 'CRUD'
#   at t/db_dependent/Virtualshelves.t line 110.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'public' in 'field list' at
/kohadevbox/koha/Koha/Object.pm line 170
# Looks like your test exited with 11 just after 1.
t/db_dependent/Virtualshelves.t .. Dubious, test returned 11 (wstat 2816,
0xb00)
Failed 8/8 subtests 

Test Summary Report
-------------------
t/db_dependent/Virtualshelves.t (Wstat: 2816 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 11
  Parse errors: Bad plan.  You planned 8 tests but ran 1.
Files=1, Tests=1,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.58 cusr  0.15
csys =  1.75 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:37:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:37:30 +0000
Subject: [Koha-bugs] [Bug 28965] Add public routes for lists
In-Reply-To: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28965-70-Q3opnxYeQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #4)
> Tests fail for me after applying patch (and dependencies) 8-(...
> 
> root at kohadevbox:koha(bz28965)$ prove t/db_dependent/Virtualshelves.t
> t/db_dependent/Virtualshelves.t .. No method count found for
> Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI
> Exception: DBD::mysql::st execute failed: Unknown column 'public' in 'where
> clause' at /kohadevbox/koha/Koha/Objects.pm line 601

This failure is because you didn't run the updatedatabase script with bug 28959
applied. That said, I found some missing bits on that bug as well. So hold on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:45:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:45:38 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-c3QbUQ317i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124663&action=edit
Bug 28959: (follow-up) Adjust all places in which 'category' was used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:48:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:48:21 +0000
Subject: [Koha-bugs] [Bug 28975] New: Holds queue lists can show holds from
 all libraries even with IndependentBranches
Message-ID: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

            Bug ID: 28975
           Summary: Holds queue lists can show holds from all libraries
                    even with IndependentBranches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds for patrons from other
branches and even click on the names of the patrons to access their file and
see their information (!!).

To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Patron X and their hold appear in the list
10) Click on patron X's name
-- You can access patron X's file and see their information

Superlibrarians should be able to select any library, but non-superlibrarians
should only be able to select their own library from the drop-down menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:49:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:49:33 +0000
Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section
 does not specify image size limit
In-Reply-To: <bug-28576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28576-70-HrZExtjmFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576

Eric Bégin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #14 from Eric Bégin <eric.begin at inLibro.com> ---
IMO, we have 2 possibilities : 
syspref if we want librarian to be able to change it

or

koha-conf.xml : if this is something to be set by sysadmin.

Any preference ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:52:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:52:55 +0000
Subject: [Koha-bugs] [Bug 28976] New: In MARC21slimUtils.xsl param
 'punctuation' is missing in 'chopPunctuation'
Message-ID: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

            Bug ID: 28976
           Summary: In MARC21slimUtils.xsl param 'punctuation' is missing
                    in 'chopPunctuation'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In MARC21 XSLT files for display, many call on 'chopPunctuation' use param
'punctuation'.
But this param is not used in MARC21slimUtils.xsl in 'chopPunctuation'.
Strangely this param exists in MARC21slimUtils2.xsl.

For example this removes ending dot in display of field 100 while 'punctuation'
param contains ':,;/ '

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:05 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-RGBDjFX9yu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:11 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-n3e7k8H5q2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10265

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:11 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-YbRUWvkOLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28976

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:18 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-F2PBDlmjyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21303

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:18 +0000
Subject: [Koha-bugs] [Bug 21303] XSLT should look in LDR/18 to know whether
 to add punctuation or not
In-Reply-To: <bug-21303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21303-70-rfPpj0wHRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28976

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:53:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:53:43 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-wjdoVtITUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This may be close to Bug 21303

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 21:56:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 19:56:05 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-1JT0SbtWFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
See :
 > git grep '<xsl:with-param name="punctuation">'
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl:                   
                                        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl:                   
        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl:                     
                                        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl:                     
        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl:                    
                                        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl:                    
        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:            
   <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:            
   <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:            
       <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:            
           <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:           
        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:           
    <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:           
    <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl:          
     <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param
name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl:           
    <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:               
            <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:               
        <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:               
<xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:               
<xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:              
 <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:              
 <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:              
 <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param
name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl:              
 <xsl:with-param name="punctuation">

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:00:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:00:05 +0000
Subject: [Koha-bugs] [Bug 12599] IndependentBranches Holes
In-Reply-To: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12599-70-Qq19HzLxrg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28975

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:00:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:00:05 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-EkSqDa8iPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12599

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:00:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:00:52 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-P74KCXPVGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:11:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:11:15 +0000
Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order
 receive page
In-Reply-To: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28881-70-8YJnU8rMIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:12:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:12:19 +0000
Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item
 information
In-Reply-To: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26223-70-UXblNOmAYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |

--- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:21:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:21:46 +0000
Subject: [Koha-bugs] [Bug 15869] Change framework on overlay
In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15869-70-5XoIxSjbVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

--- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
+1, this would be handy!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:26:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:26:30 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-Qw7e2hlogJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
The tests pass. 

However, there is a change to the way lists are displayed, and I can't easily
add items from a search result:

1. Private lists appear under both 'Your lists' and 'Public lists' in the drop
down list when you attempt to add an item(s) to a list from search results.

2. You can't see the public lists either.

I created three lists:

- LISTA = private
- LISTB = public (owner only able to make changes)
- LISTC = public (anyone seeing can make changes)

After applying the patch I have updated the database, flush_memcached, and
cleared cached for browser.

Now in the staff interface when doing a search and attempting to add items to
lists (search > bar at the top with 'Add to list') I only see:

  Your lists
    LISTA 
  Public lists
    LISTA

I can't see any of the public lists to add things to.

I can create a new list (LISTD) (either private or public) but I still only see
the private lists to add things to, and then the private list appears under
both headings:

  Your lists
    LISTD
    LISTA 
  Public lists
    LISTD
    LISTA

The same thing happens in the OPAC.

Also, I'm not sure what the sort order for lists should be, but A-Z would seem
logical to me.

In the OPAC I can see the public lists from Lists > Your lists, then change to
the Public lists tab.

In the staff interface I can see the public lists from Home > Lists > Public
lists tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:27:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:27:01 +0000
Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting
 hold won't save
In-Reply-To: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25619-70-YRoJHqfdgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Unit test shows a warning :

t/db_dependent/Holds.t .. 71/73 Use of uninitialized value $_ in concatenation
(.) or string at t/db_dependent/Holds.t line 1432.

Strange $_ var out of nowhere ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:27:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:27:10 +0000
Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting
 hold won't save
In-Reply-To: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25619-70-M4gCzY1KXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:27:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:27:28 +0000
Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting
 hold won't save
In-Reply-To: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25619-70-Iiq9ZiSQHI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |

--- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:29:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:29:05 +0000
Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description
In-Reply-To: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28554-70-lzFOPeLeRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #20 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:32:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:32:50 +0000
Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search
 results if some items can't be placed on hold
In-Reply-To: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7703-70-YemQnVmhVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28273
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273
[Bug 28273] Multi-holds allow invalid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:32:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:32:50 +0000
Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations
In-Reply-To: <bug-28273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28273-70-R5KhTI8k5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7703


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703
[Bug 7703] Don't block bulk hold action on search results if some items can't
be placed on hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:33:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:33:49 +0000
Subject: [Koha-bugs] [Bug 7703] Don't block bulk hold action on search
 results if some items can't be placed on hold
In-Reply-To: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7703-70-ocj77OGkQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #48 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Does not apply on 20.11.x because patches apply on code of Bug 28273

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:35:44 +0000
Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new
 column but default sort column isn't changed
In-Reply-To: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28891-70-yXDwSu1wY5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:37:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:37:32 +0000
Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should
 generate an empty from_api_mapping
In-Reply-To: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28744-70-LmSbVCEl5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:38:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:38:36 +0000
Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad
 search indexes
In-Reply-To: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28885-70-727GmScQIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:45:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:45:55 +0000
Subject: [Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental
 discount is not set
In-Reply-To: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28774-70-3ZI2WzOk1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:48:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:48:34 +0000
Subject: [Koha-bugs] [Bug 26195] Add a way to specify authorised values
 should be expanded [OAI]
In-Reply-To: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26195-70-m3E5nTJyhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           Keywords|release-notes-needed        |

--- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:49:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:49:23 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-5QUBeXr110@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #38 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:54:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:54:17 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-64fORfh9i7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #41 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Big change, I prefer not push to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 22:54:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 20:54:44 +0000
Subject: [Koha-bugs] [Bug 28977] New: Most-circulated items
 (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
Message-ID: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

            Bug ID: 28977
           Summary: Most-circulated items (cat_issues_top.pl) is failing
                    with SQL Mode ONLY_FULL_GROUP_BY
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: michael.hafen at washk12.org
        QA Contact: testopia at bugs.koha-community.org

The Most circulated items report gives an error when run on a database that has
ONLY_FULL_GROUP_BY in it's SQL_MODE.
Patch to follow shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 23:00:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 21:00:46 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-3ao70PQcxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17258

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 23:00:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 21:00:46 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-U1ocIR7snk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28977

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 23:03:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 21:03:06 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-nkJ2WTbWXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

--- Comment #1 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 124664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124664&action=edit
Proposed patch

Test plan:

Turn on strict_sql_modes ( make sure <strict_sql_modes> is 1 in KOHA_CONF )
Go to Reports -> Most circulated items
submit the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep  8 23:03:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 21:03:24 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-Fh9qwEuRBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 01:27:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 23:27:10 +0000
Subject: [Koha-bugs] [Bug 28978] New: Convert installer CSS to SCSS
Message-ID: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

            Bug ID: 28978
           Summary: Convert installer CSS to SCSS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 28376

Adding Flatpickr to the onboarding templates will be much simpler if the
installer CSS file is generated from SCSS.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 01:27:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 23:27:10 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-2FwNI2dhub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978
[Bug 28978] Convert installer CSS to SCSS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 01:43:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 23:43:36 +0000
Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS
In-Reply-To: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28978-70-o1s6pHgYtN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 01:43:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Sep 2021 23:43:39 +0000
Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS
In-Reply-To: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28978-70-PcvKdOHROm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124665&action=edit
Bug 28978: Convert installer CSS to SCSS

This patch creates a new SCSS file, installer.scss, from which
installer.css will be compiled.

Most of the resulting CSS is unchanged, but some minor sections were
removed because they were obsolete. The jQueryUI-specific section isn't
fully converted to SCSS because it's going to go away with the addition
of Flatpickr.

To test, apply the patch and rebuild the staff client SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is
  updated.
- Go through the complete web installation process, including
  onboarding, to confirm that everything is styled as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:46:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:46:06 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-HFNf1rNFOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:53:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:53:47 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-QoHfrShcBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:53:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:53:51 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-oC5rlr7qM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123234|0                           |1
        is obsolete|                            |
 Attachment #123237|0                           |1
        is obsolete|                            |
 Attachment #124661|0                           |1
        is obsolete|                            |

--- Comment #8 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124666&action=edit
Bug 28762: add staff item-status.inc and better handle statues on
course-details.tt

This patch adds an item-status.inc to the staff side much like what is already
in place on the OPAC.

To test:
1. create a course in course reserves, add an item to it.
2. confirm your item shows Available for its status on course-details.pl
3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted
use
4. reload course-details.pl, confirm it still shows available
5. apply patch
6. repeat step 3 with each of the statuses and make sure it correctly shows on
course-details.pl

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:54:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:54:15 +0000
Subject: [Koha-bugs] [Bug 21303] XSLT should look in LDR/18 to know whether
 to add punctuation or not
In-Reply-To: <bug-21303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21303-70-VeqmGlizdN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21303

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
This is interesting. I always assumed that people just went with "a" for AACR2
for LDR/18, but it looks like the practice for RDA is to use "i" or "c"
according to a few sources like OCLC
(https://www.oclc.org/bibformats/en/fixedfield/desc.html).

OCLC has some examples that suggests even when using AACR2 that they'd use "a"
when including punctuation and "c' when punctuation is omitted
(https://www.oclc.org/bibformats/en/onlinecataloging.html#punctuation)

Very interesting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:54:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:54:19 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-PCXyBlN48q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #9 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124667&action=edit
Bug 28762: handle notforloan better

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 03:55:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 01:55:08 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-UACvTkgrEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #10 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124668&action=edit
Bug 28762: (follow-up) fix template logic with Available

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:01:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:01:15 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-kitdDSbnvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #18)
> 2FA secrets (and the same for overdrive tokens, etc) are not part of the
> 'patron' entity. Changing the model like this to avoid a new table has
> another side effects: you will need to remove it in
> Koha::Patron::to_api_mapping, and if we want to add routes for dealing with
> them, the code will look weird.

+1

We shouldn't overload the borrower table. We really should keep tables as
normalized entities where performance permits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:16:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:16:50 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-ZLwSwm58Kv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---

If we look at Red Hat's FOSS Identity Management system Keycloak, we can see
that they do store credentials separately to the user_entity table.

https://www.keycloak.org/docs/latest/server_admin/#_user-credentials

http://htmlpreview.github.io/?https://gist.githubusercontent.com/thomasdarimont/b1c19da5e8df747b8596e6ddcda7e36f/raw/29309467f4ea07519cf614fd74943272e7d939f4/keycloak_db_overview_4.0.0.CR1-SNAPSHOT.svg

They store both passwords and one-time passwords using that table.

I don't know about Keycloak for sure, but it's common for applications to store
multiple OTPs to give users a margin of error. For instance, with AWS and
Google Authenticator, you can use the current code or the past 1-2 codes I
believe. Using a separate credential table would make that easier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:37:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:37:16 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-zFZfB50aPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:39:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:39:51 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-PwV04P13BG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #2)
> We can definitely add more plugins here.
> 
> This feels a bit hacky, however, it reduces to a single lookup per page,
> avoids problems with cache coherence and is readable

Actually, it looks like there might be a cache coherence problem, since the
our-scoped variable will exist for the life of the process. You could wind up
with stale data if data is cached, the worker stays alive, data is changed in
the staff interface, and then requests are sent to that original worker.

I'd suggest just caching at the request-level. 

I would suggest creating a new() method which sets an object variable with the
required data. According to
http://www.template-toolkit.org/docs/modules/Template/Plugin.html, the new()
method will be called in the USE directive. 

This means that at template processing time you'll get 1 lookup, and then you
can reuse that data for the life of that request. 

There are even cache examples on that TT link above.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:42:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:42:47 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-QkDh2r7EwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
It would be more robust and more readable. 

Or if we wanted to persist the cache beyond the request-level we could use
Koha::Cache, and rely on the staff interface for Libraries and Item Types to
invalidate the cache. 

That would be even better. 

That Koha::Cache could also be placed in the respective modules and have
something like Koha::ItemTypes->get_list() or whatever and have the specific
module handle it's own caching logic. 

Lots of options which would be less hacky and more robust.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:43:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:43:31 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-Er3qutBIt9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
But super keen to see this work go ahead. We do far too many unnecessary DB
calls in Koha...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:45:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:45:58 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-Rwl9COkbno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Since the patch is for template plugins, it's probably worth changing the title
to reflect that the update is just for template plugins too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:47:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:47:39 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-70eOq4Wws8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:49:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:49:37 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
 preference descriptions if a cronjob is required
In-Reply-To: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21158-70-KTlC24qK3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
Also, all these paths are wrong for every installation except a dev
installation...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:52:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:52:50 +0000
Subject: [Koha-bugs] [Bug 28979] New: Cronjob references in system
 preference descriptions don't make sense for most installations
Message-ID: <bug-28979-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28979

            Bug ID: 28979
           Summary: Cronjob references in system preference descriptions
                    don't make sense for most installations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The references added in bug 21158 are path references from a git/dev
installation. Most production installations are probably from packages or
source installs which will have a path like "../bin/cronjobs/<script>" where
they're relative to the application root/installation base. 

At the moment they say "misc/cronjobs/<script>".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:52:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:52:58 +0000
Subject: [Koha-bugs] [Bug 28979] Cronjob references in system preference
 descriptions don't make sense for most installations
In-Reply-To: <bug-28979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28979-70-OvVj6Ug6gL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28979

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21158


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158
[Bug 21158] Add cronjob references to the system preference descriptions if a
cronjob is required
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 04:52:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 02:52:58 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
 preference descriptions if a cronjob is required
In-Reply-To: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21158-70-3AwU10cnGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28979


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28979
[Bug 28979] Cronjob references in system preference descriptions don't make
sense for most installations
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:51:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:51:11 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-iBuJdjzKrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:51:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:51:15 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-zGHfIUmGdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 124669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124669&action=edit
Bug 6796: Add branch_hours table and set opening hours for library

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:51:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:51:20 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-YOcm3LTOId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 124670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124670&action=edit
Bug 6796: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:51:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:51:24 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-iB1NajRSww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 124671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124671&action=edit
Bug 6796: ConsiderLibraryHoursWhenIssuing system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:51:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:51:29 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-wL8Nq1sp7s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

--- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 124672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124672&action=edit
Bug 6796: Consider library hours when calculating due date + tests

This feature adds the ability to set opening and closing hours for your
library and for these hours to be considered when calculating due dates
for hourly loans. If the due date for an hourly loan falls after the
library closes, the library can choose for the due date to be shortened
to meet the close time, or extended to meet the open time the next day.
This feature adds a new table 'branch_hours' for storing the open and
close times per day for each library, and a new system preference
'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be
followed when calculating due dates.

To test:
1. Apply patches and update database. Upgrade schema if not applying
patch with schema changes. Restart services.
2. Go to Administration -> Libraries. Edit a library and scroll to the
bottom to find the 'opening hours' section. Test adding and removing
open and close times on various days. Confirm saving works as expected.
3. Add a new library and test adding open and close times works as
expected.
4. Edit your default library and save open and close times for each day.
5. Go to Administration -> Circulation and fine rules. Edit a rule, set
the unit to 'hours' and set the loan period to a number that would cause
a checkout to be due after the close time you just set, i.e. if you set
your close time to be 5pm and your system time is currently 1pm, set the
loan period to be 5 (5 hours) so the calculated due date would be 6pm.
6. Go to Administration -> system preferences. Search for
ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in
the Circulation system preferences. Confirm the pre-selected option is
'ignore'. Keep this tab open.
6. In a new tab, get the barcode for an item that has an itemtype
matching the circulation rule you just set.
7. Go to the checkouts for a patron that has a categorycode matching the
circulation rule you just set.
8. Check out your item. Confirm that the checkout is due at the end of
the loan period, not taking closing hours into consideration. Return the
item.
9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'close', so the due date should be shortened to meet the close time.
10. Check out your item. Confirm the checkout is due when the library
closes. Return the item.
11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to
'open', so the due date should be extended to meet the opening time.
12. Check out your item. Confirm the checkout is due the next day when
the library opens.
13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 05:52:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 03:52:48 +0000
Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account
 opening and closing hours
In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6796-70-EyHsQD3ni6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This feature adds the
      release notes|                            |ability to set opening and
                   |                            |closing hours for your
                   |                            |library and for these hours
                   |                            |to be considered when
                   |                            |calculating due dates for
                   |                            |hourly loans. If the due
                   |                            |date for an hourly loan
                   |                            |falls after the library
                   |                            |closes, the library can
                   |                            |choose for the due date to
                   |                            |be shortened to meet the
                   |                            |close time, or extended to
                   |                            |meet the open time the next
                   |                            |day. This feature adds a
                   |                            |new table 'branch_hours'
                   |                            |for storing the open and
                   |                            |close times per day for
                   |                            |each library, and a new
                   |                            |system preference
                   |                            |'ConsiderLibraryHoursWhenIs
                   |                            |suing' to choose which
                   |                            |behaviour should be
                   |                            |followed when calculating
                   |                            |due dates.
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 06:15:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 04:15:26 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Lh5dgg3HDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
Note having a credential table could also make it easier to add "temporary"
passwords. 

For instance, it would be great if staff could reset a password, tell the
patron the password, and then the patron would be forced to reset that password
on first login. I'm going to raise a ticket for that and link it to here...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 06:17:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 04:17:12 +0000
Subject: [Koha-bugs] [Bug 28980] New: Add temporary passwords which must be
 reset after first login
Message-ID: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

            Bug ID: 28980
           Summary: Add temporary passwords which must be reset after
                    first login
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be great if passwords could be marked as temporary, so that staff
users could set temporary passwords for borrowers, and those borrowers would
have to reset their password on their 1st successful login.

This would prevent staff users from re-using the same simple password across a
range of users and having those same simple passwords persist over time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 06:17:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 04:17:38 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-eAt3qKoREQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I soft pitched a concept of a credential table  based off the Keycloak
credential table on bug 28786 which might make this easier to implement as
well...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 06:18:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 04:18:23 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-1y993y4xAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
Note that Keycloak db schema view is very old. It's just the first
visualization I could find while I was quickly looking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:31:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:31:32 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-8LAsZbms8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What error you have in the Koha log files?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:36 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-fcPbV2JNR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:40 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-KxFLyMO3dS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124072|0                           |1
        is obsolete|                            |

--- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124673&action=edit
Bug 27945: Add tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:44 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-LJZsTx8IxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124073|0                           |1
        is obsolete|                            |

--- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124674&action=edit
Bug 27945: Add article_request_limit in categories table

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:48 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-fV0HefBH8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124074|0                           |1
        is obsolete|                            |

--- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124675&action=edit
Bug 27945: [DO NOT PUSH] Update DBIx schema

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:52 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-qdD0ZXhQaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124075|0                           |1
        is obsolete|                            |

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124676&action=edit
Bug 27945: Add limit article request feature

This patch makes it possible to limit article requests per patron per day.

To test:
1. Apply patches
2. updatedatabase
3. Enable ArticleRequests preference
4. Edit a patron category and set an article request limit to 1
CHECK => if you set the limit to anything else but a positive number or empty
string, a warning appears
5. In staff search biblios and request an article for a patron of the modified
category
6. Repeat step 5
SUCCESS => if limit is reached, when you select the user to request an article
a warning appears saying that the limit was reached
7. Repeat steps 5 and 6 but this time in opac
SUCCESS => Patron is not allowed to request another article if limit is reached
8. prove t/db_dependent/ArticleRequests.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:44:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:44:56 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-yxxfl3ktxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124076|0                           |1
        is obsolete|                            |

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124677&action=edit
Bug 27945: (QA follow-up) Fix exception POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:01 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-nuc6cff85q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124077|0                           |1
        is obsolete|                            |

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124678&action=edit
Bug 27945: (follow-up) Fix column header title and edit form label

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:06 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-6lNmeaPFiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124079|0                           |1
        is obsolete|                            |

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124679&action=edit
Bug 27945: (follow-up) fix limit check in Patron.pm, regexp in categories.pl
and removed unwanted use Koha::ArticleRequests in ArticleRequest.pm

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:10 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-x6hEynzJ9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124284|0                           |1
        is obsolete|                            |

--- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124680&action=edit
Bug 27945: (QA follow-up) Fix limit check

Resolve:
    [WARN] SQL::Abstract::belch(): [SQL::Abstract::_where_field_op_ARRAYREF]
Warning: A multi-element arrayref as an argument to the inequality op '!=' is
technically equivalent to an always-true 1=1 (you probably wanted to say ...{
$inequality_op => [ -and => @values ] }... instead) at
/usr/share/koha/Koha/Objects.pm line 601

In this case we can simply count the statuses PENDING and PROCESSING.
Note that bug 27944 will change that; PENDING should be replaced by
REQUESTED there.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:14 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-DSxeWAlF7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124285|0                           |1
        is obsolete|                            |

--- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124681&action=edit
Bug 27945: (QA follow-up) Terminology

The term "Maximum article request limit" could be improved.

In this patch we use 'Article request limit' to describe it more
generic. On the field we say 'Maximum active article requests'.

In the manual we need to explain that it is the sum of requests in
Pending (Requested) or Processing stage and completed requests within
the last 24 hours.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:19 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-kOqw4evjir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124633|0                           |1
        is obsolete|                            |

--- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124682&action=edit
Bug 27945: (follow-up) Fix tests for the adjusted check

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:45:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:45:42 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-pLCa4Sh2P6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:46:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:46:19 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-DjgJFluMDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Agustín Moyano from comment #52)
> Created attachment 124633 [details] [review]
> Bug 27945: (follow-up) Fix tests for the adjusted check

Thx Agustin. Looks good to me now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 09:59:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 07:59:54 +0000
Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section
 does not specify image size limit
In-Reply-To: <bug-28576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28576-70-g3BKFnQz9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
We are not asking for making it configurable, only to be meaningful and
consistent.

I agree with Owen's suggestion, let use 2MB.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:13:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:13:50 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-BCOzefKdTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Would be great if you could implement this by a password expiry mechanism.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:25:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:25:27 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-i95sIl1Q5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
On debian 9 it should be:

pmvers Mojolicious::Plugin::OpenAPI
2.16
pmvers Mojolicious
8.12
pmvers JSON::Validator
3.14
pmvers YAML::XS
0.76

You have messed with your packages somehow.

Can you post the output of the following command?

% sudo grep -r koha /etc/apt/sources.list*

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:33:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:33:53 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-2oR2XgIE89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124686&action=edit
Bug 28373: [21.05] Fix transformMARCXML4XSLT export in C4::XSLT

#   Failed test 'use Koha::OAI::Server::Repository;'
 #   at t/00-load.t line 62.
 #     Tried to use 'Koha::OAI::Server::Repository'.
 #     Error:  "transformMARCXML4XSLT" is not exported by the C4::XSLT module
 # Can't continue after import errors at
/kohadevbox/koha/Koha/OAI/Server/Repository.pm line 39.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:41:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:41:50 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-dBkZMNQ35i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:53:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:53:33 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-LRLrCgzJ45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124543|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124687&action=edit
Bug 28921: Remove warning from html_helpers.inc

Argument "" isn't numeric in numeric gt (>) at
/home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line
23.

To test:
1 - Open OPAC main page
2 - Check opac-error.log or plack-opac-error.log for message as above
3 - Apply patch
4 - Open OPAC main page
5 - Check opac-error.log again, there should be no more warnings

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:54:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:54:25 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-a1Vu9OqzV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Didier, the warning itself is not a correct commit title. Have a look at
https://wiki.koha-community.org/wiki/Commit_messages if you are not familiar
with it yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 10:59:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 08:59:23 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-FFubZ9eqti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Isn't the correct fix to call $item->home_branch->branchcode?

>From Koha::Item

sub home_branch {
    my ($self) = @_;

    $self->{_home_branch} ||= Koha::Libraries->find( $self->homebranch() );

    return $self->{_home_branch};
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:30 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-ZrT2sak96W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:33 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-wXaYI3iqso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:35 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-QF0q0yO29d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:38 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-plSDnRy63m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:41 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-tr4xikFsmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:44 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-olQ0Yn5Y6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:46 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-jJsJnmjQ3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:49 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-QAmnlDRRdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:52 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-8m2uAA0HEP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:54 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-GlRX6bd5WF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:57 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-v3j7EZDEyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:00:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:00:59 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-uDyJZM0f9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:01:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:01:02 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-GtTk9kxdQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:01:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:01:04 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-bwqnhLp7iH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:01:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:01:07 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-QsJlsyiHXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:01:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:01:10 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-eVip99UdqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:01:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:01:39 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-W9Nwyj1XLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #38)
> Created attachment 124496 [details] [review]
> Bug 28373: (follow-up) Fix copy error
> 
> Previous commit linked all 'default' buttons for sysprefs to
> OPACXSLTListsDisplay
> 
> This adjusts the links
> 
> To test:
> Click "default" for all 6 XSLT preferences
> Confirm the syspref relating to the link is marked 'modified' when clicked

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:02:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:02:29 +0000
Subject: [Koha-bugs] [Bug 28306] Allow to query database with minimal memory
 footprint
In-Reply-To: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28306-70-RMXgQphPVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
As I didn't get additional help I've pushed Julian's patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:04:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:04:18 +0000
Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache
In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28955-70-saqMT2dpiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

Jake Deery <jake.deery at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jake.deery at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:06:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:06:33 +0000
Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache
In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28955-70-0dnJOOhJrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:29:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:29:42 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-HNElS53KEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |BLOCKED

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Bug 28316 is waiting for SO, can we get your attention there please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:51:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:51:55 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-ySlKQlXJZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:51:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:51:59 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-qC25Dsple6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124688&action=edit
Bug 28831: Database revision, add new preference

The preference OPACResultsUnavailableGroupingBy allows you to
group unavailable items by substatus, only showing item counts, on
the OPAC XSLT results.

This is meant to be useful for larger consortia.

Test plan:
Run dbrev.
Check new pref on Admin, preferences, OPAC tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:52:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:52:02 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-pYvaaqMizs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124689&action=edit
Bug 28831: Add choose/when, and change indentation

As a first step:
[1] Add the new pref OPACResultsUnavailableGroupingBy in the xslt,
    and pass it via C4/XSLT.
[2] Add a choose/when construction in the third part of Availability.
[3] Add indentation (8 spaces) of the inner block handling group by branch.

Test plan:
Make sure that OPACResultsUnavailableGroupingBy eq branch.
Verify that OPAC results are still untouched.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:52:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:52:06 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-YNmquglIy8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124690&action=edit
Bug 28831: Add the new group by substatus-block

Test plan:
Change OPACResultsUnavailableGroupingBy to substatus.
Verify the result on opac results. (You need a few unavailable items
with different statuses on a few branches.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:53:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:53:10 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-EoncihD4sO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
David, Nick: This is a small follow-up on the XSLT changes on bug 26302. Could
you please have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 11:54:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 09:54:15 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-z045XqxsRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
As I didn't get a reply I will try to provide a more complete, and maybe more
convincing, answer.

I would like to highlight that those patches are not adding *new* code to
Koha::UI. The code there is moved from current code that is duplicated in
several places: additem and batchmod so far (for the add item form and the
items table).

To make the item batchmod tool use the task queue I had to reuse the same code
from batchmod.pl, and instead of reusing the code as it, I preferred to make it
more robust, and reusable from other places. The code is now in a module,
covered by test, and centralized in a single place.

The next move should be to reuse the same code (methods and BLOCK from inc)
from the remaining places (acq and serial, detail pages, etc.)

If we reach this point we will have all our add item forms and items tables
using the exact same code, covered by tests. That will make any other
improvements easier to implement.

Please see this as a continuous improvement of the current situation, not as
the perfect solution we want to have at the end. I totally agree we should be
using the REST API routes to achieve that goal, but we are not ready at all for
that.
Building the table like it's done here is not achievable right now using the
REST API, and was not the point anyway.

We need the item batch mod tool back running in background mode for 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:00:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:00:02 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-Dt0j1nmLuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
As example.
This allows you to toggle between:

Not available: Centerville: Checked out (1). Centerville: Ordered (1).
Fairfield: Checked out (1). Fairfield: Withdrawn (1). 

OR

Not available: Checked out (2). Ordered (1). Withdrawn (1). 

In the first case the unavailable items = 0, groupby = branch.
In the second case only groupby = substatus is relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:03:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:03:14 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-vbFiCJJCsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #11 from Mohamad Barham <mbarham at birzeit.edu> ---
/etc/apt/sources.list.d/koha.list:deb http://debian.koha-community.org/koha
stable main stretch
/etc/apt/sources.list.d/koha.list.save:deb
http://debian.koha-community.org/koha stable main

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:18:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:18:53 +0000
Subject: [Koha-bugs] [Bug 28981] New: Add a syspref for marking items as
 unavailable in Z3950Responder
Message-ID: <bug-28981-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28981

            Bug ID: 28981
           Summary: Add a syspref for marking items as unavailable in
                    Z3950Responder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Proposal:
1 - Add a new system preference "Z39ResponderUnavailable"
2 - Similar to 'OpacHiddenItems' this will accept a list of column/value pairs
3 - Update Koha::Z3950Responder::Session::add_item_status to check the
preference and mark item as unavailable
4 - Item status message will be pulled from Z3950_STATUS authorized value list

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:20:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:20:52 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-AkHGAPoOB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
In a test environment, I would try to remove the different packages and
reinstall them.

remove:
libmojolicious-plugin-openapi-perl
libmojolicious-perl
libjson-validator-perl
libyaml-perl

apt update && apt upgrade

reinstall them
restart services

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:34:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:34:42 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-XADB1lvlfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I get this error in master: The method Koha::Patron::Categories->search_limited
is not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 12:35:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 10:35:45 +0000
Subject: [Koha-bugs] [Bug 28981] Add a syspref for marking items as
 unavailable in Z3950Responder
In-Reply-To: <bug-28981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28981-70-m3KjCczvqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28981

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:10:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:10:23 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-GmTRKr5cYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mohamad Barham from comment #9)
> root at libkoha:~# pmvers Mojolicious::Plugin::OpenAPI
> 4.05
> root at libkoha:~# pmvers Mojolicious
> 9.20
> root at libkoha:~# pmvers JSON::Validator
> 4.21
> root at libkoha:~# pmvers YAML::XS
> 0.83

hi Mohamad
it seems that these perl modules have been installed from CPAN

this will cause problems with your Koha install, and you need to remove these
modules to fix the problem

you should not have to install any perl modules from CPAN, for a working Koha
package install

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:13:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:13:04 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-eVu6PfI5Ge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:24:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:24:45 +0000
Subject: [Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of
 itemcallnumbers
In-Reply-To: <bug-26302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26302-70-JA3hvPBoGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:26:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:26:26 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-2LcodMZgag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #13)
> (In reply to Mohamad Barham from comment #9)
> > root at libkoha:~# pmvers Mojolicious::Plugin::OpenAPI
> > 4.05
> > root at libkoha:~# pmvers Mojolicious
> > 9.20
> > root at libkoha:~# pmvers JSON::Validator
> > 4.21
> > root at libkoha:~# pmvers YAML::XS
> > 0.83
> 
> hi Mohamad
> it seems that these perl modules have been installed from CPAN
> 
> this will cause problems with your Koha install, and you need to remove
> these modules to fix the problem
> 
> you should not have to install any perl modules from CPAN, for a working
> Koha package install

hi Mohamad
after a backup, try these commands to remove the problem modules

 sudo cpan -v --uninstall Mojolicious::Plugin::OpenAPI
 sudo cpan -v --uninstall Mojolicious
 sudo cpan -v --uninstall JSON::Validator
 sudo cpan -v --uninstall YAML::XS

then...
 sudo koha-plack --restart libkoha

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:30:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:30:16 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-MYiEO5ymgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:30:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:30:29 +0000
Subject: [Koha-bugs] [Bug 28811] Cant receive orders
In-Reply-To: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28811-70-OsiTiPJ3Yu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
> hi Mohamad
> after a backup, try these commands to remove the problem modules
> 

oops, that should been 'cpanm'

 sudo cpanm -v --uninstall Mojolicious::Plugin::OpenAPI
 sudo cpanm -v --uninstall Mojolicious
 sudo cpanm -v --uninstall JSON::Validator
 sudo cpanm -v --uninstall YAML::XS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:31:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:31:50 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-tv96szGinO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #6 from David Nind <david at davidnind.com> ---
I get this message when updating the database:

root at kohadevbox:koha(bz28831)$ updatedatabase
Bareword found where operator expected at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28831.pl line 11, near
"('OPACResultsUnavailableGroupingBy','branch','branch|substatus"
  (Might be a runaway multi-line || string starting on line 9)
        (Missing operator before substatus?)
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28831.pl  [12:29:18]
ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at
/kohadevbox/koha/C4/Installer.pm line 735. at /kohadevbox/koha/C4/Installer.pm
line 737

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:33:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:33:13 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-8ncudqPalA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:45:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:45:55 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-sbkuMcsAbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

--- Comment #3 from jstallings at tsas.org ---
As above, "The method Koha::Patron::Categories->search_limited is not covered
by tests!" Full plack-error.log: https://pastebin.com/1hZnCGnD

Nothing in intranet or other logs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:48:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:48:18 +0000
Subject: [Koha-bugs] [Bug 28982] New: Use Flatpickr on onboarding pages
Message-ID: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

            Bug ID: 28982
           Summary: Use Flatpickr on onboarding pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28937, 28376

There is one datepicker instance in the onboarding templates which should be
replaced with Flatpickr.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:48:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:48:18 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-WUabJq5Tfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982
[Bug 28982] Use Flatpickr on onboarding pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:48:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:48:18 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-UDSQ8vTSFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982
[Bug 28982] Use Flatpickr on onboarding pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:49:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:49:06 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-vEMx2k4XBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978
[Bug 28978] Convert installer CSS to SCSS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:49:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:49:06 +0000
Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS
In-Reply-To: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28978-70-5QLUnRPCyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28982


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982
[Bug 28982] Use Flatpickr on onboarding pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:51:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:51:14 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-5sJDxjiN2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #3)
> Isn't the correct fix to call $item->home_branch->branchcode?
> 
> From Koha::Item
> 
> sub home_branch {
>     my ($self) = @_;
> 
>     $self->{_home_branch} ||= Koha::Libraries->find( $self->homebranch() );
> 
>     return $self->{_home_branch};
> }

There are two things with that.

1) $item is a DBIx::Class::Result and not a Koha::Item in EDI (Yes, we should
certainly convert to Koha Objects here at some point)
2) if all we need is the code, why call through another DB hitting accessor
rather than use the field in the first set directly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:51:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:51:33 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-BsLiBHhkQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124688|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124706&action=edit
Bug 28831: Database revision, add new preference

The preference OPACResultsUnavailableGroupingBy allows you to
group unavailable items by substatus, only showing item counts, on
the OPAC XSLT results.

This is meant to be useful for larger consortia.

Test plan:
Run dbrev.
Check new pref on Admin, preferences, OPAC tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:51:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:51:37 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-iWPchO9Tzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124689|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124707&action=edit
Bug 28831: Add choose/when, and change indentation

As a first step:
[1] Add the new pref OPACResultsUnavailableGroupingBy in the xslt,
    and pass it via C4/XSLT.
[2] Add a choose/when construction in the third part of Availability.
[3] Add indentation (8 spaces) of the inner block handling group by branch.

Test plan:
Make sure that OPACResultsUnavailableGroupingBy eq branch.
Verify that OPAC results are still untouched.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:51:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:51:40 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-v4mEVjcnYY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124690|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124708&action=edit
Bug 28831: Add the new group by substatus-block

Test plan:
Change OPACResultsUnavailableGroupingBy to substatus.
Verify the result on opac results. (You need a few unavailable items
with different statuses on a few branches.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:58:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:58:19 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-6uJZG5OcRB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
For future reference, once a bug has gone through SO and QA please respond to
change requests as follow-ups... that way it's easy for a reviewer to see that
the requested change has been made and nothing else beyond it.. with the
changed squashed in it's much more difficult.. especially if one has cleaned up
their previous branches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 14:58:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 12:58:38 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-VQC3KjB5vq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:00:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:00:28 +0000
Subject: [Koha-bugs] [Bug 28831] Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-qGMOVGp2IW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Nind from comment #6)
> I get this message when updating the database:
> 
> root at kohadevbox:koha(bz28831)$ updatedatabase
> Bareword found where operator expected at
> /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28831.pl line 11,
> near "('OPACResultsUnavailableGroupingBy','branch','branch|substatus"
>   (Might be a runaway multi-line || string starting on line 9)
> 	(Missing operator before substatus?)
> DEV atomic update
> /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28831.pl  [12:29:18]
> ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at
> /kohadevbox/koha/C4/Installer.pm line 735. at
> /kohadevbox/koha/C4/Installer.pm line 737

Ah thanks for noting.
The pipe char ended the quote command. Had to add a backslash. And removed a
comma.
Tested now, should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:00:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:00:51 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC Results XSLT: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-9MkZx4C3W3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Results XSLT: Allow         |OPAC Results XSLT: Allow
                   |unavailable item grouping   |unavailable item grouping
                   |on status only for large    |on status only for large
                   |consortia                   |consortia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:02:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:02:53 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-RZyY0u3lMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124560|0                           |1
        is obsolete|                            |

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124709&action=edit
Bug 28316: add tests

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:02:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:02:59 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-DDxWjepdIK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124561|0                           |1
        is obsolete|                            |

--- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124710&action=edit
Bug 28316: screen unquoted semicolons and all followup colons

Currently searches like: "book:", ":book" and "host-item:test:n"
cause internal server errors.

This patch adds additional regexes that remove the colons at the start
and end of the query, and another regex that screens all follow-up
colons that go after the first colon to avoid errors when searching for
"host-item:test:n".

To reproduce:
1) using ES, search for the book with title that contains
semicolon at the start or at the end of the line, separated with spaces,
this should cause internal server error.
2) try doing the same with something like "host-item:test:n", it should
result in error as well.
3) apply the patch.
4) repeat steps 1-2, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:03:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:03:05 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-pQOOEL01I1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124562|0                           |1
        is obsolete|                            |

--- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124711&action=edit
Bug 28316: escape brackets in the search query

This patch screens square and curly brackets which have no special
language meaning.

To reproduce:
1) using ES, search for the book with title that contains
square and/or curly brackets, like "book [second edition]", which will
result in error.
2) apply the patch.
3) search for that book again, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:03:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:03:11 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-Plo6fIvMwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124563|0                           |1
        is obsolete|                            |

--- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124712&action=edit
Bug 28316: escape exclamation signs in the query

Currently having exclamation sign at the end of the query makes ES
search fail, and when you try to search for a book that has exclamation
sign in the tittle (something like "Words! words") won't show results
correctly as it tries to negate everything that is after exclamation
sign, making it impossible to search for books that have in in the title

This patch escapes exclamation signs if it's at the end of the query or
has a space after it, resolving both of the issues listed above.

To reproduce:
1) with ES enabled, search for the book with title that contains
exclamation sight at the end, like "book!", this search should result
 in error.
2) do another search, but this time find/prepare beforehand book with a
title that has exclamation sign with a space after it,
e.g "exclamation! sign", it shouldn't find it as ES treats everything
after that exclamation sign as negation.
2) apply the patch.
3) perform searches from the steep one and two again.
Search from step one should no longer fail, while search from the step
two should find that book.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:03:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:03:17 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-IpXe6aPinx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124564|0                           |1
        is obsolete|                            |

--- Comment #108 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124713&action=edit
Bug 28316: avoid messing up regexes in the search queries

This patch ensures that the behavior with
QueryRegexEscapeOptions set to values other than
"Escape" still will works as expected.

It does so by storing the contents of regexes
before escaping special characters and
then restores the contents of regexes back to how
it was before, ensuring that searching with regex is possible.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:03:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:03:22 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-13HLiALvRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124565|0                           |1
        is obsolete|                            |

--- Comment #109 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124714&action=edit
Bug 28316: escape ES ranges if QueryAutoTruncate is enabled

if QueryAutoTruncate enabled we will have any special operators ruined
for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]"
so no reason to keep ranges when QueryAutoTruncate set to "enabled"

1) enable QueryAutoTruncate at your sysprefs.
2) perform a search using range, for example: "[1999 TO 2020]",
it shouldn't work the way it's supposed to.
3) apply the patch.
4) perform the same search with range, ensure that it works correctly.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:03:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:03:29 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-4lIPx3he7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124566|0                           |1
        is obsolete|                            |

--- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124715&action=edit
Bug 28316: (QA follow-up) Make clean_search_term public

With all the work that's gone into improving the internal
_clean_search_term method I feel we should expose it publically as it's
going to be more widely helpful

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:04:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:04:32 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-FxEvUvxLA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Phew.. I had an old branch hanging around I could diff with.

Passing QA again, looks like everything has been taken care of.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:05:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:05:48 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-tcWDFGJmLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC Results XSLT: Allow    |OPAC XSLT Results: Allow
                   |unavailable item grouping   |unavailable item grouping
                   |on status only for large    |on status only for large
                   |consortia                   |consortia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:45:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:45:56 +0000
Subject: [Koha-bugs] [Bug 27753] Automate resolution of return claim when
 checking in an item
In-Reply-To: <bug-27753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27753-70-X0xUdFtf5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #5 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
For me if a book is really returned, the claims retruned note should desappear.

> Maybe a sys pref that can say "If a claim return item is checked in on the
> returns.pl resolve the claim and set it to X resolution?"

I'm Ok for a syspref but it should also be done if the return is done on a
selfcheckout system via SIP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 15:57:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 13:57:46 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-7mbW9cMQqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've finally found a moment to look at this.

Whilst I like Tomas's proposal to normalise the database by having a distinct
table.. I think that can certainly come as a followup later.

I do wonder why you've chosen a super new cpan module for this,
Auth::GoogleAuth. I had considered Authen::OAth myself, because although it's a
little smaller (you'de need something to generate QR codes on top), it's
further up the CPAN river and is written by a trusted author... might even
already have a debian package.

Finally, and what I would consider a QA failure.. the secret is stored in plain
text in the database. I feel this should be stored encrypted using the a
passphrase stored in the config file (we could re-use api_secret_passphrase or
add a new field to the config.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:13:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:13:19 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-D0HFaE6n1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:13:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:13:22 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-YiZ9GidmW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124716&action=edit
Bug 28982: Use Flatpickr on onboarding pages

This patch replaces the use of jQueryUI's datepicker in the onboarding
templates. The addition of calendar.inc to the template requires that
some additions be made to the installer's header files, adding the i18n
JavaScript assets.

jQueryUI-specific CSS is removed from installer.scss, and inclusion of
Flatpickr's SCSS is added.

To test, apply the patch and rebuild the staff client SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Start the installation process.
- Continue through the installation process until you reach the stage in
  onboarding where you are creating a patron category.
- The "Enrollment period -> Until" field should be a Flatpickr calendar
  widget. The widget should look and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:18:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:18:12 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-Zewpl1vmlx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #112 from Andrew Nugged <nugged at gmail.com> ---
:huggs:

yeah, right, Petro, look, we should next time add follow-up (thanks Martin!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:25:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:25:34 +0000
Subject: [Koha-bugs] [Bug 28983] New: Use Flatpickr on various pages
Message-ID: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

            Bug ID: 28983
           Summary: Use Flatpickr on various pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 28937, 28376

This bug will cover Flatpickr additions to these pages/files:

* circ/offline.tt
* clubs/clubs-add-modify.tt
* ill/ill-requests.tt
* labels/search.tt
* pos/register.tt
* suggestion/suggestion.tt
* tags/review.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:25:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:25:34 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-TgVHUEQXL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28983


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983
[Bug 28983] Use Flatpickr on various pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:25:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:25:34 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-ByPQHi4E3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28983


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983
[Bug 28983] Use Flatpickr on various pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:38:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:38:48 +0000
Subject: [Koha-bugs] [Bug 28984] New: Unify MARC21 ISBN/ISSN handling in
 XSLT in the OPAC
Message-ID: <bug-28984-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984

            Bug ID: 28984
           Summary: Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 20339

Bug 20339 implemented a template for ISBN/ISSN display, but only changed the
staff interface files. We should implement the changes for the OPAC as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339
[Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:38:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:38:48 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-n2Rr3Fk2u7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28984


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984
[Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:39:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:39:12 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSLT in
 the staff interface
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-5iif8UNaWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unify MARC21 ISBN/ISSN      |Unify MARC21 ISBN/ISSN
                   |handling in XSL             |handling in XSLT in the
                   |                            |staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 16:56:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 14:56:48 +0000
Subject: [Koha-bugs] [Bug 28985] New: Negative rental amounts can be saved
 but not enforced
Message-ID: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

            Bug ID: 28985
           Summary: Negative rental amounts can be saved but not enforced
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: nick at bywatersolutions.com
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In item types, one can enter a negative amount for a rental charge. Koha allows
this, saves the value, and shows it to you in admin. However, that value gets
ignored at checkout.

On the one hand, I can see weird use cases for giving patrons credits for
checking out items.

On the other hand, it would be a lot simpler to just not allow negative values
to get set in the first place.

Whichever way we go, we should pursue consistency and not let users enter
values that don't get used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:20:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:20:58 +0000
Subject: [Koha-bugs] [Bug 28986] New: Parent itemtype not selected when
 editing circ rules
Message-ID: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

            Bug ID: 28986
           Summary: Parent itemtype not selected when editing circ rules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
1 - Go to Administration -> Item types
2 - Edit a type to have a parent of another type
3 - Go to Administration -> Circulation and fines rules
4 - Add a rule for the child type
5 - Add a rule for the parent type
6 - Click edit on child type, note dropdown in editor correctly selected
7 - Click edit on parent type - note dropdown menu refers to 'All' itemtypes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:22:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:22:44 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-LT6E0qpTRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #113 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Andrew Nugged from comment #112)
> :huggs:
> 
> yeah, right, Petro, look, we should next time add follow-up (thanks Martin!)

No worries; if there's a mistake to be made like this I've probably made it at
least a few times already myself ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:25:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:25:09 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-z5iJKSfdsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:25:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:25:12 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-ODfcUDgVob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124717&action=edit
Bug 28986: Remove (All) notation to correctly select rule for editing

This patch updates the JS comparison code to remove the '(All)' hint before
comparing
to the current value

To test:
1 - Go to Administration -> Item types
2 - Edit a type to have a parent of another type
3 - Go to Administration -> Circulation and fines rules
4 - Add a rule for all categories for the child itemtype
5 - Add a rule for all categories for the parent itemtype
6 - Click edit on child type, note itemtype dropdown in editor correctly
selected
7 - Click edit on parent type - note itemtype dropdown menu refers to 'All'
itemtypes
8 - Apply patch
9 - Reload page and edit parent type rule
10 - Itemtype dropdown is correctly populated

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:45:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:45:41 +0000
Subject: [Koha-bugs] [Bug 28987] New: Record search by date broken in label
 management
Message-ID: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987

            Bug ID: 28987
           Summary: Record search by date broken in label management
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24735

If you go to Tools -> Label creator -> New batch -> Add items you'll trigger a
popup window with a search form. Searching by date returns no results.

I think Bug 24735, "Remove QueryParser-related code" is to blame.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735
[Bug 24735] Remove QueryParser-related code
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:45:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:45:41 +0000
Subject: [Koha-bugs] [Bug 24735] Remove QueryParser-related code
In-Reply-To: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24735-70-0I4kz3WUl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28987


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987
[Bug 28987] Record search by date broken in label management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:46:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:46:08 +0000
Subject: [Koha-bugs] [Bug 28987] Record search by date broken in label
 management
In-Reply-To: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28987-70-BL2YaViKKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28983


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983
[Bug 28983] Use Flatpickr on various pages
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 17:46:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 15:46:08 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-ajnLWlcQUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28987


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987
[Bug 28987] Record search by date broken in label management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 18:59:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 16:59:55 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-jGslmWKcOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 18:59:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 16:59:58 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-D34110uC9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124717|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124718&action=edit
Bug 28986: Remove (All) notation to correctly select rule for editing

This patch updates the JS comparison code to remove the '(All)' hint before
comparing
to the current value

To test:
1 - Go to Administration -> Item types
2 - Edit a type to have a parent of another type
3 - Go to Administration -> Circulation and fines rules
4 - Add a rule for all categories for the child itemtype
5 - Add a rule for all categories for the parent itemtype
6 - Click edit on child type, note itemtype dropdown in editor correctly
selected
7 - Click edit on parent type - note itemtype dropdown menu refers to 'All'
itemtypes
8 - Apply patch
9 - Reload page and edit parent type rule
10 - Itemtype dropdown is correctly populated

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 19:36:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 17:36:52 +0000
Subject: [Koha-bugs] [Bug 28987] Record search by date broken in label
 management
In-Reply-To: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28987-70-2qYbjG5oU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28983                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983
[Bug 28983] Use Flatpickr on various pages
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 19:36:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 17:36:52 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-vuiTyti8vt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28987                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987
[Bug 28987] Record search by date broken in label management
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 19:39:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 17:39:33 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-20RXebQzo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 19:39:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 17:39:36 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-CH3Go5csPN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124719&action=edit
Bug 28983: Use Flatpickr on various pages

This patch replaces the use of jQueryUI's datepicker on various
unrelated pages.

To test, apply the patch and test the following pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Tools -> Patron clubs -> New club: Linked "start date" and "end date"
  fields.
- ILL requests: Two linked pairs of date fields in the sidebar, "Date
  placed between" and "Updated between." Each pair should work correctly
  and table filtering by date should work correctly.
- Tools -> Label creator -> Manage -> Layout batches -> Edit a batch ->
  Add items. This should trigger a popup window with a linked pair of
  date fields, "Added on or after date," and "Added on or before date."
- Point of sale -> Transaction history: "From" and "To" linked date
  field in the "Older transactions" section.
- Acquisitions -> Suggestions -> Add a suggestion: "Created by,"
  "Accepted on," and "Managed by" fields.
- Tools -> Tags -> Filter tags by date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 19:41:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 17:41:27 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-ug7UDv8lxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I started to make this bug dependent on Bug 28987 because you can't actually
test whether the label search by date works. But if you believe your eyes that
the dates appear correctly in the input fields I think you can sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:27:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:27:33 +0000
Subject: [Koha-bugs] [Bug 28988] New: Reindent calendar template
Message-ID: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

            Bug ID: 28988
           Summary: Reindent calendar template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28963

I would like to update the calendar template so that it has consistent
indentation. It also needs to have some trailing spaces removed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963
[Bug 28963] Use Flatpickr on calendar page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:27:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:27:33 +0000
Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
In-Reply-To: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28963-70-MSdlkclaR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988
[Bug 28988] Reindent calendar template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:27:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:27:45 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-bmkoMqebyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28963                       |
             Blocks|                            |28963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963
[Bug 28963] Use Flatpickr on calendar page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:27:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:27:45 +0000
Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
In-Reply-To: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28963-70-FVnyKLpG1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28988                       |
         Depends on|                            |28988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988
[Bug 28988] Reindent calendar template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:44:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:44:57 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-300bs4Piaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:45:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:45:00 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-PY36cw3jSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124720&action=edit
Bug 28988: Reindent calendar template

This patch performs general template cleanup to the calendar template:
Make indentation consistent and trim trailing whitespace.

To test, apply the patch and go to Tools -> Calendar.

The page should look correct and work correctly. If you view the diff
while ignoring whitespace the only changes should be where line breaks
were introduced.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 20:45:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 18:45:04 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-DLlayB5Duy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124721&action=edit
Bug 29899: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 23:30:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 21:30:00 +0000
Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record
 results not ordered correctly due to punctuation marks
In-Reply-To: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26472-70-oOQudVz9KA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep  9 23:30:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 21:30:55 +0000
Subject: [Koha-bugs] [Bug 25035] Add ability to search match-heading index
 in authorities
In-Reply-To: <bug-25035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25035-70-mTzj0cQr0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25035

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 01:36:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Sep 2021 23:36:38 +0000
Subject: [Koha-bugs] [Bug 28980] Add temporary passwords which must be reset
 after first login
In-Reply-To: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28980-70-91RpxWx8Oh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #2)
> Would be great if you could implement this by a password expiry mechanism.

I was thinking about that a bit as well. Good call. 

I should note that I don't have any plans to work on this, but thought it was a
good idea, so raised a report for it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:04:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:04:50 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-j9nQkvpmCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #10)
> What remains for me is the question: Should we allow a non-superlibrarian to
> give him or herself the privilege to change systemprefs?
> Because you can disable ProtectSuperlib etc..
> But this should be solved on another report imo.
> 
> Should we only protect that pref, or a specific set of prefs, or actually
> not allow changing sysprefs at all by non superlibs? I tend to choose the
> latter.

I don't think shutting out non-superlibrarians from the admin tools/system
preferences is a feasible solution. That forces you to give out superlibrarian
permissions to more people instead of making it a protected circle. We just
added granular permissions for administration areas - that would make them
practically useless.

Maybe the ProtectSuperLib should not be a pref in the first place?

> Even a few other options on the Admin menu like Koha to MARC mapping (among
> others) might be candidates too for restricting them to superlibrarians only.
> What do you think?

We do already have separate permissions for all those areas, I believe adding
dependencies like that, will only make the system more intransparent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:06:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:06:46 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-lbJDpCn6xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Will it still be possible to print the whole queue over multiple pages?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:22:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:22:42 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-ZNdEiIXRq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #12)

Thx for your feedback.

> I don't think shutting out non-superlibrarians from the admin tools/system
> preferences is a feasible solution. That forces you to give out
> superlibrarian permissions to more people instead of making it a protected
> circle. We just added granular permissions for administration areas - that
> would make them practically useless.

It might be helpful if we could distinguish between viewing sysprefs and
changing them.
And along those lines, a small set of sysprefs could somehow be set apart for
changes only by superlibrarian. Perhaps even configurable by sysadmin.

The gap in the changing permissions form is that we allow a staff user to set
and clear permissions that he does not have himself. Which is a bit awkward,
especially for Admininstration. I think that we should give that a bit more
thought.

> Maybe the ProtectSuperLib should not be a pref in the first place?

Currently, a lot of devs need a preference to come in since we are too afraid
to change 'current behavior'.
This pref could be marked as privileged. See before.

I will open a few reports for these things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:26:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:26:47 +0000
Subject: [Koha-bugs] [Bug 28989] New: Allow viewing systempreferences only
Message-ID: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989

            Bug ID: 28989
           Summary: Allow viewing systempreferences only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

See bug 28882.
It might be helpful if we could distinguish between viewing sysprefs and
changing them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:38:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:38:11 +0000
Subject: [Koha-bugs] [Bug 28990] New: Allow changes for a configurable
 subset of systempreferences by superlibrarian only
Message-ID: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

            Bug ID: 28990
           Summary: Allow changes for a configurable subset of
                    systempreferences by superlibrarian only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

See bug 28882.
And along those lines, a small set of sysprefs could somehow be set apart for
changes only by superlibrarian. Perhaps even configurable by sysadmin.

Example:
If you give a staff user Administration privileges, but not superlibrarian, he
can now change your MarcFlavour,  KohaAdminEmailAddress, OPACBaseURL, etc.
It might be possible that you dont want any changes there? ;)
Note that sometimes changes could be made even unwillfully but by accident.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:43:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:43:05 +0000
Subject: [Koha-bugs] [Bug 28991] New: Setting user permissions should be
 limited by current user permissions
Message-ID: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28991

            Bug ID: 28991
           Summary: Setting user permissions should be limited by current
                    user permissions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

See bug 28882.

The gap in the changing permissions form is that we allow a staff user to set
and clear permissions that he does not have himself. Which is a bit awkward,
especially for Admininstration. I think that we should give that a bit more
thought.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:19 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-4BjYOBpUk1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28991

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:19 +0000
Subject: [Koha-bugs] [Bug 28991] Setting user permissions should be limited
 by current user permissions
In-Reply-To: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28991-70-bRd3BNC5H5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28991

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28882

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:28 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-Vdvuve8d1L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28990

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:28 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-O7DdbfU3Cf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28882

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:37 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-B4VuM9mRet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28989

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 08:44:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 06:44:37 +0000
Subject: [Koha-bugs] [Bug 28989] Allow viewing systempreferences only
In-Reply-To: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28989-70-Oxju41zqer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28882

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:10:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:10:10 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-uK0aCLaNoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This has been discussed already on a separate bug report (or I discussed it
privately with somebody else, cannot remember).

The idea we had was to have a new section in koha-conf to list sysprefs we
couldn't edit from the UI. So it's a bit stronger than what you suggest as only
the sysop could modify them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:16:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:16:39 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-aduBqty2xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> This has been discussed already on a separate bug report (or I discussed it
> privately with somebody else, cannot remember).
> 
> The idea we had was to have a new section in koha-conf to list sysprefs we
> couldn't edit from the UI. So it's a bit stronger than what you suggest as
> only the sysop could modify them.

Hmm. Interesting point.
My first idea would be to keep the possibility of change by superlibrarian. If
we would not want any change, we should better replace the pref by a
koha-config variable?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:24:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:24:15 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-SqgH2Ir3dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:24:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:24:19 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-AAvQpxxQe3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122199|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124722&action=edit
Bug 28464: Add unit tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:24:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:24:22 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-sFLjj8isvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122200|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124723&action=edit
Bug 28464: Remove useless check that gives the incorrect error message

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:24:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:24:26 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-rNPq3ApW76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124724&action=edit
Bug 28464: (QA follow-up) Correct test plan

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:25:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:25:40 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-hFlepz6yTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:29:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:29:06 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use
 XSLTParse4Display
In-Reply-To: <bug-28734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28734-70-djugtNkzcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #6)
> This looks all good, but I feel like we'll need a regression test as this is
> a change to a module method. Holding off PQA.

As QA manager you are allowed to change status, Katrin :)
Let me do it for you now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:32:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:32:18 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-JnIlTyadl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Processing files before patches
Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
line 896.
|========================>| 2 / 2 (100.00%)
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
line 896.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:34:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:34:36 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-KH5YLmUtlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #6)
> Processing files before patches
> Argument "" isn't numeric in numeric gt (>) at
> /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
> addbiblio.tt line 896.
> |========================>| 2 / 2 (100.00%)
> Processing files after patches
> Argument "" isn't numeric in numeric gt (>) at
> /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
> addbiblio.tt line 896.

[% IF ( BIG_LOOP.size > 1 ) %]

?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:44:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:44:55 +0000
Subject: [Koha-bugs] [Bug 28987] Record search by date broken in label
 management
In-Reply-To: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28987-70-Hb6kVbgSp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hum, did you confirm 24735 was the culprit?

I get results using Zebra, nothing with ES.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:48:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:48:40 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-kk8bZ43Znx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing. There might be something wrong here..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:49:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:49:37 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-4x01PLptiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
=head2 GetMarcFromKohaField

    ( $field,$subfield ) = GetMarcFromKohaField( $kohafield );
    @fields = GetMarcFromKohaField( $kohafield );
    $field = GetMarcFromKohaField( $kohafield );

    Returns the MARC fields & subfields mapped to $kohafield.
    Since the Default framework is considered as authoritative for such
    mappings, the former frameworkcode parameter is obsoleted.

    In list context all mappings are returned; there can be multiple
    mappings. Note that in the above example you could miss a second
    mappings in the first call.
    In scalar context only the field tag of the first mapping is returned.

=cut

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:53:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:53:46 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-2J7M4uCUKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber" );

Your call here does not look at the specific itemnumber field in that framework
since kohafields are looked up in the Default framework. This is already the
case in a few Koha versions. I know since I was involved in that dev ;)

So your framework may not have an itemnumber field, but if the Default has,
then you can still add an item.

You need to think of a solution in some other way?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:54:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:54:10 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-lblEd6yQzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 09:55:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 07:55:36 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-HpMnvmoeJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I hadn't realized we weren't manipulating a Koha::Object. And my remark was
silly anyway as $item->branchcode is working if $item is a Koha::Item.

Sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:06:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:06:06 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-LjF5Op1tVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
            Version|21.05                       |unspecified
         Depends on|                            |23590, 23271
           Severity|normal                      |major
           Keywords|                            |rel_21_05_candidate
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
[Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
[Bug 23590] Add the ability to change the manager of a suggestion and notify
the new manager
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:06:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:06:06 +0000
Subject: [Koha-bugs] [Bug 23271] Koha::Patron::Category should use
 Koha::Object::Limit::Library
In-Reply-To: <bug-23271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23271-70-W8CAdKJh7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946
[Bug 28946] 500 error when choosing patron for purchase suggestion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:06:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:06:06 +0000
Subject: [Koha-bugs] [Bug 23590] Add the ability to change the manager of a
 suggestion and notify the new manager
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-gvaIRZwjmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946
[Bug 28946] 500 error when choosing patron for purchase suggestion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:07:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:07:41 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-RJqqURHeBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:07:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:07:45 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-g63JXbPj70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124725&action=edit
Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl

commit f6e0b04f48e8f0a02dbb8d48152646257d9accba
Bug 23271: Replace search_limited with search_with_library_limits

We were modifying the occurrences of:
  Koha::Patron::Categories->search_limited;
with:
  Koha::Patron::Categories->search_with_library_limits;

But between the patch submission and the push, another occurrence has
been added by bug 23590.

Test plan:
Create a new suggestion from staff and click "select manager"
Without the patch, notice the error:
  The method Koha::Patron::Categories->search_limited is not covered by tests!
With the patch applied everything is working correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:27:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:27:38 +0000
Subject: [Koha-bugs] [Bug 28992] New: Resolve warning from undefined BIG_LOOP
Message-ID: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

            Bug ID: 28992
           Summary: Resolve warning from undefined BIG_LOOP
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
addbiblio.tt line 896.

Spotted this one while QAing bug 28608

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:27:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:27:48 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-8qNwPZlbty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28608

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:27:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:27:48 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
 creation even if framework has no items field
In-Reply-To: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28608-70-tlhuNuWjdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28992

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:30:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:30:52 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-rJTMH6AEve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:30:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:30:56 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-kvPFa1hTG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124726&action=edit
Bug 28992: Resolve warning on BIG_LOOP

Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
addbiblio.tt line 896.

Came across it when testing 28608. Could have been a QA follow-up.

Test plan:
If you run QA tools on this patch, you should see the warning only
when processing files before patches.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:31:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:31:24 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-DXtApFOUme@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Super trivial one liner. Self signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:37:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:37:45 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-MXGYTQZnZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 FAIL   C4/HoldsQueue.pm
   FAIL   critic
                # Variables::ProhibitUnusedVariables: Got 1 violation(s).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:41:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:41:44 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-539eGWa9hh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:41:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:41:49 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-XgPFFktPex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124719|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 124728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124728&action=edit
Bug 28983: Use Flatpickr on various pages

This patch replaces the use of jQueryUI's datepicker on various
unrelated pages.

To test, apply the patch and test the following pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Tools -> Patron clubs -> New club: Linked "start date" and "end date"
  fields.
- ILL requests: Two linked pairs of date fields in the sidebar, "Date
  placed between" and "Updated between." Each pair should work correctly
  and table filtering by date should work correctly.
- Tools -> Label creator -> Manage -> Layout batches -> Edit a batch ->
  Add items. This should trigger a popup window with a linked pair of
  date fields, "Added on or after date," and "Added on or before date."
- Point of sale -> Transaction history: "From" and "To" linked date
  field in the "Older transactions" section.
- Acquisitions -> Suggestions -> Add a suggestion: "Created by,"
  "Accepted on," and "Managed by" fields.
- Tools -> Tags -> Filter tags by date.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:45:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:45:01 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-eBwRvcpgr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
:).. it's certainly on my list to switch over to objects.. but before that I
need to blitz some tests.. why is EDI so darn hard!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:47:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:47:26 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-z9frBEJTbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 10:58:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 08:58:52 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-1owMnj4tv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
My concern here is introducing a item-status.inc that will be deviating from
the opac version quite a bit already.
Thinking about how we could keep them together. Maybe a few more lines here or
there, but if they could be the same?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:08:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:08:58 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-d8tqCoqqWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #27)
> I've finally found a moment to look at this.
> 
> Whilst I like Tomas's proposal to normalise the database by having a
> distinct table.. I think that can certainly come as a followup later.

If we are talking about 3NF, I don't think having a separate table with a
single column (different than the FK) is what can be called normalisation.

If that is what you have in mind, I think it's wrong:
borrowers < 1-1 > secrets
                  - borrowernumber (FK borrowers.borrowernumber)
                  - secret


> I do wonder why you've chosen a super new cpan module for this,
> Auth::GoogleAuth. I had considered Authen::OAth myself, because although
> it's a little smaller (you'de need something to generate QR codes on top),
> it's further up the CPAN river and is written by a trusted author... might
> even already have a debian package.

I've compared them all.
There is a recent version of Auth::GoogleAuth, which show it's still an active
project:
https://metacpan.org/pod/Auth::GoogleAuth
1.03      2021-01-10
1.02      2017-12-26
1.01      2015-08-03
1.00      2015-08-03

Note that 1.03 is only in bullseye.

https://metacpan.org/pod/Authen::OATH
2.0.1     2017-04-12
1.0.0     2010-05-25

The author is active in different other projects:
https://metacpan.org/author/GRYPHON

Also, it can generate QR codes out-of-the-box.

> Finally, and what I would consider a QA failure.. the secret is stored in
> plain text in the database. I feel this should be stored encrypted using the
> a passphrase stored in the config file (we could re-use
> api_secret_passphrase or add a new field to the config.

How would you do that?
You encrypt when you don't want to know the secret, and you will never know it
again.
Here we need the secret (and not one of its hashed version) as it's an external
module that is doing the comparison job. We could eventually generate a new
secret containing borrowers.secret, like we concatenate bcrypt_settings (or
part of it) with borrowers.secret. That could work but feel weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:11:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:11:09 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-kni1Ntybzs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124438|0                           |1
        is obsolete|                            |

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124741&action=edit
Bug 28898: Context for translation: term (word) vs. term (semester)

This patch add context to the term Term in the context of course reserves.

To test:
0- Apply patch
Set up course reserves
1- Enable UseCourseReserves
2- Create at least one authorized value for DEPARTMENT
3- Create at least one authorized value for TERM
4- Create a course
5- Add at least one item to the course

Check the terms:
6- Go to the OPAC
7- Go to Course reserves
** 8- In the list of courses, check the Term column heading
9- Go to the staff interface
10- Go to Course reserves
** 11- In the list of courses, check the Term column heading
12- Click on the course name
** 13- Check the Term line in the course description

Add a new language (fr-CA in the example, change for whatever language code you
want)
14- In a terminal, run
gulp po:create --lang fr-CA
15- Then, run
gulp po:update --lang fr-CA
16- In system preferences, enable the new language in language and
OpacLanguages
17- Switch the language in staff interface and OPAC

Change the translations
18- In your favourite text editor, open fr-CA-messages.po
19- Find the string 'msgctxt Semester'
20- Enter a word in msgstr
21- Save the file
22- In a terminal, go to misc/translator
23- Run
./translate install fr-CA

Check the translations
24- Redo the steps to check the terms (6-16) and make sure the terms in steps
8, 11, and 13 are changed for the word you put in step 20.
25- Optionally, check the following pages to make sure the terms are not the
word you put in step 20 (these pages shouldn't have been changed)
- opac-tags (your account > your tags)
- opac-authorities (search for an authority in Authority search)
- review (tags in staff interface)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:11:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:11:13 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-7kSfJLtyts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124439|0                           |1
        is obsolete|                            |

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124742&action=edit
Bug 28898: (follow-up) Remove comment lines before PROCESS statements

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:11:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:11:17 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-TEQT88AsIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124440|0                           |1
        is obsolete|                            |

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124743&action=edit
Bug 28898: (follow-up) Add context to some more occurrences of Term in course
reserves

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:11:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:11:29 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-nCzKST7j8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:14:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:14:23 +0000
Subject: [Koha-bugs] [Bug 28993] New: Switch magnifying class in staff
 detail pages to FA icon
Message-ID: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993

            Bug ID: 28993
           Summary: Switch magnifying class in staff detail pages to FA
                    icon
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

It appears that bug 13327 switched the magnifying class shown on authority
links in the OPAC detail pages to a FA icon. It would be nice to make the same
change to the staff detail pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:19:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:19:45 +0000
Subject: [Koha-bugs] [Bug 28994] New: Make writeoff_debts.pl use
 amountoutstanding, not amount
Message-ID: <bug-28994-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994

            Bug ID: 28994
           Summary: Make writeoff_debts.pl use amountoutstanding, not
                    amount
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

This script uses "amount" to write off debts, when it should be using
"amountoutstanding":

                # A 'writeoff' is a 'credit'
                my $writeoff = Koha::Account::Line->new(
                    {
                        date              => \'NOW()',
                        amount            => 0 - $line->amount,   <== HERE
                        credit_type_code  => 'WRITEOFF',
                        status            => 'ADDED',
                        amountoutstanding => 0 - $line->amount,   <== HERE
                        manager_id        => undef,
                        borrowernumber    => $line->borrowernumber,
                        interface         => 'intranet',
                        branchcode        => undef,
                    }
                )->store();

                my $writeoff_offset = Koha::Account::Offset->new(
                    {
                        credit_id => $writeoff->accountlines_id,
                        type      => 'WRITEOFF',
                        amount    => $line->amount   <== HERE
                    }
                )->store();

Patch coming.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:19:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:19:57 +0000
Subject: [Koha-bugs] [Bug 28994] Make writeoff_debts.pl use
 amountoutstanding, not amount
In-Reply-To: <bug-28994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28994-70-Ap9CbBOm8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049
[Bug 27049] Add a script to bulk writeoff debts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:19:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:19:57 +0000
Subject: [Koha-bugs] [Bug 27049] Add a script to bulk writeoff debts
In-Reply-To: <bug-27049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27049-70-4aC6NUlXnK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28994


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28994
[Bug 28994] Make writeoff_debts.pl use amountoutstanding, not amount
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:22:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:22:48 +0000
Subject: [Koha-bugs] [Bug 28995] New: Add --added_after to writeoff_debts.pl
Message-ID: <bug-28995-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995

            Bug ID: 28995
           Summary: Add --added_after to writeoff_debts.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 27049

writeoff_debts.pl currently supports --added_before to make it work on fines
added before a given date. It would be nice if we could also tell it to work on
fines added after a given date, with --added_after.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049
[Bug 27049] Add a script to bulk writeoff debts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:22:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:22:48 +0000
Subject: [Koha-bugs] [Bug 27049] Add a script to bulk writeoff debts
In-Reply-To: <bug-27049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27049-70-nde6S4QdPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28995


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995
[Bug 28995] Add --added_after to writeoff_debts.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:28:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:28:41 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-DBrhwni06U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124744&action=edit
Bug 28762: (QA follow-up) A first attempt to sync the includes

This is just a start.
Should we resolve all differences?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:31:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:31:13 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-PSs1xcKywe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |In Discussion
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Jonathan: What do you think? Get the includes correct here and enforce synced
changes or just push them while different, and hope to keep them closer? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:32:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:32:37 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-kB6HJGg7M8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Obviously you would need to pass staff => 1 now too in the course reserves page
in staff client..
If we go this direction?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:32:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:32:56 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-n0YLnKAGbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:33:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:33:23 +0000
Subject: [Koha-bugs] [Bug 28761] Item status shows incorrectly on
 opac-course-details.pl
In-Reply-To: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28761-70-rSQVJO0V8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:40:08 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-iP7vATearm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:40:12 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-5AExgRvnL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124746&action=edit
Bug 28803: Replace INVALID_EMAIL with UNKNOWN_ERROR

There can be other exceptions/errors raised by Koha::Email->create.

On a follow-up bug report we should deal with the different possible errors to
handle them properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:41:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:41:10 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-eeVrcy1A94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Everything ok with this approach then? Please keep moving!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:50:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:50:33 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-DkNObFID57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:52:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:52:12 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-DcTptO2qHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #14)
> Jonathan: What do you think? Get the includes correct here and enforce
> synced changes or just push them while different, and hope to keep them
> closer? ;)

Hard call, I don't think we should have them all in sync.
Maybe we could have a 'common' directory with some include files that would be
identically both sides? We even could have a test to ensure it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:55:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:55:32 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-hbKuOYMAn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+        [% IF ( OPACShowCheckoutName ) %]

this is wrong for staff, there is no test on "opac".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 11:57:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 09:57:33 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-V9gjGkPtjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:00:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:00:01 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-OW8h7zoTSq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #17)
> +        [% IF ( OPACShowCheckoutName ) %]
> 
> this is wrong for staff, there is no test on "opac".

Yeah. I did not finish this sync operation. But wanted to get some discussion
first. It should be possible to add some opac/staff checks and have them
exactly identical.
But it might be to hard to require that here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:08:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:08:17 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-a5tX9FZ6gd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:08:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:08:21 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-SJzQQgiqLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124460|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 124748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124748&action=edit
Bug 28945: Use Flatpickr on administration pages

This patch updates administration templates to use Flatpickr instead of
jQueryUI datepickers.

To test, apply the patch and test date fields on the following pages:

- Administration -> Budgets ->
  - New budget: Linked "Start date" and "End  date" fields.
  - Duplicate budget: Linked "Start date" and "End  date" fields.
- Acquisitions -> Vendor -> New contract: Linked "Start date" and "End
  date" fields.
- Administration -> Circulation and fine rules: "Hard due date" and "No
  automatic renewal after" fields.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:24:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:24:01 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-fXYA22SOyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124749&action=edit
Bug 28948: (follow-up) Use ::Allowlist structure

This patch updates the patchset to use the ::Allowlist structure
introduced with bug 28935.  I think we need more work here to provide
for 'read' and 'write' allowlists.. we also need a way to alter the
allowlist from the Koha object when required as with the load time at
to_api here we currently have no way to pass overrides to the allowlist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:37:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:37:16 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-yKDioB5fc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry, not sure what more needs doing here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 12:46:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 10:46:39 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-KgvWSxJSSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Not all encryption is one way ;). I was suggesting for these fields we use
encrypt/decrypt where we have the key stored outside of the database, but on
the server.  That way, we can decrypt the secret as needed on the server to
validate the top. But the key secret itself can't easily be leaked via reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:05:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:05:31 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-65O1c185CL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #21)
> Sorry, not sure what more needs doing here?

Confirmation from you and Tomas that the last patch is what we want.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:06:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:06:02 +0000
Subject: [Koha-bugs] [Bug 11223] Incorrect ind 1 semantics for MARC21 785 on
 the detail page in staff
In-Reply-To: <bug-11223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11223-70-hkmIusKPgN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, maybe instead of checking ind1=0 it would be safer to check ind1!=1, so
people that don't catalog the indicators are on the safe side. Need to verify
still.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:07:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:07:11 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-40zbtjWhnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:07:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:07:15 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-ihKSzC5bBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124283|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124750&action=edit
Bug 28931: Use EXPORT_OK from Koha::AuthUtils

It has been missed on bug 17600.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:08:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:08:07 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-oPMswxSQbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Got the list using

 % grep --files-without-match "use Koha::DateUtils.*dt_from_string" `git grep
dt_from_string|cut -d':' -f1|sort|uniq`

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:39:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:39:37 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-K39gKdBPUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:39:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:39:40 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-kV0oPWBfcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124725|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124751&action=edit
Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl

commit f6e0b04f48e8f0a02dbb8d48152646257d9accba
Bug 23271: Replace search_limited with search_with_library_limits

We were modifying the occurrences of:
  Koha::Patron::Categories->search_limited;
with:
  Koha::Patron::Categories->search_with_library_limits;

But between the patch submission and the push, another occurrence has
been added by bug 23590.

Test plan:
Create a new suggestion from staff and click "select manager"
Without the patch, notice the error:
  The method Koha::Patron::Categories->search_limited is not covered by tests!
With the patch applied everything is working correctly

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:39:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:39:53 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-cbamPDQ0to@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:40:12 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-hjv85qeSWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:56:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:56:25 +0000
Subject: [Koha-bugs] [Bug 28996] New: SendQueuedMessages exit on a bad email
 'To' and following messages are never processed.
Message-ID: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

            Bug ID: 28996
           Summary: SendQueuedMessages exit on a bad email 'To' and
                    following messages are never processed.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 22343

If there's a bad 'To' field email create die but it isn't caught by
SendQueuedMessages.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343
[Bug 22343] Add configuration options for SMTP servers
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 13:56:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 11:56:25 +0000
Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
In-Reply-To: <bug-22343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22343-70-JBW7iGStBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996
[Bug 28996] SendQueuedMessages exit on a bad email 'To' and following messages
are never processed.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:05:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:05:49 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-cFkOJYaIZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:09 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-NxX7pfg1Yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124002|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124752&action=edit
Bug 28870: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:13 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-ky4bqwQLrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124003|0                           |1
        is obsolete|                            |

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124753&action=edit
Bug 28870: Use Email::Address to validate email addresses

This patch adds a new dependency, Email::Address. It is used in
Koha::Email to replace the current use of Email::Valid, which proved to
be problematic when it comes to UTF-8 characters.

Email::Address provides suitable regexes that -when used- keep our
tests passing, but also deal better with UTF-8 data.

To test:
1. Apply the regression tests patch
2. Notice the only change is that it tweaks a couple addresses so they
   contain umlauts and also have the "Description <address>" format that
   is used when sending carts.
3. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> FAIL: Tests fail! Things die because Email::Valid doesn't like the
   from we passed.
4. Run:
   $ sudo apt install libemail-address-perl
5. Apply this patch
6. Repeat 3
=> SUCCESS: Tests pass!
7. Try what is described in comment 1
=> SUCCESS: Things are back to normal
8. Sign off :-D
9. Send cookies

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:17 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-r1X4jlfJhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124004|0                           |1
        is obsolete|                            |

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124754&action=edit
Bug 28870: Remove traces of Email::Valid

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:21 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-M3RR5VBGgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124183|0                           |1
        is obsolete|                            |

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124755&action=edit
Bug 28870: Move email address validation to a specific class method

To ease testing and future changes if needed.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:26 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-MTzC7x47DE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124184|0                           |1
        is obsolete|                            |

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124756&action=edit
Bug 28870: Use Email::Address->parse

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:06:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:06:31 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-TtYzE4Kupq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124185|0                           |1
        is obsolete|                            |

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124757&action=edit
Bug 28870: non-FQDN addresses are valid

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:08:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:08:33 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-gAWgG0GvqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Letting pragmatism win here.

I feel the is_valid method is in the wrong context here, perhaps a
Koha::Email::Address object we pass around should be created.. or the class
method here could be renamed validate_address() or something.

But, the code works, the tests pass.  Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:08:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:08:42 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-gzb8YDmEUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:09:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:09:59 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-EmgzdP8KSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:12:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:12:54 +0000
Subject: [Koha-bugs] [Bug 28991] Setting user permissions should be limited
 by current user permissions
In-Reply-To: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28991-70-yAZfBbzs1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28991

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:12:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:12:58 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-PDyuvWqTgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:13:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:13:04 +0000
Subject: [Koha-bugs] [Bug 28989] Allow viewing systempreferences only
In-Reply-To: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28989-70-LGepsq3eC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:16:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:16:17 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-IgJLAtZp7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:17:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:17:50 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-s1hWWtndAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:18:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:18:21 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-QZy6lJBun1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:18:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:18:25 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-TgtMw5p0jg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124758&action=edit
Bug 28985: Force positive numbers for itemtype charge fields

This patch adds a min attribute to the fields on this page and adds
other cost related fields to validator

To test:
1 - Apply patch
2 - Browse to Administration->Item types
3 - Edit or create an item type
4 - Attempt to place a negative or non numeric value in:
    Daily rental charge
    Hourly rental charge
    Default replacement cost
    Processing fee
5 - You should not be able to

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:18:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:18:49 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-Z6M3j1E4LJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #3 from Donna <bwsdonna at gmail.com> ---
I'd be hesitant to move certain sysprefs to the koha-conf.  Many times a
superlibrarian is not the sysop, and would not have access to make those
changes directly when needed.  I like Marcel's idea of having a customizable
list of preferences that can only be changed by a superlibrarian.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:19:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:19:18 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-oNavXs5yrs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |kyle at bywatersolutions.com
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:21:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:21:06 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-w4Aqmxsi0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00                    |21.11.00,21.05.04
        released in|                            |
                 CC|                            |kyle at bywatersolutions.com

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Pushed to 21.05.x for 21.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:22:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:22:23 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_28921=5D_Many_=5BWARN=5D_Argument_?=
 =?utf-8?q?=22=22_isn=27t_numeric_in_numeric_gt_=28=3E=29_at_/home/koha/sr?=
 =?utf-8?q?c/koha-tmpl/opac-tmpl/bootstrap/en/includes/html=5Fhelpers=2Ein?=
 =?utf-8?q?c_line_23=2E?=
In-Reply-To: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28921-70-jNW8OxoF6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28921

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |CLOSED
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:26:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:26:21 +0000
Subject: [Koha-bugs] [Bug 28991] Setting user permissions should be limited
 by current user permissions
In-Reply-To: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28991-70-0CI8Haova1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28991

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #1 from Donna <bwsdonna at gmail.com> ---
I agree!  You either have to let a user change pretty much everything, or
nothing.  It would be nice to have a middle ground.  

The two sys prefs that are involved with this are also fairly confusing - 
Allow staff members to modify permissions for other staff members (staffaccess)
and 
Set user permissions (permissions)

Perhaps as a supervisor I need to be able to reset the password for my staff,
but I don't need to be able to change permissions.  

It would be helpful to have this permissions reworked to allow more flexibility
and control.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:29:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:29:19 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-w3ojfrm76h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Well.. all the exceptions thrown by Koha::Email->create are around invalid
email addresses so I'm not entirely comfortable with 'Unknown error'.. that
kinda feels like "Give up now" to me whereas the actual fix is fairly simple.

Problem is.. we don't, yet, pass the 'fields' param in the BadParameter
exceptions that are thrown and I'm not sure we've got a field in the messages
table to hold that data anyway to pass it to the template.

So.. all in all.. I dunno.  Personally, we have the patch in production now on
all our servers without your follow-up.. and find it helpful.

I also don't really think this needs to require either of the depends. Yes,
they help to reduce the times it'll get thrown, but this patch eliminates a
vital issue whereby sending ANY massages in the queue can be thwarted by one
bad email address server wide.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:42:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:42:09 +0000
Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a
 reason when cancelling a hold
In-Reply-To: <bug-25534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25534-70-ZGGPe91rwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

--- Comment #97 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
The Template Toolkit notice example given above had the wrong authorised value
category value. This will work:

[% USE AuthorisedValues %]
Reason: [% AuthorisedValues.GetByCode( 'HOLD_CANCELLATION',
hold.cancellation_reason, 'IS_OPAC' ) %]

[% IF hold.cancellation_reason == "YOUR_CODE" %]
IF perhaps you'd like to have a much longer explanation than just the
one sentence in the AV description, you can use IF blocks using Template
Toolkit markup!
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 14:47:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 12:47:26 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-SQt7oL4vMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #20)

I understand your intentions. I'm sure we have as many possible solutions as we
do developers. If Koha and its community are to continue to be successful we
need to adapt as technology and trends change. It's important that we keep that
in mind is all.

I have reservations but this is definitely an improvement nevertheless.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:05:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:05:55 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-O2HvIBeJvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

--- Comment #187 from Nick Clemens <nick at bywatersolutions.com> ---
Doesn't apply, please remove unused function in comment 186

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:09:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:09:56 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 search fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-jB5dembea8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111567|0                           |1
        is obsolete|                            |

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124759&action=edit
Bug 24720: Strip special chars from sort fields

Strip all non alphanumerical characters from beginning
of sort field values so that sorting is performed on
the first alphanumeric character and not special characters
like "-" or "[".

To test:

1. Prepend "[" to the title of a biblio and save
2. Perform a search that matches this biblio and at least one
   more biblio.
3. Sort alphabetically a-z.
4. The biblio with "[" should appear first
5. Apply the patch
6. Perform a full reindexing
7. Perform steps 2-3 again
8. The result should now be alphabetically sorted,
   ignoring the initial bracket in the title.
9. Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:10:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:10:00 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 search fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-5hZT1ghjTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #10 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124760&action=edit
Bug 24720: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:21:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:21:34 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-mxGaZ6AC81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:21:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:21:38 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-O8fotFHGv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124758|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124761&action=edit
Bug 28985: Force positive numbers for itemtype charge fields

This patch adds a min attribute to the fields on this page and adds
other cost related fields to validator

To test:
1 - Apply patch
2 - Browse to Administration->Item types
3 - Edit or create an item type
4 - Attempt to place a negative or non numeric value in:
    Daily rental charge
    Hourly rental charge
    Default replacement cost
    Processing fee
5 - You should not be able to

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:38 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-9FYrhrIgeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:42 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-natpI7jSlX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124752|0                           |1
        is obsolete|                            |
 Attachment #124753|0                           |1
        is obsolete|                            |
 Attachment #124754|0                           |1
        is obsolete|                            |
 Attachment #124755|0                           |1
        is obsolete|                            |
 Attachment #124756|0                           |1
        is obsolete|                            |
 Attachment #124757|0                           |1
        is obsolete|                            |

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124762&action=edit
Bug 28870: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:46 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-KyV59VUDWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124763&action=edit
Bug 28870: Use Email::Address to validate email addresses

This patch adds a new dependency, Email::Address. It is used in
Koha::Email to replace the current use of Email::Valid, which proved to
be problematic when it comes to UTF-8 characters.

Email::Address provides suitable regexes that -when used- keep our
tests passing, but also deal better with UTF-8 data.

To test:
1. Apply the regression tests patch
2. Notice the only change is that it tweaks a couple addresses so they
   contain umlauts and also have the "Description <address>" format that
   is used when sending carts.
3. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> FAIL: Tests fail! Things die because Email::Valid doesn't like the
   from we passed.
4. Run:
   $ sudo apt install libemail-address-perl
5. Apply this patch
6. Repeat 3
=> SUCCESS: Tests pass!
7. Try what is described in comment 1
=> SUCCESS: Things are back to normal
8. Sign off :-D
9. Send cookies

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:50 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-dhaqqzT1zE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124764&action=edit
Bug 28870: Remove traces of Email::Valid

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:53 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-WbxEBq4k7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #37 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124765&action=edit
Bug 28870: Move email address validation to a specific class method

To ease testing and future changes if needed.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:45:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:45:59 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-AbaTmEsOIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124766&action=edit
Bug 28870: Use Email::Address->parse

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:46:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:46:04 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-NWSu08ivfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124767&action=edit
Bug 28870: non-FQDN addresses are valid

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:47:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:47:34 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 search fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-ZVRToJ4BZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #11 from David Gustafsson <glasklas at gmail.com> ---
(In reply to David Cook from comment #6)
> I will say though that my own manual texting of the regular expression looks
> good. 
> 
> I've plugged in English, French, and Chinese into my tests and it's all
> working as expected. (I tried Arabic as well and I think that worked too,
> although I imagine Séverine could confirm that better than me.)
> 
> If we can just get those automated unit tests to prove that, then I think
> we'd be good to go.

I added one simple test. I first attempted to test multiple variants with
different scripts but it turned out to be more effort than think is warranted
for this simple line of code. Firstly, since sort field are concatenated you
have to add multiple different fields with mappings for different strings to be
testable (since multiple values on same field are concatenated), no big deal
but is it really worth it? (Could break into separate method and test that, but
then we are missing out making sure it's actually called in
Koha::SearchEngine::Elasticsearch::marc_records_to_documents and don't get the
same coverage, and we would be creating a method just to be able to test this
piece of code in isolation, which if we where to be consistent and treat the
whole code-base this way would create a mess). I don't know if an issue with my
terminal/editor or something else, but when testing other scripts, like Chinese
I also get error messages like "UTF-8 "\xC3" does not map to Unicode at
/usr/share/perl5/MARC/File/Encode.pm line 35." before even reaching the regular
expression.

What we are testing is effectively be the trivial regular expression
"s/^\W+//u", that is to replace all non word unicode characters at the
beginning of the string with the empty string (remove them). I think the Perl
core implementation regarding separating word and non-word characters in
different scripts is not something that we should be writing tests for, I would
trust Perl in this case. But sure, to make sure we get to that piece of code,
and that the regexp does not do something completely unexpected doesn't hurt.

(In reply to Nick Clemens from comment #7)
> I agree with the ask for unit tests - they can be added to tests for
> marc_records_to_documents in t/db_dependent/Koha/SearchEngine/Elasticsearch.t
> 
> Additionally, I think this should be optional in search field configs:
> 1 - Title already has options for 'non-filing' characters - so if you want
> to ignore a leading '[' you can 
> 2 - Author names may contain real punctation, consider the band '!!!'
>     https://en.wikipedia.org/wiki/!!!

(In reply to David Cook from comment #8)
> Good point, Nick!
> 
> There's nothing more frustrating for a library user than the search not
> retrieving records that you know it has...

I made a mistake describing the bug as "Strip special chars from search
fields", so I can understand the confusion. It should be sort, not search
fields. I have corrected this in the commit message. This fix doesn't have any
impact on search fields so will not effect what is search on (the stripping of
special characters for search fields is already handled in Elastic). So the
band name '!!!' would still be searchable, but would probably have the same
sort weight as other strings containing only non-word characters, but this is
more of an edge case that will probably never have any major impact in real
life situations. To for example start allowing some special characters and not
others I think could be a potientially larger source of confusion, it's also
hard to know how to decide which characters should be exempted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:48:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:48:13 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-6Mq2WnodL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #26)
> (In reply to Jonathan Druart from comment #22)
> > Ulrich, can we get your signoff on those patches please?
> 
> We don't have a master environment we can test email functionality with
> right now. 

Just FYI - if your email account provides SMTP settings you can enter those in
the SMTP server configuration and use your email to test :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:49:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:49:38 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 search fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-OjKhrgpT5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:51:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:51:00 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 sort fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-hgvlsR4qSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove special characters   |Remove special characters
                   |from beginning of search    |from beginning of sort
                   |fields                      |fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:53:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:53:39 +0000
Subject: [Koha-bugs] [Bug 28997] New: Subscription table sorting in the opac
Message-ID: <bug-28997-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28997

            Bug ID: 28997
           Summary: Subscription table sorting in the opac
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: janet.mcgowan at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Similar to the issues reported in Bug 27934, the subscription table is not
sorting correctly.
In opac-detail.tt

<td class="publisheddate"><span title="[% latestserial.publisheddate | html
%]">[% latestserial.publisheddate | $KohaDates %]</span></td>
 <td class="planneddate"><span title="[% latestserial.planneddate | html %]">[%
latestserial.planneddate | $KohaDates %]</span></td>

If these lines are changed to use data-order instead as per:
<td data-order="[% reserveloo.waitingdate | html %]">[% reserveloo.waitingdate
| $KohaDates %]</td>
<td data-order="[% reserveloo.reservedate | html %]">[% reserveloo.reservedate
| $KohaDates %]</td>

they sort correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:56:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:56:14 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-egxfmbo23U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
The suggestion was to have a facultative and configurable list of sysprefs in
the config files. The sysprefs in this list couldn't be editable from the
interface (read-only).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 15:56:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 13:56:59 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 sort fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-UPw3nw1kSV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #12 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Nick Clemens from comment #7)
> ...
> Additionally, I think this should be optional in search field configs:
> 1 - Title already has options for 'non-filing' characters - so if you want
> to ignore a leading '[' you can
> ...

I forgot to address this. You are right that ideally marc-posts with initial
characters that should not be considered when sorting should have a proper
value for non-filing characters. In practice though when either have a large
collection of biblios, or do not have complete control over imported records
this becomes very cumbersome to handle since this value has to be correctly set
on each record. Also some fields which you might want to sort on don't have
this indicator available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 16:06:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 14:06:56 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-ai1gkf6gyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #5 from Donna <bwsdonna at gmail.com> ---
I apologize for my imprecise wording.  I would strongly oppose making this
change in which sys prefs could be configured from the user interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 16:41:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 14:41:19 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-xX1uDfWJKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+        my $allowlist = Koha::Library::Allowlist->new({ interface => 'opac'
})->load();

We should allow chaining then. IIRC load does not return self now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 16:59:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 14:59:14 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-agZKNSJ6HK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #4)
> The suggestion was to have a facultative and configurable list of sysprefs
> in the config files. The sysprefs in this list couldn't be editable from the
> interface (read-only).

To be precise, thats not my idea. See comment2. I would prefer to allow
changing this set of selected prefs by superlibrarian only.


(In reply to Donna from comment #5)
> I apologize for my imprecise wording.  I would strongly oppose making this
> change in which sys prefs could be configured from the user interface.

At least I dont understand it anymore now :) All sysprefs are now configured
via the UI. This report is about making a subset of these prefs read-only for
regular users (not superlibrarians).

Is that more clear?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:09:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:09:28 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-esUkvlFsxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:11:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:11:02 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-Uxs0gwGM34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:11:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:11:06 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-Np5scua7Id@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119903|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124768&action=edit
Bug 28022: Only show subfield "9" if subfield "a" is visible

Amend the workaround (from but 2206) to only show subfield "9" in editor if
subfield "a" has the editor-visibility bit set.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:14:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:14:28 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-IZWSywKU1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:15:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:15:55 +0000
Subject: [Koha-bugs] [Bug 28998] New: Encrypt borrowers.secret
Message-ID: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

            Bug ID: 28998
           Summary: Encrypt borrowers.secret
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We don't want the secret to be available from the reports admin and so we must
encrypt them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:16:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:16:18 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-O3BbiZNOeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28998
             Status|Failed QA                   |Signed Off

--- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This will be done on bug 28998.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998
[Bug 28998] Encrypt borrowers.secret
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:16:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:16:18 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-Af4G56Yviq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
[Bug 28786] Two-factor authentication for staff client - TOTP
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:17:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:17:44 +0000
Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra
 leading zeroes are reported not found
In-Reply-To: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20206-70-BCC602vpr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
I can't see any way we can get this in without at least a syspref or some other
way to make this optional. I'm also a bit concerned about the regex
performance, but the syspref should take care of that for anyone not using the
feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:25:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:25:18 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
 display partners in audit log
In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22531-70-1bN24gJWtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Applying: Bug 22531: Add logging & display of req partners
Applying: Bug 22531: Add unit tests
error: sha1 information is lacking or useless (Koha/Illrequest/Logger.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 22531: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:29:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:29:54 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-REsMFQ8xwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123401|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124770&action=edit
Bug 28786: Two-factor authentication for staff client - TOTP

This patchset introduces the Two-factor authentication (2FA) idea in
Koha.

It is far for complete, and only implement one way of doing it, but at
least it's a first step.
The idea here is to offer the librarian user the ability to
enable/disable 2FA when logging in to Koha.

It will use time-based, one-time passwords (TOTP) as the second factor,
an application to handle that will be required.

https://en.wikipedia.org/wiki/Time-based_One-Time_Password

More developements are possible on top of this:
* Send a notice (sms or email) with the code
* Force 2FA for librarians
* Implementation for OPAC
* WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/

Test plan:
 0.
  a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all
  b. To test this you will need an app to generate the TOTP token, you can
 use FreeOTP that is open source and easy to use.
 1. Turn on TwoFactorAuthentication
 2. Go to your account, click 'More' > 'Manage Two-Factor authentication'
 3. Click Enable, scan the QR code with the app, insert the pin code and
 register
 4. Your account now requires 2FA to login!
 5. Notice that you can browse until you logout
 6. Logout
 7. Enter the credential and the pincode provided by the app
 8. Logout
 9. Enter the credential, no pincode
10. Confirm that you are stuck on the second auth form (ie. you cannot
access other Koha pages)
11. Click logout => First login form
12. Enter the credential and the pincode provided by the app

Sponsored-by: Orex Digital

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:30:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:30:14 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Tgkj63wB73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123402|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124771&action=edit
Bug 28786: Improve readability in C4::Auth::checkauth

Sponsored-by: Orex Digital

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:30:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:30:31 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Jgid9vmXjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123403|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:31:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:31:04 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-N1CipSPGvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:31:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:31:08 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-QgCtYWd3Q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124772&action=edit
Bug 28998: Store encrypted secret

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:31:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:31:13 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-sgPTI7X743@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124773&action=edit
Bug 28998: Add encryption_key to the config file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:31:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:31:17 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-RU3xG8lD9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124774&action=edit
Bug 28998: Add Crypt::CBC dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:31:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:31:35 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-hefsdAidVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Sponsored-by: Orex Digital
      release notes|                            |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:32:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:32:29 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-BM5wI0QQSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How do we generate the new config entry on upgrade?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:38:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:38:57 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-aNv9FD3h8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:45:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:45:19 +0000
Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of
 fines in notices
In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13961-70-HUmjAzt36Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm wondering if this is really necessary given the solution provided by Josef.
If we implement this, it means adding yet another database query that will only
be used in a few cases.

That solution from Josef was:
---
[% USE Price %]

# your normal issue slip content

[% SET balance = borrower.account.balance %]
[% IF balance > 0 %]
Patron has debit of [% balance | $Price %].
[% END %]
[% IF balance < 0 %]
Patron has credit of [% balance | $Price %].
[% END %]
---

Is there a slip where this doesn't work? This functions on any slip with a
borrower object. If there is a slip where this doesn't work, it seems more
sensible to add the borrower object instead, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:47:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:47:45 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28785-70-wO2zNIJIKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123392|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124776&action=edit
Bug 28785: Centralize cookie auth check in check_cookie_auth

This code is duplicated in 3 different places, we must call
check_cookie_auth instead.

It makes check_cookie_auth returns a 'restricted' when
SessionRestrictionByIP is set and the IP changed.
It also returns a third parameters contained the old and new IP, to fill
the "info" hash in checkauth but apparently the oldip and newip
variables are not even used from the template. We may want to remove it
completely.

No change is expected with this patch, the different authentication
methods should still work as before.

Test plan:
Log in the staff and OPAC interfaces, logout.
Log in and call script that call the 3 different subroutines modified by
this patch. For instance you can list checkouts (that is using
check_cookie_auth) and display a patron's image (using check_api_auth).

QA with good knowledge of the C4::Auth module and the different
authentication methods is required.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:47:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:47:50 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28785-70-41OogCbjjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123393|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124777&action=edit
Bug 28785: Adjust check_cookie_auth calls

The previous patch makes check_cookie_auth return the session instead of
$sessionID, so we are adjusting the different calls to prevent
confusion.
However they are mainly used to check the authentication status and
don't care about this second variable.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:47:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:47:53 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28785-70-6y0s7b3daa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123394|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124778&action=edit
Bug 28785: Add skip_version_check for checkauth

We could have this patch but we also could decide to skip it. The idea
is to avoid 2 checks of the version when we are coming from checkauth.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:47:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:47:57 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28785-70-QDxAnXRa87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123395|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124779&action=edit
Bug 28785: Don't send SessionRestrictionByIP to template

It's not used.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 17:50:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 15:50:03 +0000
Subject: [Koha-bugs] [Bug 28785] Code in C4::Auth::checkauth is copy pasted
In-Reply-To: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28785-70-HDh2J4FT9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28785

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Always takes a while to wrap my brain around Auth again.. All seems solid in
testing and there's certainly a code improvement here.

Tests pass, QA script happy, QA person happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:05:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:05:12 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-Hj1DLqEr6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
QA looking here.

So far I'm reasonably happy. I think I would have prefered more isolation of
the verification step myself, but I can follow on with that in a follow-up bug.

So, personally, I would pass around a 'varified' state linked to the session
(as you do I believe). Then, for any get_template_and_user calls I'd have
checked the verification status and redirected to a self-contained verification
controller for the MFA check... rather than folding the check into Auth.pm and
the login pages themselves.  In this way you open up the option to invalidate
the verification without invalidating the session entirely for things like
patron modification for example (when we add this to the opac.. I can see it
being most helpful to not require the verification step at first login but
rather upon taking higher privilege actions).

Anywho.. I'll continue down the QA route but wanted to flag it in case you had
any feedback as to why you took this particular route rather than any others?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:06:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:06:47 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-4ED3UavFr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is looking great.. thanks for taking the time on it.. I'll swing back
round to this once I've completed working through the 2FA bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:08:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:08:24 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-ARkY4dYLcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:09:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:09:17 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-b2099w310g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:09:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:09:20 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-CIVhImxZnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121492|0                           |1
        is obsolete|                            |
 Attachment #121493|0                           |1
        is obsolete|                            |
 Attachment #121494|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124780&action=edit
Bug 27032: Remove unused variables

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:09:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:09:24 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-uFx8JRArRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
242722e99df77be9ce0e4c6d52ff402e0a77d604 might help with generating the random
key at koha-create.. need to dig out how we did it for upgrades

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:10:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:10:32 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-YBmrcX1MXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124781&action=edit
Bug 27032: Move auto renewal code out of CanBookBeRenewed

This moves the checks related to whether auto renewal can be done on
the checkout to its own function _CanBookBeAutoRenewed(). This makes
it more clear which parts of the code are related to auto renewal
checking and which are not.

To test:
  1) Make sure prove t/db_dependent/Circulation.t still passes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:10:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:10:35 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-gTnYWz1bpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124782&action=edit
Bug 27032: (follow-up) Pass rather than fetch variables

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:12:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:12:13 +0000
Subject: [Koha-bugs] [Bug 28799] Action logs should capture lost items found
In-Reply-To: <bug-28799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28799-70-cYMAKoNR6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:23:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:23:32 +0000
Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail
 pages to FA icon
In-Reply-To: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28993-70-MVVwDXR74G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:27:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:27:58 +0000
Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in
 value_builder/unimarc_field_4XX.pl
In-Reply-To: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28829-70-zhNMER82lV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 18:28:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 16:28:01 +0000
Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in
 value_builder/unimarc_field_4XX.pl
In-Reply-To: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28829-70-EB4cBoL8m7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123598|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124783&action=edit
Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl

Since Bug 23777 added To.json, single quote escaping in
value_builder/unimarc_field_4XX.pl is useless.

Test plan:
1) Use UNIMARC database
2) Define value builder unimarc_field_4XX on 463$t
3) Create a record B1 with 200$a : L'avion
4) Create a record B2
5) Click on value builder in 463$t
6) Search for record B1
7) Click on "Choose"
=> Without patch 463$t contains : L\'avion
=> With patch 463$t contains : L'avion

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 19:04:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 17:04:12 +0000
Subject: [Koha-bugs] [Bug 10035] Allow default hard due date by patron
 category
In-Reply-To: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10035-70-MATNkw0ZN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10035

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move or copy hard due date  |Allow default hard due date
                   |to be by patron category    |by patron category
                 CC|                            |andrew at bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm hijacking this old bug a bit. I propose that instead of removing hard due
dates from circ rules entirely we allow the definition of a default hard due
date per patron category. Ideally, each rule would allow one to either set a
date or select "category default."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 19:46:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 17:46:46 +0000
Subject: [Koha-bugs] [Bug 28999] New: Add module for Allowlist / ColumnFilter
Message-ID: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

            Bug ID: 28999
           Summary: Add module for Allowlist / ColumnFilter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Idea is to have a module that helps you filter columns of a certain table for
various use cases. Like checking parameters from user interface, or in the API,
etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 20:14:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 18:14:17 +0000
Subject: [Koha-bugs] [Bug 28740] Delete old ILL requests with
 cleanup_database
In-Reply-To: <bug-28740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28740-70-HxTfpZ5Ozm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28740

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 20:32:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 18:32:20 +0000
Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail
 pages to FA icon
In-Reply-To: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28993-70-6FT0ItTZCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I'd like to also replace the image on the authority detail page but I'm
confused by this section of the template (authorities/detail.tt):

[% IF ( subfiel.link ) %]
    <a class="authlink"
href="/cgi-bin/koha/catalogue/search.pl?op=do_search&amp;marclist=[%
subfiel.link | uri %]&amp;operator==&amp;type=intranet&amp;value=[%
subfiel.marc_value |url %]">
        <i class="fa fa-search" aria-label="Search on [% subfiel.marc_value |
html %]" title="Search on [% subfiel.marc_value | html %]"></i>
    </a>
[% END %]
[% IF ( subfiel.authority ) %]
    <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% subfiel.authority |
uri %]" class="button">Auth</a>
[% END %]

Are subfiel.link and subfiel.authority really relevant to an authority record?
I'm wondering if it's actually copy and paste from the MARC view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 21:08:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 19:08:40 +0000
Subject: [Koha-bugs] [Bug 25978] No branch is recorded for paypal payments
In-Reply-To: <bug-25978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25978-70-v0l1u1iiuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25978

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Moved to the plugin:

https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/issues/18

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 21:49:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 19:49:29 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-y9dIXAiRYY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 21:53:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 19:53:03 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-tHpznQAltp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I like the idea.
For example 'KohaAdminEmailAddress' change may change all emails to SPAM :(

For 'MarcFlavour' :
Is it even useful to have it in UI ? We could move it to 'local usage' like
'Version'. It will be defined only during install.

To add water in the mill :

I'd say if a preference is really system-related we should move it to
koha-conf.xml.
For example 'casServerUrl', it sounds system-related like LDAP authentication
that is in koha-conf.xml.
Idem for OPACBaseURL.

Plus add a list that only superlibrarians can edit, sort of super-preferences.

PS :
There is a trick actually to define a preference ready-only :
define it as overwritten in Apache config via 'OVERRIDE_SYSPREF_NAMES'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 21:55:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 19:55:55 +0000
Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra
 leading zeroes are reported not found
In-Reply-To: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20206-70-5JEbtVbsRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #20)
> I can't see any way we can get this in without at least a syspref or some
> other way to make this optional. I'm also a bit concerned about the regex
> performance, but the syspref should take care of that for anyone not using
> the feature.

My first impression would be to just leave it here. Perhaps a plugin. Not sure
for now. I wont add a pref probably. If there was more interest, people had
their chance since 2018..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:29:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:29:14 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-OeyXkxRmLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #18 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This bug is now even more relevant for security reasons

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:36:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:36:05 +0000
Subject: [Koha-bugs] [Bug 29000] New: Create a display of patrons with
 permissions
Message-ID: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

            Bug ID: 29000
           Summary: Create a display of patrons with permissions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Actually it is hard to find which patrons have which permissions.
It can lead to mistakes and security issues.

I've created a POC plugin :
https://github.com/biblibre/koha-plugin-users-with-permissions

Maybe permissions could be displayed in patrons search table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:36:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:36:12 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-lYsVLEErTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28991

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:36:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:36:12 +0000
Subject: [Koha-bugs] [Bug 28991] Setting user permissions should be limited
 by current user permissions
In-Reply-To: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28991-70-nFGj63TRax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28991

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29000

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:37:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:37:07 +0000
Subject: [Koha-bugs] [Bug 28989] Allow viewing systempreferences only
In-Reply-To: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28989-70-8TuTztAZmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Yep, this could be a new page with a datatable containing all preferences.
Maybe with a modal display for special content HTML,YAML ...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 22:52:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 20:52:37 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-Bvw2GbId3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
+1, this would be handy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 23:06:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 21:06:44 +0000
Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts
 (bor_issues_top.pl) is failing with MySQL 8
In-Reply-To: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28523-70-8LQ3b3v04O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

--- Comment #12 from David Nind <david at davidnind.com> ---
Currently getting this error when running Patrons with the most checkouts
report (using KTD started with ku and on master) - is the this the same issue
or something else?

CGI::Compile::ROOT::kohadevbox_koha_reports_bor_issues_top_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.borrowers.surname'
isn't in GROUP BY at /kohadevbox/koha/reports/bor_issues_top.pl line 63
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77

       74:     my $self = { msg => $msg };
       75:     bless $self => $class;
       76: 
       77:     die $self;
       78: }
       79: 
       80: =head2 rethrow

    Show function arguments
    in DBIx::Class::Schema::throw_exception at
/usr/share/perl5/DBIx/Class/Schema.pm line 1118

     1115:     };
     1116:   }
     1117: 
     1118:   DBIx::Class::Exception->throw($args[0], $self->stacktrace);
     1119: }
     1120: 
     1121: =head2 deploy

    Show function arguments
    in DBIx::Class::Storage::throw_exception at
/usr/share/perl5/DBIx/Class/Storage.pm line 113

      110:   my $self = shift;
      111: 
      112:   if (ref $self and $self->schema) {
      113:     $self->schema->throw_exception(@_);
      114:   }
      115:   else {
      116:     DBIx::Class::Exception->throw(@_);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 23:29:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 21:29:02 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-jFQ1DmxRES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 23:29:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 21:29:07 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-7srfZLtPvm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124658|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 124785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124785&action=edit
Bug 28949: Use Flatpickr on reports pages

This patch replaces the use of jQueryUI's datepicker on reports pages.

To test, apply the patch and test the following reports pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Acquisitions statistic wizard: Linked pairs of fields for
  "placed on" and "received on."
- Patrons with the most checkouts: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Patrons who haven't checked out: "Not checked out since"
  field.
- Cash register statistics wizard: Linked "From" and "To"
  fields.
- Most-circulated items: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Catalog statistics wizard: Linked pairs of fields for "Date acquired
  (item)" and "Date deleted (item)" The latter is shown by checking the
  "Count deleted items" radio button.
- View dictionary -> New definition:
  - Enter a definition name
  - Select table Circulation
  - Choose a date column, e.g. "Date of birth" or "Registration date"
  - Select "Date range"
    - Test that the "Start of date range" and "End of date range" fields
      are linked correctly.
- Create guided report:
  - Module: catalog
  - Type: Tabular
  - Select columns (any)
  - Select criteria to limit on: There should be three pairs of linked
    fields, "Creation date," "Modification date," and "Due date."
  - Confirm that the report is saved correctly with the dates you chose.
- Create from SQL -> Test a report with one or more date
  fields, e.g.
https://wiki.koha-community.org/wiki/SQL_Reports_Library#Items_added_by_Collection
- Average loan time: Linke pairs of fields for "Checkout
  date" and "Returns."
- Reports -> Circulation statistics wizard: Linked "Period" fields.
- Reports -> Holds statistics wizard: Linked pairs of fields "Hold
  date," "Notification date," "Reminder date," "Waiting date," and
  "Cancellation date."

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 10 23:41:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 21:41:52 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-07cmeF7YaE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Testing notes (koha-testing-docker):

- I mostly just tested that the date picker was working as expected,
particularly from to date ranges so that the to date can't be before the from
date
- Several reports are "broken" in master (KTD started with ku) - this may be
related to bug 28523 or something similar:
  . Patrons with the most checkouts
  . Most-circulated items
  . Patrons who haven't checked out
  . Items with no checkouts
  . Guided reports using grouped by (has error encountered message, rather than
a stack trace)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:04:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:04:50 +0000
Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
 other items and libraries
In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28642-70-dwIzHZoyzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122509|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:05:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:05:34 +0000
Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
 other items and libraries
In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28642-70-XfqGZoB1rL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642

--- Comment #3 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 124786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124786&action=edit
Fresh patch with test plan

Test Plan:

Apply patch and run koha-upgrade-schema or manually create
IndependentBranchesHideOtherBranchesItems system preference.
Login with an account that is not Super Librarian.
Set the IndependentBranchesHideOtherBranchesItems system preference to yes.
On the Item Search page observe that only your library shows in the home and
current library fields.
On the Advanced Search page observe that only your library shows in the
location -> individual libraries field.
Search the catalog for a title with an item at your library and also at another
library.
Observe that you only see your library listed in the facets panel (Refine your
search -> Home Libraries section)
Observe that you only see the item at your library in the search results, title
details, MARC details, Items, Checkout history, and Edit Items pages.
On the title details page Save the title as a text format, for example MARCXML,
and observe that only item(s) at your library are in the export.
On the Place hold page, search for a patron and observe that only patrons at
your library are found.
After selecting a patron observe that only items at your library are displaed.
In the Circulation -> Overdues page observe that you only see items at your
library.
In the Check out quick search search for patrons.  Observe that only patrons at
your school are found unless you search by cardnumber.
On the Patrons page observe that only your library shows in the library field
of the search form.
In the Search Patrons tab of the quick search click the '+' to open the other
fields.  Observe that only your library shows in the Library field.
On the Modify Patron page (edit patron) observe that only your library shows in
the library field in the library management section.
In Serials start a new subscription and observe that only your library shows in
the library field.
In Serials -> Check expiration observe that only your library show in the
library field.
In Reports observe that only your library shows in the following reports:
Acquisitions statistics, Patrons statistics, Catalog statistics, Circulation
statistics, Serials statistics, Cash register statistics, Holds statistics,
Patrons with the most checkouts, Most-circulated items, Items with no
checkouts, Items lost, Catalog by item type, Average loan time.
In Suggestions observe that only your library shows in the library field on the
Suggestion management and New purchase suggestion pages.
In Tools -> Patron Lists when adding patrons to a list observe that only
patrons at your library are found by name.
In Patron Clubs observe that the library field only shows your library in the
Club Template and Club edit pages.
In Comments observe that only comments at your library are shown.
In Import Patrons observe that the library field in the defaults section only
shows your library.
In Batch patron modification observe that your library is the only library in
the library field.
In Batch item modification observe that your library is the only library in the
Home and Current library fields.
In Export data observe that only your library shows in the 'With items owned by
the following libraries' field and it is selected.
In Inventory observe that only your library shows in the library field.
In News observe that only your library shows in the library field in the Filter
on the home page and the Edit entry page.
Open the Opac and log in.
On the Advanced search page observe that your library is the only library in
the Location field.
Search for a title with items at multiple libraries.  Observe that only your
library shows in the libraries facets (refine your search).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:05:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:05:43 +0000
Subject: [Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide
 other items and libraries
In-Reply-To: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28642-70-DfppHBApuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:19:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:19:24 +0000
Subject: [Koha-bugs] [Bug 28743] With IndependentBranches block changes to
 biblio records shared with other libraries
In-Reply-To: <bug-28743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28743-70-SGi4gJay9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #9 from Michael Hafen <michael.hafen at washk12.org> ---
The use case is that we have records with multiple libraries using the record,
but they can't see each other's items (because of a local patch) so they don't
know it's a shared record.  We came up with the hard lock as a way to prevent
libraries from changing records which other libraries are also using in that
case.

I'd be fine with recording the "first library to use a record" in the
biblio_metadata, or doing as the original patch does, which is to check if
other branches are using it.

And maybe it would be fine to go from this hard lock to just the warning (and
add that warning to the advanced editor too).  I can see wording such as
"Warning: this is a shared record and should not be changed with out consulting
the other libraries: [list of other libraries]".

That may be the optimum compromise here, taking out the hard lock, and having
that warning on the relevant pages.  I'd have to discuss it with my librarians,
but I don't think that will be a hard sell for most of them.

I welcome your thoughts on this idea as well, of course.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:19:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:19:41 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-c6nT1ejlOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:43:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:43:08 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-EaVyL77W8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123848|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:43:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:43:33 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-i9fcEAtas6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #2 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 124787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124787&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 00:50:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Sep 2021 22:50:00 +0000
Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts
 (bor_issues_top.pl) is failing with MySQL 8
In-Reply-To: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28523-70-Cie1966frZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hafen at washk12.org

--- Comment #13 from Michael Hafen <michael.hafen at washk12.org> ---
That is something else. The first line of the test plan states that there are
other problems with the script, this is the other problem.  In SQL Strict mode
the query failed the ONLY_FULL_GROUP_BY check.

I recently ran into that problem (and created a patch) on another report.

(In reply to David Nind from comment #12)
> Currently getting this error when running Patrons with the most checkouts
> report (using KTD started with ku and on master) - is the this the same
> issue or something else?
> 
> CGI::Compile::ROOT::kohadevbox_koha_reports_bor_issues_top_2epl::calculate():
> DBI Exception: DBD::mysql::st execute failed:
> 'koha_kohadev.borrowers.surname' isn't in GROUP BY at
> /kohadevbox/koha/reports/bor_issues_top.pl line 63
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
>     in DBIx::Class::Exception::throw at
> /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
>        74:     my $self = { msg => $msg };
>        75:     bless $self => $class;
>        76: 
>        77:     die $self;
>        78: }
>        79: 
>        80: =head2 rethrow
> 
>     Show function arguments
>     in DBIx::Class::Schema::throw_exception at
> /usr/share/perl5/DBIx/Class/Schema.pm line 1118
> 
>      1115:     };
>      1116:   }
>      1117: 
>      1118:   DBIx::Class::Exception->throw($args[0], $self->stacktrace);
>      1119: }
>      1120: 
>      1121: =head2 deploy
> 
>     Show function arguments
>     in DBIx::Class::Storage::throw_exception at
> /usr/share/perl5/DBIx/Class/Storage.pm line 113
> 
>       110:   my $self = shift;
>       111: 
>       112:   if (ref $self and $self->schema) {
>       113:     $self->schema->throw_exception(@_);
>       114:   }
>       115:   else {
>       116:     DBIx::Class::Exception->throw(@_);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 08:22:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 06:22:20 +0000
Subject: [Koha-bugs] [Bug 28436] Cache relatively static info that is used
 often and on many pages (instead of fetching from DB)
In-Reply-To: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28436-70-Lfh5OWxRos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28436

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to David Cook from comment #4)
> It would be more robust and more readable. 
> 
> Or if we wanted to persist the cache beyond the request-level we could use
> Koha::Cache, and rely on the staff interface for Libraries and Item Types to
> invalidate the cache. 
> 
> That would be even better. 
> 
> That Koha::Cache could also be placed in the respective modules and have
> something like Koha::ItemTypes->get_list() or whatever and have the specific
> module handle it's own caching logic. 
> 
> Lots of options which would be less hacky and more robust.

Indeed.
I think we should use Memcached for those datas, they are not often changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 08:57:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 06:57:46 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-pab4PUxF5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124788&action=edit
Bug 28959: (follow-up 2) Adjust more places in which 'category' was used

Some links still had category.

I propose we use explicit public=1 and public=0 when links to public/private
are side by side.
Otherwise whe just use /cgi-bin/koha/opac-shelves.pl?op=list using default
value 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:00:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:00:37 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-bx50cnbD9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I've added a followup 2, otherwise seems to work fine.

Maybe we could change in form :
"Category: Private/Public" with "Public: No/Yes"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:05:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:05:20 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7tRhVpLZ4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:29:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:29:47 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-quQ289laZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:29:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:29:51 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-Ybx9ZotmHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120176|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124789&action=edit
Bug 28228: Supress plugin related error message

Use of uninitialized value in subroutine entry at
/usr/share/koha/lib/Koha/Plugins/Base.pm line 182.

Test Plan:
1) Install the Kitchen Sink plugin ( it does not have a max versio defined )
2) Note the warning in your logs
3) Apply this patch
4) Restart all the things
5) No warning!

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:43:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:43:21 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-bLdjL4STsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:43:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:43:25 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-25K7y3FzNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123563|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124790&action=edit
Bug 28821: (follow-up) Improve operation of button plus/less

Follow-up for bug 28784.

Do not remove the op select on the first row.
Allow plus/less on all lines. Allow less until we have one line left.
Make sure that first op is disabled and hidden with plus/less.

Test plan:
Search on multiple indexes on advanced search.
Verify that plus/minus works as expected.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 09:44:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 07:44:42 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-RbQQzLSFBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Works fine.

Maybe we should also review staff interface search page.
There is actually no less button :-O

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 10:03:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 08:03:57 +0000
Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
In-Reply-To: <bug-27161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27161-70-t2vWV9g0hc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|In Discussion               |RESOLVED

--- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 28228 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 10:03:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 08:03:58 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-3ZIQ8zLuyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cornejo.alvaro at gmail.com

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
*** Bug 27161 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 10:03:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 08:03:58 +0000
Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25790-70-KeEQx7jm2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Bug 25790 depends on bug 27161, which changed state.

Bug 27161 Summary: Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 10:04:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 08:04:45 +0000
Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
In-Reply-To: <bug-27161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27161-70-ooV6CQKbQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161

--- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Alvaro Cornejo thanks a lot for your work, its continues on Bug 28228

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 12:25:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 10:25:42 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-kU2lElrKFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #19 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
This breaks the existing links in the format:

localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=&branch_group_limit=multibranchlimit-1&weight_search=1

i.e. where branch_group_limit is used. Let's not break the links suddenly as
they might be someone's bookmarks or shared online. So please fix the code in
opac/opac-search.pl to not produce multibranch query params from
branch_group_limit param and leave a note that branch_group_limit is deprecated
and should not be used.

The code I'm talking about is in the following if block:

> my $branch_group_limit = $cgi->param("branch_group_limit");
> if ( $branch_group_limit ) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 12:43:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 10:43:19 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-kLc8NnhfVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 12:43:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 10:43:23 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-l3r5IF3xMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123828|0                           |1
        is obsolete|                            |
 Attachment #124573|0                           |1
        is obsolete|                            |

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124791&action=edit
Bug 28845: Match against the full limit string, not just the group id

To test:
1 - Add to OPAC virtual host in apache conf:
   SetEnv OPAC_SEARCH_LIMIT branch:multibranch-1
   SetEnv OPAC_LIMIT_OVERRIDE 1
   RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT
branch:multibranchlimit-1"
   RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1"
2 - Enable system preference OpacAddMastheadLibraryPulldown
3 - Create a library group enabled as OPAC search group (or make sure existing
group 1 is an OPAC search group)
4 - Load the opac - dropdown does not pree-select the search group
5 - Apply patch
6 - Relaod opac - group is pre-selected!

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 12:43:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 10:43:27 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-nsuoMgati4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124792&action=edit
Bug 28845: (follow-up) Retain selection when using advanced search

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 12:43:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 10:43:48 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-0hxkz1boIZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 13:05:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 11:05:02 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-QBpv8ofM1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 13:05:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 11:05:06 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-hsK4vtWl3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124637|0                           |1
        is obsolete|                            |
 Attachment #124638|0                           |1
        is obsolete|                            |

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124793&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is an HTML customization, there is an HTML
tags with id="opacmainuserblock" and one with id="OpacMainUserBlock".

I think template block "koha_news_block" should add a class (lowercase) instead
of an id.
It fixes the bug and also it may be used several times in same page in the
future.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock"

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 13:05:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 11:05:09 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-tTpcwIudVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124794&action=edit
Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS

Actually this rule does nothing, it defines same background color as "body" :
#fcf9fc

Test plan :
1) Without patch look at OPAC header
2) With patch OPAC header should have same background color

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 13:05:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 11:05:45 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-0GGVeaDRm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Passing QA as Sally already signed this off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 13:12:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 11:12:28 +0000
Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation
 for request.pl
In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28782-70-bSpNQKX3bP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement
           Assignee|joonas.kylmala at helsinki.fi  |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 15:20:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 13:20:32 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-AuT35fYJVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
I don't see how this patch does anything, and thus unable to even reproduce the
problem. The problem should have been fixed already by "Bug 24361: (bug 24217
follow-up) Fix several warnings in C4 modules". Is the information about this
concering master branch correct?

The $metadata->{$_} part is false if it is undef so it should not proceed to
the next statement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 15:26:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 13:26:40 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-jjfraJBpYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 15:26:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 13:26:43 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-vRwSjG8MAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124789|0                           |1
        is obsolete|                            |

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124795&action=edit
Bug 28228: Supress plugin related error message

Use of uninitialized value in subroutine entry at
/usr/share/koha/lib/Koha/Plugins/Base.pm line 182.

Test Plan:
1) Install the Kitchen Sink plugin ( it does not have a max versio defined )
2) Note the warning in your logs
3) Apply this patch
4) Restart all the things
5) No warning!

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 15:27:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 13:27:54 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-DdhcUofIGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
It at least fixes the strings where they evaluate to false, like 0, so this is
still a good patch to take in but I don't see still how this fixes any
warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 15:51:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 13:51:53 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-2HDfCLJJok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #0)
> Somehow it got more complicated than required.

This report oversimplifies things?
Private lists include shared lists too.
Saying public Y/N implicitly may include the wrong message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:07:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:07:45 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-OaAqnH1fdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:07:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:07:48 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-MKnd4yz0UF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124718|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124796&action=edit
Bug 28986: Remove (All) notation to correctly select rule for editing

This patch updates the JS comparison code to remove the '(All)' hint before
comparing
to the current value

To test:
1 - Go to Administration -> Item types
2 - Edit a type to have a parent of another type
3 - Go to Administration -> Circulation and fines rules
4 - Add a rule for all categories for the child itemtype
5 - Add a rule for all categories for the parent itemtype
6 - Click edit on child type, note itemtype dropdown in editor correctly
selected
7 - Click edit on parent type - note itemtype dropdown menu refers to 'All'
itemtypes
8 - Apply patch
9 - Reload page and edit parent type rule
10 - Itemtype dropdown is correctly populated

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:12:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:12:24 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-zFjLVJdjWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Without refactoring the table logic here totally this looks like it is the best
least-effort-fix we can do right now. I wonder at what state the new GUI for
managing these circ rules is, the code here is very hacky and we cannot forever
do this sort of one off fixes. Anyway passing QA since as I said, this is
seemingly the best we can do right now without having the new editing page for
circ rules or doing total refactoring.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:16:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:16:18 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-tlV7cLN04U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:16:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:16:22 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-gQRaWrqxkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124797&action=edit
Bug 28847: (follow-up) Handle branch_group_limit

To test:
1 - Create a library group as an OPAC search group
2 - Enable OpacAddMastheadLibraryPulldown
3 - Browse to:
   
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=t&branch_group_limit=multibranchlimit-1&weight_search=1
4 - Confirm search works and returns correct results
5 - Confirm dropdown is correctly populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:21:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:21:45 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-GDmFkCXWqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:21:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:21:48 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-0WOLDOpAE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124761|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124798&action=edit
Bug 28985: Force positive numbers for itemtype charge fields

This patch adds a min attribute to the fields on this page and adds
other cost related fields to validator

To test:
1 - Apply patch
2 - Browse to Administration->Item types
3 - Edit or create an item type
4 - Attempt to place a negative or non numeric value in:
    Daily rental charge
    Hourly rental charge
    Default replacement cost
    Processing fee
5 - You should not be able to

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 17:22:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 15:22:29 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-ZBW48O1iDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:37:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:37:42 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-VwK7E5agL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:37:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:37:47 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-3IOiTT0BgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124622|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 124799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124799&action=edit
Bug 28959: Move category => public

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:37:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:37:52 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-UIVdQ5aFuv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124623|0                           |1
        is obsolete|                            |

--- Comment #14 from David Nind <david at davidnind.com> ---
Created attachment 124800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124800&action=edit
Bug 28959: DBIC update

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:37:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:37:58 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-rWvNfCJc0J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124624|0                           |1
        is obsolete|                            |

--- Comment #15 from David Nind <david at davidnind.com> ---
Created attachment 124801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124801&action=edit
Bug 28959: Add virtualshelves.public as a boolean

This patchset moves the 'category' attribute for virtual shelves, that
takes values of 1 and 2 (private and public respectively) into a boolean
for public.

The DBRev is trivial, and the changes to the code are as well.

To test:
1. have some known public and private lists
2. Apply this patches
3. Run:
   $ updatedatabase
=> SUCCESS: Public lists have public=1, private have public=0
4. Run:
   $ kshell
  k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Try the feature in staff and OPAC
=> SUCCESS: All good
6. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:38:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:38:02 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-n3oRbnSRfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124663|0                           |1
        is obsolete|                            |

--- Comment #16 from David Nind <david at davidnind.com> ---
Created attachment 124802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124802&action=edit
Bug 28959: (follow-up) Adjust all places in which 'category' was used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:38:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:38:08 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-adO9CGHjjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124788|0                           |1
        is obsolete|                            |

--- Comment #17 from David Nind <david at davidnind.com> ---
Created attachment 124803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124803&action=edit
Bug 28959: (follow-up 2) Adjust more places in which 'category' was used

Some links still had category.

I propose we use explicit public=1 and public=0 when links to public/private
are side by side.
Otherwise whe just use /cgi-bin/koha/opac-shelves.pl?op=list using default
value 0.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 11 22:46:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 20:46:41 +0000
Subject: [Koha-bugs] [Bug 28523] Patrons with the most checkouts
 (bor_issues_top.pl) is failing with MySQL 8
In-Reply-To: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28523-70-FfmzoDdhOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

--- Comment #14 from David Nind <david at davidnind.com> ---
Thanks Michael!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 00:36:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Sep 2021 22:36:34 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-3Tm8m9YStT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
I had a go at testing with koha-testing-docker (KTD), but was unable to get
this to work.

- KTD = started with ku
- Strict mode already set in /etc/koha/sites/kohadev/koha-conf.xml

Error before patch applied, no change after (with a flush_memcached and
restart_all):

CGI::Compile::ROOT::kohadevbox_koha_reports_cat_issues_top_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.biblio.title' isn't
in GROUP BY at /kohadevbox/koha/reports/cat_issues_top.pl line 64
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

I think I will leave the testing to someone who understands how this all works
a bit better than I do!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 07:35:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 05:35:59 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-pZgbPOmtgu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 07:36:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 05:36:03 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-oKzwpRuFPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124706|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 124804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124804&action=edit
Bug 28831: Database revision, add new preference

The preference OPACResultsUnavailableGroupingBy allows you to
group unavailable items by substatus, only showing item counts, on
the OPAC XSLT results.

This is meant to be useful for larger consortia.

Test plan:
Run dbrev.
Check new pref on Admin, preferences, OPAC tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 07:36:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 05:36:08 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-Zm04DZgFrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124707|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 124805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124805&action=edit
Bug 28831: Add choose/when, and change indentation

As a first step:
[1] Add the new pref OPACResultsUnavailableGroupingBy in the xslt,
    and pass it via C4/XSLT.
[2] Add a choose/when construction in the third part of Availability.
[3] Add indentation (8 spaces) of the inner block handling group by branch.

Test plan:
Make sure that OPACResultsUnavailableGroupingBy eq branch.
Verify that OPAC results are still untouched.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 07:36:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 05:36:12 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-YgSSmubtHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124708|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 124806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124806&action=edit
Bug 28831: Add the new group by substatus-block

Test plan:
Change OPACResultsUnavailableGroupingBy to substatus.
Verify the result on opac results. (You need a few unavailable items
with different statuses on a few branches.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 12:07:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 10:07:35 +0000
Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-LjpIqrGk3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
(In reply to Fridolin Somers from comment #8)
> Is it at least OK to change submit button "Login" to "Log in" ?

It is for the submit button (log in where it as an action (verb), for example:
Log in with your user id; login when you are referring to the details they use
(noun or adjective), for example: Your login details are <username> and
<password>, Enter your credentials in the login page.

https://wiki.koha-community.org/wiki/Terminology#L

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 13:23:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 11:23:43 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-890KpnBK7l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #18 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Marcel de Rooy from comment #12)
> (In reply to Tomás Cohen Arazi from comment #0)
> > Somehow it got more complicated than required.
> 
> This report oversimplifies things?
> Private lists include shared lists too.
> Saying public Y/N implicitly may include the wrong message.

This patch does not alter the message we are giving out, we already say before
this patch explicitly in the OPAC GUI whether a list is Public or not. So I
wouldn't take that into consideration whether to accept this patch or not. If
we want to use another naming it can be done even after this patch, this patch
doesn't make it any harder as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:00:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:00:53 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-8iLKA7he5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:00:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:00:59 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-k5vc6yYUaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124799|0                           |1
        is obsolete|                            |
 Attachment #124800|0                           |1
        is obsolete|                            |
 Attachment #124801|0                           |1
        is obsolete|                            |
 Attachment #124802|0                           |1
        is obsolete|                            |
 Attachment #124803|0                           |1
        is obsolete|                            |

--- Comment #19 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124807&action=edit
Bug 28959: Move category => public

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:01:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:01:04 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-Y9xOIyczu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #20 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124808&action=edit
Bug 28959: DBIC update

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:01:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:01:08 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-N2GXmIA7DU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #21 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124809&action=edit
Bug 28959: Add virtualshelves.public as a boolean

This patchset moves the 'category' attribute for virtual shelves, that
takes values of 1 and 2 (private and public respectively) into a boolean
for public.

The DBRev is trivial, and the changes to the code are as well.

To test:
1. have some known public and private lists
2. Apply this patches
3. Run:
   $ updatedatabase
=> SUCCESS: Public lists have public=1, private have public=0
4. Run:
   $ kshell
  k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Try the feature in staff and OPAC
=> SUCCESS: All good
6. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:01:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:01:14 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-p8KPPDQ0vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #22 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124810&action=edit
Bug 28959: (follow-up) Adjust all places in which 'category' was used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:01:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:01:21 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-dChkcuFFBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #23 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124811&action=edit
Bug 28959: (follow-up) Adjust more places in which 'category' was used

Some links still had category.

I propose we use explicit public=1 and public=0 when links to public/private
are side by side.
Otherwise whe just use /cgi-bin/koha/opac-shelves.pl?op=list using default
value 0.

Signed-off-by: David Nind <david at davidnind.com>
JK: Adjust commit title
Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:01:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:01:48 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-tkjWbLtfDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:36:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:36:53 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-lCsp0nJAS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Sorry for not doing very good job the first time reviewing, I found now
additional issue:

The buildQuery function in C4/Search.pm is modified by "Bug 28847: Move
SearchLimitLibrary code to QueryBuilder Modules", it however leaves dead code
in the else section "if ($this_limit =~ /^branch:(.+)/) {". That should be
completely removed, and also we can see from that that the new regex condition
added doesn't match as carefully the limit parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:45:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:45:31 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-11qSvHuzUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:46:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:46:02 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-7zCAUhF0g8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 14:46:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 12:46:06 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-MStyMyl4yh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124726|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124812&action=edit
Bug 28992: Resolve warning on BIG_LOOP

Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
addbiblio.tt line 896.

Came across it when testing 28608. Could have been a QA follow-up.

Test plan:
If you run QA tools on this patch, you should see the warning only
when processing files before patches.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:13:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:13:46 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-HxNfNtFGiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:13:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:13:50 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-Uj3xuknIC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124653|0                           |1
        is obsolete|                            |

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124813&action=edit
Bug 21093: In additem.pl set the right stickyduedate for fast add

To test:
-1 Set the specify due date option to a date, don't check the checkbox
-2 Enter an unknown barcode
-3 Click on fast add
-4 Add a record
-5 Add an item (don't change the barcode!)
-6 The item is checked out to the patron
-7 Verify: The checkbox is "Remember for session" is checked now
-8 APPLY patch
-9 Do steps 1-6 again, this time "Remember for session" should be unchecked
-10 Do steps 1-6 again but this time do check the "Remember for session"
checkbox.
-11 It should be properly checked

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:14:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:14:20 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-0vuu21ym5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:52:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:52:55 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-1Che2s1GXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:53:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:53:44 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-iYeTBjaKgX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:53:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:53:48 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-ImZYmcN1Gv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122346|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124814&action=edit
Bug 28356: Consolidate catalogue search box code

To test:
1 - Apply patch
2 - Confirm searchign the catalog works from:
    Administration->Budgets
    Cataloging
    Circulation->Check in
    Administration->Cities and towns
    Acquisitions->{Vendor}->Contracts
    Administration->Currencies
    Administration->Circulation desks (requires  UseCirculationDesks
preference)
    Home
    Tools->Notices and slips
    Patrons
    Adminstration
    Serials
    Acquisitions->Suggestions
    Administration->Z39.50/SRU servers

Signed-off-by: hakam <hakam at inlibro.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 15:54:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 13:54:16 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-3pwKPyDFz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Passing QA. Note: Administration->Cities and towns search was already broken
before this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:08:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:08:06 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-8FYI9nm7KW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Joonas Kylmälä from comment #18)

> This patch does not alter the message we are giving out, we already say
> before this patch explicitly in the OPAC GUI whether a list is Public or
> not. So I wouldn't take that into consideration whether to accept this patch
> or not. If we want to use another naming it can be done even after this
> patch, this patch doesn't make it any harder as far as I can tell.

So, we implicitly already have three categories. And some requests show that
people are still shaking the tree. Might extending categories solve that? Not
sure. But we choose to put that aside here and make it a boolean. I have no
strong arguments against it but just have the intuitive feeling that this may
not be the right direction :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:10:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:10:05 +0000
Subject: [Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item
 grouping on status only for large consortia
In-Reply-To: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28831-70-FTMHLdII7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Nind from comment #13)

> Signed-off-by: David Nind <david at davidnind.com>

Thanks David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:13:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:13:25 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-8BSa1EU8OG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:13:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:13:29 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-5kIvtg2Kpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123706|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124815&action=edit
Bug 28653: Add new method RefreshIssuesTable

On patrons check out or details page, after renewing
loans they don't sort correctly when clicking on "Date due"
tab. Page has to be reloaded so that sorting works.
This patch adds new method RefreshIssuesTable to
checkouts.js. When loans are renewed or checked in, issues
table is reloaded to and due dates are sorted correctly.

To test:
1. Add 3 loans for patron.
2. Change due dates so you they are e.g. 07/01, 07/02, 07/04
3. Make sure you have renewal period set e.g. 5 days and
check your RenewalPeriodBase syspref (I use current date there)
4. Renew loan with date due on 07/01, it should now be 07/07
5. Sort loans by date due
=> Note that order from top to bottom is 07/04->07/02->07/07
or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would
assume.
6. Apply patch and repeat.
=> Note that issues table is reloaded ("Loading..." pop-up is displayed)
and that due dates are in correct order.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: kelly <kelly at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:13:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:13:33 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-LTMF87BcgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 124816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124816&action=edit
Bug 28653: (QA follow-up) Remove debug message used during development

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:13:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:13:49 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-ywIPppobCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 16:14:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 14:14:06 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-N7HyLIEtGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 17:13:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 15:13:18 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-zfzlYmIiOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patches still apply, but something has been broken since my last test run.

What I did so far:

- Made sure master was current
- restart_all, ran database updates
- Applied patches, no conflicts
- restart_all again
- yarn build --view opac


1) Turned on Adlibris covers.

Instead of the covers, only a link shows in the result list and detail pages.

2) Additionally activated Google covers.

The covers show, but not within the lightbox display.

3) Added Amazon covers

Now I see up to 2 covers, but next to each other, still no lightbox.


Did a patch get lost here? :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 17:13:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 15:13:26 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-uLWxVqGWrp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 17:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 15:38:05 +0000
Subject: [Koha-bugs] [Bug 29001] New: Subfields attributes are not preserved
 when order is changed in framework
Message-ID: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

            Bug ID: 29001
           Summary: Subfields attributes are not preserved when order is
                    changed in framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Bug 8976 adds the ability to change the default order of the subfields in MARC
framework. But it does not preserve the Repeatable or Mandatory attribute. ​

To test : in a MARC framework, define a subfield as Mandatory. Move the
subfield to an other position within the field. The Mandatory flag for that
subfield is not preserved. Instead, the subfield occupying the same position is
flaged as Mandatory. 

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 18:24:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 16:24:12 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-9Ym0StN5Ev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 18:24:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 16:24:36 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-KLd7kDNeYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124720|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 124817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124817&action=edit
Bug 28988: Reindent calendar template

This patch performs general template cleanup to the calendar template:
Make indentation consistent and trim trailing whitespace.

To test, apply the patch and go to Tools -> Calendar.

The page should look correct and work correctly. If you view the diff
while ignoring whitespace the only changes should be where line breaks
were introduced.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 18:24:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 16:24:51 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-wv69WudMKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124721|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 124818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124818&action=edit
Bug 29899: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

https://bugs.koha-community.org/show_bug.cgi?id=28988

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 12 23:30:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 21:30:14 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-8qegwpGGoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I later realized that this was not meant to change results, but only the
detail page. Previous comments apply to the results list.

On the detail page for me none of the 3 mentioned cover services covers show :(

Example: search for "perl" > Programming Perl
- 2 covers and the adlibris link on results
- no cover at all on detail page

Switch back to master, git stash, restart_all:
- Adlibris still broken on results
- covers show on results and detail page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 00:09:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 22:09:25 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-uz5REJ4UO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124819&action=edit
Bug 28180: Fix bug with AdLibris

If Adlibris is first and there is no image

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 00:13:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 22:13:10 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-Q3TaVw5cSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hi Katrin, thanks!
You found a bug in a very specific combination. AdLibris is loaded first but
there is no image there (is the service broken currently?).
The code copied from staff is broken. As we have much more cover services OPAC
side the bugs are easier to catch.
I think this last patch is improving the situation but I cannot guarantee it
will always work.
To be honest I've always tested with local cover images (as it's why this
enhancement has been sponsored), and it was always working when a cover image
is attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 01:17:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 23:17:51 +0000
Subject: [Koha-bugs] [Bug 28989] Allow viewing systempreferences only
In-Reply-To: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28989-70-vxZpyAMIaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 01:43:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 23:43:22 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-uFn0PzQh2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #7)
> To add water in the mill :
> 
> I'd say if a preference is really system-related we should move it to
> koha-conf.xml.
> For example 'casServerUrl', it sounds system-related like LDAP
> authentication that is in koha-conf.xml.
> Idem for OPACBaseURL.

That's interesting.

On one hand, Donna makes the point that a library might not always have a
sysadmin available to make those changes via the CLI, so having them editable
by web UI is ideal. (From a deployment point of view, it might be nicer at
times to just make a data change via normal user activity in the UI rather than
needing to do a full deployment.)

On the other hand, as a vendor, there are times where I want to prevent all
library staff users (including superlibrarians) from making certain changes, as
they can break the system, make the system insecure, etc. 

--

What if we could add functionality for a sysadmin to lock system preferences
with all sysprefs defaulted to unlocked?

We could add a "locked" or "readonly" column to the systempreferences table. We
could then have a little CLI script for locking/unlocking system preferences,
setting system preference values.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 01:48:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 23:48:25 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-G5kcPYhYw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
My above idea would actually flow into another idea I've had for "hardening"
Koha instances.

Many of Koha's defaults are quite open and flexible, which makes it easy for
anyone to use Koha. But I suspect many vendors would like to apply certain
rules that make the Koha instance more secure. Originally, I was thinking about
installation "profiles", which could be invoked by koha-create, but maybe a
post-installation script would be easier/more flexible.

While I haven't used it myself, I've been thinking about the "jboss-cli" tool
that comes with the Java server JBOSS AS/Wildfly. I encountered it most
recently with Keycloak:
https://www.keycloak.org/docs/latest/server_installation/#_start_cli

It lets you set configuration with a script. I like the idea of a
"secure_koha.cli" or "vendor_profile.cli" script that you could run. A sysadmin
could lock down certain system preferences, set certain values for
authentication servers, email addresses, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 01:52:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 23:52:29 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-5iakuFb2Wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
I actually wrote a simple PHP script to do this about 10 years ago, as a
library needed to be able to easily audit user permissions, and I've been
meaning to convert it into Perl... but it looks like you've saved me the
hassle!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 01:55:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Sep 2021 23:55:51 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-8ulnKHUnGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I have it in the Tools module with the label "User Audit", but I suppose it
should be in the "Patrons" module? Maybe next to "Patron lists" we could have a
"Permission audit" or "Permission review" button?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 02:35:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 00:35:30 +0000
Subject: [Koha-bugs] [Bug 27432] Add report run to action logs
In-Reply-To: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27432-70-299X9a8x4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
I would love to see this get through. What do we need to do to push this along?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 02:50:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 00:50:32 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-8HBe40Zi5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 04:32:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 02:32:06 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-uNXnL8lxZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #10)
> I think we need more work here to provide
> for 'read' and 'write' allowlists.. we also need a way to alter the
> allowlist from the Koha object when required as with the load time at
> to_api here we currently have no way to pass overrides to the allowlist.

I think that we've overloaded the allow list concept. I originally came up with
the allow list concept to function as a user input validation allow/valid list
rather than an attribute-based access control list. 

I like attribute-based access control, but it might make more sense to start
there and then do the input validation rather than going the other way around.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 06:56:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 04:56:42 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-E9saOLCfoV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
For a while, I've been fantasizing about an RBAC or ABAC permission system, but
I think modernizing Koha's AuthZ might be an insurmountable task. 

I like the idea of groups too. Administrators, Cataloguers, and Circulation as
three out-of-the-box groups with default permissions set. Rather than setting
permissions for individual users, the average library might just assign users
to groups and manage permissions at the group level. 

I think someone needs to do something (although it's not going to be me).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:00:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:00:48 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-uTYOxwFqJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #12)

> I think that we've overloaded the allow list concept. I originally came up
> with the allow list concept to function as a user input validation
> allow/valid list rather than an attribute-based access control list. 

I am submitting shortly a generic AllowList and a Koha::Object::ColumnSet
proposal on bug 28999.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:08:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:08:05 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-PH9wa7oSZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:15:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:15:33 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-XU2B3joE44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124820&action=edit
Bug 28999: Introduce Allowlist

Based on work of David Cook and Jonathan Druart.
Removed the patron example here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:15:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:15:37 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-nG0PmGWGp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124821&action=edit
Bug 28999: Rename to AllowList

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:15:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:15:40 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-Zzh0bR09uw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124822&action=edit
Bug 28999: Additional check method, some parameter changes

License for module.
Remove interface parameter in new.
Add dry_run parameter to apply.
Add arrayref as input for apply.
Add check as shortcut for apply with dry_run.
Add tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:15:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:15:44 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-vnuSj6PG2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124823&action=edit
Bug 28999: Remove (un)load, add reset; apply returns result now

Remove load but add $defaults in new.
Replace unload by reset, restoring defaults.
Replace warn en verbose by a dump variable in apply.
Do not return $blocked anymore but return the filtered input in apply.
New check method returns true when no entries were blocked.
New keys method to list current allow list entries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:15:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:15:47 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-mGPsJ89uzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124824&action=edit
Bug 28999: Add Koha::DenyList as counterpart

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:17:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:17:55 +0000
Subject: [Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-24vJjS3Par@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:18:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:18:37 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-Ga01UUva77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add module for Allowlist /  |Add Koha::AllowList,
                   |ColumnFilter                |DenyList and
                   |                            |Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:27:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:27:01 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-BzDI2NMC3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The code for AllowList is generic now. But we need the ColumnSet to apply it to
Koha objects in various ways.


This is the idea:

Say $city is a Koha object.
$city->filter('opac_ui') returns city data through the opac_ui filter which is
just a set of columns for some purpose.
$city->filter('staff') could return some other subset or even nothing when the
set does not exist.

The sub filter calls Koha::Object::ColumnSet with the requested column set
name. The module calls the corresponding DBIx schema where we add a sub called
column_set_info containing the lists we need like a list for opac_ui.
ColumnSet runs a Koha::AllowList based on that list over the object data.

Hang on a little bit. Submitting some concept code shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 08:49:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 06:49:44 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-fuKFEgG1o9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
I spent a lot of time thinking this morning, and I'm not sure I see a purpose
for filtering outbound data besides for the public API. 

And on the flipside the API has its own input validation so it wouldn't need an
inbound data filter whereas the HTML UI does. 

I just wonder if we're trying to make this all too generic/comprehensive. The
original premise was just filtering input from HTML forms. 

Maybe it makes more sense to do a RFC? I think this might be the 3rd or 4th
report now for allow lists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:17:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:17:37 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-MlibQMDYRV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #41 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
We are currently working on upcoming version update and have decided to ditch
this floating matrix feature. Instead we've decided use float groups which work
like hold groups introduced in bug 22284.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:17:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:17:53 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-sHBE1AlgXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |emmi.takkinen at koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:18:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:18:53 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-QDpnV0KCBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40102|0                           |1
        is obsolete|                            |
  Attachment #40103|0                           |1
        is obsolete|                            |
 Attachment #112550|0                           |1
        is obsolete|                            |
 Attachment #112551|0                           |1
        is obsolete|                            |
 Attachment #112552|0                           |1
        is obsolete|                            |
 Attachment #112553|0                           |1
        is obsolete|                            |

--- Comment #42 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124825&action=edit
Bug 9525: Add ft_local_float_group column

This patch adds new ft_local_float_group column
to library_groups table.

To test:
1. Apply patch and update database
2. Confirm new column is added correctly to the
library_groups table

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:19:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:19:25 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-NES2JB7Ojq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #43 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124826&action=edit
Bug 9525: DO NOT PUSH! Schema update

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:20:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:20:00 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-qQ8YzvQbYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

--- Comment #44 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124827&action=edit
Bug 9525: Add option to define float groups and rules for float

Bug 22284 introduced ability to create hold groups.
We should have ability to create float groups in
same manner. This patch adds checkbox "Is local
float group" to group creation feature and new return
policy "Item floats by librarygroup".

To test:
1. Add new float group and some libraries to it.
2. From circulation and fine rules, set default
return policy as "Item floats by library group".
3. Check out an item for a patron.
4. Set library as one that belongs in the same
float group.
5. Check in the item.
=> Observe that notice for transfer doesn't pop up.
6. Check out again.
7. This time set library as one that doen's
belong in the same float group.
8. Check in.
=> Observe that notice for transfer pops up.

Experiment this feature by changing return policy
per library, item type etc.

Also prove t/db_dependent/Koha/Libraries.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:22:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:22:23 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-evFkhcyiKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
         Depends on|13906, 13995                |

--- Comment #45 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Attached new patches, removed dependencies on bug 13906 and bug 13995.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906
[Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object
creation from HASHes or from preconfigured test groups.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:22:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:22:23 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-kx8q70HxVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9525                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
[Bug 9525] group floating rules
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 09:22:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 07:22:23 +0000
Subject: [Koha-bugs] [Bug 13995] Proper Exception handling
In-Reply-To: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13995-70-9qPZEOyU51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9525                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525
[Bug 9525] group floating rules
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:05:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:05:45 +0000
Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules
 for float
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-1lnTbQPwPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|group floating rules        |Add option to define float
                   |                            |groups and rules for float

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:06:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:06:37 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-v3vkfw33bA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124828&action=edit
Bug 28999: {CONCEPT] Introduce Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:08:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:08:10 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-tQru4yXIPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please add feedback on especially the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:45:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:45:23 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-sgiXkG1EQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124744|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 124744
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124744
Bug 28762: (QA follow-up) A first attempt to sync the includes

Coming here again, I think we are asking too much when insisting on a synced
item status include. So I am obsoleting this follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:55:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:55:18 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-sOjyuyt84K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
So from this perspective looking at a new include, I see things like:

[% IF item.isa('Koha::Item') %]
..
[% IF NOT ( item.isa('Koha::Item') ) AND item.transfertwhen %]

Which is awful. Yes, I know that it comes from the opac include, but we should
really solve its twisted usage.

When we are starting at staff here, please use one consistent approach. Either
always pass a Koha object, or do something else. But keep it consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 10:55:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 08:55:50 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-ILwFVZ27fO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing status for comment17 and comment20

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:17:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:17:59 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-bv4UhfSMTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please, keep in mind that the API already has input/output validation,
specified in the OpenAPI spec. That's why this dev was originally simple and
only included a list of attributes for the 'public' context. Also, this allowed
for easy implementation of calculated lists: frameworks telling what item
structure to hide? Sysprefs?

Also, keep in mind that public and staff are not the only representations we
might want for resources: we could have a 'brief' representation to be used in
dropdowns (id+name). I mention it, because that's where the simplicity came
from.

For what is worth, I think we should do

use base wq(Koha::Object Koha::Object::AllowList)

And have AllowList just read the library's defined lists... I mean not
implementing a new AllowList class for each thing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:20:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:20:28 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-xb5SaqG0kB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124829&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:22:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:22:33 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-6T8GwSxkTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
My final patch is an alternative to Jonathans.. it tries to improve the
feedback given to the end user by embedding the parameter that failed
validation into the error code and then adding this to the template output.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:22:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:22:42 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-OIk0l7KXyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124746|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:31:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:31:43 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-KngVl4HuMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+package Koha::Auth::TwoFactorAuth;
+=head1 NAME
+
+Koha::Encryption - Koha class to encrypt or decrypt strings

Hmm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:37:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:37:50 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-CgwAStg9Q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #14)
> And have AllowList just read the library's defined lists... I mean not
> implementing a new AllowList class for each thing

Bug 28999 centralizes attributes lists in the schema file for the table. In the
ColumnSet concept.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:44:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:44:19 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-dZCRgFONKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Template process failed: undef error - The method Koha::Patron->auth_method is
not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 11:46:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 09:46:16 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-ZdwzyVbwtL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #35)
> Template process failed: undef error - The method Koha::Patron->auth_method
> is not covered by tests!

No DBIx schema change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 12:37:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 10:37:20 +0000
Subject: [Koha-bugs] [Bug 24718] Introduce hour-based holds
In-Reply-To: <bug-24718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24718-70-TI1hwNqlgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This looks interesting.. could we get a rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 12:54:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 10:54:51 +0000
Subject: [Koha-bugs] [Bug 29002] New: Add ability to book items ahead of time
Message-ID: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

            Bug ID: 29002
           Summary: Add ability to book items ahead of time
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Normal loans allow a patron to pick an item and take it out immediately.

Reserves allow a patron to add themselves to a queue for the item should it
already be checked out to someone.

We have a library that wishes to allow patrons to book items for a specific
date and loan period and have the item guaranteed to be available to them for
that period.

This bug intends to introduce that functionality, adding a bookable option to
items and exposing a calendar with bookable loan slots.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 12:54:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 10:54:56 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-6lr0F7APLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 12:55:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 10:55:41 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-UXC3G2TfH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24718

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 12:55:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 10:55:41 +0000
Subject: [Koha-bugs] [Bug 24718] Introduce hour-based holds
In-Reply-To: <bug-24718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24718-70-8X5NFTWbFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29002

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:15:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:15:11 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-yiTwzQ5WQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:15:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:15:14 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-zjDgAJ0rrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124322|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124830&action=edit
Bug 28934: Correct markup of GDPR consent in OPAC patron entry

This patch makes changes to the markup around the GDPR consent checkbox
in the OPAC self-registration / update page to make it more consistent
with other form fields on the page.

The patch also adds some missing attributes which are required to enable
JavaScript validation of the checkbox.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and Enable the system
  preference PatronSelfRegistration.
- Set the system preference GDPR_Policy to "Enforce".
- Go to the OPAC and click the "Register here" link.
- Under the "GDPR consent" heading near the bottom of the page,
  confirm that the "I agree" checkbox lines up with other form fields on
  the page, and that the "Required" label lines up below it.
- Submit the form without checking the GDPR consent checkbox.
- The form should not be submitted, and a "This field is
  required" message should appear next to the checkbox label.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:25:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:25:26 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-HIvSGgWLvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:44:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:44:31 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-14wKmANrq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #1 from Donna <bwsdonna at gmail.com> ---
I think this is a great idea, and I have had other libraries ask about being
able to do this.  It will be well received!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:55:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:55:40 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-uB68GTEPbB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 13:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 11:55:43 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-KhqaZuU6yz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124831&action=edit
Bug 28847: Remove dead code and make regex consistent

This updates the regex code to match throughout the routine and removes
code that would no longer be reached.

Note that the code to update library name in the query descruiption was
broken before this patch, so removal does not change behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:05:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:05:56 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-geYVONl0ka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Not a complete QA, but at least some remarks:

Nice development! Would like to see 2FA in Koha.

There was discussion about moving the secret to another table. I tend to follow
Tomas here. Two factor authentication now only includes TOTP, but we could
extend that. If we have several methods, they would (probably) have their own
secrets. So yes a separate table would be better.

In terms of security I wonder if we should let the user choose to enable 2FA.
If the library switches 2FA on, I would opt for enforcing it. How would you let
a user register at that point? Might be that you need some verification mail
mechanism here to allow access to the register page exposing the shared key
(QR).

As for code, Koha/Auth/TwoFactorAuth.pm should be a folder or base class. And
the TOTP code should move deeper then?
There is a Selenium test, but not a regular one?

The "Improve readability" patch triggers this remark ;) The code in C4::Auth is
very essential, but already a pain. The maintenance of it by adding the 2FA
will be even harder. No one volunteers to rewrite it, but wouldnt this be a
great opportunity? Just hoping.. The current changes with a nice "ugly trick"
are not the greatest base for confidence.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:36:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:36:46 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-hT3qioOqAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Is the last patch failing to apply for anyone else?

Applying: Bug 28803: (follow-up) Error details improvement
.git/rebase-apply/patch:71: trailing whitespace.
        Koha::Exceptions::BadParameter->throw({ parameter => $address, error =>
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 28803: (follow-up) Error details improvement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:48:14 +0000
Subject: [Koha-bugs] [Bug 29003] New: Apply different reasons via
 cancel_expired_holds cron based on found value
Message-ID: <bug-29003-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003

            Bug ID: 29003
           Summary: Apply different reasons via cancel_expired_holds cron
                    based on found value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 12656

Bug 12656 allows one to define a cancellation reason when running the
cancel_expired_holds cron. That reason is recorded for later reporting and also
triggers a notice.

That cron cancels both holds that have simply never had an item captured *and*
holds where the item has been waiting on the hold shelf past the pickup delay.
Ideally, we'd be able to tell the cron to apply two different reasons in these
two very distinct cases.

Maybe the cron could take a pair of [found value]=[reason]? So you could set it
with something like:
'W'='TOO_LONG'
NULL='UNFILLED'


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656
[Bug 12656] Allow a CANCELLATION_REASON to be specified on the
cancel_expired_holds.pl job
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:48:14 +0000
Subject: [Koha-bugs] [Bug 12656] Allow a CANCELLATION_REASON to be specified
 on the cancel_expired_holds.pl job
In-Reply-To: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12656-70-sFOvZ2OND0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29003


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003
[Bug 29003] Apply different reasons via cancel_expired_holds cron based on
found value
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:52:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:52:35 +0000
Subject: [Koha-bugs] [Bug 29003] Apply different reasons via
 cancel_expired_holds cron based on found value
In-Reply-To: <bug-29003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29003-70-UB73kIOEsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Actually, reiterating the importance of this a bit, if a library is using
ExpireReservesMaxPickUpDelayCharge then an auto-cancelled waiting hold will
result in a fee but an auto-cancelled non-waiting hold will not. That's not new
behavior or anything, but it definitely would be helpful to be able to easily
know that in the notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:58:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:58:59 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-DEw8VehBfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:59:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:59:06 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-N8KAudOoia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:59:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:59:30 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-QH3PL3wN52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:59:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:59:34 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-aGxfrNQlgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75542|0                           |1
        is obsolete|                            |
  Attachment #75543|0                           |1
        is obsolete|                            |
  Attachment #75544|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124834&action=edit
Bug 20813: Update db schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:59:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:59:47 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-1iKQL15E25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124835&action=edit
Bug 20813: Revamp user permissions system

Koha's current user permissions system is a bit convoluted and limited
due to it's legacy where the permissions system was a simple set of
flags. A second layer of sub-permissions were later added complication
and obfuscation to the system.

We should revamp the permissions system to be a more modern system and
open the path to having unlimited nesting of sub-permissions instead of
shoe-horning sub-permissions into the limited system we have.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Restart all the things!
4) Koha should still enforce user permissions as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 14:59:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 12:59:51 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-JZee2knl2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124836&action=edit
Bug 20813: Remove deleted table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:00:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:00:56 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-7YULFBRU4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Fridolin Somers from comment #18)
> This bug is now even more relevant for security reasons

Given that, I've rebased this patch set. I haven't tested it at all yet. Please
let me know if it any issue! Given the age of the patches, I think a fresh
sign-off is in order!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:30:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:30:36 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-vRCCGLNpko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28935

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:34:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:34:40 +0000
Subject: [Koha-bugs] [Bug 29004] New: Update GoogleOpenIDConnect preference
 to make it clear that it is OPAC-only
Message-ID: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

            Bug ID: 29004
           Summary: Update GoogleOpenIDConnect preference to make it clear
                    that it is OPAC-only
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 10988

GoogleOpenIDConnect and related system preferences only affect the OPAC, but
the system preference descriptions don't make that explicit. The description
should be modified to mention that it only applies to the OPAC.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:34:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:34:40 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
 Connect)
In-Reply-To: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-3DTKUsVmGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29004


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004
[Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is
OPAC-only
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:40:08 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-1rYvZv4tcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:40:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:40:11 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-F6DN0jNmJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124841&action=edit
Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is
OPAC-only

This patch modifies the description of the GoogleOpenIDConnect and
related preferences to make it clear that GoogleOpenIDConnect affects
OPAC logins and that the preferences are related.

To test, apply the patch and go to Administration -> System preferences.

Search for "google," and confirm that the descriptions of
GoogleOpenIDConnect and related preferences look clear and correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 15:40:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 13:40:50 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-VNvdIDpvvi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 16:03:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 14:03:19 +0000
Subject: [Koha-bugs] [Bug 29005] New: Add support for AutoEmailUser similar
 to AutoEmailOpacUser to patron imports
Message-ID: <bug-29005-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005

            Bug ID: 29005
           Summary: Add support for AutoEmailUser similar to
                    AutoEmailOpacUser to patron imports
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be helpful to add automatic email to users on patron imports.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 16:45:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 14:45:05 +0000
Subject: [Koha-bugs] [Bug 29006] New: Make GoogleOpenIDConnect options
 consistent in the OPAC
Message-ID: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

            Bug ID: 29006
           Summary: Make GoogleOpenIDConnect options consistent in the
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10988

In the OPAC, when GoogleOpenIDConnect is enabled, the login options are
inconsistent:

- The "Log in to your account" link in the header takes you straight to a
Google form.
- The login form on the main page doesn't offer a link to Google login, just
the standard login form.
- The login page offers both a GoogleOpenIDConnect link and a standard login
form.

If GoogleOpenIDConnect is enabled, all login options should offer both Google
and Koha login.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 16:45:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 14:45:05 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID
 Connect)
In-Reply-To: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-7uhMIPZUwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29006


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006
[Bug 29006] Make GoogleOpenIDConnect options consistent in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 17:39:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 15:39:54 +0000
Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call
In-Reply-To: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26635-70-azg62Y8889@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Started an API Users Guide on the Wiki:
https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 18:00:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 16:00:04 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-Wfb3gqc1Xe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 18:00:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 16:00:08 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-pluqmUPqXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124842&action=edit
Bug 28510: Remove unused variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 18:15:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 16:15:36 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-ZHUaiICZPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #2)
> Will it still be possible to print the whole queue over multiple pages?

Yes, you can choose the number of results per page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 18:51:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 16:51:33 +0000
Subject: [Koha-bugs] [Bug 29007] New: Prompt for reason when cancelling
 waiting hold via popup
Message-ID: <bug-29007-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007

            Bug ID: 29007
           Summary: Prompt for reason when cancelling waiting hold via
                    popup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 25534

To recreate:
- have a HOLD_CANCELLATION auth value
- have an item waiting for pickup for a hold
- check the item in, prompting the "item is already waiting" popup
- on that popup, select "Cancel"
- the hold is cancelled and you are not given a chance to apply a reason


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534
[Bug 25534] Add ability to specifying and store a reason when cancelling a hold
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 18:51:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 16:51:33 +0000
Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a
 reason when cancelling a hold
In-Reply-To: <bug-25534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25534-70-tWYHDgcv8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007
[Bug 29007] Prompt for reason when cancelling waiting hold via popup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 19:46:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 17:46:43 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-o5oQ8h8YOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #3 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to David Nind from comment #2)
> I had a go at testing with koha-testing-docker (KTD), but was unable to get
> this to work.
> 
> - KTD = started with ku
> - Strict mode already set in /etc/koha/sites/kohadev/koha-conf.xml
> 
> Error before patch applied, no change after (with a flush_memcached and
> restart_all):
> 
> CGI::Compile::ROOT::kohadevbox_koha_reports_cat_issues_top_2epl::calculate():
> DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.biblio.title'
> isn't in GROUP BY at /kohadevbox/koha/reports/cat_issues_top.pl line 64
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
> I think I will leave the testing to someone who understands how this all
> works a bit better than I do!

What options did you use to generate that error?  I'm not able to reproduce it.

I didn't test this report thoroughly, so I'm sure there is more work to be done
here.  Now that I'm playing with it a bit more the "distinct" is causing
trouble too with Mysql 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 19:59:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 17:59:17 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-0sDyTuGttE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 19:59:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 17:59:20 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-jcHenKpJ1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124415|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124843&action=edit
Bug 28940: In spinelabel-print.tt call IntranetUserJS only once

1. In IntranetUser add some JS that will target spinelabel-print.tt, I used
this:
    if ( $('#labels_spinelabel-print').length ) {
      $('#labels_spinelabel-print').append('<div>TEST</div>');
      console.log('TEST');
    }
2. Generate a quick spine label
3. Once you have entered a barcode the JS will go off 2x. With the jQuery added
you will see 2 div's with the word 'TEST'. Look at the console and you will
also see TEST console logged 2x.
4. Apply patch
5. Try seto 2 and 3 again, the JS should only be called once.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 21:53:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 19:53:08 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-egK7lWhJoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

--- Comment #4 from David Nind <david at davidnind.com> ---

> What options did you use to generate that error?  I'm not able to reproduce
> it.

This was with and without selecting any date ranges, 

With koha-testing-docker (started with ku) it is using MariaDB 10.1 with Debian
9.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:03:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:03:59 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-DYGpifdkiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Martin and Marcel, thank you for your interest in this patch set!

As you noted, C4::Auth is not an easy place, and we all know that. It was hard
to write code that followed the different "check auth" methods, I reworked the
code to make the code isolated enough to be located in only one place
(checkauth). And I wrote it, it was the best solution I found without having to
rewrite more parts.

There are more to implement but, as said in the commit message, the idea was to
provide a first step, without reworking the whole C4::Auth code.

I would like to get more funding to work on follow-up bugs, but as of today I
have already exploded the time I could dedicate to this bug.

(In reply to Martin Renvoize from comment #33)
> So, personally, I would pass around a 'varified' state linked to the session
> (as you do I believe). Then, for any get_template_and_user calls I'd have
> checked the verification status and redirected to a self-contained
> verification controller for the MFA check... rather than folding the check
> into Auth.pm and the login pages themselves.  In this way you open up the
> option to invalidate the verification without invalidating the session
> entirely for things like patron modification for example (when we add this
> to the opac.. I can see it being most helpful to not require the
> verification step at first login but rather upon taking higher privilege
> actions).
> 
> Anywho.. I'll continue down the QA route but wanted to flag it in case you
> had any feedback as to why you took this particular route rather than any
> others?

I don't follow what you suggest. A check in get_template_and_user is not
enough, we need to catch other auth calls as well.

(In reply to Marcel de Rooy from comment #37)
> There was discussion about moving the secret to another table. I tend to
> follow Tomas here. Two factor authentication now only includes TOTP, but we
> could extend that. If we have several methods, they would (probably) have
> their own secrets. So yes a separate table would be better.

IMO it's out of the scope. That would put this bug in a dead-end situation.

> In terms of security I wonder if we should let the user choose to enable
> 2FA. If the library switches 2FA on, I would opt for enforcing it. How would
> you let a user register at that point? Might be that you need some
> verification mail mechanism here to allow access to the register page
> exposing the shared key (QR).

It's part of the enhancement I suggested in the commit message :)
"* Force 2FA for librarians"

> As for code, Koha/Auth/TwoFactorAuth.pm should be a folder or base class.
> And the TOTP code should move deeper then?

It's a first step, no need to make it more complex. We can still create the
base class we will need it.

> There is a Selenium test, but not a regular one?

What tests would make you happy? I could add tests for
Koha::Auth::TwoFactorAuth but it's based on Auth::GoogleAuth and only overwrite
the constructor.
Or are you asking for C4::Auth::checkauth tests?

With selenium tests we are testing the whole workflow, they are robust and I am
very happy with them as they helped me a lot during the development process.

> The "Improve readability" patch triggers this remark ;) The code in C4::Auth
> is very essential, but already a pain. The maintenance of it by adding the
> 2FA will be even harder. No one volunteers to rewrite it, but wouldnt this
> be a great opportunity? Just hoping.. The current changes with a nice "ugly
> trick" are not the greatest base for confidence.

I am open to suggestions to improve the code I've added, and isolate more the
code. But I spent a lot of time and tried different approaches before ending
with that one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:04:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:04:14 +0000
Subject: [Koha-bugs] [Bug 26865] Double quotes in patron's data breaks
 patron searches
In-Reply-To: <bug-26865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26865-70-xcF4JZZzgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26865

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:06:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:06:25 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-D3hWm5tT3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124770|0                           |1
        is obsolete|                            |

--- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124844&action=edit
Bug 28786: Two-factor authentication for staff client - TOTP

This patchset introduces the Two-factor authentication (2FA) idea in
Koha.

It is far for complete, and only implement one way of doing it, but at
least it's a first step.
The idea here is to offer the librarian user the ability to
enable/disable 2FA when logging in to Koha.

It will use time-based, one-time passwords (TOTP) as the second factor,
an application to handle that will be required.

https://en.wikipedia.org/wiki/Time-based_One-Time_Password

More developements are possible on top of this:
* Send a notice (sms or email) with the code
* Force 2FA for librarians
* Implementation for OPAC
* WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/

Test plan:
 0.
  a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all
  b. To test this you will need an app to generate the TOTP token, you can
 use FreeOTP that is open source and easy to use.
 1. Turn on TwoFactorAuthentication
 2. Go to your account, click 'More' > 'Manage Two-Factor authentication'
 3. Click Enable, scan the QR code with the app, insert the pin code and
 register
 4. Your account now requires 2FA to login!
 5. Notice that you can browse until you logout
 6. Logout
 7. Enter the credential and the pincode provided by the app
 8. Logout
 9. Enter the credential, no pincode
10. Confirm that you are stuck on the second auth form (ie. you cannot
access other Koha pages)
11. Click logout => First login form
12. Enter the credential and the pincode provided by the app

Sponsored-by: Orex Digital

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:06:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:06:29 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-93mzwD1vKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124771|0                           |1
        is obsolete|                            |

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124845&action=edit
Bug 28786: Improve readability in C4::Auth::checkauth

Sponsored-by: Orex Digital

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:06:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:06:46 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-67hGV6nzQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #34)
> +package Koha::Auth::TwoFactorAuth;
> +=head1 NAME
> +
> +Koha::Encryption - Koha class to encrypt or decrypt strings
> 
> Hmm

Oops, fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:08:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:08:36 +0000
Subject: [Koha-bugs] [Bug 25825] Allow Claim Return function to be
 controlled by permissions
In-Reply-To: <bug-25825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25825-70-08AdA8loq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

--- Comment #5 from Rebecca Coert <rcoert at arlingtonva.us> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 22:13:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 20:13:34 +0000
Subject: [Koha-bugs] [Bug 27887] Patrons should not receive overdue notices
 for claimed returns
In-Reply-To: <bug-27887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27887-70-6GpMDNgdmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

--- Comment #1 from Rebecca Coert <rcoert at arlingtonva.us> ---
We would absolutely, 100% like to see this function.  Staff have told us that
they spend a lot of time discussing this with patrons, who are sometimes irate
for having us contact them regarding an item that they've already told us
they've RETURNED.  We search our locations several times for these items, and
receiving these notices creates extra work for everyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:21:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:21:07 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-0yRiRpTSTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124846&action=edit
Bug 28786: Correctly inherit from Auth::GoogleAuth

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:21:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:21:14 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-PB8QsP6q6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124847&action=edit
Bug 28786: Add tests for checkauth

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:49:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:49:41 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-Ldk1DILQUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Depends on|                            |28937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:49:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:49:41 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-YV1iuS2CYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:57:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:57:03 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-ynUc0bmNko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:57:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:57:07 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-Vf5KzJ91xe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124453|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 124848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124848&action=edit
Bug 28942: Use Flatpickr on acquisitions pages

This patch modifies several acquisitions pages replacing jQuery
datepickers with Flatpickr widgets.

To test, apply the patch and test datepickers on the following
Acquisitions pages:

 - Acquisitions -> Late orders (linked date fields in the sidebar)
 - Acquisitions -> Invoices (linked date fields in the sidebar)
 - Acquisitions -> Invoices -> Invoice details (shipment date and
   billing date)
 - Acquisitions -> Vendor -> Receive shipment (shipment date)
 - Acquisitions -> Vendor -> Receive shipment -> Receive (on order line)
   -> Date received field under "Accounting details
 - Acquisitions -> Orders search tab in the header -> Advanced search:
   Linked date fields in the search form."

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 13 23:58:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 21:58:59 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-BbKBTt04cZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Micheal,

I'm happy to test this if you could add a test plan.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 00:27:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 22:27:34 +0000
Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-EGTeg551BQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 00:27:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 22:27:38 +0000
Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-l3OQIfnT8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124063|0                           |1
        is obsolete|                            |
 Attachment #124064|0                           |1
        is obsolete|                            |
 Attachment #124065|0                           |1
        is obsolete|                            |

--- Comment #11 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 124849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124849&action=edit
Bug 27947: Add authorised values list in article requests cancellation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 00:27:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 22:27:43 +0000
Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-w8Vnl5Ucoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #12 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 124850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124850&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 00:27:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Sep 2021 22:27:48 +0000
Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-GPCWmqW8S2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #13 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 124851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124851&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:08:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:08:59 +0000
Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-vPlGfOBej2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Thanks for the info David :)

I mean here :
https://git.koha-community.org/Koha-community/Koha/src/commit/a5a3a330cfc7c7d6c35db13326745dabf8fe0df3/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt#L115
  <p class="submit"><input id="submit-button" type="submit" value="Login"
tabindex="4" /></p>

We must replace with "Log in" right ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:15:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:15:15 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-qZnFhxfdPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #25 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Marcel de Rooy from comment #24)
> (In reply to Joonas Kylmälä from comment #18)
> 
> > This patch does not alter the message we are giving out, we already say
> > before this patch explicitly in the OPAC GUI whether a list is Public or
> > not. So I wouldn't take that into consideration whether to accept this patch
> > or not. If we want to use another naming it can be done even after this
> > patch, this patch doesn't make it any harder as far as I can tell.
> 
> So, we implicitly already have three categories. And some requests show that
> people are still shaking the tree. Might extending categories solve that?
> Not sure. But we choose to put that aside here and make it a boolean. I have
> no strong arguments against it but just have the intuitive feeling that this
> may not be the right direction :)

I also had the feeling we could keep a place for a third value.
But the need here is for API routes to know if datas can be open to the public
or not. That is binary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:19:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:19:45 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-kmE8PHd0ep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
In my opinion storing security settings inside database is not good.
We often copy database from a production server to a test server, where
security is on purpose lower.
For me the best place is koha-conf.xml, it already contains major security
settings (authentication, path, ...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:25:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:25:11 +0000
Subject: [Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
In-Reply-To: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28959-70-TwD21K3axJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Fridolin Somers from comment #25)
> (In reply to Marcel de Rooy from comment #24)
> > (In reply to Joonas Kylmälä from comment #18)
> > 
> > > This patch does not alter the message we are giving out, we already say
> > > before this patch explicitly in the OPAC GUI whether a list is Public or
> > > not. So I wouldn't take that into consideration whether to accept this patch
> > > or not. If we want to use another naming it can be done even after this
> > > patch, this patch doesn't make it any harder as far as I can tell.
> > 
> > So, we implicitly already have three categories. And some requests show that
> > people are still shaking the tree. Might extending categories solve that?
> > Not sure. But we choose to put that aside here and make it a boolean. I have
> > no strong arguments against it but just have the intuitive feeling that this
> > may not be the right direction :)
> 
> I also had the feeling we could keep a place for a third value.
> But the need here is for API routes to know if datas can be open to the
> public or not. That is binary.

Isn't the fact that a list is shared just another boolean? What if we decided
to make lists shareable with specific patrons or categories? We need stop doing
things implicitly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:29:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:29:15 +0000
Subject: [Koha-bugs] [Bug 27432] Add report run to action logs
In-Reply-To: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27432-70-iCg6gRpyQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432

--- Comment #25 from Fridolin Somers <fridolin.somers at biblibre.com> ---
We need a unit test.
Maybe in t/db_dependent/Log.t.

Actually there are no test for other reports actions right ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 02:33:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 00:33:27 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-4jpSYelLOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to David Cook from comment #3)
> I have it in the Tools module with the label "User Audit", but I suppose it
> should be in the "Patrons" module? Maybe next to "Patron lists" we could
> have a "Permission audit" or "Permission review" button?

Yep.
Maybe a link "Patrons with permissions" ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 03:41:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 01:41:59 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-pGgm58Cops@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #10)
> In my opinion storing security settings inside database is not good.

I think it's arguable about whether an Identity Provider counts as a security
setting per se. Or are you referring to different settings?

> We often copy database from a production server to a test server, where
> security is on purpose lower.

That sounds like an internal problem? What's the risk that you're worried about
here? Data breach?

> For me the best place is koha-conf.xml, it already contains major security
> settings (authentication, path, ...)

As a vendor, I like storing things in configuration files (although I hate the
bloated koha-conf.xml), since they're more secure and easier to deploy
programmatically.

But as a consumer, we'd be removing functionality from Koha. I think that's the
point that Donna is making. Unless you have the wealth to pay for a vendor or
internal staff, you might not be able to configure those settings anymore. (Of
course, one could argue there are many settings in Koha that already work that
way.)

--

Ultimately, it doesn't matter to me, as I have power. I'm just thinking about
removing options from people who don't have as much power.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 03:56:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 01:56:02 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-i7gcQqvF9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #4)
> (In reply to David Cook from comment #3)
> > I have it in the Tools module with the label "User Audit", but I suppose it
> > should be in the "Patrons" module? Maybe next to "Patron lists" we could
> > have a "Permission audit" or "Permission review" button?
> 
> Yep.
> Maybe a link "Patrons with permissions" ;)

Well, all patrons have permissions though, even if it's minimal permissions.
That would also take up a lot of room on the screen on a Patrons toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 03:56:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 01:56:30 +0000
Subject: [Koha-bugs] [Bug 27432] Add report run to action logs
In-Reply-To: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27432-70-OpBL6sU8v4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432

--- Comment #26 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #25)
> We need a unit test.
> Maybe in t/db_dependent/Log.t.
> 
> Actually there are no test for other reports actions right ?

That's what I was wondering too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 05:37:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 03:37:05 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-n5IwbI7eQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 05:37:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 03:37:08 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-rlvUCgdn60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124830|0                           |1
        is obsolete|                            |

--- Comment #5 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 124852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124852&action=edit
Bug 28934: Correct markup of GDPR consent in OPAC patron entry

This patch makes changes to the markup around the GDPR consent checkbox
in the OPAC self-registration / update page to make it more consistent
with other form fields on the page.

The patch also adds some missing attributes which are required to enable
JavaScript validation of the checkbox.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and Enable the system
  preference PatronSelfRegistration.
- Set the system preference GDPR_Policy to "Enforce".
- Go to the OPAC and click the "Register here" link.
- Under the "GDPR consent" heading near the bottom of the page,
  confirm that the "I agree" checkbox lines up with other form fields on
  the page, and that the "Required" label lines up below it.
- Submit the form without checking the GDPR consent checkbox.
- The form should not be submitted, and a "This field is
  required" message should appear next to the checkbox label.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:25:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:25:39 +0000
Subject: [Koha-bugs] [Bug 29008] New: Avoid warning when checking Koha
 plugin version
Message-ID: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

            Bug ID: 29008
           Summary: Avoid warning when checking Koha plugin version
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In Koha plugins home page, each plugin min/max version is compared with actual
Koha version.

This uses metadatas assuming there are numbers, like 18.11 or 20.1100000.

But source code version is actually YY.MM.XX.YYY.ZZZ.
We sometimes find it in plugins, for examle :
https://github.com/thekesolutions/koha-plugin-bibliocommons/blob/c2da98f1bda450452ad687e5623f45939a967bdf/Koha/Plugin/Com/Theke/BiblioCommons.pm#L31
https://github.com/KohaSuomi/koha-plugin-sms-send-link-mobility-driver/blob/master/Koha/Plugin/Fi/KohaSuomi/SMSSendLinkMobilityDriver.pm#L22

This generates warning :
Argument "18.11.01" isn't numeric in numeric lt (<) at
/home/koha/src/Koha/Plugins/Base.pm line 377.: src/plugins/plugins-home.pl

We should allow this syntax in plugins metadatas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:25:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:25:47 +0000
Subject: [Koha-bugs] [Bug 29008] Avoid warning when checking Koha plugin
 version
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-Ejdkqb0Ns6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
[Bug 25790] [OMNIBUS] warnings removal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:25:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:25:47 +0000
Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25790-70-Iop8S6q4cS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008
[Bug 29008] Avoid warning when checking Koha plugin version
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:30:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:30:58 +0000
Subject: [Koha-bugs] [Bug 28990] Allow changes for a configurable subset of
 systempreferences by superlibrarian only
In-Reply-To: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28990-70-WJXV1Pyaix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Bug 28998 is introducing Koha::Encryption. I'd like to use it for sysprefs that
shouldn't be stored in plain text (credentials in mind).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:42:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:42:44 +0000
Subject: [Koha-bugs] [Bug 29008] Avoid warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-tMqVZZY3Us@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Avoid warning when checking |Avoid warning when checking
                   |Koha plugin version         |Koha version in plugins

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 08:43:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 06:43:14 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-42Ccaxni2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Avoid warning when checking |Warning when checking Koha
                   |Koha version in plugins     |version in plugins

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 09:45:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 07:45:31 +0000
Subject: [Koha-bugs] [Bug 29009] New: Attempting to Koha-restore shows
 unnecessary SQL error
Message-ID: <bug-29009-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29009

            Bug ID: 29009
           Summary: Attempting to Koha-restore shows unnecessary SQL error
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matthew.lindfield-seager at hope.edu.kh
        QA Contact: testopia at bugs.koha-community.org

`koha-restore` command outputs an error about being unable to drop the user:

`ERROR 1396 (HY000) at line 1: Operation DROP USER failed for
'koha_library'@'%'`

This can be avoided by adding `IF EXISTS` to the command (as has been done in
[`koha-remove`](https://github.com/Koha-Community/Koha/blob/a5a3a330cfc7c7d6c35db13326745dabf8fe0df3/debian/scripts/koha-remove#L69-70)

Tested on Ubuntu 20.04 LTS with Koha 21.05.02.003 and 21.05.03.001

N.B. This bug was originally filed as a [PR on
GitHub](https://github.com/Koha-Community/Koha/pull/42)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 09:48:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 07:48:07 +0000
Subject: [Koha-bugs] [Bug 29009] Attempting to Koha-restore shows
 unnecessary SQL error
In-Reply-To: <bug-29009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29009-70-zBTQ4MOu6r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29009

--- Comment #1 from Matthew LS <matthew.lindfield-seager at hope.edu.kh> ---
Created attachment 124853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124853&action=edit
Patch (from GitHub - https://github.com/Koha-Community/Koha/pull/42.patch)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 09:53:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 07:53:33 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-ujjdB8zWuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 09:53:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 07:53:48 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-GwUJFs9zMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124652|0                           |1
        is obsolete|                            |
                 CC|                            |emmi.takkinen at koha-suomi.fi

--- Comment #7 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124854&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 09:53:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 07:53:54 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-e93TT2uvNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 10:39:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 08:39:29 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-8jQpP1Czyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

--- Comment #4 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
I think this needs some improvement. I have over 600 holds on my list. I first
selected 10 rows per page and moved to page 3. Then I changed rows per page as
1000 assuming all holds would be displayed. Instead I got blank page. I had to
switch back to 10 rows per page, go to page 1 and then select 1000 per page to
see all of my holds. IMO it would be more user friendly to e.g. return to the
first page if rows per page is changed. Otherwise this works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:10:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:10:57 +0000
Subject: [Koha-bugs] [Bug 29010] New: weight input pattern wrong
Message-ID: <bug-29010-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010

            Bug ID: 29010
           Summary: weight input pattern wrong
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: domm at plix.at

search_field.weight is of type NUMERIC(5,2) in the database, and values are
rendered as floats in /admin/searchengine/elasticsearch/mappings.pl

But the field validation only accepts INTs:

<input type="text" inputmode="numeric" pattern="[0-9]*"
name="search_field_weight" value="[% search_field.weight | html %]" />

To fix this, change the regexp in patter as follows:

  pattern="[0-9\.]*"

I can supply a proper patch in a few minutes...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:19:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:19:31 +0000
Subject: [Koha-bugs] [Bug 29010] weight input pattern wrong
In-Reply-To: <bug-29010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29010-70-XZZAxa4ZMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010

--- Comment #1 from Thomas Klausner <domm at plix.at> ---
Created attachment 124855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124855&action=edit
Bug 29010: fix pattern in search_field.weight

search_field.weight is of type NUMERIC(5,2) in the database, and values
are rendered as floats in /admin/searchengine/elasticsearch/mappings.pl

But the field validation only accepts INTs. This patch fixes the pattern
to accept NUMERIC(ish) values

Sponsored-by: Steiermärkische Landesbibliothek

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:19:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:19:52 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-W00iW9BC8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:19:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:19:55 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-ABnFoMVRnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124856&action=edit
Bug 29008: Avoid warning when checking Koha version in plugins

In Koha plugins home page, each plugin min/max version is compared with actual
Koha version.

This uses metadatas assuming there are numbers, like 18.11 or 20.1100000.

But source code version is actually YY.MM.XX.YYY.ZZZ.
We sometimes find it in plugins, for examle :
https://github.com/thekesolutions/koha-plugin-bibliocommons/blob/c2da98f1bda450452ad687e5623f45939a967bdf/Koha/Plugin/Com/Theke/BiblioCommons.pm#L31
https://github.com/KohaSuomi/koha-plugin-sms-send-link-mobility-driver/blob/master/Koha/Plugin/Fi/KohaSuomi/SMSSendLinkMobilityDriver.pm#L22

This generates warning :
Argument "18.11.01" isn't numeric in numeric lt (<) at
/home/koha/src/Koha/Plugins/Base.pm line 377.: src/plugins/plugins-home.pl

We should allow this syntax in plugins metadatas.

Test plan :
1) Install a Koha plugin with minimum_version containing 3 dots :
   for example 18.11.01.001
2) Go to plugins home page
3) Check there is no warning
4) Install a plugin with minimum_version higher than current Koha version
5) Check in plugins table the warning appears
6) Install a plugin with maximum_version lower than current Koha version
7) Check in plugins table the warning appears

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:22:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:22:18 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-7nKdWtfChi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124857&action=edit
Bug 29008: Add unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:22:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:22:34 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-SvRw5MyhbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124856|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124858&action=edit
Bug 29008: Avoid warning when checking Koha version in plugins

In Koha plugins home page, each plugin min/max version is compared with actual
Koha version.

This uses metadatas assuming there are numbers, like 18.11 or 20.1100000.

But source code version is actually YY.MM.XX.YYY.ZZZ.
We sometimes find it in plugins, for examle :
https://github.com/thekesolutions/koha-plugin-bibliocommons/blob/c2da98f1bda450452ad687e5623f45939a967bdf/Koha/Plugin/Com/Theke/BiblioCommons.pm#L31
https://github.com/KohaSuomi/koha-plugin-sms-send-link-mobility-driver/blob/master/Koha/Plugin/Fi/KohaSuomi/SMSSendLinkMobilityDriver.pm#L22

This generates warning :
Argument "18.11.01" isn't numeric in numeric lt (<) at
/home/koha/src/Koha/Plugins/Base.pm line 377.: src/plugins/plugins-home.pl

We should allow this syntax in plugins metadatas.

Test plan :
1) Install a Koha plugin with minimum_version containing 3 dots :
   for example 18.11.01.001
2) Go to plugins home page
3) Check there is no warning
4) Install a plugin with minimum_version higher than current Koha version
5) Check in plugins table the warning appears
6) Install a plugin with maximum_version lower than current Koha version
7) Check in plugins table the warning appears

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:23:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:23:03 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-c3AnUFJTJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124857|0                           |1
        is obsolete|                            |

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124859&action=edit
Bug 29008: Add unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:44:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:44:56 +0000
Subject: [Koha-bugs] [Bug 28285] Lists sorted by copyrightdate display
 results in ascending date order
In-Reply-To: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28285-70-w4viYiLX0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28285

Wasim Rahaman <kolrahaman04 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kolrahaman04 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:50:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:50:40 +0000
Subject: [Koha-bugs] [Bug 28285] Lists sorted by copyrightdate display
 results in ascending date order
In-Reply-To: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28285-70-kstYyfcI5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28285

--- Comment #1 from Wasim Rahaman <kolrahaman04 at gmail.com> ---
Created attachment 124860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124860&action=edit
Need an ascending/ descending dropdown

While creating a new list from the staff client or OPAC there's no mode of
sorting ascending/ descending order of the records added to the list. Can we
have a dropdown of the same, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:51:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:51:22 +0000
Subject: [Koha-bugs] [Bug 28285] Lists sorted by copyrightdate display
 results in ascending date order
In-Reply-To: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28285-70-MoSBMj49za@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28285

--- Comment #2 from Wasim Rahaman <kolrahaman04 at gmail.com> ---
Created attachment 124861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124861&action=edit
OPAC view of the same

While creating a new list from the staff client or OPAC there's no mode of
sorting ascending/ descending order of the records added to the list. Can we
have a dropdown of the same, please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 11:57:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 09:57:05 +0000
Subject: [Koha-bugs] [Bug 29008] Warning when checking Koha version in
 plugins
In-Reply-To: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29008-70-ghY57Law0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I really don't know if it is possible to create unit test on
is_for_newer_koha() and is_for_older_koha()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 12:06:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 10:06:34 +0000
Subject: [Koha-bugs] [Bug 29000] Create a display of patrons with permissions
In-Reply-To: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29000-70-OKjZraCzC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
"Permission review" sounds good then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 12:17:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 10:17:54 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-ivxqIHtnPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 12:17:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 10:17:58 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-xNPKFDKQlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124862&action=edit
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC

This patch makes modifications to OPAC templates to make the Google
login options more consistent.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- In the staff interface, enable the GoogleOpenIDConnect preference, and
  populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with
  values (they don't need to be valid).
- On the OPAC main page you should see a "Log in with Google" button
  above the Koha login form.
- If you click the "Log in to your account" link at the top of the page
  you should see a "Log in with Google" button in the modal window
- If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged
  in you should see the same "Log in with Google" button on that page.
- In each case the Google button should point to
/cgi-bin/koha/svc/auth/googleopenidconnect
- If you disable GoogleOpenIDConnect the buttons should disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 12:59:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 10:59:42 +0000
Subject: [Koha-bugs] [Bug 29011] New: Error 500 on item checkout
Message-ID: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

            Bug ID: 29011
           Summary: Error 500 on item checkout
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: jan.michael.mueck at uni-hamburg.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 124863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124863&action=edit
screenshots

We want to checkout a item for a user, but have to search it by keywords. In
that result list there is a button "ausleihe" (borrow) next to the item we want
to checkout. When clicking on that there is an error 500. 

The item is then borrowed by the user (so everything is correct), but the page
still shows error 500. I think its suppused to redirect to the borrowed page of
that user..

see attachement.

Kind regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 13:46:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 11:46:38 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-KVFWdtO9O1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #15)
> (In reply to Tomás Cohen Arazi from comment #14)
> > And have AllowList just read the library's defined lists... I mean not
> > implementing a new AllowList class for each thing
> 
> Bug 28999 centralizes attributes lists in the schema file for the table. In
> the ColumnSet concept.

+1 looks interesting!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 13:57:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 11:57:56 +0000
Subject: [Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-nQppTvAdod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #11 from David Nind <david at davidnind.com> ---
(In reply to Fridolin Somers from comment #10)

> We must replace with "Log in" right ?

Agreed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 14:03:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 12:03:44 +0000
Subject: [Koha-bugs] [Bug 29012] New: Some rules are not saved when left
 blank while editing a 'rule' line in smart-rules.pl
Message-ID: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

            Bug ID: 29012
           Summary: Some rules are not saved when left blank while editing
                    a 'rule' line in smart-rules.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

There are 5 fields that are not set if no value is provided when saving/editing
a rule in Administration->Circulation and fines rules
- issuelength
- hardduedate
- unseenrenewalsallowed
- rentaldiscount
- decreaseloanholds

This is problematic because it gives the impression these rules are set as
blank, but in reality they don't exist and the rule will fal back to the higher
level

To test:
1 - Set a rule for
    Patron category: Teacher
    Itemtype: All
    Hard due date: (Today)
    Lona period: 10
2 - Set a rule for
    Patron category: Teacher
    Itemtype: Books
    Hard due date: (leave blank)
    Loan period: 10
3 - Expected behaviour is Book item will checkout to teacher for 10 days, all
other types will be due yesterday at 25:59:00
4 - Checkout an non-book item type to teacher
5 - Hard due date applies
6 - Checkout a 'book' item type to teacher
7 - Hard due date applies - FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 14:12:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 12:12:26 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-Cw6Mq12poS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 14:22:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 12:22:55 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-f5laepcxaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124864&action=edit
Bug 28974: Start at first page when change number of results per page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 14:24:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 12:24:33 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-o0x7O6j8n6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:06:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:06:16 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-YZWDDcXL91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124865&action=edit
Bug 28534: (follow-up) Don't adjust original DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:09:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:09:01 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place volume level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-14H5HA3Ie6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:12:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:12:58 +0000
Subject: [Koha-bugs] [Bug 29013] New: Add ability to uncancel an order
Message-ID: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

            Bug ID: 29013
           Summary: Add ability to uncancel an order
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: Malnati at ucc.edu
        QA Contact: testopia at bugs.koha-community.org

More an enhancement than a bug.  I would like the ability to uncancel an order.
 I was informed that "orders are tied to that cancelled order, so they can't
also be tied to a different order and thus budget."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:16:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:16:29 +0000
Subject: [Koha-bugs] [Bug 29014] New: Unable to use full fledged Regular
 Expression with capture groups and repalce capability in MARC Modification
 Template Action Builder.
Message-ID: <bug-29014-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29014

            Bug ID: 29014
           Summary: Unable to use full fledged Regular Expression with
                    capture groups and repalce capability in MARC
                    Modification Template Action Builder.
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rajujogi.t at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The RegEx used in MARC Modification Template Action Builder does merely help to
replace the value copied into a field/subfield from another MARK field/subfield
with some text (user specified). It also allows to add some prefixes or
suffixes to the value. However, it is not possible to replace the value with
first few characters of the value. It is also not possible to change the case
to UPPER or LOWER case. 

For this to work RegEx should allow for using capture groups and replacing the
value with the captured part of the value. For converting to upper or lower
case it should also allow for using utility modifiers such as \U (UPPER
entire), \L (lower entire), \u (UPPER first character), \l (lower first
character).

For example if we want to copy only the first 3 characters from the author
(100$a) subfield into Dewey (082$b) subfield and convert the case to UPPER
case, we should be able to specify RegEx like this 's/^([a-z]{3}]).*$/\U$1/ig'
and get the job done.

Intended result of applying this MARC modification template to a biblio record
:

MARC Modification Template Action: 
copy first 100$a to 082$b and replace the value with RegEx: 
  's/^([a-z]{3}]).*$/\U$1/ig'

Record before applying :
        100$a  - Akbar
        082$b  - some entry already existing or empty

Record after applying modification template: 
        100$a  - Akbar  
        082$b  - AKB

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:19:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:19:13 +0000
Subject: [Koha-bugs] [Bug 29007] Prompt for reason when cancelling waiting
 hold via popup
In-Reply-To: <bug-29007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29007-70-J5ggOFY1OB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:24:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:24:45 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-gMiyEN4T21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
> -- this table is MyISAM, InnoDB tables are growing only and this table is
> filled/emptied/filled/emptied...
> -- so MyISAM is better in this case
> 
> So it seems that it was expected.
> 
> I don't know how it's still relevant however.

This appears to be incorrect for the most part. It is only true if
innodb_file_per_table is disabled, but innodb_file_per_table is enabled by
default. It lists this behavior specifically as a reason not to disable it.

https://dev.mysql.com/doc/refman/8.0/en/innodb-file-per-table-tablespaces.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:33:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:33:17 +0000
Subject: [Koha-bugs] [Bug 29015] New: Add option to limit Holds Queue report
 by shelving location / collection
Message-ID: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

            Bug ID: 29015
           Summary: Add option to limit Holds Queue report by shelving
                    location / collection
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In large consortia it can take a long time to load the whole holds queue -
additionally staff may only work on a section at a time.

We should add options for limiting to a specific location/collection

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:44:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:44:43 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-PB4sNRVO7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 15:54:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 13:54:22 +0000
Subject: [Koha-bugs] [Bug 29016] New: viewlog.pl - Problem with many entries
Message-ID: <bug-29016-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29016

            Bug ID: 29016
           Summary: viewlog.pl - Problem with many entries
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: vitorfernandes87 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The script viewlog.pl it's very slow because it retrieves all action logs at
the same time. It should use KohaTables with pagination/number max of returning
entries like other Koha tables (API + AJAX wrapper).

Test plan:

- We need a database with a large number of entries in the action_logs table
(200k for example)
- Open view logs tool (viewlog.pl)
- Select all modules and search
- Timeout or a long waiting time

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 16:47:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 14:47:29 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-yiRVKDYC6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    # FIXME: All modules should have a corresponding allowlist eventually
+    my $allowclass = ref($self) . '::Allowlist';
+    if ( can_load( modules => { $allowclass => undef } ) ) {
+        my $allowlist = $allowclass->new(
+            { interface => $params->{public} ? 'opac' : 'staff' } );
+        $allowlist->load;
+        my $blocked = $allowlist->apply( { input => $json_object } );
+        Koha::Logger->get->debug(
+                ref($self)
+              . "::to_api allowlist blocked fields: "
+              . (
+                join ', ',
+                map { $_ . '=' . $blocked->{$_} } sort keys %$blocked
+              )
+        ) if keys %$blocked;

So this would become something like (using api_staff and api_public; whats in a
name):
    $json_object = $self->filter({ column_set => $params->{public} ?
'api_public' : 'api' });

It is just one line if you skip logging. Which is probably fine here.
If we need it, the idea is now to add a dump => $dump parameter. Note that the
concept is still a concept.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 16:52:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 14:52:07 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout
In-Reply-To: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29011-70-8mSnDJjG8f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
           Severity|enhancement                 |normal
          Component|Browser compatibility       |Circulation

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I can't reproduce this problem in my test system. Enabling the
itemBarcodeFallbackSearch system preference and searching for an item by
keyword works for me.

Do you have access to Koha's error logs?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 16:53:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 14:53:00 +0000
Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of
 our TT plugins
In-Reply-To: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28874-70-M8FciHLXsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 16:54:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 14:54:54 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-rT05NL8xj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:06:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:06:24 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-FQdQAB7hb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

--- Comment #10 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Henry Bolshaw from comment #9)
> The patch works as expected as far as I can tell, but I preferred the
> original behaviour prior to bug 23493:
> 
> "* Initial table load would group the results by "Today's checkouts" and
> "Previous checkouts".
> * Any subsequent column sort would disable the grouping entirely."
> 
> I like the way the "Today's checkouts" and "Previous checkouts" groupings
> are removed when sorting by date and would prefer the table to do the same
> when sorting by Title, branch etc.
> 
> I can see that library staff might want to see the "Today's checkouts" and
> "Previous checkouts" groupings. However, if people wanted to keep the
> today/previous grouping, I think it would make most sense to keep this
> grouping when sorting by date and remove it for all other columns i.e. the
> opposite of what this patch does.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:13:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:13:35 +0000
Subject: [Koha-bugs] [Bug 29017] New: Require permission to override
 DecreaseLoanHighHolds values
Message-ID: <bug-29017-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29017

            Bug ID: 29017
           Summary: Require permission to override DecreaseLoanHighHolds
                    values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the DecreaseLoanHighHolds sysprefs are enabled and one performs a checkout
that triggers the decreased loan period, one is given the option to not use the
decreased loan period. This option is given even if the user only has
circulate_remaining_permissions permission. This should be its own permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:16:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:16:33 +0000
Subject: [Koha-bugs] [Bug 29018] New: Deleting patrons from REST API doesn't
 do any checks or move to deletedborrowers
Message-ID: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018

            Bug ID: 29018
           Summary: Deleting patrons from REST API doesn't do any checks
                    or move to deletedborrowers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de

When deleting a patron via the REST API it doesn't block on
- has a guarantee
- has checkouts
- has pending fines

and it doesn't move the patron to deletedborrowers :(

It looks like the code around deleting patrons could do with a little work:

Patrons batch deletes appear to use: 
https://git.koha-community.org/Koha-community/Koha/src/commit/42ce8c29960dc8d133f8403db31459bae810f8e1/C4/Members.pm#L367

Deleting a single patron from the account in staff has a lot of additional
checks in the .pl
https://git.koha-community.org/Koha-community/Koha/src/commit/9d6d641d1f8b77271800f43bc027b651f9aea52b/members/deletemem.pl

And then there are delete and move_to_deleted in Koha/Patron*

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:17:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:17:28 +0000
Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do
 any checks or move to deletedborrowers
In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29018-70-o23fnPbUS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the API should not allow deletes on the same "hard reasons" as the
GUI and take care of holds etc. silently as if it was confirmed in staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:34:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:34:19 +0000
Subject: [Koha-bugs] [Bug 29019] New: Unable to delete HTML customization
Message-ID: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

            Bug ID: 29019
           Summary: Unable to delete HTML customization
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Hi all,

I don't know if I'm just not doing it right, but I cannot seem to be able to
delete an HTML customization.

To replicate :
1. Go to Tools > HTML customizations
2. Click on New entry
3. Fill out the form (I tried it with OpacSuggestionInstructions and
OpacLoginInstructions)
4. Click Save
5. In the list of HTML customizations, click on the Delete button at the end of
the row
-> Note that it goes back to Additional contents (News) instead of Additional
contents (HTML customizations)
6. Go back to Tools > HTML customizations
-> Note that the entry you deleted is still there

Since it goes back to Additional contents (News) after deleting, I'm wondering
if it has something to do with the separation of News and HTML
customizations...

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 17:51:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 15:51:49 +0000
Subject: [Koha-bugs] [Bug 6816] Capture member signature
In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6816-70-baVsZIta15@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
This would be a good feature.  A general import document feature that would
link the uploaded document to the patron account, and list it somewhere on the
patron checkout/details page, in a tab.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:21:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:21:49 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-euZIGJddAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #4 from Michael Hafen <michael.hafen at washk12.org> ---
The test plan is in the patch, but it isn't complete.
Here it is for you.

1.  Set the PatronsPerPage system preference to any integer other than 20.

2.  Go to the Patrons page and search for patrons.
3.  Observe that the per page drop down defaults to 20.

4.  Go to Tools -> Patron card creator.
5.  Start a new Card Batch.
6.  Click the 'Add patron(s)' button to open the patron search window.
7.  Do a search with more then 20 results.
8.  Observe that the per page drop down defaults to 20.
8b. If the PatronsPerPage was set to a value other than 10, 20, 50, or 100
      observe that that value is not in the per page drop down.
9.  Add patrons to the batch.
10. Close patron search window.
11. Click the 'Add patron(s)' button again to add the patrons to the batch.
      Observe that the per page defaults to 20.
12. Delete the card batch.

13. Apply patch.
14. Start a new card batch.  Click the 'Add patron(s)' button again to open the
      patron search window.
15. Do a search.
16. Observe that the per page drop down includes the value of PatronsPerPage
      and that value is selected by default.
17. Add patrons to batch and close the search window.
18. Click the 'Add patron(s)' button again and observe that the per page
      drop down includes and defaults to the PatronsPerPage value.
19. Delete the card batch.
17. Go back to the Patrons page and search for patrons.
18. Observe that the per page drop down defaults to the value of the
     PatronsPerPage system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:23:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:23:55 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-SoyfFqoyvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #139 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124866&action=edit
Bug 17600: Fix opac/svc/overdrive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:24:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:24:29 +0000
Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item
 in transfer because of a hold to another patron
In-Reply-To: <bug-25690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25690-70-I8F6xvNpAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Daniel Gaghan <daniel.gaghan at pueblolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.gaghan at pueblolibrary
                   |                            |.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:25:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:25:54 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-tWK8rY6mOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #140 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #139)
> Created attachment 124866 [details] [review]
> Bug 17600: Fix opac/svc/overdrive

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:25:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:25:57 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-lKMUJqP8xy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:26:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:26:01 +0000
Subject: [Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase
 suggestion
In-Reply-To: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28946-70-UILxYELw6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:38:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:38:55 +0000
Subject: [Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable
 to parse OpacHiddenItems syspref
In-Reply-To: <bug-27662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27662-70-Aqd7GLtdEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662

--- Comment #24 from Jonathan Cuéllar <jcautomatizacion at gmail.com> ---
(In reply to Jonathan Druart from comment #23)
> If your error is: "opac-sendshelf.pl: Error sending mail: Connection error
> from srvrelay.urosario.edu on port 25" then I bet you know what you should
> do. There is a connection error with your SMTP server.

Hi Jonathan,

this is the errors:

==> /var/log/koha/catalogo/opac-error.log <==
[Tue Sep 14 11:33:07.148914 2021] [cgi:error] [pid 15427] [client
172.16.29.2:24484] AH01215: (8)Exec format error: exec of
'/usr/share/koha/opac/cgi-bin/opac/opac-sendshelf.pl' failed:
/usr/share/koha/opac/cgi-bin/opac/opac-sendshelf.pl, referer:
https://catalogo.urosario.edu.co/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3516&sortfield=title
[Tue Sep 14 11:33:07.149620 2021] [cgi:error] [pid 15427] [client
172.16.29.2:24484] End of script output before headers: opac-sendshelf.pl,
referer:
https://catalogo.urosario.edu.co/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3516&sortfield=title
[Tue Sep 14 11:33:07.912845 2021] [cgi:error] [pid 15456] [client
172.16.29.2:24636] AH01215: [Tue Sep 14 11:33:07 2021] opac-export.pl: Use of
uninitialized value in numeric ne (!=) at /usr/share/koha/lib/C4/Ris.pm line
832.: /usr/share/koha/opac/cgi-bin/opac/opac-export.pl
[Tue Sep 14 11:33:07.912988 2021] [cgi:error] [pid 15456] [client
172.16.29.2:24636] AH01215: [Tue Sep 14 11:33:07 2021] opac-export.pl: Use of
uninitialized value in numeric ne (!=) at /usr/share/koha/lib/C4/Ris.pm line
832.: /usr/share/koha/opac/cgi-bin/opac/opac-export.pl
[Tue Sep 14 11:33:08.633832 2021] [cgi:error] [pid 15427] [client
172.16.29.2:24484] AH01215: [Tue Sep 14 11:33:08 2021] 500.pl: File not found :
css/opac-crai2.css at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line
107.: /usr/share/koha/opac/cgi-bin/opac/errors/500.pl, referer:
https://catalogo.urosario.edu.co/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3516&sortfield=title

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:59:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:59:13 +0000
Subject: [Koha-bugs] [Bug 27756] background_jobs_worker.pl is memory
 inefficient
In-Reply-To: <bug-27756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27756-70-pjxMnp8dnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 27782 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 18:59:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 16:59:13 +0000
Subject: [Koha-bugs] [Bug 27782] If a BackgroundJob should fail,
 it should NOT bring down the worker!
In-Reply-To: <bug-27782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27782-70-SJ0XQG8euD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27782

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|NEW                         |RESOLVED

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---


*** This bug has been marked as a duplicate of bug 27756 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:04:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:04:11 +0000
Subject: [Koha-bugs] [Bug 27662] Can't send list e-mail from OPAC / Unable
 to parse OpacHiddenItems syspref
In-Reply-To: <bug-27662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27662-70-40Wb5khxRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27662

--- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
[Tue Sep 14 11:33:08.633832 2021] [cgi:error] [pid 15427] [client
172.16.29.2:24484] AH01215: [Tue Sep 14 11:33:08 2021] 500.pl: File not found :
css/opac-crai2.css at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line
107.: /usr/share/koha/opac/cgi-bin/opac/errors/500.pl, referer:
https://catalogo.urosario.edu.co/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3516&sortfield=title

This is something specific, not part of Koha. Search for that opac-crai2.css
occurrence and remove or update it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:25:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:25:50 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-fRM99YU7q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_21_11_candidate         |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:27:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:27:21 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-LgVmZqonmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124867&action=edit
Bug 24387: Entries with parent are missing a code

We executed the same 2 queries, we want to adjust the code for the
parent and the language specific row.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:27:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:27:49 +0000
Subject: [Koha-bugs] [Bug 29020] New: Missing Background jobs link in
 admin-home
Message-ID: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

            Bug ID: 29020
           Summary: Missing Background jobs link in admin-home
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hello!

There is currently no way to access the Background jobs page other than typing
in the URL in the address bar of the navigator.

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:29:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:29:21 +0000
Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29020-70-npqyYxFCkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22417
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Keywords|                            |rel_21_11_candidate


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
[Bug 22417] Add a task queue
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:29:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:29:21 +0000
Subject: [Koha-bugs] [Bug 22417] Add a task queue
In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22417-70-rk7XUbgqof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29020


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020
[Bug 29020] Missing Background jobs link in admin-home
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:29:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:29:32 +0000
Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29020-70-aKvcaeCNJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:31:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:31:24 +0000
Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow
 fallbacks
In-Reply-To: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21781-70-LDV7istUmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:31:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:31:28 +0000
Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow
 fallbacks
In-Reply-To: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21781-70-0Vtet2vswm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109559|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124868&action=edit
Bug 21781 - message_transport_type should allow fallbacks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:31:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:31:40 +0000
Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow
 fallbacks
In-Reply-To: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21781-70-PXuhXwOt0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alexbuckley at catalyst.net.nz |kyle at bywatersolutions.com
                 CC|                            |kyle at bywatersolutions.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:33:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:33:14 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-1tPNJUh08T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:36:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:36:17 +0000
Subject: [Koha-bugs] [Bug 21781] message_transport_type should allow
 fallbacks
In-Reply-To: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21781-70-KndvTnJcCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124868|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124869&action=edit
Bug 21781 - message_transport_type should allow fallbacks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:46:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:46:01 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-WioeiTzQAV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:59:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:59:46 +0000
Subject: [Koha-bugs] [Bug 29021] New: Automatic renewal due to
 RenewAccruingItemWhenPaid should not be considered Seen
Message-ID: <bug-29021-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021

            Bug ID: 29021
           Summary: Automatic renewal due to RenewAccruingItemWhenPaid
                    should not be considered Seen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

If one is using Seen/Unseen renewals and has the RenewAccruingItemWhenPaid
system preference enabled, upon accepting payment for an accruing overdue fine
the item will be automatically renewed and that renewal will be considered
"seen," as if the patron had actually brought the item to the library. That
seems like a faulty assumption. An automatically-triggered renewal should be
unseen.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 19:59:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 17:59:46 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-qHmTfgAXu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021
[Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be
considered Seen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 20:04:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 18:04:34 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-uqTJasY112@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 20:04:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 18:04:38 +0000
Subject: [Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils
In-Reply-To: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28931-70-jO7n8I8iSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124750|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124870&action=edit
Bug 28931: Use EXPORT_OK from Koha::AuthUtils

It has been missed on bug 17600.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 20:23:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 18:23:21 +0000
Subject: [Koha-bugs] [Bug 6816] Capture member signature
In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6816-70-gerwbBU845@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Christopher Brannon from comment #3)
> This would be a good feature.  A general import document feature that would
> link the uploaded document to the patron account

Isn't this what EnableBorrowerFiles controls?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 20:33:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 18:33:29 +0000
Subject: [Koha-bugs] [Bug 6816] Capture member signature
In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6816-70-ysTgn5spaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had left this open, because I thought there might be a way to automate the
pad to image file a bit - but thinking about, I am not sure it would be wise to
just store a patrons signature without the contents of the signed document?
Thinking if this could be abused - not sure how those terminals work in
general.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 20:43:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 18:43:34 +0000
Subject: [Koha-bugs] [Bug 6816] Capture member signature
In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6816-70-EU73eTp5mN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Owen Leonard from comment #4)
> (In reply to Christopher Brannon from comment #3)
> > This would be a good feature.  A general import document feature that would
> > link the uploaded document to the patron account
> 
> Isn't this what EnableBorrowerFiles controls?

Well, how about that?  Didn't even know that was there.

I think that works pretty darn good, although, it would be nice if there was a
view feature, so you don't have to download the file to view it (if it is just
an image).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 21:33:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 19:33:22 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-M1nunSJpdV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 21:33:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 19:33:25 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-qE17GcjtPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124871&action=edit
Bug 29015: Add options for itemtpye, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
    "### items found for All libraries and item type:(Books)"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:07:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:07:12 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-2igzTL35Rl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wording in authentication   |Wrong wording in
                   |forms is confusing          |authentication forms

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:07:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:07:42 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-8tscIgrUEe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:07:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:07:47 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-sRq5TUUUe3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124218|0                           |1
        is obsolete|                            |

--- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124872&action=edit
Bug 28914: Fix wording in authentication forms

In most authentication forms we see :
Fields "Login:" and "Password:" with a submit button "Log in".

In some places submit button contains "Login", which is confusing for
translation.
It is not correct according to terminology
https://wiki.koha-community.org/wiki/Terminology#L
Also in opac-user.pl ":" is missing, it generates new translation entries.

Test plan:
1) Log out if you are logged in
2) Go to staff interface
3) Check you see button "Log in"
4) Go to OPAC page /cgi-bin/koha/opac-user.pl
5) Check you see fields "Login:" and "Password:"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:09:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:09:20 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-fxbzUIvxn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ok now patch only fixes a submit button wording and adds ":" to inputs.

Back to need signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:20:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:20:26 +0000
Subject: [Koha-bugs] [Bug 29022] New: Allow choice of whether or not to
 reset Unseen renewal count on Seen renewal
Message-ID: <bug-29022-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29022

            Bug ID: 29022
           Summary: Allow choice of whether or not to reset Unseen renewal
                    count on Seen renewal
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

There are cases in which a library might not want the count of unseen renewals
to reset on a seen renewal. For example, I've had several libraries ask if it's
possible to give some number of automatic renewals and then a number of manual
renewals. Seen/Unseen *nearly* accomplishes that, but each manual renewal would
make the next auto-renewal allowed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:20:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:20:26 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-GdHkzaPV1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29022
[Bug 29022] Allow choice of whether or not to reset Unseen renewal count on
Seen renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:23:38 +0000
Subject: [Koha-bugs] [Bug 29023] New: Allow local definition of seen/unseen
 for various renewal methods
Message-ID: <bug-29023-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29023

            Bug ID: 29023
           Summary: Allow local definition of seen/unseen for various
                    renewal methods
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

It'd be nice to be able to define which renewals are "seen" and which are
"unseen." Maybe a syspref that lists the possible renewal methods and one
checks a box for those that are to be considered "seen."

For one thing, this would give an easy place in Koha to see which are which.
For another, the feature as it exists now makes some assumptions that won't
hold true for every library. For example, not every sip-based renewal option
requires one to have the item in-hand.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:23:38 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-jLtuQnxBNf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29023


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29023
[Bug 29023] Allow local definition of seen/unseen for various renewal methods
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:33:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:33:08 +0000
Subject: [Koha-bugs] [Bug 29024] New: Renewals performed via web-based
 self-check should be Unseen
Message-ID: <bug-29024-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29024

            Bug ID: 29024
           Summary: Renewals performed via web-based self-check should be
                    Unseen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

With UnseenRenewals and WebBasedSelfCheck both enabled, when one renews an item
from the web-based self-check, that renewal is considered "Seen." It should be
"Unseen" as this renewal is happening without staff intervention and needn't
include the physical item.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 14 22:33:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 20:33:08 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-aGtY2dddZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29024


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29024
[Bug 29024] Renewals performed via web-based self-check should be Unseen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 01:51:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 23:51:37 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-0FRWMqvy61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 01:56:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Sep 2021 23:56:23 +0000
Subject: [Koha-bugs] [Bug 6816] Capture member signature
In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6816-70-jyXtGG9QUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #5)
> I had left this open, because I thought there might be a way to automate the
> pad to image file a bit - but thinking about, I am not sure it would be wise
> to just store a patrons signature without the contents of the signed
> document? Thinking if this could be abused - not sure how those terminals
> work in general.

I think that the risk seems higher than the reward in my opinion. I wouldn't
want my library system storing my signature in an Internet facing system. If I
knew that my library was doing that, I'd probably stop using that library. 

Curious what the GDPR requirements would be as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 07:14:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 05:14:16 +0000
Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in
 patron creation from
In-Reply-To: <bug-14599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14599-70-n6C7BfEDxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29025


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025
[Bug 29025] Saved auth login and password are pre-filled in patron creation
form
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 07:14:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 05:14:16 +0000
Subject: [Koha-bugs] [Bug 29025] New: Saved auth login and password are
 pre-filled in patron creation form
Message-ID: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

            Bug ID: 29025
           Summary: Saved auth login and password are pre-filled in patron
                    creation form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: didier.gautheron at biblibre.com
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 14599

Fix in #14599 and #8080 aren't working anymore with latest Firefox

Tested with Firefox 92:
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
3 - Open Create a new patron form
4 - At least password field is pre-filled with logged in user's credentials


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599
[Bug 14599] Saved auth login and password are used in patron creation from
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 07:39:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 05:39:23 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-nwQF3E8BB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 07:39:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 05:39:27 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-Nlu9TeXkA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

--- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> ---
Created attachment 124873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124873&action=edit
Bug 29025: Don't prefill userid and password in user creation form

Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 08:03:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 06:03:32 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-eOu8KWORcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124660|0                           |1
        is obsolete|                            |

--- Comment #6 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124874&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 08:04:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 06:04:09 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-Pvn7ajkW41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124864|0                           |1
        is obsolete|                            |

--- Comment #7 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124875&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 08:04:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 06:04:16 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-Dz4SXnHOko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:19:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:19:48 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-D2rhZyJ2e9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124508|0                           |1
        is obsolete|                            |

--- Comment #36 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 124876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124876&action=edit
Bug 15156: Add filter_by_amount_owed that's chainable

This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.

The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:26:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:26:07 +0000
Subject: [Koha-bugs] [Bug 29026] New: Behavior change when an empty barcode
 field is submitted in circulation
Message-ID: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

            Bug ID: 29026
           Summary: Behavior change when an empty barcode field is
                    submitted in circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty
barcode field is submitted in circulation :

Before Bug 17845, behavior was to display empty circulation page (no patron
selected).
Now behavior is displaying the circulation page of current patron.

I think previous behavior was used when scanner is used to clear form and wait
for another patron card to be scanned.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:26:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:26:17 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-J4GHpoFgDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845
[Bug 17845] Printers related code should be removed
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:26:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:26:17 +0000
Subject: [Koha-bugs] [Bug 17845] Printers related code should be removed
In-Reply-To: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17845-70-9NoUyTFWlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29026


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026
[Bug 29026] Behavior change when an empty barcode field is submitted in
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:32:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:32:11 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-hNT6c5YIc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:44:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:44:16 +0000
Subject: [Koha-bugs] [Bug 29027] New: When an order created from a
 suggestion is cancelled, suggestion remains as ORDERED
Message-ID: <bug-29027-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29027

            Bug ID: 29027
           Summary: When an order created from a suggestion is cancelled,
                    suggestion remains as ORDERED
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When an order is created from a suggestion and then cancelled, the suggestion
will remain in the status ordered.

It would be better if the status could be switched automatically to another
custom or pre-defined status, so that those would not remain in "ordered"
forever. These are hard to spot for libraries when one has been missed.

At the moment you have to create a report on suggestions with a biblionumber
and status ordered where the biblionumber no longer exists in aqordres, as it
appears to be removed from the order when the record is deleted (also not
good).

Later on, we could then also think about creating a notice to inform the patron
about the cancellation automatically as an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:52:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:52:24 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-GxUFpVedHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:52:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:52:28 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-nqpNVVF8qI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 124877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124877&action=edit
Bug 29026: Restore behavior when an empty barcode field is submitted in
circulation

When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty
barcode field is submitted in circulation :

Before Bug 17845, behavior was to display empty circulation page (no patron
selected).
Now behavior is displaying the circulation page of current patron.

I think previous behavior was used when scanner is used to clear form and wait
for another patron card to be scanned.

Test plan :
1) Set system preference CircAutoPrintQuickSlip to 'clear the screen'
2) Go to a patron circulation page
3) Post form without a barcode
=> Check you go to circulation page with no patron selected
4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip
window'
5) Go to a patron circulation page
6) Post form without a barcode
=> Check you go to print quick slip window with correct datas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:54:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:54:31 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-0AyVUem7fX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124131|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124878&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:54:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:54:35 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-wFxOBlAek8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124132|0                           |1
        is obsolete|                            |

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124879&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:54:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:54:40 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-3DAjUGNHUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124829|0                           |1
        is obsolete|                            |

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124880&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 09:55:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 07:55:23 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-0FinJDRskj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fresh patches attached... should work now Kyle, sorry about that... sha1 issues
are the bane.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 10:13:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 08:13:31 +0000
Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised
 value within the cataloguing module
In-Reply-To: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25728-70-vvRpQg5ZbL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

Klas Blomberg <klas.blomberg at skovde.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |klas.blomberg at skovde.se

--- Comment #50 from Klas Blomberg <klas.blomberg at skovde.se> ---
I don't like this patch at all!
After just a few weeks we have dozens of new locations created by mistake, like
HORS, FICT, NON-FI &c, &c

Staff type just the first letters of a location and then hit enter, and voila,
there is a new location!

Please make a syspref for this, and make it disabled by default - or set it as
a permission that could be turned off, even for superlibrarians

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 10:58:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 08:58:59 +0000
Subject: [Koha-bugs] [Bug 29028] New: UNIMARC - Authorities see from
Message-ID: <bug-29028-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29028

            Bug ID: 29028
           Summary: UNIMARC - Authorities see from
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: vitorfernandes87 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The UNIMARC authorities search results don't show the see from link in OPAC.
In staff client, the see from section appears.

Test plan:

- Add one UNIMARC authority with one field 4XX.
- Search the authority in staff client and check that see from section appears.
- Search the authority in OPAC and check that see from section don't appears.

The following code is missing in authorities-search-result.inc (OPAC):

           [% IF summary.seefrom %]
             <div class="authres_seefrom">
             [% FOREACH see IN summary.seefrom %]
               [% PROCESS showreference heading=see.heading linkType=""
type=see.type authid=see.authid %]
               [% IF ! loop.last %] ; [% END %]
             [% END %]
             </div>
           [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 11:21:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 09:21:57 +0000
Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised
 value within the cataloguing module
In-Reply-To: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25728-70-YnFGPZ0AyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Klas Blomberg from comment #50)
> I don't like this patch at all!
> After just a few weeks we have dozens of new locations created by mistake,
> like HORS, FICT, NON-FI &c, &c
> 
> Staff type just the first letters of a location and then hit enter, and
> voila, there is a new location!
> 
> Please make a syspref for this, and make it disabled by default - or set it
> as a permission that could be turned off, even for superlibrarians

Hi Klas, this is not how it should work. The intended behaviour is that it
opens up a modal where you have to enter further information - code and
descripton for the new authorised value. If it works like you describe, this
would be a bug.

It is already tied to a permission - you can't add them if you don't have
managing authorised values permission. Does that help?

Also: Filing a new bug and linking to the existing bug once released is better,
we will have to do this for this to progress and with the link everyone added
here will also get emailed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 11:22:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 09:22:48 +0000
Subject: [Koha-bugs] [Bug 20412] Importing records from Copac server
In-Reply-To: <bug-20412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20412-70-FFt4uQHREK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20412

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

--- Comment #2 from Holly <hc at interleaf.ie> ---
I just want to express there is still interest in in enabling Koha to support
Copac/JISC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 12:34:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 10:34:35 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-Q26lhGxP19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124881&action=edit
Bug 29015: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 12:53:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 10:53:54 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-sN1RxgXpRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 12:53:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 10:53:57 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-NzuRWhMEua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124872|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124882&action=edit
Bug 28914: Fix wording in authentication forms

In most authentication forms we see :
Fields "Login:" and "Password:" with a submit button "Log in".

In some places submit button contains "Login", which is confusing for
translation.
It is not correct according to terminology
https://wiki.koha-community.org/wiki/Terminology#L
Also in opac-user.pl ":" is missing, it generates new translation entries.

Test plan:
1) Log out if you are logged in
2) Go to staff interface
3) Check you see button "Log in"
4) Go to OPAC page /cgi-bin/koha/opac-user.pl
5) Check you see fields "Login:" and "Password:"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 13:25:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 11:25:08 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-dYnh7nYrNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:19:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:19:04 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-gSyGniZIxX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #30)
> Fresh patches attached... should work now Kyle, sorry about that... sha1
> issues are the bane.

I looks like your patches conflict when applied on top of 28870?

Even applied directly to master, I'm getting unit test failures:
t/db_dependent/Letters.t .. 51/83
    #   Failed test 'Failure code set correctly for invalid email parameter'
    #   at t/db_dependent/Letters.t line 959.
    #          got: 'INVALID_EMAIL:HASH(0x55de0d87b468)->parameter'
    #     expected: 'INVALID_EMAIL'
    # Looks like you failed 1 test of 7.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:19:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:19:11 +0000
Subject: [Koha-bugs] [Bug 29029] New: Koha::Object - add filter method based
 on column sets
Message-ID: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

            Bug ID: 29029
           Summary: Koha::Object - add filter method based on column sets
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

See bug 28999. Separating ColumnSet from AllowList.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:27:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:27:32 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-BtvIH7gGuR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124883&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:29:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:29:19 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-XlaaTNyCTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:29:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:29:22 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-9xfDehpwcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124877|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124884&action=edit
Bug 29026: Restore behavior when an empty barcode field is submitted in
circulation

When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty
barcode field is submitted in circulation :

Before Bug 17845, behavior was to display empty circulation page (no patron
selected).
Now behavior is displaying the circulation page of current patron.

I think previous behavior was used when scanner is used to clear form and wait
for another patron card to be scanned.

Test plan :
1) Set system preference CircAutoPrintQuickSlip to 'clear the screen'
2) Go to a patron circulation page
3) Post form without a barcode
=> Check you go to circulation page with no patron selected
4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip
window'
5) Go to a patron circulation page
6) Post form without a barcode
=> Check you go to print quick slip window with correct datas

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:30:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:30:03 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-RsISXrLPAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
I think the original patches work well, and I hope my follow-up makes it even
better. I do have one request because I think as it is this patch changes a
behavior that libraries depend on:

The form when it is initially displayed should pre-select the logged-in user's
home library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:30:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:30:16 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-2PR5TRQtjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:33:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:33:00 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-frCLcqUoer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Moving the ColumnSet to its own report. Bug 29029

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:33:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:33:34 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-s27inUPgcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:33:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:33:36 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList,
 DenyList and Koha::Object::ColumnSet
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-rNi9wUMPjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124828|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:33:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:33:55 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-KkEXIadFx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add Koha::AllowList,        |Add Koha::AllowList and
                   |DenyList and                |DenyList
                   |Koha::Object::ColumnSet     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:35:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:35:16 +0000
Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList
In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28999-70-nZRJnkWk8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #9)
> Please add feedback on especially the last patch.

Here is my current stand: These two objects are so generic and close to hash
slice and invert that I removed them from ColumnSet. They are real nice
objects, but we can live without them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:35:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:35:49 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-dku5dAoW42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:36:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:36:26 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-ml8CYXPsL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124885&action=edit
Bug 29029: Introduce Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:36:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:36:49 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-EdMjEamDgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 14:37:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 12:37:26 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-eWliibE8m9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removed the test temporarily, and the City example. Patch coming.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:01:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:01:28 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-hBxwm2lYTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just looking into this a little bit: I think sending the "all branches all
items" notice from the patron's homebranch would make a lot of sense as this is
how the DUEDGST and PREDUEDGST also operate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:15:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:15:45 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-yjK9IlMD1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124878|0                           |1
        is obsolete|                            |

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124886&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:15:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:15:49 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-gfsMh734Ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124879|0                           |1
        is obsolete|                            |

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124887&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:15:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:15:53 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-e4CFB6CBAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124880|0                           |1
        is obsolete|                            |

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124888&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:17:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:17:09 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-y2w8jUGfzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased for bug 28870..

I really wish the dependencies hadn't been jumbled up so much.. this was a
trivial and critical fix for older Koha's and now it's got a chain of bugs to
apply.

Oh well.. this is how things go sometimes I suppose.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:20:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:20:57 +0000
Subject: [Koha-bugs] [Bug 29030] New: Problems introduced by bugg 25728
Message-ID: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

            Bug ID: 29030
           Summary: Problems introduced by bugg 25728
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: klas.blomberg at skovde.se
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

There are two problems with the feature of creating new authorized values
introduced by bugg 25728

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

The MINOR problem is that you can save a new authorized value without actually
entering a new authorized value, you just need a description

The MAJOR problem is that this feature isn't optional!
Introducing a new authorized value is a complex process where you have to take
library limitaions into consideration, authorized values are used in sysprefs
and conjobs, often you have to rewrite some reports when you introduce a new
authorized value &c, &c.
In short: We certainly don't want anyone to create new authorized values on the
fly! Not even I should have that possibility.

We have had this unwelcome feature for some weeks, and there are already dozens
of new athorized values created by mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:24:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:24:21 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-AfwcZrgKSn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:24:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:24:24 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-FhGNFPyWbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124873|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124889&action=edit
Bug 29025: Don't prefill userid and password in user creation form

Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:32:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:32:43 +0000
Subject: [Koha-bugs] [Bug 29031] New: Authorities see also links - plack
 error
Message-ID: <bug-29031-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29031

            Bug ID: 29031
           Summary: Authorities see also links - plack error
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: vitorfernandes87 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The authorities see also links in Koha 21.05.01 OPAC gives a plack error:
Can't call method "authtypetext" on an undefined value at
opac-authorities-home.pl line 155

Test plan:

- Create for example an UNIMARC authority with the following fields:
            - 250$a - test1
            - 550$a - test2
- Open the created authority in OPAC
- Click on the link test2 (see also section)
- Error 500

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:33:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:33:08 +0000
Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report
In-Reply-To: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27884-70-H9Lsj0RXh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118929|0                           |1
        is obsolete|                            |

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124890&action=edit
Bug 27884: Add html support for report mails

To test:
1) Create a new notice, for example with Koha module "Patrons",
   name/code TEST and message body "<strong>testing<strong>".
2) Create a new sql report, the query could be someting like:
   SELECT "<number>" as `borrowernumber`, "to at example.com", as `email`,
"from at example.com" as `from`;
   where "<number>" is a valid borrowernumber.
3) Run patron_emailer.pl --report=<id> --notice=TEST --module=members -commit
   where <id> is the report id.
4) Check the message_queue table that the content_type column has been
   set to text/html; charset="UTF-8".
5) Ideally process the message queue and veriy that the sent email is displayed
   as rendered html.
6) Run tests in t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:33:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:33:12 +0000
Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report
In-Reply-To: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27884-70-9vl4DtFP5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124891&action=edit
Bug 27884: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:33:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:33:31 +0000
Subject: [Koha-bugs] [Bug 27884] Add html mail support for email report
In-Reply-To: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27884-70-MrithPtWb1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 15:51:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 13:51:12 +0000
Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to
 linking to orders
In-Reply-To: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19358-70-Pt1y3kAdoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io
           Assignee|nick at bywatersolutions.com   |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:14:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:14:18 +0000
Subject: [Koha-bugs] [Bug 27859] Marc export for search result
In-Reply-To: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27859-70-qh3nSy3quz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124892&action=edit
Use patron object instead of userenv

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:17:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:17:32 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-qa1SXmcuK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|BLOCKED                     |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:20:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:20:27 +0000
Subject: [Koha-bugs] [Bug 27859] Marc export for search result
In-Reply-To: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27859-70-QzMsczXkPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117721|0                           |1
        is obsolete|                            |
 Attachment #124892|0                           |1
        is obsolete|                            |

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124893&action=edit
Bug 27859: marc search result export

Enable export of staff interface search results in different marc formats.
The export will be mailed to the configured mail address of the current user.
This feature is Elasticsearch only.

To test:
1) Apply patch
2) Run installer/data/mysql/updatedatabase.pl
3) Make sure the syspref EnableSearchResultMARCExport is enabled
4) Make sure the current user has the tools -> export_catalog permission
5) Make sure the current user has an email under your control set
6) Perform a search
7) Export the serach result by choosing a format under the
   "Export results" drop down
8) Verify that link(s) with exported data has been mailed to the
   provided emial
9) Revoke the permission in 3) and make sure exporting is no longer
   possible
10) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:20:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:20:55 +0000
Subject: [Koha-bugs] [Bug 27859] Marc export for search result
In-Reply-To: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27859-70-Pren1Tml8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:23:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:23:25 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bugg 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-i79r5IEorx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
At the very least the authorized value and description fields should be
mandatory in the modal form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:23:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:23:36 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-HuywVimTfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Problems introduced by bugg |Problems introduced by bug
                   |25728                       |25728

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:28:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:28:59 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-zuV3j7HtLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44646|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124894&action=edit
Bug 15157 - Cronjob to automatically debar Borrowers/Patrons with
pending/unpaid fines/accountlines

If your library wants to debar all Borrower who haven't paid their fines by the
end of the year, this script will do that trick :)

You can give the message from a file if the cronjob runner doesn't deal with
quotes,
or as a command-line parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:29:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:29:03 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-nKJsPnoWNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109220|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124895&action=edit
Bug 15157: Update script

This patch updates debarrBorrowersWithFines.pl script to match
changes made in bug 15156.

To test:
1. Have patron(s) with unpaid fines
2. Run e.g debarrBorrowersWithFines.pl --confirm -m "This is a description of
you bad deeds"
(test other options too)
3. Confirm patron(s) with fines has been debarred with the explanation

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:29:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:29:07 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-l1scNDxDmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 124896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124896&action=edit
Bug 15157: Update for reworked bug 15156

This patch updates the script to use filter_by_amount_owed.

We could add a series of options to the script to allow more fine
grained control.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:30:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:30:30 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-o1wLp8v42i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Updated to use the Signed off alternative posted to bug 15156.

What is 'MAD' for the --confirm option.. that confused me whilst testing.

Otherwise, this generally works as expected.. I'd love to see the filter
options introduced in bug 15156 utilised in this script allowing for debarment
threshold amounts for example.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:33:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:33:27 +0000
Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower
 debarments after a payment
In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16223-70-fs92gxTGcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:33:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:33:45 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-vdSLWmole9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 16:58:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 14:58:56 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-JnLkkasx4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124885|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124897&action=edit
Bug 29029: Introduce Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:00:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:00:46 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-0talwqGvgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:02:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:02:07 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-mmIbr5lH6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124898&action=edit
Bug 29029: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:02:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:02:40 +0000
Subject: [Koha-bugs] [Bug 29032] New: ILL route unusable (slow)
Message-ID: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

            Bug ID: 29032
           Summary: ILL route unusable (slow)
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

With only 20 ill requests, for the same backend, the page takes lots of seconds
to load.

Steps to reproduce:
1. Add 23 requests with your favourite ILL backend
2. Hit the ILL requests page
=> FAIL: Notice it takes ages to load

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:03:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:03:19 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-z4raYMYS7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:10:13 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-sWwNfgf38d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:10:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:10:20 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-qlwgYQMqDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:16:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:16:34 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-RfCy0Tf9u3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Marking it RM_priority so it can be backported ASAP to stable branches once we
are sure it works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:16:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:16:56 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-hvIe4Do2Zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124899&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:48:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:48:37 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-1HSSifyUYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124886|0                           |1
        is obsolete|                            |
 Attachment #124887|0                           |1
        is obsolete|                            |
 Attachment #124888|0                           |1
        is obsolete|                            |

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124900&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:48:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:48:51 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-az2X28gtS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124901&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 17:48:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 15:48:55 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-D4qSSlJZwn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 124902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124902&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 18:40:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 16:40:42 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-493zH7iSze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
@ashimema, @Joubu what you think needs to be done to unlock this?
I could chase the places in which scalar is used in a chained fashion on
templates and make them use the Scalar TT plugin as suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 18:46:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 16:46:37 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-98foDs2qQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
After reading the comments again, it seems that:
- Keep wantarray, fix places: ashimema, tcohen
- Get rid of wantarray: Joubu

what do you think, Marcel?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 18:57:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 16:57:32 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
 other endpoints
In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22440-70-IlbjRNGXd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032
[Bug 29032] ILL route unusable (slow)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 18:57:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 16:57:32 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-xKyrAbq7bm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
[Bug 22440] ILL API response objects inconsistent with other endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:17:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:17:51 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-sr8WD64bjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:17:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:17:54 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-bHAS9N6B6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124903&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:49:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:49:23 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-HxtnwT5B2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:49:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:49:26 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-p68Yt37pfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124899|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 124904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124904&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:58:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:58:34 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-p3oALFLnlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 19:58:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 17:58:37 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-4f5Mrw8f36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124905&action=edit
Bug 29030: Make authorized value and description fields required

This patch modifies the markup of the "Create a new authorized value"
modal so that a minimum set of fields is required: Authorized value and
description.

The patch also modifies the JavaScript which handles the submission so
that the jQuery Validation plugin can handle the field checks.

The spelling "authorised" is changed to "authorized" following coding
guidelines.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Locate a record in the catalog which has items and open an item for
  editing.
- In the add item form, test the process of adding an authorized
  value on the fly with the following fields: Withdrawn, Lost,
  Damaged, Use restrictions, Not for loan, Collection code, Shelving
  location, and Shelving control number.
  - In each case you should be able to type a new value in the
    dropdown's search box and be shown the option "Select to create."
  - Selecting should trigger a modal window, "Create a new authorized
    value."
  - Test that both "Authorized value" and "Description" fields are
    required, and the form can't be submitted without them.
  - Test that an error message shows up when you submit an authorized
    value which already exists, e.g. authval "1" for "DAMAGED."
  - After triggering this error, click the "Cancel" button and try
    creating another new authorized value. When the modal reopens the
    form should be reset: No previously-entered data, no error messages.
  - Submitting a valid form with a new authorized value should work
    correctly. The modal window should close automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:03:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:03:00 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-67gxnFbcbk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Owen Leonard from comment #1)
> At the very least the authorized value and description fields should be
> mandatory in the modal form.

My patch makes this change along with some other interface improvements. It
would be nice if errors triggered by duplicate authorized values were better
handled... Right now it triggers a 500 error which shows up in the browser
console.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:10:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:10:34 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-xZyGtFsbMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124904|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124906&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:15:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:15:19 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-L2Abz8FieD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:15:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:15:22 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-gG5UNciAfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124871|0                           |1
        is obsolete|                            |
 Attachment #124881|0                           |1
        is obsolete|                            |
 Attachment #124883|0                           |1
        is obsolete|                            |
 Attachment #124903|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124907&action=edit
Bug 29015: Add options for itemtpye, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
    "### items found for All libraries and item type:(Books)"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:15:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:15:26 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-By7vfgY5fa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124908&action=edit
Bug 29015: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:15:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:15:30 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-8FfEfxKOdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124909&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:15:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:15:33 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-w3MVqFJumU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124910&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:56:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:56:36 +0000
Subject: [Koha-bugs] [Bug 29033] New: Add C4::Context->multivalue_preference
Message-ID: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

            Bug ID: 29033
           Summary: Add C4::Context->multivalue_preference
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I've seen many places in which a syspref is read, and then split used to
convert the contents into a list.

It seems it would be simple to add a method to do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 15 20:56:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 18:56:45 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-wGZcRPKdqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 01:03:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Sep 2021 23:03:26 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-CqJkmExup2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #57 from Phil Ringnalda <phil at chetcolibrary.org> ---
Fails for me in koha-testing-docker startup, with

koha_1       | C4::Installer::load_sql returned the following errors while
attempting to load
/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql:
koha_1       | DBD::mysql::st execute failed: Data too long for column 'type'
at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1.
koha_1       | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]:
INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`,
`type` ) VALUES

Looks like at 22 characters, modification-templates doesn't quite fit in a 20
character column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 04:21:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 02:21:28 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-jRZdDds8cI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #162 from David Cook <dcook at prosentient.com.au> ---
Actually, I don't think we really need the changes to opac-reserve.pl and
opac-reserve.tt. Those changes just add complexity. While they give patrons a
little bit more information about when the hold expires, I don't know that we
need to give that information at that point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 04:29:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 02:29:21 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-MPZiBjBetx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #163 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #161)
> I don't think this patch takes into account
> C4::Reserves::CancelExpiredReserves which gets called by the cronjob
> /usr/share/koha/bin/cronjobs/holds/cancel_expired_holds.pl

Actually, that's irrelevant. I was mixing up "ReservesMaxPickUpDelay" and
"ExpireReservesMaxPickUpDelay". The description of
"ExpireReservesMaxPickUpDelay" is actually a bit misleading and isn't relevant
after all (since a user could nominate their own expiry regardless of
ReservesMaxPickUpDelay).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:15:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:15:27 +0000
Subject: [Koha-bugs] [Bug 29034] New: Accessibility: OPAC nav-links don't
 have sufficient contrast ratio
Message-ID: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

            Bug ID: 29034
           Summary: Accessibility: OPAC nav-links don't have sufficient
                    contrast ratio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The contrast ratio for the OPAC navigation links (Cart, Lists, Login, Search
history, Delete your search history)fails to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:15:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:15:51 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-qcWqN0BTeG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Keywords|                            |accessibility
             Blocks|                            |28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:15:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:15:51 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-6FF5NhYUzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29034


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034
[Bug 29034] Accessibility: OPAC nav-links don't have sufficient contrast ratio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:17:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:17:03 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-tlCj3XLbvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:20:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:20:26 +0000
Subject: [Koha-bugs] [Bug 29035] New: Accessibility: OPAC masthead_search
 label doesn't have sufficient contrast ratio
Message-ID: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

            Bug ID: 29035
           Summary: Accessibility: OPAC masthead_search label doesn't have
                    sufficient contrast ratio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The contrast ratio for the OPAC mast_head search label fails to meet
accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:20:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:20:42 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-GtqDi8QUSu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:22:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:22:25 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-akAvbrnIhC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29035


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035
[Bug 29035] Accessibility: OPAC masthead_search label doesn't have sufficient
contrast ratio
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:22:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:22:25 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-FoyKZdmcsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:26:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:26:00 +0000
Subject: [Koha-bugs] [Bug 29036] New: Accessibility: OPAC buttons don't have
 sufficient contrast
Message-ID: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

            Bug ID: 29036
           Summary: Accessibility: OPAC buttons don't have sufficient
                    contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The contrast ratio for the OPAC buttons fails to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:28:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:28:51 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-LliInxDV1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28188
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
           Keywords|                            |accessibility

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
The Koha green we are using for the buttons isn't accessible with white text so
we could change it to a green that is. Alternatively we could change the text
to black (which keeps the Koha green) or choose a completely different button
colour.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:28:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:28:51 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-onIu9jHDwD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29036


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036
[Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:35:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:35:48 +0000
Subject: [Koha-bugs] [Bug 29037] New: Accessibility: OPAC breadcrumb links
 don't have sufficient contrast
Message-ID: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

            Bug ID: 29037
           Summary: Accessibility: OPAC breadcrumb links don't have
                    sufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The OPAC breadcrumb links are on a grey background and don't have sufficient
contrast. This makes the text difficult to read and fails to meet accessibility
criteria.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:36:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:36:44 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC breadcrumb links don't
 have sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-qRru0fchMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
                 CC|                            |bolshawh at parliament.uk
           Keywords|                            |accessibility
             Status|NEW                         |ASSIGNED
             Blocks|                            |28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:36:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:36:44 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-hSeqWMhAKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037
[Bug 29037] Accessibility: OPAC breadcrumb links don't have sufficient contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:41:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:41:24 +0000
Subject: [Koha-bugs] [Bug 29038] New: Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
Message-ID: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

            Bug ID: 29038
           Summary: Accessibility: OPACUserSummary heading doesn't have
                    sufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The "heading" of the OPACUserSummary table has bad contrast (grey script on
grey background). This makes the text difficult to read and fails to meet
accessibility criteria.

The Summary table is only visible if you are logged in, have some checkouts and
OPACUserSummary is active.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1..."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:41:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:41:47 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-aKcN2O1YK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |28188
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
           Keywords|                            |accessibility
                 CC|                            |bolshawh at parliament.uk


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:41:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:41:47 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-QWJZ3riBGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29038


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038
[Bug 29038] Accessibility: OPACUserSummary heading doesn't have sufficient
contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:57:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:57:44 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-Zd4qNxwVks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124208|0                           |1
        is obsolete|                            |

--- Comment #7 from Henry Bolshaw <bolshawh at parliament.uk> ---
Comment on attachment 124208
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124208
Bug 28188: Accessibility: OPAC contrast ratio for text is insufficient

I'm breaking this down into smaller patches on other bugs so I've marked this
obsolete. Thank you for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 05:58:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 03:58:19 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-Z4l92UF7tx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 07:27:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 05:27:20 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-O4xC48CkVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #33)
> After reading the comments again, it seems that:
> - Keep wantarray, fix places: ashimema, tcohen
> - Get rid of wantarray: Joubu
> 
> what do you think, Marcel?

I am close to revisiting this bug. On my list ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 08:47:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 06:47:58 +0000
Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar
 Borrowers/Patrons with pending/unpaid fines/accountlines
In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15157-70-QRV0UCAkTO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
This should be wrapped in a system preference, so that you can enable the
cronjob for a server, but only implement it for selective Koha instances on
that server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 08:50:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 06:50:09 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-Wyh09BDEMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 08:50:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 06:50:27 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-6elKT1AdmY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:10:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:10:37 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-Ea7AGHgknG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124911&action=edit
Bug 28948: Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:11:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:11:30 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-E4W7YoQ5xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #18)
> Created attachment 124911 [details] [review]
> Bug 28948: Changes

Not completely finished here. Other test needs adjustment still.
Read something about overriding..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:12:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:12:30 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-qZeb38bfN6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29029

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:12:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:12:30 +0000
Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on
 column sets
In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29029-70-tK7eEUSFlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28948

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:21:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:21:28 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-ny7sGYzC0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

--- Comment #8 from Henry Bolshaw <bolshawh at parliament.uk> ---
I agree about the automated testing. I've found some instructions for setting
up automated accessibility tests:
https://accessibility-manual.dwp.gov.uk/best-practice/automated-testing-using-axe-core-and-pa11y/#acceptance-tests-using-axe-core-and-selenium

This can be done with selenium or puppeteer. I don't have any experience with
these but I think we already use selenium for testing:
https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha

The tests rely on Pa11y (https://pa11y.org/) and axe-core
(https://github.com/dequelabs/axe-core)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:40:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:40:03 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-Lfn3Rj5u4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Accessibility: OPAC         |Accessibility: OPAC links
                   |breadcrumb links don't have |don't have sufficient
                   |sufficient contrast         |contrast

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:41:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:41:31 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-PPHER1k2iU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
This issue also applies to other links on a grey background e.g. the links in
the OPAC search results. I've amended the bug title to remove the reference to
breadcrumbs specifically.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:46:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:46:08 +0000
Subject: [Koha-bugs] [Bug 28882] Incorrect permissions check client-side
In-Reply-To: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28882-70-zXuHQ6z9DG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Depends on Bug B22150 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:49:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:49:00 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-xq9sDASEvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:54:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:54:35 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-RH2IOu0EmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |

--- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:56:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:56:37 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-9q9XRSWO8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 09:58:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 07:58:05 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-ieiSmSSFYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:00:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:00:10 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-k0aeEfdsyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04           |21.11.00,21.05.04,20.11.10
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pushed to 20.11.x for 20.11.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:01:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:01:50 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-X27VCmftdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

--- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Does not apply easily on 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:01:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:01:59 +0000
Subject: [Koha-bugs] [Bug 28149] Improve internationalization and formatting
 on background jobs page
In-Reply-To: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28149-70-MxA2RkROZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:03:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:03:44 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-BKqbUKfMhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

--- Comment #2 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 124912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124912&action=edit
Bug 29037: Accessibility: OPAC links don't have sufficient contrast

This patch changes the colour of links on the OPAC
to improve the contrast ratio and make the link
text easier to read. This accessibility issue was
identified using the WebAIM WAVE accessibility
browser extension and Google Chrome's Lighthouse
tool.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that some links (e.g. breadcrumb links
   and title links in search results) have
   insufficient contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio meets minimum requirements
5. Check that the OPAC still looks ok after the
   changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:05:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:05:41 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-g0hggLNWvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:05:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:05:44 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-pS4lyvrrcz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #10)

> This patch updates the patchset to use the ::Allowlist structure
> introduced with bug 28935.  I think we need more work here to provide
> for 'read' and 'write' allowlists.. we also need a way to alter the
> allowlist from the Koha object when required as with the load time at
> to_api here we currently have no way to pass overrides to the allowlist.

The ColumnSet allows you to create lists for various contexts. You can make
that as complex as you want. You could just create a complete attribute list
for each use case initially, but surely get_column_set could return the merge
of two sets or the intersection etc.
$column_sets = { stuff };
$column_sets->{another1} = [ uniq( @$set1, @$set2) ];
$column_sets->{another2} = [ intersect( $set1, $set2) ];
where $set1 and $set2 refer to entries in $column_sets

As to overriding, I would tend to leave that to the controller. After running
the specified filter, you can always add overrides like:
$data = { $obj->filter, @overrides };
The number of needed overrides may be an indication for the need of improving
the defined sets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:44:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:44:45 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-geOPpaDJ31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:44:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:44:49 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-Kpe02CPCkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 124913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124913&action=edit
Bug 29034: Accessibility: OPAC nav links don't have sufficient contrast ratio

This patch changes the colour of the navigation
links on the OPAC (Cart, Lists etc.) to improve
the contrast ration and make them easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast
   ratio on the OPAC
2. Confirm that the navigation links have
   insufficient contrast
3. Apply the patch and rebuild the OPAC css:
   yarn build --view opac
4. Use the accessibility tool to confirm
   the contrast ratio meets  the minimum
   accessibility requirements
5. Check that the OPAC looks ok after the
   changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:47:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:47:07 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-rcIeSsKk7Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124911|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124914&action=edit
Bug 28948: Changes

Touched Objects.t now too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 10:58:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 08:58:26 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-u5ZcT7mQ1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I elaborated on the changes of Martin, but note the following:

-    # Remove forbidden attributes if required
-    if (    $params->{public}
-        and $self->can('api_privileged_attrs') )
-    {
-        foreach my $privileged_attr ( @{ $self->api_privileged_attrs } ) {
-            delete $json_object->{$privileged_attr};
-        }
-    }

Initially we only filtered the public side removing the api privileged keys.
What we now do, is filter both public and staff !
Which is a serious difference obviously.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:02:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:02:46 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-JXs8SP66Rr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Did it not just move:

if ( can_load( modules => { $allowclass => undef } ) ) {
    {           
        my $allowlist = $allowclass->new(
            { interface => $params->{public} ? 'opac' : 'staff' } );
        $allowlist->load;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:12:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:12:03 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-1JwKCidFS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #23)
> Did it not just move:
> 
> if ( can_load( modules => { $allowclass => undef } ) ) {
>     {		
>         my $allowlist = $allowclass->new(
>             { interface => $params->{public} ? 'opac' : 'staff' } );
>         $allowlist->load;

It became more or less the ->can('get_column_set') test. But this might not be
what you mean.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:16:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:16:12 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-YjzTaC8E6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #22)

> Initially we only filtered the public side removing the api privileged keys.
> What we now do, is filter both public and staff !
> Which is a serious difference obviously.

We apply an allow list on staff too now. Tomas did not. So we are removing a
few staff fields, like:

| branchphone      | longtext     | YES  |     | NULL    |       |
| issuing          | tinyint(4)   | YES  |     | NULL    |       |
| opac_info        | mediumtext   | YES  |     | NULL    |       |
| geolocation      | varchar(255) | YES  |     | NULL    |       |
| pickup_location  | tinyint(1)   | NO   |     | 1       |       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:18:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:18:46 +0000
Subject: [Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries
 REST endpoints
In-Reply-To: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28948-70-04p6O0oW3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
What he did, is something like:

    # Remove forbidden attributes if required
    if( $params->{public} && $self->_result->can('get_column_set') ) { #FIXME
Temporary measure
        $json_object = $self->filter({ input => $json_object, column_set =>
'public_read', log_level => 'debug' });
    }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:37:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:37:52 +0000
Subject: [Koha-bugs] [Bug 29039] New: Place hold for patron upon receipt if
 order biblio is linked to a suggestion
Message-ID: <bug-29039-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29039

            Bug ID: 29039
           Summary: Place hold for patron upon receipt if order biblio is
                    linked to a suggestion
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When ordering a from suggestion the 'biblionumber' column is populated

When receiving a suggestion it would be nice to have holds placed for the
suggester

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:50:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:50:32 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-CTSeLzxiwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:50:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:50:36 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-UqCB8hac32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124907|0                           |1
        is obsolete|                            |
 Attachment #124908|0                           |1
        is obsolete|                            |
 Attachment #124909|0                           |1
        is obsolete|                            |
 Attachment #124910|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124915&action=edit
Bug 29015: Add options for itemtpye, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
    "### items found for All libraries and item type:(Books)"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:50:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:50:39 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-WcngyNyHtM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124916&action=edit
Bug 29015: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:50:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:50:43 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-kHqvZapf5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124917&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:50:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:50:47 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-yrDqtTw7Dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124918&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 11:53:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 09:53:44 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-GerAX73xDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #9)
> 1. I would not modify the old DB rev
> 
> 2.
> There was a comment about that prior to
>   commit 8c5845ef9ecd92584723cd60a221ecd4710a2516
>   Bug 26947: Update kohastructure.sql
> 
> 
> -- this table is MyISAM, InnoDB tables are growing only and this table is
> filled/emptied/filled/emptied...
> -- so MyISAM is better in this case

tmp_holdsqueue is constantly filled/emptied and is InnoDB and has no issues

It seems the other problem of InnoDB is the resetting of auto_increment on a
restart, which we have handled and should not affect here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:04:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:04:38 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-fSz1fYx0Sr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #532 from Ere Maijala <ere.maijala at helsinki.fi> ---
Martin,

As far as I can see, bundles is a different but useful case. However, it seems
that bug 24857 is kind of a subset of what holdings records would be (if
properly embraced), though as there's no RFC or much more information on how
the item groups work, I can't say for sure. What I can say is that it doesn't
make sense to have two methods that allow for grouping items in a bib.

The main advantage of holdings records compared to item groups is that they can
also exist without items and provide useful summary holdings information about
items that have not been individually catalogued. And since holdings records
are a standard thing among MARC records, there are other systems that support
them as well.

Since item groups has passed QA, I assume it's to be merged soon. At this point
I'll have to reconsider what to do here. I'm must admit that I'm somewhat
discombobulated (yes, I finally got to use the word!) as to how to proceed. It
might be possible to make summary holdings work with item groups without making
a complete mess, but the relationship between the two will need a lot of work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:26:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:26:49 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-YIzaZ8Q75r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:26:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:26:52 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-gZXSbHO2Gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124913|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124919&action=edit
Bug 29034: Accessibility: OPAC nav links don't have sufficient contrast ratio

This patch changes the colour of the navigation
links on the OPAC (Cart, Lists etc.) to improve
the contrast ration and make them easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast
   ratio on the OPAC
2. Confirm that the navigation links have
   insufficient contrast
3. Apply the patch and rebuild the OPAC css:
   yarn build --view opac
4. Use the accessibility tool to confirm
   the contrast ratio meets  the minimum
   accessibility requirements
5. Check that the OPAC looks ok after the
   changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:33:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:33:01 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-uZ8PAwdhav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:33:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:33:27 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-Dh9QgmCSUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124905|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 124920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124920&action=edit
Bug 29030: Make authorized value and description fields required

This patch modifies the markup of the "Create a new authorized value"
modal so that a minimum set of fields is required: Authorized value and
description.

The patch also modifies the JavaScript which handles the submission so
that the jQuery Validation plugin can handle the field checks.

The spelling "authorised" is changed to "authorized" following coding
guidelines.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Locate a record in the catalog which has items and open an item for
  editing.
- In the add item form, test the process of adding an authorized
  value on the fly with the following fields: Withdrawn, Lost,
  Damaged, Use restrictions, Not for loan, Collection code, Shelving
  location, and Shelving control number.
  - In each case you should be able to type a new value in the
    dropdown's search box and be shown the option "Select to create."
  - Selecting should trigger a modal window, "Create a new authorized
    value."
  - Test that both "Authorized value" and "Description" fields are
    required, and the form can't be submitted without them.
  - Test that an error message shows up when you submit an authorized
    value which already exists, e.g. authval "1" for "DAMAGED."
  - After triggering this error, click the "Cancel" button and try
    creating another new authorized value. When the modal reopens the
    form should be reset: No previously-entered data, no error messages.
  - Submitting a valid form with a new authorized value should work
    correctly. The modal window should close automatically.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 12:36:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 10:36:08 +0000
Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29020-70-LwZd8wPJhW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 13:31:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 11:31:23 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-3qoKY8eqeI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #533 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Ere Maijala from comment #532)
> Since item groups has passed QA, I assume it's to be merged soon. At this
> point I'll have to reconsider what to do here. I'm must admit that I'm
> somewhat discombobulated (yes, I finally got to use the word!) as to how to
> proceed. It might be possible to make summary holdings work with item groups
> without making a complete mess, but the relationship between the two will
> need a lot of work.

Did you raise your points on that bug too? Without knowing all details, this
sounds like a serious argument to postpone pushing that one?

> discombobulated

I was so confused that I had to lookup that one ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:01:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:01:09 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-2gZVeeAmcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:01:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:01:13 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-5Nyw1AjQvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124921&action=edit
Bug 29033: Add C4::Context->multivalue_preference

I've seen several places in which a syspref is retrieved and then
splitted using split and the fact they are pipe-separated strings.

It seems it would be simple (and handy) to add a method to do that.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Context.t
=> SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved
as an arrayref.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:10:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:10:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-qgN4AxHfH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

--- Comment #458 from Ere Maijala <ere.maijala at helsinki.fi> ---
Just to raise awareness: It seems to me that this overlaps the holdings record
functionality in bug 20447 quite significantly while providing some that the
holdings support doesn't yet. While I've not really familiarized myself with
what grouped items provide (is there an RFC or other documentation somewhere?),
I don't think it makes much sense to have two different methods for grouping
items in a bib record. Since this one has already passed QA I assume this one
will get merged soon enough, and that means that the future of bug 20447 (to
which many people have invested quite a bit, me included) needs to be
reconsidered. I wish I had known about this development much sooner. If anyone
has further thoughts, I'd welcome discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:12:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:12:17 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-DraUNd2X2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #534 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Marcel de Rooy from comment #533)
> Did you raise your points on that bug too? Without knowing all details, this
> sounds like a serious argument to postpone pushing that one?

I've now added a comment to raise awareness. I'd like to keep the discussion in
one place, though. And I'm not quite sure how to approach this all. 

> > discombobulated
> 
> I was so confused that I had to lookup that one ;)

Ha! :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:15:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:15:00 +0000
Subject: [Koha-bugs] [Bug 29040] New: Uninitialized value warning in
 Languages.pm
Message-ID: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

            Bug ID: 29040
           Summary: Uninitialized value warning in Languages.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

I noticed these warnings coming from getTranslatedLanguages when working on my
OpacNav-to-news patch:

Use of uninitialized value $interface in concatenation (.) or string at
/kohadevbox/koha/C4/Languages.pm line 121.
Use of uninitialized value $theme in concatenation (.) or string at
/kohadevbox/koha/C4/Languages.pm line 121.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:31:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:31:08 +0000
Subject: [Koha-bugs] [Bug 29039] Place hold for patron upon receipt if order
 biblio is linked to a suggestion
In-Reply-To: <bug-29039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29039-70-mNdbAwAXIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29039

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #1 from Donna <bwsdonna at gmail.com> ---
This is something many many libraries would love to see!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:43:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:43:46 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-pRZqvJGHud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Love this work.. but..

I'm afraid it fell at the first hurdle for me; accessibility is affected.

I tested the check-in screen; Upon navigating to the due date input the widget
pops up as expected, however the focus remains in the input box and the widget
cannot be navigated or submitted via keyboard.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:46:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:46:19 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-Qbr3qNdT6B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:47:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:47:37 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-Uqe7HcdzNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bolshawh at parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:48:14 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-IsjJUToxSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:48:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:48:17 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-2qYUIeB7oE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124922&action=edit
Bug 29040: Quiet ninitialized value warnings in Languages.pm

This patch makes a minor change to getTranslatedLanguages in
Languages.pm in order to quiet a warning shown when the "interface" and
"theme" variables are empty.

To test, apply the patch go to Administration -> Item types -> Edit
item type.

- Check the error log:
  tail /var/log/koha/kohadev/plack-intranet-error.log
- Before the patch you would see a warning, "Use of uninitialized value
  $interface in concatenation (.) or string at
  /kohadevbox/koha/C4/Languages.pm line 121."
- After the patch there should be no new warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:49:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:49:12 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-N4Veyq3phx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:59:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:59:01 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-9Xy2YVoOyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 14:59:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 12:59:05 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-tlZGETpxmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 124923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124923&action=edit
Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient
contrast ratio

This patch changes the colour of the masthead
search label to improve accessibility and make it
easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that the search label has insufficient
   contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio now meets accessibility
   requirements.
5. Check that the OPAC still looks ok after
   the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:25:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:25:31 +0000
Subject: [Koha-bugs] [Bug 28217] Several non-repeatable attributes when
 merging patrons
In-Reply-To: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28217-70-1qQ4hUcT1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

Mark Rogers <marcos.rogers at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcos.rogers at gmail.com

--- Comment #15 from Mark Rogers <marcos.rogers at gmail.com> ---
Comment on attachment 120325
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120325
Bug 28217: Prevent several non-repeatable attributes to be merged

Thank you for catching this issue of non-repeatable attributes being repeated
upon merge. I didn't realize it had been an issue until trying to merge records
recently and running into the exception thrown by this patch.

In my case, I was trying to merge two records for the same student; the
non-repeatable attribute was the student's grade level.

Would it be possible to change the default behavior to one of keeping the
non-repeatable attribute (if it exists) of the patron record that was selected
as the patron to keep? This would make the behavior the same as that of the
standard patron fields, which also are non-repeatable.

I apologize if this is not the right place to post this.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:36:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:36:54 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-QJTTef667S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28376                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:36:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:36:54 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-kDnY0K4nDr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28958                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958
[Bug 28958] Use Flatpickr on serials pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:19 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-f0no0rPoFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|28376                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:19 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-TlLdFsCfHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28961                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961
[Bug 28961] Use Flatpickr on tools pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:30 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-Ou88YjMw8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|28376                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:30 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-dmm4APblUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28949                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949
[Bug 28949] Use Flatpickr on reports pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:41 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-hGrslMFT8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|28376                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:37:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:37:41 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-2bdlzD2uHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28945                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:38:05 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-lPIjlNIhYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28376                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:38:05 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-yCxif1lP8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28942                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:38:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:38:38 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-R7zyWC0OIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28376                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:38:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:38:38 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-GMMXNlflIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28982                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982
[Bug 28982] Use Flatpickr on onboarding pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:03 +0000
Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
In-Reply-To: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28963-70-IwYxgMPtwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28376                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:03 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-WeUYCEcQFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28963                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963
[Bug 28963] Use Flatpickr on calendar page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:13 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-mfDkgw6mLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|28376                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376
[Bug 28376] Replace obsolete jquery-ui-timepicker-addon
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:13 +0000
Subject: [Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
In-Reply-To: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28376-70-apYFXVEQly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28983                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983
[Bug 28983] Use Flatpickr on various pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:44 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-p9vKpCRg8b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28938                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:44 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-arOgCvMwiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28942                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942
[Bug 28942] Use Flatpickr on acquisitions pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:50 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-srxJ5HEMBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|28938                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938
[Bug 28938] Correct Flatpickr's default 12hr time formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 15:39:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 13:39:50 +0000
Subject: [Koha-bugs] [Bug 28938] Correct Flatpickr's default 12hr time
 formatting
In-Reply-To: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28938-70-cUDu4LNeOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28945                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945
[Bug 28945] Use Flatpickr on administration pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:09:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:09:10 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-a1lp3VtBDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

Mark Rogers <marcos.rogers at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcos.rogers at gmail.com

--- Comment #13 from Mark Rogers <marcos.rogers at gmail.com> ---
+1 Having a middle name field would be very useful.

I work with a school in Bogotá, Colombia, where most Colombian students and
staff also have a second surname (family name), which is treated much like
middle (given) names are treated in the US and UK, namely, that they aren't
usually used except for legal and disambiguation purposes. Having both "middle
name" and "subsequent surnames" fields would be helpful.

So in the case of someone named José Manuel Pérez Rodríguez, that would be

First name: José
Middle name: Manuel
Surname ("last name"): Pérez
Subsequent surnames: Rodríguez

In general usage, the above person would just be called "José Pérez" while
official documentation would have his name as "José Manuel Pérez Rodríguez" or
"Pérez Rodríguez, José Manuel".

Portuguese names also tend to have multiple surnames, but work opposite Spanish
surnames, from what I understand, i.e. that the last surname is typically used
in the shortened version of their name. Perhaps a solution like Christopher
Brannon's for generic name fields would be best. In order to accommodate
different naming conventions, perhaps a configuration field or two could also
be added to allow for defining:

 - A "display name" (patron account), e.g.
   "name1 name3" (English-speaking and Spanish-speaking)
   "name1 name4" (Portuguese-speaking)
   "name3 name1" (Korea/China/Japan)

 - A "sort name" (in results), e.g.
   "name 3 [name4], name1 [name2]" (Spanish-speaking countries)
   "name3, name 1 [name2]" (English-speaking)
   "name 3 name1" (Korea/China/Japan)

If we wanted even further configuration, we could even allow for multiple
formats to be added as authorized values, with the possibility of setting a
default value for the database, with the option to choose a different "display
name" or "full name" for individual patrons. But perhaps this is too much
customization.

At the very least, having a middle name field and a subsequent surnames field
would be very helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:18:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:18:20 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-ouziRpH2Sf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:58:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:58:01 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-WTNPN2HzwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:58:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:58:05 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-IkRp4l7tLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115758|0                           |1
        is obsolete|                            |
 Attachment #115759|0                           |1
        is obsolete|                            |
 Attachment #115760|0                           |1
        is obsolete|                            |

--- Comment #24 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124935&action=edit
Bug 24223: Convert OpacNav system preference to additional content

This patch builds on Bug 22318 to move the OpacNav system
preference into the "Additional contents" system, making it possible to
have language- and library-specific content.

To test you should have some content in the OpacNav system
preference. To make testing easier it's also a good idea to have content
in the OpacNavBottom preference.

 - Apply the patch and run the database update process.
 - In the staff client, go to Tools -> HTML customizations and verify
   that the content from OpacNav is now stored there. When you
   edit the entry you should see content for each of the enabled
   translations in your system under each tab.
   - Confirm that the previous contents of OpacNav were added
     correctly.
 - Go to Administration -> System preferences -> OPAC and verify that
   the OpacNav preference has been removed.
 - Update and reinstall active translations (for instance fr-FR):
   - cd misc/translator/
   - perl translate update fr-FR
   - perl translate install fr-FR
 - View the OPAC and confirm that the contents of the OpacNav system
   preference displays in the left-hand sidebar.
 - Test as many pages as possible to confirm that wherever the
   OpacNavBottom content is displayed, OpacNav is also displayed.
 - Test also using the updated translation.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:58:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:58:09 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-02UK5hmpLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124936&action=edit
Bug 24223: (follow-up) Add date to OpacNav additional content entries

This follow-up modifies the atomic update so that it inserts today's
date as the "Published on" date. Without that information the system
considers the item unpublished and will not display the content.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:58:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:58:14 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-2iMP8zlrbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

--- Comment #26 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124937&action=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template

This patch makes a couple of corrections for problems I discovered
while working on Bug 24224: The variables required for correct display
of news items by branch and language were not consistently available to
the templates.

In opac-readingrecord.pl, the "lang" variable was being overwritten. On
this and other pages the logged-in patron's brachcode was not made
available. I've corrected instances of KohaNews.get() to use the
globally-available "logged_in_user.branchcode" instead.

To test, apply the patch and follow the original test plan, with the
addition of instances of the OpacNav additional contents item which
have a specific library selected.

Confirm that such items are correctly displayed according to the
logged-in user's home library. If there is no logged-in user the
library-specific OpacNav should not display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 16:58:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 14:58:18 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-Y1NsQ5a93M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

--- Comment #27 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124938&action=edit
Bug 24223: (follow-up) Updates to conform to new practices

- The patch now works with new "Additional contents" system
- The database update follows new skeleton.pl
- Add "OpacNav" option to the additional contents template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:03:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:03:43 +0000
Subject: [Koha-bugs] [Bug 28217] Several non-repeatable attributes when
 merging patrons
In-Reply-To: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28217-70-XLiPNuPmub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

--- Comment #16 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Mark Rogers from comment #15)
> Comment on attachment 120325 [details] [review]
> Bug 28217: Prevent several non-repeatable attributes to be merged
> 
> Thank you for catching this issue of non-repeatable attributes being
> repeated upon merge. I didn't realize it had been an issue until trying to
> merge records recently and running into the exception thrown by this patch.
> 
> In my case, I was trying to merge two records for the same student; the
> non-repeatable attribute was the student's grade level.
> 
> Would it be possible to change the default behavior to one of keeping the
> non-repeatable attribute (if it exists) of the patron record that was
> selected as the patron to keep? This would make the behavior the same as
> that of the standard patron fields, which also are non-repeatable.
> 
> I apologize if this is not the right place to post this.
> 
> Thank you!

Mark,
Since this bug is resolved, you will need to add your comments and votes on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648, where we are
addressing this exact issue now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:07:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:07:51 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-7z96wJvKR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #14 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Mark,
Thank you for your input.  This is very valuable and helpful.  I know our
situation is unique to the US, and we do have some patrons with more than three
names.  I think anything we can do to make the names more definable and
purposeful without lumping a bunch of them in a single field would be a
tremendous help and improvement.  The information you gave will help us come
together on a good solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:11:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:11:04 +0000
Subject: [Koha-bugs] [Bug 29041] New: Improve specificity of breadcrumbs in
 Additional Contents
Message-ID: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

            Bug ID: 29041
           Summary: Improve specificity of breadcrumbs in Additional
                    Contents
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24387

I'd like to add to the page's breadcrumbs a link for "HTML customizations" or
"News" depending on which kind of content you're adding or editing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
[Bug 24387] Rename News tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:11:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:11:04 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-EGK3vVGINO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041
[Bug 29041] Improve specificity of breadcrumbs in Additional Contents
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:26:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:26:33 +0000
Subject: [Koha-bugs] [Bug 29042] New: Improve formatting of entry form in
 Additional Contents
Message-ID: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

            Bug ID: 29042
           Summary: Improve formatting of entry form in Additional
                    Contents
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 24387

To fix a FIXME in the template: Add a "clearfix" class in the form markup so
that the standard '<fieldset class="rows">' can be used.

Also: Lengthen the title field and add a maxlength attribute to match the table
column.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
[Bug 24387] Rename News tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:26:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:26:33 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-r2ij86IFV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29042


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042
[Bug 29042] Improve formatting of entry form in Additional Contents
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:35:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:35:05 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-rIpOCNNyDf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #535 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Indeed.. this is a very complicated set of features and I agree we certainly
need to think about them as a complimentary pair.

Tomas is keen to talk and help this area move forward too having taken over the
Item groups piece.  My hope is we can come up with some way of achieving the
best for everyone.  I have my doubts as to whether the Item groups stuff will
be pushed this cycle.. I couldn't fail it in due conscience as it all works
well enough and I couldn't see that it would block this work.. but I can
definitely see how they are competitive and thus this needs taking into context
before final push.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 17:38:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 15:38:34 +0000
Subject: [Koha-bugs] [Bug 21648] Patron Merge duplicates patron attributes
In-Reply-To: <bug-21648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21648-70-0c5dlJvRlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648

Mark Rogers <marcos.rogers at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcos.rogers at gmail.com

--- Comment #17 from Mark Rogers <marcos.rogers at gmail.com> ---
I agree that prevention of data loss/corruption is important. It sounds like
the implementation of Andrew's suggestion to have a full interface to merge
both patrons (though great) is currently a barrier to getting a more functional
solution for those of us who have required non-repeating patron attributes.

Would it be possible to simply treat the non-repeating patron attributes the
same way as the standard patron fields? That is, the default behavior would be
to retain those non-repeating attributes belonging to the patron record that
was chosen when initiating the merge rather than the values for those
attributes provided by the non-selected patron. The screen where the merge is
confirmed already has links to both patron records, allowing the differences of
patron records and additional patron attributes to be compared, albeit somewhat
manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 18:03:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 16:03:19 +0000
Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in
 Additional Contents
In-Reply-To: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29042-70-8xjmCq3LLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 18:03:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 16:03:22 +0000
Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in
 Additional Contents
In-Reply-To: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29042-70-kEqBiPrClw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124939&action=edit
Bug 29042: Improve formatting of entry form in Additional Contents

This patch makes some corrections to the Additional Contents template so
that the content entry form can be styled like other similar forms in
the staff interface.

The patch also updates the form's "title" field so that it is longer and
has a maxlength attribute matching the size of the table column.

To test, apply the patch and go to Tools -> News.

 - Create a new news item.
 - In the entry form, confirm that the "Title" and "Content" fields are
   styled consistently with other similar forms.
 - Confirm that the "title" field is longer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 18:05:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 16:05:04 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-bBAePBdnyI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 18:05:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 16:05:07 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-7KJ9Azijus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124940&action=edit
Bug 29041: Improve specificity of breadcrumbs in Additional Contents

This patch adds a link to news or HTML customizations in the breadcrumbs
navigation depending on which category of content you're adding or
editing.

To test, apply the patch and go to Tools -> News.

 - Begin the process of adding a news item.
 - In the breadcrumbs menu you should see:
   Additional contents > News > Add additional content
 - Clicking "News" should return you to the view of news items.
 - Test the same process in "HTML customizations."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 19:02:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 17:02:28 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-aYENxZovmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 19:12:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 17:12:37 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-vqk7eKxiwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Can confirm this issue exists in 21.05. I performed a checkout AFTER turning on
the syspref. I see "Checked out by" in the patron history but not the item
history.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 19:14:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 17:14:09 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-UE8CinpMKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916
[Bug 23916] Issuer should be recorded and visible in patron circulation history
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 19:14:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 17:14:09 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-LxeVKB82Q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27279


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279
[Bug 27279] "Checked out by" not populated on issuehistory.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 20:50:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 18:50:20 +0000
Subject: [Koha-bugs] [Bug 29043] New: Items are prcoessed but not displayed
 on request.pl before a patron is selected
Message-ID: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

            Bug ID: 29043
           Summary: Items are prcoessed but not displayed on request.pl
                    before a patron is selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
1 - Browse to a bib in the staff client
2 - Click on the holds tab
3 - Note loading time
4 - Add 500 items to bib
5 - Note loading time - it takes longer
6 - Note items are not displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 20:53:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 18:53:01 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-wgGHmMtTw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 20:53:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 18:53:04 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-ca9FfXPf9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124941&action=edit
Bug 29043: Don't load items unless a patron has been chosen on request.pl

This page wraps the item processing into an 'if( $patron )' conditional
to boost performance before a patron has been located.

To test:
 1 - Browse to a bib in the staff client
 2 - Click on the holds tab
 3 - Note loading time
 4 - Add 500 items to bib
 5 - Note loading time - it takes longer
 6 - Note items are not displayed
 7 - Apply patch
 8 - Reload page - is much faster
 9 - Find/choose a patron
10 - Confirm items are loaded correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 20:53:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 18:53:11 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-kqccN4mF69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 21:43:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 19:43:45 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-XpoUYC3dU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 21:43:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 19:43:49 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-jURjsMnZkH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124922|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 124942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124942&action=edit
Bug 29040: Quiet ninitialized value warnings in Languages.pm

This patch makes a minor change to getTranslatedLanguages in
Languages.pm in order to quiet a warning shown when the "interface" and
"theme" variables are empty.

To test, apply the patch go to Administration -> Item types -> Edit
item type.

- Check the error log:
  tail /var/log/koha/kohadev/plack-intranet-error.log
- Before the patch you would see a warning, "Use of uninitialized value
  $interface in concatenation (.) or string at
  /kohadevbox/koha/C4/Languages.pm line 121."
- After the patch there should be no new warnings.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 22:58:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 20:58:27 +0000
Subject: [Koha-bugs] [Bug 29044] New: Check holds when checking out
Message-ID: <bug-29044-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29044

            Bug ID: 29044
           Summary: Check holds when checking out
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be helpful if the system would alert staff if the patron is checking
out an item that has not been triggered in their holds queue, and give the
option to delete that item from the queue or retain it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 16 23:33:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 21:33:44 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-b4Hijcg3pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #70 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Tomás Cohen Arazi from comment #69)
> Shouldn't we have a single 'allowed_to_change' column as an
> ENUM('owner','everyone','staff') ?

Hi Tomas, 

Yes, I can certainly implement that. 

Thanks for testing Caroline, I will also rebase the patches against master, and
re-attach them to this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 00:45:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 22:45:42 +0000
Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be
 XSLT Driven
In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11083-70-1mvlWsPb5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 01:14:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 23:14:57 +0000
Subject: [Koha-bugs] [Bug 29045] New: Public Lists do not sort
 alphabetically as expected
Message-ID: <bug-29045-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29045

            Bug ID: 29045
           Summary: Public Lists do not sort alphabetically as expected
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: estherm at sodaspringsid.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 124943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124943&action=edit
Failed sorting of public list.

When viewing the table with public lists, the individual lists do not
automatically descend alphabetically as expected. When clicking on the arrow to
sort the list, the list reorders but is also not alphabetical as expected. (see
the pre and post sort image). It looks like the lists default to appear in
order of creation date, but even then it should sort alphabetically when the
arrow is clicked in the List Name column. Clicking the arrow to sort the List
Name column a second and third time further orders the list in what appears to
be a random order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 01:28:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 23:28:41 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-6pSrxY0GQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
(In reply to Christopher Brannon from comment #14)
> I know our
> situation is unique to the US, and we do have some patrons with more than
> three names.  

It's not really unique to the US. It's common to "English" countries like the
US, Canada, Australia, New Zealand, and the UK. 

That said, I don't often see fields in Australia for middle name. Typically I
see either "First name" and "Last name", or "Given names" and "Last name".
Occasionally I'll see a field for middle name. 

I actually have found previously that giving my middle name in situations has
led to data errors. For some reason I end up being referred to by my middle
name instead of my first name (both in Canada and Australia), so I try to omit
it wherever possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 01:31:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 23:31:58 +0000
Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in
 all pages of the OPAC
In-Reply-To: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26847-70-SI7YSG2fyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847

--- Comment #23 from wainuiwitikapark at catalyst.net.nz ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 01:36:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Sep 2021 23:36:08 +0000
Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29020-70-ZPEdkS7w2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 05:03:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 03:03:06 +0000
Subject: [Koha-bugs] [Bug 29046] New: Allow libraries to specify email order
 for "AutoEmailPrimaryAddress"
Message-ID: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

            Bug ID: 29046
           Summary: Allow libraries to specify email order for
                    "AutoEmailPrimaryAddress"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

At the moment, Koha::Patron->first_valid_email_address is hard-coded to go
"email", "emailpro", and then "B_email". 

Libraries should be able to specify their own preference (at least since
historically email was "Home" and emailpro was "Work" and many non-public
library Koha databases would rather privilege emailpro over email).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:17:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:17:44 +0000
Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
In-Reply-To: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28963-70-Goe6hgRt90@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm actually looking at a calendar component related to my work to add a
bookings system for items.

I wonder if that same component may be used to improve the existing calendar
page beyond just replacing the picker widget here.

Just thought I'd mention it to suggest you work on the other bugs in this
series first whilst I get my act together ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:20:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:20:43 +0000
Subject: [Koha-bugs] [Bug 29047] New: Update the calendar page to use a
 calendar component
Message-ID: <bug-29047-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29047

            Bug ID: 29047
           Summary: Update the calendar page to use a calendar component
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Trying out a full calendar component for the calendar page rather than an
adapted picker widget.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:20:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:20:53 +0000
Subject: [Koha-bugs] [Bug 29047] Update the calendar page to use a calendar
 component
In-Reply-To: <bug-29047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29047-70-CC3XjZgmUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29047

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:35:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:35:35 +0000
Subject: [Koha-bugs] [Bug 27947] Add cancellation reasons to article requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-LAmgYy9WXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Working on this one now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:42:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:42:44 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-q0T7UjGMGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:42:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:42:57 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-84B2P7KqCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124012|0                           |1
        is obsolete|                            |

--- Comment #536 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124944&action=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland
Co-authored-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:43:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:43:10 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-AmLTtzYJmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124013|0                           |1
        is obsolete|                            |

--- Comment #537 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124945&action=edit
Bug 20447: Add holding_id to REST API item definition

Allows items to be properly returned, including the holding_id field.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:43:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:43:24 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-X5fkXumMsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124014|0                           |1
        is obsolete|                            |

--- Comment #538 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124946&action=edit
Bug 20447: Add a batch rebuild script for holdings table

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:43:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:43:36 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-Y3QRMPS4ng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124015|0                           |1
        is obsolete|                            |

--- Comment #539 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124947&action=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:43:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:43:50 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-qZ0lQxcFbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124016|0                           |1
        is obsolete|                            |

--- Comment #540 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124948&action=edit
Bug 20447: (QA follow-up) Update for bug 26703

Reverse the title element content as per updated guidelines.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:44:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:44:12 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-PEQiGrtv9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124017|0                           |1
        is obsolete|                            |

--- Comment #541 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124949&action=edit
Bug 20447: Fixes for bug 17600

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:44:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:44:28 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-JDh30zQo2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124018|0                           |1
        is obsolete|                            |

--- Comment #542 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 124950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124950&action=edit
Bug 20447: DBIX schema changes

Rebased-by: Andrew Nugged <nugged at gmail.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:45:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:45:25 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-PLXqgyVJ7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #543 from Ere Maijala <ere.maijala at helsinki.fi> ---
Rebased and fixed displaying of holdings records in OPAC results when there are
no items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 09:50:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 07:50:22 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-pphrWXFdIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add cancellation reasons to |Add default cancellation
                   |article requests            |reasons to article requests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 10:03:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 08:03:32 +0000
Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on
 serial-level
In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18745-70-lbXSaEOkrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87102|0                           |1
        is obsolete|                            |

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124951&action=edit
Bug 18745: Serial claims: save supplier info on serial-level

This allows to change the subscription's supplier while keeping the info
of supplier for previous serials, which allows to claim late/missing
serials to the right supplier

Test plan:
1. Create 2 suppliers, S1 and S2
2. Create a new subscription with S1
3. Generate some late/missing serials
4. Change supplier to S2
5. Generate some more late/missing serials
6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing
issues for both suppliers
7. Check that you have the expected issues for each supplier
8. prove t/db_dependent/Serials/Claims.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 10:04:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 08:04:40 +0000
Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on
 serial-level
In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18745-70-pTgzQNoSNX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
All patches rebased on master and squashed. Ready to be tested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:18:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:18:54 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-eg7Rn4IP4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:18:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:18:58 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-DjPjYrEppx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124849|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124952&action=edit
Bug 27947: Add authorised values list in article requests cancellation

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:19:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:19:01 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-FmLz9a0Luh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124850|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124953&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:19:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:19:05 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-RjPLz1FbWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124851|0                           |1
        is obsolete|                            |

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124954&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:19:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:19:09 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-tzRVUzQc8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124955&action=edit
Bug 27947: (follow-up) Improve atomic update

We do not need to replace the whole notice text, we only need to
replace the reference to article_requests.notes.

Test plan:
Run the dbrev. Verify result for notice AR_CANCELED.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:19:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:19:14 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-IhilrYgjHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 124956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124956&action=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too

Something that currently comes up now already too:
If the user cancels from the OPAC page, there is no reason in the notice.
We could simply add one now.

Test plan:
Run dbrev to add the OPAC authval.
Create new AR and cancel it from OPAC.
Verify notice created for the user.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:19:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:19:49 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-wz7xxpZiDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me. 
Added two follow-ups to refine notice update in db rev and to add OPAC
cancellation as a new reason.

One thing remains (point 5 from comment7):
DELETE /public/patrons/{patron_id}/article_requests/{ar_id}
DELETE /api/v1/article_requests/{ar_id}
=> Tomas, please respond. Quoting myself: "But it seemed more logical (or
consistent) to me that deleting an article request from OPAC or staff have
similar end points."
In short: Why not /public/article_requests/{ar_id} ?
And out of scope: But why does public not have a version?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:20:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:20:32 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-ccDwhYmp43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:27:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:27:35 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-a6wLAGXXwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:30:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:30:54 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-TWvch4L9Z8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The issue raised on comment3 (tomorrow exactly three months ago) is imo
legitimate, but has not been answered sufficiently.
Changing status to emphasize the need for feedback in all appreciation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:36:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:36:18 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
 categories configuration
In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27946-70-rZDQLjvO4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing status to BLOCKED.
This bug depends on bug 28656 which is in Failed QA state.
Could we do something to get this/that one further? Or remove the dependency on
this report?

@Martin: ping.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:37:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:37:39 +0000
Subject: [Koha-bugs] [Bug 26088] Add optional fee for (scanned) article
 requests
In-Reply-To: <bug-26088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26088-70-O77VcHijSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26088

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---


*** This bug has been marked as a duplicate of bug 27946 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:37:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:37:39 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
 categories configuration
In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27946-70-91HsysYzIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
*** Bug 26088 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 11:51:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 09:51:29 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-cbGN6cj6yC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #61 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Martin Renvoize from comment #60)
> Ouch.. there's stuff missing here.
> 
> We don't update kohastructure at all and we don't do a DB update to add the
> error_code field to the database either.  Finally, we don't add error_code
> to the _set_message_status routine.

I don't understand what you mean with error_code? We add delivery_note column
where fail message is added and it's also added to _set_message_status routine.
Also kohastructure is updated on first patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 12:42:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 10:42:26 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-8iiBeeJXhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #544 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Martin Renvoize from comment #535)
> Indeed.. this is a very complicated set of features and I agree we certainly
> need to think about them as a complimentary pair.
> 
> Tomas is keen to talk and help this area move forward too having taken over
> the Item groups piece.  My hope is we can come up with some way of achieving
> the best for everyone.  I have my doubts as to whether the Item groups stuff
> will be pushed this cycle.. I couldn't fail it in due conscience as it all
> works well enough and I couldn't see that it would block this work.. but I
> can definitely see how they are competitive and thus this needs taking into
> context before final push.

Okay, I've now rebased the code (I think this was rebase 32 from me :D) and
also fixed a problem displaying the holdings locations in OPAC results list
when there are no items (apparently this was broken in one of the earlier
rebases). So for this part this would be ready to move on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 12:51:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 10:51:27 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-G5eFHtSzdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Reviewing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:02 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-kpGxy0JDCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122635|0                           |1
        is obsolete|                            |

--- Comment #65 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124957&action=edit
Bug 27378: Add new 'modaljs' syspref type

This commit adds a new 'modaljs' syspref type. This is similar to the existing
'modalselect' syspref type but instead of using a file to create a list of
selectable options which are displayed in the modal, it assumes that anything
can happen within the modal driven by JS, and whatever happens is going to
return a string, that will be saved as the syspref value. In our case, the
string will be all the details of the “chunks” concatenated into a string

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:07 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-oppIdkFLd4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122636|0                           |1
        is obsolete|                            |

--- Comment #66 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124958&action=edit
Bug 27378: Add sysprefs

This commit adds 4 new sysprefs:

- CookieConsent - the master on/off for this functionality
- ConsentJS - The configuration for JS code that requires consent prior to
running.
- CookieConsentBar: Allows the admin to specify the HTML that will be
displayed in the consent bar that appears at the bottom of the page
- CookieConsentPopup: Allows the admin to specify the HTML that will be
displayed in the cookie consent popup

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:12 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-VFWEeCXR3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122637|0                           |1
        is obsolete|                            |

--- Comment #67 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124959&action=edit
Bug 27378: Add JS to power modaljs

This commit adds the Javascript that provides the functionality within
the consentJS modaljs modal. It provides the ability to display the
current state of any consentJS values and to amend them, as well as add
new ones.

There is also some refactoring of the existing modalselect functions to
allow re-use of existing code between modalselect & modaljs. This
refactoring has been minimal and consists of abstracting functionality
into functions to allow more wide use.

Styles for the consentJS UI were also added.

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:17 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-6VR2ocsQSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122638|0                           |1
        is obsolete|                            |

--- Comment #68 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124960&action=edit
Bug 27378: Add cookie consent display to OPAC

This commit adds the display of the cookie consent bar and modal to the
OPAC.

- Adds a new JSConsents template plugin that enables a template to be
populated with the contents of the ConsentJS syspref in a prepared,
usable form
- Adds a new cookieconsent.js script that drives the display and
functionality of the cookie consent bar and modal
- Adds styles for the cookie consent bar and modal
- Adds the creation and population of the cookie consent bar and modal,
if appropriate
- Adds the ability for both authenticated and unauthenticated users to
view and modify their consents either via "your consents" or a new
unobtrusive "Your cookies" button in the bottom right of the screen.
- Adds unit test for JSConsents.pm

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:22 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-4dTPHaQ31D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122639|0                           |1
        is obsolete|                            |

--- Comment #69 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124961&action=edit
Bug 27378: Add cookie consent display to staff UI

This commit adds the display of the cookie consent bar and modal to the
staff interface:

- Adds a new cookieconsent.js script that drives the display and
functionality of the cookie consent bar and modal
- Adds styles for the cookie consent bar and modal
- Adds the creation and population of the cookie consent bar and modal,
if appropriate

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:30 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-MgBuLy2MPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122640|0                           |1
        is obsolete|                            |

--- Comment #70 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124962&action=edit
Bug 27378: Move "Your cookies" to existing bar

The new "Your cookies" button that appeared at the bottom right when an
unauthenticated user had made their cookie consent selections wasn't
ideal.

It has now been moved to the top bar, next to "Lists", this feels like a
much more sensible place for it.

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:34 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-tAsHrn8BVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122641|0                           |1
        is obsolete|                            |

--- Comment #71 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124963&action=edit
Bug 27378: Delete cookies when consent removed

We have provided the ability for a user to remove previously granted
consent, but we were not removing the cookie associated with that
consent. This was a complete oversight on my part.

I've introduced an additional bit of metadata for each "consent" defined
in the ConsentJS syspref, this allows the admin defining a "consent" to
specify a string (which is treated as a regex) that allows us to
identify a cookie name associated with that consent. So, for example, if
Google Analytics was being added, an identifying string might be '_ga'.
This allows us to subsequently remove a cookie that a previously
granted consent has set.

This commit also adds some missing 'html' filters in
koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:40 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-KWFfeWeSt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122642|0                           |1
        is obsolete|                            |

--- Comment #72 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124964&action=edit
Bug 27378: Add cookie domain and path

A subtlety I missed was that some tracking services, such as Google
Analytics, specify a cookie domain and path that differ from the
default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the
GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/',
even though the cookie may have been set at a different path.

Both of these things makes sense, but of course unless we also specify
both of those things when we try to delete a previously set cookie, we
cannot.

Therefore, I have added two more bits of metadata to each "consent",
Cookie Domain and Cookie Path. It is necessary for an admin creating a
"consent" entry to know and specify these values. They can be
established by looking a cookie set by the service being configured.

This adds more complexity to setting up a consent, but we cannot remove
previously set cookies without it.

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:07:44 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-2KQV0DCpOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

--- Comment #73 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124965&action=edit
Bug 27378: (follow-up) Fix update delimiter

As suggested by Nick in Comment #64

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:08:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:08:22 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-CujUy1UfGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

--- Comment #74 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
- Rebased and fixed merge conflicts
- Modified update delimiter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:02 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-bcKLO5w20c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:06 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-LS8kZV8ReO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123943|0                           |1
        is obsolete|                            |

--- Comment #69 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124966&action=edit
Bug 27944: Add new letter in atomicupdate, and modify status column in
article_requests table

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:10 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-wYlBaQjmj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123944|0                           |1
        is obsolete|                            |

--- Comment #70 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124967&action=edit
Bug 27944: Add AR_REQUESTED message in sample_notices.yml and modify AR_PENDING

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:13 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-jM4H08ypVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123945|0                           |1
        is obsolete|                            |

--- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124968&action=edit
Bug 27944: Add "requested" stage in article request process

This patch adds the stage "requested" in article request process, which
is previous to pending stage.

To test:
1. apply this patch
2. updatedatabase
3. enable ArticleRequests syspref
4. from staff inteface and from opac search for a record and place an
   article request
5. koha-mysql kohadev
6. query: select subject, content, letter_code from message_queue;
CHECK => There is a message for each article request with code
AR_REQUESTED
      => In opac-user.pl, in "Article requests" tab you should see a row
in the table with "Requested" status
5. in staff go to Circulation -> Article Requests
SUCCESS => You should see 3 tabs, one for Requested stage (with two
requests), one for Pending stage and one for Processing stage.
6. play with actions buttons
CHECK => you should see a new action called "Set request as pending"
SUCCESS => All action buttons behave as expected, and tab counts updates
correctly.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:18 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-50jsIoZObM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123946|0                           |1
        is obsolete|                            |

--- Comment #72 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124969&action=edit
Bug 27944: Add missing Status module

Test plan:
perl -c the module or run qa tools

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:22 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-VAjoAhYiqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123947|0                           |1
        is obsolete|                            |

--- Comment #73 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124970&action=edit
Bug 27944: (follow-up) Improving consistency between notice names

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:27 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-1u3DY1eGEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123948|0                           |1
        is obsolete|                            |

--- Comment #74 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124971&action=edit
Bug 27944: (follow-up) Move existing statuses, rename idempotent

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:33 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-0pO6Unoqg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123949|0                           |1
        is obsolete|                            |

--- Comment #75 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124972&action=edit
Bug 27944: (follow-up) Move statuses to constants

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:37 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-KzVgOO1ybv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123950|0                           |1
        is obsolete|                            |

--- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124973&action=edit
Bug 27944: REQUESTED is the new default status

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:42 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-JqDeFmrWzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123951|0                           |1
        is obsolete|                            |

--- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124974&action=edit
Bug 27944: (QA follow-up) Rename ->open for ->set_pending

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:48 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-EwdZiwglaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123952|0                           |1
        is obsolete|                            |

--- Comment #78 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124975&action=edit
Bug 27944: (QA follow-up) Make staff home page show new article requests

As exposed on comment 29, the current code is showing the 'pending'
requests when it should display 'requested' ones (i.e. the new ones).

This patch changes that accordingly.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:10:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:10:59 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-6gE81WUWsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #79 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124976&action=edit
Bug 27944: (QA follow-up) Add span to fix pipe separator

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:11:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:11:50 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-Om1vWGKjqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #75 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #64)
> Error in :
> installer/data/mysql/atomicupdate/bug_27378_add_CookieConsentPopup_syspref.
> perl
> (shoudl quote with q{} so the | doesn't break it)

Thanks, fixed.

> In testing I was never able to get the cookies to set - can you provide some
> values in the test plan that work on koha testing docker - I got complaints
> of bad domain for cookies

It was developed on KTD and I just ran through the test plan on the same and it
worked perfectly. For step 12 of the test plan are you using the domain you use
to access the KTD in your browser?

> Question: Should you be able to keep using the site before clicking 'Accept'
> on the necessary cookies?

I think so, I've yet to encounter a site that wouldn't let me use it before I
agreed to cookies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:12:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:12:32 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-fQkm7YsblP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:12:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:12:37 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-9ingEjlA5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124940|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 124977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124977&action=edit
Bug 29041: Improve specificity of breadcrumbs in Additional Contents

This patch adds a link to news or HTML customizations in the breadcrumbs
navigation depending on which category of content you're adding or
editing.

To test, apply the patch and go to Tools -> News.

 - Begin the process of adding a news item.
 - In the breadcrumbs menu you should see:
   Additional contents > News > Add additional content
 - Clicking "News" should return you to the view of news items.
 - Test the same process in "HTML customizations."

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:13:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:13:14 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-126IcARScZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #80 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #68)
> If bug 27945 might pass before this one, we could add here:
> 
> +++ b/Koha/Patron.pm
> @@ -975,7 +975,7 @@ sub can_request_article {
> 
> -        { borrowernumber => $self->borrowernumber, status => { '!=' =>
> ['CANCELED','COMPLETED'] } },
> +        { borrowernumber => $self->borrowernumber, status => { '!=' =>
> ['PENDING', 'CANCELED', 'COMPLETED'] } },
> 
> It feels better to not count the PENDING reqs here.

The bugs do not apply on top of each other - one will need to be rebased to be
pushed before the other, Agustin, can you take care of that and add the
follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:27:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:27:36 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-V9POtQjYBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:27:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:27:41 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
 fines/accountlines
In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15156-70-KCuNhtJADW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124876|0                           |1
        is obsolete|                            |

--- Comment #37 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124978&action=edit
Bug 15156: Add filter_by_amount_owed that's chainable

This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.

The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:30:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:30:22 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
 display partners in audit log
In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22531-70-CrsLItW6EN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122643|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124979&action=edit
Bug 22531: Add logging & display of req partners

This patch adds:

- The ability to send request to partners multiple times.
- Logging of requested partners
- Display of requested partners in "ILL Request Log" display

Signed-ff-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:30:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:30:26 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
 display partners in audit log
In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22531-70-cCiUzBG6yp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122644|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124980&action=edit
Bug 22531: Add unit tests

Add tests for new and modified methods

Signed-off-by: Barry Cannon <bc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 13:30:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 11:30:54 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
 display partners in audit log
In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22531-70-qffcKLQzH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:05:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:05:55 +0000
Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC
 detail pages
In-Reply-To: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28667-70-NxPYZRxBFf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:05:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:05:58 +0000
Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC
 detail pages
In-Reply-To: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28667-70-NKUbX4FSrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124981&action=edit
Bug 15156: Add filter_by_amount_owed that's chainable

This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.

The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:15:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:15:04 +0000
Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC
 detail pages
In-Reply-To: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28667-70-lFFdg5tdT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123805|0                           |1
        is obsolete|                            |
 Attachment #124981|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124982&action=edit
Bug 28667: Check damaged item can be reserved in OPAC detail pages

In OPAC detail pages, damaged items must impact the "place hold" link.
This behavior depends on preference AllowHoldsOnDamagedItems.

Test plan :
1) Create a record with one damaged item
2) Set AllowHoldsOnDamagedItems to 'Allow'
3) Go to OPAC record detail page : opac-detail.pl
4) Check you see "Place hold" link
5) Set AllowHoldsOnDamagedItems to 'Don't allow'
6) Refresh page
7) Check you don't see "Place hold" link
Same tests 2 to 7 for pages opac-ISBDdetail.pl and opac-MARCdetail.pl

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:15:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:15:07 +0000
Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC
 detail pages
In-Reply-To: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28667-70-1pttktchKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124983&action=edit
Bug 28667: (QA follow-up) Fetch preference once

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:33:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:33:41 +0000
Subject: [Koha-bugs] [Bug 21217] No error when doing Renewals for expired
 borrowers
In-Reply-To: <bug-21217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21217-70-UzdXLypaBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21217

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:36:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:36:20 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-MgtAk8dtlj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91428|0                           |1
        is obsolete|                            |

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124984&action=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:36:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:36:39 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-mfCVWZPjvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 14:57:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 12:57:07 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-g6cr8zwwJn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #9)
> > > [5] Why do you add cancel_article_request to Koha/REST/V1/Patrons.pm ? Apart
> > > from checking existence of the patron id, what is its use ?
> > 
> > As I was making API endpoints for cancelling article requests from staff
> > interface (we should move away from svc in any chance we've got), I thought
> > it would be good to add the same for opac.. the endpoint that opac uses is
> > DELETE /api/v1/public/patrons/{patron_id}/article_requests/{ar_id}, so It
> > seemed natural to place it in Koha/REST/V1/Patrons.pm 
> 
> I dont really mind. Maybe ask Tomas? But it seemed more logical (or
> consistent) to me that deleting an article request from OPAC or staff have
> similar end points.

I generally prefer context-specific routes, so:

/patrons/:patron_id/article_requests/1
over
/article_requests/1

in the particular case of the public routes, this allows us to use the
'allow-owner' permission feature from our API framework.

What I don't like, is having the controller methods so sparse. I will submit a
follow-up reorganizing that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:05:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:05:06 +0000
Subject: [Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription
 batch edit tool
In-Reply-To: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18784-70-TyH2i384Ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91429|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124985&action=edit
Bug 18784: Add 'auto claim' option to subscription batch edit tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:05:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:05:29 +0000
Subject: [Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription
 batch edit tool
In-Reply-To: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18784-70-EvAjZD7uwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Needs Signoff

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:16:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:16:41 +0000
Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out
 by field in Checkout history
In-Reply-To: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28859-70-qf0QDONiwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859

--- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 124986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124986&action=edit
Bug 28859: Fix missing column setting

This commit adds the missing checked_out_by column to
columns_settings.yaml

Test plan:

- Follow the test plans in the bug description and note that the
symptoms are no longer seen

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:16:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:16:54 +0000
Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out
 by field in Checkout history
In-Reply-To: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28859-70-MW2SdLUNFf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:21:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:21:53 +0000
Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
In-Reply-To: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18796-70-tJsa1hNq38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Fridolin Somers from comment #3)
> Rebase looks easy ;)

(In reply to Fridolin Somers from comment #5)
> Needs a huge rebase :D

What two years of changes can do... :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:28:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:28:45 +0000
Subject: [Koha-bugs] [Bug 29048] New: Authorities search results - related
 records link
Message-ID: <bug-29048-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048

            Bug ID: 29048
           Summary: Authorities search results - related records link
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: vitorfernandes87 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The related records link in the authorities search results searches for
"an=authid", which returns all records with an started with authid (after
clicking the link). This causes a difference between the number of related
records and the number of records retrieved in the search (using
Elasticsearch).

The link should change from:

q=an=[% resul.authid | uri %]

To:

q=[% resul.authid | uri %]&amp;idx=an,phr

in the following line:

https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L110

Test plan:

- Create 10 authority with similar values
- Relate some record with authority 1
- Relate some record with authority 10
- Search authorities (authority 1 should have 1 related record)
- Click the related records link
- You should get 2 related records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:35:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:35:51 +0000
Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
In-Reply-To: <bug-28910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28910-70-Z3wi2ktK7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:35:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:35:54 +0000
Subject: [Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js
In-Reply-To: <bug-28910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28910-70-F99abhQTnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124987&action=edit
Bug 28910: Correct eslint errors in OPAC basket.js

This patch corrects eslint errors in the OPAC copy of basket.js:
Indentation inconsistencies, undeclared variables, unused functions,
etc.

To test, apply the patch and test the "Cart" functionality in the
OPAC:

- In the OPAC, add an item to the cart.
- A popup message should appear telling you the item has been added.
- The "Add to cart" link should update to read "In your cart."
- The count if cart items in the header should be updated.
- The "In your cart (remove)" link should work correctly.
- Test this process from both the search results and
  detail pages.
- Open the cart.
- The cart should open correctly.
- In the cart, test all the controls:
  - More details
  - Send
  - Download
  - Empty and close
  - Hide window
  - Print
  - Select all / clear all
  - With checked items:
    - Remove
    - Add to list
    - Place hold
    - Tag

The following unused functions were removed: readCookieValue,
AllAreChecked, SelectAll, and quit. A search of the Koha codebase should
return no results from the opac-tmpl directory.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:51:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:51:33 +0000
Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
In-Reply-To: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18796-70-6IS0CGwjL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64263|0                           |1
        is obsolete|                            |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 124988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124988&action=edit
Bug 18796: Allow to print notice while claiming serials

It can be useful to have a printable version of a claim notice, for
testing purposes or for when supplier has no email address for
example

Test plan:
1. Go to Serials > Claims and select a vendor
2. Select some serials by clicking on checkboxes
3. Click to the little arrow next to 'Send notification' button and
   click on 'Print notification'
4. Verify that the downloaded PDF contains the content of the selected
   notice
5. Verify that the 'Send notification' button still works as before
6. Run `prove t/db_dependent/Letters.t`

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:52:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:52:10 +0000
Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
In-Reply-To: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18796-70-BqAjQZidz0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:53:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:53:30 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-V0flHuMxoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Agustín Moyano from comment #4)
> > Hi Marcel, sorry for the delay. For what I've seen, printslip.tt uses
> > SlipCSS stylesheet (if defined) where you may say, for example
> > 
> > hr {
> >     display: none;
> >     page-break-after: always;
> > }
> 
> Did you test this yourself?
> 
> I already did some testing with page-break-after but couldnt get it to work.
> I now inserted the exact lines above in a stylesheet for SlipCSS but it does
> not work either.

Hi Marcel, I did not test it, but my point was that printslip.tt includes a
css, just as print-notices.tt where you can define page breaking conditions.

Let me play around a bit, and I'll post a working example

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 15:59:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 13:59:17 +0000
Subject: [Koha-bugs] [Bug 29049] New: Holds page shows too many priority
 options in pulldown
Message-ID: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

            Bug ID: 29049
           Summary: Holds page shows too many priority options in pulldown
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
1 - Place 5 holds on a biblio
2 - 'Find' two holds i.e. check them in to set them as transit or waiting
3 - Load the holds page for the biblio
4 - Check the pull down for priority
5 - Note holds has priority 1-3 but dropdown is 1-5
6 - Click 4 or 5 and note nothing happens

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:03:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:03:14 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-qaBk5G5vgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:03:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:03:17 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-Q9uUvPyKgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #7 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 124989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124989&action=edit
Bug 28472: (follow-up) add unit test for the case where location = NULL

This patch adds an extra unit test, to cover the case where the
UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART"
and the item being returned has no shelving location set.

Test plan:

1) Apply the patch provided earlier
2) prove -v t/db_dependent/Circulation/issue.t
   ...and sign off if all tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:03:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:03:33 +0000
Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out
 by field in Checkout history
In-Reply-To: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28859-70-L4NbMomDqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:03:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:03:36 +0000
Subject: [Koha-bugs] [Bug 28859] Table Settings should control Checked out
 by field in Checkout history
In-Reply-To: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28859-70-AHBcrC54TL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124986|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 124990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124990&action=edit
Bug 28859: Fix missing column setting

This commit adds the missing checked_out_by column to
columns_settings.yaml

Test plan:

- Follow the test plans in the bug description and note that the
symptoms are no longer seen

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:05:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:05:10 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-0Tyb3G3BcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #8 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Jonathan Druart from comment #5)
> The change is missing test coverage.
Hi Jonathan!
I think I managed to write a test that covers this case, see my follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:07:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:07:33 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-J1WFa01MZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #58 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 124991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124991&action=edit
Bug 18138: Refactor after using template id instead of name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:11:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:11:15 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-8O0Zn8EpFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #9 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Hannah Co from comment #6)
> I don't believe this patch catches items in "processing" that should end up
> with no shelving location. I have a freshly updated 21.05, with this patch
> included. My system pref UpdateItemLocationOnCheckin contains "PROC:
> _PERM_". Check-in does not make any changes to a record with "PROC" location
> and no other shelving location assigned. 
> 
> New items are automatically created with location AND permanent_location
> both set as PROC. It seems that "PROC" and "CART" should never populate
> permanent_location. Can we prevent "PROC" from populating the
> permanent_location?
> 
> Or, can we handle the situation where "PROC" exists in both
> permanent_location AND location, so the location is completely removed and
> replaced with NULL?
Hi Hannah!
Perhaps I've misunderstood what you're describing in your comment, but to me
it looks like it's a different scenario than the one in the Description of
this bug report. Perhaps your report deserves to be submitted as a new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:12:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:12:18 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-UoLnzkkJRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gveranis at dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:12:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:12:39 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-zuol74uxe4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #59 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Phil Ringnalda from comment #57)
> Fails for me in koha-testing-docker startup, with
> 
> koha_1       | C4::Installer::load_sql returned the following errors while
> attempting to load
> /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql:
> koha_1       | DBD::mysql::st execute failed: Data too long for column
> 'type' at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}>
> line 1.
> koha_1       | Something went wrong loading file
> /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]:
> INSERT INTO systempreferences ( `variable`, `value`, `options`,
> `explanation`, `type` ) VALUES
> 
> Looks like at 22 characters, modification-templates doesn't quite fit in a
> 20 character column.

That column has length 50 for me, and also in kohastructure.sql. Don't know if
you created this table using a different version of Koha. If this can be
reproduced will address the issue.

Some things in the patch needed adjustment after changing to using template ids
instead of name. There is a problem with Elasticsearch in my devbox for recent
version of Koha which had not had time to fix, so was not able to properly test
the code. Meanwhile submitting and hoping for the best, will get back to
properly testing this once this issue has been sorted out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:29:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:29:39 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-knCqicGLZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:29:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:29:42 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-8Mvs4NxT3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 124992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124992&action=edit
Bug 29049: Simply holds priorty dropdown logic on request.pl

This patch makes a few changes:
1 - If we are not splitting the queue ( HoldsSplitQueue == 'nothing' ) then
    there are no changes for 'virtual' vs 'actual' numbering
2 - If we are splitting the queue you cannot use the dropdown, so we do not
need to process the options
3 - If the hold is 'found' we do not need to process the options
4 - We can simply use the 'last priority' to build the options, we do not need
to process in the script
5 - We can use a block to build the options
6 - Remove a stray holds.index

To test:
 1 - Place 5 holds on a bib
 2 - 'Find' two of the holds i.e. check them in to set status to 'transit' or
'waiting'
 3 - View the holds page for the biblio
 4 - Inspect the priorty dropdown for the found holds, note they have options
for 1-5 but are disabled
 5 - Note the dropdowns for other holds have options 1-5
 6 - Note options 4&5 in the dropdowns have no effect
 7 - Apply patch
 8 - Inspect the priority dopdowns on the found holds
 9 - Note they only show their found status
10 - Note the other dropdowns only show options 1-3
11 - Test with other HoldsSplitQueue options and HoldsSplitQueueNumbering
12 - When holds queue is split, no dropdowns should be active and should show
only their current priority
13 - When  HoldsSplitQueueNumbering is 'virtual' the dropdown should be
disabled and correctly count the number of unfound holds in the list

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:29:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:29:50 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-KMPilL38im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 16:34:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 14:34:06 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-bpqUXF0Mxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:02:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:02:23 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-OLKXMJ0FXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #60 from Phil Ringnalda <phil at chetcolibrary.org> ---
https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=02cf864ddd7f0f2ca6a921ae2a9045a18e1375f6;hb=HEAD#l4987
- type is 20, no?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:13:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:13:06 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-9oaTyPjZ6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

--- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Marcel, the following code worked for me

hr {
    page-break-after: always;
    border: 0px solid black !important;
}

First times did not work, but I believe it was browser's cache or memcached

Could you try again, please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:03 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-shfemekOcK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:06 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-3n959t3Hgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124952|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:09 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-nJWmU6DSnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124953|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:11 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-ZfhPgP9TSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124954|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:14 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-1kFhzfXMtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124955|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:17 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-XkpET0XDCQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124956|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:51 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-k52IRONxFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:14:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:14:56 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-ddLBerv7VF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124993&action=edit
Bug 27947: Add authorised values list in article requests cancellation

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:02 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-kARojaYyu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124994&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:07 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-dgwb0sbQZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124995&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:12 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-byJuW9uvfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124996&action=edit
Bug 27947: (follow-up) Improve atomic update

We do not need to replace the whole notice text, we only need to
replace the reference to article_requests.notes.

Test plan:
Run the dbrev. Verify result for notice AR_CANCELED.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:18 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-9cWZNUKhc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124997&action=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too

Something that currently comes up now already too:
If the user cancels from the OPAC page, there is no reason in the notice.
We could simply add one now.

Test plan:
Run dbrev to add the OPAC authval.
Create new AR and cancel it from OPAC.
Verify notice created for the user.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:24 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-IvWhzfNQch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124998&action=edit
Bug 27947: (QA follow-up) Refactor routes

This patch refactors the route specs a bit, and also reorganizes code
for easier tracking.

Unused exceptions that were added earlier are removed for now.

A follow-up patch will add tests to this routes.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:15:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:15:29 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-sAmAr4zQam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 124999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124999&action=edit
Bug 27947: Add regression tests for routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:35:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:35:15 +0000
Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive
 integration
In-Reply-To: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28537-70-XFTMUCZv6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20168


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168
[Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:35:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:35:15 +0000
Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to
 bootstrap v4
In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20168-70-U86lEthyIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28537


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537
[Bug 28537] Improve HTML generated by OverDrive integration
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:40:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:40:53 +0000
Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive
 integration
In-Reply-To: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28537-70-AaoOittwKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121748|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125000&action=edit
Bug 28537: Improve HTML generated by OverDrive integration

This patch makes changes to the way HTML is generated when showing
output from OverDrive integration:

- Buttons have Bootstrap button classes
- Layout of information is improved.
- Handling of cover image thumbnails is improved, especially in cases
  where images were much larger than expected.
- An OverDrive-specific CSS file is added.

To test you must have valid credentials entered in system preferences
for the OverDrive API. You should test using a patron who has holds and
current checkouts in OverDrive.

Apply the patch and log in to the OPAC.

- On the "Your summary" page, open the "OverDrive Account" tab.
  - Log in to your OverDrive account.
  - The contents of the tab should display well, with item
    thumbnails showing in a column to the left, and item information
    showing to the right.
  - Controls should be styled with standard Bootstrap style.
  - Confirm that operations work correctly: Acessing titles, checking
    in, canceling holds, etc.

- Perform a catalog search which will return results also found in your
  OverDrive collection.
  - Open the OverDrive results page.
  - The page should display correctly, especially thumbnails.
  - Confirm that operations work correctly: Checking out and placing
    holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 17:40:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 15:40:57 +0000
Subject: [Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive
 integration
In-Reply-To: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28537-70-GNem6SaNps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125001&action=edit
Bug 28537: (follow-up) Correct and improve OverDrive checkout modal

This patch corrects the markup of the modal which is displayed when the
user clicks the "Download as" button in their list of OverDrive
checkouts. The modal markup had not been updated in the conversion to
Bootstrap 4.

I have also modified the markup generated when listing the download
format options so that they use some standard Bootstrap 4 classes,
improving the layout a little.

To test you must have valid credentials entered in system preferences
for the OverDrive API. You should test using a patron who has holds and
current checkouts in OverDrive.

Apply the patch and log in to the OPAC.

- On the "Your summary" page, open the "OverDrive Account" tab.
  - Log in to your OverDrive account.
  - In the list of current checkouts, click the "Download as" button for
    one of the titles.
    - A modal window should display with a list of radio buttons for
      each available format.
      - Confirm that the format text acts as the label for the radio
        button.
      - Confirm that closing the modal without making a selection works
        correctly.
      - Confirm that making a selection and submitting the form closes
        the modal and submits your choice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:13 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-j4KbAfwYji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124993|0                           |1
        is obsolete|                            |

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125002&action=edit
Bug 27947: Add authorised values list in article requests cancellation

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:17 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-HCGH7TupIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124994|0                           |1
        is obsolete|                            |

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125003&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:21 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-V1NseUW997@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124995|0                           |1
        is obsolete|                            |

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125004&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:25 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-Ea4tu0rnf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124996|0                           |1
        is obsolete|                            |

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125005&action=edit
Bug 27947: (follow-up) Improve atomic update

We do not need to replace the whole notice text, we only need to
replace the reference to article_requests.notes.

Test plan:
Run the dbrev. Verify result for notice AR_CANCELED.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:30 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-o5D1fuDIFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124997|0                           |1
        is obsolete|                            |

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125006&action=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too

Something that currently comes up now already too:
If the user cancels from the OPAC page, there is no reason in the notice.
We could simply add one now.

Test plan:
Run dbrev to add the OPAC authval.
Create new AR and cancel it from OPAC.
Verify notice created for the user.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:35 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-0zD5juXKHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124998|0                           |1
        is obsolete|                            |

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125007&action=edit
Bug 27947: (QA follow-up) Refactor routes

This patch refactors the route specs a bit, and also reorganizes code
for easier tracking.

Unused exceptions that were added earlier are removed for now.

A follow-up patch will add tests to this routes.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:39 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-7hBA4Tqu4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124999|0                           |1
        is obsolete|                            |

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125008&action=edit
Bug 27947: Add regression tests for routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:43 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-jJ8cBBLQcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125009&action=edit
Bug 27947: (QA follow-up) Remove incorrect permission check

The API was checking for 'reserverforothers' permission, but that
doesn't make sense to apply here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:16:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:16:48 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-7DgtlnhraE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125010&action=edit
Bug 27947: (QA follow-up) Update test to highlight issue

This addition to the tests highlights a permissions/security check
error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:20:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:20:21 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-crysdTJbzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry guys.. little more needed here.

My first followup drops the 'reserveforothers' permission requirement as I
don't think that relates to this functionality.. but it makes the API tests
fail.. and I can't see why.. code blind on a Friday.

My second followup highlights an issue with the public route.  Although moving
the route under /public/patrons/{patron_id} ensure we do a patron identity
check.. there isn't actually a later check anywhere that the article your
trying to delete actually belongs to the patron ;)

This final one is actually why I preferred the original
/article_requests/{request_id} approach.. though of course that would require
the addition of a routine to handle checking borrowernumber in the article
request against the user as per the other routines for checking allow-owner.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:25:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:25:36 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-yjPGzWchvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:25:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:25:40 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-NvRvdQmsXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122749|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125011&action=edit
Bug 28472: handle items with NULL shelving location

The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).

This patch, based on the comment made by Nick Clemens, fixes that.

Test plan (based on the original Bug Description by Andrew Fuerste-Henry):

1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to
CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:25:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:25:45 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-FLInebikBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124989|0                           |1
        is obsolete|                            |

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125012&action=edit
Bug 28472: (follow-up) add unit test for the case where location = NULL

This patch adds an extra unit test, to cover the case where the
UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART"
and the item being returned has no shelving location set.

Test plan:

1) Apply the patch provided earlier
2) prove -v t/db_dependent/Circulation/issue.t
   ...and sign off if all tests pass.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:30:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:30:51 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-QLh6NmbiSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #12 from Hannah Co <hannah.co at northwestu.edu> ---
(In reply to Andreas Roussos from comment #9)
> (In reply to Hannah Co from comment #6)
> > I don't believe this patch catches items in "processing" that should end up
> > with no shelving location. I have a freshly updated 21.05, with this patch
> > included. My system pref UpdateItemLocationOnCheckin contains "PROC:
> > _PERM_". Check-in does not make any changes to a record with "PROC" location
> > and no other shelving location assigned. 
> > 
> > New items are automatically created with location AND permanent_location
> > both set as PROC. It seems that "PROC" and "CART" should never populate
> > permanent_location. Can we prevent "PROC" from populating the
> > permanent_location?
> > 
> > Or, can we handle the situation where "PROC" exists in both
> > permanent_location AND location, so the location is completely removed and
> > replaced with NULL?
> Hi Hannah!
> Perhaps I've misunderstood what you're describing in your comment, but to me
> it looks like it's a different scenario than the one in the Description of
> this bug report. Perhaps your report deserves to be submitted as a new bug?

Hi Andreas, I can certainly start a new bug report - I can report a bug for my
situation, but would it be better to create a bug that covers the whole issue
of "UpdateItemLocationOnCheckin not updating items where location is null"? The
_ALL_: CART issue discussed above is another highly specific case, and I don't
quite understand why the fix for that doesn't help in my situation. I feel like
there's a larger issue of location = NULL needing to be handled in all
situations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:36:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:36:53 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-Gaolb5zel6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125013&action=edit
Bug 29049: (follow-up) Reduce number of line returns in page

While moving the dropdown to a block, I noticed the page size was very large
when there are many holds

This patch chomps a large amoutn of whitespace, from the block and elsewhere
and drecreased the paeg from about 400k lines to 25k lines for a record with
~200 holds

To test:
1 - Apply previous patch
2 - Load holds tab for a biblio
3 - Save the page as html from your browser, note the size of the file
4 - Apply patch this
5 - Reload and repeat
6 - Note the size is much smaller

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:43:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:43:32 +0000
Subject: [Koha-bugs] [Bug 28895] Don't fill in items.location with
 NewItemsDefaultLocation if blank
In-Reply-To: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28895-70-0BapUzcCIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Agreed, I would like to be able to set a blank shelving location on a new item,
have it go to the location set in NewItemsDefaultLocation, then go to a blank
shelving location on a later checkin.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 18:53:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 16:53:40 +0000
Subject: [Koha-bugs] [Bug 28895] Don't fill in items.location with
 NewItemsDefaultLocation if blank
In-Reply-To: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28895-70-kh5uGAl7L5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895

--- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Actually, testing this on master this morning it's very much not working as
intended.

I have NewItemsDefaultLocation set to PROC.
On additem.pl, when I create a load the new item page, location is
automatically set to PROC. If I create my item without changing it, the item
has both location and shelving_location set to PROC.
There is no reason to set the default to PROC here, but I guess it doesn't hurt
anything.

On additem.pl, if I change the shelving location to any value other than PROC
before I create my item, both the location and permanent location are set to
whatever new value I've selected.
Whatever I've selected should go into permanent_location, but location should
be PROC.

If I delete PROC without selecting something else on creating my item, then
location and permanent_location end up as PROC anyway.
This bug asserts that in this case I should get location=PROC and
permanent_location=NULL. I support that change.

This could debatably be a new bug, but there are a lot of old bugs around this
syspref already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:00:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:00:55 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-vbWFbB4Z0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Hannah, just making sure you saw bug 28895.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:09:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:09:43 +0000
Subject: [Koha-bugs] [Bug 29050] New: Add punctuation in Unseen Renewals
 message
Message-ID: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

            Bug ID: 29050
           Summary: Add punctuation in Unseen Renewals message
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

In the Checkouts tab of the patron record, the counts of renewals and unseen
renewals need some punctuation. Right now they say something like "(W of X
renewals remainingY of Z unseen renewals remaining." That needs at least a
comma and a space in the middle, for ""(W of X renewals remaining, Y of Z
unseen renewals remaining."


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:09:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:09:43 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-PGc6rr6Gbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29050


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050
[Bug 29050] Add punctuation in Unseen Renewals message
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:20:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:20:51 +0000
Subject: [Koha-bugs] [Bug 28895] Don't fill in items.location with
 NewItemsDefaultLocation if blank
In-Reply-To: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28895-70-VSkkp4kdzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895

Hannah Co <hannah.co at northwestu.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hannah.co at northwestu.edu

--- Comment #6 from Hannah Co <hannah.co at northwestu.edu> ---
(In reply to Andrew Fuerste-Henry from comment #5)
> Actually, testing this on master this morning it's very much not working as
> intended.
> 
> I have NewItemsDefaultLocation set to PROC.
> On additem.pl, when I create a load the new item page, location is
> automatically set to PROC. If I create my item without changing it, the item
> has both location and shelving_location set to PROC.
> There is no reason to set the default to PROC here, but I guess it doesn't
> hurt anything.
> 
> On additem.pl, if I change the shelving location to any value other than
> PROC before I create my item, both the location and permanent location are
> set to whatever new value I've selected.
> Whatever I've selected should go into permanent_location, but location
> should be PROC.
> 
> If I delete PROC without selecting something else on creating my item, then
> location and permanent_location end up as PROC anyway.
> This bug asserts that in this case I should get location=PROC and
> permanent_location=NULL. I support that change.
> 
> This could debatably be a new bug, but there are a lot of old bugs around
> this syspref already.

In order for UpdateItemLocationOnCheckin to work correctly for items with no
shelving location, the NewItemsDefaultLocation needs to stay out of the
permanent_location field. If NewItemsDefaultLocation is set to PROC, and
UpdateItemLocationOnCheckin has the line "PROC: _PERM_" items with no shelving
location remain in processing and don't get shelving location changed to NULL
on checkin, as they should. 

I agree that at item creation, if a shelving location is not selected then the
item should have location=PROC and permanent_location=NULL.

When editing an item, the NewItemsDefaultLocation currently replaces a NULL
value. If the shelving location is NULL, NewItemsDefaultLocation should not
replace the NULL upon editing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:28:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:28:42 +0000
Subject: [Koha-bugs] [Bug 29051] New: Seen renewal methods incorrectly
 blocked
Message-ID: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

            Bug ID: 29051
           Summary: Seen renewal methods incorrectly blocked
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 24083

To recreate:
1 - turn on UnseenRenewals
2- confirm AllowRenewalLimitOverride is off
3- set your all/all rule to allow 1 unseen renewal, more than 1 regular renewal
4- check item out to patron, make sure you're following the all/all rule
5- renew item from OPAC as patron
6- confirm OPAC and intranet tell you next renewal must be at library but that
you have renewals remaining
7- try to renew with the Renew Selected button in the Checkouts tab, you cannot
select this checkout
8- try to renew with the Renew All button in the Checkouts tab, the item does
not renew
9- try to check the item out to the patron again, get message "No more renewals
possible"
10 - try to renew by putting the barcode in the big Renew box at the top of the
page, get message "E Street shuffle : ( 1 ) has been renewed the maximum number
of consecutive times without being seen by the library )"

That leaves staff with no way to perform a Seen renewal and reset the count un
Unseen renewals, which means the patron is stuck and the item must be returned,
which makes this feature deeply flawed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
[Bug 24083] Koha should support "seen" vs "unseen" renewals
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 19:28:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 17:28:42 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-1FTkGf5ndy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29051


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051
[Bug 29051] Seen renewal methods incorrectly blocked
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:04:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:04:30 +0000
Subject: [Koha-bugs] [Bug 29052] New: Make consistent use of spans and div
 with hint class
Message-ID: <bug-29052-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052

            Bug ID: 29052
           Summary: Make consistent use of spans and div with hint class
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

When adding help text alongside input fields in staff interface forms the text
should be wrapped in <span class="hint"> or <div class="hint">. This patch will
make corrections to several pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:18:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:18:58 +0000
Subject: [Koha-bugs] [Bug 29052] Make consistent use of spans and div with
 hint class
In-Reply-To: <bug-29052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29052-70-mrjaXpE2A9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:19:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:19:01 +0000
Subject: [Koha-bugs] [Bug 29052] Make consistent use of spans and div with
 hint class
In-Reply-To: <bug-29052-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29052-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29052-70-67CsQ5ilYP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29052

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125014&action=edit
Bug 29052: Make consistent use of spans and div with hint class

This patch makes minor HTML corrections to several templates, primarily
to wrap form help text in <span class="hint"> or <div class="hint">.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View the following pages to confirm that forms look correct:

- Administration -> Authority types -> Authority type -> Edit.
- Administration -> Authority types -> Authority type -> MARC structure.
  -> Subfields -> Edit.
- Administration -> Authorised values -> View category -> New authorized
  value.
- Administration -> Credit types -> New credit type.
- Administration -> Debit types -> New debit type.
- Administration -> Item types -> New item type.
  Also changed: Added link to ITEMTYPECAT authorized value page for
  users with the correct permission.
- Administration -> MARC frameworks -> MARC structure -> Edit subfields.
- Administration -> Patron attribute types -> New patron attribute type.
- Administration -> Share content with Mana KB.
- Administration -> Z39.50/SRU servers -> New Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:30:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:30:57 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-rpqnM9xmpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
See bug 28813 where I fixed the issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:34:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:34:12 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-sJ2HOaBBFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
To clarify, the followups here that converted from string note to translatable
code broke the feature entirely ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:50:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:50:33 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-pYr4B0V7Qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 20:50:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 18:50:37 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-QbmDxCLEs5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125015&action=edit
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 21:26:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 19:26:19 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-JV58lqaYph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #40 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125016&action=edit
Bug 27947: (QA follow-up) Clarify permissions

Privileged routes need permissions defined. This patch adds the minimum
required permission until there are article request-specific permissions
in Koha: circulate: circulate_remaining_permissions

It is also clarified that interacting with an article request  from
another patron, but having your own patron_id in the path would return
404 instead of 403, as technically the resource (an article request from
the patron, identified.by the supplied id) doesn't exist.

Tests are tweaked.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 21:29:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 19:29:28 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-xEgDB9vUTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 17 21:38:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Sep 2021 19:38:42 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-kn2OEvWSSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #39)
> Sorry guys.. little more needed here.
> 
> My first followup drops the 'reserveforothers' permission requirement as I
> don't think that relates to this functionality.. but it makes the API tests
> fail.. and I can't see why.. code blind on a Friday.

The permissions were wrong.

You just missed the fact that privileged routes require at least one permission
(catalogue: 1 being the bare minimum). I think we never fixed this:
https://gitlab.com/koha-community/qa-test-tools/-/issues/11

> My second followup highlights an issue with the public route.  Although
> moving the route under /public/patrons/{patron_id} ensure we do a patron
> identity check.. there isn't actually a later check anywhere that the
> article your trying to delete actually belongs to the patron ;)

There's an implicit check by doing:

   $article_requests = $patron->article_requests->find( $article_request_id );

I clarified this with a comment in the code on the latest patch. I agree with
returning 404 there, as 403 would 'leak' the fact that the ID exists... Not
sure how important it is, but I think it is correctly tested to avoid security
issues.

> This final one is actually why I preferred the original
> /article_requests/{request_id} approach.. though of course that would
> require the addition of a routine to handle checking borrowernumber in the
> article request against the user as per the other routines for checking
> allow-owner.

allow-owner falls short. It feels like with routes with multiple ids in the
path we need to think a bit more [1]. I think object 'ownership' validation
should be baked into the objects in a declarative way. But that's for another
day/bug.

[1] I tried adding a validator for article requests in Koha::REST::V1::Auth,
but it failed randomly depending on which 'key' was picked first (patron_id vs.
article_request_id). It feels like a big refactoring is needed there. Or just
keep the patron_id from the path and leave the rest to  the controllers, as in
this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:15:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:15:54 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-AaSLeFBotN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:15:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:15:58 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-6mCtGIzpe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124574|0                           |1
        is obsolete|                            |
 Attachment #124575|0                           |1
        is obsolete|                            |
 Attachment #124576|0                           |1
        is obsolete|                            |
 Attachment #124577|0                           |1
        is obsolete|                            |
 Attachment #124797|0                           |1
        is obsolete|                            |
 Attachment #124831|0                           |1
        is obsolete|                            |

--- Comment #23 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125017&action=edit
Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules

This patch removes the code from the search scripts into QueryBuilder
modules.

To test:
1 - Have a library group defined as a search group for both staff and opac
2 - Search on staff client and opac with that group limit and a single branch
limit
3 - Note your results/counts
4 - Note the visuals of the search description
5 - Apply patch
6 - Repeat searches
7 - All should work as before

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:16:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:16:02 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-gUL4i9RCsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #24 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125018&action=edit
Bug 28847: Unit tests

Note: tests are very similar between ES and Zebra, however, ES requires the
uppercase
OR and doesn't use '=' in the same way. I feel having test coverage in each
module is fair and more future
proof in case of changes to search engine

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:16:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:16:07 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-hkzC9O3Yqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #25 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125019&action=edit
Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT

The opac had 'branch_group_limit' parameters which can be simplified to more
closely match intranet code.

Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate

Expand JS to prevent selection of single and multibranch limits

To test:
1 - Enable OpacAddMastheadLibraryPulldown system preference
2 - Ensure branches and groups show as before patch
3 - Ensure single and multibranch limits from masthead apply as expected
4 - Test advanced search page, ensure you cannot select both single and
multibranch limit
5 - Follow test plan on 28845 - ensure multibranch limit still correctly
pre-selected

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:16:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:16:11 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-RAf5z4D9Sc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #26 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125020&action=edit
Bug 28847: Only apply JS to branch/multibranch selection if there are search
groups

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:16:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:16:15 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-I7Ht1ec9af@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #27 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125021&action=edit
Bug 28847: (follow-up) Handle branch_group_limit

To test:
1 - Create a library group as an OPAC search group
2 - Enable OpacAddMastheadLibraryPulldown
3 - Browse to:
   
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=t&branch_group_limit=multibranchlimit-1&weight_search=1
4 - Confirm search works and returns correct results
5 - Confirm dropdown is correctly populated

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:16:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:16:19 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-Igkgdt9mTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #28 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125022&action=edit
Bug 28847: Remove dead code and make regex consistent

This updates the regex code to match throughout the routine and removes
code that would no longer be reached.

Note that the code to update library name in the query descruiption was
broken before this patch, so removal does not change behaviour

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:17:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:17:06 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-7EF3NVE6ya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 10:42:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 08:42:11 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-PHHzZIz92G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
The get_from_cache() function cannot be called without any value because it
calls croak() if done so. This change will at least break the Koha installer,
http://localhost:8081/cgi-bin/koha/installer/install.pl. Please also fix the
typo in the commit title and check with perltidy your code follows the coding
style: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 11:45:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 09:45:21 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-DbVzwbp5il@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 11:45:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 09:45:25 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-RM6YSDjyiG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124882|0                           |1
        is obsolete|                            |

--- Comment #15 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125023&action=edit
Bug 28914: Fix wording in authentication forms

In most authentication forms we see :
Fields "Login:" and "Password:" with a submit button "Log in".

In some places submit button contains "Login", which is confusing for
translation.
It is not correct according to terminology
https://wiki.koha-community.org/wiki/Terminology#L
Also in opac-user.pl ":" is missing, it generates new translation entries.

Test plan:
1) Log out if you are logged in
2) Go to staff interface
3) Check you see button "Log in"
4) Go to OPAC page /cgi-bin/koha/opac-user.pl
5) Check you see fields "Login:" and "Password:"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 11:46:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 09:46:01 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-7oHo0SaNzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:20:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:20:14 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-XM9OSBEMa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:20:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:20:18 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-27INbxmkwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124328|0                           |1
        is obsolete|                            |

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125024&action=edit
Bug 18747: Select All in Add Patron Option in Patron Lists only selects the
first 20 entries

This patch corrects the JavaScript functions for the "select all" and
"clear all" action when viewing patrons in a list. Before this
correction, checkboxes which were previously in hidden table rows would
not be checked.

To test, apply the patch and go to Patrons -> Patron Lists

- View a patron list
- If necessary, add multiple patrons to the list so that the number
  exceeds 20.
- Change the number of entries shown by the DataTable: Show [ 50 ]
  entries.
- Click "Select all." All visible checkboxes should be checked.
- Click "Clear all." All checkboxes should be unchecked.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:21:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:21:22 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-rGjJsoU1e0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:35:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:35:40 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-gRLLmAM04A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:35:44 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-bHeC2fbL4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124662|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125025&action=edit
Bug 28972: Add missing foreign key constraints to holds queue table

The table tmp_holdsqueue is missing a couple key constraints that should
be there, one for biblio and one for borrowers.

Test Plan:
1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or
borrowers
2) Apply this patch
3) Run updatedatabase.pl
4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or
borrowers

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 12:36:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 10:36:33 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-wweGCcK7Sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:19:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:19:38 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-8wyZ7abqYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:19:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:19:42 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-kx9O4PPFFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124430|0                           |1
        is obsolete|                            |
 Attachment #124431|0                           |1
        is obsolete|                            |

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125026&action=edit
Bug 28676: Cache and retrieve match_count when searching a cached heading

We use match_count to determine if a new authority record should be created,
however,
we were not adding this count to the cache, so if a record returned too many
matches on first
lookup, we would create a new record on the second lookup

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and 
CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add two headings for that authority to a bib record (e.g. a 610 and 710)
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:24:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:24:32 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-pVRxnGnUWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Fixes the problem, also as well for link_bibs_to_authorities.pl where the same
issue occurred. This patch doesn't update the match_count value to cache in the
update_cache() function even though it should, but the function was already
buggy before this (it didn't update correctly the fuzzy value), and I think
what we should do there is call the get_link() with a parameter to tell ignore
cache so it will correctly then populate the cache values – but it's out of
scope for this bug.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:29:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:29:08 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-7vOeKRrZdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125026|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125027&action=edit
Bug 28676: Unit test

Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:29:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:29:11 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-TEu36MdJM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125028&action=edit
Bug 28676: Cache and retrieve match_count when searching a cached heading

We use match_count to determine if a new authority record should be created,
however,
we were not adding this count to the cache, so if a record returned too many
matches on first
lookup, we would create a new record on the second lookup

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and 
CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add two headings for that authority to a bib record (e.g. a 610 and 710)
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 15:30:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 13:30:13 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-JYoAsExQwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Joonas Kylmälä from comment #6)
> Fixes the problem, also as well for link_bibs_to_authorities.pl where the
> same issue occurred. This patch doesn't update the match_count value to
> cache in the update_cache() function even though it should, but the function
> was already buggy before this (it didn't update correctly the fuzzy value),
> and I think what we should do there is call the get_link() with a parameter
> to tell ignore cache so it will correctly then populate the cache values –
> but it's out of scope for this bug.
> 
> Passing QA.

Forgot to attach the other patch, re-attached now with my sign-off again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 16:40:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 14:40:18 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-gWamFfAhqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 16:40:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 14:40:35 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-4mqz5oXrv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 16:40:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 14:40:45 +0000
Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29040-70-TlpWhahsSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124942|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 17:53:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 15:53:05 +0000
Subject: [Koha-bugs] [Bug 29053] New: ILSDI Internal Server errors seem not
 to log anywhere?
Message-ID: <bug-29053-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053

            Bug ID: 29053
           Summary: ILSDI Internal Server errors seem not to log anywhere?
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Had a situation where ILSDI was throwing an internal server error, but none of
the logs (plack-intranet-error, plack-error, intranet-error, plack-opac-error,
opac-error, or really anywhere in /var/log/koha/instance/) seemed to be logging
the errors.

I'd be happy to be wrong about this one lol.

Liz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 17:53:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 15:53:24 +0000
Subject: [Koha-bugs] [Bug 29053] ILSDI Internal Server errors seem not to
 log anywhere?
In-Reply-To: <bug-29053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29053-70-u64nUyRfPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 18 17:54:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 15:54:08 +0000
Subject: [Koha-bugs] [Bug 29053] ILSDI Internal Server errors seem not to
 log anywhere?
In-Reply-To: <bug-29053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29053-70-828t9iRrsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
The test case was a place hold via ilsdi, with a dateformat that was not in ISO
format, which was a bug with the requesting software.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:00:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:00:26 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-2FTWqFQ26O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:00:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:00:35 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-VbjUal4fJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125015|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 125029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125029&action=edit
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:00:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:00:40 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-Rwglo4jrds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 125030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125030&action=edit
Bug 28438: (follow-up) Capitalization: Various corrections

One mdditional correction.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:01:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:01:55 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-6SXsTyQjpL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Thanks Owen - some nice tidy-ups!

Testing notes:
- Reviewed diff in browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:14:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:14:05 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-PrMGFxa3Ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 00:14:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Sep 2021 22:14:16 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-aJgGQiGMiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124921|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 125031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125031&action=edit
Bug 29033: Add C4::Context->multivalue_preference

I've seen several places in which a syspref is retrieved and then
splitted using split and the fact they are pipe-separated strings.

It seems it would be simple (and handy) to add a method to do that.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Context.t
=> SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved
as an arrayref.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 10:30:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 08:30:31 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-lF29lK8u3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Signed Off                  |Failed QA

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Hayley Pelham from comment #5)
> Created attachment 124852 [details] [review]
> Bug 28934: Correct markup of GDPR consent in OPAC patron entry
> 
> This patch makes changes to the markup around the GDPR consent checkbox
> in the OPAC self-registration / update page to make it more consistent
> with other form fields on the page.
> 
> The patch also adds some missing attributes which are required to enable
> JavaScript validation of the checkbox.
> 
> To test, apply the patch and rebuild the OPAC CSS
> (https://wiki.koha-community.org/wiki/
> Working_with_SCSS_in_the_OPAC_and_staff_client).
> 
> - Go to Administration -> System preferences and Enable the system
>   preference PatronSelfRegistration.
> - Set the system preference GDPR_Policy to "Enforce".
> - Go to the OPAC and click the "Register here" link.
> - Under the "GDPR consent" heading near the bottom of the page,
>   confirm that the "I agree" checkbox lines up with other form fields on
>   the page, and that the "Required" label lines up below it.
> - Submit the form without checking the GDPR consent checkbox.
> - The form should not be submitted, and a "This field is
>   required" message should appear next to the checkbox label.
> 
> Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

The alignment is still slightly off with this patch, noticable if you put the
cursor to the input box above and then use down arrow to scroll to the
checkbox. Also, I would prefer we would use consistent way to show the fields,
i.e. always label and then the input form, this would make the alignment
perfect as well. The gender field has also the same problem. I could send a
patch to fix both of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 10:39:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 08:39:23 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-sck2aA67IT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 12:27:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 10:27:35 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-5SGDejTVTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 12:27:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 10:27:39 +0000
Subject: [Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC
 patron entry
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-ejFZUL48q0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124852|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125032&action=edit
Bug 28934: Make the OPAC registration form design consistent

The gender/sex and GDPR inputs were slightly misaligned (by
1.5em). Now they are aligned with the other inputs which have a width
of 10em (9em width + margin 1em). The label assignments and required
attributes for input elements are made also consistent.

To test:
 1) Enable GDPR_Policy syspref
 2) Apply patch, run "yarn build --view opac", restart plack
 3) Go to /cgi-bin/koha/opac-memberentry.pl
 3) Check that the GDPR input box shows the required text now in red
    color
 3) Check that the alignment of sex/gender and GDPR input matches with
    the other inputs perfectly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 12:36:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 10:36:56 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-1G0n04XFiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Correct markup of GDPR      |OPAC registration form
                   |consent in OPAC patron      |design is not consistent
                   |entry                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 13:27:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 11:27:26 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-KAqOwuTd6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
hmm, this disables the hide_patron_infos_if_needed variable which is probably
not wanted, though the feature is quite broken anyways but this makes it more
broken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 14:01:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 12:01:40 +0000
Subject: [Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module
In-Reply-To: <bug-28903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28903-70-fi17dwAHp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
             Status|Signed Off                  |Failed QA

--- Comment #13 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Proposed fix would select the option if you just hover your mouse cursor over
the option and then click outside the box after that --> will cause most
definitely unintended changes and was not the previous behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 14:36:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 12:36:06 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-n3Roh1n77Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 14:36:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 12:36:10 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-cPi6vkTBtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125011|0                           |1
        is obsolete|                            |
 Attachment #125012|0                           |1
        is obsolete|                            |

--- Comment #14 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125033&action=edit
Bug 28472: handle items with NULL shelving location

The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).

This patch, based on the comment made by Nick Clemens, fixes that.

Test plan (based on the original Bug Description by Andrew Fuerste-Henry):

1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to
CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 14:36:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 12:36:14 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-ZOgPXkh8BO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #15 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125034&action=edit
Bug 28472: (follow-up) add unit test for the case where location = NULL

This patch adds an extra unit test, to cover the case where the
UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART"
and the item being returned has no shelving location set.

Test plan:

1) Apply the patch provided earlier
2) prove -v t/db_dependent/Circulation/issue.t
   ...and sign off if all tests pass.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 14:41:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 12:41:54 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-fl8XRKKK4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #16 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Hannah Co from comment #12)
> Hi Andreas, I can certainly start a new bug report - I can report a bug for
> my situation, but would it be better to create a bug that covers the whole
> issue of "UpdateItemLocationOnCheckin not updating items where location is
> null"? The _ALL_: CART issue discussed above is another highly specific
> case, and I don't quite understand why the fix for that doesn't help in my
> situation. I feel like there's a larger issue of location = NULL needing to
> be handled in all situations.

Opening a new bug report for your issue seems like the best idea, the problem
here (by reading the code) is just specific to the _ALL_ configuration value
and not to the other ones.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 15:02:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 13:02:20 +0000
Subject: [Koha-bugs] [Bug 26626] When checking in a hold that is not found
 the X option is 'ignore' and when hold is found it is 'cancel'
In-Reply-To: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26626-70-DecIHJ5qDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 15:20:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 13:20:58 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-RjyFLaYqoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #13 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
So can we just obsolete those two patches? Let me know when this is ready for
QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 19:51:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 17:51:26 +0000
Subject: [Koha-bugs] [Bug 11388] Error exporting records to
 non-Unicode/MARC-8
In-Reply-To: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11388-70-2fARgJg4tY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Bug still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 19:56:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 17:56:42 +0000
Subject: [Koha-bugs] [Bug 11388] Error exporting records to
 non-Unicode/MARC-8
In-Reply-To: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11388-70-Amqy2bh3YU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|joonas.kylmala at iki.fi       |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 22:29:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 20:29:50 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-UAtudFn9fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 22:29:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 20:29:55 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-DzoeBiKgDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124112|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 125035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125035&action=edit
Bug 28906: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 22:29:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 20:29:59 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-eXToSqJIoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124113|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 125036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125036&action=edit
Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context

This patch makes the method honour list context.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail! It returns [Koha::Items]. Boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 22:30:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 20:30:05 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-82eIzEIcnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124115|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 125037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125037&action=edit
Bug 28906: (26223 follow-up) Remove use of as_list

This bug makes Koha::Items->filter_by_visible_in_opac honour list
context, so this explicit call is not needed.

To test:
1. Pick a biblio in the OPAC
2. Go to the ISBD view
=> SUCCESS: It renders correctly
3. Apply this patch and restart Plack
4. Refresh the ISBD view page
=> SUCCESS: It doesn't break!
5. Check opac-reserve.pl doesn't break either
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 19 22:59:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 20:59:38 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-hVJXLGlKTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 28377: Use the API to suspend/resume holds
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M       koha-tmpl/intranet-tmpl/prog/js/holds.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/holds.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 28377: Use the API to suspend/resume holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 00:05:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 22:05:52 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-CYlU0J1L82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Karen,
could you maybe add a step by step where you end up in this kind of situation?
I haven't seen that error/message yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 00:07:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 22:07:23 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout
In-Reply-To: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29011-70-lt9wZIJz2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Another thing to check:
Make sure that all your items have itemtype, holding branch and home branch
set. These are the subfields a, b, and y in the item form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 01:47:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Sep 2021 23:47:10 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-Z3aYPIHWua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

--- Comment #19 from wainuiwitikapark at catalyst.net.nz ---
On 19.11.x 

Test Result (2 failures / ±0)

    t_db_dependent_api_v1_biblios_t.get() tests (703)
    t_db_dependent_api_v1_biblios_t.get_public() tests (703)

I am getting these failtures

Can someone please write a patch for that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 02:01:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 00:01:25 +0000
Subject: [Koha-bugs] [Bug 11388] Error exporting records to
 non-Unicode/MARC-8
In-Reply-To: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11388-70-0iCTrFwaGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 02:10:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 00:10:00 +0000
Subject: [Koha-bugs] [Bug 11388] Error exporting records to
 non-Unicode/MARC-8
In-Reply-To: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11388-70-oTfa6n0xdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 02:11:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 00:11:40 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-tblwPubzg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 02:14:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 00:14:33 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-hE2WKJ9vMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I don't know about this one...

There are also multi value preferences that don't use pipes. Many preferences
like "NotesToHide" and "ILS-DI:AuthorizedIPs" use commas instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 02:17:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 00:17:18 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-rSgCqBZolB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
"SubfieldsToAllowForRestrictedBatchmod",
"SubfieldsToAllowForRestrictedEditing", and "SubfieldsToUseWhenPrefill" are
separated by spaces. 

"AdvancedSearchLanguages" is separated by pipe or comma, which would make this
method particularly problematic...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 05:16:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 03:16:26 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-3AFEi082D2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

--- Comment #8 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Hi Joonas,

The alignment is much closer to the other form elements now, which is great.

However, if all required fields are completed except the GDPR checkbox, we
don't get the 'This field is required' text and highlighting like we do for
other elements.

Should this be present?

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 06:18:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 04:18:14 +0000
Subject: [Koha-bugs] [Bug 29054] New: Stop warns from advance_notices.pl if
 not running in verbose mode
Message-ID: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054

            Bug ID: 29054
           Summary: Stop warns from advance_notices.pl if not running in
                    verbose mode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hayleypelham at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

When the advance_notices.pl cronjob is run and the EnhancedMessagingPreferences
syspref is set to don't allow, we get the following warning:

The "EnhancedMessagingPreferences" syspref is off.
Therefore, it is unlikely that this script will actually produce any messages
to be sent.
To change this, edit the "EnhancedMessagingPreferences" syspref.

The advance_notices.pl script help says:

-v      Verbose. Without this flag set, only fatal errors are reported.

However, the above warning is shown regardless of whether the script is run
with the verbose flag.

We need to add a verbosity check to this warn

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 06:18:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 04:18:29 +0000
Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not
 running in verbose mode
In-Reply-To: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29054-70-h4OmfZ1Dch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |hayleypelham at catalyst.net.n
                   |ity.org                     |z
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 06:21:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 04:21:11 +0000
Subject: [Koha-bugs] [Bug 29055] New: Focus on keyword field when
 subscription biblio search window opens
Message-ID: <bug-29055-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29055

            Bug ID: 29055
           Summary: Focus on keyword field when subscription biblio search
                    window opens
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
1. Go to Serials and Add a new subscription
2. Search for a record
3. There is only one search field (keyword), and you have to click into it to
use it. It should be focussed as the window opens so the cursor starts in
there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 07:22:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 05:22:34 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-AbXESBOogJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #64 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Gosh, I didn't realise I had made that change in follow up and hadn't tested it
properly. My bad, sorry. Thanks Martin for fixing this :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 08:53:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 06:53:15 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout
In-Reply-To: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29011-70-HUElXyQF0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

--- Comment #3 from JanMueck <jan.michael.mueck at uni-hamburg.de> ---
Hello and sorry for the late response.

Yes i have access to the logs. What files do you need?

I found out that the error only occures when the Pseudonymization (DSGVO) is
enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 08:56:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 06:56:56 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout
In-Reply-To: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29011-70-XDXxcK2Lui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

--- Comment #4 from JanMueck <jan.michael.mueck at uni-hamburg.de> ---
subfields a, b, and y are set on all items on our test server

kind regards
Jan

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 09:34:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 07:34:07 +0000
Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages
In-Reply-To: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14723-70-BFVIeXj64r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
No worries at all, we all do it sometimes :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:18:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:18:10 +0000
Subject: [Koha-bugs] [Bug 12227] Remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-Uj64Fmb1ZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
found some remnants: 
https://git.koha-community.org/Koha-community/Koha/search?q=C4%3A%3AContext+config+demo
https://git.koha-community.org/Koha-community/Koha/src/branch/master/svc/config/systempreferences#L98

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:02 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-O85BCqnUH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125002|0                           |1
        is obsolete|                            |

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125038&action=edit
Bug 27947: Add authorised values list in article requests cancellation

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:08 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-JG19LyKWLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125003|0                           |1
        is obsolete|                            |

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125039&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:12 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-oADJntYhjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125004|0                           |1
        is obsolete|                            |

--- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125040&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:16 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-HFOlwmu6Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125005|0                           |1
        is obsolete|                            |

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125041&action=edit
Bug 27947: (follow-up) Improve atomic update

We do not need to replace the whole notice text, we only need to
replace the reference to article_requests.notes.

Test plan:
Run the dbrev. Verify result for notice AR_CANCELED.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:20 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-eAC06H2h2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125006|0                           |1
        is obsolete|                            |

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125042&action=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too

Something that currently comes up now already too:
If the user cancels from the OPAC page, there is no reason in the notice.
We could simply add one now.

Test plan:
Run dbrev to add the OPAC authval.
Create new AR and cancel it from OPAC.
Verify notice created for the user.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:24 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-yoRm2NNbj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125007|0                           |1
        is obsolete|                            |

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125043&action=edit
Bug 27947: (QA follow-up) Refactor routes

This patch refactors the route specs a bit, and also reorganizes code
for easier tracking.

Unused exceptions that were added earlier are removed for now.

A follow-up patch will add tests to this routes.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:30 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-pgxCaH7W4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125008|0                           |1
        is obsolete|                            |

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125044&action=edit
Bug 27947: Add regression tests for routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:40 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-tiyTHwLfun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125009|0                           |1
        is obsolete|                            |

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125045&action=edit
Bug 27947: (QA follow-up) Remove incorrect permission check

The API was checking for 'reserverforothers' permission, but that
doesn't make sense to apply here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:46 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-zZYQFab6cp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125010|0                           |1
        is obsolete|                            |

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125046&action=edit
Bug 27947: (QA follow-up) Update test to highlight issue

This addition to the tests highlights a permissions/security check
error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:20:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:20:51 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-BiXKElVPrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125016|0                           |1
        is obsolete|                            |

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125047&action=edit
Bug 27947: (QA follow-up) Clarify permissions

Privileged routes need permissions defined. This patch adds the minimum
required permission until there are article request-specific permissions
in Koha: circulate: circulate_remaining_permissions

It is also clarified that interacting with an article request  from
another patron, but having your own patron_id in the path would return
404 instead of 403, as technically the resource (an article request from
the patron, identified.by the supplied id) doesn't exist.

Tests are tweaked.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:21:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:21:30 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-raxROtw7RY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Brill, thanks for the follow-up clarifications Tomas.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:21:39 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-y107aSM1h3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:22:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:22:10 +0000
Subject: [Koha-bugs] [Bug 12227] Remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-bIVwX4SXfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nugged at gmail.com

--- Comment #10 from Andrew Nugged <nugged at gmail.com> ---
(above comment re-posted from my words by JD, we had some antispam issues)

found some remnants of "C4::Context->config('demo')": 
in /svc/config/systempreferences line 68:

`unless ( C4::Context->config('demo') ) { ... `

it's never failing because it returns _REFERENCE_TO_HASH_, even the hash is
empty:


```
sub set_preferences {
    warn C4::Context->config( 'demo' );
    warn C4::Context->config( 'demo' ) ? 'TRUTH' : 'FALSE';
    warn Dumper(C4::Context->config( 'demo' ));

    unless ( C4::Context->config('demo') ) {
        ...
```

Gives:
[2021/09/20 10:42:56] [WARN] HASH(0x5646ead56e00)
[2021/09/20 10:42:56] [WARN] TRUTH
[2021/09/20 10:42:56] [WARN] $VAR1 = {};

and despite this "hash truth" issue
also, by the way, as I see, this "demo" was removed everywhere so should be in
svc/config/systempreferences too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:42:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:42:07 +0000
Subject: [Koha-bugs] [Bug 29056] New: Remove demo functionality remnants
Message-ID: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

            Bug ID: 29056
           Summary: Remove demo functionality remnants
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: stalkernoid at gmail.com
          Reporter: nugged at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 12227

found some remnants of "C4::Context->config('demo')": 
in /svc/config/systempreferences line 68:

`unless ( C4::Context->config('demo') ) { ... `

this "demo" was removed everywhere so should be removed in
svc/config/systempreferences too


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227
[Bug 12227] Remove demo user functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:42:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:42:07 +0000
Subject: [Koha-bugs] [Bug 12227] Remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-jK7uRk9I2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29056


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056
[Bug 29056] Remove demo functionality remnants
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 10:44:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 08:44:53 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-m5jMqGj1EV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

--- Comment #1 from Andrew Nugged <nugged at gmail.com> ---
also to note maybe for separate tickets later (needs to be analyzed):

this

    `unless ( C4::Context->config('demo') ) { ... `

it's never failed because it returns _REFERENCE_TO_HASH_,
even the hash is empty:


```
sub set_preferences {
    warn C4::Context->config( 'demo' );
    warn C4::Context->config( 'demo' ) ? 'TRUTH' : 'FALSE';
    warn Dumper(C4::Context->config( 'demo' ));

    unless ( C4::Context->config('demo') ) {
        ...
```

Gives:
[2021/09/20 10:42:56] [WARN] HASH(0x5646ead56e00)
[2021/09/20 10:42:56] [WARN] TRUTH
[2021/09/20 10:42:56] [WARN] $VAR1 = {};

We might have other "if/unless ->config" usages not even for the "demo" key in
our code which might be degraded with this "always true" trick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:07:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:07:15 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-uRPhhZWNVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Caused by
  commit 61a39b0dd52df4f6d743671823449e265d6add26
  Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor
names

- [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %]

+ [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:13:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:13:12 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-X2AwHLOrhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:15:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:15:08 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-AETkNWC0G9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Looking good so far :)
I've followed the test plan and everything works as expected.

There are some things that are in bug 24023 that are missing here, but they can
be re-added on top of it later.

The big difference between both bugs is that, in bug 24023 the biblio record is
the bundle (its item is only there for circulation), whereas in bug 28854 the
item record is the bundle.
It means that you can do completely different bundles under the same name (the
biblio title). Is that intended ?

About the UI, I find the "tables in table" idea confusing. There are just too
much table controls in there :)
What do you think of moving the list of bundled items inside the popup that
opens when you click on the "Bundle" button ?

qa tool reports a weird error:

 FAIL   Koha/Item/Bundle.pm                                                     
   FAIL   valid                                                                 
                Inconsistent hierarchy during C3 merge of class
'Koha::Item::Bundle':                                                           
                        current merge results [                                 
                                Koha::Item::Bundle,                             
                        ]                                                       
                        merging failed on 'Koha::Item'

but it doesn't break koha, which is even more weird :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:20:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:20:43 +0000
Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a from
 record to search form
In-Reply-To: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28812-70-6NsnvZjVBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #18 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
testing this on 20.05.x to backport:

- create a new record with 700$a and 700$d populated
- save
- edit same record
- go back to 700$a
- open the Tag Editor
- only the value of 700$a goes in "Search main heading ($a only): "
- only the value of 700$d goes in "Search main heading: "

Same with an without the patch

Is what is happening expected?
yes: so 20.05.x isn't affected
no: there is an issue even with the patch

Am I actually testing the right thing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:21:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:21:59 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-N2OdDpY3qq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 11:22:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 09:22:03 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-sNNV69VMqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125048&action=edit
Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history"

Caused by
  commit 61a39b0dd52df4f6d743671823449e265d6add26
  Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor
names

- [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %]

+ [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %]

It must have been patron=checkout.issuer as patron-title.inc is
expecting a Koha::Patron object, not a borrowernumber.

Test plan:
Turn RecordStaffUserOnCheckout on
Check an item out then in
Go to the biblio checkout history and confirm that the "Checked out by"
column contains the logged in librarian's name.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:04:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:04:34 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-evYYsnAxgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Isn't UNKNOWN_ERROR missing in notices.tt?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:22:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:22:44 +0000
Subject: [Koha-bugs] [Bug 29057] New: Use font awesome icons on request.pl
Message-ID: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

            Bug ID: 29057
           Summary: Use font awesome icons on request.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We have a few images we use here, they could be replaced with font-awesome
icons

It looks like the 'top'/'bottom' icons require a pro license, but the filled
circle arrows seem a close equivalent

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:24:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:24:31 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-Xb3pbP7r0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:24:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:24:34 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-hLEG5I7VYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125049&action=edit
Bug 29057: Use font awesome icons on request.pl

To test:
1 - Place some holds on a record
2 - View the 'Holds' tab in the staff interface
3 - Note the new icons
4 - Note their hover test
5 - Confirm the buttons still work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:24:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:24:57 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-NPiuseXMBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:31:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:31:20 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-0syD6gbIf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125034|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125050&action=edit
Bug 28472: (follow-up) add unit test for the case where location = NULL

This patch adds an extra unit test, to cover the case where the
UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART"
and the item being returned has no shelving location set.

Test plan:

1) Apply the patch provided earlier
2) prove -v t/db_dependent/Circulation/issue.t
   ...and sign off if all tests pass.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

JD amended patch: use 'is' instead of 'ok'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:35:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:35:19 +0000
Subject: [Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC
 detail pages
In-Reply-To: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28667-70-KcsOAv4Vm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Passed QA                   |RESOLVED
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This is done on bug 3142, with duplicated code moved to a module, with tests.

*** This bug has been marked as a duplicate of bug 3142 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:35:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:35:19 +0000
Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine
 requestability
In-Reply-To: <bug-3142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3142-70-iAyQEF2oAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
*** Bug 28667 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:38:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:38:03 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-9OfTH9xGue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
In my opinion it would have been better to continue and finish the work started
on bug 7867.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:45:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:45:10 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-d4REt9IW81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Current behaviour is definitely wrong, but I am wondering why we don't keep the
id with the same capitalization (not lowered).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 12:55:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 10:55:41 +0000
Subject: [Koha-bugs] [Bug 12227] Remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-ybXyUwrPHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

--- Comment #11 from Andrew Nugged <nugged at gmail.com> ---
Created Bug 29056

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:13:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:13:48 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-Eara5vxpdy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Peter Vashchuk <stalkernoid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:13:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:13:52 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-WTsR3A63K2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

--- Comment #2 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 125051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125051&action=edit
Bug 29056: Remove the demo functionality leftovers

Remove forgotten code of the old legacy demo functionality that was
removed from elsewhere except systempreferences, this code not only
serves no purpose but also is causing some troubles for our customers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:17:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:17:38 +0000
Subject: [Koha-bugs] [Bug 28881] Suggestion not displayed on the order
 receive page
In-Reply-To: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28881-70-zlIWl3xXhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 20.05.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:19:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:19:23 +0000
Subject: [Koha-bugs] [Bug 29058] New: Add option to not load existing holds
 table automatically
Message-ID: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

            Bug ID: 29058
           Summary: Add option to not load existing holds table
                    automatically
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In large consortia the holds table can take a long time to load on records with
many holds.

When attempting to place a hold this table is always loaded

We should provide an option to prevent automatic loading of the table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:22:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:22:12 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-TG5A6lPogA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:22:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:22:16 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-0wGhAZnt4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121129|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125052&action=edit
Bug 28377: Use the API to suspend/resume holds

This patch makes the patron page (detail and circulation) use the API to
suspend/resume holds on the holds tab.

It previously used the old svc/ scripts we plan to replace.

To test
1. Have a patron with some holds
2. Play with suspending/resuming holds. Include the indefinite
   suspension.
=> SUCCESS: Everything works as usual
3. Apply this patch
4. Repeat 2
=> SUCCESS: Nothing changed, a soft breeze surprises you
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:22:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:22:20 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-7wlmmf73GM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121130|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125053&action=edit
Bug 28377: (follow-up) Remove svc/hold/{resume|suspend}

This files are no longer used and thus removed. Their functionality is
already present on the API

POST   /holds/:hold_id/suspension
DELETE /holds/:hold_id/suspension

To test:
1. Apply this patch
2. Run:
   $ git grep 'hold/suspend'
   $ git grep 'hold/resume'
=> SUCCESS: No references to the scripts
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:23:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:23:01 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-iyoM3jsf46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #3)
> Patch no longer applies 8-(..

Thanks for your time! Rebased!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:23:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:23:15 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-bIw1XFPvZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Asked Owen on IRC:

oleonard> Hm, no... There should be a single OpacMainUserBlock, not two. The
class would be correct if it were repeated for each additional content entry,
but it's not.
Joubu> yes, that's my point
oleonard> I agree with the change removing the divs from opac-main.tt and
opac-registration-confirmation.tt, those are cleanups I should have done
earlier.
oleonard> However I think the id in html_helpers.inc should stay.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:25:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:25:35 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-oNjFVFdh8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:25:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:25:39 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-QNgRWjaA7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125054&action=edit
Bug 29058: Add 'Always show holds' checkbox to request.pl

This patch adds a new cookie 'awalys_show_holds' and utlises it on request.pl
to determine if the existing holds table should be loaded.

If the cookie does not exist, the table is loaded to preserve exiting
behaviour.
If the cookie exists and is set to 'DONT' a new button 'Show holds' is added to
the page to allow force loading the table

To test:
1 - Place some holds on a record
2 - Click 'Holds' tab or 'Place a hold' from details page
3 - Note search box to place hold and table of existing holds
4 - Apply patch
5 - Reload the holds page and note new checkbox 'Always show holds'
6 - Confirm the box is checked
7 - Uncheck it
8 - Reload the page and confirm holds do not automatically load
9 - Click the new 'Show holds' button
10 - Confirm the existing holds load, and that 'Always show holds' is unchecked
11 - Check 'Always show holds'
12 - Reload page and confirm holds don't show
13 - Uncheck the box, load holds for another record, confirm it remains
unchecked
14 - Bring up browser console (F12)
15 - In 'Storage' tab, under 'Cookies', delete the cookie for
'always_show_holds'
16 - Reload holds page, confirm holds load and check box is checked

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:26:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:26:02 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-oaWd8Kwsxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:27:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:27:26 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-8jIYCdP88h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #3)
> I don't know about this one...
> 
> There are also multi value preferences that don't use pipes. Many
> preferences like "NotesToHide" and "ILS-DI:AuthorizedIPs" use commas instead.

In my opinion, that's a totally different problem, which we could cleary
address by making all multi-valued sysprefs behave consistently.

Thanks for the examples, BTW.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:29:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:29:44 +0000
Subject: [Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item
 information
In-Reply-To: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26223-70-RwXv1Xxqr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:29:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:29:44 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-kbPCdCmQQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906
Bug 28906 depends on bug 26223, which changed state.

Bug 26223 Summary: The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:34:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:34:15 +0000
Subject: [Koha-bugs] [Bug 25619] Updating an expiration date for a waiting
 hold won't save
In-Reply-To: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25619-70-HRqfpPdCt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #32 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:35:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:35:17 +0000
Subject: [Koha-bugs] [Bug 28554] In itemsearch sort filters by description
In-Reply-To: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28554-70-Qsmq9895g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:36:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:36:47 +0000
Subject: [Koha-bugs] [Bug 28891] RecordStaffUserOnCheckout display a new
 column but default sort column isn't changed
In-Reply-To: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28891-70-2rBCto0IuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:47:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:47:09 +0000
Subject: [Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should
 generate an empty from_api_mapping
In-Reply-To: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28744-70-FbpWNV5spV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:47:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:47:09 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
 new 'holds' table
In-Reply-To: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25260-70-J70WzfiN06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260
Bug 25260 depends on bug 28744, which changed state.

Bug 28744 Summary: Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:52:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:52:46 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-OBLQQVBouC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
First and last patches will be squashed when pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:53:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:53:17 +0000
Subject: [Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad
 search indexes
In-Reply-To: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28885-70-TradzyxbmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.04,20.11.10  |21.11.00,21.05.04,20.11.10,
        released in|                            |20.05.16
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 20.05.x branch for 20.05.16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:56:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:56:10 +0000
Subject: [Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental
 discount is not set
In-Reply-To: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28774-70-ewgSX0Q1UP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:56:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:56:33 +0000
Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when
 the search contains a double quote
In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20529-70-zXenHWxkzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #39 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:57:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:57:28 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-z28iSlAcVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125055&action=edit
Bug 28972: Make DB rev idempotent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:57:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:57:30 +0000
Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice
 error message when brcypt_settings are not defined
In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28912-70-XNXpjHCfyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:58:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:58:08 +0000
Subject: [Koha-bugs] [Bug 10265] 8xx serial added entries need spaces and
 punctuation in XSLT display
In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10265-70-L1SIORz6pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #23 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:59:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:59:20 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-DVGEuCcHZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #2 from Karen Venturella <Malnati at ucc.edu> ---
I wanted to unreceive 3 MLA handbooks that I received in koha in FY2021 with
vendor GO-YBP.

I was told, "There isn't a way to unreceive them in order to receive them in
FY22."  It was recommended to create a bug entry to ask for an enhancement in
order to unreceive an order.

Karen

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 13:59:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 11:59:20 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-LknDjAypHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patches will be squashed when pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:03:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:03:04 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-24rc8jyXQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:03:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:03:07 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-SNfnwDy9PL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125048|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125056&action=edit
Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history"

Caused by
  commit 61a39b0dd52df4f6d743671823449e265d6add26
  Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor
names

- [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %]

+ [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %]

It must have been patron=checkout.issuer as patron-title.inc is
expecting a Koha::Patron object, not a borrowernumber.

Test plan:
Turn RecordStaffUserOnCheckout on
Check an item out then in
Go to the biblio checkout history and confirm that the "Checked out by"
column contains the logged in librarian's name.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:05:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:05:03 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-qYCi3C0D3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Very minor quibble, in patron circ history we only show first and last name of
the person who did the checkout. In the bib's checkout history we're now
showing first name, last name, and cardnumber. Didn't seem worth holding up a
signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:07:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:07:30 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-t6sSBuL0n0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Hi Karen! Did you mean un-receive or un-cancel? The former should be possible
in Koha, but the latter is not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:14:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:14:32 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-nQnilOJaVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:14:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:14:36 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-Qt7gjnRxQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125052|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 125057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125057&action=edit
Bug 28377: Use the API to suspend/resume holds

This patch makes the patron page (detail and circulation) use the API to
suspend/resume holds on the holds tab.

It previously used the old svc/ scripts we plan to replace.

To test
1. Have a patron with some holds
2. Play with suspending/resuming holds. Include the indefinite
   suspension.
=> SUCCESS: Everything works as usual
3. Apply this patch
4. Repeat 2
=> SUCCESS: Nothing changed, a soft breeze surprises you
5. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:14:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:14:42 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-sJwUq91us0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125053|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 125058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125058&action=edit
Bug 28377: (follow-up) Remove svc/hold/{resume|suspend}

This files are no longer used and thus removed. Their functionality is
already present on the API

POST   /holds/:hold_id/suspension
DELETE /holds/:hold_id/suspension

To test:
1. Apply this patch
2. Run:
   $ git grep 'hold/suspend'
   $ git grep 'hold/resume'
=> SUCCESS: No references to the scripts
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:15:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:15:02 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-3KGnUirDW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29057: Use font awesome icons on request.pl
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc).
error: could not build fake ancestor
Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:24:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:24:33 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
 new 'holds' table
In-Reply-To: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25260-70-Cp1NRjELUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #95 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Owen Leonard from comment #93)
> I get an error from pendingreserves.pl:

Thanks for taking the time to test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:45:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:45:21 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-52QVXIsw7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #141 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125059&action=edit
Bug 17600: Remove wrong C4::Context imports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:46:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:46:52 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-3zibcdDUwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:46:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:46:55 +0000
Subject: [Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron
 Lists only selects the first 20 entries
In-Reply-To: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18747-70-zdVHJ8mN7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:46:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:46:58 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-7L5NQLSLJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:01 +0000
Subject: [Koha-bugs] [Bug 21093] Specified due date incorrectly retained
 when using fast add
In-Reply-To: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21093-70-Yd2PBFytZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:04 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-SKNxoXgopf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:09 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-eHOenKrUeD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #142 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #141)
> Created attachment 125059 [details] [review]
> Bug 17600: Remove wrong C4::Context imports

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:16 +0000
Subject: [Koha-bugs] [Bug 28228] Warns from plugins when metadata value not
 defined for key
In-Reply-To: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28228-70-83rEv37Fkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:18 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-cVXXPMFqaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:22 +0000
Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various
 punctuation characters
In-Reply-To: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28316-70-JXmJApkdQJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #114 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:25 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-hKlr2mgj0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:28 +0000
Subject: [Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a
 failed response even when cancellation succeeds
In-Reply-To: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28464-70-WXmCxQBmRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:30 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-EgRirJDLlA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:32 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
 items where location is null
In-Reply-To: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28472-70-QHk2tx7gT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:35 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-H5Cowm6aXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:37 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
 after renewing
In-Reply-To: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28653-70-kJlGYaWmZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:40 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-VgtqTxBvpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:42 +0000
Subject: [Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly
 generate authority records when using Default linker and heading is cached
In-Reply-To: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28676-70-2xhhQOEwOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:45 +0000
Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in
 value_builder/unimarc_field_4XX.pl
In-Reply-To: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28829-70-LjgBaiMnvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:47 +0000
Subject: [Koha-bugs] [Bug 28829] Useless single quote escaping in
 value_builder/unimarc_field_4XX.pl
In-Reply-To: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28829-70-YsfiLU8VAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:50 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-lgMjkDcRdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:52 +0000
Subject: [Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not
 respect multibranchlimit in OPAC_SEARCH_LIMIT
In-Reply-To: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28845-70-jPLrVOj4HY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:54 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-FFOTr7shlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:56 +0000
Subject: [Koha-bugs] [Bug 28847] Branch limits while searching should be
 expanded in query building and not in CGI
In-Reply-To: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28847-70-gwDYg7rtjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:47:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:47:59 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-YDgfsF6ht7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:01 +0000
Subject: [Koha-bugs] [Bug 28914] Wrong wording in authentication forms
In-Reply-To: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28914-70-N7DpDidUJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:04 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-bVxUdVxIMK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:06 +0000
Subject: [Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship
 where it's looking for a field
In-Reply-To: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28960-70-5bVhmuYo9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:08 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-ZijwW5GSB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:11 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-r0rX8zdsTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:13 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-GmBdrBIQOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:16 +0000
Subject: [Koha-bugs] [Bug 28985] Negative rental amounts can be saved but
 not enforced
In-Reply-To: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28985-70-458y2mEI2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:18 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-SYcGFVYnfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:21 +0000
Subject: [Koha-bugs] [Bug 28986] Parent itemtype not selected when editing
 circ rules
In-Reply-To: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28986-70-7dVj1fPEXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:24 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-qNJJdk7U0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:48:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:48:26 +0000
Subject: [Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
In-Reply-To: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28992-70-NzxZnaQ02y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:51:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:51:44 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-68Qk8JdiCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:51:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:51:47 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-z7UNrlYoxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124941|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125060&action=edit
Bug 29043: Don't load items unless a patron has been chosen on request.pl

This page wraps the item processing into an 'if( $patron )' conditional
to boost performance before a patron has been located.

To test:
 1 - Browse to a bib in the staff client
 2 - Click on the holds tab
 3 - Note loading time
 4 - Add 500 items to bib
 5 - Note loading time - it takes longer
 6 - Note items are not displayed
 7 - Apply patch
 8 - Reload page - is much faster
 9 - Find/choose a patron
10 - Confirm items are loaded correctly

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 14:57:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 12:57:36 +0000
Subject: [Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public
 Lists
In-Reply-To: <bug-20846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20846-70-ti4wZEs8si@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:14:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:14:56 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-X2F81hni2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:14:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:14:59 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-5MFHklef2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125049|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125061&action=edit
Bug 29057: Use font awesome icons on request.pl

To test:
1 - Place some holds on a record
2 - View the 'Holds' tab in the staff interface
3 - Note the new icons
4 - Note their hover test
5 - Confirm the buttons still work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:26:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:26:03 +0000
Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for
 pseudonymization but are not set on upgrade
In-Reply-To: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28911-70-L2FTDJFBbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28998,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17336

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
See also

1.
  commit 242722e99df77be9ce0e4c6d52ff402e0a77d604
  Bug 17336: Add api_secret_passphrase entry in packages setup

and 2.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998#c6

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:26:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:26:03 +0000
Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret
In-Reply-To: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28998-70-PjkU84NEle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28911

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:26:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:26:03 +0000
Subject: [Koha-bugs] [Bug 17336] api_secret_passphrase missing in packages
 setup
In-Reply-To: <bug-17336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17336-70-50KFvGN4oZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Oldversions                 |---

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28911

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:38:05 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-x2CnNHMnCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Tests from t/db_dependent/HoldsQueue.t and t/db_dependent/Koha/Item.t are
failing. Please fix ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:45:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:45:35 +0000
Subject: [Koha-bugs] [Bug 28936] Sort1 and Sort2 should be included in
 BorrowerUnwantedField and related sysprefs
In-Reply-To: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28936-70-4BnV1dFbJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28936

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:47:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:47:19 +0000
Subject: [Koha-bugs] [Bug 21794] Incomplete address displayed on patron
 details page when City field is empty
In-Reply-To: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21794-70-fxEArB9clF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21794

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:47:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:47:26 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-jybn6iCHFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:47:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:47:29 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-xne7GjdX6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125054|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125062&action=edit
Bug 29058: Add 'Always show holds' checkbox to request.pl

This patch adds a new cookie 'awalys_show_holds' and utlises it on request.pl
to determine if the existing holds table should be loaded.

If the cookie does not exist, the table is loaded to preserve exiting
behaviour.
If the cookie exists and is set to 'DONT' a new button 'Show holds' is added to
the page to allow force loading the table

To test:
1 - Place some holds on a record
2 - Click 'Holds' tab or 'Place a hold' from details page
3 - Note search box to place hold and table of existing holds
4 - Apply patch
5 - Reload the holds page and note new checkbox 'Always show holds'
6 - Confirm the box is checked
7 - Uncheck it
8 - Reload the page and confirm holds do not automatically load
9 - Click the new 'Show holds' button
10 - Confirm the existing holds load, and that 'Always show holds' is unchecked
11 - Check 'Always show holds'
12 - Reload page and confirm holds don't show
13 - Uncheck the box, load holds for another record, confirm it remains
unchecked
14 - Bring up browser console (F12)
15 - In 'Storage' tab, under 'Cookies', delete the cookie for
'always_show_holds'
16 - Reload holds page, confirm holds load and check box is checked

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:47:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:47:50 +0000
Subject: [Koha-bugs] [Bug 28392] streettype and B_streettype cannot be
 hidden via BorrowerUnwantedField
In-Reply-To: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28392-70-5Pps9oZzwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28392

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:50:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:50:13 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-3vgZHoU3lq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #143 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125063&action=edit
Bug 17600: (follow-up) Fix overdrive proxy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 15:54:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 13:54:55 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-irSdqucfA9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125063|0                           |1
        is obsolete|                            |

--- Comment #144 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125064&action=edit
Bug 17600: (follow-up) Fix overdrive_proxy recordedbooks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:08:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:08:43 +0000
Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for
 publicationyear/copyrightdate
In-Reply-To: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11046-70-wrgrJWTNAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a late observation about the last changes:

-    } elsif( $retval =~ m/(\d)[.Xx?]{3}|(\d\d)[.Xx?]{2}|(\d{3})[.Xx?]/ ) {
-        my $digits = $1 || $2 || $3;
-        $retval = $digits * ( 10 ** ( 4 - length($digits) ));
-    } elsif( $retval =~ m/(\d)[-]{3}\?|(\d\d)[-]{2}\?|(\d{3})[-]\?/ ) {
-        # the form 198-? occurred in Dutch ISBD rules
-        my $digits = $1 || $2 || $3;
+    } elsif( $retval =~ m/
+             (?<year>\d)[-]?[.Xx?]{3}
+            |(?<year>\d{2})[.Xx?]{2}
+            |(?<year>\d{3})[.Xx?]
+            |(?<year>\d)[-]{3}\?
+            |(?<year>\d\d)[-]{2}\?
+            |(?<year>\d{3})[-]\?
+    /xms ) { # the form 198-? occurred in Dutch ISBD rules

This part of the regex made me wonder:
             (?<year>\d)[-]?[.Xx?]{3}
What does the minus do here after the first digit? Do we allow 1-234 or so?
Looking at the above, this must have been a typo (copy/paste) after all..

Continued on bug 24674

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:08:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:08:43 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-STYFiKmjFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It is not breaking xmlstarlet, so not an issue. Back to NSO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:09:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:09:21 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-Lvpkbc9ZTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From bug 11046:

This part of the regex made me wonder:
             (?<year>\d)[-]?[.Xx?]{3}
What does the minus do here after the first digit? Do we allow 1-234 or so?
Looking at the above, this must have been a typo (copy/paste) after all..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:11:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:11:44 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-RU1UojrIoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Working a bit on this one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:12:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:12:20 +0000
Subject: [Koha-bugs] [Bug 28972] Add missing foreign key constraints to
 holds queue table
In-Reply-To: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28972-70-ije1NRRf7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125065&action=edit
Bug 28972: Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:14:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:14:36 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-ORaCuIQ92W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125064|0                           |1
        is obsolete|                            |

--- Comment #145 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125066&action=edit
Bug 17600: Fix overdrive_proxy and recordedbooks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:19:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:19:48 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-HADMdKzZxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #8)

> 1999- = 1999
> 1999-2009 = 1999
> 19xx (very common  here) = NULL

This observation seems to be incorrect. The code does this:

19xx = 1900
19--? = 1900
19-- = 19

The latter one is obviously wrong. (The suffix question mark should not be
mandatory in the regex.)

A problem that I could see with the Polish way of Janusz here is that 17-
should become 1700. But what if you would describe a year between 300 and 400?
3- or even 3-- would mean 3000 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:21:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:21:41 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-2BbHEjyhDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:21:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:21:44 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-Rr0FS5D3eg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124992|0                           |1
        is obsolete|                            |

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125067&action=edit
Bug 29049: Simply holds priorty dropdown logic on request.pl

This patch makes a few changes:
1 - If we are not splitting the queue ( HoldsSplitQueue == 'nothing' ) then
    there are no changes for 'virtual' vs 'actual' numbering
2 - If we are splitting the queue you cannot use the dropdown, so we do not
need to process the options
3 - If the hold is 'found' we do not need to process the options
4 - We can simply use the 'last priority' to build the options, we do not need
to process in the script
5 - We can use a block to build the options
6 - Remove a stray holds.index

To test:
 1 - Place 5 holds on a bib
 2 - 'Find' two of the holds i.e. check them in to set status to 'transit' or
'waiting'
 3 - View the holds page for the biblio
 4 - Inspect the priorty dropdown for the found holds, note they have options
for 1-5 but are disabled
 5 - Note the dropdowns for other holds have options 1-5
 6 - Note options 4&5 in the dropdowns have no effect
 7 - Apply patch
 8 - Inspect the priority dopdowns on the found holds
 9 - Note they only show their found status
10 - Note the other dropdowns only show options 1-3
11 - Test with other HoldsSplitQueue options and HoldsSplitQueueNumbering
12 - When holds queue is split, no dropdowns should be active and should show
only their current priority
13 - When  HoldsSplitQueueNumbering is 'virtual' the dropdown should be
disabled and correctly count the number of unfound holds in the list

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:21:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:21:47 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-XbvMQW2Fwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125013|0                           |1
        is obsolete|                            |

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125068&action=edit
Bug 29049: (follow-up) Reduce number of line returns in page

While moving the dropdown to a block, I noticed the page size was very large
when there are many holds

This patch chomps a large amoutn of whitespace, from the block and elsewhere
and drecreased the paeg from about 400k lines to 25k lines for a record with
~200 holds

To test:
1 - Apply previous patch
2 - Load holds tab for a biblio
3 - Save the page as html from your browser, note the size of the file
4 - Apply patch this
5 - Reload and repeat
6 - Note the size is much smaller

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:25:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:25:29 +0000
Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail
 pages to FA icon
In-Reply-To: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28993-70-Ec8rXr6dgn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Authorities can also be linked to each other hierarchically - could that have
to do with it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:25:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:25:50 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-KYgkGEVs4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Janusz Kaczmarek from comment #2)

> In addition, in Poland a form with only one dash is quite common, like YY-
> (== YY--).

With reference to former comment, this form is not in the ISBD document you
refer to in the description btw.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:48:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:48:11 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27526-70-jRF5RSRx9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123772|0                           |1
        is obsolete|                            |

--- Comment #101 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125069&action=edit
Bug 27526: Add tests for columns_to_str and host_items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:57:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:57:44 +0000
Subject: [Koha-bugs] [Bug 29059] New: Keep non-repeatable attribute from
 patron to preserve
Message-ID: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

            Bug ID: 29059
           Summary: Keep non-repeatable attribute from patron to preserve
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

See bug 21648 comment 17.

Suggestion is to keep the non-repeatable patron's attribute from the patron we
selected instead of raising a blocking error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:58:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:58:25 +0000
Subject: [Koha-bugs] [Bug 21648] Patron Merge duplicates patron attributes
In-Reply-To: <bug-21648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21648-70-6yvReung2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29059

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Mark, I've opened bug 29059 to implement your suggestion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:58:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:58:25 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-Wnkdp8cWvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21648

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:58:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:58:38 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-HB384ramDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
         Depends on|                            |28217


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217
[Bug 28217] Several non-repeatable attributes when merging patrons
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 16:58:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 14:58:38 +0000
Subject: [Koha-bugs] [Bug 28217] Several non-repeatable attributes when
 merging patrons
In-Reply-To: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28217-70-IIUdHlaI0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28217

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29059


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059
[Bug 29059] Keep non-repeatable attribute from patron to preserve
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:01:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:01:29 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-mo32p53MQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:01:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:01:33 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-gy7UTieFoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125070&action=edit
Bug 29059: Keep non-repeatable attribute from patron to preserve when merging

See bug 21648 comment 17.

Suggestion is to keep the non-repeatable patron's attribute from the patron we
selected instead of raising a blocking error.

A side-effect will be that when several patrons are merged, the
non-repeatable attribute from the first one will be kept, which can
result in unexpected result if the original patron does not have the
attribute defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:09:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:09:20 +0000
Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js
In-Reply-To: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28536-70-lAJ7IT2unr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:09:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:09:23 +0000
Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js
In-Reply-To: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28536-70-GxnElZFljB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123999|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125071&action=edit
Bug 28536: Move translatable strings into overdrive.js

This patch takes strings defined as variables in opac-bottom.inc for use
in overdrive.js and moves them to overdrive.js, wrapped in the
double-underscore translation function.

To test you must have valid credentials entered in system preferences
for the OverDrive API. Ideally you should test using a patron who has
holds and current checkouts in OverDrive.

Apply the patch and log in to the OPAC.

- On the "Your summary" page, open the "OverDrive Account" tab.
  - Log in to your OverDrive account.
  - The contents of the tab should display correctly, with correct
    labels for controls like "Log out of your OverDrive account", "Check
    in", "On hold", etc.
- Perform a catalog search which will return results also found in your
  OverDrive collection.
  - Open the OverDrive results page.
  - The page should display correctly, with correct labels on controls
    like "Check out" and "Place hold."

To test that the correct strings are translatable. In this example I'm
testing fr-FR:

 - Update a translation:

  > gulp po:update
  > cd misc/translator
  > perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from
  JavaScript  e.g.  misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from bootstrap/js/overdrive.js for
  translation, e.g.:

  koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js:124
  msgid "OverDrive account page"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing)
- Install the updated translation:

  > perl translate install fr-FR

In the OPAC, switch to the language you're testing. Confirm that your
translated strings appear. In the above example, the string should
appear at the top of the "Overdrive Account" tab.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=28356

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:21:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:21:23 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-O6B9tkhV3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
It would be preferable if we are given the setting in both and could choose
which to use.

Also, it is more likely that the more recent record will have up-to-date
information.  Keeping the first one is not necessarily the best option.  But it
would be preferred to review the different entries and select the correct one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:36:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:36:16 +0000
Subject: [Koha-bugs] [Bug 29059] Keep non-repeatable attribute from patron
 to preserve
In-Reply-To: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29059-70-B8mFD3S8dU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29059

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Then we need the full UI suggested by bug 21648 and this bug report can be
closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:43:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:43:22 +0000
Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if
 content above navbar
In-Reply-To: <bug-28901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28901-70-AmOWfJsNFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:43:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:43:25 +0000
Subject: [Koha-bugs] [Bug 28901] showCart incorrectly calculates position if
 content above navbar
In-Reply-To: <bug-28901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28901-70-U98i9CPttq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125072&action=edit
Bug 28901: showCart incorrectly calculates position if content above navbar

This patch makes changes to the OPAC Cart's CSS and JS so that the cart
pop-up message display more consistently. The CSS is changed to use
position "fixed" instead of "absolute." This allows the message to
display without recalculating the position every time, and keeps the
appearance we expect.

The z-index of the message is also increase to prevent it from being
hidden behind a floating toolbar.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Perform a catalog search in the OPAC which will return multiple
   results.
 - In the list of search results, click the "Add to cart" link next to
   several search results. Each time you should see a message appear in
   the upper left corner of the screen, "The item has been added to the
   cart."
 - The position of the messages should be consistent no matter how far
   down the page you scroll.
 - Test again after adding content to the OpacHeader region. One way to
   do this is to add the following to the OpacUserJS preference:

   $(document).ready(function(){
     $("#wrapper").prepend('<img
src="https://generative-placeholders.glitch.me/image?width=900&height=200&style=triangles&gap=30">');
   });

 - Test at various browser widths, from a phone-sized screen width up to
   wide desktop-sized.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:48:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:48:31 +0000
Subject: [Koha-bugs] [Bug 28925] OPAC checkout history is not accessing the
 set language
In-Reply-To: <bug-28925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28925-70-M2nIjP0phZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28925

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24223
            Version|unspecified                 |master

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Bug 24223 is currently awaiting testing, but this bug probably needs its own
fix for previous versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 17:48:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 15:48:31 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-ztuPAdH90T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28925

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 18:02:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 16:02:35 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-HOYLcABdIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
           Assignee|oleonard at myacpl.org         |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 18:17:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 16:17:38 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-87QU3WtnZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 18:17:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 16:17:42 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-pHCyPuBawv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124084|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125073&action=edit
Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link
in reports

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 18:17:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 16:17:45 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-iiPhvJMjN1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125074&action=edit
Bug 28454: (follow-up) Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:13:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:13:08 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-5fsF4e8uzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #3)
> Hi Karen! Did you mean un-receive or un-cancel? The former should be
> possible in Koha, but the latter is not.

+1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:14:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:14:35 +0000
Subject: [Koha-bugs] [Bug 29011] Error 500 on item checkout when
 Pseudonymization is used
In-Reply-To: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29011-70-EkUXpJYuWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Error 500 on item checkout  |Error 500 on item checkout
                   |                            |when Pseudonymization is
                   |                            |used

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Do you have access to the server and could check the plack-error-log maybe?
There might be something useful there pointing the right direction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:16:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:16:44 +0000
Subject: [Koha-bugs] [Bug 29060] New: Use modal for suspending holds until a
 date from the holds page
Message-ID: <bug-29060-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060

            Bug ID: 29060
           Summary: Use modal for suspending holds until a date from the
                    holds page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If you view the list of holds on a patron's checkout screen you can click the
"Suspend" button to trigger a modal dialog where you can select a date after
which the hold should resume.

I'd like to make the controls work the same way when viewing the list of holds
on a title, e.g. /cgi-bin/koha/reserve/request.pl?biblionumber=XXX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:23:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:23:08 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-9XQ7UiXJP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:23:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:23:11 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-hXAVo0mvNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125075&action=edit
Bug 28832: (follow-up) Handle regex fields too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:33:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:33:11 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-56ECOXA7FF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:33:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:33:15 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-TWUlTrzel0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123982|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125076&action=edit
Bug 28832: Don't batch modify fields that we don't update

In bug 27837 we made sure to always pass through the permanent_location if it
was passed in unlike
other fields which are not passed if they have no value.
During batch mod, however, fields that aren't editied have no value, so forcing
permanent_location
to pass through forces blanking it.

This patch alters the script to only pass thgouhr for edit the fields that have
been updated or
cleared.

To test:
 1 - In frameworks add a new subfield to 952, "C" - make it editable in items
tab and visible in intranet/editor
 2 - In mappings map that subfield to items.permanent_location
 3 - Set an item to have differing shelving location and permanent_location
 4 - This saves correctly for an individual item
 5 - Edit the item using Tools->batch item modification, updating the note
field
 6 - Note the permanet_location is removed
 7 - Check the DB, the field is set to NULL
 8 - Apply patch
 9 - Repeat
10 - Permanent location is not cleared
11 - Verify that clearing fields works as before, including permanent_location

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Deb Stephenson <dstephen at dubuque.lib.ia.us>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:33:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:33:19 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-kArmAPojYP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125075|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125077&action=edit
Bug 28832: (follow-up) Handle regex fields too

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:34:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:34:26 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-tZVVlYd5Lv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

--- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Repeated the original test plan and then did a second batch edit, successfully
editing a field via regex, confirmed that edit worked and did not mess up the
shelving locations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:48:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:48:20 +0000
Subject: [Koha-bugs] [Bug 29060] Use modal for suspending holds until a date
 from the holds page
In-Reply-To: <bug-29060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29060-70-VfilwmOoF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 19:48:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 17:48:23 +0000
Subject: [Koha-bugs] [Bug 29060] Use modal for suspending holds until a date
 from the holds page
In-Reply-To: <bug-29060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29060-70-cqOcJd94Qz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125078&action=edit
Bug 29060: Use modal for suspending holds until a date from the holds page

This patch modifies the way suspensions are handled when viewing the
list of holds on a particular title. In particular, when
AutoResumeSuspendedHolds is enabled the "suspend until" form field is
hidden until the suspend button is clicked, when a modal window appears.
This is consistent with the way it works when working with the list of
holds on a patron record.

The patch also converts the hold deletion button from an "X" image to a
more-standard "Delete" button.

To test, apply the patch and make sure AutoResumeSuspendedHolds is
enabled.

- Locate a title in the catalog with multiple holds.
- View the holds on that title. In the list of holds you should see
  "Delete" and "Suspend" buttons in the last two columns of the tabel of
  holds.
- Test that the "Delete" button works correctly,
- Test the "Suspend" button. Clicking it should trigger a modal window
  where you can set a date for the hold to resume.
  - Submitting the form with a date should result in the page reloading
    and showing the hold as suspended until that date.
  - Submitting hte form without a date should result in the page
    reloading and showing the hold as suspended.
  - Test that the "Resume" button works to remove the suspension.
- Disable AutoResumeSuspendedHolds. Now when you click the "Suspend"
  button you should not see the modal. The page should reload and the
  hold should be suspended without a resume date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 20:40:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 18:40:47 +0000
Subject: [Koha-bugs] [Bug 29061] New: max_holds rule not saving a value of
 Unlimited
Message-ID: <bug-29061-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29061

            Bug ID: 29061
           Summary: max_holds rule not saving a value of Unlimited
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate: 
- Set your Default checkout, hold and return policy value for Maximum total
holds allowed (count) to 1
- find a patron, confirm you can only place 1 hold for this patron before
getting a "too many holds" error
- create a Checkout, hold policy by patron category for your patron's category,
with a Total Holds value of Unlimited
- confirm you still get a "too many holds" error, even though your circ rules
say your holds should be unlimited

We don't save a max_holds rule with a blank value for the patron category, so
Koha ends up falling back to the more restrictive default.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 22:35:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 20:35:23 +0000
Subject: [Koha-bugs] [Bug 29062] New: Patron check-in slip repeats data
Message-ID: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

            Bug ID: 29062
           Summary: Patron check-in slip repeats data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The patron check in slip repeats data for each time that particular itemnumber
is found in old_issues.

TO recreate:

1. Check something out to patron A. Check it in.
2. Check something out to patron B. Check it in.
3. Check something out to patron C. Check it in and print the check-in slip.
4. You will see the checkin repeat itself 3 times, one for each line in
old_issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 22:35:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 20:35:34 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-ymNrYqU2t3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12224


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224
[Bug 12224] Allow easy printing of patron check-in slip
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 22:35:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 20:35:34 +0000
Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
In-Reply-To: <bug-12224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12224-70-Z53UdJblJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29062


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062
[Bug 29062] Patron check-in slip repeats data
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 22:38:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 20:38:05 +0000
Subject: [Koha-bugs] [Bug 29063] New: Translation issue with repeated
 strings in system preferences
Message-ID: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

            Bug ID: 29063
           Summary: Translation issue with repeated strings in system
                    preferences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

When translating the preferences in Pootle, the strings of every preference are
prefixed with a string, keeping them unique and allowing for a more individual
translation. In other words: you can use different translations for Use/don't
use, activate/deactivate depending on context and the rest of the sentence.

Now in the manual chapters for the system preferences, this does no longer
work. There strings like Use/don't use and activate/deactivate are "collapsed"
into one string. So you can only translate it once, which means you can't match
the translations you picked for the Koha GUI.

I am not sure how to solve this. Maybe we could think about formatting the
preferences in the manual differently so the whole text descriptoin appears as
one entry on Pootle?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 22:40:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 20:40:39 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-aoUmtSsWeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:06:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:06:25 +0000
Subject: [Koha-bugs] [Bug 19008] Add more options to cleanup database script
In-Reply-To: <bug-19008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19008-70-VP5NxPC9De@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:06:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:06:26 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
 Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-dyJnpdcGGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
Bug 18081 depends on bug 19008, which changed state.

Bug 19008 Summary: Add more options to cleanup database script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:06:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:06:27 +0000
Subject: [Koha-bugs] [Bug 27965] cleanup_database.pl should not remove old
 checkouts with unpaid fines
In-Reply-To: <bug-27965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27965-70-NJECNM9H9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27965
Bug 27965 depends on bug 19008, which changed state.

Bug 19008 Summary: Add more options to cleanup database script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:06:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:06:27 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-QzOslLandc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152
Bug 24152 depends on bug 19008, which changed state.

Bug 19008 Summary: Add more options to cleanup database script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:21:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:21:40 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-tNko7YhoVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #4)
> Love this work.. but..
> 
> I'm afraid it fell at the first hurdle for me; accessibility is affected.
> 
> I tested the check-in screen; Upon navigating to the due date input the
> widget pops up as expected, however the focus remains in the input box and
> the widget cannot be navigated or submitted via keyboard.

But would that not be the intended behavior if we want to allow for direct
input of the date in the input field for accessibility?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:25:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:25:09 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-Gq9V07lCzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #5)
> (In reply to Martin Renvoize from comment #4)
> > Love this work.. but..
> > 
> > I'm afraid it fell at the first hurdle for me; accessibility is affected.
> > 
> > I tested the check-in screen; Upon navigating to the due date input the
> > widget pops up as expected, however the focus remains in the input box and
> > the widget cannot be navigated or submitted via keyboard.
> 
> But would that not be the intended behavior if we want to allow for direct
> input of the date in the input field for accessibility?

Also it seems that the behaviour is the same with our current widget:

* new patron
* tab to date of birth input field
* enter date with keyboard - ok
* try to use widget with keyboard keys/arrows - doesn't work

To me that makes sense. People preferring the mouse, will use the mouse to
handle the widget, but people preferring the keyboard, will probably want to
type the date directly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:28:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:28:02 +0000
Subject: [Koha-bugs] [Bug 29063] Manual: Translation issue with repeated
 strings in system preferences
In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29063-70-sIYaDPfeeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Translation issue with      |Manual: Translation issue
                   |repeated strings in system  |with repeated strings in
                   |preferences                 |system preferences

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:41:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:41:39 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-hetqRAU9HF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:41:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:41:43 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-EPAsPI8Ndy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 125079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125079&action=edit
Bug_29038: Accessibility OPACUserSummary heading doesn't have sufficient
contrast

This patch changes the colour of the OPAC User
Summary heading text to increase the contrast
ratio, improving accessibility and making the
text easier to read.

To test:

1. Log in to the OPAC homepage as a user with
   items checked out
2. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
3. Confirm the UserSummary heading has insufficient
   contrast.
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Use the accessibility tool to confirm the
   contrast ratio now meets accessibility
   requirements
6. Check that the OPAC still looks ok after
   the changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:48:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:48:21 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-NBWr1SrFzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Liz Rea <wizzyrea at gmail.com> ---
I sign this off (we have had this in production for many months) - however my
devbox is broken and I do not have a spoon to get it working right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:57:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:57:44 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-7Dx0l0463S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 20 23:57:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 21:57:48 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-MIHJ9KHnPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

--- Comment #2 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 125080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125080&action=edit
Bug_29036: Accessibility OPAC buttons don't have sufficient contrast

This patch changed the base colour of OPAC buttons
to increase the contrast ratio, improving
accessibility and making the button text easier to
read.

To test:

1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast ratio
   on the OPAC
2. Confirm that the OPAC buttons don't have
   sufficient colour contrast
3. Apply the patch and rebuild css:
   yarn build --view opac
4. Use the accessibility tool to confirm
   the button contrast ratio now meets
   minimum accessibility requirements
5. Check that the OPAC still looks ok
   after the changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:06:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:06:55 +0000
Subject: [Koha-bugs] [Bug 29064] New: OPAC duplicate "Most popular titles"
 in <title> tag
Message-ID: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

            Bug ID: 29064
           Summary: OPAC duplicate "Most popular titles" in <title> tag
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lari.taskula at hypernova.fi
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:15:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:15:00 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-uums37SwQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27742
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742
[Bug 27742] Accessibility: OPAC - Page titles should have unique information
first
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:15:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:15:00 +0000
Subject: [Koha-bugs] [Bug 27742] Accessibility: OPAC - Page titles should
 have unique information first
In-Reply-To: <bug-27742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27742-70-zOk627VsNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27742

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29064


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064
[Bug 29064] OPAC duplicate "Most popular titles" in <title> tag
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:15:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:15:04 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-LPs2Xre9QH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 125081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125081&action=edit
Bug 29064: Remove duplicate term Most popular titles

To test:
1. Enable system preference OpacTopissue
2. Go to OPAC /cgi-bin/koha/opac-topissues.pl
3. Observe title Most popular titles &rsaquo; Koha online catalogMost popular
titles
4. Apply patch
5. Observe title Most popular titles &rsaquo; Koha online catalog
6. See that this path complies with Bug 27742

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:22:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:22:54 +0000
Subject: [Koha-bugs] [Bug 29065] New: Accessibility: OPAC clear search
 history link has insufficient contrast
Message-ID: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

            Bug ID: 29065
           Summary: Accessibility: OPAC clear search history link has
                    insufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The contrast ratio for the OPAC Delete your search history link fails to meet
accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:23:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:23:32 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-NYtSG3HcVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28188
             Status|NEW                         |ASSIGNED
                 CC|                            |bolshawh at parliament.uk
           Keywords|                            |accessibility
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:23:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:23:32 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-GF5oZZyHf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29065


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065
[Bug 29065] Accessibility: OPAC clear search history link has insufficient
contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:29:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:29:38 +0000
Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header
In-Reply-To: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15749-70-9hwo0uCjd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Is this still valid?
See syspref preference OpacAddMastheadLibraryPulldown

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:32:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:32:32 +0000
Subject: [Koha-bugs] [Bug 29066] New: Remove text in OPAC search form and
 use Font Awesome icons
Message-ID: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

            Bug ID: 29066
           Summary: Remove text in OPAC search form and use Font Awesome
                    icons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In modern front-end websites, first think you see in header region is an large
input text with a search icon.
No need to say it is a search form.
We still tell it in 'title' attribut for accessibility.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:32:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:32:44 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-KHeA7nZAin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:33:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:33:36 +0000
Subject: [Koha-bugs] [Bug 29067] New: Remove duplicate conditional statement
 from OPAC messaging settings title
Message-ID: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

            Bug ID: 29067
           Summary: Remove duplicate conditional statement from OPAC
                    messaging settings title
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lari.taskula at hypernova.fi
        QA Contact: testopia at bugs.koha-community.org

There is a duplicate conditional statement in OPAC messaging settings <title>.

We need to check LibraryNameTitle just once.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:33:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:33:47 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-d7PXGiJ3z0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:33:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:33:52 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-mSwBOQpAr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 125082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125082&action=edit
Bug_29065: Accessibility OPAC clear search history link has insufficient
contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:39:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:39:36 +0000
Subject: [Koha-bugs] [Bug 29068] New: Accessibility: OPAC search results
 summary text has insufficient contrast
Message-ID: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

            Bug ID: 29068
           Summary: Accessibility: OPAC search results summary text has
                    insufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The OPAC search results summary text ("Edition", "Material type", "Format" etc)
is hard to read (grey text on a grey background) and the contrast ratio fails
to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:40:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:40:25 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-TK474emLNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bolshawh at parliament.uk
             Blocks|                            |28188
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
           Keywords|                            |accessibility


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:40:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:40:25 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-HSdKOxqjGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29068


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068
[Bug 29068] Accessibility: OPAC search results summary text has insufficient
contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:42:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:42:08 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-1WHjxovLAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:42:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:42:20 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-8dadr1bJjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

--- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 125083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125083&action=edit
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings
title

We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC
messaging preferences title, so it's dead code.

This patch removes the useless duplicate if-statement.

To test:
1. Enable EnhancedMessagingPreferencesOPAC system preference
2. Go to /cgi-bin/koha/opac-messaging.pl
3. Observe title Your messaging settings > Koha online catalog
4. Apply patch
5. Refresh page /cgi-bin/koha/opac-messaging.pl
6. Observe same title Your messaging settings > Koha online catalog
7. See patch content
8. Confirm there are no functional changes in the new logic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:42:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:42:29 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-t1TKTv7a1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |lari.taskula at hypernova.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:43:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:43:19 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-dMqTR8j4fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |lari.taskula at hypernova.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:54:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:54:57 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-bcIwP0uTYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:55:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:55:01 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-D31C4I4nMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125084&action=edit
Bug 29066: Remove text in OPAC search form and use Font Awesome icons

In modern front-end websites, first think you see in header region is an large
input text with a search icon.
No need to say it is a search form.
We still tell it in 'title' attribut for accessibility.

This patch removes 'Search' text.
If 'my library first' feature is enabled, shows a text in title of a
question mark icon.
In submit button, replaces 'Go' with a seach icon and add title
'Search'.

Test plan :
1)
1.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Add'
  SearchMyLibraryFirst to 'Don't limit'
1.2) Go to OPAC main page
1.3) You don't see 'Search' anymore
1.4) You see in submit button an icon
1.5) Move mouse over submit button to see tooltip text 'Search'
2)
2.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Don't add'
  SearchMyLibraryFirst to 'Limit'
2.2) Go to OPAC main page
2.3) Log in
2.4) You don't see text 'Search (in <library name>) only'
2.5) You see a question mark icon
2.6) Move mouse over submit button to see tooltip text 'Search (in <library
name>) only'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:55:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:55:29 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-M7P4hg92lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29066

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:55:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:55:29 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-g6HxWlS7XF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29035

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:56:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:56:10 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-1S70uNlpdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I agree with this change.

But I also propose an enhancement Bug 29066 to remove this text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:57:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:57:10 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-QBiAwRnrqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Don't hesitate to ask for changes that are needed for accessibility.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:58:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:58:15 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-UTyeALUeLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 00:58:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 22:58:19 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-U0eXfgwyJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 125085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125085&action=edit
Bug 29068: Accessibility OPAC search results summary text has insufficient
contrast

This patch changes the colour of the label text in
OPAC search results to increase the contrast ratio,
improve accessibility and make the text easier to read.

To test:

1. Search for something on the OPAC
2. Use an accessibility tool (e.g. Chrome's Lighthouse
   tool) to check the contrast ratio
3. Confirm that the labels (Edition, Format etc.) in the
   results summary have insufficient contrast
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Use the accessibility tool to confirm the contrast
   ratio now meets minimum accessibility requirements
6. Check that the OPAC still looks ok after the changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:02:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:02:26 +0000
Subject: [Koha-bugs] [Bug 29069] New: Accessibility: "Refine your search"
 link doesn't have sufficient contrast
Message-ID: <bug-29069-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29069

            Bug ID: 29069
           Summary: Accessibility: "Refine your search" link doesn't have
                    sufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The "refine your search" link on the OPAC search results page (opac-search.pl)
is hard to read (grey text on a grey background) and doesn't meet accessibility
guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:02:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:02:50 +0000
Subject: [Koha-bugs] [Bug 29069] Accessibility: "Refine your search" link
 doesn't have sufficient contrast
In-Reply-To: <bug-29069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29069-70-9Fz2HuO9HL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29069

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bolshawh at parliament.uk
             Blocks|                            |28188
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
           Keywords|                            |accessibility
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:02:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:02:50 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-wI0M1YV3ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29069


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29069
[Bug 29069] Accessibility: "Refine your search" link doesn't have sufficient
contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:35:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:35:41 +0000
Subject: [Koha-bugs] [Bug 29070] New: Accessibility: OPAC Purchase
 Suggestions on search results page has insufficient contrast
Message-ID: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

            Bug ID: 29070
           Summary: Accessibility: OPAC Purchase Suggestions on search
                    results page has insufficient contrast
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bolshawh at parliament.uk
        QA Contact: testopia at bugs.koha-community.org

The "Not finding what you're looking for? Make a purchase suggestion" text box
on the search results page (opac-search.pl) is hard to read and fails to meet
accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:36:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:36:03 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-1gbhRa5tCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |accessibility
             Blocks|                            |28188
           Assignee|oleonard at myacpl.org         |bolshawh at parliament.uk
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:36:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:36:03 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-1GnbLbiSoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29070


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070
[Bug 29070] Accessibility: OPAC Purchase Suggestions on search results page has
insufficient contrast
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:44:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:44:38 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29033-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29033-70-eSY807Esll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #5)
> In my opinion, that's a totally different problem, which we could cleary
> address by making all multi-valued sysprefs behave consistently.

I was thinking that a bit as well. Don't we have some multi-value preferences
that use select lists as well? I'm not sure how those work though. 

I've been debating whether it would be better to return different data types
with C4::Context->preference or if having C4::Context->multivalue_preference
makes sense... and I think you might be right. (I mean if we were starting
over, it would make sense for the preference to be an object and then that
object would have the appropriate methods, but we have to work with what we
have...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:49:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:49:13 +0000
Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not
 running in verbose mode
In-Reply-To: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29054-70-YZFG4QesUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 01:49:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Sep 2021 23:49:16 +0000
Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not
 running in verbose mode
In-Reply-To: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29054-70-twc8CCHhJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054

--- Comment #1 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 125086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125086&action=edit
Bug 29054: Add verbose check for warn in advance_notices.pl

To test:
1) Set EnhancedMessagingPreferences to Don't allow
2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c
3) Note that you see the warning "The "EnhancedMessagingPreferences"
syspref is off... etc."
4) Apply the patch and restart services
5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note
the warning no longer shows
6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and
note the warning does show

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 02:59:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 00:59:26 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for
 the same record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-jC2oFb88V5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #274 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #273)
> I fixed the merge conflict but the Javascript in the staff interface doesn't
> work anymore. Probably due to other changes that have happened to the
> templates on master.

This is so weird... I swear that I successfully backported to 21.05 but now
it's not working...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 03:40:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 01:40:59 +0000
Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for
 the same record
In-Reply-To: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15565-70-IUV0U3f5qU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #275 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #274)
> (In reply to David Cook from comment #273)
> > I fixed the merge conflict but the Javascript in the staff interface doesn't
> > work anymore. Probably due to other changes that have happened to the
> > templates on master.
> 
> This is so weird... I swear that I successfully backported to 21.05 but now
> it's not working...

Ah, those Javascript issues are with hold limits. The problem I encountered was
due to Bug 28338...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 03:46:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 01:46:42 +0000
Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup
 location separately
In-Reply-To: <bug-28338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28338-70-qa7AnHSHZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
Just a little comment on this one. 

On "koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt", the function
"check(table)" should really be "check(form)" because it's the form element
#hold-request-form passed in rather than the table element.

It would make more sense to do "check(form)" and then do something like "let
table = form.find('#requestspecific');"

And then when searching through the table, you could do input[name="checkitem"]
rather than input[type="radio"], so that it's more specific. (I say this as
someone who works on bug 15565 though, so that's just me being demanding :p)

Hopefully I'll make the above changes via bug 15565 some day down the line, but
figured I'd note them here anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 07:08:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 05:08:19 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-pYLxejl872@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #164 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #157)
> Created attachment 124568 [details] [review]
> Bug 8367: Make database update idempotent

This query works on MariaDB 10.1.48 (used by koha-testing-docker), but it's not
working for MariaDB 10.3.29 out in the wild on Debian 10...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 07:23:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 05:23:38 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-tv9xrcKlVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #165 from David Cook <dcook at prosentient.com.au> ---
Created attachment 125087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125087&action=edit
Bug 8367: Make database update idempotent (across different MariaDB versions)

The previous query seemed to work on MariaDB 10.1.48 (used by
koha-testing-docker),
but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this
writing),
but this patched query works on both indempotently.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 07:55:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 05:55:15 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-symsIwdVlG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 08:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 06:07:44 +0000
Subject: [Koha-bugs] [Bug 29039] Place hold for patron upon receipt if order
 biblio is linked to a suggestion
In-Reply-To: <bug-29039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29039-70-Lt5o8O3xG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is an older bug report that is really similar to this one - merging them
duplicate to merge discussion as well (difference is only the "when" exactly
the hold should be placed)

*** This bug has been marked as a duplicate of bug 27595 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 08:07:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 06:07:44 +0000
Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted
 purchase suggestions
In-Reply-To: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27595-70-DCvVVm8gD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 29039 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 08:29:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 06:29:35 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-DkoRoVKtBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:26:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:26:14 +0000
Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header
In-Reply-To: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15749-70-07K2QIU511@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Comment 5 talks about reasons why OpacAddMastheadLibraryPulldown doesn't match
the original intention of this patch, but given the 5 years since this had any
comments I don't know if this should remain open.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:30:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:30:11 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-4hjLAcTlyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:30:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:30:14 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-Uawx849z1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125089&action=edit
Bug 29065: Accessibility OPAC clear search history link has insufficient
contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:32:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:32:04 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-7xMxEkzZE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:32:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:32:07 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-oEQssI3Fte@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125081|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125090&action=edit
Bug 29064: Remove duplicate term Most popular titles

To test:
1. Enable system preference OpacTopissue
2. Go to OPAC /cgi-bin/koha/opac-topissues.pl
3. Observe title Most popular titles &rsaquo; Koha online catalogMost popular
titles
4. Apply patch
5. Observe title Most popular titles &rsaquo; Koha online catalog
6. See that this path complies with Bug 27742

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:45:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:45:40 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-YCT4Nz3eLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125091&action=edit
Bug 29058: (follow-up) Add hold count and don't display show options if no
holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:48:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:48:01 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-oYFoshg1sc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:48:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:48:04 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-9uQAELvhTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125085|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125092&action=edit
Bug 29068: Accessibility OPAC search results summary text has insufficient
contrast

This patch changes the colour of the label text in
OPAC search results to increase the contrast ratio,
improve accessibility and make the text easier to read.

To test:

1. Search for something on the OPAC
2. Use an accessibility tool (e.g. Chrome's Lighthouse
   tool) to check the contrast ratio
3. Confirm that the labels (Edition, Format etc.) in the
   results summary have insufficient contrast
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Use the accessibility tool to confirm the contrast
   ratio now meets minimum accessibility requirements
6. Check that the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:48:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:48:09 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-j2eeiE8pPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #6)
> > But would that not be the intended behavior if we want to allow for direct
> > input of the date in the input field for accessibility?

For full accessibility, you should support both options ;)

> 
> Also it seems that the behaviour is the same with our current widget:
> 
> * new patron
> * tab to date of birth input field
> * enter date with keyboard - ok
> * try to use widget with keyboard keys/arrows - doesn't work

I worked on this recently for an accessibility audit of the OPAC ;).

Try the arrow keys whilst holding ctrl or shift ;). Holding ctrl sets the arrow
keys to navigate through days, holding shift allows them to navigate month to
month, year to year.  (This also works with the screen reader, reading out the
date after a small pause on your selected date.

I think I even submitted a documentation patch for this.. it was a requirement
to ensure it worked this way to pass the accessibility audit undertaken by UK
Gov.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:49:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:49:34 +0000
Subject: [Koha-bugs] [Bug 29071] New: HoldsSplitQueueNumbering not set for
 new installs
Message-ID: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071

            Bug ID: 29071
           Summary: HoldsSplitQueueNumbering not set for new installs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Bug 19469 added two new preferences, only one of them is in sysprefs.sql

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:57:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:57:09 +0000
Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new
 installs
In-Reply-To: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29071-70-98JQOX597L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:57:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:57:12 +0000
Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new
 installs
In-Reply-To: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29071-70-gf3tzVd4VI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125093&action=edit
Bug 29071: Add HoldsSplitQueueNumbering to installer data

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:57:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:57:38 +0000
Subject: [Koha-bugs] [Bug 29071] HoldsSplitQueueNumbering not set for new
 installs
In-Reply-To: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29071-70-2dnsjH1UkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19469


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
[Bug 19469] Add ability to split view of holds view on record by pickup library
and/or itemtype
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 12:57:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 10:57:38 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
 record by pickup library and/or itemtype
In-Reply-To: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19469-70-gD16SRKjlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29071


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29071
[Bug 29071] HoldsSplitQueueNumbering not set for new installs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 13:07:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 11:07:29 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-7BgFQNcnLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 13:07:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 11:07:32 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-YMY9LQngmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125079|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125094&action=edit
Bug 29038: Accessibility OPACUserSummary heading doesn't have sufficient
contrast

This patch changes the colour of the OPAC User Summary heading text to
increase the contrast ratio, improving accessibility and making the
text easier to read.

To test:

1. Log in to the OPAC homepage as a user with items checked out
2. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the
   contrast ratio.
3. Confirm the UserSummary heading has insufficient contrast.
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Use the accessibility tool to confirm the contrast ratio now meets
   accessibility requirements
6. Check that the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 13:49:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 11:49:13 +0000
Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header
In-Reply-To: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15749-70-Up5Mw4zC26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749

--- Comment #10 from Chad Billman <chad at pennmanor.net> ---
I have worked around this not getting much traction by setting up multiple
subdomains with OPAC_SEARCH_LIMIT set in apache2. That approach has been
working fine for our needs.

This can be closed from my perspective.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 13:58:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 11:58:55 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-wSDi7iDusZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105767|0                           |1
        is obsolete|                            |
 Attachment #120178|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125095&action=edit
Bug 25716: Add ability to specify additional options in koha-conf.xml for
z3950_responder.pl when using koha-z3950-responder

The z39.50 responder has a number of command line options that are not
accessible if using the debian scripts to control it. We should be able
to set those options in the koha conf file to be passed to the script
itself.

Test Plan:
1) Apply this patch
2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder
if necessary
3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>"
inside your <config> block in your koha-conf.xml file
4) Use koha-z3950-responder to start/restart the z39.50 responder, note the
item status is now in subfield k!

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 13:59:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 11:59:18 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-hzPg6tSlna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125096&action=edit
Bug 25716: Don't exit if config doesn't exist in Koha conf file

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:17:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:17:03 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-Pbp06Z0FkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I think it's okay to just revert it. The severity is only "normal" and it was
requested for 20.05.x
I read comment 17 as an advice about the string freeze and not as a need for
19.11
Could be wrong though. If it turns out to be needed and is fixed for 19.11 ,
then it could still be backported next month.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:21:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:21:27 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-L9iIfcPT8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to wainuiwitikapark from comment #19)
> On 19.11.x 
> 
> Test Result (2 failures / ±0)
> 
>     t_db_dependent_api_v1_biblios_t.get() tests (703)
>     t_db_dependent_api_v1_biblios_t.get_public() tests (703)
> 
> I am getting these failtures
> 
> Can someone please write a patch for that

I tried to understand what's going on yesterday, and couldn't figure why it is
failing, I agree with Victor, that this can safely be reverted to keep jenkins
happy, and if someone requests it, we can come back to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:22:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:22:34 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-1Em0dPqrZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Joonas Kylmälä from comment #13)
> So can we just obsolete those two patches? Let me know when this is ready
> for QA.

I think all three are needed. The first one fixes the koha structure file, the
second one fixes existing installs, and the third one reverts the changes in
the first patch to the original db update that creates the table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:34:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:34:15 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-xgCOi5nLLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:34:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:34:26 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-37Ytdrnpn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120136|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:34:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:34:33 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-JjNflC7Qrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120133|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:34:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:34:39 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-KdyO8UF8pT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120134|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:34:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:34:56 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-tKZh0zILsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120135|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:35:44 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-YCBPjHiLOG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #68 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125097&action=edit
Bug 17314: Make TestBuilder set good defaults for Suggestions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:35:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:35:53 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-uIutV3wjvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #69 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125098&action=edit
Bug 17314: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:35:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:35:59 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-BCZr4r8srz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #70 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125099&action=edit
Bug 17314: OpenAPI spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:36:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:36:05 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-uUoyEuQGXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #71 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125100&action=edit
Bug 17314: Implement /suggestions routes

This patch introduces routes to handle purchase suggestions, from the
staff POV.

Tests are added as well.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/suggestions.t
=> SUCCESS: Tests pass! And they are meaningful!
3. Play with your favourite REST tool (Postman?)
4. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:38:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:38:22 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-G0LMljybBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:39:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:39:51 +0000
Subject: [Koha-bugs] [Bug 29072] New: Move reference route /cities spec to
 YAML
Message-ID: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

            Bug ID: 29072
           Summary: Move reference route /cities spec to YAML
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We have been adding routes in YAML format, which provides an easy path for
adding Markdown documentation. The reference route should be migrated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:39:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:39:57 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-cqgVniC7Ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125097|0                           |1
        is obsolete|                            |

--- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125101&action=edit
Bug 17314: Make TestBuilder set good defaults for Suggestions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:40:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:40:02 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-HQeDE4fIzp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125098|0                           |1
        is obsolete|                            |

--- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125102&action=edit
Bug 17314: Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:40:08 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-pguWhWWR62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125099|0                           |1
        is obsolete|                            |

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125103&action=edit
Bug 17314: OpenAPI spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:40:12 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-d6bEJYUTaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125100|0                           |1
        is obsolete|                            |

--- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125104&action=edit
Bug 17314: Implement /suggestions routes

This patch introduces routes to handle purchase suggestions, from the
staff POV.

Tests are added as well.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/suggestions.t
=> SUCCESS: Tests pass! And they are meaningful!
3. Play with your favourite REST tool (Postman?)
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:40:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:40:46 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-JoY4XlaXx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |28189
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189
[Bug 28189] Move the base swagger file to YAML
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:40:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:40:46 +0000
Subject: [Koha-bugs] [Bug 28189] Move the base swagger file to YAML
In-Reply-To: <bug-28189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28189-70-bMxMMnSoEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29072


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072
[Bug 29072] Move reference route /cities spec to YAML
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:42:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:42:18 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-Uz4bsRF5tW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
* Agree with field names
* Tested manually and all works as expected
* Tests pass
* QA script passes

Going straight for PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:42:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:42:25 +0000
Subject: [Koha-bugs] [Bug 17314] Routes to create,
 list and delete a purchase suggestion
In-Reply-To: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17314-70-QnVFLPBknB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:47:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:47:11 +0000
Subject: [Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for
 new Koha installations
In-Reply-To: <bug-24638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24638-70-GO0NpaKrxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #3 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
Did you look at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309
?

I'm not sure but I think that the new fields you mention are added.
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:54:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:54:54 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-lIfcGWMsWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:54:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:54:59 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-wCJjamzh8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125105&action=edit
Bug 29072: Move reference route /cities spec to YAML

This patch moves the /cities routes spec and related files into YAML so
devs can use it as a reference for future routes.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/cities.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 14:58:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 12:58:50 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-XqzArzGOtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:01:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:01:19 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-ynrOwfYkXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:03:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:03:47 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-euFwVva4mU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125105|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125106&action=edit
Bug 29072: Move reference route /cities spec to YAML

This patch moves the /cities routes spec and related files into YAML so
devs can use it as a reference for future routes.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/cities.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:05:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:05:16 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-HBmiYtKAms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice One!

This is great, I'll stop defaulting to JSON now (as I often use this as a
template for creating other new routes!)

All works before and after patch, tests passing, QA script happy..

Going for a straight PQA again here!  It's only a string patch really.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:05:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:05:20 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-kKHbPxZ8G1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:05:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:05:25 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-VaQVlDxQGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:21:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:21:01 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-9BMNXn8kff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
If we do

  $self->attribute( dt_from_string );

the 'attribute' will obviously have a DateTime in it, as Koha::Object-derived
objects are just blessed hashrefs. We could be doing any weird stuff on those
assignments.

So far we have sticked to the 'know what you're doing' approach, so if you know
you don't care about the stored object, just move on; and if you need it, you
call ->discard_changes.

I'm inclined to think we should keep it like this, and in this particular case
assume there's a bug in Koha::Item->store, which is callig $self->SUPER::store
and then tries to use the resulting object without calling ->discard_changes as
it should.

I can see reasons to prefer not to call ->discard_changes all the time (in API
controllers it is a common mistake not to do it, yielding super weird and hard
to debug errors). But the tradeoff tells me it is not worth making it implicit.

That's my honest opinion on the subject.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:36:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:36:28 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-7RF1gyeYE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124906|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125107&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:36:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:36:57 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-WqyaUmAjb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice speed up here.. No regressions found

PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 15:37:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 13:37:04 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-oY8oev0Hf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:10:17 +0000
Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28377-70-jSpZ6V67oQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Given this patchset includes getting and settings dates via the API I believe
it will fall short on the same grounds that bug 24608 is currently stuck.

We need to properly handle RFC dates in dt_from_string before I'd be
comfortable with us moving to using the API for date setting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:34:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:34:00 +0000
Subject: [Koha-bugs] [Bug 28360] Link to make article reqests should display
 on detail page when user is not logged in
In-Reply-To: <bug-28360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28360-70-ZDyB77eZpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
In my tests in master (as of 21.06.00.022), the "request article" link shows up
in search results and on the detail page regardless of the
ArticleRequestsLinkControl setting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:38:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:38:17 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-wYgAe0yRQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Hayley Pelham from comment #8)
> Hi Joonas,
> 
> The alignment is much closer to the other form elements now, which is great.
> 
> However, if all required fields are completed except the GDPR checkbox, we
> don't get the 'This field is required' text and highlighting like we do for
> other elements.
> 
> Should this be present?

It should be. I will revise this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:41:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:41:44 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-eUT8REeLC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:41:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:41:49 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-bz5fMaYi7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99173|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125108&action=edit
Bug 24674: Uncertain years for publicationyear/copyrightdate -- corrected

This is a correction to Bug 11046: YYY-, YY--, Y---, are also
correct according to ISBD: uncertain year, but certain decade/century
(cf. n. 4.3.8 in ISBD Consolidated Edition of 2011).
(Question mark is not mandatory.)

In addition, in Poland a form with one only dash is quite common,
like YY- (== YY--).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
See last follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:41:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:41:52 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-JTutcwop7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99186|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125109&action=edit
Bug 24674: Adjust tests and add new ones to cover changes

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Rebased 21-09-21.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:41:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:41:57 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-DWbCsHDDiM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125110&action=edit
Bug 24674: (follow-up) Simpler regex

The 'Polish notation' actually simplifies things.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 16:58:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 14:58:25 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-z6jqzwwq38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:15:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:15:16 +0000
Subject: [Koha-bugs] [Bug 29073] New: Hold expiration added to new holds
 when DefaultHoldExpirationdate turned off
Message-ID: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

            Bug ID: 29073
           Summary: Hold expiration added to new holds when
                    DefaultHoldExpirationdate turned off
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: nick at bywatersolutions.com
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 26498

to recreate:
- turn on DefaultHoldExpirationdate, place a hold, confirm it has an expiration
date
- turn off DefaultHoldExpirationdate, place a hold, confirm it still has an
expirtion date

we're saving "no" rather than 0, which is breaking checks further along.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498
[Bug 26498] Add option to set a default expire date for holds at reservation
time
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:15:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:15:16 +0000
Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for
 holds at reservation time
In-Reply-To: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26498-70-zQnnYU9zrp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29073


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073
[Bug 29073] Hold expiration added to new holds when DefaultHoldExpirationdate
turned off
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:28:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:28:12 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-suYLHM1s5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:28:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:28:15 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-o4JYwK5Qd7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125111&action=edit
Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate

DefaultHldexpirationDate is set in the pref screen to 'yes/no'

The code checks if the preference is 'true', 'no' is true

We should instead use 1/0

To test:
0 - Have a fresh devbox
1 - With syspref disabled, place a hold
2 - Note no expiration date set
3 - Enable the preference
4 - Place a hold and note the expiration date is set, good
5 - Disable the pref
6 - Place a hold and note the expiration date is set, bad
7 - Apply patch
8 - Update database
9 - Repeat 1-8, date not set when pref disabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:29:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:29:10 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-fld3bEyXr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Tomas, which means you agree with comment 5?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:34:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:34:09 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-3gbUZwFOar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> Tomas, which means you agree with comment 5?

Yes, but locally. Not implicitly in unblessed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:34:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:34:49 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-7DCjb7bPSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:34:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:34:52 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-Ksf2xp9BTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125111|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125113&action=edit
Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate

DefaultHldexpirationDate is set in the pref screen to 'yes/no'

The code checks if the preference is 'true', 'no' is true

We should instead use 1/0

To test:
0 - Have a fresh devbox
1 - With syspref disabled, place a hold
2 - Note no expiration date set
3 - Enable the preference
4 - Place a hold and note the expiration date is set, good
5 - Disable the pref
6 - Place a hold and note the expiration date is set, bad
7 - Apply patch
8 - Update database
9 - Repeat 1-8, date not set when pref disabled

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:39:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:39:24 +0000
Subject: [Koha-bugs] [Bug 29074] New: DefaultHoldExpirationdatePeriod blank
 value interpreted as zero
Message-ID: <bug-29074-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074

            Bug ID: 29074
           Summary: DefaultHoldExpirationdatePeriod blank value
                    interpreted as zero
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 26498

If DefaultHoldExpirationdate is on and DefaultHoldExpirationdatePeriod is
blank, the blank is treated as a zero and all holds are created with an
expiration date of today. I'm not sure what the best answer is. We could:
- add some text to the syspref to make clear that a blank is treated as zero
- make it always save and display a zero when you try to save a blank
or
- make it treat a blank as disabled (and then add some text to the syspref to
tell people that)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498
[Bug 26498] Add option to set a default expire date for holds at reservation
time
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:39:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:39:24 +0000
Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for
 holds at reservation time
In-Reply-To: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26498-70-B5Lvm4gENl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29074


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074
[Bug 29074] DefaultHoldExpirationdatePeriod blank value interpreted as zero
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:40:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:40:27 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-W65var7IOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Tomas, which means you agree with comment 5?
> 
> Yes, but locally. Not implicitly in unblessed.

That's why comment 5 is suggesting :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:40:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:40:49 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-21SLIISiJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Tomas, which means you agree with comment 5?
> 
> Yes, but locally. Not implicitly in unblessed.

That's what comment 5 is suggesting :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 17:41:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 15:41:15 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-7g2o7MQ4Vp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:09:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:09:21 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-lZu183p7e4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125114&action=edit
Bug 28803: (QA folow-up) Reinstate UNKNOWN_ERROR in templates

I can't see how this will ever get thrown, but as it's there we should
have the template handling included.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:09:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:09:41 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-npOMqLghIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125115&action=edit
Bug 28803: (QA follow-up) Reinstate UNKNOWN_ERROR in templates

I can't see how this will ever get thrown, but as it's there we should
have the template handling included.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:10:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:10:03 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-yTJMeQDt1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125114|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:11:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:11:12 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-ZTVI2mp24g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Done... isn't this already PQA..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:32:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:32:49 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-5RGldhwof0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125032|0                           |1
        is obsolete|                            |

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125117&action=edit
Bug 28934: Make the OPAC registration form design consistent

The gender/sex and GDPR inputs were slightly misaligned (by
1.5em). Now they are aligned with the other inputs which have a width
of 10em (9em width + margin 1em). The label assignments and required
attributes for input elements are made also consistent.

To test:
 1) Enable GDPR_Policy syspref
 2) Apply patch, run "yarn build --view opac", restart plack
 3) Go to /cgi-bin/koha/opac-memberentry.pl
 4) Check that the GDPR input box shows the required text now in red
    color
 5) Check that the alignment of sex/gender and GDPR input matches with
    the other inputs perfectly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 18:33:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 16:33:22 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-Df0OwoaI1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Joonas Kylmälä from comment #9)
 > However, if all required fields are completed except the GDPR checkbox, we
> > don't get the 'This field is required' text and highlighting like we do for
> > other elements.
> > 
> > Should this be present?
> 
> It should be. I will revise this.

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 19:22:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 17:22:59 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-WCQaULpnik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #42)
> Done... isn't this already PQA..

There is only 1 SO-by line on the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 19:35:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 17:35:28 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-yF561yUtyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123390|0                           |1
        is obsolete|                            |

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125119&action=edit
Bug 24190: (follow-up) Rename AcqLog

As requested in comment #49, renamed uses of AcqLog to AcquisitionLog

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

JD amended patch: replace one missing occurrence in Budgets.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:00:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:00:34 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-etocvjR6Vo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
If I apply patches from this bug (27945) and the ones from bug 27944 I am
getting the following failures:

t/db_dependent/ArticleRequests.t .. 22/55 
    #   Failed test 'Limit is 1, so patron cannot request more articles'
    #   at t/db_dependent/ArticleRequests.t line 292. 
    #          got: '1'  
    #     expected: '0'                                                         

    #   Failed test 'There is still an AR, so patron cannot request more
articles'
    #   at t/db_dependent/ArticleRequests.t line 309. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There is still one article request'
    #   at t/db_dependent/ArticleRequests.t line 310. 
    #          got: '2'
    #     expected: '1'

    #   Failed test 'A new AR was created, so patron cannot request more
articles'
    #   at t/db_dependent/ArticleRequests.t line 329. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There are 2 article requests'
    #   at t/db_dependent/ArticleRequests.t line 330. 
    #          got: '3'
    #     expected: '2'

    #   Failed test 'There is an old AR but not completed or cancelled, so
patron cannot request more articles'
    #   at t/db_dependent/ArticleRequests.t line 347. 
    #          got: '1'
    #     expected: '0'

    #   Failed test 'There are 3 current article requests'
    #   at t/db_dependent/ArticleRequests.t line 348. 
    #          got: '4'
    #     expected: '3'
    # Looks like you planned 13 tests but ran 12.
    # Looks like you failed 7 tests of 12 run.
t/db_dependent/ArticleRequests.t .. 55/55 
#   Failed test 'article request limit'
#   at t/db_dependent/ArticleRequests.t line 350.

There are 3 PQA bugs related to article requests (bug 27944, bug 27945 and bug
27947). Please make sure they don't conflict with each others and that the
tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:01:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:01:02 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-kHwFKs2Qnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:01:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:01:11 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-K9J0WhICkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:11:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:11:54 +0000
Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request
 metadata in notices
In-Reply-To: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28340-70-hfxtCrTAlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123336|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125120&action=edit
Bug 28340: Unit test

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

JD amended patch: remove commented line

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:16:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:16:37 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-V0YT5sfecs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Nice one!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:26 +0000
Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to
 another should not create new request
In-Reply-To: <bug-22614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22614-70-eBMzwe6oue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:29 +0000
Subject: [Koha-bugs] [Bug 22614] Request migration from one backend to
 another should not create new request
In-Reply-To: <bug-22614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22614-70-6hWW12NmC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:31 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-WvnWBO2Uu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:34 +0000
Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging
In-Reply-To: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24190-70-eQn0gfOuZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

--- Comment #65 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:37 +0000
Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display
 arbitrary links to related resources
In-Reply-To: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27170-70-FT3TPe6Qeo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:40 +0000
Subject: [Koha-bugs] [Bug 27170] ILL availability should be able to display
 arbitrary links to related resources
In-Reply-To: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27170-70-IF1QTUGnus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:42 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-Xx3thQMRxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:45 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-L38Bh2Tma9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:48 +0000
Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request
 metadata in notices
In-Reply-To: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28340-70-nxY7KBkUJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:50 +0000
Subject: [Koha-bugs] [Bug 28340] Provide improved display of ILL request
 metadata in notices
In-Reply-To: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28340-70-8iWQYi9cnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:53 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-twxQ0V7Tlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:55 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-p1IlJ4i2lb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:18:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:18:58 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-PNLIp7u1V6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:00 +0000
Subject: [Koha-bugs] [Bug 28412] Add supported authentication methods
 documentation
In-Reply-To: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28412-70-jIy6TAv7HA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:03 +0000
Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js
In-Reply-To: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28536-70-OwkZ8Q53gS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:06 +0000
Subject: [Koha-bugs] [Bug 28536] Move translatable strings into overdrive.js
In-Reply-To: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28536-70-RAQJgkamL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28536

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:08 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-bryml5nsXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:11 +0000
Subject: [Koha-bugs] [Bug 28898] Context for translation: term (word) vs.
 term (semester)
In-Reply-To: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28898-70-65tBXlkCHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:13 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-kilYcS46xT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:16 +0000
Subject: [Koha-bugs] [Bug 29032] ILL route unusable (slow)
In-Reply-To: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29032-70-RnO4yZHYvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:18 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-kRcEkz8NCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:19:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:19:21 +0000
Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
In-Reply-To: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29072-70-qBNSRVFQ4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:20:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:20:38 +0000
Subject: [Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
In-Reply-To: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28022-70-QzoGkDCH0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |unspecified
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Congratulations, Thomas, for your first patch pushed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:21:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:21:30 +0000
Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data,
 cannot decode object" on ISBDdetail and MARCdetail pages.
In-Reply-To: <bug-24574-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24574-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24574-70-z1Hf7p9GPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 20:44:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 18:44:06 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-mvEb3notZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:08:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:08:28 +0000
Subject: [Koha-bugs] [Bug 28952] Item Checkout History fails
In-Reply-To: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28952-70-I873XEFrpP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28952

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hafen at washk12.org

--- Comment #1 from Michael Hafen <michael.hafen at washk12.org> ---
I also ran into this error.

The reason it seemed to work from the sql is that the placeholder causes the
'0' to be quoted.  Try the sql with the '0' quoted and you will see the same
error.

Not sure what the best way to handle this is.  Perhaps watch for $date eq 0 in
the issuessince() sub and convert it to '1970-01-01 00:00:00'?

(In reply to beardst from comment #0)
> Created attachment 124504 [details]
> MySQL output
> 
> We are getting an error whenever trying to view an item's checkout history.
> This is happening on all items that we have tested
> 
> /cgi-bin/koha/circ/bookcount.pl?&biblionumber=33518&itm=18222
> 
> Results in a 500 error
> 
> The Plack error log reports
> 
> CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_circ_bookcount_2epl::
> issuessince(): DBI Exception: DBD::mysql::st execute failed: Incorrect
> TIMESTAMP value: '0' [for Statement "SELECT SUM(count) FROM (
>                         SELECT COUNT(*) AS count FROM issues WHERE
> itemnumber = ? and timestamp > ?
>                         UNION ALL
>                         SELECT COUNT(*) AS count FROM old_issues WHERE
> itemnumber = ? and timestamp > ?
>                      ) tmp" with ParamValues: 0="18222", 1=0, 2="18222",
> 3=0] at /usr/share/koha/intranet/cgi-bin/circ/bookcount.pl line 63
> 
> 
> If I run the above sql statement with the variables populated it returns
> information. Screenshot is attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:32:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:32:33 +0000
Subject: [Koha-bugs] [Bug 28952] Item Checkout History fails
In-Reply-To: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28952-70-16QvDwn4ik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28952

--- Comment #2 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 125121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125121&action=edit
Proposed patch

One possible solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:42:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:42:29 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-ocq5E3GAHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:42:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:42:33 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-TgHzxbl6aJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124841|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 125122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125122&action=edit
Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is
OPAC-only

This patch modifies the description of the GoogleOpenIDConnect and
related preferences to make it clear that GoogleOpenIDConnect affects
OPAC logins and that the preferences are related.

To test, apply the patch and go to Administration -> System preferences.

Search for "google," and confirm that the descriptions of
GoogleOpenIDConnect and related preferences look clear and correct.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:43:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:43:55 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-KCXIPf7lRa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
           Keywords|                            |Manual
  Text to go in the|                            |This improves the
      release notes|                            |description of the
                   |                            |GoogleOpenIDConnect and
                   |                            |related preferences to make
                   |                            |it clear that
                   |                            |GoogleOpenIDConnect affects
                   |                            |OPAC logins and that the
                   |                            |preferences are related.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:58:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:58:28 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-K8WnVSk3Ot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:58:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:58:28 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-FqWbzVewkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944
[Bug 27944] Add new stages to the article request process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 21:59:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 19:59:05 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-vFJ4qad1zc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #81 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Nick Clemens from comment #80)
> (In reply to Marcel de Rooy from comment #68)
> > If bug 27945 might pass before this one, we could add here:
> > 
> > +++ b/Koha/Patron.pm
> > @@ -975,7 +975,7 @@ sub can_request_article {
> > 
> > -        { borrowernumber => $self->borrowernumber, status => { '!=' =>
> > ['CANCELED','COMPLETED'] } },
> > +        { borrowernumber => $self->borrowernumber, status => { '!=' =>
> > ['PENDING', 'CANCELED', 'COMPLETED'] } },
> > 
> > It feels better to not count the PENDING reqs here.
> 
> The bugs do not apply on top of each other - one will need to be rebased to
> be pushed before the other, Agustin, can you take care of that and add the
> follow-up?

I've decided this  one will depend on bug 27945. Just because someone had to
make the decision :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 22:00:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 20:00:09 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-9BgPSKkYRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #65 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Tests pass on its own, I've now set bugs dependencies, so if other bug breaks
this, we will treat it in the specific bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 22:19:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 20:19:26 +0000
Subject: [Koha-bugs] [Bug 27893] Delete of biblio with order does not always
 warn
In-Reply-To: <bug-27893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27893-70-PXfuHKgOcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I think blocking the deletion entirely is preferable to a confirmation box. Why
warn the user that their intended action will make a mess that can only be
corrected via a database update and then let them do it anyway? They should be
instructed to go cancel the order(s) in acq.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 23:30:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 21:30:42 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-DiCU6suInA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 23:30:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 21:30:46 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-JSs8dn7zFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Hayley Pelham <hayleypelham at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125117|0                           |1
        is obsolete|                            |

--- Comment #12 from Hayley Pelham <hayleypelham at catalyst.net.nz> ---
Created attachment 125123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125123&action=edit
Bug 28934: Make the OPAC registration form design consistent

The gender/sex and GDPR inputs were slightly misaligned (by
1.5em). Now they are aligned with the other inputs which have a width
of 10em (9em width + margin 1em). The label assignments and required
attributes for input elements are made also consistent.

To test:
 1) Enable GDPR_Policy syspref
 2) Apply patch, run "yarn build --view opac", restart plack
 3) Go to /cgi-bin/koha/opac-memberentry.pl
 4) Check that the GDPR input box shows the required text now in red
    color
 5) Check that the alignment of sex/gender and GDPR input matches with
    the other inputs perfectly.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 23:40:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 21:40:06 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-aAA1RCom7w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124664|0                           |1
        is obsolete|                            |

--- Comment #5 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 125124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125124&action=edit
Proposed patch

Fresh patch with fixes for MariaDB in Debian 9.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 23:40:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 21:40:14 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-zhnOJozcPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 21 23:55:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 21:55:48 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-R7rHcBrUem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi Owen.

After applying the patch, updating the css, flush_memcached, restart_all, and a
fresh browser with the cache cleared I'm not seeing the changes come through in
the OPAC (the login form on the main page and in the header).

It's probably something I haven't done....

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 00:03:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Sep 2021 22:03:31 +0000
Subject: [Koha-bugs] [Bug 29075] New: OPAC info should not be raw in
 libraries table
Message-ID: <bug-29075-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075

            Bug ID: 29075
           Summary: OPAC info should not be raw in libraries table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In Administration › Libraries, we see content of OPAC info as escaped HTML.
This content may be long and seeing HTML tags is strange.

We should not show it in this table.
Or maybe create a modal preview of it (not escaped HTML).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 04:26:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 02:26:05 +0000
Subject: [Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
In-Reply-To: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28604-70-WcQcIxtVoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.11.00,21.05.02,20.11.09, |21.11.00,21.05.02,20.11.09,
        released in|20.05.15,19.11.22           |20.05.15
         Resolution|---                         |FIXED
             Status|Pushed to oldoldoldstable   |RESOLVED

--- Comment #22 from wainuiwitikapark at catalyst.net.nz ---
Ok so reverted these patches - so not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 08:26:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 06:26:58 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-M4lI5qfi4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 08:27:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 06:27:03 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-H71Vl2uDGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124793|0                           |1
        is obsolete|                            |

--- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125125&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is now an HTML customization,
there is actually an HTML tags with id="opacmainuserblock" and one with
id="OpacMainUserBlock".
Same for OPACNavRight in opac-registration-confirmation.tt

This patch removed id from page to keep the one comming from HTML customization
include.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock"
5) Same for id="opacnavright" in opac-registration-confirmation.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 08:27:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 06:27:52 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-obK8mQggD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124794|0                           |1
        is obsolete|                            |

--- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125126&action=edit
Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS

Actually this rule does nothing, it defines same background color as "body" :
#fcf9fc

Test plan :
1) Without patch look at OPAC header
2) With patch OPAC header should have same background color

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 08:31:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 06:31:33 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-Bqh4tHgaQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #13)
> Asked Owen on IRC:
> 
> oleonard> Hm, no... There should be a single OpacMainUserBlock, not two. The
> class would be correct if it were repeated for each additional content
> entry, but it's not.
> Joubu> yes, that's my point
> oleonard> I agree with the change removing the divs from opac-main.tt and
> opac-registration-confirmation.tt, those are cleanups I should have done
> earlier.
> oleonard> However I think the id in html_helpers.inc should stay.

Ok I'm in.

Main patch needs a new signoff.

I've kept followup patch if its OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 08:41:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 06:41:23 +0000
Subject: [Koha-bugs] [Bug 28306] Allow to query database with minimal memory
 footprint
In-Reply-To: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28306-70-X21vrvMssn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #18)
> Bug 28306: Trying to understand...

Does this commit title meet our standards? :)

What I would like to understand too, is what happens with Objects.t on this
patch. At first glance looks like deleting lots of lines since we cannot
resolve a problem with AUTOLOAD or so ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 09:16:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 07:16:14 +0000
Subject: [Koha-bugs] [Bug 27962] UNIMARC update from IFLA for new Koha
 installations
In-Reply-To: <bug-27962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27962-70-f3vrWXV2Vy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27962

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 09:35:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 07:35:30 +0000
Subject: [Koha-bugs] [Bug 28306] Allow to query database with minimal memory
 footprint
In-Reply-To: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28306-70-PU0SjOp68L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #20)
> (In reply to Jonathan Druart from comment #18)
> > Bug 28306: Trying to understand...
> 
> Does this commit title meet our standards? :)
> 
> What I would like to understand too, is what happens with Objects.t on this
> patch. At first glance looks like deleting lots of lines since we cannot
> resolve a problem with AUTOLOAD or so ?

It was not meant to be pushed.

I sent the following email to the QA team on August 31:

"""
Wanna have some fun?
I am struggling with the following situation.
Today I pushed bug 28306 and noticed a failure on Objects.t (see from
coment 15 -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306#c15)
It's absolutely not related with the original patches, but seems to be
linked with 17600 (the EXPORT_OK funkiness).
So there is an easy fix, two actually:
* use C4::Context from the test file (even not used directly from there...)
* Use full qualified namespace for dt_from_string
That could work, but we don't know what's going on exactly.

I've attached a patch to play (comment 18), you just need to run a 3
lines script to recreate the problem
A simple call to dt_from_string generates a "The method
->dt_from_string is not covered by tests!" error.
Because we are hitting AUTOLOAD (??). But the POD is clear, we
shouldn't https://perldoc.perl.org/perlsub#Autoloading
And, we are using dt_from_string that way from Koha::Object (singular)
and it's working perfectly.

So, what's going on? Maybe coming from Koha::DateUtils that is not
using EXPORT_OK? I tried, see bug 28931. You can apply the patch from
there and try again with the 3 lines script.

Unfortunately, it's not fixed, but maybe part of the solution...
I need more eyes one this one, please help!
"""

I didn't receive any feedback and decided to abandon the investigation and push
the (meaningless) fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 09:45:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 07:45:54 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-kOoGah0AYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Henry Bolshaw <bolshawh at parliament.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 09:45:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 07:45:58 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-bJlVo2zA2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

--- Comment #1 from Henry Bolshaw <bolshawh at parliament.uk> ---
Created attachment 125127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125127&action=edit
Bug 29070: Accessibility OPAC Purchase suggestions box on search results page
has insufficient contrast

This patch changes the text colour for the purchase
suggestion box on the OPAC search results page to
make the text easier to read and improve accessibility.

To test:

1. Log in to the OPAC and search for something
2. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the Purchase suggestion text
   fails to meet accessibility requirements
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Confirm the text contrast ratio now meets
   minimum accessibility requirements
6. Check that the OPAC still looks ok after
   the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 10:15:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 08:15:48 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-enzO95uRm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Does it mean we should drop Flatpickr and revert what has been pushed already?

It seems that their accessibility issues don't get much attention:
https://github.com/flatpickr/flatpickr/milestone/5

See also https://github.com/flatpickr/flatpickr/issues/1329

Workaround suggested at
https://github.com/flatpickr/flatpickr/issues/1329#issuecomment-380805839

(In reply to Martin Renvoize from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > > But would that not be the intended behavior if we want to allow for direct
> > > input of the date in the input field for accessibility?
> 
> For full accessibility, you should support both options ;)
> 
> > 
> > Also it seems that the behaviour is the same with our current widget:
> > 
> > * new patron
> > * tab to date of birth input field
> > * enter date with keyboard - ok
> > * try to use widget with keyboard keys/arrows - doesn't work
> 
> I worked on this recently for an accessibility audit of the OPAC ;).
> 
> Try the arrow keys whilst holding ctrl or shift ;). Holding ctrl sets the
> arrow keys to navigate through days, holding shift allows them to navigate
> month to month, year to year.  (This also works with the screen reader,
> reading out the date after a small pause on your selected date.
> 
> I think I even submitted a documentation patch for this.. it was a
> requirement to ensure it worked this way to pass the accessibility audit
> undertaken by UK Gov.

I do confirm that ctrl allows to navigate through days, however shift does
nothing for me. Alt does but conflicts with browser's shortcuts (tab switch).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 13:07:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 11:07:23 +0000
Subject: [Koha-bugs] [Bug 28306] Allow to query database with minimal memory
 footprint
In-Reply-To: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28306-70-jL6yNiMT3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #21)
> I sent the following email to the QA team on August 31:
> 
> I didn't receive any feedback and decided to abandon the investigation and
> push the (meaningless) fix.

Yeah I saw it but the security stuff came after it right away and has put this
one in the shadow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 13:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 11:55:43 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-Wvow2QC4vg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 13:55:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 11:55:46 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-QiqNDVvbGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125129&action=edit
Bug 29062: Use primary key issued_id to fetch old_issues for letters

The code currently uses itemnumber to fetch old_issues for notices.
This doesn't seem to be used in any current notices except the CHECKINSLIP:
SELECTY letter.code,content FROM letter WHERE content LIKE 'old\\_%'\G

For issues we use itemnumber, however, issues has a constraint to limit issues
for an itemnumber to 1
Old issues has no such constraint, we try to rectify this in the old code by
adding 'ORDER BY returndate DESC LIMIT 1"

As the code is not used by default and buggy I think we can make a change to
using 'issue_id' as the key and
announcing the change - it prevents leaky data

To test:
1. Check something out to patron A. Check it in.
2. Check something out to patron B. Check it in.
3. Check something out to patron C. Check it in and print the check-in slip.
(Leave the checkin paghe open)
4. You will see the checkin repeat itself 3 times, one for each line in
old_issues.
5. Apply patch and restart_all
6. Click the 'Print checkin slip' button again
7. You see a single checkin
8. Checkout a different item to patron A. Check it in and print the check-in
slip
9. See the correct checkins

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:02:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:02:35 +0000
Subject: [Koha-bugs] [Bug 29076] New: cleanup_database.pl dies of passed
 zebraqueue and not confirm
Message-ID: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

            Bug ID: 29076
           Summary: cleanup_database.pl dies of passed zebraqueue and not
                    confirm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

To recreate:
perl  misc/cronjobs/cleanup_database.pl --sessions --zebraqueue 10
--list-invites --z3950 --logs 180 --mail 375
Confirm flag not passed, running in dry-run mode...
{UNKNOWN}: DBI Exception: DBD::mysql::st fetchrow_hashref failed: fetch()
without execute()  at /usr/share/perl5/DBIx/Class/Schema.pm line 1118.
        DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x55c5ab09aff0),
"DBI Exception: DBD::mysql::st fetchrow_hashref failed: fetch("...) called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113
       
DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x55c5b27dc0c8),
"DBI Exception: DBD::mysql::st fetchrow_hashref failed: fetch("...) called at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501
        DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::st fetchrow_hashref
failed: fetch() without execu"..., DBI::st=HASH(0x55c5b494d6f8), undef) called
at misc/cronjobs/cleanup_database.pl line 290

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:05:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:05:02 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-BZvU2TViHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:05:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:05:05 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-xIlsWdBO9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125130&action=edit
Bug 29076: Fetch the zebraqueue entries when not confirm

This patch remove a check for confirm when fetching the entries
for possible deletion from the zebraqueue

Without this we die when we try to access the entries for counting

To test:
1 - perl  misc/cronjobs/cleanup_database.pl --sessions --zebraqueue 10
--list-invites --z3950 --logs 180 --mail 375 -v
2 - Dies
3 - Apply patch
4 - Repeat 1
5 - Success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:05:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:05:43 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-3qFGrE5Y2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24153
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153
[Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:05:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:05:43 +0000
Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the
 cleanup_database.pl cronjob
In-Reply-To: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24153-70-0BfchcTSgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29076


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076
[Bug 29076] cleanup_database.pl dies of passed zebraqueue and not confirm
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:07:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:07:06 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-FPketwNRrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|robin at catalyst.net.nz       |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:08:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:08:09 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-PhfWak0cdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:08:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:08:13 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-4ILGhyfzc0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125130|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125131&action=edit
Bug 29076: Fetch the zebraqueue entries when not confirm

This patch remove a check for confirm when fetching the entries
for possible deletion from the zebraqueue

Without this we die when we try to access the entries for counting

To test:
1 - perl  misc/cronjobs/cleanup_database.pl --sessions --zebraqueue 10
--list-invites --z3950 --logs 180 --mail 375 -v
2 - Dies
3 - Apply patch
4 - Repeat 1
5 - Success!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:26:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:26:15 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-bGgYS2eSVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27945
         Depends on|27945                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:26:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:26:15 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-fBnubCgIVt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|27944                       |
         Depends on|                            |27944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944
[Bug 27944] Add new stages to the article request process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:40:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:40:28 +0000
Subject: [Koha-bugs] [Bug 10919] Use the date of closing basketgroup for
 calculating late orders
In-Reply-To: <bug-10919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10919-70-2rsFfnHSRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10919

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:50:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:50:01 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-zDOSzcI4tg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #72 from mathieu saby <mathsabypro at gmail.com> ---
Hi
I proposed a patch for that bug a loooong time ago. I suppose it is obsolete
now, but I am a bit sad to see that the situation has not evolved.
Is it reasonable to expect a solution in the foreseeable future?

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:52:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:52:46 +0000
Subject: [Koha-bugs] [Bug 10919] Use the date of closing basketgroup for
 calculating late orders
In-Reply-To: <bug-10919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10919-70-q6THvZhLpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10919

--- Comment #2 from mathieu saby <mathsabypro at gmail.com> ---
This bug was still assigned to me. Of course it is no more the case since 2013

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:55:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:55:14 +0000
Subject: [Koha-bugs] [Bug 29077] New: Warns when searching blank index
Message-ID: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077

            Bug ID: 29077
           Summary: Warns when searching blank index
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

To recreate:
1 - Be using Elasticsearch
2 - Search on OPAC with dropdown set to 'Library catalog'
3 - Warns in plack-opac-error.log
[2021/09/22 12:40:55] [WARN] Use of uninitialized value $f in pattern match
(m//) at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line
725.
[2021/09/22 12:40:55] [WARN] Use of uninitialized value $f in exists at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 731.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:58:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:58:11 +0000
Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29077-70-UlMVfU6RVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:58:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:58:14 +0000
Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29077-70-9v1WHctE1F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125132&action=edit
Bug 29077: Remove blank indexes before convert

To test:
1 - Be using Elasticsearch
2 - Search on OPAC with dropdown set to 'Library catalog'
3 - Warns in plack-opac-error.log
4 - Apply patch
5 - Repeat
6 - No warns
7 - Search returns correct results

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 14:58:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 12:58:32 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-CAEpqcZBDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 15:07:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 13:07:50 +0000
Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element
 causes duplicate actions
In-Reply-To: <bug-28932-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28932-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28932-70-IMrCZT7Ukt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 15:08:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 13:08:46 +0000
Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to
 use backend template
In-Reply-To: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28909-70-F0vvuHYpKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 15:40:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 13:40:10 +0000
Subject: [Koha-bugs] [Bug 24674] Uncertain years for
 publicationyear/copyrightdate -- corrected
In-Reply-To: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24674-70-4koQhjIVtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You might be surprised what you find if you look for copyrightdate>0 and
copyrightdate<1000 in your local catalogue..

You could use this in a where statement with touch_all_biblios

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 15:53:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 13:53:11 +0000
Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29077-70-gOqCjmsWj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:05:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:05:59 +0000
Subject: [Koha-bugs] [Bug 29078] New: Division by zero in touch_all scripts
Message-ID: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

            Bug ID: 29078
           Summary: Division by zero in touch_all scripts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The touch_all scripts allow you to specify a where condition. If you have no
records in the set, the result is divided by zero to get a percentage.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:11:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:11:10 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-vfSxnVPSGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:11:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:11:14 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-otFrWQiqeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125133&action=edit
Bug 29078: Resolve division by zero in touch_all scripts

Illegal division by zero at misc/maintenance/touch_all_biblios.pl line 102.

Trivial fix.
Funny that the percentage is not even shown without verbose flag ;)

Test plan:
Run misc/maintenance/touch_all_biblios.pl -where 'biblionumber<0'
You should now see:
Good: 0, Bad: 0 (of 0) in 0 seconds

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:11:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:11:37 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-2hSELx7aYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Super trivial, self signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:35:44 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-Lh2N9Xb2z1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
You populated these preferences? 

GoogleOAuth2ClientID
GoogleOAuth2ClientSecret

And turned this one on?

GoogleOpenIDConnect

Do you have any missing modules under About -> Perl modules?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:36:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:36:19 +0000
Subject: [Koha-bugs] [Bug 27964] Link to subscription in serial collections
 view is broken - the field subscriptionid is undefined in the subscription
 object.
In-Reply-To: <bug-27964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27964-70-W6Alrbmg7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:46:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:46:10 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-T2HlIEd1tx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:46:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:46:13 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-3c1VGYgrdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125131|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125134&action=edit
Bug 29076: Fetch the zebraqueue entries when not confirm

This patch remove a check for confirm when fetching the entries
for possible deletion from the zebraqueue

Without this we die when we try to access the entries for counting

To test:
1 - perl  misc/cronjobs/cleanup_database.pl --sessions --zebraqueue 10
--list-invites --z3950 --logs 180 --mail 375 -v
2 - Dies
3 - Apply patch
4 - Repeat 1
5 - Success!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:46:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:46:23 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-X3yLIF6XiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:49:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:49:38 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-rD1etB1bKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:49:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:49:41 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-LwsZzWE4xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125090|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125135&action=edit
Bug 29064: Remove duplicate term Most popular titles

To test:
1. Enable system preference OpacTopissue
2. Go to OPAC /cgi-bin/koha/opac-topissues.pl
3. Observe title Most popular titles &rsaquo; Koha online catalogMost popular
titles
4. Apply patch
5. Observe title Most popular titles &rsaquo; Koha online catalog
6. See that this path complies with Bug 27742

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:50:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:50:06 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-g0tUM5WLKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:51:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:51:19 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-0sSDccVCS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:51:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:51:22 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-PPrjSOgBbE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125127|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125136&action=edit
Bug 29070: Accessibility OPAC Purchase suggestions box on search results page
has insufficient contrast

This patch changes the text colour for the purchase
suggestion box on the OPAC search results page to
make the text easier to read and improve accessibility.

To test:

1. Log in to the OPAC and search for something
2. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the Purchase suggestion text
   fails to meet accessibility requirements
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Confirm the text contrast ratio now meets
   minimum accessibility requirements
6. Check that the OPAC still looks ok after
   the changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:56:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:56:44 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-kRBVGXdd27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:56:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:56:48 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-nh0vWNMBJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125125|0                           |1
        is obsolete|                            |
 Attachment #125126|0                           |1
        is obsolete|                            |

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125137&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is now an HTML customization,
there is actually an HTML tags with id="opacmainuserblock" and one with
id="OpacMainUserBlock".
Same for OPACNavRight in opac-registration-confirmation.tt

This patch removed id from page to keep the one comming from HTML customization
include.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock"
5) Same for id="opacnavright" in opac-registration-confirmation.tt

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 16:56:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 14:56:52 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-Eo5f7LyVCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125138&action=edit
Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS

Actually this rule does nothing, it defines same background color as "body" :
#fcf9fc

Test plan :
1) Without patch look at OPAC header
2) With patch OPAC header should have same background color

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:04:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:04:26 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-llRPWRGXCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:04:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:04:29 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-dgOf66c5VE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125083|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125139&action=edit
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings
title

We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC
messaging preferences title, so it's dead code.

This patch removes the useless duplicate if-statement.

To test:
1. Enable EnhancedMessagingPreferencesOPAC system preference
2. Go to /cgi-bin/koha/opac-messaging.pl
3. Observe title Your messaging settings > Koha online catalog
4. Apply patch
5. Refresh page /cgi-bin/koha/opac-messaging.pl
6. Observe same title Your messaging settings > Koha online catalog
7. See patch content
8. Confirm there are no functional changes in the new logic

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:09:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:09:49 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-FQ5ALp56a4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124673|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:09:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:09:53 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-xP2YQKO8LE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124674|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:09:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:09:57 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-V80wyiL5Ya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124675|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:01 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-E5Y8M2GHTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124676|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:05 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-EBhy7feGVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124677|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:09 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-PybppLG8OK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124678|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:13 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-ekj6zj1YR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124679|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:17 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-V1TmdNU5rb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124680|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:21 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-dtKF6HS7KB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124681|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:10:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:10:25 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-9mqpRXLXIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124682|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:04 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-KPDYTYCVR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #66 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125140&action=edit
Bug 27945: Add tests

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:06 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-sbKot2Ybbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:10 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-ZKYYqF0Yyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124923|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125141&action=edit
Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient
contrast ratio

This patch changes the colour of the masthead
search label to improve accessibility and make it
easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that the search label has insufficient
   contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio now meets accessibility
   requirements.
5. Check that the OPAC still looks ok after
   the changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:12 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-oFOamZlFBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #67 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125142&action=edit
Bug 27945: Add article_request_limit in categories table

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:18 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-6Y5sMCTf4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #68 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125143&action=edit
Bug 27945: [DO NOT PUSH] Update DBIx schema

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:23 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-dt5cIaL7ix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #69 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125144&action=edit
Bug 27945: Add limit article request feature

This patch makes it possible to limit article requests per patron per day.

To test:
1. Apply patches
2. updatedatabase
3. Enable ArticleRequests preference
4. Edit a patron category and set an article request limit to 1
CHECK => if you set the limit to anything else but a positive number or empty
string, a warning appears
5. In staff search biblios and request an article for a patron of the modified
category
6. Repeat step 5
SUCCESS => if limit is reached, when you select the user to request an article
a warning appears saying that the limit was reached
7. Repeat steps 5 and 6 but this time in opac
SUCCESS => Patron is not allowed to request another article if limit is reached
8. prove t/db_dependent/ArticleRequests.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:30 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-F77RVNKtRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #70 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125145&action=edit
Bug 27945: (QA follow-up) Fix exception POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:37 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-J0WJPXv3Av@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #71 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125146&action=edit
Bug 27945: (follow-up) Fix column header title and edit form label

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:43 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-mIi6DoKJhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #72 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125147&action=edit
Bug 27945: (follow-up) fix limit check in Patron.pm, regexp in categories.pl
and removed unwanted use Koha::ArticleRequests in ArticleRequest.pm

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:49 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-zSx6989kC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #73 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125148&action=edit
Bug 27945: (QA follow-up) Fix limit check

Resolve:
    [WARN] SQL::Abstract::belch(): [SQL::Abstract::_where_field_op_ARRAYREF]
Warning: A multi-element arrayref as an argument to the inequality op '!=' is
technically equivalent to an always-true 1=1 (you probably wanted to say ...{
$inequality_op => [ -and => @values ] }... instead) at
/usr/share/koha/Koha/Objects.pm line 601

In this case we can simply count the statuses PENDING and PROCESSING.
Note that bug 27944 will change that; PENDING should be replaced by
REQUESTED there.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:11:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:11:56 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-ghWMaWXA26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #74 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125149&action=edit
Bug 27945: (QA follow-up) Terminology

The term "Maximum article request limit" could be improved.

In this patch we use 'Article request limit' to describe it more
generic. On the field we say 'Maximum active article requests'.

In the manual we need to explain that it is the sum of requests in
Pending (Requested) or Processing stage and completed requests within
the last 24 hours.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:12:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:12:02 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-zOr8wWUHGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #75 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125150&action=edit
Bug 27945: (follow-up) Fix tests for the adjusted check

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:12:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:12:07 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-JDjIK55yml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #76 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125151&action=edit
Bug 27945: Move atomicupdate to new format

It also removes the implicit dependency on bug 27946 by changing the
AFTER column.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:12:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:12:15 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-cBl5qYim1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #77 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125152&action=edit
Bug 27945: (QA follow-up) Fix and move tests to proper file

Koha::Patron methods tests belong to the t/db_dependent/Koha/Patron.t
tests file.

This patch moves the tests, and also acknowledges the fact that we can
use Test::Exception instead of a try/catch block. It also fixes the
tests so they actually trigger the ->request method, which is the one
that raises the exception if the limit is reached.

At some point, because of the dependency mess, this bug ended up with
the exception throwing in the wrong method, and that's why tests were
also failing.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/ArticleRequests.t
=> FAIL: Patron.t passes, ArticleRequests.t doesn't
2. Apply this patch
3. Repeat 1
=> SUCCESS: Both pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:13:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:13:31 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-r9960qV6a5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #78 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Rebased on top of bug 27944, fixed a problem introduced by a rebase, fixed the
tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:19:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:19:18 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-zpoyAa8O21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:19:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:19:21 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-oYRAJH2Y0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124912|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125153&action=edit
Bug 29037: Accessibility: OPAC links don't have sufficient contrast

This patch changes the colour of links on the OPAC
to improve the contrast ratio and make the link
text easier to read. This accessibility issue was
identified using the WebAIM WAVE accessibility
browser extension and Google Chrome's Lighthouse
tool.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that some links (e.g. breadcrumb links
   and title links in search results) have
   insufficient contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio meets minimum requirements
5. Check that the OPAC still looks ok after the
   changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:27:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:27:35 +0000
Subject: [Koha-bugs] [Bug 29079] New: Biblio info info Holds Queue needs to
 be able to be customized
Message-ID: <bug-29079-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079

            Bug ID: 29079
           Summary: Biblio info info Holds Queue needs to be able to be
                    customized
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

With the addition of information to the biblio info column in the Holds queue,
there can end up being a lot of info in that field, and it is not necessary for
many libraries.  It would be really helpful to be able to customize this to
show only what the library needs.  An extra bonus would be to add a separate
column for this info, so that the first column is title, and the second is
biblio info that is customizable.

One example:
A history of France /

Norwich, John Julius,
First Grove Atlantic hardcover edition.
, 2018 : xiii, 382 pages, 16 unnumbered leaves of plates : 24 cm ISBN:
9780802128904

Many libraries would only want the title and author.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:37:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:37:59 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-yNd1WaE5Yk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:38:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:38:02 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-EzYk7JUr9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125129|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 125154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125154&action=edit
Bug 29062: Use primary key issued_id to fetch old_issues for letters

The code currently uses itemnumber to fetch old_issues for notices.
This doesn't seem to be used in any current notices except the CHECKINSLIP:
SELECTY letter.code,content FROM letter WHERE content LIKE 'old\\_%'\G

For issues we use itemnumber, however, issues has a constraint to limit issues
for an itemnumber to 1
Old issues has no such constraint, we try to rectify this in the old code by
adding 'ORDER BY returndate DESC LIMIT 1"

As the code is not used by default and buggy I think we can make a change to
using 'issue_id' as the key and
announcing the change - it prevents leaky data

To test:
1. Check something out to patron A. Check it in.
2. Check something out to patron B. Check it in.
3. Check something out to patron C. Check it in and print the check-in slip.
(Leave the checkin paghe open)
4. You will see the checkin repeat itself 3 times, one for each line in
old_issues.
5. Apply patch and restart_all
6. Click the 'Print checkin slip' button again
7. You see a single checkin
8. Checkout a different item to patron A. Check it in and print the check-in
slip
9. See the correct checkins

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:38:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:38:33 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-z9zLvdI4mY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:58:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:58:18 +0000
Subject: [Koha-bugs] [Bug 28730] Add option to format AH field (due date) in
 SIP checkout response
In-Reply-To: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28730-70-dbnbsdnD6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124062|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125155&action=edit
Bug 28730: Add option to format AH field (due date) in SIP checkout response

This patch adds a new option to sip accounts:
format_due_date

If set to 1 the AH field in checkouts will follow the dateFormat system
preference and format as due dates (ignoring time portion if 23:59:59 or
11:59:59)

To test:
 1 - checkout an item via SIP:
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL
-t CR --item 3999900000001 --patron enda -m checkout
 2 - Note the AH field is like "YYYYMMDD    HHMMSS"
 3 - Apply patch
 4 - repeat SIP checkout - nothing has changed
 5 - edit SIPConfig.xml and add format_due_date="1" to 'term1' account:
    <login id="term1"  password="term1" delimiter="|" error-detect="enabled"
institution="CPL" encoding="ascii"     checked_in_ok="1" format_due_date="1"/>
 6 - restart all
 7 - repeat the SIP checkout
 8 - AH field now matches dateFormat system preference
 9 - Change your dateFormat preference
10 - repeat the SIP checkout
11 - AH matches new format

Note: If you cannot renew and don't get an AH just check the item back in:
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL
-t CR --item 3999900000001 --patron enda -m checkin

Signed-off-by: Winfred Thompkins <Winfred.thompkins at cedarhilltx.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:58:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:58:21 +0000
Subject: [Koha-bugs] [Bug 28730] Add option to format AH field (due date) in
 SIP checkout response
In-Reply-To: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28730-70-7g5zOXiJh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125156&action=edit
Bug 28730: (QA follow-up) Add new option to example configs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 17:59:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 15:59:14 +0000
Subject: [Koha-bugs] [Bug 28730] Add option to format AH field (due date) in
 SIP checkout response
In-Reply-To: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28730-70-qVVIQMACNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, no regressions.. I added a follow-up to add the config
option to the example configs (disabled by default).

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 18:36:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 16:36:19 +0000
Subject: [Koha-bugs] [Bug 25241] Accessibility: 1.4.4 Resize text
In-Reply-To: <bug-25241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25241-70-fWxCUri9JP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25241

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think Bug 20168 made a lot of improvements in this area.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 18:40:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 16:40:23 +0000
Subject: [Koha-bugs] [Bug 29080] New: Missing data trail for reduced fine
Message-ID: <bug-29080-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29080

            Bug ID: 29080
           Summary: Missing data trail for reduced fine
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23091

To recreate:
- Set MarkLostItemsAsReturned to ON for all cases, WhenLostChargeReplacementFee
ON, WhenLostForgiveFine ON
- Set you refund lost item value to refund lost fee and charge a new overdue
fine
- set a circ rule to charge $1 per day overdues
- check out an item, setting its due date to 7 days ago
- run the fines cron, see your $7 accruing fine
- mark the item lost, confirm the $7 fine is forgiven
- check the item in, backdating the checkin to 5 days ago
- confirm your new fine is $2, but old_issues.returndate still shows the time
at which this item was marked lost

In this situation, I can't find anything in the data to explain why the fine is
$2. That's the correct amount, given the actions, but if one stumbled on this
patron after the fact one would have a hard time figuring out what happened.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091
[Bug 23091] Add options to charge new or restore forgiven overdues when a lost
item is returned
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 18:40:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 16:40:23 +0000
Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore
 forgiven overdues when a lost item is returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-F71MDMP9Uz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29080
[Bug 29080] Missing data trail for reduced fine
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 18:42:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 16:42:32 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-QMrTRFQTti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #61 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125157&action=edit
Bug 18138: fix atomic update and system preference type

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 18:46:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 16:46:23 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-gphQVAaa6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #62 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Phil Ringnalda from comment #60)
> https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/
> mysql/kohastructure.sql;h=02cf864ddd7f0f2ca6a921ae2a9045a18e1375f6;
> hb=HEAD#l4987 - type is 20, no?

Hi! Yes, sorry. I misunderstood. The reason it seamed to work for me and I did
not get the crash was (probably) the patch using an old koha format for patch
database updates (atomicupdate). My guess is you tried the patch out with a
slightly older version of Koha where the old format worked and got the error,
and for me it simply did not run (nor produce any errors) and the syspref had
been previously added before the type change. I fixed the atomicupdate to use
perl-script instead, and shortened the type name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 19:08:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 17:08:03 +0000
Subject: [Koha-bugs] [Bug 29081] New: Lost item behavior can result in
 duplicate fines
Message-ID: <bug-29081-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29081

            Bug ID: 29081
           Summary: Lost item behavior can result in duplicate fines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23091

If one's lost item refund behavior is set to charge a new when a lost item is
found, but one has WhenLostForgiveFine turned off, then the patron ends up with
2 identical fines. The original overdue never goes away, and a new one is
created anyway.

I'd like to just block creation of the second fine.
If that's not feasible, we should at least put a warning on the refund area in
circ rules.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091
[Bug 23091] Add options to charge new or restore forgiven overdues when a lost
item is returned
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 19:08:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 17:08:03 +0000
Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore
 forgiven overdues when a lost item is returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-32d2EEozHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29081
[Bug 29081] Lost item behavior can result in duplicate fines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 19:10:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 17:10:16 +0000
Subject: [Koha-bugs] [Bug 29013] Add ability to uncancel an order
In-Reply-To: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29013-70-Ih03SBFZ5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013

--- Comment #5 from Karen Venturella <Malnati at ucc.edu> ---
I was told "There isn't a way to unreceive them in order to receive them in
FY22."
Perhaps you can reach out to Sara Brown to describe the problem.

I want to receive 3 print copies of MLA handbook in FY22 and I had entered the
order in FY2021.
Is it possible to enter new order and mark FY21 order as cancelled?

Karen

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 19:19:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 17:19:30 +0000
Subject: [Koha-bugs] [Bug 29081] Lost item behavior can result in duplicate
 fines
In-Reply-To: <bug-29081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29081-70-GiKERJqDKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29081

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I should note, I realize it makes no sense to set things this way. It's a bad
idea. But we should maybe protect against it anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:15:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:15:06 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-3uvKLxnIWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #82 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125158&action=edit
Bug 27944: (QA follow-up) Make atomic update idempotent

This patch checks the DB structure to see if the status column
definition contains 'REQUESTED' as a valid ENUM value.

The script is also moved into the new style.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:18:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:18:04 +0000
Subject: [Koha-bugs] [Bug 29082] New: Add filtering methods to
 Koha::ArticleRequests
Message-ID: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

            Bug ID: 29082
           Summary: Add filtering methods to Koha::ArticleRequests
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I propose to add:
- filter_by_current
- filter_by_finished

to be reused in several areas.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:18:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:18:16 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-g9OoLRrTd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:19:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:19:23 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-HcO1Rc4us9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28684

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:19:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:19:23 +0000
Subject: [Koha-bugs] [Bug 28684] Superfluous -or condition in few article
 request queries
In-Reply-To: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28684-70-9wJSp1PsX0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29082

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:24:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:24:42 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-RkZdlJqM3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:25:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:25:14 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-ZdGDk5RP9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:25:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:25:18 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-04POEpIUTY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125159&action=edit
Bug 29082: Add filtering methods to Koha::ArticleRequests

This patch adds handy methods for filtering Koha::ArticleRequests
resultsets.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:31:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:31:04 +0000
Subject: [Koha-bugs] [Bug 29083] New: Update article requests-related
 Koha::Patron methods to use relationships
Message-ID: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

            Bug ID: 29083
           Summary: Update article requests-related Koha::Patron methods
                    to use relationships
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:31:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:31:38 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-2r90diRMnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:33:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:33:05 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-s7xtJEdWnj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:33:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:33:05 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-8yiK8SXXno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:33:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:33:28 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-ikJJvSHyV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Added bug 27945 as dependency because it touches the same tests file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:55:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:55:22 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-x0g6XvUJdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:55:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:55:26 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-SpZIdmI693@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125160&action=edit
Bug 29083: Unit tests

This patch adds missing tests for Koha::Patron->article_requests and
moves (and extends) tests for 'article_requests_current' and
'article_requests_finished' that were originally in ArticleRequests.t
into Koha/Patron.t as we now do.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests pass!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:55:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:55:31 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-bJQZkOX7pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125161&action=edit
Bug 29083: Update article requests-related Koha::Patron methods to use
relationships

This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.

No behavior change should take place.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:55:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:55:50 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-T9RNKRU62P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29082


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082
[Bug 29082] Add filtering methods to Koha::ArticleRequests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 20:55:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 18:55:50 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-IR0mc0dBt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:01:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:01:56 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-26DMlJuhby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125162&action=edit
Bug 29083: (QA follow-up) Remove unused param

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:09:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:09:59 +0000
Subject: [Koha-bugs] [Bug 29084] New: Update article requests-related
 Koha::Biblio methods to use relationships
Message-ID: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

            Bug ID: 29084
           Summary: Update article requests-related Koha::Biblio methods
                    to use relationships
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

As bug 29083 does for Koha::Patron, this bug will deal the with Koha::Biblio
counterpart.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:10:13 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-vUAciiXUM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |29083
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:10:13 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-jY63fkwaSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084
[Bug 29084] Update article requests-related Koha::Biblio methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:17:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:17:59 +0000
Subject: [Koha-bugs] [Bug 28684] Superfluous -or condition in few article
 request queries
In-Reply-To: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28684-70-NGYjJXLNqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29083
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:17:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:17:59 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-UpJkZ7t7Ex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28684

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:18:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:18:07 +0000
Subject: [Koha-bugs] [Bug 28684] Superfluous -or condition in few article
 request queries
In-Reply-To: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28684-70-xGzrEeXGzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29084

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:18:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:18:07 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-cIkRQ8loPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28684

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:18:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:18:47 +0000
Subject: [Koha-bugs] [Bug 28684] Superfluous -or condition in few article
 request queries
In-Reply-To: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28684-70-JOpmSZB2sr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Good catch, solved in the linked bugs.

*** This bug has been marked as a duplicate of bug 29082 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:18:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:18:47 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-wnVtuG6RH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 28684 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:26:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:26:10 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-CyXUA49kzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:26:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:26:15 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-BrMRiNopLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125163&action=edit
Bug 29084: Unit tests

This patch adds missing tests for Koha::Biblio->article_requests and
reorganizes (and extends) the tests for 'article_requests_current' and
'article_requests_finished' that were originally in ArticleRequests.t
into Koha/Biblio.t as we do now.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:26:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:26:20 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-9rBJ13CjDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125164&action=edit
Bug 29084: Update article requests-related Koha::Biblio methods to use
relationships

This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.

No behavior change should take place.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:31:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:31:10 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-po73hLlGG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27947


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
[Bug 27947] Add default cancellation reasons to article requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:31:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:31:10 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-PGLOoJVI4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:19 +0000
Subject: [Koha-bugs] [Bug 29085] New: Add an alert when deleting a vendor
 linked to a subscription
Message-ID: <bug-29085-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29085

            Bug ID: 29085
           Summary: Add an alert when deleting a vendor linked to a
                    subscription
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

Hi,

Currently (20.05), when deleting a vendor, there is no alert to check if a
subscription is linked to the vendor.

if the vendor is deleted anyway, in the subscription, the vendor box is empty
but the booksellerid remains visible.

When editing a subscription, an error message appears because the vendor is no
longer found.

see the following video https://www.screencast.com/t/5oi85cCFGclS

Can an alert be added to mean that the vendor should not be deleted as it is
used in a subscription?

Regards,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:32 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-R5mwQIZNMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Last rebase after dependency changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:37 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-tEQjVLXY6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125038|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:41 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-nqdodTAiDr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125039|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:45 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-1pygjq0fUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125040|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:49 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-iIXas7j8QB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125041|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:52 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-gWlLqepFaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125042|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:33:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:33:58 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-fWkwr1q2S4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125043|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:34:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:34:02 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-Kj7aNTX8Hf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125044|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:34:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:34:06 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-vfhuFiOC8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125045|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:34:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:34:09 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-vckAvMNYsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125046|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:34:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:34:13 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-lmffQlJwIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125047|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:00 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-PjiJAbvzjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #54 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125165&action=edit
Bug 27947: Add authorised values list in article requests cancellation

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:06 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-we5yDhkUDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #55 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125166&action=edit
Bug 27947: [DO NOT PUSH] update ArticleRequest schema

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:13 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-Vh4CdyAcEL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125167&action=edit
Bug 27947: Add cancellation reason to article request

This bug adds a cancellation reason authorised values to article requests

To test:
1. apply this patch
2. updatedatabase
3. in staff interface go to /cgi-bin/koha/admin/authorised_values.pl
CHECK => AR_CANCELLATION category should appears
4. place several article requests
5. in staff interface go to /cgi-bin/koha/circ/article-requests.pl
6. select multiple requests, or just one and cancel them
SUCCESS => a modal pops up offering to select a cancellation reason
CHECK => message_queue table has messages with cancellation reason included
7. repeat steps 4 to 6 but for /cgi-bin/koha/circ/request-article.pl
8. cancelling article requests from opac interface should work just as before

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:18 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-bVt8uVOt1O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #57 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125168&action=edit
Bug 27947: (follow-up) Improve atomic update

We do not need to replace the whole notice text, we only need to
replace the reference to article_requests.notes.

Test plan:
Run the dbrev. Verify result for notice AR_CANCELED.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:23 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-9Dn3B2Uwxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125169&action=edit
Bug 27947: (follow-up) Add OPAC cancellation as new reason too

Something that currently comes up now already too:
If the user cancels from the OPAC page, there is no reason in the notice.
We could simply add one now.

Test plan:
Run dbrev to add the OPAC authval.
Create new AR and cancel it from OPAC.
Verify notice created for the user.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:30 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-MpLIFG9bUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #59 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125170&action=edit
Bug 27947: (QA follow-up) Refactor routes

This patch refactors the route specs a bit, and also reorganizes code
for easier tracking.

Unused exceptions that were added earlier are removed for now.

A follow-up patch will add tests to this routes.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:35 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-eszmYoclQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #60 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125171&action=edit
Bug 27947: Add regression tests for routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:36:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:36:43 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-mq8fuGOtay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125172&action=edit
Bug 27947: (QA follow-up) Remove incorrect permission check

The API was checking for 'reserverforothers' permission, but that
doesn't make sense to apply here.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:37:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:37:01 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-f6bF189n68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125173&action=edit
Bug 27947: (QA follow-up) Update test to highlight issue

This addition to the tests highlights a permissions/security check
error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:37:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:37:08 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-OC9KF4KzkN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125174&action=edit
Bug 27947: (QA follow-up) Clarify permissions

Privileged routes need permissions defined. This patch adds the minimum
required permission until there are article request-specific permissions
in Koha: circulate: circulate_remaining_permissions

It is also clarified that interacting with an article request  from
another patron, but having your own patron_id in the path would return
404 instead of 403, as technically the resource (an article request from
the patron, identified.by the supplied id) doesn't exist.

Tests are tweaked.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:48:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:48:48 +0000
Subject: [Koha-bugs] [Bug 29086] New: Reuse article request filtering
 methods in Biblio template plugin
Message-ID: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

            Bug ID: 29086
           Summary: Reuse article request filtering methods in Biblio
                    template plugin
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Introduced by bug 29082, and covered by tests, we should use those higher level
methods instead of crafting queries in-place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:49:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:49:06 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-USyHbawuy0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28684
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:49:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:49:06 +0000
Subject: [Koha-bugs] [Bug 28684] Superfluous -or condition in few article
 request queries
In-Reply-To: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28684-70-xBlTX3cRfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29086

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:55:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:55:55 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-T4w0AGw7TS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125175&action=edit
Bug 29086: Simplify querying active article requests

This patch makes a trivial replacement of a query for a higher level
method that does the same query.

To test:
1. Enable the ArticleRequests feature
2. Place some article requests on known biblios
3. Have some article requests be active on others finished (either
   completed or cancelled)
4. Go to the detail page for those records
=> SUCCESS: The active article requests count is correct!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:56:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:56:00 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-k6fopKKt95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125176&action=edit
Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses

I noticed a couple places in which this library was included but not
used.

To test:
1. Apply this patch
2. Run:
   $ git grep 'Koha::ArticleRequest::Status'
=> SUCCESS: There aren't any calls to their defined constants in
Biblio.pm or Patrons.pm
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:57:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:57:09 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-RQNA6LoZLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
         Depends on|                            |29084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084
[Bug 29084] Update article requests-related Koha::Biblio methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:57:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:57:09 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-6ycRtPapVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29086


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086
[Bug 29086] Reuse article request filtering methods in Biblio template plugin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 21:57:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 19:57:41 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-xPFSsi3pua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 22:14:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 20:14:46 +0000
Subject: [Koha-bugs] [Bug 18668] Add the column localuse to the items table
In-Reply-To: <bug-18668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18668-70-3Ms9TaMCwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18668

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

--- Comment #3 from Rebecca Coert <rcoert at arlingtonva.us> ---
+1, this would be very useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 23:16:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 21:16:14 +0000
Subject: [Koha-bugs] [Bug 29087] New: Holds to pull list can crash with a
 SQL::Abstract puke
Message-ID: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087

            Bug ID: 29087
           Summary: Holds to pull list can crash with a SQL::Abstract puke
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Opening the holds to pull list page can crash with the following logged error:

  SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before
v1.75 used to generate incorrect SQL when the -NOT IN operator was given an
undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming
Data::Query-based version of SQL::Abstract will emit the logically correct SQL
instead of raising this exception) at /usr/share/koha/lib/Koha/Objects.pm line
145

I've traced this to Koha::Holds->get_items_that_can_fill(). Among other things,
this routine fetches a list of item types that cannot fill holds, i.e., cases
where the 'holdallowed' rule value is 'not_allowed'.

However, if your default rule is to not allow holds, the
@hold_not_allowed_itypes list will end up including an entry whose value is
undef. When passed to the item query, doing the -not_in filter on itype will
result in the crash listed above.

A quick fix might be to filter out undef from that list. That will fix the
crash, but could lead to incorrect results if the default policy is to deny
holds for all item types except for ones that are going to be specifically
permitted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 22 23:29:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 21:29:02 +0000
Subject: [Koha-bugs] [Bug 29088] New: Warning when connection to memcached
 fails is too long
Message-ID: <bug-29088-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29088

            Bug ID: 29088
           Summary: Warning when connection to memcached fails is too long
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Actually when connection to memcached fails a warning is created :

    unless ($ismemcached) {
        warn "\nConnection to the memcached servers '@servers' failed. Are the
unix socket permissions set properly? Is the host reachable?\nIf you ignore
this warning, you will face performance issues\n";
        return $self;
    }

This will generate 2 lines plus one empty line.

It it shown even for CLI scripts.

During some system operations or bash scripts, we may shutdown memcached on
purpose.
In this case warning is annoying.

I propose we show a sorter text, and maybe a link to a wiki page.

We may choose to remove this warning for it can SPAM log files.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 00:55:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 22:55:15 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-tu14Tzp8mf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 00:55:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 22:55:23 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-LFkgxX24CM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124862|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 125177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125177&action=edit
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC

This patch makes modifications to OPAC templates to make the Google
login options more consistent.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- In the staff interface, enable the GoogleOpenIDConnect preference, and
  populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with
  values (they don't need to be valid).
- On the OPAC main page you should see a "Log in with Google" button
  above the Koha login form.
- If you click the "Log in to your account" link at the top of the page
  you should see a "Log in with Google" button in the modal window
- If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged
  in you should see the same "Log in with Google" button on that page.
- In each case the Google button should point to
/cgi-bin/koha/svc/auth/googleopenidconnect
- If you disable GoogleOpenIDConnect the buttons should disappear.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 00:57:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 22:57:01 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-0Ej4pOTdRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

--- Comment #5 from David Nind <david at davidnind.com> ---
(In reply to Owen Leonard from comment #3)
> You populated these preferences? 
> 
> GoogleOAuth2ClientID
> GoogleOAuth2ClientSecret
> 
> And turned this one on?
> 
> GoogleOpenIDConnect
> 
> Do you have any missing modules under About -> Perl modules?

All worked perfectly today! Must have been me not doing something
right..¯\_(ツ)_/¯

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 01:12:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 23:12:57 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-JPnHA44B5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
  Text to go in the|                            |This enhancement improves
      release notes|                            |the consistency of the OPAC
                   |                            |login forms when using
                   |                            |Google OpenID Connect. A
                   |                            |"Log in with Google" button
                   |                            |now appears above the Koha
                   |                            |login form when logging in
                   |                            |from the home page, "Log in
                   |                            |to your account" in the
                   |                            |navigation menu, and when
                   |                            |accessed directly
                   |                            |(/cgi-bin/koha/opac-user.pl
                   |                            |).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 01:43:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Sep 2021 23:43:40 +0000
Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a
 SQL::Abstract puke
In-Reply-To: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29087-70-vp6XzE0NQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 05:39:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 03:39:38 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-ILGLmBvhOo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Everything worked fine in the staff interface.

However, in the OPAC no items are shown for the patron (Your account > Your
summary > Article requests tab (has no number in (), and not items listed. This
may be one of the dependcies causing this...

Testing notes:
- remember to run updatedatabase (for other dependencies)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 08:02:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 06:02:06 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-sqa0FUMUNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #83 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Our old friend:
   FAIL   valid_template
                Attempt to reload Koha/Template/Plugin/Biblio.pm aborted.
Compilation failed in require at
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 08:21:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 06:21:24 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-wvJbPxtIBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125151|0                           |1
        is obsolete|                            |

--- Comment #79 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125178&action=edit
Bug 27945: Move atomicupdate to new format

It also removes the implicit dependency on bug 27946 by changing the
AFTER column.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 08:21:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 06:21:29 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-LLeagIpzQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125152|0                           |1
        is obsolete|                            |

--- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125179&action=edit
Bug 27945: (QA follow-up) Fix and move tests to proper file

Koha::Patron methods tests belong to the t/db_dependent/Koha/Patron.t
tests file.

This patch moves the tests, and also acknowledges the fact that we can
use Test::Exception instead of a try/catch block. It also fixes the
tests so they actually trigger the ->request method, which is the one
that raises the exception if the limit is reached.

At some point, because of the dependency mess, this bug ended up with
the exception throwing in the wrong method, and that's why tests were
also failing.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/ArticleRequests.t
=> FAIL: Patron.t passes, ArticleRequests.t doesn't
2. Apply this patch
3. Repeat 1
=> SUCCESS: Both pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 08:27:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 06:27:31 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-nRrCpgPA8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125180&action=edit
Screenshot mylibraryfirst

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 08:27:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 06:27:56 +0000
Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use
 Font Awesome icons
In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29066-70-SHJySkRkdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125181&action=edit
Screenshot librarypulldown

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 09:50:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 07:50:16 +0000
Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19814-70-g30arE0Z3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Anna <urstanlib at urs.edu.ph> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |urstanlib at urs.edu.ph

--- Comment #23 from Anna <urstanlib at urs.edu.ph> ---
(In reply to Björn Nylén from comment #17)
> I was envisioning a checkin process that would support a batch of book
> placed on an rfid pad. The checkins would be processed asynchonously via
> ajax calls. That way you could process books without waiting for pageloads
> etc. We're handling quite a lot of stack requests that need a checkin before
> being svailable for patrons. Being able to process them by just passing them
> over the rfid pad without more interaction would be a time saver.

I agree on this one. Batch check-in of books on RFID pad would save time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 09:57:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 07:57:27 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-cIrbWwmmuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please specify on top of which bug this should be placed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 09:59:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 07:59:24 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-OM8udMRCWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 10:32:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 08:32:41 +0000
Subject: [Koha-bugs] [Bug 29089] New: When placing a hold,
 delivery by mail / in house delivery should be an option
Message-ID: <bug-29089-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29089

            Bug ID: 29089
           Summary: When placing a hold, delivery by mail / in house
                    delivery should be an option
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

For some libraries it's a common service to offer delivery by mail or in house
delivery to their patrons.

When placing a hold it's only possible to set a branch as a pick-up location.
It would be great if there was also an option to pick up alternative delivery
options like "Mail" or "Office". 

It would be nice if the list was configurable, but having a "Mail" option would
already be quite helpful.

Using the hold notes is a little difficult as they don't allow for a list of
options and are also often used internally, so should not be made visible to
the patron in the OPAC.

I'd also be interested if anyone has a good workaround for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 11:08:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 09:08:14 +0000
Subject: [Koha-bugs] [Bug 29090] New: Patron card creator has a bug when
 generating batches
Message-ID: <bug-29090-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29090

            Bug ID: 29090
           Summary: Patron card creator has a bug when generating batches
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: eliza.allison64 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 125182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125182&action=edit
screenshot of patron library cards

When creating a new batch of patron library cards, underneath the barcode,
there is a line obstructing the card number saying "HASH(0X55d6.....)". I'm not
sure how to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 11:33:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 09:33:14 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-zUHG2JRLa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Agustín Moyano from comment #8)
> Hi Marcel, the following code worked for me
> 
> hr {
>     page-break-after: always;
>     border: 0px solid black !important;
> }
> 
> First times did not work, but I believe it was browser's cache or memcached
> 
> Could you try again, please?

It works for me now. Not sure what changed. Anyway, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 11:39:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 09:39:09 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-cQQEnX8qir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 11:39:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 09:39:12 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-onyV3RoBKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121608|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125183&action=edit
Bug 27949: Allow multiple article requests print slip

This bug allows for batch printing of multiple article requests slips

To test:
1. apply this patch
2. restart_all
3. enable ArticleRequests preference
4. create multiple article requests
5. go to circ/article-requests.pl in staff interface
6. print a single slip from a row
CHECK => it works as expected
7. select all rows and print slip from general actions menu (above the table)
SUCCESS => all article requests slips are printed
8. select multiple rows (not all) and print slip from general actions menu
(above the table)
SUCCESS => only selected article requests slips are printed

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 12:44:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 10:44:44 +0000
Subject: [Koha-bugs] [Bug 29079] Make biblio info in holds queue customizable
In-Reply-To: <bug-29079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29079-70-3E5jbkKxae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Biblio info info Holds      |Make biblio info in holds
                   |Queue needs to be able to   |queue customizable
                   |be customized               |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 12:49:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 10:49:54 +0000
Subject: [Koha-bugs] [Bug 29090] Patron card creator has a bug when
 generating batches
In-Reply-To: <bug-29090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29090-70-9qYnf4VoCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29090

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Could you tell us what fields are in the layout you're using to print the
cards?

Tools -> Patron card creator -> Layouts -> Edit

Or a screenshot of the form?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:23:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:23:30 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-Q5yqgzEr4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #3)
> Please specify on top of which bug this should be placed.

No particular dependency, it is a standalone dev, self-contained.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:24:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:24:31 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-2DVVmciKXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #3)
> Everything worked fine in the staff interface.
> 
> However, in the OPAC no items are shown for the patron (Your account > Your
> summary > Article requests tab (has no number in (), and not items listed.
> This may be one of the dependcies causing this...
> 
> Testing notes:
> - remember to run updatedatabase (for other dependencies)

Thanks for testing! Will check it ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:36:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:36:16 +0000
Subject: [Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be
 more accessible
In-Reply-To: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28101-70-gPhUJyO7Kt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:36:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:36:19 +0000
Subject: [Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be
 more accessible
In-Reply-To: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28101-70-d42SF7Nr8f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119933|0                           |1
        is obsolete|                            |
 Attachment #119934|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125184&action=edit
Bug 28101: changed styling for breadcrumbs

Updates opac.scss file so the breadcrumbs will appear the same as Bug
27846 (Staff Client breadcrumbs).

This works but the file may need to be changed/cleaned up so that there
is not unnecessary information in it.

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:36:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:36:22 +0000
Subject: [Koha-bugs] [Bug 28101] Accessibility: OPAC - Breadcrumbs should be
 more accessible
In-Reply-To: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28101-70-dgqvwnmVIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28101

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125185&action=edit
Bug 28101: Update breadcrumb markup in the OPAC for consistency and
accessibility

Modified breadcrumbs to be accessible, in particular for a
screen-reader. Also ensured the breadcrumbs were all consistent.

Made the block of breadcrumbs to be a <nav id="breadcrumbs"
aria-label="Breadcrumb" class="breadcrumbs"> with an ordered list
inside. The last breadcrumb also has aria-current="page" to specify that
it is the current page.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Confirm that OPAC templates are updated consistently to use
  breadcrumbs markup beginning with '<nav
  id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">'
- Pages in the OPAC should look consistent, with the last breadcrumb
  styled as text and with the "aria-current" attribute "page."

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:37:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:37:55 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-KhtpUTQ8wN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #4)
> (In reply to Marcel de Rooy from comment #3)
> > Please specify on top of which bug this should be placed.
> 
> No particular dependency, it is a standalone dev, self-contained.

Sure? I thought I saw a new status somewhere ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:38:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:38:11 +0000
Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set
 'datereturned' when --mark-returned option is used.
In-Reply-To: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17996-70-wlSwPdQBNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm not sure about this patch. If I manually mark an item lost while I have
MarkLostItemsAsReturned on, that *also* sets the returndate. And I'm not sure
that's wrong? After all, we've elected to mark it as returned.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:53:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:53:39 +0000
Subject: [Koha-bugs] [Bug 29091] New: Correct display of lists and tags on
 search results
Message-ID: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

            Bug ID: 29091
           Summary: Correct display of lists and tags on search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The list of tags and lists on the OPAC search results page inherits margins and
padding that isn't correct for this area. A small change to the SCSS will
correct it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 13:55:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 11:55:33 +0000
Subject: [Koha-bugs] [Bug 29092] New: Table Settings for account_fines table
 missing Updated On column and hide the wrong things
Message-ID: <bug-29092-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29092

            Bug ID: 29092
           Summary: Table Settings for account_fines table missing Updated
                    On column and hide the wrong things
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Table settings for the account_fines table (in the Patrons section, the
"Transactions" table in a patron account) are missing a checkbox for the
"Updated On" column. Because of this, one cannot hide the Updated On column and
any other values one sets here get applied to the wrong columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:12:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:12:09 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-cC8wmJq2Xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|27945                       |27947


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
[Bug 27947] Add default cancellation reasons to article requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:12:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:12:09 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-0krEH1zqlU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|29083                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:12:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:12:09 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-lDD8k9CwxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:12:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:12:58 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-KaIbrFEi7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125186&action=edit
Bug 29083: Fix OPAC listing of article requests

This patch makes the OPAC template reuse a precalculated value for the
active article requests for the patron (and its count).

The original code relied on the methods returning a list, which is not
the case for _new_from_dbic until bug 28883 is pushed.

This patch fixes that.

Note: there was an odd behavior when ArticleRequests was enabled but no
active article requests were present: the tab wasn't rendered but the
'empty table' with the 'You have no article requests currently.' message
was displayed below the Checkouts tab. I'm not sure that was caused by
this patches, or other. Fixed on this patch.

To test:
1. In the OPAC, go to 'your summary'
=> FAIL: Things don't show for article requests
2. Add some article requests and repeat 1
=> FAIL: Something's wrong there
3. Apply this patch and repeat 1
=> Yes! Things show correctly!
4. Cancel all your article requests
=> SUCCESS: Things render as they should
5. Re-enter the 'your summary' page (to force re-rendering)
=> SUCCESS: Things render correctly for empty article requests
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:13:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:13:46 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-DeebeIa787@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125187&action=edit
Screenshot showing the display problem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:15:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:15:58 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-hFr9mbOx1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:16:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:16:01 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-7vQM12VWu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125188&action=edit
Bug 29091: Correct display of lists and tags on search results

This patch makes a minor change to CSS to fix the display of tags and
lists on the OPAC search results page so that the list doesn't have
extra padding.

To test, apply the patch and rebuild the OPAC SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- To test you should be able to perform a catalog search in the OPAC
  which will return results which have one or more tags and which are on
  one or more lists.
- In the OPAC search results, confirm that there isn't extra padding
  between the "Tags:" and "Lists:" labels and their values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:17:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:17:32 +0000
Subject: [Koha-bugs] [Bug 29093] New: Article requests: Checkbox for table
 of contents
Message-ID: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

            Bug ID: 29093
           Summary: Article requests: Checkbox for table of contents
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If you allow copying or scanning parts of books, a very common question is: I
would like to receive a copy/scan of the table of contents.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:20:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:20:19 +0000
Subject: [Koha-bugs] [Bug 29094] New: Placing holds via SIP2 does not check
 if a patron can hold the given item
Message-ID: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

            Bug ID: 29094
           Summary: Placing holds via SIP2 does not check if a patron can
                    hold the given item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When placing holds via SIP2, there is no holdability check. This seems very
incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:28:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:28:53 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-bshjUOIf5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27947

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Tomás Cohen Arazi from comment #4)
> > (In reply to Marcel de Rooy from comment #3)
> > > Please specify on top of which bug this should be placed.
> > 
> > No particular dependency, it is a standalone dev, self-contained.
> 
> Sure? I thought I saw a new status somewhere ;)

Right


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
[Bug 27947] Add default cancellation reasons to article requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:28:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:28:53 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-JIozY4CKj0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29082


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082
[Bug 29082] Add filtering methods to Koha::ArticleRequests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:30:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:30:02 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-p9UiAasCux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125082|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 14:56:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 12:56:51 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-dT00vkjspS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:07:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:07:01 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-eTKAFXsXQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:07:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:07:04 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-jCDCnIqSXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125189&action=edit
Bug 29094: Adding hold via SIP should check if patron can hold item first

When placing holds via SIP2, there is no holdability check. This seems very
incorrect.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:37:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:37:12 +0000
Subject: [Koha-bugs] [Bug 29095] New: Add re-usable item-status include
Message-ID: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

            Bug ID: 29095
           Summary: Add re-usable item-status include
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We display item status's in a few places, and already have an item-status
include file to share this display logic around in the OPAC.

We should do the same in the staff client, this would lead to simplified logic
in the catalogue/detail controller and DRYer code in future developments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:37:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:37:26 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-B54m6ter58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:39:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:39:32 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pWz0ThKGjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29095


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095
[Bug 29095] Add re-usable item-status include
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:39:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:39:32 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-tMymqa828k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:41:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:41:30 +0000
Subject: [Koha-bugs] [Bug 29096] New: Removing a lost status via item edit
 refunds lost fee without reinstating overdue fine
Message-ID: <bug-29096-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29096

            Bug ID: 29096
           Summary: Removing a lost status via item edit refunds lost fee
                    without reinstating overdue fine
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23091

To recreate:
- Set WhenLostChargeReplacementFee ON, WhenLostForgiveFine ON
- Set you refund lost item value to EITHER refund lost fee and charge a new
overdue fine OR refund lost fee and restore overdue fine
- check an item out with a due date in the past, run the fines cron
- mark the item lost, confirm the overdue fine is forgiven and a lost fee is
applied
- edit the item to remove the lost status
- confirm the lost status is refunded but the overdue fine hasn't returned

We're removing the lost fee on the assumption that we've found the item and
therefore the patron doesn't owe us the replacement anymore. That assumption
should also result in restoring/re-charging the overdue fine.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091
[Bug 23091] Add options to charge new or restore forgiven overdues when a lost
item is returned
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:41:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:41:30 +0000
Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore
 forgiven overdues when a lost item is returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-CfnGBV99D1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29096


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29096
[Bug 29096] Removing a lost status via item edit refunds lost fee without
reinstating overdue fine
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:44:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:44:48 +0000
Subject: [Koha-bugs] [Bug 29097] New: Overdue fines for lost items
 reinstated even when item returned on Fine Free mode
Message-ID: <bug-29097-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29097

            Bug ID: 29097
           Summary: Overdue fines for lost items reinstated even when item
                    returned on Fine Free mode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23091

To recreate:
- Set WhenLostChargeReplacementFee ON, WhenLostForgiveFine ON
- Set you refund lost item value to EITHER refund lost fee and charge a new
overdue fine OR refund lost fee and restore overdue fine
- check an item out with a due date in the past, run the fines cron
- mark the item lost, confirm the overdue fine is forgiven and a lost fee is
applied
- set checkin to Fine Free mode and check the item in
- confirm your lost fee is gone and your overdue is back

If the item is checked in on Fine Free mode, the fine should not come back. Or
at least that should be a configurable option via a syspref. We have libraries
set Fine Free on for all checkouts for amnesty periods. This sort of return of
long-lost items is exactly what they're trying to incentivize with such a
program.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091
[Bug 23091] Add options to charge new or restore forgiven overdues when a lost
item is returned
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:44:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:44:48 +0000
Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore
 forgiven overdues when a lost item is returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-VE7cdhim4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29097
[Bug 29097] Overdue fines for lost items reinstated even when item returned on
Fine Free mode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:48:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:48:41 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-HEQdydmnNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:49:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:49:13 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-qghe9j5oTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch set adds a new
      release notes|                            |article request column for
                   |                            |a request to copy or scan
                   |                            |table of contents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:49:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:49:22 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-TmQlUbbhOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:50:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:50:38 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-Bcs5bi8NeO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:51:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:51:01 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-TaDhj2ZkgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:51:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:51:06 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-cXNhiF61Bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125190&action=edit
Bug 29093: Database revision for article_requests.toc_request

Test plan:
Run dbrev or new install.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:51:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:51:10 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-l3TUQzS4f4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125191&action=edit
Bug 29093: {DO NOT PUSH] DBIx schema changes

Note: Pending table changes in PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 15:51:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 13:51:15 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-TuMyU2qcwN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125192&action=edit
Bug 29093: Interface changes

Show the TOC checkbox on OPAC and staff.

Test plan:
Add new article request on OPAC or staff. Tick checkbox.
Verify if TOC is Yes on opac-user or staff patron details.
Check the list view on circ/article-requests.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:03:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:03:47 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-VJUnyAwN7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please look for another report where one was suggested to introduce.
Quite recently.
FQA probably

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:09:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:09:28 +0000
Subject: [Koha-bugs] [Bug 28952] Item Checkout History fails
In-Reply-To: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28952-70-oPhZm1cYO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28952

--- Comment #3 from beardst at rlasd.net ---
That fixed it for us. Thanks for the patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:22:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:22:00 +0000
Subject: [Koha-bugs] [Bug 29098] New: Double confirm running resource
 intensive Overdues report
Message-ID: <bug-29098-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29098

            Bug ID: 29098
           Summary: Double confirm running resource intensive Overdues
                    report
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Very large libraries still have the option to run the resource intensive
overdues.pl with no filters, even when the syspref is on to require filters
before running it. I propose a confirmation message to ensure users know that
the thing they are requesting is very resource intensive and may not complete,
as we don't want to take away the functionality but I do think people should
really be sure they know what they are doing when they click through with no
filters on this page.

Other solutions to this problem welcome - my requirements are
- the option to run the full report should still be available, as it is now
- users should be duly warned and forced to confirm that they really want to do
this when the no-filter case is requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:23:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:23:14 +0000
Subject: [Koha-bugs] [Bug 29098] Double confirm running resource intensive
 Overdues report
In-Reply-To: <bug-29098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29098-70-UPyobNZ8MG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29098

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:34:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:34:29 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-dHDVSS1JK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This might be hard to find another occurrence.
But look at this code in SendCirculationAlert

    my $issues_table = ( $type eq 'CHECKOUT' || $type eq 'RENEWAL' ) ? 'issues'
: 'old_issues';
[etc]
            tables => {
                $issues_table => $item->{itemnumber},

This should no longer work.

How do you know if there no other occurrences like that one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:06 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-AWQ5y3dWfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125193&action=edit
Bug 28854: Database update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:09 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-PfM5z7ytX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125194&action=edit
Bug 28854: DBIC Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:13 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-TdzV2mII1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125195&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point
1) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
2) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
3) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.

TODO: Add Object Tests + API Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:17 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-n8vkNB155l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125196&action=edit
Bug 28854: Add bundle content display to OPAC

TODO: Switch to /public api route
TODO: Move expand button to right like staff client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:20 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-CH5ZukBi3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125197&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:24 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-f9wvoUOUBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125198&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that the patron who
   lost the item is displayed
4) Checkin the lost item
   * The item should be marked as found and the items_lost_issue table
     should no longer contain a link to the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:28 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dYPmEUKK0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|29095                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095
[Bug 29095] Add re-usable item-status include
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:28 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-utdWe4zXZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28854                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:29 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-E0bjD4ew8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125199&action=edit
Bug 28854: Respect WhenLostChargeReplacementFee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:37 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-yWotd33d60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29095

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:39:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:39:37 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-a7lQRfkCKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28854

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:14 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-NJ3QxFho9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125200&action=edit
Bug 28854: Database update

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:19 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pYYEpNcYK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125201&action=edit
Bug 28854: DBIC Schema Updates

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:24 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Ta16FTv4rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125202&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point
1) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
2) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
3) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.

TODO: Add Object Tests + API Tests

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:28 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-PkA8h94bYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125203&action=edit
Bug 28854: Add bundle content display to OPAC

TODO: Switch to /public api route
TODO: Move expand button to right like staff client

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:35 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-09UVMMXtzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125204&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:37 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-B5t7ehfrIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125194|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:42 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KW4WoAJFPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125205&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that the patron who
   lost the item is displayed
4) Checkin the lost item
   * The item should be marked as found and the items_lost_issue table
     should no longer contain a link to the issue

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:48 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-H0TcMesdUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125193|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:40:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:40:47 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-P4CV7VB7UM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125206&action=edit
Bug 28854: Respect WhenLostChargeReplacementFee

https://bugs.koha-community.org/show_bug.cgi?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:41:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:41:09 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-w4kjgaw7M0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125195|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:41:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:41:18 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-pgKvsc1d52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125196|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:41:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:41:30 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-pDCQM4h1dC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125197|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:41:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:41:40 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-D1TVf6dFyD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125198|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:41:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:41:49 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-iekrH1dzWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125199|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:42:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:42:07 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-cU7sMJHQ8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124616|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:47:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:47:55 +0000
Subject: [Koha-bugs] [Bug 29099] New: Add support for item bundles in the
 inventory tool
Message-ID: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099

            Bug ID: 29099
           Summary: Add support for item bundles in the inventory tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I chose to split out the inventory tool additions from the bundles bug.. that
bug was already big enough ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:48:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:48:07 +0000
Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the
 inventory tool
In-Reply-To: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29099-70-2kRBVjj0QT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:48:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:48:07 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-N70mbM4p99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29099


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099
[Bug 29099] Add support for item bundles in the inventory tool
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:48:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:48:13 +0000
Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the
 inventory tool
In-Reply-To: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29099-70-dt96611iIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 16:51:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 14:51:46 +0000
Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the
 inventory tool
In-Reply-To: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29099-70-YiYeEW0W6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125207&action=edit
Bug 29099: Add bundle support to inventory tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 17:33:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 15:33:24 +0000
Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted
 purchase suggestions
In-Reply-To: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27595-70-bvO1h0Gerf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> ---
+1

This would be a fantastic and much needed feature!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 17:35:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 15:35:00 +0000
Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted
 purchase suggestions
In-Reply-To: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27595-70-Kh1tvk7o7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

Mwoo <mary.woodward at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mary.woodward at bedfordtx.gov

--- Comment #5 from Mwoo <mary.woodward at bedfordtx.gov> ---
Patrons ask us about this all the time. 
This would be an awesome feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 17:36:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 15:36:01 +0000
Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted
 purchase suggestions
In-Reply-To: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27595-70-sJv46DCGp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

--- Comment #6 from Ashley Johnson <ajohnson at jcls.org> ---
Our Collection Development team processes hundreds of patron suggestions each
month. This feature would be highly important to our library system. Please
develop this feature!!!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 17:42:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 15:42:03 +0000
Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted
 purchase suggestions
In-Reply-To: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27595-70-nVvaqVjRvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #7 from George Williams (NEKLS) <george at nekls.org> ---
This would be a great feature to add to Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:01:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:01:36 +0000
Subject: [Koha-bugs] [Bug 26649] Authorized Value suggest_status doesn't
 respect branch limitation
In-Reply-To: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26649-70-Y03F6BH6eW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #1 from George Williams (NEKLS) <george at nekls.org> ---
It would be nice if this was fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:02:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:02:08 +0000
Subject: [Koha-bugs] [Bug 26649] Authorized Value suggest_status doesn't
 respect branch limitation
In-Reply-To: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26649-70-YRuImMnH6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
+1  Please fix!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:02:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:02:46 +0000
Subject: [Koha-bugs] [Bug 26649] Authorized Value suggest_status doesn't
 respect branch limitation
In-Reply-To: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26649-70-nh7fpSOpxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:03:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:03:29 +0000
Subject: [Koha-bugs] [Bug 23819] Allow status to be set during creation of a
 purchase suggestion
In-Reply-To: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23819-70-YzHg06Dabl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23819

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:03:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:03:46 +0000
Subject: [Koha-bugs] [Bug 23819] Allow status to be set during creation of a
 purchase suggestion
In-Reply-To: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23819-70-iiwHP6yaKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23819

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
+1 This would be EXTREMELY helpful!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:04:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:04:32 +0000
Subject: [Koha-bugs] [Bug 23819] Allow status to be set during creation of a
 purchase suggestion
In-Reply-To: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23819-70-uNFP2n1UwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23819

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #2 from George Williams (NEKLS) <george at nekls.org> ---
This would be another good thing to fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:16:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:16:03 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-Dy44Qwn9kg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:16:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:16:08 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-yme4p4gLtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 125208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125208&action=edit
Bug 28977 - Add GROUP_CONCAT to some of the selected columns

To get the 'Most circulated items' report to run in ONLY_FULL_GROUP_BY
Sql mode.

Test plan:

Turn on strict_sql_modes ( make sure <strict_sql_modes> is 1 in KOHA_CONF )
Go to Reports -> Most circulated items
submit the form.

Without the patch you get an error like:
CGI::Compile::ROOT::usr_local_koha_master_reports_cat_issues_top_2epl::calculate():
DBI Exception: DBD::mysql::st execute failed: Expression #4 of SELECT list is
not in GROUP BY clause and contains nonaggregated column
'koha_main_v4.items.itemcallnumber' which is not functionally dependent on
columns in GROUP BY clause; this is incompatible with
sql_mode=only_full_group_by [for Statement "SELECT DISTINCT biblio.title,
COUNT(biblio.biblionumber) AS `RANK`, biblio.biblionumber AS ID, itemcallnumber
as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues`
                  LEFT JOIN items USING(itemnumber)
                  LEFT JOIN biblio USING(biblionumber)
                  LEFT JOIN biblioitems USING(biblionumber)
                  LEFT JOIN borrowers USING(borrowernumber)
                  WHERE 1 AND old_issues.issuedate > '2020-08-03' AND
old_issues.issuedate < '2021-05-17' AND old_issues.returndate > '2020-08-27'
AND old_issues.returndate < '2021-06-01' AND old_issues.branchcode like '403'
AND items.itype like 'F' AND ccode like 'FIC' AND borrowers.categorycode like
'ST' group by biblio.biblionumber order by `RANK` DESC"] at
/usr/local/koha_master/reports/cat_issues_top.pl line 67
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

With the patch you will see the report results view.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:19:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:19:16 +0000
Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl)
 is failing with SQL Mode ONLY_FULL_GROUP_BY
In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28977-70-x8sVMCoy5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977

--- Comment #7 from David Nind <david at davidnind.com> ---
Testing notes (koha-testing-docker):
- tested on environments available by starting KTD with ku, ku-mdb, ku-md9,
ku-md10, ky-my8
- check out and check in an item (so that there was some data for the report)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:21:39 +0000
Subject: [Koha-bugs] [Bug 28867] Use Bootstrap button menu and modal for
 adding patrons to lists
In-Reply-To: <bug-28867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28867-70-kIeA17QU8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27725


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725
[Bug 27725] Use JavaScript to set history state during patron search
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:21:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:21:39 +0000
Subject: [Koha-bugs] [Bug 27725] Use JavaScript to set history state during
 patron search
In-Reply-To: <bug-27725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27725-70-8cBnwebSR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28867


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867
[Bug 28867] Use Bootstrap button menu and modal for adding patrons to lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:27:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:27:43 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 sort fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-Rf5GsnFs0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124759|0                           |1
        is obsolete|                            |

--- Comment #13 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125209&action=edit
Bug 24720: Strip special chars from sort fields

Strip all non alphanumerical characters from beginning
of sort field values so that sorting is performed on
the first alphanumeric character and not special characters
like "-" or "[".

To test:

1. Prepend "[" to the title of a biblio and save
2. Perform a search that matches this biblio and at least one
   more biblio.
3. Sort alphabetically a-z.
4. The biblio with "[" should appear first
5. Apply the patch
6. Perform a full reindexing
7. Perform steps 2-3 again
8. The result should now be alphabetically sorted,
   ignoring the initial bracket in the title.
9. Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:27:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:27:47 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 sort fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-MQEDP0Hqtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124760|0                           |1
        is obsolete|                            |

--- Comment #14 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125210&action=edit
Bug 24720: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:27:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:27:59 +0000
Subject: [Koha-bugs] [Bug 24720] Remove special characters from beginning of
 sort fields
In-Reply-To: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24720-70-3cLoHG4LsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24720

--- Comment #15 from David Gustafsson <glasklas at gmail.com> ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:38:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:38:51 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-a4tQNU5Eoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116408|0                           |1
        is obsolete|                            |

--- Comment #42 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125211&action=edit
Bug 20551: Add option for including deleted records in export_records.pl

Add option "--include_deleted" to include deleted
biblios in export_records.pl as marc records with
record status (in leader) set to "d" and
"--deleted_only" to export only deleted biblios.

How to test:
1) Run tests in t/db_dependent/Exporter/Record.t
2) All tests should pass
3) Delete a biblio record in Koha
4) Run the export script as:
   `export_records.pl --date=<date-just-before-deletion>
   --include_deleted`
5) Open the generated koha.mrc, and verify that contains
   the recently deleted record, and that the record header
   has record status "d".
6) Perform the same check with:
   `export_records.pl --date=<date-just-before-deletion>
      --include_deleted --format=xml`
7) Run:
   `export_records.pl --date=<date-just-before-deletion>
      --deleted_only --format=xml`
    and verify that only the deleted biblio was included
    in the export.

Sponsored-by: Gothenburg University Library

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:38:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:38:55 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-qUGygezQOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116409|0                           |1
        is obsolete|                            |

--- Comment #43 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125212&action=edit
Bug 20551: Fix option name in pod

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:39:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:39:00 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-z6IhSglHrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116410|0                           |1
        is obsolete|                            |

--- Comment #44 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125213&action=edit
Bug 20551: Rename "marcflavour" field to "schema"

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:39:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:39:05 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-cm1lDFk1ag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116411|0                           |1
        is obsolete|                            |

--- Comment #45 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125214&action=edit
Bug 20551: Improve documentation and make compatible with more options

Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:39:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:39:13 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-uoZgk9rs9X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123101|0                           |1
        is obsolete|                            |

--- Comment #46 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125215&action=edit
Bug 20551: Add missing subroutine import

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:39:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:39:19 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-VuMQpsDsRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123102|0                           |1
        is obsolete|                            |

--- Comment #47 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125216&action=edit
Bug 20551: Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 18:45:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 16:45:08 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-1zlHKVje4J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

--- Comment #48 from David Gustafsson <glasklas at gmail.com> ---
Rebase against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:08:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:08:51 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-oaSV6RxCHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28762

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:08:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:08:51 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-wmxUHMdYVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29095

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:09:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:09:06 +0000
Subject: [Koha-bugs] [Bug 29095] Add re-usable item-status include
In-Reply-To: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29095-70-q9Dk6z5xNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 28762 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:09:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:09:06 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-36nSICz3Lt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 29095 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:18:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:18:03 +0000
Subject: [Koha-bugs] [Bug 29100] New: Add checkouts data loop to predue
 notices script ( advance_notices.pl )
Message-ID: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

            Bug ID: 29100
           Summary: Add checkouts data loop to predue notices script (
                    advance_notices.pl )
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Predue / due notices are limited to using itemscontent to display checkouts
data. It would be nice to make all the checkouts data available for those
notices so that libraries could format that data more nicely if they wish.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:18:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:18:09 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-wByTaq6J4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:37:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:37:50 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-KcllNVwgaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:37:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:37:53 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-L1ejtXUk6d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125217&action=edit
Bug 29100: Add checkouts data loop to predue notices script (
advance_notices.pl )

Predue / due notices are limited to using itemscontent to display checkouts
data. It would be nice to make all the checkouts data available for those
notices so that libraries could format that data more nicely if they wish.

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
Title: [% issue.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
Titles:
[% FOREACH i IN issues %]
* [% i.title %]
[% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:42:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:42:23 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-o4McaSuMFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125218&action=edit
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 19:47:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 17:47:05 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-KbTBXTTBhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125218|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125219&action=edit
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 20:03:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 18:03:55 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-kK9lcOylLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, this certainly needs some work.. if we're going to introduce an
'item-status' include here I feel it should really be re-usable and
simple/clear.

For that to be the case we should really be expecting a simple 'item' object to
be passed and not deal with special cases for weird structures.

I propose updating the minimal controller to use Koha:: Objects instead of C4::
classes and methods for these item details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 20:08:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 18:08:26 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-DR9dQUCyIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125220&action=edit
Bug 28762: Use Koha::Course in course-details controller

This patch updates Koha::Course to include the 'instructors' relation
accessor and then update the course-details controller to use the
Koha::Course object and pass it to the template instead of building a
hash using GetCourse.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 20:10:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 18:10:06 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-aZSfDwDtGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
My follow-up should allow us to switch out the `isa` in the template include
now I believe.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 21:39:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 19:39:46 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-ttcTpL1QWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 21:39:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 19:39:50 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-mSAjSlPvi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124419|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125221&action=edit
Bug 28919: Select logged in library as pickup for multi holds

When placing multiple holds from the result list, the pick-up location
is empty now, which makes it a more tedious process than it needs to be.

Logged in library must be selected to match the single hold logic.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 21:51:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 19:51:33 +0000
Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice
In-Reply-To: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8838-70-WY8aLBrr0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 21:52:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 19:52:42 +0000
Subject: [Koha-bugs] [Bug 28863] Cancel a Pending Notice
In-Reply-To: <bug-28863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28863-70-vJ4FrO2Luc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrobb at sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 21:55:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 19:55:21 +0000
Subject: [Koha-bugs] [Bug 28863] Cancel a Pending Notice
In-Reply-To: <bug-28863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28863-70-T8iaj9Vu0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28863

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:02:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:02:02 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
 notice templates
In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27208-70-7pWxX9DIDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:04:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:04:38 +0000
Subject: [Koha-bugs] [Bug 7972] GUI for Crons
In-Reply-To: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7972-70-e1V1rc5LIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:08:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:08:38 +0000
Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses
In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12802-70-YUhRMx61V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #103 from Fridolin Somers <fridolin.somers at biblibre.com> ---
With this feature there is actually an exception thows by Koha/Email.pm :
    Koha::Exceptions::BadParameter->throw("Invalid 'to' parameter:
".$args->{to})
        unless Email::Valid->address($args->{to}); # to is mandatory

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:09:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:09:45 +0000
Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses
In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12802-70-kgKLw4sy68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22343

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:09:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:09:45 +0000
Subject: [Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
In-Reply-To: <bug-22343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22343-70-zRUe4vRncq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12802

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:13:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:13:42 +0000
Subject: [Koha-bugs] [Bug 29101] New: unable to enter 020 and 024 tag fields
 other than blank
Message-ID: <bug-29101-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29101

            Bug ID: 29101
           Summary: unable to enter 020 and 024 tag fields other than
                    blank
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: courtenay.johnson at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 125222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125222&action=edit
Framework with problem, used for audio

KOHA version 18.11, Ubuntu 20.04.3

Home/cataloging/editing

When cataloging a new audio item I get an error if the line for tag 20 or 24
are not blank. I am using a framework for audio items. When I used a framework
for books earlier I did not encounter this problem even though I did enter a 13
digit ISBN for that title.

Tag "20" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2517.
Tag "24" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2517.

I can't have any number in the input field for 20 ISBN 13, or 24 for a 12 or 13
bit UPC or EAN. If both are blank then the save works. A subsequent edit also
fails to save if either of these tag input fields are not blank.

Today I used 2 other frameworks, 1 for books and 1 for DVD/Video and I had no
problem entering an ISBN value. 

I have exported the 2 different frameworks and can't see any differences for
these tags.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:39:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:39:12 +0000
Subject: [Koha-bugs] [Bug 29102] New: DecreaseLoanHighHolds will decrease
 lona period if borrower has an 'unfound' hold
Message-ID: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

            Bug ID: 29102
           Summary: DecreaseLoanHighHolds will decrease lona period if
                    borrower has an 'unfound' hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Similar to bug 25566

If a patron has a hold on a record and there are other holds
 -the hold is not found
 -the rules limit to 1 hold per record
 -no items will be holdable (already have the hone hold)
 -Loan will be decreased if using decreaseLoanHighHoldsControl  - 'over the
number of holdable items'/dynamic

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 22:39:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 20:39:30 +0000
Subject: [Koha-bugs] [Bug 7972] GUI for Crons
In-Reply-To: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7972-70-VMCBcCPsN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

Rebecca Coert <rcoert at arlingtonva.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcoert at arlingtonva.us

--- Comment #12 from Rebecca Coert <rcoert at arlingtonva.us> ---
It would be very helpful to have this feature - both the scheduling ability and
the cron status view.  This would be very useful if we need to adjust our
settings quickly for some reason.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:15:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:15:11 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-jPp09Vy1fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:18:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:18:39 +0000
Subject: [Koha-bugs] [Bug 29103] New: reserves.desk_id for desk of waiting
 hold only updates when printing new hold sip
Message-ID: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

            Bug ID: 29103
           Summary: reserves.desk_id for desk of waiting hold only updates
                    when printing new hold sip
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 24412

To recreate:
- turn on UseCirculationDesks and define at least 2 for your library
- set yourself to a desk using "Set library and desk"
- place a hold for pickup at your library
- check the item in, confirm the hold and print slip
- check reserves.desk_id, see it has updated to the desk you're at
- change your desk
- check the item in again, click Confirm
- check reserves.desk_id, see it has not changed
- check the item in a third again, click Confirm and Print Slip
- check reserves.desk_id again, see it has changed


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
[Bug 24412] Attach waiting hold to desk
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:18:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:18:39 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting hold to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-mmEVohwsbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29103


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103
[Bug 29103] reserves.desk_id for desk of waiting hold only updates when
printing new hold sip
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:18:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:18:49 +0000
Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold
 only updates when printing new hold slip
In-Reply-To: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29103-70-Ud9Q7thorv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|reserves.desk_id for desk   |reserves.desk_id for desk
                   |of waiting hold only        |of waiting hold only
                   |updates when printing new   |updates when printing new
                   |hold sip                    |hold slip

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:35:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:35:51 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-6hKKtlrmuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:35:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:35:54 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-fskjQDKZ0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125223&action=edit
Bug 29019: Unable to delete HTML customization

This patch makes some corrections to additional contents to allow
content to be deleted. The wrong parameter was being passed to the
script. The script was also not handling multiple deletions correctly.

The patch also adds a "category" parameter to the delete operation so
that the page is redirected correctly.

The patch also changes some strings which referred to "news"
referencing operations which might be performed on news or on HTML
customizations, e.g.:

"Are you sure you want to delete the selected content?" instead of "Are
you sure you want to delete the selected news?"

To test, apply the patch and go to Tools -> News.

- Create multiple news items if necessary.
- Test the "Delete" button corresponding to a single news item:
  - Clicking the button should ask you to confirm.
  - Check that the wording of the message is correct.
  - After confirming the news item should be deleted.
  - Ideally, test on news items which are on the second page of the
    DataTable of news items.
- Test the process of deleting multiple news items at once:
  - Check the checkbox next to multiple items.
  - Click the "Delete selected" button at the bottom of the page.
  - Check that the wording of the confirmation message is correct.
  - After you confirm, the items should be deleted.
- Repeat these tests under Tools -> HTML customizations to confirm that
  redirects work correctly. After deleting an HTML customization you
  should be redirected back to the list of HTML customizations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 23 23:37:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 21:37:35 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-U1GOqJaiYa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 01:21:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 23:21:19 +0000
Subject: [Koha-bugs] [Bug 29101] unable to enter 020 and 024 tag fields
 other than blank
In-Reply-To: <bug-29101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29101-70-o8hc2TywR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29101

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
This sounds like a support query rather than a bug report. 

I'd suggest trying the mailing lists, IRC, or a support company:
https://koha-community.org/support/.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 01:24:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Sep 2021 23:24:45 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
 export_records.pl
In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20551-70-YoIEw6bjPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 02:11:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 00:11:05 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-vcuXS8sTD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 02:11:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 00:11:09 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-ExxU4O9ue5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125224&action=edit
Bug 15812: Use patron search in place of circ search

The 'Checkout' search hijacks some of the DataTables searching code used for
'Search patrons'
Rather than try to implement the search again on another page, we can simply
send the user
to the patron search if the cardnumber is not found

Additionally, this patch adds a 'Check out' button to the patron search results
to allow
going to checkotus directly

To test:
1 - Apply patch
2 - Perform a 'Checkout' search from the header
3 - Note that:
    For a cardnumber, you are redirected directly to checkouts page for the
borrower
    For a search with one result, you are redirected directly to the checkout
page for the borrower
    For a search with many results, you are redirected to the patron search
results
    and there is a 'Checkout' button under the cardnumber
4 - Confirm circulation page works as expected (i.e. checkout to a patron)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 02:13:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 00:13:01 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-vjLfDHKDDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Note: while changes to circulation.tt appear large, it is mostly a whitespace
change to fix indentation after removal of conditional on 'borrowers'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 03:38:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 01:38:37 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-GdAz5R7vV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123020|0                           |1
        is obsolete|                            |

--- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125225&action=edit
Bug 3150: Move emails for sending cart and list contents to notices

This patch creates notices using Template Toolkit syntax for sending
emails containing cart and list contents.

To test:
1. Apply Bug 27266
2. Run update database and restart services
3. In the staff client, add multiple items to your cart and to a list
4. Go to your cart and click Send to email the contents
5. Add an email and a comment and click Send
6. Confirm the information shown in the success message is correct
7. In your terminal, log into the database. View the message queue ( i.e.
select * from message_queue; ). Confirm that your email has been queued and the
content is all correct. Confirm the cart contents has been included as an
attachment.
8. Go to your list and click Send list to email the contents
9. Repeat steps 5-7
10. Log into the OPAC
11. Add multiple items to your cart and to a list
12. Repeat steps 4-9
13. By the end, you should have four emails in your message queue. All
of the data about the items should be correct, they should all have
attachments, and be addressed to the correct email address.

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 03:38:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 01:38:44 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-o74Mskldoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123021|0                           |1
        is obsolete|                            |

--- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125226&action=edit
Bug 3150: (follow-up) HTML filtering TT notices and removing old files

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 03:38:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 01:38:59 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-b7VAuOmFr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123022|0                           |1
        is obsolete|                            |

--- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125227&action=edit
Bug 3150: (follow-up) Reformat notices, don't send if no sender email

This patch reformats the notices so that the is_html flag is disabled
and the notices display better

It also throws an error if trying to send an email but the logged in
borrower has no valid email address.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 06:16:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 04:16:10 +0000
Subject: [Koha-bugs] [Bug 29104] New: Add new columns to table_borrowers
 column configuration
Message-ID: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

            Bug ID: 29104
           Summary: Add new columns to table_borrowers column
                    configuration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bibliwho at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The present options under columns_settings.pl for the table_borrowers table are
name, cardnumber, date_of_birth, category, library, address, & phone.

It would be helpful to have the dateexpiry column available for display as
well.

Others may have prefer additional columns as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 07:59:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 05:59:16 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-nJVkYHsJtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looking here now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:12:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:12:08 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-o42AB9JppC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    is( $items_scalar->count, 2, 'No items in resultset' );
+    is( scalar @items_list, 2, 'Empty list in list context' );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:28:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:28:22 +0000
Subject: [Koha-bugs] [Bug 28886] Remove uses of ->as_list from the codebase
In-Reply-To: <bug-28886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28886-70-GobLjE4kji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:35:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:35:45 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-uuaAm73vvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Curious code segment Koha/Patron:

sub get_club_enrollments {
    my ( $self, $return_scalar ) = @_;
    my $e = Koha::Club::Enrollments->search( { borrowernumber =>
$self->borrowernumber(), date_canceled => undef } );
    return $e if $return_scalar;
    return wantarray ? $e->as_list : $e;
}

$return_scalar ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:43:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:43:31 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-gYNNIaOoHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #22)
> If we need consistency, then should we adjust all the other methods?
> 
> Koha::UploadedFiles->getCategories?

Whats wrong with that one? Hahaha, it is the most consistent routine in Koha.
Always returning an arrayref.. Who wrote it? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:46:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:46:13 +0000
Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold
 only updates when printing new hold slip
In-Reply-To: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29103-70-g3XySIjcrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:46:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:46:43 +0000
Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold
 only updates when printing new hold slip
In-Reply-To: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29103-70-gB6RdZ4si0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:48:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:48:06 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-sUe10ZKqtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #16)
> (In reply to Jonathan Druart from comment #15)
> > Wow, no! This is not as trivial as it looks like.
> > 
> > We must force scalar context actually. I am expecting lot of side-effects
> > with this change.
> 
> I get that, but isn't it the case already? We already force scalar context
> when passing things to the templates.

It is not the case already. There is no need to force scalar now on
$item->holds or similar constructions since you get a single "plural Koha
object" back (if you know what I mean).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:51:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:51:35 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-75nhZgR1oQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
[PATCH 4/5] Bug 28883: Fix wrong list context calls
-    my $images = $biblio->cover_images;
-    $template->param( localimages => $biblio->cover_images );
+    $template->param( localimages => scalar $biblio->cover_images );
Why didnt you pass $images instead ? The original code was a bit weird.

But yes, it serves as a good example of why we cannot do this without
immediately fixing a lot of calls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 08:55:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 06:55:16 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-T9FnhK0Eo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #20)
> I have found only one problematic occurrence but I'd like another QA stamp
> with that in mind.

I have my doubts here if that was really the only one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 09:01:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 07:01:51 +0000
Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold
 only updates when printing new hold slip
In-Reply-To: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29103-70-Lb9b9luK8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103

--- Comment #1 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Thanks a lot Andrew! My colleagues just pointed me this one yesterday. I may
try to fix it, but I'll have soon a new child so I'm not sure I'll have time to
work on this one before November. I'll try next week.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 09:05:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 07:05:00 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-GI6NC9yW69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
$biblio->items->filter_by_visible_in_opac( { patron => $patron } )->as_list
=> This filter sub in Koha/Items always returns a scalar (a plural object).
=> Unfortunately, we have been quite inconsistent in this area.

E.g. directly following it:
sub filter_out_lost {
    my ($self) = @_;
    my $params = { itemlost => 0 };
    return $self->search( $params );
}
->search is context specific (contains wantarray), so depends on caller and
thus filter_out_lost is too. I am lost ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 09:42:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 07:42:16 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-xZmsL3YvT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125228&action=edit
Bug 28762: Update item-status include

This patch updates the item-status include so that it expects just an
item object making if simpler and more widely re-usable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 09:44:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 07:44:09 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-QZxL9aD7ph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #41)
> (In reply to Jonathan Druart from comment #20)
> > I have found only one problematic occurrence but I'd like another QA stamp
> > with that in mind.
> 
> I have my doubts here if that was really the only one.

Searching a bit, hmm. The first weak(!) example I found in a test:
t/db_dependent/Illrequests.t:    isa_ok($patron->checkouts, 'Koha::Checkouts');
In this specific test at that time there is only 1 item. But if there were
more, we would have a problem.
Gaining bit more confidence..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 09:57:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 07:57:42 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-RYJAmI94qR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125228|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125229&action=edit
Bug 28762: Update item-status include

This patch updates the item-status include so that it expects just an
item object making if simpler and more widely re-usable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:01:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:01:45 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-WJOBXlkmb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
OK Cant find bad calls that easy ;) WHich doesnt say there are none!
What I did:

=== cd Koha; git grep -E "return.*s\->_new_from_dbic"
=> Find routines that directly return a new_from_dbic with a plural object
DONE Account/Line.pm
DONE Acquisition/Basket.pm
DONE Acquisition/Bookseller.pm
DONE Acquisition/Order.pm
DONE Biblio.pm
Cash/Register.pm
Checkouts/ReturnClaims.pm
DONE Clubs.pm
DONE Course/Item.pm
Illrequest.pm
DONE Item.pm
DONE Library.pm
Object.pm
Object/Mixin/AdditionalFields.pm
Objects.pm
DONE Patron.pm
Patrons.pm
StockRotationRota.pm

Within that module, I looked for the specific subs that do it:
Biblio: items, orders, suggestions, cover_images
Patron: holds,checkouts, pending_checkouts, old_checkouts, get_routing_lists,
old_holds, return_claims, extended_attributes
Item: holds, cover_images,orders,   get_transfers, current_holds, tracked_links
Account/Line: credit_offsets, debit_offsets, credits, debits
Acquisition/Bookseller: baskets, contacts
Acquisition/Order: claims
Course/Item.pm: course_reserves
Library.pm: stockrotationstages, outgoing_transfers, inbound_transfers,
library_groups,  cash_registers

For each of these subs, I grepped something like:
git grep -E "\->\s*debits(\s*,|$)"

Which should find occurrences where $blabla-> debits, might be in a list or
function call etc.

So far, so good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:02:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:02:10 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-iuXvP8QPIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The include here was heavily inspired by the opac equivalent, the status cell
of the holdings table in catalogue/detail.tt and the equivalent include
included in bug 28854/bug 24023.

What I'm least familiar with here is holds and independent branches, so please
test that area carefully.

The challenge is holds in the holds table vs holds in the tmp_holdsqueue.. they
have different cases but I think I've handled both.

As for IndependantBranches.. there's some really funky code in
catalogue/details and GetItemInfo that deals with that.. we should be moving to
Koha::Item objects in catalogue/details as soon as possible with this patch in
my opinion.. but I feel that area may need some work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:17:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:17:32 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-AC6aOzsZEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
git grep Context.Scalar on master

koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:    [% IF
Context.Scalar(Context.Scalar(items, "filter_by_for_hold"), "count") %]
koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET current
  = Context.Scalar(orders, "filter_by_current") %]
koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET
cancelled = Context.Scalar(orders, "filter_by_cancelled") %]

I think we should not do these things in the templates. Doesnt look good to me.
The double Scalar in the first line is horrible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:34:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:34:17 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-MilCn9gbca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #33)
> After reading the comments again, it seems that:
> - Keep wantarray, fix places: ashimema, tcohen
> - Get rid of wantarray: Joubu
> 
> what do you think, Marcel?

Well, it looks like Martin changed opinion between comment28 and comment31.
And I do not read explicitly that Joubu wants to get rid of wantarray btw.

I would like to go the wantarray approach like this dev proposes. More
generally, it is the perl way of things. (The number of hits on wantarray is
surprisingly low btw in the codebase.) We created ->search as context
sensitive, so making new_from_dbic now context sensitive too and therewith
->items, ->holds etc, etc too is a logical followup.
As Jonathan and I have been looking for bad calls, it feels that we are on the
safe side when going further. Maybe we should push this quickly if we want it
in the next release. Allowing to test and find remaining problems.

But this is something else:
> I could chase the places in which scalar is used in a chained fashion on 
> templates and make them use the Scalar TT plugin as suggested.

Personally, I dont like to go that road. I already had some reservations about
passing Koha objects into the templates, but okay we do. But adding these
scalar calls here and there in templates is imo kind of pollution. Solve in the
controller, in perl.
Already we may miss things when git grepping the codebase, since we forget that
we are using a different notation when calling objects in the templates. Which
might be dangerous in the long run?

So I would opt for adding a patch here that removes these three calls somehow
instead of adjusting them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:56:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:56:39 +0000
Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to
 use backend template
In-Reply-To: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28909-70-lLNn8ERq5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:57:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:57:10 +0000
Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names
 looks terrible
In-Reply-To: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28879-70-2KjHUwq451@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 10:58:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 08:58:48 +0000
Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element
 causes duplicate actions
In-Reply-To: <bug-28932-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28932-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28932-70-KzfksuralJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:00:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:00:11 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-mD997yb7bO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:07:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:07:31 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-6sJETttX06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97959|0                           |1
        is obsolete|                            |
  Attachment #97960|0                           |1
        is obsolete|                            |

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 125230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125230&action=edit
Bug 22379: Fix checks not made by ILS-DI method CancelHold

Disable the possibility for a borrower to cancel a reservation
which is either in a Transit or Waiting state.
This reproduce the behaviour seen on the OPAC.
Also replaces previous checks on the borrowernumber
since CanReserveBeCanceledFromOpac already checks this.

--------------------------------

Test plan (before patch) :
-Put a reserve for a borrower
-Try to cancel the reserve providing another borrowernumber as argument
        -> Should fail and reply "RecordNotFound"
        -> Reserve still appears in the list of holds.

-Try to cancel the reserve providing the borrowernumber the reserve is
for.
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Put a new reserve with a pickup branch != from the homebranch
-Transfer the item to the pickup branch (reserve status = Transit)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Checkout the reserved item in the pickup branch (reserve status =
Waiting)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

--------------------------------

Test plan (after patch) :
-Put a reserve for a borrower
-Try to cancel the reserve providing another borrowernumber as argument
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

-Try to cancel the reserve providing the borrowernumber the reserve is
for.
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Put a new reserve with a pickup branch != from the homebranch
-Transfer the item to the pickup branch (reserve status = Transit)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

-Checkout the reserved item in the pickup branch (reserve status =
Waiting)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:07:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:07:47 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-OoX9Wx94GV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 125231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125231&action=edit
Bug 22379: Unit tests for CancelHold service

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:10:17 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-FT9p5mvFML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hello,
I've rebased and reuploaded the patches.
I also have tests failing but they seem to fail also on master :
<pre>
    #   Failed test 'Record hold, Item cannot be transferred'
    #   at t/db_dependent/ILSDI_Services.t line 558.
    #          got: undef
    #     expected: 'cannotBeTransferred'
</pre>

Hope this will pass QA now!
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:13:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:13:51 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-ccqwXizrqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125231|0                           |1
        is obsolete|                            |

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 125232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125232&action=edit
Bug 22379: Unit tests for CancelHold service

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:26:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:26:30 +0000
Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on
 course-details.pl
In-Reply-To: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28762-70-O5yJelSIoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125233&action=edit
Bug 28762: Move notforloan fallback into object

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:57:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:57:22 +0000
Subject: [Koha-bugs] [Bug 29105] New: items responses do not respect
 effective_itemtype
Message-ID: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

            Bug ID: 29105
           Summary: items responses do not respect effective_itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com

The item objects we return from various items API routes do not respect the
effective itype offerings.

Example, itype is mapped directly from the item itype field to item_type.. it
should check for effective itemtype and return the result of that.

Similarly notforloan is mapped directly, but can depend on the effective
itemtype.

There are possibly others.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:57:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:57:33 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-uzhdpVwYVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 11:58:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 09:58:04 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-t1F9t1pqRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not sure how to tackle this, I think it will need a to_api or TO_JSON
overload or something.?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:01:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:01:14 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-CM6wgNcl9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #45)
> git grep Context.Scalar on master
> 
> koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:    [% IF
> Context.Scalar(Context.Scalar(items, "filter_by_for_hold"), "count") %]
> koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET
> current   = Context.Scalar(orders, "filter_by_current") %]
> koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET
> cancelled = Context.Scalar(orders, "filter_by_cancelled") %]
> 
> I think we should not do these things in the templates. Doesnt look good to
> me.
> The double Scalar in the first line is horrible.

Additional note:
If TT was doing things a bit smarter, this should work like we chain in perl:
var countorders = [% biblio.orders.filter_by_current.count || 0 | html %];
(In Perl the chain brings it in scalar context.)

But it fails. TT calls the orders method in LIST context. Explaining the
horrible scalar stuff introduced.
See also https://www.perlmonks.org/bare/?node_id=413941

Question remains then: Should we workaround that in the script or template?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:07:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:07:39 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-zOIM18Lm0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:07:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:07:53 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-fHBerqCN1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Switching back to PQA as the blocker has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:25:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:25:47 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-z7kWllQPpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add new columns to          |Add dateexpiry column to
                   |table_borrowers column      |circulation patron search
                   |configuration               |results
           Severity|trivial                     |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:51:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:51:41 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-6fVMc50gDI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #60 from Owen Leonard <oleonard at myacpl.org> ---
I get an error from the opac-sendbasket popup whether or not I'm logged in:

Could not compile /kohadevbox/koha/opac/opac-sendbasket.pl: syntax error at
/kohadevbox/koha/opac/opac-sendbasket.pl line 122, near "else"
BEGIN not safe after errors--compilation aborted at
/kohadevbox/koha/opac/opac-sendbasket.pl line 137.

The QA tool also raises several warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 12:58:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 10:58:01 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-770YeBpUus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125224|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125234&action=edit
Bug 15812: Use patron search in place of circ search

The 'Checkout' search hijacks some of the DataTables searching code used for
'Search patrons'
Rather than try to implement the search again on another page, we can simply
send the user
to the patron search if the cardnumber is not found

Additionally, this patch adds a 'Check out' button to the patron search results
to allow
going to checkotus directly

To test:
1 - Apply patch
2 - Perform a 'Checkout' search from the header
3 - Note that:
    For a cardnumber, you are redirected directly to checkouts page for the
borrower
    For a search with one result, you are redirected directly to the checkout
page for the borrower
    For a search with many results, you are redirected to the patron search
results
    and there is a 'Checkout' button under the cardnumber
4 - Confirm circulation page works as expected (i.e. checkout to a patron)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:11:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:11:54 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-T0UhwaQhJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:19:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:19:50 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-LOmbdz7Qza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125235&action=edit
Bug 29105: Add effective_itemtype handling for Item API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:20:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:20:16 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-IHaEthwpSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:20:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:20:28 +0000
Subject: [Koha-bugs] [Bug 29106] New: Can we get rid of
 Koha::Item->effective_itemtype
Message-ID: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

            Bug ID: 29106
           Summary: Can we get rid of Koha::Item->effective_itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I file this bug to gather some ideas.

Do we still need that pattern here?

Right now we send a warning to the logs each time an item doesn't have an item
type set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:22:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:22:57 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-oqwoEgoLmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:26:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:26:34 +0000
Subject: [Koha-bugs] [Bug 29107] New: item_type should be item_type_id on
 item response object
Message-ID: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

            Bug ID: 29107
           Summary: item_type should be item_type_id on item response
                    object
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

This is what we've been doing, and not fixing it prevents us from embedding the
actual item_type object if we required it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:26:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:26:51 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-8ViOUQAiZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29105
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:26:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:26:51 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-um36vl5PCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29107

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:41:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:41:09 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-6NI9KY3j5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:41:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:41:14 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-idySx9ABpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125236&action=edit
Bug 29107: Rename item_type => item_type_id

This simple change renames the attribute in the item object API
representation.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/items.t
=> SUCCESS: Tests pass
2. Run:
   $ git grep 'api/v1/items'
=> SUCCESS: The items routes are not (yet) used in Koha
3. Run:
   $ cd koha-tmpl
   $ git grep --name-only '"embed"'
=> SUCCESS: Only two templates are using embed.
4. Check:
   - register.tt uses it to embed the manager, good
   - parcel.tt uses it to embed items. Alert.
=> SUCCESS: parcel.tt only uses a count on items. No item_type involved.
5. Sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

https://bugs.koha-community.org/show_bug.cgi?id=29105

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 13:41:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 11:41:34 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-WV6hCTB8lx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:03:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:03:23 +0000
Subject: [Koha-bugs] [Bug 29108] New: Add q parameters to items routes
Message-ID: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

            Bug ID: 29108
           Summary: Add q parameters to items routes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:03:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:03:34 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-r68gSnqXm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:07:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:07:31 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-euCYCs3zqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com
         Depends on|                            |29107
             Status|ASSIGNED                    |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107
[Bug 29107] item_type should be item_type_id on item response object
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:07:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:07:31 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-zNENq2538a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29108


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108
[Bug 29108] Add q parameters to items routes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:07:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:07:47 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-JpILdT6iEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125237&action=edit
Bug 29108: Add q parameters to items routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:13:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:13:33 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-v38b50q7hE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #47)
> (In reply to Marcel de Rooy from comment #45)
> > git grep Context.Scalar on master
> > 
> > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:    [% IF
> > Context.Scalar(Context.Scalar(items, "filter_by_for_hold"), "count") %]
> > koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET
> > current   = Context.Scalar(orders, "filter_by_current") %]
> > koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc:    [% SET
> > cancelled = Context.Scalar(orders, "filter_by_cancelled") %]
> > 
> > I think we should not do these things in the templates. Doesnt look good to
> > me.
> > The double Scalar in the first line is horrible.
> 
> Additional note:
> If TT was doing things a bit smarter, this should work like we chain in perl:
> var countorders = [% biblio.orders.filter_by_current.count || 0 | html %];
> (In Perl the chain brings it in scalar context.)
> 
> But it fails. TT calls the orders method in LIST context. Explaining the
> horrible scalar stuff introduced.
> See also https://www.perlmonks.org/bare/?node_id=413941

We should be able to use the TT scalar plugin and do things like:

[% USE scalar %]
[% SET var = scalar.biblio.items %]

but I haven't checked it.

> Question remains then: Should we workaround that in the script or template?

I feel like we should do this stuffs in the controller and leave logic out of
TT, as much as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:20:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:20:13 +0000
Subject: [Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To'
 and following messages are never processed.
In-Reply-To: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28996-70-dkYOR9SfDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

--- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> ---
Created attachment 125238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125238&action=edit
Bug 28996: Catch error in mail creation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:25:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:25:54 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-vXHDLRipsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #4)
> (In reply to David Nind from comment #3)
> > Everything worked fine in the staff interface.
> > 
> > However, in the OPAC no items are shown for the patron (Your account > Your
> > summary > Article requests tab (has no number in (), and not items listed.
> > This may be one of the dependcies causing this...
> > 
> > Testing notes:
> > - remember to run updatedatabase (for other dependencies)
> 
> Thanks for testing! Will check it ASAP.

Solved, on bug 29083.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:26:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:26:09 +0000
Subject: [Koha-bugs] [Bug 14791] Automatically attempt to resend failed
 notices
In-Reply-To: <bug-14791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14791-70-gju3DVBAME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Lari Taskula from comment #14)
> Blocked by Bug 14723.

Bug 14723 is pushed to master, but this no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:36:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:36:09 +0000
Subject: [Koha-bugs] [Bug 28740] Delete old ILL requests with
 cleanup_database
In-Reply-To: <bug-28740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28740-70-RudpG5EGpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28740

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29109

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:36:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:36:08 +0000
Subject: [Koha-bugs] [Bug 29109] New: Delete ILL requests manually
Message-ID: <bug-29109-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29109

            Bug ID: 29109
           Summary: Delete ILL requests manually
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com

There is no way to delete an ILL request in the staff client. It would be nice
to be able to delete a request that is either complete or somehow in error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:52:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:52:51 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-33pwA4jCfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125159|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125239&action=edit
Bug 29082: Add filtering methods to Koha::ArticleRequests

This patch adds handy methods for filtering Koha::ArticleRequests
resultsets.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:53:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:53:36 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-ud27XFXnqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, it well covered by tests.

Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:55:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:55:54 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-uIq1MxCHd1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|27947                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
[Bug 27947] Add default cancellation reasons to article requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 14:55:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 12:55:54 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-cztU6fd29M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|29083                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083
[Bug 29083] Update article requests-related Koha::Patron methods to use
relationships
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:01:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:01:16 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-RJePyF9qmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125160|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125240&action=edit
Bug 29083: Unit tests

This patch adds missing tests for Koha::Patron->article_requests and
moves (and extends) tests for 'article_requests_current' and
'article_requests_finished' that were originally in ArticleRequests.t
into Koha/Patron.t as we now do.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests pass!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:01:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:01:20 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-OMq8AeWv2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125161|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125241&action=edit
Bug 29083: Update article requests-related Koha::Patron methods to use
relationships

This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.

No behavior change should take place.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:01:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:01:24 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-KchyGiUJgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125162|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125242&action=edit
Bug 29083: (QA follow-up) Remove unused param

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:01:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:01:28 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-DpRuOE0EhE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125186|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125243&action=edit
Bug 29083: Fix OPAC listing of article requests

This patch makes the OPAC template reuse a precalculated value for the
active article requests for the patron (and its count).

The original code relied on the methods returning a list, which is not
the case for _new_from_dbic until bug 28883 is pushed.

This patch fixes that.

Note: there was an odd behavior when ArticleRequests was enabled but no
active article requests were present: the tab wasn't rendered but the
'empty table' with the 'You have no article requests currently.' message
was displayed below the Checkouts tab. I'm not sure that was caused by
this patches, or other. Fixed on this patch.

To test:
1. In the OPAC, go to 'your summary'
=> FAIL: Things don't show for article requests
2. Add some article requests and repeat 1
=> FAIL: Something's wrong there
3. Apply this patch and repeat 1
=> Yes! Things show correctly!
4. Cancel all your article requests
=> SUCCESS: Things render as they should
5. Re-enter the 'your summary' page (to force re-rendering)
=> SUCCESS: Things render correctly for empty article requests
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:01:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:01:59 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-aaKNiFOqJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice clear refactor.. signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:04:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:04:47 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-oWLsCvGpzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125163|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125244&action=edit
Bug 29084: Unit tests

This patch adds missing tests for Koha::Biblio->article_requests and
reorganizes (and extends) the tests for 'article_requests_current' and
'article_requests_finished' that were originally in ArticleRequests.t
into Koha/Biblio.t as we do now.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:04:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:04:50 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-Q6XR4adkm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125164|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125245&action=edit
Bug 29084: Update article requests-related Koha::Biblio methods to use
relationships

This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.

No behavior change should take place.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:05:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:05:54 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-xtW9MtmRdM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another nice improvement.. no regressions found.

Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:08:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:08:22 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-k89WUjVygw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:08:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:08:23 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-vFUEE22AVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125175|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125246&action=edit
Bug 29086: Simplify querying active article requests

This patch makes a trivial replacement of a query for a higher level
method that does the same query.

To test:
1. Enable the ArticleRequests feature
2. Place some article requests on known biblios
3. Have some article requests be active on others finished (either
   completed or cancelled)
4. Go to the detail page for those records
=> SUCCESS: The active article requests count is correct!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:08:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:08:27 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-2VBDmo8e4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125176|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125247&action=edit
Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses

I noticed a couple places in which this library was included but not
used.

To test:
1. Apply this patch
2. Run:
   $ git grep 'Koha::ArticleRequest::Status'
=> SUCCESS: There aren't any calls to their defined constants in
Biblio.pm or Patrons.pm
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:08:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:08:44 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-EZiyTq1TAi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:30:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:30:11 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-n6yFa7s1uT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
         Depends on|                            |29086

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Adding a dependency to organize things. It doesn't apply.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086
[Bug 29086] Reuse article request filtering methods in Biblio template plugin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:30:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:30:11 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-CtxeSPchBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949
[Bug 27949] Batch printing of article request slips
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:34:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:34:48 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for holds
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-4zRYI1Lu6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #47 from Owen Leonard <oleonard at myacpl.org> ---
Marking "Failed QA" based on comment 46.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:35:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:35:17 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-WKbizYmlmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:35:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:35:23 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-EU88UxCOBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125183|0                           |1
        is obsolete|                            |

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125248&action=edit
Bug 27949: Allow multiple article requests print slip

This bug allows for batch printing of multiple article requests slips

To test:
1. apply this patch
2. restart_all
3. enable ArticleRequests preference
4. create multiple article requests
5. go to circ/article-requests.pl in staff interface
6. print a single slip from a row
CHECK => it works as expected
7. select all rows and print slip from general actions menu (above the table)
SUCCESS => all article requests slips are printed
8. select multiple rows (not all) and print slip from general actions menu
(above the table)
SUCCESS => only selected article requests slips are printed

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:41:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:41:49 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-TlYWdnldtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:41:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:41:52 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-aIAZ9YDwDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 125249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125249&action=edit
Bug 29104: Add date expiry column to patron search borrower table

Test plan:
1. Apply patch
2. The new dateexpiry column will be hidden by default, go to table settings
and expose it (table_borrowers)
3. Do a patron search that will return multiple patrons, you should see the
date expiry column
4. Make the date displays correctly  right with different dateformats
5. Make sure that the column, and other columns in that table, can be correctly
hidden via table settings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:52:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:52:12 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-GEgzEC52Zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 15:52:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 13:52:28 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-VOqFlTcYXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:04:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:04:47 +0000
Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean
 operators for Elasticsearch
In-Reply-To: <bug-25616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25616-70-QsV9w7t05X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
The same issue has been address in bug 23322 och bug 24506, but some instances
of where operator case need to be changed remains and is addressed in this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:08:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:08:10 +0000
Subject: [Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To'
 and following messages are never processed.
In-Reply-To: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28996-70-AO02ZV9TyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

Didier Gautheron <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125238|0                           |1
        is obsolete|                            |

--- Comment #2 from Didier Gautheron <didier.gautheron at biblibre.com> ---
Created attachment 125250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125250&action=edit
Bug 28996: Catch error in mail creation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:16:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:16:48 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-fdgHRnPdU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125251&action=edit
Bug 29105: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:16:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:16:51 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-6tDWQS5tnk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125252&action=edit
Bug 29105: Add effective_itemtype handling to items api

This patch adds effective_itemtype handling to the items api.

We overload the to_api method to replace the itype column value with
that of the effective itemtype code.

We also add in the notforloan fallback that is apparent in
catalogue/details.tt status templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:17:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:17:57 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-YjtZIiH9y1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125235|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:18:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:18:03 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-NIEwGO1k9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:18:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:18:17 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-hQPGP480DI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:20:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:20:25 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-dP22jqn4wy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125236|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125253&action=edit
Bug 29107: Rename item_type => item_type_id

This simple change renames the attribute in the item object API
representation.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/items.t
=> SUCCESS: Tests pass
2. Run:
   $ git grep 'api/v1/items'
=> SUCCESS: The items routes are not (yet) used in Koha
3. Run:
   $ cd koha-tmpl
   $ git grep --name-only '"embed"'
=> SUCCESS: Only two templates are using embed.
4. Check:
   - register.tt uses it to embed the manager, good
   - parcel.tt uses it to embed items. Alert.
=> SUCCESS: parcel.tt only uses a count on items. No item_type involved.
5. Sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:34:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:34:05 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-KfxaEbdXez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is great to see.. but as discussed, with bug 29105 in mind we need to
think about how we overload the existing API search method to allow for the
item-level_itypes mapping in searches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:36:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:36:12 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-2Brw6EXgzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:45:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:45:38 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-Bl2j7nbpM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Well, this one stands on its own. We should move the discussion about the
search override to bug 29105.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:46:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:46:39 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-a05V0qXuQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:48:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:48:05 +0000
Subject: [Koha-bugs] [Bug 29110] New: Refactor Koha::ArticleRequest->store
Message-ID: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

            Bug ID: 29110
           Summary: Refactor Koha::ArticleRequest->store
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We should revisit the file altogether, and add more checks to ->store. This way
the code will be easier to follow are more similar to what we do everywhere
else.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:48:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:48:25 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-SkOCTxrrxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27949
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949
[Bug 27949] Batch printing of article request slips
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:48:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:48:25 +0000
Subject: [Koha-bugs] [Bug 27949] Batch printing of article request slips
In-Reply-To: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27949-70-c7ajcxwkOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29110


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
[Bug 29110] Refactor Koha::ArticleRequest->store
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:48:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:48:38 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-lJOqoWoAhE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:52:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:52:01 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-sbzmNSPYIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125237|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125254&action=edit
Bug 29108: Add q parameters to items routes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:52:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:52:39 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-YpXyv2hXE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fair.. signed off then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:53:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:53:04 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-zudvU9zvNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29108

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:53:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:53:04 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-ALhMrLFr1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29105

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:53:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:53:46 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-QlmQyQ02rN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So this patch does one direction (i.e. results), but doesn't cater for searches
using q_param yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:57:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:57:43 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-ybLLABJFj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125051|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125255&action=edit
Bug 29056: Remove the demo functionality leftovers

Remove forgotten code of the old legacy demo functionality that was
removed from elsewhere except systempreferences, this code not only
serves no purpose but also is causing some troubles for our customers.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 16:57:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 14:57:53 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-9ZuPKfDaCG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:07:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:07:58 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-7sGZsCSGKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:08:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:08:02 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-Q2czqGArvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125256&action=edit
Bug 29110: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:08:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:08:06 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-yoBjvpf9yp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125257&action=edit
Bug 29110: Refactor Koha::ArticleRequest

This patchset is simple to test. It adds lots of tests for the existing
routines, and then tweaks them.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/ArticleRequest*
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:12:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:12:11 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-9ZNlRJRVCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125035|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125258&action=edit
Bug 28906: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:12:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:12:15 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-7J6VP8s5iT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125036|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125259&action=edit
Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context

This patch makes the method honour list context.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail! It returns [Koha::Items]. Boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:12:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:12:19 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-o5EGel8Ub4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125037|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125260&action=edit
Bug 28906: (26223 follow-up) Remove use of as_list

This bug makes Koha::Items->filter_by_visible_in_opac honour list
context, so this explicit call is not needed.

To test:
1. Pick a biblio in the OPAC
2. Go to the ISBD view
=> SUCCESS: It renders correctly
3. Apply this patch and restart Plack
4. Refresh the ISBD view page
=> SUCCESS: It doesn't break!
5. Check opac-reserve.pl doesn't break either
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:12:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:12:46 +0000
Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac
 doesn't honour list context
In-Reply-To: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28906-70-WYNx5tKSgn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works as expected, no regressions found, QA scripts happy and tests all
passing.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:14:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:14:24 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-6dE7AglKXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125029|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125261&action=edit
Bug 28438: Capitalization: Various corrections

This patch makes capitalization corrections to many templates in the
OPAC and staff interface. A exhaustive test plan would be huge, so I
recommend examining the patch to confirm that it contains correct case
changes.

If you want to make it easier to examine changes you can try:
https://github.com/so-fancy/diff-so-fancy

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:14:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:14:27 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-0BHzU9xS5I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125030|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125262&action=edit
Bug 28438: (follow-up) Capitalization: Various corrections

One mdditional correction.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:14:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:14:50 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-8U6GPEcDO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:14:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:14:54 +0000
Subject: [Koha-bugs] [Bug 29082] Add filtering methods to
 Koha::ArticleRequests
In-Reply-To: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29082-70-Z2uBVBUyPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125239|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125263&action=edit
Bug 29082: Add filtering methods to Koha::ArticleRequests

This patch adds handy methods for filtering Koha::ArticleRequests
resultsets.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:14:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:14:58 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-AV11WRm15C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Excellent work.. scald the devs for getting them wrong in the first place (that
probably includes me :( )

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:16:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:16:28 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-Hoi2HUQ4ad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125113|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125264&action=edit
Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate

DefaultHldexpirationDate is set in the pref screen to 'yes/no'

The code checks if the preference is 'true', 'no' is true

We should instead use 1/0

To test:
0 - Have a fresh devbox
1 - With syspref disabled, place a hold
2 - Note no expiration date set
3 - Enable the preference
4 - Place a hold and note the expiration date is set, good
5 - Disable the pref
6 - Place a hold and note the expiration date is set, bad
7 - Apply patch
8 - Update database
9 - Repeat 1-8, date not set when pref disabled

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:16:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:16:58 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-ZQmS5k7upI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Doh!

Well spotted, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:20:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:20:38 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-Gg2dCnKaZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123112|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125265&action=edit
Bug 28534: Fix engine for pending_offline_circulations table

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:20:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:20:43 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-8K1aNH2qig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123113|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125266&action=edit
Bug 28534: Atomic update to fix existing installs

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:20:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:20:47 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-9FuzXRpbKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124865|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125267&action=edit
Bug 28534: (follow-up) Don't adjust original DB update

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:21:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:21:10 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-a59HSnZdjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:25:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:25:37 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-rUj2A95Kq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:25:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:25:40 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-HMPPXbSTgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125240|0                           |1
        is obsolete|                            |
 Attachment #125241|0                           |1
        is obsolete|                            |
 Attachment #125242|0                           |1
        is obsolete|                            |
 Attachment #125243|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125268&action=edit
Bug 29083: Unit tests

This patch adds missing tests for Koha::Patron->article_requests and
moves (and extends) tests for 'article_requests_current' and
'article_requests_finished' that were originally in ArticleRequests.t
into Koha/Patron.t as we now do.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests pass!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:25:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:25:44 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-OfQeOBxLyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125269&action=edit
Bug 29083: Update article requests-related Koha::Patron methods to use
relationships

This patch makes Koha::Patron->article_requests use the underlying DBIC
relationship and _new_from_dbic instead of a plain search. It also
refactors 'article_requests_current' and 'article_requests_finished' to
use ->article_requests, as well as the new methods introduced by bug
29082 for filtering.

No behavior change should take place.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/ArticleRequests.t
=> SUCCESS: Tests pass!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:25:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:25:47 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-mLGRN8xzvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125270&action=edit
Bug 29083: (QA follow-up) Remove unused param

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:25:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:25:50 +0000
Subject: [Koha-bugs] [Bug 29083] Update article requests-related
 Koha::Patron methods to use relationships
In-Reply-To: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29083-70-60VvHR01En@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125271&action=edit
Bug 29083: Fix OPAC listing of article requests

This patch makes the OPAC template reuse a precalculated value for the
active article requests for the patron (and its count).

The original code relied on the methods returning a list, which is not
the case for _new_from_dbic until bug 28883 is pushed.

This patch fixes that.

Note: there was an odd behavior when ArticleRequests was enabled but no
active article requests were present: the tab wasn't rendered but the
'empty table' with the 'You have no article requests currently.' message
was displayed below the Checkouts tab. I'm not sure that was caused by
this patches, or other. Fixed on this patch.

To test:
1. In the OPAC, go to 'your summary'
=> FAIL: Things don't show for article requests
2. Add some article requests and repeat 1
=> FAIL: Something's wrong there
3. Apply this patch and repeat 1
=> Yes! Things show correctly!
4. Cancel all your article requests
=> SUCCESS: Things render as they should
5. Re-enter the 'your summary' page (to force re-rendering)
=> SUCCESS: Things render correctly for empty article requests
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:26:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:26:45 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-ahTJczLz0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122752|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125272&action=edit
Bug 13188: Add PatronSelfModificationMandatoryField system preference

TEST PLAN:
1. Apply patch, updatedatabase, restart_all
2. In the  PatronSelfRegistrationBorrowerMandatoryField add the field password.
3. Go to the self registration page on make sure password is required.
4. Now go to the OPAC modification page, make some changes and attempt to
submit. It should work.
5. Go to PatronSelfModificationMandatoryField and select some fields.
6. The columns you selected should now be required.
7. On the PatronSelfModificationMandatoryField page, make sure the select all
and clear all buttons work.

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:26:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:26:49 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-wvMmp3qJIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123335|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125273&action=edit
Bug 13188: (follow-up) Get value from
PatronSelfRegistrationBorrowerMandatoryField when updating database

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:26:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:26:54 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-Ev5vMcCk4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125274&action=edit
Bug 13188: (QA follow-up) Modernise atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:27:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:27:24 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-BtWCQpTnBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice one.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:29:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:29:37 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-tq18LJHpm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125133|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125275&action=edit
Bug 29078: Resolve division by zero in touch_all scripts

Illegal division by zero at misc/maintenance/touch_all_biblios.pl line 102.

Trivial fix.
Funny that the percentage is not even shown without verbose flag ;)

Test plan:
Run misc/maintenance/touch_all_biblios.pl -where 'biblionumber<0'
You should now see:
Good: 0, Bad: 0 (of 0) in 0 seconds

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:30:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:30:00 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-Q04hKDYPoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works as expected.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:32:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:32:25 +0000
Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names
 looks terrible
In-Reply-To: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28879-70-XTufSONWwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:32:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:32:28 +0000
Subject: [Koha-bugs] [Bug 28879] Display of metadata with long label names
 looks terrible
In-Reply-To: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28879-70-RnZxYZLYxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123961|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125276&action=edit
Bug 28879: Fix display of request metadata

This commit adjusts the CSS surrounding the display of request
metadata, it improves the display for metadata with long key names.

Test plan:

- Do not apply patch
- Create a FreeForm ILL request with a custom metadata field with a long
  name
- View the created request
- Observe that the long metadata name breaks the display of the metadata
- Apply the patch
- View the created request
  => TEST: Observe that the display is no longer broken

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:37:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:37:33 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-YEyCViVGpG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125089|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125277&action=edit
Bug 29065: Accessibility OPAC clear search history link has insufficient
contrast

This patch changes the colour of the clear search history link
on the OPAC to increase the contrast ratio, improve accessibility
and makes the text easier to read.

To test:

1. Go to the OPAC homepage
2. Use an accessibility tool (e.g Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the clear search history link
   has insufficient contrast
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Confirm that the contrast ratio now
   meets minimum accessibility requirements
6. Check the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:38:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:38:37 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-hJwn7QWOcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Brill. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:48:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:48:15 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-9PRTuNnW4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:48:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:48:18 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-HuVN9DCuyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125223|0                           |1
        is obsolete|                            |

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 125278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125278&action=edit
Bug 29019: Unable to delete HTML customization

This patch makes some corrections to additional contents to allow
content to be deleted. The wrong parameter was being passed to the
script. The script was also not handling multiple deletions correctly.

The patch also adds a "category" parameter to the delete operation so
that the page is redirected correctly.

The patch also changes some strings which referred to "news"
referencing operations which might be performed on news or on HTML
customizations, e.g.:

"Are you sure you want to delete the selected content?" instead of "Are
you sure you want to delete the selected news?"

To test, apply the patch and go to Tools -> News.

- Create multiple news items if necessary.
- Test the "Delete" button corresponding to a single news item:
  - Clicking the button should ask you to confirm.
  - Check that the wording of the message is correct.
  - After confirming the news item should be deleted.
  - Ideally, test on news items which are on the second page of the
    DataTable of news items.
- Test the process of deleting multiple news items at once:
  - Check the checkbox next to multiple items.
  - Click the "Delete selected" button at the bottom of the page.
  - Check that the wording of the confirmation message is correct.
  - After you confirm, the items should be deleted.
- Repeat these tests under Tools -> HTML customizations to confirm that
  redirects work correctly. After deleting an HTML customization you
  should be redirected back to the list of HTML customizations.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:52:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:52:36 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-cRlrMdYA1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125153|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125279&action=edit
Bug 29037: Accessibility: OPAC links don't have sufficient contrast

This patch changes the colour of links on the OPAC
to improve the contrast ratio and make the link
text easier to read. This accessibility issue was
identified using the WebAIM WAVE accessibility
browser extension and Google Chrome's Lighthouse
tool.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that some links (e.g. breadcrumb links
   and title links in search results) have
   insufficient contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio meets minimum requirements
5. Check that the OPAC still looks ok after the
   changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:53:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:53:07 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-bgWdRzhA2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
A marked improvement. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:59:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:59:34 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-cLf6bS5N6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122193|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125280&action=edit
Bug 28510: Skip processing holds queue items from closed libraries when
HoldsQueueSkipClosed is enabled

Right now we skip closed branch's items as we iterate over all items looking
for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a
closed library can be targeted, so it would be more efficient if we never
selected the items from those branches to begin with. This is how the holds
queue works if we are not using the transport cost matrix, so we should make it
work the same way if we *are* using the matrix.

Test Plan:
1) Apply this patch
2) prove prove t/db_dependent/HoldsQueue.t
3) All tests should continue to pass

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:59:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:59:38 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-ysPW1Ub5Ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122194|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125281&action=edit
Bug 28510: Remove marking of closed branches as 'disable_transfer'

We no longer need to act as if closed branches were marked as
disable_transfer. This allows us to clean up a nice bit of code.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:59:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:59:41 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-oOG0ZQaf5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122195|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125282&action=edit
Bug 28510: Remove unnecessary conditional

It makes sense to use items by branch to get the list of branches, as it
already tells use which branches have available items. We could use
branches to pull from instead, but all we would accomplish is added
extra ununsed loop iterations. We already know that any additional
branches in the branches to pull loop have no items to fill holds.
If they did, they would be in the items_by_branch hash.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 17:59:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 15:59:45 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-9muClC9Gvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124842|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125283&action=edit
Bug 28510: Remove unused variable

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:00:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:00:13 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-eM1dLNEuwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work, QA scripts happy, cleaner code and tests still pass.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:00:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:00:18 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-rlNgjT0bYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:00:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:00:20 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-hPJKeHaIGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:00:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:00:37 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-eLLLvkN1BM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125256|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 125284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125284&action=edit
Bug 29110: Unit tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:00:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:00:46 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-bc4MdHAWtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125257|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 125285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125285&action=edit
Bug 29110: Refactor Koha::ArticleRequest

This patchset is simple to test. It adds lots of tests for the existing
routines, and then tweaks them.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/ArticleRequests.t \
           t/db_dependent/Koha/ArticleRequest*
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:03:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:03:58 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-sSNb3Sz9y8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123599|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125286&action=edit
Bug 28826: Add FacetOrder system preference

This bug adds a system preference to control ordering of facets and
adds the control to both Zebra and Elasticsearch

To test:
1 - Have a koha that can use both Zebra and ES
2 - Set 'displayFacetCount' to true
3 - Search in ES and Zebra
4 - Note facets in Zebra sorted alphabetically, ES by usage
5 - Apply patch, updatedatabase
6 - Search in ES and Zebra, facets are alphabetically sorted in both
7 - Find new syspref FacetOrder and set to 'by usage'
8 - Search in both engines, facets sorted by usage

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:04:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:04:43 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-SW7hu6jrQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works well, nice improvement.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:15:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:15:57 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-kBE72qi5gF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
I singed this off, but then thought I should check that the article requests
system is still working.

When adding a request or going to "Your account" (all the other user account
ages seem fine) I get:

Template process failed: undef error - DBIC result _type  isn't of the _type
Item at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 751.
 at /kohadevbox/koha/C4/Templates.pm line 121

    in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 121

      118: 
      119:     my $data;
      120:     binmode( STDOUT, ":encoding(UTF-8)" );
      121:     $template->process( $self->filename, $vars, \$data )
      122:       || die "Template process failed: ", $template->error();
      123:     return $data;
      124: }

    Show function arguments
    in (eval) at /kohadevbox/koha/opac/opac-user.pl line 421

      418:     );
      419: }
      420: 
      421: output_html_with_http_headers $query, $cookie, $template->output,
undef, { force_no_caching => 1 };

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:18:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:18:56 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-WGM1b0JRmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:19:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:19:43 +0000
Subject: [Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are
 caused by OPACUserJS/IntranetUserJS
In-Reply-To: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25003-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25003-70-4dgZxyR7T4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003

T. Keagan <tasha.keagan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tasha.keagan at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:29:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:29:55 +0000
Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point
 of Sale can make the Collect Payment field off
In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27801-70-w1JO8ipx18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

Esther Melander <estherm at sodaspringsid.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |estherm at sodaspringsid.com

--- Comment #4 from Esther Melander <estherm at sodaspringsid.com> ---
Created attachment 125287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125287&action=edit
Calculation error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:30:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:30:47 +0000
Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point
 of Sale can make the Collect Payment field off
In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27801-70-EJgYAOwwTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801

--- Comment #5 from Esther Melander <estherm at sodaspringsid.com> ---
On version 21.05.14.

The combination of the certain numbers appears to result in being 1 penny off.

0.6 x 3 = 1.79
0.7 x 3 = 2.09

Other combinations appear to be correct.

In this case, only one item is added to the sale box.

Screenshot attached to ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:44:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:44:18 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-C9sB59fufi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:44:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:44:45 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-4y9S8vM0Em@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125190|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 125288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125288&action=edit
Bug 29093: Database revision for article_requests.toc_request

Test plan:
Run dbrev or new install.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:44:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:44:53 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-M46BsrKEtB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125191|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 125289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125289&action=edit
Bug 29093: {DO NOT PUSH] DBIx schema changes

Note: Pending table changes in PQA.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 18:45:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 16:45:14 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-wDfUwUhtig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125192|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 125290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125290&action=edit
Bug 29093: Interface changes

Show the TOC checkbox on OPAC and staff.

Test plan:
Add new article request on OPAC or staff. Tick checkbox.
Verify if TOC is Yes on opac-user or staff patron details.
Check the list view on circ/article-requests.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 19:23:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 17:23:49 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-U1rK17esHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #5)
> I singed this off, but then thought I should check that the article requests
> system is still working.
> 
> When adding a request or going to "Your account" (all the other user account
> ages seem fine) I get:
> 
> Template process failed: undef error - DBIC result _type  isn't of the _type
> Item at
> /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line
> 751.
>  at /kohadevbox/koha/C4/Templates.pm line 121
> 
>     in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 121
> 
>       118: 
>       119:     my $data;
>       120:     binmode( STDOUT, ":encoding(UTF-8)" );
>       121:     $template->process( $self->filename, $vars, \$data )
>       122:       || die "Template process failed: ", $template->error();
>       123:     return $data;
>       124: }
> 
>     Show function arguments
>     in (eval) at /kohadevbox/koha/opac/opac-user.pl line 421
> 
>       418:     );
>       419: }
>       420: 
>       421: output_html_with_http_headers $query, $cookie, $template->output,
> undef, { force_no_caching => 1 };

Are you sure you restarted all the things? I have just applied the whole tree
and reset_all, and things keep working as they used to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 19:27:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 17:27:51 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-sISbeHfGxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124874|0                           |1
        is obsolete|                            |
 Attachment #124875|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125291&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 19:28:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 17:28:03 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-F4EQrYVJBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125292&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:03:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:03:59 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-bY6YGC15iK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:04:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:04:02 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-npmwFQcEdU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125080|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125293&action=edit
Bug 29036: Accessibility OPAC buttons don't have sufficient contrast

This patch changed the base colour of OPAC buttons to increase the
contrast ratio, improving accessibility and making the button text
easier to read.

To test:

1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check
   the contrast ratio on the OPAC
2. Confirm that the OPAC buttons don't have sufficient colour contrast
3. Apply the patch and rebuild css:
   yarn build --view opac
4. Use the accessibility tool to confirm the button contrast ratio now
   meets minimum accessibility requirements
5. Check that the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:04:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:04:06 +0000
Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have
 sufficient contrast
In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29036-70-W30bkf93iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125294&action=edit
Bug 29036: (follow-up) Improve the use of variables to keep colors consistent

This patch modifies the OPAC SCSS so that a "base theme color" variable
is defined which can be used to color button backgrounds and similar
elements. The patch also moves some other colors into variables and
removes some unused CSS.

The Koha logo which is displayed in the upper left corner of the OPAC
has been modified to use the same color.

To test, apply the patch and repeat the previous test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:06:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:06:15 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-GshlleXLUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125291|0                           |1
        is obsolete|                            |
 Attachment #125292|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125295&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:06:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:06:24 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-hKFs3GAxYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125296&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:06:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:06:28 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-GZSaG6ftGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125297&action=edit
Bug 28974: Hard code page = 1 instead of using javascript

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:24:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:24:06 +0000
Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values
 (POC)
In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24977-70-LqcIEDevrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 20:24:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 18:24:22 +0000
Subject: [Koha-bugs] [Bug 24975] Refactor database translations
In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24975-70-t8SlQR03h5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:18:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:18:10 +0000
Subject: [Koha-bugs] [Bug 26305] Warn IE users of staff interface that it is
 no longer supported and to use a supported browser instead
In-Reply-To: <bug-26305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26305-70-DCEDf3lGZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:39:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:39:31 +0000
Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for
 non-waiting holds
In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14783-70-6PXdATZzXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:49:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:49:17 +0000
Subject: [Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To'
 and following messages are never processed.
In-Reply-To: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28996-70-YZaCqpM3Mj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
+1 giga

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:50:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:50:01 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-RQCPLNvheq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #18 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 125298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125298&action=edit
Bug 17649: Only one message per borrower and overdue level

The added option (-a|--all_in_one) allows to create only one message per
borrower and delay level
including overdues from whatever branches.
A branchcode value (branches.branchcode) has to be given to choose which sender
address will be set.

== test plan ==
0/ Have (or create) at least two branches B1 and B2. Have (or create) a default
notice for all branches in Notices and Slips Module
1/ Make sure you're logged in with an account belonging to B1, or switch to
branch B1
2/ checkout item I1 (belonging to B1) to patron P (specifying as due date the
day before (1 day overdue))
3/ switch to branch B2
4/ checkout item I2 (belonging to B2) to patron P (specifying as due date the
day before (1 day overdue))
5/ make sure you have defined "Overdue notice/status triggers" for that patron
category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is
checked.
6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' (optionally
specifying also '-library B1 -library B2' )
7/ Two new entries will be generated in message_queue DB table, coming from
different branches that have the SAME list of overdue items
8/ either see the 'content' field in these entries, or run 'perl
./cronjobs/process_message_queue.pl' to receive the actual emails (provided the
email is properly setup).

Apply patch
redo step 6 running the script with the new option -a (all_in_one). this option
expect as mandatory parameter the branchcode of the library that you want to
make sender of the message. say that 'B2CODE' is the branchcode of B2 branch,
it will run like this :
perl ./misc/cronjobs/overdue_notices.pl -a B2CODE
You will see that only one message had been created. Its content shows both B1
and B2 overdue items and the sender address matches B2 address as well.

Rebased-on: 2021-09-24 Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:50:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:50:22 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-dd8bciNpoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58398|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 21:50:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 19:50:26 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-fhDBFDTWt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80925|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:17:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:17:37 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-z29yo1Ylu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Hi,

Looks great.

Just a few thoughts :

> 3. Do a patron search that will return multiple patrons, you should see the date expiry column
You should tell to use the "Check out" form.
To not mistake with "Search patrons" form.

Column name is 'Date expiry'.
We see in patrons module the name 'Expires on'.
I propose we use the same name.

There is an issue, column sorting is not on date (if you don't use the ISO
format).
This is because formatting is done in perl code :
https://git.koha-community.org/Koha-community/Koha/src/commit/870e3e8e161f6da998c1deae216d7fdf0d0490e7/C4/Utils/DataTables/Members.pm#L222
See the FIXME.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:18:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:18:54 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-fawo4siGO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15812

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:18:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:18:54 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-r5rg2z617f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29104

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:20:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:20:32 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-j52basEMSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Oh see that this will be obsolete if Bug 15812 is pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:35:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:35:02 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-Hh2bBecHZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:35:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:35:07 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-GDjvkcGxqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125188|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125299&action=edit
Bug 29091: Correct display of lists and tags on search results

This patch makes a minor change to CSS to fix the display of tags and
lists on the OPAC search results page so that the list doesn't have
extra padding.

To test, apply the patch and rebuild the OPAC SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- To test you should be able to perform a catalog search in the OPAC
  which will return results which have one or more tags and which are on
  one or more lists.
- In the OPAC search results, confirm that there isn't extra padding
  between the "Tags:" and "Lists:" labels and their values.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:36:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:36:44 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-zeFM67ZZAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I've also tested display in lists.
"Tags:" diplay is corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:39:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:39:12 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-Si3KfhPfNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #19 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Hi :)

I'm not working on this anymore but since I did a rebase in the past, here is
another one.

The test plan of Olivier has been integrated with the requested changes(comment
13)

It has not been tested, I'm just solving conflicts :P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:39:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:39:53 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-uqlBzKKzv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:49:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:49:53 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-JL4baoPvTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Also, there are been some changes in Koha that require consideration:
issues.branchcode was moved from the bulk of the SQL query to just after in an
«if($owning_library)»

https://git.koha-community.org/Koha-community/Koha/src/commit/9d6d641d1f8b77271800f43bc027b651f9aea52b/misc/cronjobs/overdue_notices.pl#L492

This patch historically removed issues.branchcode from the bulk of the SQL
query to have instead «AND issues.branchcode = ?" unless $all_in_one;»

So maybe these two aren't compatible as it is.

Still worth testing the current patch to maybe expose that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:50:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:50:10 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-Ev6pMmKC9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Nice change, I test it.

> For a search with many results, you are redirected to the patron search results and there is a 'Checkout' button under the cardnumber
I see this also when searching via 'Seach patrons' form.
And looks like permission check is needed there right ?

In my opinion this button should be with 'Edit' in actions column.
When searching for patron one can assume cardnumber is unknown so button being
next to it is not really useful.
Note than cardnumber column may be hidden.

Patron may be identified by name so when clicking on it we may go to
circulation page.

Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Sep 24 22:58:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 20:58:17 +0000
Subject: [Koha-bugs] [Bug 29077] Warns when searching blank index
In-Reply-To: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29077-70-xsWLNssObT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
  @indexes = grep(/.+/, @indexes)

This is correct, but in actual code we see much more occurrences of :
  grep { $_ ne q{} } @array

In my opinion it is better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 01:32:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Sep 2021 23:32:20 +0000
Subject: [Koha-bugs] [Bug 29101] unable to enter 020 and 024 tag fields
 other than blank
In-Reply-To: <bug-29101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29101-70-iHDxF86t4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29101

Courtenay Johnson <courtenay.johnson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |WONTFIX

--- Comment #2 from Courtenay Johnson <courtenay.johnson at gmail.com> ---
Problem resolved. Update to 21.05 reported problem as error 500. Found by
examining log and the file it pointed to the problems that the tag specified in
the framework should be 020, and not 20. Ditto for tag 24 in the framework
should be 024.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 06:28:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 04:28:38 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-m0XE7gCRWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Applying: Bug 28321: Use template block for display of items in search results
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
M       koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
Falling back to patching base and 3-way merge...
Removing koha-tmpl/intranet-tmpl/prog/img/item-bullet.gif
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
error: Failed to merge in the changes.
Patch failed at 0001 Bug 28321: Use template block for display of items in
search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 06:28:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 04:28:54 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-CAKZpTsBmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:42:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:42:40 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-VnJ3HIkuZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124935|0                           |1
        is obsolete|                            |

--- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125300&action=edit
Bug 24223: Convert OpacNav system preference to additional content

This patch builds on Bug 22318 to move the OpacNav system
preference into the "Additional contents" system, making it possible to
have language- and library-specific content.

To test you should have some content in the OpacNav system
preference. To make testing easier it's also a good idea to have content
in the OpacNavBottom preference.

 - Apply the patch and run the database update process.
 - In the staff client, go to Tools -> HTML customizations and verify
   that the content from OpacNav is now stored there. When you
   edit the entry you should see content for each of the enabled
   translations in your system under each tab.
   - Confirm that the previous contents of OpacNav were added
     correctly.
 - Go to Administration -> System preferences -> OPAC and verify that
   the OpacNav preference has been removed.
 - Update and reinstall active translations (for instance fr-FR):
   - cd misc/translator/
   - perl translate update fr-FR
   - perl translate install fr-FR
 - View the OPAC and confirm that the contents of the OpacNav system
   preference displays in the left-hand sidebar.
 - Test as many pages as possible to confirm that wherever the
   OpacNavBottom content is displayed, OpacNav is also displayed.
 - Test also using the updated translation.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:42:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:42:56 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-QMTEsH9gc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124936|0                           |1
        is obsolete|                            |

--- Comment #29 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125301&action=edit
Bug 24223: (follow-up) Add date to OpacNav additional content entries

This follow-up modifies the atomic update so that it inserts today's
date as the "Published on" date. Without that information the system
considers the item unpublished and will not display the content.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:43:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:43:14 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-5XpNNxSkic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124937|0                           |1
        is obsolete|                            |

--- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125302&action=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template

This patch makes a couple of corrections for problems I discovered
while working on Bug 24224: The variables required for correct display
of news items by branch and language were not consistently available to
the templates.

In opac-readingrecord.pl, the "lang" variable was being overwritten. On
this and other pages the logged-in patron's brachcode was not made
available. I've corrected instances of KohaNews.get() to use the
globally-available "logged_in_user.branchcode" instead.

To test, apply the patch and follow the original test plan, with the
addition of instances of the OpacNav additional contents item which
have a specific library selected.

Confirm that such items are correctly displayed according to the
logged-in user's home library. If there is no logged-in user the
library-specific OpacNav should not display.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:43:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:43:30 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-hZbKIyuH9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124938|0                           |1
        is obsolete|                            |

--- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125303&action=edit
Bug 24223: (follow-up) Updates to conform to new practices

- The patch now works with new "Additional contents" system
- The database update follows new skeleton.pl
- Add "OpacNav" option to the additional contents template

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:43:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:43:47 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-KKchcBBTUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

--- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125304&action=edit
Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc

Id attribut will be defined by 'koha_news_block'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 08:46:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 06:46:50 +0000
Subject: [Koha-bugs] [Bug 24223] Convert OpacNav system preference to news
 block
In-Reply-To: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24223-70-iPQdQj0jxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #33 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I signed existing patches.

But also added one :
  Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc

Like in Bug 28927, no need anymore to create a div with id 'opacnav' :
it will generate a div with id="opacnav" and one inside with id="OpacNav".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 11:37:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 09:37:15 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-Z63LxHfdZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 11:37:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 09:37:19 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-iadjwfu9vb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125255|0                           |1
        is obsolete|                            |

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125305&action=edit
Bug 29056: Remove the demo functionality leftovers

Remove forgotten code of the old legacy demo functionality that was
removed from elsewhere except systempreferences, this code not only
serves no purpose but also is causing some troubles for our customers.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 11:39:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 09:39:25 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-BAN8JzdK6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Passing QA.

@nugged: I wonder how you were able to get C4::Context->config return an empty
hash, it seems like somehow somewhere that code didn't manage to find a
configuration file or there is a bug in the C4::Context code. Would love to
hear more about this in case it turns out to be a bug in C4::Context.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 11:40:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 09:40:31 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-asU1k8FjKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 12:29:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 10:29:24 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-crcqPBxtT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
In case anybody else is testing this I was bit confused why i couldn't
reproduce the problem at first: turns out we are missing
HoldsSplitQueueNumbering from the installer/data/mysql/mandatory/sysprefs.sql
file, so on fresh install the bug doesn't happen because we are using the
virtual mechanism if none is specified (even though if you go to the
systempreferences menu it shows actual).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 12:56:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 10:56:25 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-YbiZmUf5y4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:01:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:01:11 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-b1KdVDgnKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
This causes the following warning:

> Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc line 47.

Let me see if I can come up with a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:23 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-egyw0nptBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:27 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-3XbnuQTeX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125067|0                           |1
        is obsolete|                            |
 Attachment #125068|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125306&action=edit
Bug 29049: Simplify holds priority dropdown logic on request.pl

This patch makes a few changes:
1 - If we are not splitting the queue ( HoldsSplitQueue == 'nothing' ) then
    there are no changes for 'virtual' vs 'actual' numbering
2 - If we are splitting the queue you cannot use the dropdown, so we do not
need to process the options
3 - If the hold is 'found' we do not need to process the options
4 - We can simply use the 'last priority' to build the options, we do not need
to process in the script
5 - We can use a block to build the options
6 - Remove a stray holds.index

To test:
 1 - Place 5 holds on a bib
 2 - 'Find' two of the holds i.e. check them in to set status to 'transit' or
'waiting'
 3 - View the holds page for the biblio
 4 - Inspect the priorty dropdown for the found holds, note they have options
for 1-5 but are disabled
 5 - Note the dropdowns for other holds have options 1-5
 6 - Note options 4&5 in the dropdowns have no effect
 7 - Apply patch
 8 - Inspect the priority dopdowns on the found holds
 9 - Note they only show their found status
10 - Note the other dropdowns only show options 1-3
11 - Test with other HoldsSplitQueue options and HoldsSplitQueueNumbering
12 - When holds queue is split, no dropdowns should be active and should show
only their current priority
13 - When  HoldsSplitQueueNumbering is 'virtual' the dropdown should be
disabled and correctly count the number of unfound holds in the list

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
JK: Fixed grammar in commit title
Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:31 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-izR2qri5Wo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125307&action=edit
Bug 29049: (follow-up) Reduce number of line returns in page

While moving the dropdown to a block, I noticed the page size was very large
when there are many holds

This patch chomps a large amoutn of whitespace, from the block and elsewhere
and drecreased the paeg from about 400k lines to 25k lines for a record with
~200 holds

To test:
1 - Apply previous patch
2 - Load holds tab for a biblio
3 - Save the page as html from your browser, note the size of the file
4 - Apply patch this
5 - Reload and repeat
6 - Note the size is much smaller

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:35 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-w66jrQUH1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125308&action=edit
Bug 29049: (QA follow-up) Remove unused variable

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:39 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-VNhNwX518i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125309&action=edit
Bug 29049: (QA follow-up) Remove excessive whitespace

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Sep 25 13:17:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Sep 2021 11:17:43 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-4upVASN80y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125310&action=edit
Bug 29049: (QA follow-up) Initialize uninitialized variable to prevent warning

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 09:04:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 07:04:16 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-o1mQO2e2k6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

--- Comment #9 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
The indicator code was not handled here but on a closer look it seems unused,
and for some reason the same indicator code is copied all over Koha codebase
unused as well. I will open a separate ticket to remove the indicator related
code with items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 09:18:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 07:18:21 +0000
Subject: [Koha-bugs] [Bug 28832] Batch modification always clears
 permanent_location if it is mapped in frameworks
In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28832-70-hSw6MvGZzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
After applying the patches modifying the item fields to values that evaluate in
perl to false is impossible. The conditions in 

> unless( $values[$i] || $searches[$i] || grep { $subfields[$i] } @disabled ){

should be the same as just above it, i.e. if the value is empty string or not.

To reproduce:
 1) Try to change inventory field to 0 and notice it is not modified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 09:24:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 07:24:48 +0000
Subject: [Koha-bugs] [Bug 29111] New: Unused code to handle indicators in
 many item modification scripts
Message-ID: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

            Bug ID: 29111
           Summary: Unused code to handle indicators in many item
                    modification scripts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org

At a quick glance it looks like Koha doesn't support placing indicators to the
item field (952) but we have code for doing that in the .pl scripts, for
example in:

tools/batchMod.pl
cataloguing/additem.pl
acqui/addorderiso2709.pl

Please search for "indicator" and "ind_tag" in these files to locate the unused
code. For cataloguing/additem.pl it is clear the code is unused because it is
hard coded in the .tt (template toolkit) file that the indicator values are
always " " / empty.

This code should be removed so we are not unnecessarily spending time doing
modifications relating to this part of code to keep it "working" (bug
28832...).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:00:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:00:42 +0000
Subject: [Koha-bugs] [Bug 29111] Unused code to handle indicators in many
 item modification scripts
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-1bgSyryn26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:15:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:15:44 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-q4neC0qphu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unused code to handle       |Remove dead code from
                   |indicators in many item     |intranet
                   |modification scripts        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:21:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:21:56 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-ZHWjpkfiph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:21:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:21:58 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-XCoou4coDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125311&action=edit
Bug 29111: Remove dead code from acqui/addorderiso2709.pl

Test plan:
 1) open acqui/addorderiso2709.pl in your code editor and make sure
 nothing references $item in the if block where it was removed from

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:22:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:22:01 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-NauSt62xII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125312&action=edit
Bug 29111: Remove unused indicator modification code for items

The indicator value for 952 was hard coded in every case to " ". In
order to achieve that we can simply pass undef to TransformHtmlToXml()
and it will set the indicator values to " ".

To test:
 1) Make sure the submission of (at least some) the modified files
 still work, e.g. test that making a new item via
 cataloguing/additem.pl works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:22:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:22:05 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-2PMeB3mRfr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125313&action=edit
Bug 29111: Remove unused function from cataloguing/additem.pl

To test:
 1) Open cataloguing/additem.pl and search for any usages of
 find_value, you should find 0 usages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:22:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:22:46 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-FudD8OgZ6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
There was some additional dead code around the indicator values so those are
removed here as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:23:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:23:07 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-Gar3uKu9fA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 10:28:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 08:28:00 +0000
Subject: [Koha-bugs] [Bug 29111] Remove dead code from intranet
In-Reply-To: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29111-70-KF8mam6qLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:48:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:48:29 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-9AatSp8uCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:48:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:48:35 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-vTYOwPePdT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125177|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125314&action=edit
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC

This patch makes modifications to OPAC templates to make the Google
login options more consistent.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- In the staff interface, enable the GoogleOpenIDConnect preference, and
  populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with
  values (they don't need to be valid).
- On the OPAC main page you should see a "Log in with Google" button
  above the Koha login form.
- If you click the "Log in to your account" link at the top of the page
  you should see a "Log in with Google" button in the modal window
- If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged
  in you should see the same "Log in with Google" button on that page.
- In each case the Google button should point to
/cgi-bin/koha/svc/auth/googleopenidconnect
- If you disable GoogleOpenIDConnect the buttons should disappear.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:49:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:49:27 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-ec01wshOzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:53:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:53:10 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-9i1saV43mk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:53:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:53:13 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-uJjzCpqQPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125139|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125315&action=edit
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings
title

We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC
messaging preferences title, so it's dead code.

This patch removes the useless duplicate if-statement.

To test:
1. Enable EnhancedMessagingPreferencesOPAC system preference
2. Go to /cgi-bin/koha/opac-messaging.pl
3. Observe title Your messaging settings > Koha online catalog
4. Apply patch
5. Refresh page /cgi-bin/koha/opac-messaging.pl
6. Observe same title Your messaging settings > Koha online catalog
7. See patch content
8. Confirm there are no functional changes in the new logic

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 12:59:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 10:59:05 +0000
Subject: [Koha-bugs] [Bug 29112] New: Module navigation sidebars in staff
 now show bullet points
Message-ID: <bug-29112-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112

            Bug ID: 29112
           Summary: Module navigation sidebars in staff now show bullet
                    points
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Not sure if this was an intentional change after all, but I noticed that on
master the navigation sidebars (tools or administration for examples) now show
bullet points before each link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:00:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:00:50 +0000
Subject: [Koha-bugs] [Bug 29112] Module navigation sidebars in staff now
 show bullet points
In-Reply-To: <bug-29112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29112-70-41UchiPlIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In earlier versions instead of the standard bullet point a custom image with a
small arrow was used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:02:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:02:12 +0000
Subject: [Koha-bugs] [Bug 29112] Module navigation sidebars in staff now
 show bullet points
In-Reply-To: <bug-29112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29112-70-HpgQLG2kDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The image link appears now to be broken, but it's still in the code - so I
guess this was not inentional after all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:03:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:03:18 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-LlvokRJ894@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:03:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:03:23 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-zVdjVmU606@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125073|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125316&action=edit
Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link
in reports

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:03:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:03:27 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-Aqj9tJ6ATQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125074|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125317&action=edit
Bug 28454: (follow-up) Add missing filters

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:08:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:08:47 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-os0G8DjrJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the hierarchy in this new link:

Home > Tools > Additional contents > HTML customizations > Add additional
content 

I think it would be nice to make the start page of the tools the same instead
of having the HTML or news part in ():

Homen > Tools > Additional contents (HTML customizations) 

Could we make the change there as well for more consistency?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:15:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:15:23 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-8QPbArIvn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124817|0                           |1
        is obsolete|                            |
 Attachment #124818|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125318&action=edit
Bug 28988: Reindent calendar template

This patch performs general template cleanup to the calendar template:
Make indentation consistent and trim trailing whitespace.

To test, apply the patch and go to Tools -> Calendar.

The page should look correct and work correctly. If you view the diff
while ignoring whitespace the only changes should be where line breaks
were introduced.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:15:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:15:27 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-xR6wNpZDEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125319&action=edit
Bug 28988: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

https://bugs.koha-community.org/show_bug.cgi?id=28988

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:16:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:16:19 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-LrAzDnNKCB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fixed the bug number on the follow-up patch.

Something spotted while testing: we have a really heavy grey border around the
options for adding/editing a calendar entry that doesn't quite fit with the
background.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:16:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:16:49 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-40N9X9FSnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:17:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:17:36 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-o2qqSdJYvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:48:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:48:50 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-kkFhkYc6sg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:48:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:48:53 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-kWO9LJ3kdq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124843|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125320&action=edit
Bug 28940: In spinelabel-print.tt call IntranetUserJS only once

1. In IntranetUser add some JS that will target spinelabel-print.tt, I used
this:
    if ( $('#labels_spinelabel-print').length ) {
      $('#labels_spinelabel-print').append('<div>TEST</div>');
      console.log('TEST');
    }
2. Generate a quick spine label
3. Once you have entered a barcode the JS will go off 2x. With the jQuery added
you will see 2 div's with the word 'TEST'. Look at the console and you will
also see TEST console logged 2x.
4. Apply patch
5. Try seto 2 and 3 again, the JS should only be called once.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:52:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:52:45 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-j1fmpisp0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 13:52:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 11:52:49 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-XAq8TPWR64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124436|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125321&action=edit
Bug 28933: Add subscription class to each subscription in opac-detail

To Test:
1. Go to a record with some subscriptions, have some closed and some
   open.
2. Go to the opac-detail page, click on the subscription tab and use
   your developer tools to inscept the element.
3. Notice the hierarchy of HTML structure, everything is a sibling of
   the next.
4. Apply patch
5. Reload the same opac-detail page and again inscept the element.
6. Now every individual subscription should be wrapped in an element
   with the class name of 'subscription'.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:34:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:34:33 +0000
Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery
 preferences when scheduling
In-Reply-To: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26544-70-9SihzlL32A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:34:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:34:38 +0000
Subject: [Koha-bugs] [Bug 26544] Housebound module should show delivery
 preferences when scheduling
In-Reply-To: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26544-70-nMxPzXB7dT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124432|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125322&action=edit
Bug 26544: Add housebound details to delivery page

To test:
1. Turn on the housebound module
2. go to the housebound for a given patron
/cgi-bin/koha/members/housebound.pl?borrowernumber=X
3. add some housebound details, fill out all the fields
4. Go to 'Add a new delivery'
5. No housebound details, hard to know what the patron likes or days to
deliver!
6. apply patch
7. Go to 'Add a delivery'
8. See the housebound details, yay! All the line breaks should be preserved.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:40:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:40:04 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-RaQyJKIdUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:40:08 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-B3gNJC7h9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124465|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125323&action=edit
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis at dataly.gr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:43:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:43:05 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-BqSHOtp7wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:43:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:43:08 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-RJRwAoU2OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125141|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125324&action=edit
Bug 29035: Accessibility: OPAC masthead_search label doesn't have sufficient
contrast ratio

This patch changes the colour of the masthead
search label to improve accessibility and make it
easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to test the contrast ratio.
2. Confirm that the search label has insufficient
   contrast.
3. Apply the patch and rebuild the OPAC CSS:
   yarn build --view opac
4. Use the accessibility tool to confirm the
   contrast ratio now meets accessibility
   requirements.
5. Check that the OPAC still looks ok after
   the changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:46:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:46:46 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-yUdkwcYtxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:46:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:46:49 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-IUCLlks8Dt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125136|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125325&action=edit
Bug 29070: Accessibility OPAC Purchase suggestions box on search results page
has insufficient contrast

This patch changes the text colour for the purchase
suggestion box on the OPAC search results page to
make the text easier to read and improve accessibility.

To test:

1. Log in to the OPAC and search for something
2. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast ratio
3. Confirm that the Purchase suggestion text
   fails to meet accessibility requirements
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Confirm the text contrast ratio now meets
   minimum accessibility requirements
6. Check that the OPAC still looks ok after
   the changes.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:49:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:49:45 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-URmZ0E1HJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:49:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:49:49 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-1ep9XBYuzL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125094|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125326&action=edit
Bug 29038: Accessibility OPACUserSummary heading doesn't have sufficient
contrast

This patch changes the colour of the OPAC User Summary heading text to
increase the contrast ratio, improving accessibility and making the
text easier to read.

To test:

1. Log in to the OPAC homepage as a user with items checked out
2. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the
   contrast ratio.
3. Confirm the UserSummary heading has insufficient contrast.
4. Apply the patch and rebuild css:
   yarn build --view opac
5. Use the accessibility tool to confirm the contrast ratio now meets
   accessibility requirements
6. Check that the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:54:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:54:48 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-6SmWgo8c8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 14:54:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 12:54:52 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-u3Q6vTFeQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124919|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125327&action=edit
Bug 29034: Accessibility: OPAC nav links don't have sufficient contrast ratio

This patch changes the colour of the navigation
links on the OPAC (Cart, Lists etc.) to improve
the contrast ration and make them easier to read.

To test:
1. Use an accessibility tool (e.g. Chrome's
   Lighthouse tool) to check the contrast
   ratio on the OPAC
2. Confirm that the navigation links have
   insufficient contrast
3. Apply the patch and rebuild the OPAC css:
   yarn build --view opac
4. Use the accessibility tool to confirm
   the contrast ratio meets  the minimum
   accessibility requirements
5. Check that the OPAC looks ok after the
   changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:01:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:01:56 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-X7NVJ6niH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:02:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:02:01 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-GYC216g07v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125092|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125328&action=edit
Bug 29068: Accessibility OPAC search results summary text has insufficient
contrast

This patch changes the colour of the label text in
OPAC search results to increase the contrast ratio,
improve accessibility and make the text easier to read.

To test:

1. Search for something on the OPAC
2. Use an accessibility tool (e.g. Chrome's Lighthouse
   tool) to check the contrast ratio
3. Confirm that the labels (Edition, Format etc.) in the
   results summary have insufficient contrast
4. Apply the patch and rebuild CSS:
   yarn build --view opac
5. Use the accessibility tool to confirm the contrast
   ratio now meets minimum accessibility requirements
6. Check that the OPAC still looks ok after the changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:06:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:06:33 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-jJxaWM9fJ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:06:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:06:37 +0000
Subject: [Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to
 make it clear that it is OPAC-only
In-Reply-To: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29004-70-oGMjS7H8Se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125122|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125329&action=edit
Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is
OPAC-only

This patch modifies the description of the GoogleOpenIDConnect and
related preferences to make it clear that GoogleOpenIDConnect affects
OPAC logins and that the preferences are related.

To test, apply the patch and go to Administration -> System preferences.

Search for "google," and confirm that the descriptions of
GoogleOpenIDConnect and related preferences look clear and correct.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:07:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:07:15 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-fjQVHGzjT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:07:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:07:25 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-xuziamrRDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:10:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:10:43 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-2VKKX8D3Ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:10:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:10:47 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-nA3rFBtqXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125056|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125330&action=edit
Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history"

Caused by
  commit 61a39b0dd52df4f6d743671823449e265d6add26
  Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor
names

- [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %]

+ [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %]

It must have been patron=checkout.issuer as patron-title.inc is
expecting a Koha::Patron object, not a borrowernumber.

Test plan:
Turn RecordStaffUserOnCheckout on
Check an item out then in
Go to the biblio checkout history and confirm that the "Checked out by"
column contains the logged in librarian's name.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:16:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:16:51 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-9jEBuwi5Vx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:16:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:16:54 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-vqxjouaiFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124790|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125331&action=edit
Bug 28821: (follow-up) Improve operation of button plus/less

Follow-up for bug 28784.

Do not remove the op select on the first row.
Allow plus/less on all lines. Allow less until we have one line left.
Make sure that first op is disabled and hidden with plus/less.

Test plan:
Search on multiple indexes on advanced search.
Verify that plus/minus works as expected.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:26:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:26:59 +0000
Subject: [Koha-bugs] [Bug 29113] New: Requires code field for additional
 contents appears unnecessary
Message-ID: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

            Bug ID: 29113
           Summary: Requires code field for additional contents appears
                    unnecessary
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When adding a HTML customization there is now a new required "Code" field that
has to be filled in.

Is this really necessary?

* The old news editor didn't require this additional field.
* None of the HTML customizations is repeatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:27:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:27:37 +0000
Subject: [Koha-bugs] [Bug 29113] Requires code field for additional contents
 appears unnecessary
In-Reply-To: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29113-70-6257shWI59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
* The code doesn't show in the list of entries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:27:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:27:53 +0000
Subject: [Koha-bugs] [Bug 29113] Required new "code" field for additional
 contents appears unnecessary
In-Reply-To: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29113-70-QdwBvlxxpr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Requires code field for     |Required new "code" field
                   |additional contents appears |for additional contents
                   |unnecessary                 |appears unnecessary

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:30:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:30:17 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-Ag7JLEfbre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:30:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:30:21 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-hQUrtXeMGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125137|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125332&action=edit
Bug 28927: Fix id opacmainuserblock used twice in OPAC

Since preference OpacMainUserBlock is now an HTML customization,
there is actually an HTML tags with id="opacmainuserblock" and one with
id="OpacMainUserBlock".
Same for OPACNavRight in opac-registration-confirmation.tt

This patch removed id from page to keep the one comming from HTML customization
include.

Test plan :
1) Create an HTML customization for OpacMainUserBlock with some text
2) Go to OPAC main page
3) Check HTML code of the page
4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock"
5) Same for id="opacnavright" in opac-registration-confirmation.tt

https://bugs.koha-community.org/show_bug.cgi?id=28927

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:30:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:30:26 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-QaKBsWSIhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125138|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125333&action=edit
Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS

Actually this rule does nothing, it defines same background color as "body" :
#fcf9fc

Test plan :
1) Without patch look at OPAC header
2) With patch OPAC header should have same background color

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:39:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:39:14 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-fjmXSOnhCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:39:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:39:18 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-ZzETfB64oa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125123|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125334&action=edit
Bug 28934: Make the OPAC registration form design consistent

The gender/sex and GDPR inputs were slightly misaligned (by
1.5em). Now they are aligned with the other inputs which have a width
of 10em (9em width + margin 1em). The label assignments and required
attributes for input elements are made also consistent.

To test:
 1) Enable GDPR_Policy syspref
 2) Apply patch, run "yarn build --view opac", restart plack
 3) Go to /cgi-bin/koha/opac-memberentry.pl
 4) Check that the GDPR input box shows the required text now in red
    color
 5) Check that the alignment of sex/gender and GDPR input matches with
    the other inputs perfectly.

Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:49:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:49:59 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-1qcLHPzql6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:50:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:50:03 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-UClm8LzslE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125299|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125335&action=edit
Bug 29091: Correct display of lists and tags on search results

This patch makes a minor change to CSS to fix the display of tags and
lists on the OPAC search results page so that the list doesn't have
extra padding.

To test, apply the patch and rebuild the OPAC SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- To test you should be able to perform a catalog search in the OPAC
  which will return results which have one or more tags and which are on
  one or more lists.
- In the OPAC search results, confirm that there isn't extra padding
  between the "Tags:" and "Lists:" labels and their values.

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:50:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:50:44 +0000
Subject: [Koha-bugs] [Bug 28303] Having multiple pluginsdir causes
 plugin_upload to try to write to the opac-tmpl folder
In-Reply-To: <bug-28303-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28303-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28303-70-Rw8Q7FWflj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:54:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:54:42 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-kSca1qeKvz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for the fix Didier, we just recently noticed that this problem was back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:55:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:55:24 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-h9fZQSpSSn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 15:55:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 13:55:28 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-a4MkaGjlqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124889|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125336&action=edit
Bug 29025: Don't prefill userid and password in user creation form

Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:02:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:02:57 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-jFW5acEsKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, I tried "restart_all" multiple times, but the pull downs remain
empty.

I am using the admin user (42), logged in at Centerville.

When placing a single hold, Centerville is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:03:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:03:05 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-SiBPNhoq01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:05:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:05:18 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-VIp6daIlVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:17:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:17:28 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-9hoBKNC6eu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:17:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:17:33 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-cTsgGRaJ9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124920|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125337&action=edit
Bug 29030: Make authorized value and description fields required

This patch modifies the markup of the "Create a new authorized value"
modal so that a minimum set of fields is required: Authorized value and
description.

The patch also modifies the JavaScript which handles the submission so
that the jQuery Validation plugin can handle the field checks.

The spelling "authorised" is changed to "authorized" following coding
guidelines.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Locate a record in the catalog which has items and open an item for
  editing.
- In the add item form, test the process of adding an authorized
  value on the fly with the following fields: Withdrawn, Lost,
  Damaged, Use restrictions, Not for loan, Collection code, Shelving
  location, and Shelving control number.
  - In each case you should be able to type a new value in the
    dropdown's search box and be shown the option "Select to create."
  - Selecting should trigger a modal window, "Create a new authorized
    value."
  - Test that both "Authorized value" and "Description" fields are
    required, and the form can't be submitted without them.
  - Test that an error message shows up when you submit an authorized
    value which already exists, e.g. authval "1" for "DAMAGED."
  - After triggering this error, click the "Cancel" button and try
    creating another new authorized value. When the modal reopens the
    form should be reset: No previously-entered data, no error messages.
  - Submitting a valid form with a new authorized value should work
    correctly. The modal window should close automatically.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:23:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:23:19 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-g7EfPwS6Tl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:23:22 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-qkEa1MIHyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124884|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125338&action=edit
Bug 29026: Restore behavior when an empty barcode field is submitted in
circulation

When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty
barcode field is submitted in circulation :

Before Bug 17845, behavior was to display empty circulation page (no patron
selected).
Now behavior is displaying the circulation page of current patron.

I think previous behavior was used when scanner is used to clear form and wait
for another patron card to be scanned.

Test plan :
1) Set system preference CircAutoPrintQuickSlip to 'clear the screen'
2) Go to a patron circulation page
3) Post form without a barcode
=> Check you go to circulation page with no patron selected
4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip
window'
5) Go to a patron circulation page
6) Post form without a barcode
=> Check you go to print quick slip window with correct datas

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:23:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:23:40 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-AFLE7N6LEq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Good catch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:29:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:29:50 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-2ZWz4ZmuNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 16:29:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 14:29:54 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-zysCELu4bv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125278|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 125339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125339&action=edit
Bug 29019: Unable to delete HTML customization

This patch makes some corrections to additional contents to allow
content to be deleted. The wrong parameter was being passed to the
script. The script was also not handling multiple deletions correctly.

The patch also adds a "category" parameter to the delete operation so
that the page is redirected correctly.

The patch also changes some strings which referred to "news"
referencing operations which might be performed on news or on HTML
customizations, e.g.:

"Are you sure you want to delete the selected content?" instead of "Are
you sure you want to delete the selected news?"

To test, apply the patch and go to Tools -> News.

- Create multiple news items if necessary.
- Test the "Delete" button corresponding to a single news item:
  - Clicking the button should ask you to confirm.
  - Check that the wording of the message is correct.
  - After confirming the news item should be deleted.
  - Ideally, test on news items which are on the second page of the
    DataTable of news items.
- Test the process of deleting multiple news items at once:
  - Check the checkbox next to multiple items.
  - Click the "Delete selected" button at the bottom of the page.
  - Check that the wording of the confirmation message is correct.
  - After you confirm, the items should be deleted.
- Repeat these tests under Tools -> HTML customizations to confirm that
  redirects work correctly. After deleting an HTML customization you
  should be redirected back to the list of HTML customizations.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:00:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:00:50 +0000
Subject: [Koha-bugs] [Bug 29114] New: Can not add barcodes with whitespaces
 at the beginning to the list
Message-ID: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

            Bug ID: 29114
           Summary: Can not add barcodes with whitespaces at the beginning
                    to the list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andriiverem at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When you try to add a barcode that has any whitespaces before it, it is not
recognized as a valid item.

Steps to reproduce:
1. Go to the koha/virtualshelves/shelves.pl;
2. Add new list or edit existing one;
3. Start adding new items;
4. In the "Barcode" field add barcode(s) with whitespaces before them;
5. Observe that it wasn't added as the barcode isn't recognized because of
whitespaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:25:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:25:26 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-OyVdsPx1AB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Andrii Veremeienko <andriiverem at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andriiverem at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:36:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:36:24 +0000
Subject: [Koha-bugs] [Bug 29115] New: Placing a club hold is not showing
 warnings when unable to place a hold
Message-ID: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

            Bug ID: 29115
           Summary: Placing a club hold is not showing warnings when
                    unable to place a hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The code that is supposed to show warnings if someone in a club cannot reserve
the item when placing a club hold is broken and not showing the warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:36:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:36:36 +0000
Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings
 when unable to place a hold
In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29115-70-FmqcVB40D3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:51:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:51:20 +0000
Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings
 when unable to place a hold
In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29115-70-Ego9PXkBPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:51:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:51:23 +0000
Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings
 when unable to place a hold
In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29115-70-PzvsLZJDMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125340&action=edit
Bug 29115: Fix syntax errors in club hold functionality

The code didn't previously correctly do the checks for patron
debarment status and whether the patron has fees, this caused the
intended warnings messages to not appear when they should have.

To test:
 1) Create a new club and add a patron to it who has manual debarment
    and a manual charge of over $5 (more than the maxoutstanding syspref).
 2) Try to create a new club hold for the previously created club and
    notice no warnings are listed for the patron.
 3) Apply patch
 4) Try to create now the club hold again and notice the warnings
    being shown in the hold page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 17:58:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 15:58:51 +0000
Subject: [Koha-bugs] [Bug 25454] When placing holds for clubs there should
 be an alert if a hold is not placed for a club member
In-Reply-To: <bug-25454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25454-70-xUpnBXeTV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25454

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Bug 29115 should alleviate this problem a tiny bit but I think we would have to
get the answer after placing the request how many succeeded as the situation
might change after the hold request page load.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 18:09:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 16:09:07 +0000
Subject: [Koha-bugs] [Bug 29116] New: request.pl re-invents
 Koha::Patron::is_expired accessor
Message-ID: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

            Bug ID: 29116
           Summary: request.pl re-invents Koha::Patron::is_expired
                    accessor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

reserve/request.pl duplicates the same code as what Koha::Patron::is_expired
does, the code should be deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 18:15:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 16:15:54 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-zHARrqx7uK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 18:15:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 16:15:57 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-B5jGvZ9J15@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125341&action=edit
Bug 29116: Use a pre-existing accessor instead of reimplementing it

We can use the Koha::Patron::is_expired accessor instead of re-writing
it in request.pl.

To test:
 1) Make that a warning is being shown with and without this patch
    when placing a hold to an expired patron account

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 18:17:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 16:17:13 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-gFQPsBgnIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:00:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:00:41 +0000
Subject: [Koha-bugs] [Bug 29117] New: Placing a multi-club-hold is not
 possible
Message-ID: <bug-29117-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29117

            Bug ID: 29117
           Summary: Placing a multi-club-hold is not possible
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If you try to create a club hold for many biblios using the multi-hold feature
by selecting many biblios for hold from the search results it doesn't work, you
always get the message "No items are available to be placed on hold"

To reproduce, create a new club with a patron and then try to place a multi
hold for a club from the catalogue search results. Or if you have kohadevbox
you can open this url directly:

http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248/233

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:03:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:03:03 +0000
Subject: [Koha-bugs] [Bug 29117] Placing a multi-club-hold is not possible
In-Reply-To: <bug-29117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29117-70-GqLrt9g1qG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29117

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:22:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:22:28 +0000
Subject: [Koha-bugs] [Bug 29043] Items are prcoessed but not displayed on
 request.pl before a patron is selected
In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29043-70-HGW4GYkDnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
I think this makes the code harder to understand by adding one more indentation
layer to the giant loop. Could I propose that in this outer loop "foreach my
$biblionumber (@biblionumbers) {" all the non-patron requiring code comes first
and calls next unless we have a $patron? This way we we are not adding in all
the different places calls to if ($patron) but only in one place. This would
help also to make the multi-holds work for clubs – bug 29117.

If anyhow other people think it is okay to go with the patch here then "my
$items_any_available;" and the comment above it should be inside the loop as
well, and probably the outer loop should also actually be in this if condition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:23:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:23:57 +0000
Subject: [Koha-bugs] [Bug 29118] New: Basic editor for new entry or editing
 records drops fields that contains any UTF-8 character
Message-ID: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29118

            Bug ID: 29118
           Summary: Basic editor for new entry or editing records drops
                    fields that contains any UTF-8 character
 Change sponsored?: ---
           Product: Koha
           Version: 20.05
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: courtenay.johnson at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When using the basic editor for cataloging, entry of new records, fields that
contain UTF-8 are silent ignored when saved. When that record is reviewed the
field that had contained one of more UTF-8 character is now blank.
When an item for that record is entered, fields that contain UTF-8 work fine.
A clue may be that when a new record is created, or changed with some UTF-8 in
the title field 245a, the field appears to be blank, and if the save button is
hit again without making any changes, there is a complaint “Can’t save this
record because the following field aren’t filled, tag 245 subfield a Title in
tab 0” that you can’t save with a blank title field. However the display of the
record that shows the tile and the record number shows the title correctly
including the UTF-8 characters exactly as typed in the title.
This problem occurs in Koha 18.11 and 21.05. Both are running on Ubuntu 18.11
and now on 20.04.3 LTS.

I have tested that mysql tables will accept input from a mysql prompt in UTF-8,
and displays it correctly in a query.
 Have tested that a short HTML file can be read by Apach2 and displays
correctly.
I have tested that Ubuntu’s locale is set to support UTF-8, by running the
locale command.
I am using Koha in Canada, using English. 
I tried the advanced editor option. There was no change when I edited the same
record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:46:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:46:59 +0000
Subject: [Koha-bugs] [Bug 29118] Basic editor for new entry or editing
 records drops fields that contains any UTF-8 character
In-Reply-To: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29118-70-WQEsOl5f6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29118

--- Comment #1 from Courtenay Johnson <courtenay.johnson at gmail.com> ---
Created attachment 125342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125342&action=edit
log from entering a field with UTF-8

The log contents after 1 try to enter a value in record with field 245,a
containing several UTF-8 charcaters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 19:55:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 17:55:56 +0000
Subject: [Koha-bugs] [Bug 28167] A warning when setting which library to use
 in intranet and UseCashRegisters is disabled
In-Reply-To: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28167-70-KsxlUYEuD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28167

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi
                   |ity.org                     |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:09:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:09:18 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-FBKFhVaHk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #44 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Martin Renvoize from comment #41)
> Created attachment 125115 [details] [review]
> Bug 28803: (QA follow-up) Reinstate UNKNOWN_ERROR in templates
> 
> I can't see how this will ever get thrown, but as it's there we should
> have the template handling included.

If the SMTP server is unavailable it at least comes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:12:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:12:01 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-zdb0hccEFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:12:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:12:06 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-ol1GNy7GUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124900|0                           |1
        is obsolete|                            |
 Attachment #124901|0                           |1
        is obsolete|                            |
 Attachment #124902|0                           |1
        is obsolete|                            |
 Attachment #125115|0                           |1
        is obsolete|                            |

--- Comment #45 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125343&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:12:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:12:10 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-vyTzLwkPjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #46 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125344&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:12:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:12:14 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-sfkFxc3dXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #47 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125345&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 20:12:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 18:12:18 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-ca7NKQIatv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #48 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 125346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125346&action=edit
Bug 28803: (QA follow-up) Reinstate UNKNOWN_ERROR in templates

I can't see how this will ever get thrown, but as it's there we should
have the template handling included.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 23:44:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 21:44:44 +0000
Subject: [Koha-bugs] [Bug 29118] Basic editor for new entry or editing
 records drops fields that contains any UTF-8 character
In-Reply-To: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29118-70-O1wywLfoRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29118

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Courtenay, 

please check your framework configuration and make sure you didn't remove/hide
the LDR/000 field. This field will contain the encoding information on your
record. If it's not present in a record, it will explain the problems you see
with non-latin characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Sep 26 23:45:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 21:45:12 +0000
Subject: [Koha-bugs] [Bug 29118] Basic editor for new entry or editing
 records drops fields that contains any UTF-8 character
In-Reply-To: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29118-70-i1NeJpZnAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29118

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 00:11:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Sep 2021 22:11:20 +0000
Subject: [Koha-bugs] [Bug 18062] Damaged Status shows unavailable in results
In-Reply-To: <bug-18062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18062-70-3fpgs3DQkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18062

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid on current master and in 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 06:23:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 04:23:57 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-psljpjPU9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
Having a similar problem on 50% of 21.05 instances I've upgraded, but different
table in question:

{UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too large. The
maximum row size for the used table type, not counting BLOBs, is 8126. This
includes storage overhead, check the manual. You have to change some columns to
TXT or BLOBs [for Statement "ALTER TABLE borrowers ADD COLUMN
autorenew_checkouts TINYINT(1) NOT NULL DEFAULT 1 AFTER anonymized"]  at
/usr/share/perl5/DBIx/Class/Schema.pm line 1118.
        DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x562bc062d928),
"DBI Exception: DBD::mysql::db do failed: Row size too large. "...) called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113
       
DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x562bc077f160),
"DBI Exception: DBD::mysql::db do failed: Row size too large. "...) called at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501
        DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: Row size
too large. The maximum row"..., DBI::db=HASH(0x562bc20628b8), undef) called at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl lie
21313

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 06:37:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 04:37:54 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-kBs123GLZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
(In reply to Mason James from comment #15)
> (In reply to skaman.tx from comment #14)
> > 
> > Any further thoughts?
> 
> hi skaman
> 
> running this SQL before the upgrade might fix the error...
>  ALTER TABLE `items` ROW_FORMAT=DYNAMIC;
> 
> more info... 
>  https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-
> innodb/

Cheers, Mason!

When I ran some SQL from that troubleshooting page, I noticed that all the Koha
tables were using "Compact" row format. 

The database I was using was set up a long time ago, and it did in-place
upgrades that retained the legacy settings it seems.

>From 10.2.x, the default has been Dynamic. 

I think this bug report could probably be closed, although perhaps we could
have an audit script for double-checking some MySQL settings before upgrading I
guess... that's a bit fraught though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 07:35:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 05:35:13 +0000
Subject: [Koha-bugs] [Bug 29119] New: Search of course reserves doesn't work
 propertly with accents
Message-ID: <bug-29119-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29119

            Bug ID: 29119
           Summary: Search of course reserves doesn't work propertly with
                    accents
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org

when a user looks for a course reserve it must write as it is, it doesn't
recognize accent variations

Example is a course reserve 'evaluación' and the users looks fon evaluacion,
the result will be empty.

Search course reserves should be accent neutral 

kindest regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 07:39:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 05:39:11 +0000
Subject: [Koha-bugs] [Bug 29120] New: improve link_bibs_to_authorities.pl
Message-ID: <bug-29120-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29120

            Bug ID: 29120
           Summary: improve link_bibs_to_authorities.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

/link_bibs_to_authorities.pl links bibliographics with main entry ($a), I wish
to discuss with you if this script should also look for match at 4xx for non
accepeted entries and replace in case of matchings

The idea behind of this featrue is when importing records from external sources
for example, add this function that looks for non-accepeted authirity form in
your catalogue and if there is a march replace with main entry.

Is something we should add the option at koha?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 07:57:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 05:57:17 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-9TJMDThlvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Joonas Kylmälä from comment #44)
> (In reply to Martin Renvoize from comment #41)
> > Created attachment 125115 [details] [review] [review]
> > Bug 28803: (QA follow-up) Reinstate UNKNOWN_ERROR in templates
> > 
> > I can't see how this will ever get thrown, but as it's there we should
> > have the template handling included.
> 
> If the SMTP server is unavailable it at least comes.

Really?  I didn't think that was the case when calling 'create'.. if it is the
case I don't understand why, we don't do anything with the SMTP server until
the call to send_or_die.

It doesn't cause any harm having this, but I still haven't been able to trigger
it myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:07:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:07:55 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-O7xnq6BPMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Nind from comment #6)
> Signed-off-by: David Nind <david at davidnind.com>

Thx David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:23:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:23:06 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-jcXLJKeEa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
sub effective_itemtype {
    my ( $self ) = @_;

    my $pref = C4::Context->preference('item-level_itypes');
    if ( $pref && $self->itype() ) {
        return $self->itype();
    } else {
        warn "item-level_itypes set but no itemtype set for item
(".$self->itemnumber.")"
          if $pref;
        return $self->biblioitemnumber()->itemtype();
    }
}

This sub c/should be moved out of the DBIx schema file to Koha::Item ?
There is no need to warn each time imo.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:31:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:31:36 +0000
Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size
In-Reply-To: <bug-28692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28692-70-4bx14m2fEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Interested in this as I recently was looking at a 30GB Koha database where 20GB
was in the action_log table alone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:52:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:52:59 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-xcE1C45jGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #47)

> But it fails. TT calls the orders method in LIST context. Explaining the
> horrible scalar stuff introduced.
> See also https://www.perlmonks.org/bare/?node_id=413941

This last observations makes things a bit worse. Because we need to check all
method calls in the templates now too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:55:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:55:42 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-GcvShUz5x4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #48)
> We should be able to use the TT scalar plugin and do things like:
> 
> [% USE scalar %]
> [% SET var = scalar.biblio.items %]
> 
> but I haven't checked it.

I tried:

+    [% IF biblio.scalar.items.scalar.filter_by_for_hold.count %]

+    var countorders = [% biblio.scalar.orders.scalar.filter_by_current.count
|| 0 | html %];
+    var countdeletedorders = [%
biblio.scalar.orders.scalar.filter_by_cancelled.count || 0 | html %];

with [% USE scalar %] and [% USE Scalar %], but couldnt get them to work.

Template process failed: undef error - The method Koha::Biblio->scalar is not
covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 08:57:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 06:57:01 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-AbqSdISGPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 124420
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124420
Bug 28883: (QA follow-up) Update use of Scalar

I think we better remove this patch here. It contains a regression too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 09:39:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 07:39:46 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-SKx21P9BAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, for the .scalar stuff to work do we not need to also update C4::Templates
to use the "experimental" Template::Stash::Context module for it's stash as
aposed to the default Template::Stash?

Must admin, I'm a little confused by our use of TT now I look into it.. we have
some fun code in C4::Templates to 'ade transition'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 09:48:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 07:48:40 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-Y00CKNUVLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 09:52:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 07:52:21 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-VwUIszJv3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Humm.. now I'm more confused.. the TT docs mention the Scalar plugin but that
perlmonks question mentioned ::Stash::Context.. I'm not sure which route we're
talking about now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:07:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:07:38 +0000
Subject: [Koha-bugs] [Bug 29084] Update article requests-related
 Koha::Biblio methods to use relationships
In-Reply-To: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29084-70-4ZZCVbthfu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I followed the chain up till here and somewhere it goes wrong. But since I
discover it here, I will blame this report :)

I have a patron with 10 article requests.
OPAC shows 10 using [% current_article_requests_count %] Fine!

Intranet patron details shows None!
What does it use?
koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc
[% IF patron.article_requests_current.count %]

There is our famous bottleneck from bug 28883. TT runs the
article_requests_current call in LIST context although you think that you are
chaining.
So the above count does NOT work !

If I do [% SET x = patron.article_requests_current %] [% x.size %]
then I see that x contains 10 entries.

The problem is somewhere earlier. But I wouldnt mind correcting it here, and
not disturb all previous QAs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:10:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:10:22 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-2Qf6UjdauB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Just saying, I though we were all aware of these problems. I have been all down
this road long time ago and it's why I introduced the use of scalar and the
weird lines in the include file (better there than duplicated in the
controllers IMO). It was not the sexier approach but it worked, and I didn't
find another solution at that time.

Then it's also why I suggested earlier in this thread to be explicit when we
needed an array.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:13:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:13:17 +0000
Subject: [Koha-bugs] [Bug 20253] Optionally use buyer's purchase order
 number from Edifact quote in basketname
In-Reply-To: <bug-20253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20253-70-1clmjg0Y8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253

Jeremy Evans <jeremy.evans at phe.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeremy.evans at phe.gov.uk

--- Comment #1 from Jeremy Evans <jeremy.evans at phe.gov.uk> ---
We would support this. We have recently started using EDI and one of the issues
is not being able to see the basket name from the vendor in Koha.
We enter a basket name on the vendor site based on site/date etc so we can tell
from the basket name which site the order was placed for and the date. The
quote in Koha only shows the file name. When we confirm the order, the actual
order sent back to the vendor uses the Koha OrderID as the basket name. So we
end up with 3 different references depending if it is a quote or order and
whether you look in the vendor system or Koha so not easy to cross-check
between the vendor and Koha.

Ideally we would want to retain the vendor basketID in the Quote seen in Koha
(or at least be able to see/search sort by this).
It would also be useful to be able to use this as the basis for the orderID
sent back to the vendor though it needs to be unique so would need koha to add
some suffix to the order & quote don't have exactly the same refence on the
vendor system

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:21:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:21:03 +0000
Subject: [Koha-bugs] [Bug 14414] add field for processing fee for invoices
In-Reply-To: <bug-14414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14414-70-9hiNU8F4Vj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14414

Jeremy Evans <jeremy.evans at phe.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeremy.evans at phe.gov.uk

--- Comment #3 from Jeremy Evans <jeremy.evans at phe.gov.uk> ---
We would support this.
Our vendor charges a servicing fee for covering/labelling etc which is shown in
their invoice for each item.  The aggregate servicing fee for the invoice is
subtotalled at the end with the item costs.

We currently include this fee in the item invoice cost but it would be useful
to be able to record it as a separate servicing fee so we can report on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:21:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:21:08 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-PJr91RFzXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just failed another bug because this does not work (TT list context):

[% IF patron.article_requests_current.count %]

And about that, I have been saying longer that I just dont like all these
object methods in templates :)
I think this is a serious drawback when using TT.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:21:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:21:17 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-xZNeVhqh9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think we are perhaps trying to solve two problems here when we should be
doing different things in different situations.

I don't think we should implicitly call get_from_storage/discard_changes inside
the unblessed method as it has knock-on effects for the object.  For cases
where we want the stored object back, including any DB level trigger updates, I
think we should call that specifically as suggested by Tomas. So where we're
giving API responses, or just prior to calling logaction in many cases.

I do however, think wherever possible 'unblessed' should indeed return a
stringified value and not an object.

I think Peters solution is nearly there.. but instead of handling datetimes
specifically and throwing errors otherwise, I'd just stringify all values and
thus catch whatever we can.

Thus, my proposal would be

for my $k (keys %res) {
  $res{$k} = "$res{$k}";
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:25:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:25:18 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-9nv9FsBP2b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:25:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:25:21 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-F8mhZOKJX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125246|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125347&action=edit
Bug 29086: Simplify querying active article requests

This patch makes a trivial replacement of a query for a higher level
method that does the same query.

To test:
1. Enable the ArticleRequests feature
2. Place some article requests on known biblios
3. Have some article requests be active on others finished (either
   completed or cancelled)
4. Go to the detail page for those records
=> SUCCESS: The active article requests count is correct!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:25:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:25:25 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-LP99L9kIme@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125247|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125348&action=edit
Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses

I noticed a couple places in which this library was included but not
used.

To test:
1. Apply this patch
2. Run:
   $ git grep 'Koha::ArticleRequest::Status'
=> SUCCESS: There aren't any calls to their defined constants in
Biblio.pm or Patrons.pm
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:25:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:25:51 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-1jpP4KWh4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Note that the dependency needs a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:26:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:26:01 +0000
Subject: [Koha-bugs] [Bug 29086] Reuse article request filtering methods in
 Biblio template plugin
In-Reply-To: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29086-70-kUCLkmEGW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29086

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:34:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:34:19 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-dAkp8ZXtuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    $deleted_patron->delete; # Haha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:37:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:37:10 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-jdeDf8SSYb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 Koha/ArticleRequest.pm               | 187 ++++++++++++++-------------
 Koha/Schema/Result/ArticleRequest.pm |  38 +++++-

Strictly forbidden. Even for Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:39:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:39:20 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-xM4BvGAhU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+        # this is to avoid calling ->discard_changes to retrieve
+        # the default value from the DB
+        $self->status( Koha::ArticleRequest::Status::Requested )
+            unless $self->status;

Hmm. But if you didnt provide a status, we should be able to rely on the
default value from the DB engine, isnt it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:41:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:41:25 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-mSUiUMj9Z2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+    $self->SUPER::store;
+    $self->notify;

Not sure if this is an improvement. When you store something, you call notify?
This action begs for another code location imo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:50:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:50:44 +0000
Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
In-Reply-To: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28420-70-fAIu5Kw38c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

Eugene Espinoza <eugenegf at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eugenegf at yahoo.com

--- Comment #20 from Eugene Espinoza <eugenegf at yahoo.com> ---
Hi Mark! I tried your patch for WPRO, there version is Koha 20.05. I was
getting an Internal Server error when going to the system preference for Azure
and when I checked the log,  I got "Unrecognized source of preference values:
patron-categories at /usr/share/koha/intranet/cgi-bin/admin/preferences.pl line
97.
". Checked the perl file and the system preference yaml file as well as the
GoogleOpenIdConnect settings, there seems to be an extra line "choices:
patron-categories". I didn't see that in the GoofleOpenIDConnect so I removed
that line. I am now able to see the system preference for AzureAD and have the
library staff test it out. Thanks and keep safe!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 10:51:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 08:51:43 +0000
Subject: [Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
In-Reply-To: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29110-70-HbjiEyu9YN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Note that I also saw the problem David mentioned:

Error trace

Template process failed: undef error - DBIC result _type  isn't of the _type
Item at /usr/share/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 751.
 at /usr/share/koha/C4/Templates.pm line 121

Yes, I restarted Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 11:51:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 09:51:21 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-69FgxlcqFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124433|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125349&action=edit
Bug 27461: Move hardcoded value to module

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 11:51:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 09:51:25 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-mCW73YXOoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124434|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125350&action=edit
Bug 27461: Add tests for biblio_008

Test plan:
Run  t/db_dependent/FrameworkPlugin.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 11:51:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 09:51:29 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-zMXdgSgtBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124435|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125351&action=edit
Bug 27461: Right pad with default elements for too short 008s

Note that we treat the elements 18-34 as one block of elements,
since its subdivision may vary.
E.g. if you pass 24 characters to the form, it will use the first
18 chars (until the last complete element) and pad with default
elements from position 18-39.

Test plan:
[1] Go to addbiblio. Make sure that 008 is connected to the plugin.
[2] Backspace field 008 a bit, click on the plugin button.
[3] Verify that the last elements come from the default.
[4] Repeat for a few different lengths.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 11:52:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 09:52:13 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-nuAyesxo40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice clear code, works as expected and no regressions found. Tests all passing.

Passing QA, thanks guys.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 11:56:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 09:56:20 +0000
Subject: [Koha-bugs] [Bug 28761] Item status shows incorrectly on
 opac-course-details.pl
In-Reply-To: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28761-70-ZNsw65khkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I noticed this the other day.. should we also be falling back to item-type
level not for loan values when the local not for loan is not set or set to
allow loans.. which value should take precedence if both are set?

Otherwise, this looks pretty reasonable to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 12:55:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 10:55:04 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-wcsMi1aUdL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #1)
> sub effective_itemtype {
>     my ( $self ) = @_;
> 
>     my $pref = C4::Context->preference('item-level_itypes');
>     if ( $pref && $self->itype() ) {
>         return $self->itype();
>     } else {
>         warn "item-level_itypes set but no itemtype set for item
> (".$self->itemnumber.")"
>           if $pref;
>         return $self->biblioitemnumber()->itemtype();
>     }
> }
> 
> This sub c/should be moved out of the DBIx schema file to Koha::Item ?
> There is no need to warn each time imo.

I think it should be moved to the object. That method was added to the DBIC
class before Koha::Object(s) existed!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:11:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:11:05 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-lEtH2pE6lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
When I said we send a warning to the logs, I meant we are telling the users
their data is wrong. It implies that the user needs to fix that.
Implicitly, we are telling people they need to set a value there.

Can't we force that somehow? And set the 'effective item type' on a DBRev
instead? It feels like it was a trasitional step, for a transition that never
took place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:16:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:16:56 +0000
Subject: [Koha-bugs] [Bug 29121] New: Plugins with broken ->install prevent
 access to the plugins list
Message-ID: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

            Bug ID: 29121
           Summary: Plugins with broken ->install prevent access to the
                    plugins list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Plugin architecture
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If a plugin is badly coded, like adding a table in their install method,
without checking it doesn't exist first, the plugins home page gives a 500
error.

To reproduce:
1. Install any plugin you like
2. Restart plack
=> SUCCESS: All good
3. Manually change its install method to:

sub install {
    die "plugin, die!";
}

4. Run:
   $ koha-mysql kohadev
   > DELETE FROM plugin_data;
(to make sure there's no __INSTALLED__ entry, do on a safe to delete DB).
5. Point your browser to the plugins-home.pl page
=> FAIL: Boom

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:17:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:17:48 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-1xd5VVROvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:28:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:28:41 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-mqB5SshCln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> When I said we send a warning to the logs, I meant we are telling the users
> their data is wrong. It implies that the user needs to fix that.
> Implicitly, we are telling people they need to set a value there.
> 
> Can't we force that somehow? And set the 'effective item type' on a DBRev
> instead? It feels like it was a trasitional step, for a transition that
> never took place.

It would be better to have a Koha data linter tool for sure. Maybe we should
move this check to the about page, considering we have other checks of this
nature there.

The reason the warning is there is because itemtype is required for Koha to
operate correctly. It can be set at either the item or the bib level. That's
why that warning ended up where it is. However, unless somebody is routinely
combing through the logs that warning will go unnoticed. It seems more sensible
to remove the warning there and add a check to the about page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:33:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:33:22 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-fnuE2f7c9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
IIRC items without itemtype come from Acquisition

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:40:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:40:05 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-VgAMe83pOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:40:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:40:09 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-bergXaRAwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125352&action=edit
Bug 29121: Add new plugin exceptions

This patch introduces two new exceptions:

- Koha::Exceptions::Plugin::InstallDied
- Koha::Exceptions::Plugin::UpgradeDied

Tests are added for their stringification output.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:40:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:40:13 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-wgXGNlcEvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125353&action=edit
Bug 29121: Regression tests

This patch adds regression tests for broken ->install and ->upgrade
methods on plugins.

It adds two dummie plugins named BrokenInstall and BrokenUpgrade, for
convenience.

Tests are added to catch the warnings that will be logged when trying to
load this plugins on different scenarios.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:40:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:40:17 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-AuQQIsab4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125354&action=edit
Bug 29121: Catch errors in ->install and ->upgrade calls on plugins

This patch adds a try/catch block when instantiating plugins. Calling
->new on a plugin eventually triggers a call to ->install (this has
always been like this since bug 7804). If the ->install method is
somehow borked, then the process dies. We need to prevent that, and
report back some error took place. That's what this patch does.

The same happens to the ->upgrade.

To test:
1. Install any plugin you like
2. Restart plack (just in case)
=> SUCCESS: All good
3. Manually change its install method to:

sub install {
    die "plugin, die!";
}

4. Run:
   $ koha-mysql kohadev
   > DELETE FROM plugin_data;
(to make sure there's no __INSTALLED__ entry, do on a safe to delete DB).
5. Point your browser to the plugins-home.pl page
=> FAIL: Boom
6. Apply up to the regression tests
7. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/Plugins.t \
           t/Koha/Exceptions.t
=> FAIL: Tests fail!
8. Apply this patch
9. Repeat 2
=> SUCCESS: Tests pass!
10. Run:
    $ restart_all
11. Repeat 5
=> SUCCESS: The page is not broken
12. Sign off :-D

Note: I used
    $ kshell
   k$ perl misc/devel/install_plugins.pl
to test as well.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:51:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:51:44 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-1pePuw6jmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124630|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125355&action=edit
Bug 28937: Use Flatpickr on circulation and patron pages

This patch replaces the use of jQueryUI's datepicker on circulation and
patron-related pages.

The patch modifies Flatpickr's default configuration (in calendar.inc)
so that it has the following features:

 - A Flatpickr input with a "futuredate" class will require that the
   selected date be after today.
 - The Flatpickr input field will be wrapped in a container to
   facilitate better CSS styling.
 - Generic handling of paired date fields is enabled using
   ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the
   same feature we have for jQueryUI datepickers using ".datepickerfrom"
   and ".datepickerto".

This patch also removes an unused function which was repeated in three
templates: validate1.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check out to a patron.
  - Open the Restrictions tab and click "Add manual restriction."
    - In the "Expiration" field, test that the Flatpickr widget works
      correctly and limits to dates after today.
  - Enable the SpecifyDueDate preference if necessary.
    - Test the behavior of the SpecifyDueDate controls: Setting a date,
      clearing a date, session persistence.
- Enable the SuspendHoldsIntranet system preference if necessary.
  - Check out to a patron with existing holds.
    - Open the Holds tab and click the "Suspend" button for one of the
      holds.
      - In the modal window which appears, check that the Flatpickr
        widget works correctly and limits to dates after today.
      - At the bottom of the table of holds, test that the "Suspend all
        holds" Flatpickr works correctly and limits to dates after
        today.
        - Perform this same test from the patron details page.
- Enable the  BatchCheckouts system preference if necessary.
  - Open a patron record and click "Batch check out" in the left-hand
    sidebar menu.
    - Test that the "Hard due date" Flatpickr works correctly as a date
      and time picker.
- Go to Circulation -> Overdues.
  - Test that the date due filters in the sidebar work correctly and
    are linked, e.g. the "to" field cannot be before the "from" field.
     - Perform the same test here: Circulation -> Holds to pull; and
       here: Circulation -> Hold ratios.
- Enable the  HouseboundModule system preference if necessary.
  - Check out to or view details of a patron.
    - Click "Housebound" in the sidebar menu.
      - Save delivery day and frequency settings for that patron.
      - Click "Add a new delivery."
      - Test that the "Date" Flatpickr widget works correctly.
- Go to Patrons -> A patron record -> Edit.
  - Test that Flatpickr widgets work on the following fields:
    - Date of birth
    - Registration date & Expiration date (linked).
    - Patron restrictions -> Add manual restriction -> Expiration.
- View a bibliographic record and start the process of placing a hold.
  - After selecting a patron, test the "Hold starts on" and "Hold
    expires on" date fields. The fields should be linked and each
    should limit to future dates.
  - Confirm that the dates are saved correctly when you submit the
    hold.
- Locate a bibliographic record with multiple holds and view the holds.
  - In the table of holds, test each date field: Date, expiration, and
    suspend-until.
- Test that Flatpickr's static "formatDate" method is working
  correctly:
  - Locate a bibliographic record's item so that there is text in both
    the "Public note" and "Non-public note" field.
  - Check that item out to a patron.
  - After the page reloads the public and non-public notes should be
    shown under the checkout title highlighted in red.
- Check for references to a "validate1" function. There should be none.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:51:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:51:48 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-Q6Lx0DUP5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125356&action=edit
Bug 28937: (QA follow-up) Accessability improvement

This patch adds a keydown event listener onto the flatpickr instance and
looks for the down arrow key. When such an event is detected we take
that to mean the user wants to keyboard navigate the calendar widget and
so disable the buggy allowInput option allowing keyboard navigation to
work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:56:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:56:26 +0000
Subject: [Koha-bugs] [Bug 29122] New: appends first item barcode to all
 copies when adding multiple copies
Message-ID: <bug-29122-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29122

            Bug ID: 29122
           Summary: appends first item barcode to all copies when adding
                    multiple copies
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rlpardhi at sipnaengg.ac.in
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When adding multiple copies of item in cataloging, it automatically increments
barcode but appends barcode of first copy to all copies along with '|'. Please
guide me to resolve this issue.

Eg.
First copy barcode is: JR004141
Second copy barcode is:JR004142 | JR004141
Third copy barcode is: JR004143 | JR004141
Fourth copy barcode is:JR004144 | JR004141
Fifth copy barcode is: JR004145 | JR004141
   Kindly guide how to avoid additional string.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:57:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:57:15 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-O6L91ome2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I think my follow-up should resolve the accessibility concerns I had..
Please test it.

With that in mind, I'm happy to PQA on the original patch, but would really
like someone to SO my follow-up to check for anything I've missed.

In short, I add a listener onto the flatpickr instance at it's creation time
and watch for the 'Down arrow' keydown even.. upon detection of that event we
temporarily disable the buggy allowInput configuration option of the flatpickr
instant and restore the keyboard navigation of the picker widget in doing so. 
The only caveat I can see with this is that there's not a clear keyboard
navigable escape back to the input to get manual input back once you've enabled
down arrowed into the widget... hitting escape does close the widget, but it
drops you back at totally different focus location for some reason.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:57:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:57:46 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-ssCYjn6wN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:57:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:57:49 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-Do2OlDEXjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125352|0                           |1
        is obsolete|                            |
 Attachment #125353|0                           |1
        is obsolete|                            |
 Attachment #125354|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125357&action=edit
Bug 29121: Add new plugin exceptions

This patch introduces two new exceptions:

- Koha::Exceptions::Plugin::InstallDied
- Koha::Exceptions::Plugin::UpgradeDied

Tests are added for their stringification output.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:58:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:58:26 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-iyqXJgjBX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125357|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125358&action=edit
Bug 29121: Add new plugin exceptions

This patch introduces two new exceptions:

- Koha::Exceptions::Plugin::InstallDied
- Koha::Exceptions::Plugin::UpgradeDied

Tests are added for their stringification output.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:58:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:58:36 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-pPrCXPSOjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125359&action=edit
Bug 29121: Regression tests

This patch adds regression tests for broken ->install and ->upgrade
methods on plugins.

It adds two dummie plugins named BrokenInstall and BrokenUpgrade, for
convenience.

Tests are added to catch the warnings that will be logged when trying to
load this plugins on different scenarios.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:58:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:58:39 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-Z4ntpM3Nik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125360&action=edit
Bug 29121: Catch errors in ->install and ->upgrade calls on plugins

This patch adds a try/catch block when instantiating plugins. Calling
->new on a plugin eventually triggers a call to ->install (this has
always been like this since bug 7804). If the ->install method is
somehow borked, then the process dies. We need to prevent that, and
report back some error took place. That's what this patch does.

The same happens to the ->upgrade.

To test:
1. Install any plugin you like
2. Restart plack (just in case)
=> SUCCESS: All good
3. Manually change its install method to:

sub install {
    die "plugin, die!";
}

4. Run:
   $ koha-mysql kohadev
   > DELETE FROM plugin_data;
(to make sure there's no __INSTALLED__ entry, do on a safe to delete DB).
5. Point your browser to the plugins-home.pl page
=> FAIL: Boom
6. Apply up to the regression tests
7. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/Plugins.t \
           t/Koha/Exceptions.t
=> FAIL: Tests fail!
8. Apply this patch
9. Repeat 2
=> SUCCESS: Tests pass!
10. Run:
    $ restart_all
11. Repeat 5
=> SUCCESS: The page is not broken
12. Sign off :-D

Note: I used
    $ kshell
   k$ perl misc/devel/install_plugins.pl
to test as well.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 13:58:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 11:58:42 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-rd3umnZiqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125361&action=edit
Bug 29121: Add POD to plugins

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:00:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:00:38 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-LQRFJI5dtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
We should document this feature too..

"Down arrow" when in a flatpickr input field will focus the flatpickr widget
for keyboard navigation. Arrow keys can then be used to navigate days, holding
ctrl whilst using the arrow keys switched navigation to month and year fields.
Hitting return will submit the selected value, or if this is a datetime picker
it will submit the date part and move the focus to the timepicker for the next
selection step.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:44:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:44:13 +0000
Subject: [Koha-bugs] [Bug 29123] New: Add Dataly Tech to About page
Message-ID: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123

            Bug ID: 29123
           Summary: Add Dataly Tech to About page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: a.roussos at dataly.gr
        QA Contact: testopia at bugs.koha-community.org

We would like Dataly Tech to be added to the list of contributing companies
and institutions in the About page.

Our understanding is that this is not yet an automated process (see comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592#c6 in Bug
25592), so I'm going to submit a patch that addresses the proposed change.

A relevant entry in the .mailmap file already exists, which was added among
other entities in commit d102651d1b from Bug 28386.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:45:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:45:22 +0000
Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page
In-Reply-To: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29123-70-vB6XaEI2zP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr
                   |ity.org                     |
                 CC|                            |gveranis at dataly.gr
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:47:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:47:58 +0000
Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
In-Reply-To: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28420-70-VjIqqZJuMO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420

--- Comment #21 from mark.jaroski at gmail.com ---
Thanks Eugene. I'll have a look at that, and update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:50:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:50:41 +0000
Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page
In-Reply-To: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29123-70-PYRtH6xVZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 14:50:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 12:50:44 +0000
Subject: [Koha-bugs] [Bug 29123] Add Dataly Tech to About page
In-Reply-To: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29123-70-RgukNYSiaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123

--- Comment #1 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 125362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125362&action=edit
Bug 29123: Add Dataly Tech to About page

This patch adds Dataly Tech to the list of "Contributing companies
and institutions" in the About page.

Test plan:
1) View the About page, notice how Dataly Tech is missing
2) Apply this patch
3) Reload the About page, this time "Dataly Tech, Greece" is listed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 15:08:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 13:08:58 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-TBXp9kgnp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 15:34:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 13:34:23 +0000
Subject: [Koha-bugs] [Bug 10147] Koha allows for multiple main entries
In-Reply-To: <bug-10147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10147-70-zgsZrrktr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10147

Pablo López Liotti <paliotti at mdp.edu.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paliotti at mdp.edu.ar

--- Comment #1 from Pablo López Liotti <paliotti at mdp.edu.ar> ---
This bug is present today.
It´s possible a solution?
Thks
Paul

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:12:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:12:43 +0000
Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra
 leading zeroes are reported not found
In-Reply-To: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20206-70-0FM7RiLcNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Bye bye

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:12:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:12:55 +0000
Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra
 leading zeroes are reported not found
In-Reply-To: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20206-70-QLrkdR4Nkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:14:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:14:04 +0000
Subject: [Koha-bugs] [Bug 29124] New: Load existing holds requests using API
Message-ID: <bug-29124-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29124

            Bug ID: 29124
           Summary: Load existing holds requests using API
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We generate a lot of data when a record has many holds and we load the table of
existing holds - we should load this dynamically after the page load using the
API

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:14:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:14:20 +0000
Subject: [Koha-bugs] [Bug 29124] Load existing holds requests using API
In-Reply-To: <bug-29124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29124-70-ExIkabXjFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29124

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28964,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29058

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:14:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:14:20 +0000
Subject: [Koha-bugs] [Bug 28964] request.pl slow to load when there are many
 holds on a record
In-Reply-To: <bug-28964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28964-70-u1zVonE4hV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28964

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29124

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:14:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:14:20 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-oDRP6hi8pQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29124

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:20:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:20:37 +0000
Subject: [Koha-bugs] [Bug 29125] New: Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
Message-ID: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

            Bug ID: 29125
           Summary: Use Koha::Patron object in
                    C4:Utils::DataTables::Members.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently we do a SQL search for patrons, then fetch the patron object for each
borrowernumber individually, then fetch related objects

If we use Koha::Patrons directly we can prefetch related object and reduce the
number of calls to the DB

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:27:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:27:23 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-mSZuuPobIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125356|0                           |1
        is obsolete|                            |

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125363&action=edit
Bug 28937: (QA follow-up) Accessability improvement

This patch adds a keydown event listener onto the flatpickr instance and
looks for the down arrow key. When such an event is detected we take
that to mean the user wants to keyboard navigate the calendar widget and
so disable the buggy allowInput option allowing keyboard navigation to
work as expected.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:49:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:49:56 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-4RIaZJKQwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70791|0                           |1
        is obsolete|                            |

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125364&action=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:50:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:50:00 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-W8NvHmU8fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125365&action=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:50:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:50:23 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-JfRfktMDQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |glasklas at gmail.com

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Rebased against master and added tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 16:52:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 14:52:25 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-FSLhrF7kK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125365|0                           |1
        is obsolete|                            |

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125366&action=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 17:29:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 15:29:44 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-MZRoY4qgG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:00:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:00:03 +0000
Subject: [Koha-bugs] [Bug 29126] New: Accessibility: More corrections to
 contrast in the OPAC
Message-ID: <bug-29126-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126

            Bug ID: 29126
           Summary: Accessibility: More corrections to contrast in the
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Keywords: accessibility
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: bolshawh at parliament.uk,
                    martin.renvoize at ptfs-europe.com,
                    testopia at bugs.koha-community.org
            Blocks: 28188

I've done some more checking for contrast problems in the OPAC and will submit
a patch with various corrections.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:00:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:00:03 +0000
Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio
 for text is insufficient [OMNIBUS]
In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28188-70-XMAiurUWXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29126


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126
[Bug 29126] Accessibility: More corrections to contrast in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:24:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:24:38 +0000
Subject: [Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast
 in the OPAC
In-Reply-To: <bug-29126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29126-70-uIBtj2F0ME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:24:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:24:41 +0000
Subject: [Koha-bugs] [Bug 29126] Accessibility: More corrections to contrast
 in the OPAC
In-Reply-To: <bug-29126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29126-70-03biGpiDfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125367&action=edit
Bug 29126: Accessibility: More corrections to contrast in the OPAC

This patch makes a few more corrections to OPAC CSS in order to avoid
having elements which lack sufficient contrast, in particular parts of
the interface where a standard-colored link appears on a darker
background.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

Check the following pages/areas:

- Breadcrumbs navigation
- Datatables buttons (on the "Your summary" page)
- Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail
  pages.
- "Action" menu on the bibliographic detail pages: Place hold, print,
  etc.
- Links inside "striped" tables: Links on the alternate grey background
  are darker to increase contrast.
- Sidebar links on user pages: Your summary, your charges, etc.
- Tag cloud: Approved tags in the weighted list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:50:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:50:16 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-a7MlVzgdbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:50:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:50:19 +0000
Subject: [Koha-bugs] [Bug 29041] Improve specificity of breadcrumbs in
 Additional Contents
In-Reply-To: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29041-70-HR1dEfNWGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29041

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125368&action=edit
Bug 29041: (follow-up) Expand the scope of changes

This patch expands the scope of the original changes to add consistency
to the non-edit views.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 18:54:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 16:54:56 +0000
Subject: [Koha-bugs] [Bug 29127] New: Reminders for Suspended Holds
Message-ID: <bug-29127-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29127

            Bug ID: 29127
           Summary: Reminders for Suspended Holds
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be nice to have either a definable notice or a pesky reminder in the
OPAC (or both) when a patron has set a hold, suspended it, and forgot about it.
 Suspended holds can affect purchase decisions and decisions for patrons to
place a hold.  It would be great if the OPAC would display a reminder in the
holds or like a news or message at the top of the account when an item has been
suspended for X amount of days, and a notice that does the same.  So, libraries
could remind patrons after 6 months, and send a notice after a year.  It would
also be great if libraries could set if a suspended hold just goes away after a
set amount of time, or not at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 19:14:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 17:14:46 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-Iu6BnMPPOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

--- Comment #1 from Andrii Veremeienko <andriiverem at gmail.com> ---
Created attachment 125369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125369&action=edit
Bug 29114: Trim whitespace before the barcode

The solution was to add regexp which trimming all whitespaces.

How to test:
1. Go to the koha/virtualshelves/shelves.pl;
2. Add new list or edit existing one;
3. Start adding new items;
4. In the "Barcode" field add barcode(s) with whitespaces before them;
5. Observe that it wasn't added as the barcode isn't recognized because of
whitespaces;
6. Apply the patch;
7. Repeat step 4;
8. Observe that the item was successfully added;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 19:15:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 17:15:45 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-9u9re2seAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Andrii Veremeienko <andriiverem at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 19:23:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 17:23:56 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-QfX9157C6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 19:23:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 17:23:59 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-wR5b7baEYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120862|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125370&action=edit
Bug 28321: Use template block for display of items in search results

This patch updates the staff interface catalog search results to use
a new reusable BLOCK for displaying item information: Available items,
checked-out items, and unavailable items.

Some style has been updated, and an old GIF image has been replaced with
an SVG. The hold ratios template has been updated to accommodate this
change.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Perform a catalog search in the staff interface which will return
  multiple results with multiple items each. For thorough testing, some
  records should have items which are checked out, available, or
  lost/notforloan.
- On the search results page, confirm that item information is accurate
  and readable.
- Test with  item-level_itypes on and off.
- Test with noItemTypeImages on and off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 19:35:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 17:35:18 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21946-70-cRuj9CR3KA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
  Change sponsored?|---                         |Sponsored
  Text to go in the|This feature adds the       |This feature was sponsored
      release notes|ability to define some      |by VOKAL and adds the
                   |itemtypes as 'parent' to    |ability to define some
                   |other item types for        |itemtypes as 'parent' to
                   |defining circulation        |other item types for
                   |limits.
                    |defining circulation
                   |
                           |limits.
                   |This allows to              |
                   |create 'groups' of related  |This allows to
                   |items types. E.g. - a       |create 'groups' of related
                   |library has both Blu-ray    |items types. E.g. - a
                   |and DVD itemtypes - these   |library has both Blu-ray
                   |can be grouped under the    |and DVD itemtypes - these
                   |'Media' itemtype. The       |can be grouped under the
                   |checkout limit for Media    |'Media' itemtype. The
                   |will then apply to both     |checkout limit for Media
                   |Blu-ray and DVD. 
          |will then apply to both
                   |
                           |Blu-ray and DVD.
                   |So if a                     |
                   |library says a patron can   |So if a
                   |have 4 dvds - 4 blu-ray -   |library says a patron can
                   |and sets Media to have a    |have 4 dvds - 4 blu-ray -
                   |limit of 4 then patrons can |and sets Media to have a
                   |have up to 4 items of       |limit of 4 then patrons can
                   |either type (e.g. 1 DVD, 3  |have up to 4 items of
                   |blu-rays) but will be       |either type (e.g. 1 DVD, 3
                   |prevented from checking out |blu-rays) but will be
                   |more of either type by the  |prevented from checking out
                   |limit on the parent.
       |more of either type by the
                   |                            |limit on the parent.
                   |Parent rules only apply to  |
                   |checkout limits.            |Parent rules only apply to
                   |                            |checkout limits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:05:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:05:08 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21946-70-qr15VdL8uo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This feature was sponsored  |This feature was sponsored
      release notes|by VOKAL and adds the       |by VOKAL and adds the
                   |ability to define some      |ability to define some
                   |itemtypes as 'parent' to    |itemtypes as 'parent' to
                   |other item types for        |other item types for
                   |defining circulation        |defining circulation
                   |limits.
                    |limits.
                   |
                           |
                   |This allows to              |This allows to
                   |create 'groups' of related  |create 'groups' of related
                   |items types. E.g. - a       |items types. E.g. - a
                   |library has both Blu-ray    |library has both Blu-ray
                   |and DVD itemtypes - these   |and DVD itemtypes - these
                   |can be grouped under the    |can be grouped under the
                   |'Media' itemtype. The       |'Media' itemtype. The
                   |checkout limit for Media    |checkout limit for Media
                   |will then apply to both     |will then apply to both
                   |Blu-ray and DVD. 
          |Blu-ray and DVD.
                   |
                           |
                   |So if a                     |So if a
                   |library says a patron can   |library says a patron can
                   |have 4 dvds - 4 blu-ray -   |have 4 dvds - 4 blu-ray -
                   |and sets Media to have a    |and sets Media to have a
                   |limit of 4 then patrons can |limit of 4 then patrons can
                   |have up to 4 items of       |have up to 4 items of
                   |either type (e.g. 1 DVD, 3  |either type (e.g. 1 DVD, 3
                   |blu-rays) but will be       |blu-rays) but will be
                   |prevented from checking out |prevented from checking out
                   |more of either type by the  |more of either type by the
                   |limit on the parent.
       |limit on the parent.
                   |                            |
                   |Parent rules only apply to  |Parent rules only apply to
                   |checkout limits.            |checkout limits.
                   |                            |
                   |                            |Sponsored
                   |                            |by: Vermont Organization of
                   |                            |Koha Automated Libraries
                   |                            |(VOKAL), USA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:09:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:09:58 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-PZcOstDeLM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125295|0                           |1
        is obsolete|                            |
 Attachment #125296|0                           |1
        is obsolete|                            |
 Attachment #125297|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125371&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:10:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:10:09 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-VKo7jDRGZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125372&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:10:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:10:13 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-1CmS7CWIhX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125373&action=edit
Bug 28974: Hard code page = 1 instead of using javascript

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:38:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:38:16 +0000
Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
In-Reply-To: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29125-70-F6HMA5LC9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125374&action=edit
Bug 29125: Add primary key to user_permissions table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:38:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:38:19 +0000
Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
In-Reply-To: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29125-70-6L1TKZY1aD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125375&action=edit
Bug 29125: DBIC updates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:38:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:38:22 +0000
Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
In-Reply-To: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29125-70-3dcssNaWlT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125376&action=edit
Bug 29125: Use patron objects in C4::Utils::DataTables::Members.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 20:38:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 18:38:30 +0000
Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
In-Reply-To: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29125-70-W14FLkdN4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 21:01:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 19:01:21 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-NpZYoxD4kO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29015


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015
[Bug 29015] Add option to limit Holds Queue report by shelving location /
collection
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 21:01:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 19:01:21 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-GQgwsJv3P2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966
[Bug 28966] Holds queue viewer too slow to load for large numbers of holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 21:04:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 19:04:31 +0000
Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for
 large numbers of holds
In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28966-70-nNq0vaOI3k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124854|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125377&action=edit
Bug 28966: Prefetch patron data for holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all. The
primary slowdown is the individual fetch of the patron for each hold to be
displayed. If we prefetch those patrons, the entire script should load much
faster.

Test Plan:
1) Create as many holds as you can ( up to a few thousand if you can )
2) Run the holds queue viewer, note the load time
3) Apply this patch
4) Restart all the things!
5) Reload the holds queue viewer, load time should be improved
6) Note the HTML generated looks the same

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 21:19:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 19:19:10 +0000
Subject: [Koha-bugs] [Bug 28761] Item status shows incorrectly on
 opac-course-details.pl
In-Reply-To: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28761-70-4oGWCLiNUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #8)
> I noticed this the other day.. should we also be falling back to item-type
> level not for loan values when the local not for loan is not set or set to
> allow loans.. which value should take precedence if both are set?
> 
> Otherwise, this looks pretty reasonable to me.

Not sure I understand the question correctly, do you mean item vs. record leven
not for loan? Then I think if both are set, we should use the description from
item level. To me it makes sense that the more specific should win.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 21:50:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 19:50:31 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-qaXQYS23UY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #5)
> IIRC items without itemtype come from Acquisition

Yes, they often do. And they won't cause an issue until you try to check them
out. We have moved to setting itemtype mandatory for items in our libraries to
avoid this from happening - at least on the non-ACQ frameworks.

I am not sure about the consequences of removing the warn - so not going to
comment on that. But having a way to tell users that their data needs fixing is
probably a good thing, given that Koha explodes badly when those items slip
through in some areas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:01:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:01:53 +0000
Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item
 is paid for
In-Reply-To: <bug-22740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22740-70-fUqdGk8gIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:04:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:04:58 +0000
Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item
 is paid for
In-Reply-To: <bug-22740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22740-70-4wZaxnbCqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740

--- Comment #12 from AspenCat Team <aspencatteam at clicweb.org> ---
We would like to see this get funded and developed, so our organization can
contribute some money into making it happen. - Bob Bennhoff (Colorado Library
Consortium bbennhoff at clicweb.org)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:15:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:15:07 +0000
Subject: [Koha-bugs] [Bug 29128] New: Trailing in whitespace in Browse shelf
 link on opac-detail.tt
Message-ID: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

            Bug ID: 29128
           Summary: Trailing in whitespace in Browse shelf link on
                    opac-detail.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On item-detail:

(Browse shelf ) should be (Browse shelf)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:18:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:18:49 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing in whitespace in Browse shelf link
 on opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-72Ppw4ojQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:18:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:18:52 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing in whitespace in Browse shelf link
 on opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-QKdy5VZHFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 125378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125378&action=edit
Bug 29128: Remove whitespace in browse shelf link

To test:
-Turn on OPACShelfBrowser and make sure you have some itemcallnumbers
-Go to detail page and see the link: (Browse shelf )
-Apply patch and look at the link again, it should be: (Browse shelf)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:20:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:20:03 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing in whitespace in Browse shelf link
 on opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-NogFxLoxmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |26421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421
[Bug 26421] Use Bootstrap screen reader text class for shelf browser messages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:20:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:20:03 +0000
Subject: [Koha-bugs] [Bug 26421] Use Bootstrap screen reader text class for
 shelf browser messages
In-Reply-To: <bug-26421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26421-70-Ew0WBj091P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29128


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128
[Bug 29128] Trailing in whitespace in Browse shelf link on opac-detail.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Sep 27 22:22:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 20:22:38 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-12AZxs6T77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Trailing in whitespace in   |Trailing whitespace in
                   |Browse shelf link on        |Browse shelf link on
                   |opac-detail.tt              |opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 01:01:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 23:01:17 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-wYp6KP7Kn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 01:01:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 23:01:23 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-ggQ2o46UJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #61 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125379&action=edit
Bug 3150: (follow-up) Add missing bracket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 01:03:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 23:03:04 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-lf6Wa5cZ34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #62 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Owen Leonard from comment #60)
> I get an error from the opac-sendbasket popup whether or not I'm logged in:
> 
> Could not compile /kohadevbox/koha/opac/opac-sendbasket.pl: syntax error at
> /kohadevbox/koha/opac/opac-sendbasket.pl line 122, near "else"
> BEGIN not safe after errors--compilation aborted at
> /kohadevbox/koha/opac/opac-sendbasket.pl line 137.

Have fixed

> 
> The QA tool also raises several warnings.

The QA test tools all pass for me - can you please paste the output?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 01:33:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Sep 2021 23:33:43 +0000
Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts?
In-Reply-To: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28822-70-G1f2zBiXlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822

--- Comment #4 from Agnes Rivers-Moore <arm at hanover.ca> ---
I think this may apply to all external online services that check with Koha
through SIP for patron status. Probably does not apply to self-serve checkout
through SIP as I think people log out again after checking out, but I have not
tested and am not sure.  Sad to see this considered LOW importance, as it is a
major failure for the many patrons we have who use our online services (ebooks,
video, magazines), then frequently and repeatedly have to ask staff to reset
their password through no fault of theirs. Please reconsider.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 04:46:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 02:46:57 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14242-70-wUeaFcRleW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 04:47:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 02:47:03 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14242-70-6IWPJ52NhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116712|0                           |1
        is obsolete|                            |

--- Comment #129 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125380&action=edit
Bug 14242: Use ISBN-field to automatically fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s)
into search fields for Google Books API and automatically fills
requested fields with search result.

Use in OPAC purchase suggestions to automatically fill out fields when
entering ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACSuggestionAutoFill"
3. Log into OPAC and go to purchase suggestions page
4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into
   the ISBN field and click the 'search google books' button, or unfocus
   the field.
5. Title, Author, Publisher, publication year and Item Type fields should now
be filled
   automatically.
6. Press "clear form" to undo - should restore all fields that the API pull
   filled to empty

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 04:47:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 02:47:10 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14242-70-EdZCmiCvXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116989|0                           |1
        is obsolete|                            |

--- Comment #130 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125381&action=edit
Bug 14242: (follow-up) Format copyright date before plugged into form

This patch formats the copyright date so that only the year shows before
plugging the formatted version into the form.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 04:47:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 02:47:16 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14242-70-2jHEiQIutZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #131 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125382&action=edit
Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 04:49:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 02:49:11 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
 suggestions (using an Ajax-request)
In-Reply-To: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14242-70-hXQsRu2Bmv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #132 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Victor Grousset/tuxayo from comment #128)
> a.
> That's odd, I'm getting the autofill even with OPACSuggestionAutoFill off.
> 


Fixed in latest follow-up
> 
> b.
> > press the edit icon next to the field
> 
> Where is the icon actually? Is that the Search Google Books button?

A step from an old test plan - yes it is the search button, I've reworded the
test plan.

> 
> c.
> Maybe an issue
> 
> 
> d.
> Found something else that should be related and easy to reproduce
> 
> e.
> When clearing the form, should the ISBN also be cleared?

I've added a follow-up to clear the ISBN.

> 
> 
> f.
> I can still reproduce the issue from comment 117

I was not able to reproduce c, d or f. 

Can you please re-test?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:07:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:07:55 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-4IDnExKk6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115381|0                           |1
        is obsolete|                            |

--- Comment #136 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125383&action=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work
Update6: Merge conflicts and making sure export of default auth type
works
Update7: Fixing merge conflicts and updating buttons to bootstrap3

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) Import into your new authority type using the file you just exported
7) Confirm you are taken to auth_tag_structure.pl
8) Go back to Authority types
9) Export your new authority type. View the exported file and confirm
the authtypecode has been updated to match the code you set for the new
auth type
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:03 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-yF7LXcY1ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115382|0                           |1
        is obsolete|                            |

--- Comment #137 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125384&action=edit
Bug 13952: (follow-up) Fixing authority type import

This patch fixes the comments from Comment 29 and the import
functionality. You should now be able to import an exported file without
editing the file at all and the authority type code will be overwritten
in the file (same behaviour as biblio frameworks).

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:10 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-HQx8rVBhi4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115383|0                           |1
        is obsolete|                            |

--- Comment #138 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125385&action=edit
Bug 13952: (follow-up) Fixing import for default auth type

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:17 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-ALfqhsa3Ee@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115384|0                           |1
        is obsolete|                            |

--- Comment #139 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125386&action=edit
Bug 13952: (follow-up) Fixing export on default biblio framework

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:25 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-1gpKSgF8Q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115385|0                           |1
        is obsolete|                            |

--- Comment #140 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125387&action=edit
Bug 13952: (follow-up) template filters, moving js to separate file

This patch adds filters to the template file and moves the JS into a
separate file.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:34 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-LBsKkAcBPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115386|0                           |1
        is obsolete|                            |

--- Comment #141 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125388&action=edit
Bug 13952: (follow-up) Tests

Run:
prove -v t/db_dependent/ImportExportFramework.t and confirm all tests
pass.

I've also added a fix to remove the warns when exporting in ODS format.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:40 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-QQkQTyG2ut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115387|0                           |1
        is obsolete|                            |

--- Comment #142 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125389&action=edit
Bug 13952: (follow-up) Removing XML options

Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:08:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:08:46 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-gU9izC8cxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115388|0                           |1
        is obsolete|                            |

--- Comment #143 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125390&action=edit
Bug 13952: (follow-up) fixing indentation and rebasing

Signed-off-by: Mazen Khallaf <mazen.i.khallaf at gamil.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 06:09:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 04:09:55 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-tGbgT70Fs5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #144 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I've rebased the patches so they should apply now, however importing authority
frameworks seems to be broken. I'll fix this tomorrow.

Aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 08:19:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 06:19:38 +0000
Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts?
In-Reply-To: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28822-70-5nUBCbzeUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Agnes, we don't use the first importance field actively - low is just the
default and you can ignore it. (I think we cannot hide it :( ) The second
category 'normal' is what we are actually using.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 08:23:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 06:23:14 +0000
Subject: [Koha-bugs] [Bug 28822] SIP logins add to login attempts?
In-Reply-To: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28822-70-mTthJAsg38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28822

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am updating to 'major' to get more attention on this. FailedLoginAttempts
should be a recommended security measure to avoid brute force attacks on patron
accounts and if I understand it correctly, this bug will prevent libraries with
self checks (some require login) etc. from using it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 08:46:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 06:46:56 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-fgCoOrbK0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
A agree 100%, but I think we should trim also trailing whitespaces, like in
check-out :
https://git.koha-community.org/Koha-community/Koha/src/commit/870e3e8e161f6da998c1deae216d7fdf0d0490e7/circ/circulation.pl#L159

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 08:50:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 06:50:20 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-3kLyq6zDN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
---
a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++
b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -655,10 +655,19 @@ Circulation:
             - pref: StoreLastBorrower
               default: 0
               choices:
+        -
                   1: Store
                   0: "Don't store"

This change is a mistake no ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 08:59:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 06:59:09 +0000
Subject: [Koha-bugs] [Bug 28692] Reduce DB action_log table size
In-Reply-To: <bug-28692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28692-70-ZvPTzPl4Ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Looks great.

But :
Koha/Item.pm
-          : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " .
Dumper( $self->unblessed ) );
+          : logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " .
$self );

This is a string concatenation, seems wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 09:22:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 07:22:07 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-nBPXBKxz6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 09:22:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 07:22:11 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-nW21Bx7VCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125341|0                           |1
        is obsolete|                            |

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125391&action=edit
Bug 29116: Use a pre-existing accessor instead of reimplementing it

We can use the Koha::Patron::is_expired accessor instead of re-writing
it in request.pl.

To test:
 1) Make that a warning is being shown with and without this patch
    when placing a hold to an expired patron account

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 09:56:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 07:56:10 +0000
Subject: [Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed
 values for keys in some cases
In-Reply-To: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28700-70-wWTS77Ag8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #15)
> Thus, my proposal would be
> 
> for my $k (keys %res) {
>   $res{$k} = "$res{$k}";
> }

What's the cost of that? What's the side-effects (casting float to string for
instance)?

I would like to keep a pragmatic and safe approach for backport. If we all
agree that the explicit ->discard_changes call is a simple and good idea, let's
go with that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 09:59:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 07:59:20 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-x46tnfizfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #6)
> I am not sure about the consequences of removing the warn - so not going to
> comment on that. But having a way to tell users that their data needs fixing
> is probably a good thing, given that Koha explodes badly when those items
> slip through in some areas.

misc/maintenance/search_for_data_inconsistencies.pl is catching that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:04:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:04:08 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-2CWXspkODg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
If you want to get rid of this method you should get rid of item-level_itypes
first :D

Long standing discussion
https://lists.koha-community.org/pipermail/koha-devel/2015-December/042114.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:07:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:07:52 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-oFXmhf4Xgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #8)
> If you want to get rid of this method you should get rid of
> item-level_itypes first :D
> 
> Long standing discussion
> https://lists.koha-community.org/pipermail/koha-devel/2015-December/042114.
> html

Yes, long standing :) I am for killing the system preference, but we do require
teh item type on record level for a number of features by now, so not sure we
could get rid of all the effective itemtype handling.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:08:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:08:44 +0000
Subject: [Koha-bugs] [Bug 29116] request.pl re-invents
 Koha::Patron::is_expired accessor
In-Reply-To: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29116-70-Q7f7v9jM0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29116

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Always better not to re-invent the wheel :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:11:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:11:42 +0000
Subject: [Koha-bugs] [Bug 27585] Adding multiple items doesn't update total
 cost
In-Reply-To: <bug-27585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27585-70-YTuFO3ccs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27585

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:17:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:17:33 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-YvFz7Ty07e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
The idea was to have biblioitems.itemtype always populated and accurate (done
when upgrading and when a new item is created). No need to check anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:29:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:29:23 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-oNUPyItlri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure we can have it always accurate - I know libraries use this a lot
for records without items (articles, electronic resources, series records, set
records, etc.), so manual interaction will always be required there to make it
accurate.

We could add an automatism to update the record level itemtype when all items
have the same itemtype - but this might not be what some libraries want (it
would fit ours). But if the itemtypes for the items are different, this would
not work. 
Use case in academics: one item has a not for loan item type to always remain
in the library for reference, while additional copies can be checked out

I think especially in some French/UNIMARC libraries, there were different
authorised valued used for bibioitems (document type) and items - something we
would need to clarify is not an intended workflow and maybe help provide
workarounds for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:30:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:30:22 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-kqnmICrFzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm adding to that: as long we can't "save" 942$c from being overwritten by the
import, enforcing the itemtype on record level is quite an unsolvable issue for
us.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:31:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:31:26 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-MPqRQF1ep4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> misc/maintenance/search_for_data_inconsistencies.pl is catching that.

I know, but I think we need something more low level, that doesn't require
server side interaction for libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:43:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:43:14 +0000
Subject: [Koha-bugs] [Bug 28413] background job worker is running with all
 the modules in RAM
In-Reply-To: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28413-70-i2xlwAk3No@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121274|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125392&action=edit
Bug 28413: Reduce background job worker memory footprint

It's loading the modules in RAM then forks.
Then do not need it to have them loaded in the parent process (the
worker/daemon).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 10:44:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 08:44:43 +0000
Subject: [Koha-bugs] [Bug 28413] background job worker is running with all
 the modules in RAM
In-Reply-To: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28413-70-4aeezxXo8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice little improvement.. I too am looking forward to the next steps but I see
no reason to hold this step up.

Signing off.. tempted to go straight PQA as it's a trivially simple piece of
code to understand.. but I'll er on the side of caution and poke a fellow QA
team person to push it over the edge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 11:05:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 09:05:04 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-BxACxSQF29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #13)
> I don't recreate *on master*:
> 
>  - Create a biblio with title like "osteuropa:" or "osteuropa!"
>  - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl)
>    => Error
> 
> There is no error for me.

For the record, the error appears on the *OPAC* detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 11:07:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 09:07:02 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-IDiAQHgy2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
And I am still getting the error after applying this patch:

Unable to understand your search query, please rephrase and try again.
 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 100

In logs:
    ','type' => 'parse_exception'},'reason' => 'Failed to parse query
[(host-item:(osteuropa!))]','index_uuid' => '-iKfKTkGSwCClT_0bcKLdQ','type' =>
'query_shard_exception'},'node' => 'PCWsz1DTR6ybJJ3d0wR2YA'}],'t
ype' => 'search_phase_execution_exception','reason' => 'all shards failed'}}}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 11:07:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 09:07:42 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-LFip089jXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
There is also a QA script failure

 FAIL   Koha/SearchEngine/Zebra/QueryBuilder.pm                                 
   FAIL   pod                                                                  
                                          *** WARNING: =head2 without preceding
higher level  in file Koha/SearchEngine/Zebra/QueryBuilder.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 12:32:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 10:32:28 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-AdWC4wFZv4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125265|0                           |1
        is obsolete|                            |
 Attachment #125267|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125393&action=edit
Bug 28534: Fix engine for pending_offline_circulations table

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 28534: (follow-up) Don't adjust original DB update

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 12:44:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 10:44:11 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-zzgGla1ewc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125394&action=edit
Bug 29019: Restore eval call

But fix it (pass an arrayref). We need the eval to catch possible errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 12:52:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 10:52:55 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-YaCS1DlqdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#preventing_autofilling_with_autocompletenew-password

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 12:55:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 10:55:51 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-9kuXzER6eB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:00:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:00:51 +0000
Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in
 Additional Contents
In-Reply-To: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29042-70-tOxud6pPQO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:19:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:19:14 +0000
Subject: [Koha-bugs] [Bug 29106] Can we get rid of
 Koha::Item->effective_itemtype
In-Reply-To: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29106-70-rce4lrxanK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
HEA figures for item-level_itypes show that there is a very convincing number
of libraries to remove the pref.

28 NULL
16 (empty?)
239 0
11386 1

Btw the discussion for an default itemtype might be a topic on itself?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:23:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:23:45 +0000
Subject: [Koha-bugs] [Bug 27155] Biblio and Item hooks should pass a deleted
 object on record deletion
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-7A9qPwjHD1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:24:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:24:36 +0000
Subject: [Koha-bugs] [Bug 27155] Pass biblionumber too in item plugin hooks
 at deletion time
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-OhnYbbeJBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Biblio and Item hooks       |Pass biblionumber too in
                   |should pass a deleted       |item plugin hooks at
                   |object on record deletion   |deletion time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:35:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:35:33 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-BbFdAEGmfG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Isn't something ES can do internally? Did you investigate it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:38:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:38:03 +0000
Subject: [Koha-bugs] [Bug 27155] Pass biblionumber too in item plugin hooks
 at deletion time
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-ttCRld65Dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
In the meantime the hooks moved to Koha::Item when refactoring.
And the biblionumber is now available.
So, thats probably fine.

Might adjust the test a bit still?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:54:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:54:29 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-EfKEpcl61L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Pass biblionumber too in    |Include identifier test in
                   |item plugin hooks at        |Biblio_and_Items_plugin_hoo
                   |deletion time               |ks.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:54:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:54:51 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-fxBrsn7aKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Plugin architecture         |Test Suite

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:55:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:55:25 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-k9tYUFJrDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing title and even component ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:57:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:57:08 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-H2HntsY93C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:57:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:57:11 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-d57eDpjG9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125395&action=edit
Bug 27155: Include identifier test in Biblio_and_Items_plugin_hooks.t

The biblio and item action hooks pass a biblionumber or itemnumber now
to the plugin at time of deletion.
This patch adds a tiny refinement to Biblio_and_Items_plugin_hooks.t
and the associated test plugin to be sure of that.

Test plan:
Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:57:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:57:54 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-b5xMGflrtx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Joonas Kylmälä from comment #10)
> Created attachment 125309 [details] [review]
> Bug 29049: (QA follow-up) Remove excessive whitespace
> 
> Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Will be squashed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 13:58:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 11:58:18 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-A0ONPJqNoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Also will amend first patch to remove a trailing 'i':

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
index daf50d69a76..c48987677eb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ -53,7 +53,7 @@
                 <input type="hidden" name="borrowernumber" value="[%
hold.borrowernumber | html %]" />
                 <input type="hidden" name="biblionumber" value="[%
hold.biblionumber | html %]" />
                 [% IF Koha.Preference('HoldsSplitQueue') == "nothing" &&
!hold.found %]
-                    <select name="rank-request" class="rank-request"
data-hold-id="[% hold.reserve_id | html %]">i
+                    <select name="rank-request" class="rank-request"
data-hold-id="[% hold.reserve_id | html %]">
                     [% IF ( CAN_user_reserveforothers_modify_holds_priority )
%]
                         [% PROCESS priority_dropdown %]
                     [% ELSE %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:14:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:14:25 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-37I4N9tlEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:14:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:14:31 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-cZOgbfKFZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125395|0                           |1
        is obsolete|                            |

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125396&action=edit
Bug 27155: Include identifier test in Biblio_and_Items_plugin_hooks.t

The biblio and item action hooks pass a biblionumber or itemnumber now
to the plugin at time of deletion.
This patch adds a tiny refinement to Biblio_and_Items_plugin_hooks.t
and the associated test plugin to be sure of that.

Test plan:
Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:18:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:18:11 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-roz40etLg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125397&action=edit
Bug 29049: Remove reference to optionloop

It's no longer used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:20:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:20:52 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-yrBD0KF07A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:20:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:20:57 +0000
Subject: [Koha-bugs] [Bug 28321] Use template block for display of items in
 search results
In-Reply-To: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28321-70-jfM6jO0Jpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125370|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 125398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125398&action=edit
Bug 28321: Use template block for display of items in search results

This patch updates the staff interface catalog search results to use
a new reusable BLOCK for displaying item information: Available items,
checked-out items, and unavailable items.

Some style has been updated, and an old GIF image has been replaced with
an SVG. The hold ratios template has been updated to accommodate this
change.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Perform a catalog search in the staff interface which will return
  multiple results with multiple items each. For thorough testing, some
  records should have items which are checked out, available, or
  lost/notforloan.
- On the search results page, confirm that item information is accurate
  and readable.
- Test with  item-level_itypes on and off.
- Test with noItemTypeImages on and off.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:23:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:23:09 +0000
Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from
 5.0.16 to 5.5.1
In-Reply-To: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26949-70-BrGZZDPMpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
I've updated the remote branch again, this time with the upgrade taking us to
TinyMCE version 5.9.2.

> https://gitlab.com/koha-dev/koha-dev/-/tree/bug-26949-tinymce-upgrade

----------------------

Other than the required TinyMCE package files, the only other change is
to the internationalization include file, which is updated to include
the latest set of strings for translation.

To test, apply the patch and clear your browser cache if necessary.

Test that the TinyMCE editor works in the staff interface:

 - In system preferences, with the  UseWYSIWYGinSystemPreferences
   preference enabled: IntranetCirculationHomeHTML,
   IntranetmainUserblock, IntranetReportsHomeHTML, etc.
 - Additional contents, with the AdditionalContentsEditor preference
   set to "WYSIWYG."
 - Administration -> Libraries, in the "OPAC info" field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:26:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:26:41 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-Lomna6YhrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Straight QA. Trivial upgrade to tests I wrote.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:37:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:37:26 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-kfLHFRwzxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125371|0                           |1
        is obsolete|                            |
 Attachment #125372|0                           |1
        is obsolete|                            |
 Attachment #125373|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125399&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:37:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:37:41 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-SWxi77s0Pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125400&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:37:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:37:44 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-5wYwytoVvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125401&action=edit
Bug 28974: Hard code page = 1 instead of using javascript

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:38:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:38:37 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-p3naXKWO7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:41:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:41:12 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-apZ8CdkSFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125402&action=edit
Bug 29070: Use a variable to store the #666666 color

To prevent repetition

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:42:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:42:48 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-qNmInKrjSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hi Henry,
As we are reusing the same HTML color code (#666666) it seems better to create
a variable to reuse, instead of copying the same code everywhere. Better for
maintainability if we need to modify it later on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:47:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:47:04 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-dIjwrR8mZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27155


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155
[Bug 27155] Include identifier test in Biblio_and_Items_plugin_hooks.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:47:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:47:04 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-vOVOaFd8Ru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27173


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173
[Bug 27173] Add plugin hooks for authority record changes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:49:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:49:34 +0000
Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in
 Additional Contents
In-Reply-To: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29042-70-g0dhl7kqQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:49:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:49:38 +0000
Subject: [Koha-bugs] [Bug 29042] Improve formatting of entry form in
 Additional Contents
In-Reply-To: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29042-70-fEr8jju611@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124939|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 125403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125403&action=edit
Bug 29042: Improve formatting of entry form in Additional Contents

This patch makes some corrections to the Additional Contents template so
that the content entry form can be styled like other similar forms in
the staff interface.

The patch also updates the form's "title" field so that it is longer and
has a maxlength attribute matching the size of the table column.

To test, apply the patch and go to Tools -> News.

 - Create a new news item.
 - In the entry form, confirm that the "Title" and "Content" fields are
   styled consistently with other similar forms.
 - Confirm that the "title" field is longer.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 14:50:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 12:50:36 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-hdZb2csbOq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|Passed QA                   |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Why in French?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:15:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:15:36 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-3rnIIuaaab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #49)
> (In reply to Joonas Kylmälä from comment #44)
> > (In reply to Martin Renvoize from comment #41)
> > > Created attachment 125115 [details] [review] [review] [review]
> > > Bug 28803: (QA follow-up) Reinstate UNKNOWN_ERROR in templates
> > > 
> > > I can't see how this will ever get thrown, but as it's there we should
> > > have the template handling included.
> > 
> > If the SMTP server is unavailable it at least comes.
> 
> Really?  I didn't think that was the case when calling 'create'.. if it is
> the case I don't understand why, we don't do anything with the SMTP server
> until the call to send_or_die.
> 
> It doesn't cause any harm having this, but I still haven't been able to
> trigger it myself.

I confirm it's needed:

https://snipboard.io/10dPzT.jpg


kohadev-koha at kohadevbox:/kohadevbox/koha$ perl
misc/cronjobs/process_message_queue.pl 
unable to establish SMTP connection to (localhost) port 25

Trace begun at /usr/share/perl5/Email/Sender/Transport/SMTP.pm line 224
Email::Sender::Transport::SMTP::_throw('Email::Sender::Transport::SMTP=HASH(0x55bd3b7b9bd0)',
'unable to establish SMTP connection to (localhost) port 25') called at
/usr/share/perl5/Email/Sender/Transport/SMTP.pm line 174

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:20:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:20:15 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-ipZodTiUvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123185|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125404&action=edit
Bug 23678: Allow cancel holds in bulk

This patch allows staff patrons to cancel multiple holds in bulk.

To test:
1. Apply this patch
2. restart_all
3. In cataloge go to a book and place many holds
CHECK => Holds table shows a column of checkboxes
4. Play with checkboxes (have some fun ;-P)
CHECK => When you manually check all checkboxes, the checkbox in the
header also gets checked.
      => When you uncheck one of the checkboxes, the one in the header also
gets unchecked.
      => If no checkbox is checked and you check the one in the header,
all checkboxes get checked.
      => If there are some checkboxes that are checked and others are
not, when you click on the checkbox in the header all checkboxes get
unchecked.
      => If all checkboxes are checked, when you uncheck the one in the
header, all checkboxes get unchecked.
      => Every time you play with checkboxes, the number in the button
"Cancel selected" changes.
5. Check some of the checkboxes and click on cancel selected.
SUCCESS => A background job gets fired to cancel all selected holds.
        => A message should appear with a link to the job.
6. Wait a few seconds and click on the link
SUCCESS => A message appears with the report of the execution of the
background job.
7. Grab a patron and search to hold
8. Select multiple biblios and click on "place hold for <patron>"
CHECK => After holds are confirmed, multiple holds table are shown.. one for
   each record. Checkboxes work exactly the same as before, but scoped
for each individual table. Checkboxes from one table will not affect
checkboxes from other tables.
9. Repeat steps 4 to 6.
10. Check In some of the items so the get in Waiting state.
11. Update expirationdate os some of those holds and set it to
    ReservesMaxPickUpDelay + 1 days earlier
NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update
would be
     => update reserves set expirationdate = date_sub(expirationdate, interval
8 day) where reserve_id in (...)
12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:20:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:20:19 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-L1mYtgTEwT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123186|0                           |1
        is obsolete|                            |

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125405&action=edit
Bug 23678: (QA follow-up) Add missing template filter

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:20:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:20:24 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-ZqZxYIqJ0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123187|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125406&action=edit
Bug 23678: (QA follow-up) Add missing filters

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:21:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:21:51 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-qRzTTTjdG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This works as expected and passes QA scripts. I can't see any evidence of
previous background jobs having associated tests so the lack of a unit test
here seems reasonable.. but it did make me wonder.

Passing QA and differing to RM regards tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:26:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:26:24 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-Bjf77wt4QD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

jeremy <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125378|0                           |1
        is obsolete|                            |

--- Comment #2 from jeremy <jeremy.breuillard at biblibre.com> ---
Created attachment 125407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125407&action=edit
Bug 29128: Remove whitespace in browse shelf link

To test:
-Turn on OPACShelfBrowser and make sure you have some itemcallnumbers
-Go to detail page and see the link: (Browse shelf )
-Apply patch and look at the link again, it should be: (Browse shelf)

Signed-off-by: Jeremy <jeremy.breuillard at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:26:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:26:31 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-XkinwkuQ1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

--- Comment #3 from jeremy <jeremy.breuillard at biblibre.com> ---
Created attachment 125408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125408&action=edit
Bug 29128 : Remove the other whitespace in browse shelf link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:30:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:30:16 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-rfcMoSZ00V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

jeremy <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeremy.breuillard at biblibre.
                   |                            |com

--- Comment #4 from jeremy <jeremy.breuillard at biblibre.com> ---
Another occurence found and fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:01 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-9Pr8WtwjDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:04 +0000
Subject: [Koha-bugs] [Bug 27279] "Checked out by" not populated on
 issuehistory.pl
In-Reply-To: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27279-70-4iEXMcamZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:06 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-xVskphAbbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:09 +0000
Subject: [Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in
 cataloguing plugin
In-Reply-To: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27461-70-Cetg2Zz4i7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:11 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-kajmugIqYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:14 +0000
Subject: [Koha-bugs] [Bug 28438] Capitalization: Various corrections
In-Reply-To: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28438-70-FcrQJ0fvCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:16 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-g8u9qGj7zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:19 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-UdewHIAcPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:21 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-pqtgQ9zrxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:24 +0000
Subject: [Koha-bugs] [Bug 28534] pending_offline_circulations table uses
 MyISAM engine
In-Reply-To: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28534-70-rCLxOt88zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:27 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-duELt2Q8ys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:30 +0000
Subject: [Koha-bugs] [Bug 28803] process_message_queue.pl dies if any
 messsages in the message queue contain an invalid to_address
In-Reply-To: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28803-70-5xM2nC1hOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:32 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-6jCK5UAyB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:35 +0000
Subject: [Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII
 characters in display-name of reply-to address
In-Reply-To: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28870-70-Mby9VO62RH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870

--- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:38 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-or0HOqX0Qt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:41 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-I3hgrtohmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:43 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-bZhcPtWnBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:46 +0000
Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not
 consistent
In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28934-70-dOssreHkRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:48 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-RhWYL91YTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:51 +0000
Subject: [Koha-bugs] [Bug 28940] IntranetUserJS is called twice on
 spinelable-print.tt
In-Reply-To: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28940-70-edUdS26BR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:54 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-3YXAlpUONT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:56 +0000
Subject: [Koha-bugs] [Bug 29019] Unable to delete HTML customization
In-Reply-To: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29019-70-QQax9uFK4V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:38:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:38:59 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-L6sGISUnlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:02 +0000
Subject: [Koha-bugs] [Bug 29025] Saved auth login and password are
 pre-filled in patron creation form
In-Reply-To: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29025-70-3Bv057HJ2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:04 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-18zlEt9QVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:07 +0000
Subject: [Koha-bugs] [Bug 29026] Behavior change when an empty barcode field
 is submitted in circulation
In-Reply-To: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29026-70-W4tiZJbOeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:09 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-mXP7dIuuuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:12 +0000
Subject: [Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have
 sufficient contrast ratio
In-Reply-To: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29034-70-xrhnjjNmUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:14 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-pIPke0gVQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:17 +0000
Subject: [Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label
 doesn't have sufficient contrast ratio
In-Reply-To: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29035-70-fQ5zBvwCMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:19 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-HQ9pRPpzSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:21 +0000
Subject: [Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have
 sufficient contrast
In-Reply-To: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29037-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29037-70-YAKsegKffb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:24 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-6cNdTC3JrI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:26 +0000
Subject: [Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading
 doesn't have sufficient contrast
In-Reply-To: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29038-70-oG8rgJGG8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:29 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-1m6JvcBkvA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:31 +0000
Subject: [Koha-bugs] [Bug 29049] Holds page shows too many priority options
 in pulldown
In-Reply-To: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29049-70-fl89xTizRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29049

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:34 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-QuXIWnQhcn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:36 +0000
Subject: [Koha-bugs] [Bug 29056] Remove demo functionality remnants
In-Reply-To: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29056-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29056-70-4kVBvYNUqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:39 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-KR1S121R1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:41 +0000
Subject: [Koha-bugs] [Bug 29064] OPAC duplicate "Most popular titles" in
 <title> tag
In-Reply-To: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29064-70-izMGqp232R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29064

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:43 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-gm3LsFzTEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:46 +0000
Subject: [Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history
 link has insufficient contrast
In-Reply-To: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29065-70-1X4cTFSjrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:48 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-rGPFR1zl5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:51 +0000
Subject: [Koha-bugs] [Bug 29067] Remove duplicate conditional statement from
 OPAC messaging settings title
In-Reply-To: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29067-70-QPGWeVJ3tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29067

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:53 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-Nm7hWyf2tO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:55 +0000
Subject: [Koha-bugs] [Bug 29068] Accessibility: OPAC search results summary
 text has insufficient contrast
In-Reply-To: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29068-70-PqCxEyRmYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29068

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:39:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:39:58 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-rqh9UAaCXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:00 +0000
Subject: [Koha-bugs] [Bug 29070] Accessibility: OPAC Purchase Suggestions on
 search results page has insufficient contrast
In-Reply-To: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29070-70-x4EpvSXS4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:03 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-SofNGiMyrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:06 +0000
Subject: [Koha-bugs] [Bug 29073] Hold expiration added to new holds when
 DefaultHoldExpirationdate turned off
In-Reply-To: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29073-70-Nau7OqVClx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:08 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-MbSQCJiDNb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:11 +0000
Subject: [Koha-bugs] [Bug 29076] cleanup_database.pl dies of passed
 zebraqueue and not confirm
In-Reply-To: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29076-70-yrhUC0RYlc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29076

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:14 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-Z9cFd8yxNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:16 +0000
Subject: [Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
In-Reply-To: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29078-70-5lYYyqC2Zz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:19 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-oGXXQh7D1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:40:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:40:21 +0000
Subject: [Koha-bugs] [Bug 29091] Correct display of lists and tags on search
 results
In-Reply-To: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29091-70-6yvDpWJdoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:44:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:44:36 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-9unKfmuu7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:44:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:44:40 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-9y5Tr6wBuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125409&action=edit
Bug 27173: Add plugin hooks for authority record changes

2021-09-28 Updated version

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:44:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:44:43 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-SeSp4GX9ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125410&action=edit
Bug 27173: Add tests

Test plan:
Run t/db_dependent/Koha/Plugins/authority_hooks.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:45:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:45:58 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-5AhTDSwxVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #5)
> Isn't something ES can do internally? Did you investigate it?

There is a facet order option, however, many of our facets are authorised
values that we convert to display names, i.e. branchcodes into branchnames

Sorting in ES would be based on the codes and not the display values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 15:50:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 13:50:03 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-osDhCwOaar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows
      release notes|                            |plugin authors to implement
                   |                            |an `after_authority_action`
                   |                            |method in order to act upon
                   |                            |authority create, modify
                   |                            |and delete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:01:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:01:36 +0000
Subject: [Koha-bugs] [Bug 18787] Create permission profiles for staff users
In-Reply-To: <bug-18787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18787-70-0kVObCpugt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:11:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:11:29 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-tLzoVgdNQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125409|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125411&action=edit
Bug 27173: Add plugin hooks for authority record changes

2021-09-28 Updated version

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:11:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:11:32 +0000
Subject: [Koha-bugs] [Bug 27173] Add plugin hooks for authority record
 changes
In-Reply-To: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27173-70-R0ekHw3xVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125410|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125412&action=edit
Bug 27173: Add tests

Test plan:
Run t/db_dependent/Koha/Plugins/authority_hooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:28:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:28:16 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
 adding on order item to existing record
In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20817-70-cs3d8WIZxF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:30:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:30:31 +0000
Subject: [Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from
 borrower holds list
In-Reply-To: <bug-27734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27734-70-KDbYrgjY6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:40:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:40:45 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-8uDMX0hLIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125234|0                           |1
        is obsolete|                            |

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 125413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125413&action=edit
Bug 15812: Use patron search in place of circ search

The 'Checkout' search hijacks some of the DataTables searching code used for
'Search patrons'
Rather than try to implement the search again on another page, we can simply
send the user
to the patron search if the cardnumber is not found

Additionally, this patch adds a 'Check out' button to the patron search results
to allow
going to checkotus directly

To test:
1 - Apply patch
2 - Perform a 'Checkout' search from the header
3 - Note that:
    For a cardnumber, you are redirected directly to checkouts page for the
borrower
    For a search with one result, you are redirected directly to the checkout
page for the borrower
    For a search with many results, you are redirected to the patron search
results
    and there is a 'Checkout' button under the cardnumber
4 - Confirm circulation page works as expected (i.e. checkout to a patron)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:43:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:43:13 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-7pAqgkfXuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from George Williams (NEKLS) <george at nekls.org> ---
Tested on the biblibre sandboxes and the test plan goes as expected.  Nice fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:57:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:57:59 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-nSqtAKjHrP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125399|0                           |1
        is obsolete|                            |
 Attachment #125400|0                           |1
        is obsolete|                            |
 Attachment #125401|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125414&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:58:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:58:18 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-RLLxFwGyoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125415&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 16:58:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 14:58:21 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-BsDLSHNvAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125416&action=edit
Bug 28974: Hard code page = 1 instead of using javascript

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:10:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:10:04 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18984-70-ztKNjF0AmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
>From IRC - http://irc.koha-community.org/koha/2021-09-22

07:31   Joubu   magnuse: Hi! Can I finally push bug 18984?
07:31   Joubu   magnuse: I need it for bug 27622
11:20   magnuse Joubu: hm, we have not converted our normarc libraries to marc
21 yet. on the other hand, having to convert before upgrading to 21.11 just
might be the stick we need to get the conversions done...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:12:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:12:43 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18984-70-1dvudN84Xy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120397|0                           |1
        is obsolete|                            |
 Attachment #120398|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125417&action=edit
Bug 18984: Remove NORMARC support

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:12:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:12:47 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18984-70-slCrfhKnK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125418&action=edit
Bug 18984: Remove ES mapping for NORMARC

perl misc/search_tools/export_elasticsearch_mappings.pl >
admin/searchengine/elasticsearch/mappings.yaml
grep -v 'mandatory: ~' admin/searchengine/elasticsearch/mappings.yaml|grep -v
'opac: 1'|grep -v 'staff_client: 1'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:13:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:13:10 +0000
Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC
In-Reply-To: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18984-70-3O9vYAgXca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:23:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:23:22 +0000
Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data
In-Reply-To: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27622-70-PSgNzSc0dx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:26:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:26:20 +0000
Subject: [Koha-bugs] [Bug 27101] Remove fr-CA installer data
In-Reply-To: <bug-27101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27101-70-mYdnzIdwiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate,
                   |                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:26:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:26:32 +0000
Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data
In-Reply-To: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27622-70-cfZMXsBl3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Ready for testing on the following remote branch (too big, cannot attach here):
https://gitlab.com/joubu/Koha/-/commits/bug_27622

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:26:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:26:49 +0000
Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data
In-Reply-To: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27622-70-xbsm4arVMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate,
                   |                            |RM_priority
           Severity|minor                       |enhancement
           Assignee|magnus at libriotech.no        |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 17:58:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 15:58:33 +0000
Subject: [Koha-bugs] [Bug 29129] New: The printclearscreen icon on
 circulation.tt should be configuarable to print either ISSUESLIP or
 ISSUEQSLIP
Message-ID: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129

            Bug ID: 29129
           Summary: The printclearscreen icon on circulation.tt should be
                    configuarable to print either ISSUESLIP or ISSUEQSLIP
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The printclearscreen icon which appears when the system preference
'DisplayClearScreenButton' should allow users to choose between printing the
ISSUESLIP and ISSUEQSLIP, if that system pref is turned on. 

I think the 'DisplayClearScreenButton' could have 3 options:
-Don't show
-Show and print ISSUESLIP
-Show and print ISSUEQSLIP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:02:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:02:36 +0000
Subject: [Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt
 should be configuarable to print either ISSUESLIP or ISSUEQSLIP
In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29129-70-RgbAalfLyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:12:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:12:48 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-NFxZItHeG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124915|0                           |1
        is obsolete|                            |
 Attachment #124916|0                           |1
        is obsolete|                            |
 Attachment #124917|0                           |1
        is obsolete|                            |
 Attachment #124918|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125419&action=edit
Bug 29015: Add options for itemtpye, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
    "### items found for All libraries and item type:(Books)"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:13:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:13:46 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-nEFOj00IOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125419|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125420&action=edit
Bug 29015: Add options for itemtype, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
    "### items found for All libraries and item type:(Books)"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:13:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:13:58 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-sl28RmJcnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125421&action=edit
Bug 29015: Unit tests

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:14:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:14:02 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-qQUJvc9aFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125422&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:14:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:14:06 +0000
Subject: [Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by
 shelving location / collection
In-Reply-To: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29015-70-EbqhMQsiRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125423&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:20:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:20:11 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-XklZUP5zTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125414|0                           |1
        is obsolete|                            |
 Attachment #125415|0                           |1
        is obsolete|                            |
 Attachment #125416|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125424&action=edit
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this
number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible
and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:20:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:20:23 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-01EYvLv79F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125425&action=edit
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:20:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:20:27 +0000
Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
In-Reply-To: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28974-70-JECaNurMDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125426&action=edit
Bug 28974: Hard code page = 1 instead of using javascript

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:34:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:34:50 +0000
Subject: [Koha-bugs] [Bug 29130] New: Holds queue is empty while holds queue
 builder is running
Message-ID: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

            Bug ID: 29130
           Summary: Holds queue is empty while holds queue builder is
                    running
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and
hold_fill_targets, then starts building the holds queue again. It seems
sensible to build the holds queue using temporary tables and copy the data over
afterward.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:34:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:34:55 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-Pm9vEGmwYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 18:54:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 16:54:48 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-DRta9ZOf3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125427&action=edit
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and
hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the
data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:11:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:11:30 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-ECOecF81zl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:11:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:11:34 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-Ryb0mWmPIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125407|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 125428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125428&action=edit
Bug 29128: Remove whitespace in browse shelf link

To test:
-Turn on OPACShelfBrowser and make sure you have some itemcallnumbers
-Go to detail page and see the link: (Browse shelf )
-Apply patch and look at the link again, it should be: (Browse shelf)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:11:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:11:38 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-jlNiuU5rO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125408|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 125429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125429&action=edit
Bug 29128 : Remove the other whitespace in browse shelf link

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:15:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:15:20 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-nWjRhGshG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to jeremy from comment #4)
> Another occurence found and fixed

Thanks Jeremy for fixing this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:53:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:53:53 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-S9GpGR6gsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125427|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125430&action=edit
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and
hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the
data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 19:55:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 17:55:55 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-Yd5bFSrmzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125430|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125431&action=edit
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and
hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the
data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 20:11:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 18:11:27 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-OJH5ceuMY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 20:11:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 18:11:30 +0000
Subject: [Koha-bugs] [Bug 29130] Holds queue is empty while holds queue
 builder is running
In-Reply-To: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29130-70-XWBgmyVH70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29130

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125431|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125432&action=edit
Bug 29130 - Holds queue is empty while holds queue builder is running

When build_holds_queue.pl, it first deletes all rows from tmp_holdsqueue and
hold_fill_targets,
then starts building the holds queue again.
It seems sensible to build the holds queue using temporary tables and copy the
data over afterward.

Test Plan:
1) Apply this patch
2) Run the holds queue builder
3) Verify holds queue was was populated
4) prove t/db_dependent/HoldsQueue.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 20:38:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 18:38:28 +0000
Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from
 5.0.16 to 5.5.1
In-Reply-To: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26949-70-1dNyUAyRzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

--- Comment #6 from David Nind <david at davidnind.com> ---
Hi Owen.

I've retested and happy to sign-off.

The only minor thing noted was the version number for TinyMCE needs updating in
the about page.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:20:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:20:39 +0000
Subject: [Koha-bugs] [Bug 28075] Add missing UNIMARC for coded data 135a
In-Reply-To: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28075-70-lVj05l3lnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28075

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #6)
> Why in French?

Oops!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:36:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:36:27 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-ByUzkER3s7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:36:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:36:31 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-Ni4Mcu3VTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124379|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125433&action=edit
Bug 28484: ES clean title in biblio detail

Test plan:
 - Create a biblio with title like "osteuropa:" or "osteuropa!"
 - Go the this biblio detail pages (cgi-bin/koha/catalogue/detail.pl)
   => Error
 - Apply bug 28316 and this one
 - test again

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:36:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:36:35 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-OxKPCe2Jms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125434&action=edit
Bug 28484: (QA follow-up) Add fix on OPAC

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:36:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:36:39 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-L32qhOdbwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125435&action=edit
Bug 28484: (QA follow-up) POD fix

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:56:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:56:17 +0000
Subject: [Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate
 for staff and OPAC
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-FRVg3qD8cE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
This only works for me if I turn on an additional image service, like Amazon.
Both detail.tt and results.tt have a line like:

[% IF ( AmazonCoverImages  || LocalCoverImages || AdlibrisEnabled ||
(Koha.Preference('CustomCoverImages') && Koha.Preference('Cu   
stomCoverImagesURL')) ) %]

I *think* BakerTaylorEnabled should be added there because B&T should be able
to display without any of the other cover image services turned on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 22:57:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 20:57:39 +0000
Subject: [Koha-bugs] [Bug 29131] New: Row striping breaks color coding on
 item circulation alerts
Message-ID: <bug-29131-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131

            Bug ID: 29131
           Summary: Row striping breaks color coding on item circulation
                    alerts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
Browse to Administration->Item circulation alerts

Note that 'Disabled for all' and 'Enabled' are the same color in the key

Note that half the rows are gray


Seems to be from:
tbody tr:nth-child(odd):not(.dtrg-group):not(.active)
td:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary)
{
 background-color:#f9f9f9;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 23:04:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 21:04:41 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-G9G9nMXIMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124010|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 23:05:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 21:05:10 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-dt4NQC919G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #71 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 125436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125436&action=edit
Bug 26346: (follow-up) Fixes in response to QA

* Fix addressing comment #59 - Making can_be_deleted() consistent to
testing Patrons::find

* Fix addressing comment comment #61 - Have made the first and second
lines consistent, both now return 0

Sponsord-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 23:10:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 21:10:17 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if colon
 or exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-9YX3AUj6ER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Sep 28 23:25:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 21:25:19 +0000
Subject: [Koha-bugs] [Bug 29131] Row striping breaks color coding on item
 circulation alerts
In-Reply-To: <bug-29131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29131-70-akcbgaW4cf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 01:25:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Sep 2021 23:25:10 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-Jj69vzdyh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #72 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Rebased the last patch against master. Whole patchset applies cleanly now. 

I'm working on adding a single 'allowed_to_change' column as suggested by
Tomás.

I think the 'allowed_to_change' column should have four values ENUM('nobody',
'owner','everyone','staff')?

This is because 'Nobody' is an option available in the 'Allow changes to
contents from' dropdown when creating a list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 05:37:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 03:37:16 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-buT1dJJW82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 05:37:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 03:37:21 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-dzNw43ZX5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118264|0                           |1
        is obsolete|                            |

--- Comment #45 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125437&action=edit
Bug 20844: Revert or cancel lost holds

This patch introduces the RevertLostBibLevelHolds syspref. When an item
is marked as lost, if there is a bib-level hold on it waiting, the hold
is reverted. If there is an item-level hold on it waiting, there is an
alert box asking if the library would like to revert the hold or cancel
it.

Test:

1) Update database and restart memcached/plack
2) Place a hold on Biblio A
3) Check in Item A from Biblio A and set the hold as waiting
4) Edit Item A and give it a lost status (952$1, you may need to edit
    your MARC frameworks to have this visible in the Editor)
5) Look at your hold. Notice it is still waiting.
6) Go to Administration -> System preferences. Find the
RevertLostBibLevelHolds system preference and enable it.
7) Cancel your hold and remove Item A's lost status. Place another biblio-level
hold on the same biblio
8) Check in Item A from Biblio A and set the hold as waiting
9) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
10) Edit Item A and give it a lost status
11) Once the page reloads, go to view your hold. It should no longer be
waiting and have no item allocated.
12) Cancel your hold and remove Item A's lost status. Place an item-level hold
on Item A
13) Check in Item A and set the hold as waiting
14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
15) Give Item A a lost status and save changes
16) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
17) Confirm your hold is no longer waiting, but the item is still
allocated
18) Remove Item A's lost status
19) Check in Item A and set the hold as waiting
20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
21) Give Item A a lost status and save changes
22) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
23) Confirm the hold is now cancelled
24) Remove Item A's lost status
25) Place an item-level hold on Item A
26) Check in Item A and set the hold as waiting
27) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
28) Give Item A a lost status and save changes
29) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
30) Confirm your hold is no longer waiting, but the item is still
allocated
31) Remove Item A's lost status
32) Check in Item A and set the hold as waiting
33) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
34) Give Item A a lost status and save changes
35) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
36) Confirm the hold is now cancelled
37) Remove Item A's lost status
38) Place an item-level hold on Item A. Check in Item A and set the hold
as waiting
39) Place an item-level hold on Item B (same biblio) for another borrower.
Check in
Item B and set the hold as waiting.
40) Give both Items A and B lost statuses.
41) Confirm that both Items are included in the alert box on page when
editing items (cataloguing/additem.pl)
42) Confirm that both Items have individual alert boxes on the Items tab
(catalogue/moredetail.pl)
43) Confirm tests pass t/db_dependent/Reserves.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 05:37:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 03:37:27 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-zCrRhrJIaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118265|0                           |1
        is obsolete|                            |

--- Comment #46 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125438&action=edit
Bug 20844: (follow-up) SendLostHoldNotices

This patch adds a new syspref SendLostHoldNotices

Test:
1) Update database and restart memcached
2) Enable the SendLostHoldNotices system preference
3) Place a hold on an item
4) Check in the item and set the hold to waiting
5) Go to edit the item and set an item lost status
6) Check the borrower's notices and confirm the notice has been enqueued
7) Confirm the notice is not sent twice when reverting or cancelling the
hold
8) Confirm notice enqueues as expected for a bib-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 05:37:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 03:37:33 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-CRx8nrGx5k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118266|0                           |1
        is obsolete|                            |

--- Comment #47 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125439&action=edit
Bug 20844: (follow-up) Get working with transfers

Test:

1) Change branch to Branch B
2) Place a biblio-level hold at Branch B
3) Change branch to Branch A
4) Check in item at Branch A and set waiting and trigger transfer
5) Go to edit item and set item as lost
6) Check borrower's notices tab and confirm the lost_waiting_hold notice
was enqueued
7) Follow test plan again with item-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:21 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-uX3vmhdDlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:26 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-UsZdkl5zwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123026|0                           |1
        is obsolete|                            |

--- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125440&action=edit
Bug 27266: Move GetMarcAuthors to Koha namespace

This patch moves C4::Biblio::GetMarcAuthors to
Koha::Biblio->get_authors_from_MARC. This is so the method can be
used in templates and notices.

To test:
1. Find a record that has an author in the added entry field (700-720).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm authors show as
normal.
4. Click 'send' and confirm the email sent shows the authors as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the authors as normal.
6. Set the OPACXSLTDetailsDisplay system preference to empty (for no
xslt)
7. Log in to the OPAC. Find the record and add it to the cart and a list
8. View the cart and click 'more details'. Confirm authors show as
normal.
9. Click 'send' and confirm the email sent shows the authors as normal.
10. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the authors as normal.
11. View the record detail page and confirm the authors show as normal.
12. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:30 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-ug6FJyWBYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123027|0                           |1
        is obsolete|                            |

--- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125441&action=edit
Bug 27266: (QA follow-up) Rename to get_marc_authors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:34 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-iuxk4Icd2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123028|0                           |1
        is obsolete|                            |

--- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125442&action=edit
Bug 27266: (follow-up) Remove instances of GetMarcAuthors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:39 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-NvHT4Rwvw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123067|0                           |1
        is obsolete|                            |

--- Comment #23 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125443&action=edit
Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 06:48:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 04:48:43 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-Nw44l6e29e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

--- Comment #24 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125444&action=edit
Bug 27266: (follow-up) Show MARC author notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 09:34:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 07:34:52 +0000
Subject: [Koha-bugs] [Bug 29132] New: API access denied after update to
 19.11.22 due to not executed atomicupdate for api keys
Message-ID: <bug-29132-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132

            Bug ID: 29132
           Summary: API access denied after update to 19.11.22 due to not
                    executed atomicupdate for api keys
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alexander.borkowski at kau.se

After updating from 19.11.21 to 19.11.22, API access to our Koha instance
failed. The reason was that the
installer/data/mysql/atomicupdate/bug_28772_api_keys.pl was not executed,
likely due to the fact that installer/data/mysql/updatedatabase.pl only
executes files that end in .perl or .sql, while the new one ends in .pl.
Manually executing the equivalent code (hashing the API-keys) fixes the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 10:22:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 08:22:57 +0000
Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22
 due to not executed atomicupdate for api keys
In-Reply-To: <bug-29132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29132-70-P1TpWpBEBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132

--- Comment #1 from Alexander Borkowski <alexander.borkowski at kau.se> ---
Just renaming installer/data/mysql/atomicupdate/bug_28772_api_keys.pl to
installer/data/mysql/atomicupdate/bug_28772_api_keys.perl is not enough to fix
this. I did that, built local packages and now at least I get "DEV atomic
update: bug_28772_api_keys.perl" when I install the updated package, but the
API key secrets still remain unhashed.

As I wrote earlier extracting the relevant parts from that
installer/data/mysql/atomicupdate/bug_28772_api_keys.pl and executing them in a
short wrapper script (mainly for getting att C4::Context->dbh) works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 10:28:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 08:28:55 +0000
Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials
 statistics wizard
In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28216-70-u9frtQyYFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216

--- Comment #6 from Hinet Romain <romain.hinet-debain at univ-amu.fr> ---
Hi,
Without the patch I have the same message error trace, when clic to "serial
statistics wizards
https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:04:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:04:19 +0000
Subject: [Koha-bugs] [Bug 29133] New: Wrong string format in select2.inc
Message-ID: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

            Bug ID: 29133
           Summary: Wrong string format in select2.inc
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We are using 'max'/'min' when the arguments are 'maximum'/'minimum'.
Also using %n, %d when only %s is working in .format()

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:04:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:04:54 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-ZXi4R2S2PG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002
[Bug 29002] Add ability to book items ahead of time
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:04:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:04:54 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-vxoGlLU1ps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133
[Bug 29133] Wrong string format in select2.inc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:08:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:08:45 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-6J7IPBOEoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |25727
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727
[Bug 25727] Update the Select2 JS lib
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:08:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:08:45 +0000
Subject: [Koha-bugs] [Bug 25727] Update the Select2 JS lib
In-Reply-To: <bug-25727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25727-70-tb5TThCHxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133
[Bug 29133] Wrong string format in select2.inc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:11:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:11:53 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-EfRkMlRfKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:11:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:11:57 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-l2pjwynAF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125445&action=edit
Bug 29133: Correct select2 strings

We are using 'max'/'min' when the arguments are 'maximum'/'minimum'.
Also using %n, %d when only %s is working in .format()

Have a look at
https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js
It's Select2 v.4.0.13, the one we are using. We should match what's
there.

Test plan:
Bug 29002 is using minimumInputLength, you can see the difference when
selecting a patron:
 "Please enter %s or more characters"
vs
 "Please enter 3 or more characters"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:25:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:25:33 +0000
Subject: [Koha-bugs] [Bug 28510] Skip processing holds queue items from
 closed libraries when HoldsQueueSkipClosed is enabled
In-Reply-To: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28510-70-tW5NXb1tcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Some tests are failing randomly, please fix ASAP. See
https://jenkins.koha-community.org/job/Koha_Master_U20/191/consoleFull for
instance (Koha_Master_D11_CPAN as well).

#   Failed test 'take from lowest cost branch (don't use cost matrix) holding
branch'
#   at t/db_dependent/HoldsQueue.t line 1494.   
#          got: 'Dgj7iwys5'       
#     expected: 'qKpmffi'           
# Wrong pick-up/hold for first target (pick_branch, hold_branch, reserves,
hold_fill_targets, tmp_holdsqueue)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:25:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:25:35 +0000
Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials
 statistics wizard
In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28216-70-Q5r3LR7J0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ah another mistake :
DBD::mysql::st execute failed: 'aqbooksellers.name' isn't in GROUP BY

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:26:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:26:32 +0000
Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials
 statistics wizard
In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28216-70-5ptFcDKExo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120755|0                           |1
        is obsolete|                            |

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 125446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125446&action=edit
Bug 28216: Fix vendor list group by in serials statistics wizard

Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally
the group by.
Now vendors are repeated in the list.

Test plan :
1) Create several subscriptions for same vendor
2) Go to Reports > Serials
3) Check list of vendors
=> Without patch you see the same vendor several times
=> With patch you seen it once
4) Check sort is still on vendor name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:31:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:31:51 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if
 exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-PN7Q2RAyTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Elasticsearch fails to      |Elasticsearch fails to
                   |parse query if colon or     |parse query if exclamation
                   |exclamation point is in     |point is in 245$a
                   |245$a                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:44:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:44:27 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-cpDO4STNIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Please resubmit without the changes to opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 11:58:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 09:58:24 +0000
Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
In-Reply-To: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26351-70-I5saMZTptg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #100 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Failing test:

    #   Failed test 'Only four plugins found via a metadata tag'
    #   at /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t line 129.
    #          got: '2'
    #     expected: '4'
    # Looks like you failed 1 test of 2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:08:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:08:34 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-Ob3ww6STT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Error display change:

Before: https://snipboard.io/oGy94Y.jpg
After : https://snipboard.io/cN1FnV.jpg

Looks better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:09:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:09:06 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-AzTa3W4DoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Klas, is this patch answering your need? If not, please open a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:09:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:09:51 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-hWl5W9Fp2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patches will be squashed when pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:15:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:15:26 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-uYmsh0UwKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Joonas, don't you think we should have the same return than CanBookBeRenewed?

  ($boolean, $reason);

The 'return "no";' seems weird to me.

We could then replace:

    $auto_renew = _CanBookBeAutoRenewed($borrowernumber, $itemnumber);
    return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_account_expired';
    return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_too_late';
    return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_too_much_oweing';

with:

    my ( $can_be_auto_renewed, $reason ) =
_CanBookBeAutoRenewed($borrowernumber, $itemnumber);
    return ( 0, $reason ) unless $can_be_auto_renewed;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:19:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:19:17 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-05ewoLgI3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I can remove the 3 lines. That's why it was done that way. You certainly need
JS code to prevent that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:21:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:21:51 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-qusiJK0cn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Unfortunately there are several accessibility patches in the queue currently
that are modifying this template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:05 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-gg3xdJCcdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:08 +0000
Subject: [Koha-bugs] [Bug 27155] Include identifier test in
 Biblio_and_Items_plugin_hooks.t
In-Reply-To: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27155-70-xmCk97SFH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:10 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-pZ7otAOiD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:12 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-x6HHOep90v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:15 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if
 exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-2leGhHuPAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:17 +0000
Subject: [Koha-bugs] [Bug 28484] Elasticsearch fails to parse query if
 exclamation point is in 245$a
In-Reply-To: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28484-70-Ew1fAUOXBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28484

--- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:20 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-WISN3wQcgB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:23 +0000
Subject: [Koha-bugs] [Bug 28826] Facet sort order differs between search
 engines
In-Reply-To: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28826-70-rbLaHRXCq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:25 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-f4OVZMtRSr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:27 +0000
Subject: [Koha-bugs] [Bug 28933] Hard to parse OPAC-detail subscription
 information
In-Reply-To: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28933-70-lCBDmVLRTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28933

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:29 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-xDP9PiH7j3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |21.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:32 +0000
Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron
 pages
In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28937-70-lnKNXkLJ4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:34 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-5Zo1V3cpQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 12:44:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 10:44:36 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-8DDd74og14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:00:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:00:12 +0000
Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
In-Reply-To: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26351-70-w5pgGXyqWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #101 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 125447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125447&action=edit
Bug 26351: Revert improper change to unit test, fix number of tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:01:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:01:48 +0000
Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
In-Reply-To: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26351-70-vFXJpRQcFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:10:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:10:34 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-2k4HEDu8yG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #6)
> I can remove the 3 lines. That's why it was done that way. You certainly
> need JS code to prevent that.

+        if($(this).parent().parent().siblings().length < 2 ) {
            $('.ButtonLess').hide();

Please explain how to reproduce.
Or refresh browser cache etc ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:10:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:10:37 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-FhYgPn1M8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:10:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:10:40 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-rTuf88QilX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125288|0                           |1
        is obsolete|                            |
 Attachment #125290|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125448&action=edit
Bug 29093: Database revision for article_requests.toc_request

Test plan:
Run dbrev or new install.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:10:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:10:44 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-XWSN2VTtsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125449&action=edit
Bug 29093: Interface changes

Show the TOC checkbox on OPAC and staff.

Test plan:
Add new article request on OPAC or staff. Tick checkbox.
Verify if TOC is Yes on opac-user or staff patron details.
Check the list view on circ/article-requests.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:12:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:12:33 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-ZP3VNbZWON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
A few things to mention, not blockers:
1 - The DBIC patch includes changes from other bugs, I had to generate my own
for testing
2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean?
3 - While it makes display easier, is TOC friendly for translations? It would
be nice to have a hover text with the full 'Table of Contents' at least

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:16:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:16:52 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-FojlbyRxmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #10)

Thanks !

> A few things to mention, not blockers:
> 1 - The DBIC patch includes changes from other bugs, I had to generate my
> own for testing
Yes, sorry for that. But the RM will disregard it anyway and do a fresh DBIx
update.

> 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean?
Tinyint is just a byte. The four positions is display width and actually
irrelevant for our templates. But theoretically, you are right :)

> 3 - While it makes display easier, is TOC friendly for translations? It
> would be nice to have a hover text with the full 'Table of Contents' at least

Good point. Will have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:25:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:25:17 +0000
Subject: [Koha-bugs] [Bug 29093] Article requests: Checkbox for table of
 contents
In-Reply-To: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29093-70-UqfIgP4ORs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125450&action=edit
Bug 29093: (QA follow-up) Adding two hover texts

See QA request. Adding TOC hover text to:
- OPAC user page, tab Article requests
- Patron details page, Check out, tab Article requests

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 13:53:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 11:53:33 +0000
Subject: [Koha-bugs] [Bug 28673] An encoded ampersand missing the ampersand
In-Reply-To: <bug-28673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28673-70-R8gKq2BMtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28673

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Applies on 20.11 with me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:26:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:26:48 +0000
Subject: [Koha-bugs] [Bug 29134] New: Patron search has poor performance
 when ExtendedAttributes enabled and many attributes match
Message-ID: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

            Bug ID: 29134
           Summary: Patron search has poor performance when
                    ExtendedAttributes enabled and many attributes match
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When system preference ExtendedPatronAttributes is enabled the patron search
finds all patrons with a matching attribute and builds a where string with all
the borrowernumbers concatted into an 'IN'
            my @matching_borrowernumbers =
Koha::Patrons->filter_by_attribute_value($searchmember)->get_column('borrowernumber');

            for my $borrowernumber ( @matching_borrowernumbers ) {
                push @where_strs_or, "borrowers.borrowernumber = ?";
                push @where_args, $borrowernumber;
            }

When there are too many matches on a system with many patrons/attributes this
generates a very large query which takes a very long time to return

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:31:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:31:27 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-uK7HURD2ln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
>From IRC:
14:29 < Joubu> marcelr: ok, got it. I am using ES and I am seeing a " Apply
field weights to search " checkox
14:29 < Joubu> it's a sibling
14:30 < Joubu> it indeed works correctly with searchengine=zebra

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:33:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:33:17 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-Ts1diRZQ5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:33:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:33:20 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-Aq54mQPlM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125451&action=edit
Bug 29134: Use a subquery to increase performance of patron attributes search

This patch generates a subquery and checks if a borrowrnumber is in the results
to add patrons
to search results

To test:
 1 - Generate a bunch of patrons:
    SELECT surname, firstname, branchcode, categorycode FROM ( SELECT surname
FROM borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY
rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT
categorycode FROM borrowers ORDER BY rand() ) d LIMIT 50000
 2 - Add a patron attribute to the system and make it searchable - I used code
'TEST'
 3 - Add a value for this attribute to many patrons:
   INSERT INTO borrower_attributes (borrowernumber,code,attribute) SELECT
borrowernumber, 'TEST','alphabet' FROM borrowers LIMIT 10000;
 4 - In staff client got 'Patrons'
 5 - Open the browser console (F12) and view the netwrok tab
 6 - Perform a patron search for 'a'
 7 - Note the time it takes for 'search' to complete in console
 8 - Apply patch, restart_all
 9 - Repeat search
10 - Note it is much faster
11 - prove -v t/db_dependent/Utils/Datatables_Members.t

NOTE: I tested with 500k patrons and 100k attributes - search returned in ~2
seconds with patch
and did not return before I got impatient without patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:34:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:34:13 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-Ahu88FAtQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15812
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:34:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:34:13 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-kOwwFWkGOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29134

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:48:14 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-3D9j8IQmEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 14:48:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 12:48:17 +0000
Subject: [Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of
 button plus/less
In-Reply-To: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28821-70-pNo6GrN4Se@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125452&action=edit
Bug 28821: (QA follow-up) Adjust javascript test

The test did not work when SearchEngine == Elasticsearch.

Test plan:
Verify if it works now for Elasticsearch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 15:07:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 13:07:54 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-0FUxf9yuYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125453&action=edit
Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value

And build the IN using the existing @matching_borrowernumbers.
We have a method for that, we should not use raw SQL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 15:09:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 13:09:55 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-hALIYOCitz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> Created attachment 125453 [details] [review]
> Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value
> 
> And build the IN using the existing @matching_borrowernumbers.
> We have a method for that, we should not use raw SQL.

~600-700ms with Nick's patch
22s on master
~600-700ms with this alternative patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 15:42:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 13:42:38 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-AK5fQPhjN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> I am sorry, I tried "restart_all" multiple times, but the pull downs remain
> empty.
> 
> I am using the admin user (42), logged in at Centerville.
> 
> When placing a single hold, Centerville is selected.

The pull down from the top, the "Pickup at:"?

https://snipboard.io/pRHAMn.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 15:57:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 13:57:07 +0000
Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in
 C4:Utils::DataTables::Members.pm
In-Reply-To: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29125-70-ur20L66FkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 15:57:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 13:57:08 +0000
Subject: [Koha-bugs] [Bug 29131] Row striping breaks color coding on item
 circulation alerts
In-Reply-To: <bug-29131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29131-70-2GjyGqRedd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 16:17:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 14:17:40 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-POlXhqz8eq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

--- Comment #7 from David Gustafsson <glasklas at gmail.com> ---
Yes! Will fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 16:25:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 14:25:16 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-hu2dtQqJXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125364|0                           |1
        is obsolete|                            |

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125454&action=edit
Bug 20058: Add option to send permanent_location as AQ in SIP response

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 16:25:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 14:25:20 +0000
Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of
 homebranch for sorting
In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20058-70-T35IsESZP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125366|0                           |1
        is obsolete|                            |

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125455&action=edit
Bug 20058: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 17:48:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 15:48:02 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-MHku6DAeRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125456&action=edit
Bug 29002: Add bookings table to kohastructure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 17:48:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 15:48:06 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-YGEGjpFKkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125457&action=edit
Bug 29002: DBIC Schema Build

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 17:48:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 15:48:10 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-DWLG4OHF2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125458&action=edit
Bug 29002: Add Booking objects and API classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 17:48:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 15:48:14 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-9WE3WbRivD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125459&action=edit
Bug 29002: Add ability to book material

This patch introduces a new modal to the biblio details page to allow
booking of materials.

Test plan
1) Navigate to the details page of a biblio
2) Note the new 'Place booking' button in the toolbar
3) Click the new button and note the new modal dialogue
4) Enter part of a patron name or cardnumber and then select from the
   presented results
5) Select a start date and end date from the calender
6) Submit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 17:50:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 15:50:28 +0000
Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time
In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29002-70-T76hjEQ6Mv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Lots more to do.. but the basics of creating a booking and being able to see
the bookings for a biblio are now there..

Next steps...
1) Either add bookings to the 'Holds to pull' page or add a now 'Bookings to
collect' page
2) Integrate booking fulfilment into circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:01:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:01:30 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-R5bZyGfN5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #16 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #15)
> Joonas, don't you think we should have the same return than CanBookBeRenewed?
> 
>   ($boolean, $reason);
> 
> The 'return "no";' seems weird to me.
> 
> We could then replace:
> 
>     $auto_renew = _CanBookBeAutoRenewed($borrowernumber, $itemnumber);
>     return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_account_expired';
>     return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_too_late';
>     return ( 0, $auto_renew  ) if $auto_renew =~ 'auto_too_much_oweing';
> 
> with:
> 
>     my ( $can_be_auto_renewed, $reason ) =
> _CanBookBeAutoRenewed($borrowernumber, $itemnumber);
>     return ( 0, $reason ) unless $can_be_auto_renewed;

This is a good plan but I purposefully left it out from this refactoring
because we would have to touch the code in the bottom of CanBookBeRenewed()
where there is the cron section doing magic with "$auto_renew =~ 'too_soon'" or
alternatively make _CanBookBeAutoRenewed return 1 for "too_soon".

It was too big of a task for me to verify the correctness of the code and given
Circulation.pm module is frequently changed I didn't want to have to do it
again due to a merge conflict so I decided to do that work after the code is
merged. Currently this was simply just copy&paste of the existing code with
variable assignments changed to returns. Having the auto renew code now in a
separate function I can start doing more changes to it without having to worry
about it merge conflicting and having to start tedious verification process for
correct logic again.


Also clarifying the return "no" since you mentioned it: it is to keep intact
the 

> my $auto_renew = "no";

value assigned in the beginning of CanBookBeRenewed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:04:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:04:52 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-JUxLWryT9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125445|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125460&action=edit
Bug 29133: Correct select2 strings

We are using 'max'/'min' when the arguments are 'maximum'/'minimum'.
Also using %n, %d when only %s is working in .format()

Have a look at
https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js
It's Select2 v.4.0.13, the one we are using. We should match what's
there.

Test plan:
Bug 29002 is using minimumInputLength, you can see the difference when
selecting a patron:
 "Please enter %s or more characters"
vs
 "Please enter 3 or more characters"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:04:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:04:55 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-KWbD7caRtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125461&action=edit
Bug 29133: (follow-up) Fix for arguament mismatch

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:06:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:06:01 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-aQrFA8bx6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup was required.. but feel free to squash it.

Signing off as all cases now work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:09:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:09:37 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-0EM4i6I0V1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > Created attachment 125453 [details] [review] [review]
> > Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value
> > 
> > And build the IN using the existing @matching_borrowernumbers.
> > We have a method for that, we should not use raw SQL.
> 
> ~600-700ms with Nick's patch
> 22s on master
> ~600-700ms with this alternative patch.

At 500k patrons with 100k attributes the alternate is a bit slower
The query can still be large (caharacter count) with the IN, and requires 2 db
calls, one for filter_borrowers_by_attribute, another to search the borrower DV

Moving to Objects is nice, but I think pure SQL here makes more sense than
mixing the two - I opened bug 29125 to remove all the SQL here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:10:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:10:18 +0000
Subject: [Koha-bugs] [Bug 29133] Wrong string format in select2.inc
In-Reply-To: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29133-70-wrv4YQjI7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:26:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:26:01 +0000
Subject: [Koha-bugs] [Bug 29135] New: OAI should not include biblionumbers
 from deleteditems when determining deletedbiblios
Message-ID: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

            Bug ID: 29135
           Summary: OAI should not include biblionumbers from deleteditems
                    when determining deletedbiblios
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When including items in OAI we add the biblionumbers of deleted items into the
deleted list

This is from this line:
 93         if ( $include_items )  {
 94             $sql = "($sql) UNION (SELECT DISTINCT(biblionumber) FROM
deleteditems $criteria)";
 95             push @bind_params, @part_bind_params;


This is wrong because deletion of a single item does not indicate a record is
deleted

To recreate:
1 - Create /var/lib/koha/kohadev/OAI.yaml with:
format:
  marcxml:
    metadataPrefix: marcxml
    metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
    schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
    include_items: 1

2 - Set  OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml'
3 - Delete an item from a record
4 - View the page:
http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml
5 - Note the record is now listed as deleted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:31:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:31:25 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-72rc4MBpDo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27584

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:31:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:31:25 +0000
Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
In-Reply-To: <bug-27584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27584-70-s1yIY1nv8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29135

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 18:31:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 16:31:58 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-aFsfGbUt7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 19:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 17:55:43 +0000
Subject: [Koha-bugs] [Bug 29136] New: Patron search on request.pl has
 performance and display issues
Message-ID: <bug-29136-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136

            Bug ID: 29136
           Summary: Patron search on request.pl has performance and
                    display issues
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Similar to bug 15812, the patron search on request.pl retrieves all patrons
from a search without pagination, so broad searches can have poor performance.

Additionally, the datatables call on that page doesn't paginate, so all but the
first 20 results are unavailable

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 19:56:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 17:56:45 +0000
Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance
 and display issues
In-Reply-To: <bug-29136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29136-70-Kw37sUyRPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:27:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:27:45 +0000
Subject: [Koha-bugs] [Bug 29137] New: Unwanted to authorised values are too
 easily created via the cataloging module
Message-ID: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

            Bug ID: 29137
           Summary: Unwanted to authorised values are too easily created
                    via the cataloging module
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl
        Depends on: 25728

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728#c50

"I don't like this patch at all!
After just a few weeks we have dozens of new locations created by mistake, like
HORS, FICT, NON-FI &c, &c

Staff type just the first letters of a location and then hit enter, and voila,
there is a new location!

Please make a syspref for this, and make it disabled by default - or set it as
a permission that could be turned off, even for superlibrarians"

I very much agree with Klas here. This makes to much much too easy to create
authorised values in error.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728
[Bug 25728] Add the ability to create a new authorised value within the
cataloguing module
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:27:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:27:45 +0000
Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised
 value within the cataloguing module
In-Reply-To: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25728-70-y3Zh6SUJtt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137
[Bug 29137] Unwanted to authorised values are too easily created via the
cataloging module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:29:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:29:00 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-4y3ce4t35A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Margaret Hade <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:30:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:30:59 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted to authorised values are too
 easily created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-oflSrulNbN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
part of this issue was resolved by bug 29030.

But we absolutely need a way for this to be turned off entirely.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:33:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:33:44 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted to authorised values are too
 easily created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-LQ24l40axF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Have you looked into removing the authorised values managing permission?

I think it would be consequential, if you don't want people to add auth values
to not allow it in another spot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:35:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:35:23 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted to authorised values are too
 easily created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-ovKji0XDPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Margaret Hade <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 20:55:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 18:55:12 +0000
Subject: [Koha-bugs] [Bug 11723] Message "A refund has been applied" on all
 lost item returns
In-Reply-To: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11723-70-QyontMNrS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #7 from Donna <bwsdonna at gmail.com> ---
This is still an issue, and with the changes to refund options, it is even more
confusing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:13:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:13:36 +0000
Subject: [Koha-bugs] [Bug 29138] New: LoadSearchHistoryToTheFirstLoggedUser
 should save 0 instead of "no"
Message-ID: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

            Bug ID: 29138
           Summary: LoadSearchHistoryToTheFirstLoggedUser should save 0
                    instead of "no"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The syspref LoadSearchHistoryToTheFirstLoggedUser saves a 1 when turned on, but
a "no" when turned off. It should be a 0 when turned off. When a "no" is saved,
the syspref behaves as if it's turned on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:23:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:23:51 +0000
Subject: [Koha-bugs] [Bug 29139] New: Paying gives ISE if UseEmailReceipts
 is enabled
Message-ID: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

            Bug ID: 29139
           Summary: Paying gives ISE if UseEmailReceipts is enabled
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:

1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 4
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:


ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:25:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:25:50 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-acCp8Ipis9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |, liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:26:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:26:13 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-rk8FoL22Fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28883

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:26:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:26:13 +0000
Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work
 correctly in list context
In-Reply-To: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28883-70-q6lVPAVe3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29139

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:26:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:26:19 +0000
Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser
 should save 0 instead of "no"
In-Reply-To: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29138-70-f6LV9b9Vlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:26:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:26:22 +0000
Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser
 should save 0 instead of "no"
In-Reply-To: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29138-70-PUX0jIbDAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125462&action=edit
Bug 29138: Use zero instead of no in LoadSearchHistoryToTheFirstLoggedUser

To test:
- apply patch
- set LoadSearchHistoryToTheFirstLoggedUser to 'Don't add'
- confirm via sql that value=0
- confirm on OPAC that search history is not loaded to account on login

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:26:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:26:34 +0000
Subject: [Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser
 should save 0 instead of "no"
In-Reply-To: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29138-70-9W2GSPG1LP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:31:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:31:00 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-5q5rEhFISK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:31:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:31:04 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-uezQPkYUoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125463&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context

Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:

my @account_offsets = $payment->debit_offsets;

This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.

To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:

ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:33:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:33:17 +0000
Subject: [Koha-bugs] [Bug 29140] New: Suppress some warnings in codemirror
 js editor
Message-ID: <bug-29140-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29140

            Bug ID: 29140
           Summary: Suppress some warnings in codemirror js editor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When editing user JS preferences there are warns for:
'let' is available in ES6

I think we could suppress these and allow that usage

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:34:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:34:07 +0000
Subject: [Koha-bugs] [Bug 29140] Suppress some warnings in codemirror js
 editor
In-Reply-To: <bug-29140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29140-70-7UP7UvGJLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29140

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:35:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:35:05 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-NPSKMD8FYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:35:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:35:09 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-fxz9WKfMRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125463|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125464&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context

Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:

my @account_offsets = $payment->debit_offsets;

This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.

To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:

ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 21:51:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 19:51:05 +0000
Subject: [Koha-bugs] [Bug 28373] Items fields not used in default XSLT
In-Reply-To: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28373-70-9Ey1x7U8hY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 22:08:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 20:08:32 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-3M50wPZBqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #337 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Still interested but just haven't been able to commit any more time to it. 
Honestly it's a complicated enough patch that I get lost in it for days every
time I start to look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 22:25:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 20:25:15 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-TUX12qlfKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #48 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
On initial testing, this technically works, but is severely hampered by bug
21729 -- when a hold goes to Waiting, the expiration date is set based on
ReservesMaxPickUpDelay. When the hold is reverted, that expiration date
remains. Without patching 21729, this feature will leave most libraries with a
bunch of bib-level holds that expire within a week or so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 22:56:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 20:56:35 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-zr3eNd9V3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unwanted to authorised      |Unwanted authorised values
                   |values are too easily       |are too easily created via
                   |created via the cataloging  |the cataloging module
                   |module                      |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 23:00:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 21:00:35 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-ZRXAEs6Kn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Removing the permission would be effective for wholly disabling this feature
for folks who are not superlibrarians.
Ideally, superlibrarians who don't wish to use this would also have a way to
turn it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 23:12:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 21:12:40 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-65hswX4y5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hi Andrew, it seems that bug exists regardless of this new work. I can work on
Bug 21729 but waiting on that patch shouldn't hold up the signoff for this
enhancement.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 23:23:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 21:23:49 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-nO7jmAIug4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> ---
this patch, the one for master, no longer cleanly applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 23:30:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 21:30:20 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-2j0G1lf0nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 
> The pull down from the top, the "Pickup at:"?
> 
> https://snipboard.io/pRHAMn.jpg

Oh! I never noticed the one on top - will try to retry :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Sep 29 23:30:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 21:30:46 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
 staff pickup location is empty
In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28919-70-aDMfxwSELZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:06:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:06:29 +0000
Subject: [Koha-bugs] [Bug 29141] New: The rabbitmq task queue results page
 is very hard to find
Message-ID: <bug-29141-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29141

            Bug ID: 29141
           Summary: The rabbitmq task queue results page is very hard to
                    find
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It appears that this page 

/cgi-bin/koha/admin/background_jobs.pl

isn't linked from anywhere but the "we've enqueued this" pages on biblio
modification. Librarians ought to be able to find this page easily so if they
click off of the page and go about their lives, they can come back to make sure
their jobs completed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:27:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:27:34 +0000
Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
In-Reply-To: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26764-70-6z5nTFtRqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com
           Assignee|wizzyrea at gmail.com          |chris at bigballofwax.co.nz

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
I agree this is annoying and I think is an option that can be set when the
schemas are generated - Chris?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:34:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:34:20 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-hexv0nGuRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125440|0                           |1
        is obsolete|                            |
 Attachment #125444|0                           |1
        is obsolete|                            |

--- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125465&action=edit
Bug 27266: Move GetMarcAuthors to Koha namespace

This patch moves C4::Biblio::GetMarcAuthors to
Koha::Biblio->get_authors_from_MARC. This is so the method can be
used in templates and notices.

To test:
1. Find a record that has an author in the added entry field (700-720).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm authors show as
normal.
4. Click 'send' and confirm the email sent shows the authors as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the authors as normal.
xslt)
6. Log in to the OPAC. Find the record and add it to the cart and a list
7. View the cart and click 'more details'. Confirm authors show as
normal.
8. Click 'send' and confirm the email sent shows the authors as normal.
9. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the authors as normal.
10. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:34:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:34:25 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-0dgaxPjiAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125441|0                           |1
        is obsolete|                            |

--- Comment #26 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125466&action=edit
Bug 27266: (QA follow-up) Rename to get_marc_authors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:34:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:34:29 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-aytY5W5XTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125442|0                           |1
        is obsolete|                            |

--- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125467&action=edit
Bug 27266: (follow-up) Remove instances of GetMarcAuthors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:34:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:34:34 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-urhUdTVjw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125443|0                           |1
        is obsolete|                            |

--- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125468&action=edit
Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:34:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:34:38 +0000
Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha
 namespace
In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27266-70-VGbsIYff2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

--- Comment #29 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 125469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125469&action=edit
Bug 27266: (follow-up) Remove get_marc_authors from opac-detail

There's no way to use 'no' XSLT now, so don't need to use this to show
authors on the detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:44:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:44:48 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-u39RMUsB0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
Most catalogers (even non super librarians) will need the ability to manage
authorised values.  But what they need/value most of all is 'efficiency' in
cataloging.  For their workflows, they need  the ability to quickly select a
value in the drop down by typing the first couple letters and select the value,
move on to the next dropdown. (reduction of number of clicks) What this featuer
does is change their workflow and requires them to scroll instead of using the
keyboard.  We will see a cataloger revolt if we do not find a way to make this
optional for catalogers.

joy



(In reply to Andrew Fuerste-Henry from comment #3)
> Removing the permission would be effective for wholly disabling this feature
> for folks who are not superlibrarians.
> Ideally, superlibrarians who don't wish to use this would also have a way to
> turn it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 00:49:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 22:49:23 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-NvjDvNTtGu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #73 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Tomás Cohen Arazi from comment #69)
> Shouldn't we have a single 'allowed_to_change' column as an
> ENUM('owner','everyone','staff') ?

Hi Tomás,

I've had more of a think about this, and discussed with Chris C and Aleisha.
Here are our thoughts:

1. Introducing a single 'allowed_to_change' column should be done on a
different bug report. This bug report is adding an enhancement. Introducing a
single 'allowed_to_change' column would require existing permission logic for
'owners' and 'everyone' to be altered which is outside the scope of this
enhancement. 

2. As we understand it currently a list can have a combination of permissions,
hence why multiple columns were originally introduced. See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228#c2

Furthermore in comment #67 I noted a 'staff only' list has both
allow_change_from_owner=1 and allow_change_from_staff=1. 

Merging these separate columns into a single 'allowed_to_change' column would
eliminate the granularity that's currently available, so we wonder if it's not
the best solution.

All of that being the case, I'm marking this patchset as 'Needs signoff', as
it's been rebased. Happy to hear your thoughts though!

Many thanks
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:01:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:01:10 +0000
Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from
 5.0.16 to 5.5.1
In-Reply-To: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26949-70-ThWh3MiPUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

--- Comment #7 from David Nind <david at davidnind.com> ---
Awesome - thanks for fixing Owen.

Happy to ad my sign off.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:09:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:09:37 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-WXZj5xCmfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #74 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Alex Buckley from comment #73)
> (In reply to Tomás Cohen Arazi from comment #69)
> > Shouldn't we have a single 'allowed_to_change' column as an
> > ENUM('owner','everyone','staff') ?
> 
> Hi Tomás,
> 
> I've had more of a think about this, and discussed with Chris C and Aleisha.
> Here are our thoughts:
> 
> 1. Introducing a single 'allowed_to_change' column should be done on a
> different bug report. This bug report is adding an enhancement. Introducing
> a single 'allowed_to_change' column would require existing permission logic
> for 'owners' and 'everyone' to be altered which is outside the scope of this
> enhancement. 
> 
> 2. As we understand it currently a list can have a combination of
> permissions, hence why multiple columns were originally introduced. See
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228#c2
> 
> Furthermore in comment #67 I noted a 'staff only' list has both
> allow_change_from_owner=1 and allow_change_from_staff=1. 
> 
> Merging these separate columns into a single 'allowed_to_change' column
> would eliminate the granularity that's currently available, so we wonder if
> it's not the best solution.
> 
> All of that being the case, I'm marking this patchset as 'Needs signoff', as
> it's been rebased. Happy to hear your thoughts though!

Sounds like a good review of the current status of the feature. And makes
sense. I will poke at it tomorrow. My 'fear' is we could be adding some
technical debt.
As I said, I'll be happy to review this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:19:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:19:09 +0000
Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate
 should be reset
In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21729-70-pdox1qGL4d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:21:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:21:38 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-Xr6S0VBmCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125470&action=edit
Bug 23678: (QA follow-up) Use correct indentation

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:31:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:31:30 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-ng4Fw0bgcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
I attempted to test (using koha-testing-docker - started with ku).

For whatever reason, the SQL in step 1 didn't add the new patrons to the
database - I still just have the standard 53 patrons you normally get with KTD.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:34:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:34:03 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-Eiqrfkq7Zh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:34:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:34:09 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-iOiW4385TX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Good catch.

I think there's some additional relevant lines lower down in
Koha/OAI/Server/ListBase.pm as well when the max timestamp is fetched. 

$sql = "
    SELECT MAX(timestamp)
    FROM (
        SELECT timestamp FROM deletedbiblio_metadata WHERE biblionumber = ?
        UNION
        SELECT timestamp FROM deleteditems WHERE biblionumber = ?
    ) bis
";

I mean it should be impossible to deleted an item after the bib has been
deleted. But this SQL would return a timestamp where there is a deleted item
but not a deleted bib.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:35:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:35:03 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-rqQvp9y8dA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This developments adds a
      release notes|                            |way to choose multiple
                   |                            |holds using checkboxes, to
                   |                            |cancel them in bulk.
                   |                            |
                   |                            |It
                   |                            |uses the new background
                   |                            |jobs infrastructure
                   |                            |recently introduced.
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 01:39:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Sep 2021 23:39:03 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-S0sqocbXPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #1)
> Good catch.
> 
> I think there's some additional relevant lines lower down in
> Koha/OAI/Server/ListBase.pm as well when the max timestamp is fetched. 
> 

Koha/OAI/Server/GetRecord.pm has that same weird logic, although it would just
be a performance degradation rather than a wrong classification...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 02:01:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 00:01:13 +0000
Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
In-Reply-To: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26764-70-196BmAXmS9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Could be, if someone can tell me the option, ill make the generator use it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 05:29:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 03:29:18 +0000
Subject: [Koha-bugs] [Bug 29141] The rabbitmq task queue results page is
 very hard to find
In-Reply-To: <bug-29141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29141-70-8IuAkIsQcT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29141

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Agreed. This is a duplicate of bug 29020 which has a bit more of a following,
so going to close this one in favour of that one.

*** This bug has been marked as a duplicate of bug 29020 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 05:29:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 03:29:18 +0000
Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
In-Reply-To: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29020-70-I9Y1qlIdFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
*** Bug 29141 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 06:26:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 04:26:54 +0000
Subject: [Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron
 search results
In-Reply-To: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29104-70-EkMUQ0WtDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

--- Comment #4 from Cab Vinton <bibliwho at gmail.com> ---
Unable to test on sandbox.bywatersolutions.com. Tested on biblibre.eu sandbox.

Patch failed to apply:

Bug 29104 - Add dateexpiry column to circulation patron search results

125249 - Bug 29104: Add date expiry column to patron search borrower table

Applying: Bug 29104: Add date expiry column to patron search borrower table
Apply? [(y)es, (n)o, (i)nteractive] 
C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed:
Duplicate column name 'ft_local_float_group' at
koha/installer/data/mysql/updatedatabase.pl line 24298
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28854.perl  [04:23:38]
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/Bug-9525-Add_ft_local_float_group_column.perl
 [04:23:38]
ERROR - C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do
failed: Duplicate column name 'ft_local_float_group' at
koha/installer/data/mysql/updatedatabase.pl line 24298

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 07:45:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 05:45:00 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-cq8iIywHI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:07:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:07:16 +0000
Subject: [Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC
In-Reply-To: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28927-70-LTSbA2ShJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
  Text to go in the|                            |This patch removes
      release notes|                            |redundant div with id
                   |                            |'opacmainuserblock' and
                   |                            |'opacheader' since there is
                   |                            |already this id generated
                   |                            |by HTML customization.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:17:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:17:44 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-42K4SKeV9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27584
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=27584                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584
[Bug 27584] Improve OAI-PMH provider performance
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:17:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:17:44 +0000
Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
In-Reply-To: <bug-27584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27584-70-PY5BXaqNyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29135
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=29135                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
[Bug 29135] OAI should not include biblionumbers from deleteditems when
determining deletedbiblios
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:20:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:20:34 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-Dkugj7oo2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:26:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:26:40 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-7dhHPuC5MW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123964|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125471&action=edit
Bug 28717: Fix additional content logs

The logging for additional contents added by bug 26205 has been broken
by but 22544.

This patch is a revisited version as bug 24387 has been pushed.
It does not log MODIFY if no modification has been made on a template
(useful when only 1 version/lang of a content has been modified)

Test plan:
Turn on NewsLog
Add/modify and delete additional contents/News and confirm that
modification are logged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:27:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:27:03 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-HVQ6dJ6h26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:28:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:28:11 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-HQ4jboLoDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125436|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:28:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:28:41 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-e8RQo187US@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #75 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 125472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125472&action=edit
Bug 26346: (follow-up) Fixes in response to QA

Fixes for the following comments on bug report 26346:

1. Comment #31
2. Comment #32
3. Comment #35
4. Comment #36
5. Comment #37
6. Comment #38
7. Comment #49
8. Comment #59
9. Comment #61

Test plan for comment #49 fix:

1. Log into the staff client as User A. Create one of each of the
following types of public lists:
- 'Owner only'
- 'staff only'
- 'Anyone seeing this list'

2. Visit the OPAC. Do not login. Confirm you are able to see all three
public lists under the 'Lists' dropdown in the OPAC header

3. Perform a search. Select a search result checkbox and view the
dropdown options in the 'Select titles to:' dropdown

4. Confirm only the 'Anyone seeing this list' is displayed as an option

5. Log into the OPAC as a user B (a user with no permissions). Confirm
you can see all three public lists under the header 'Lists' dropdown

6. Repeat steps 3, and 4 as User B with the same results as
un-authenticated user

6. Log into the OPAC as user C (a user with access to the staff client).
Confirm
you can see all three public lists under the header 'Lists' dropdown

7. Repeat steps 3, and 4 but this time you should see the 'staff only'
and 'Anyone seeing this list' public lists in the dropdown

8. Log into the OPAC as user A. Confirm you can see all three poublic
lists under the header 'Lists' dropdown

9. Repeat steps 3, and 4 but this time you should see the 'owner only',
'staff only' and 'Anyone seeing this list' public lists in the
dropdown

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:31:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:31:36 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-O4in9jX24x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #76 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Tomás Cohen Arazi from comment #74)

> Sounds like a good review of the current status of the feature. And makes
> sense. I will poke at it tomorrow. My 'fear' is we could be adding some
> technical debt.
> As I said, I'll be happy to review this.

Thanks Tomás. Let me know how you go with your investigation tomorrow.

I've just replaced the last patch on this bug report as I realised it was
missing some earlier fixes.

Ready for testing again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:36:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:36:38 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
 by library staff only
In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26346-70-6reKRx8mxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #77 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #74)
> Sounds like a good review of the current status of the feature. And makes
> sense. I will poke at it tomorrow. My 'fear' is we could be adding some
> technical debt.
> As I said, I'll be happy to review this.

Go ahead and sign off. I will resume QA after that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:36:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:36:57 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-EQGYbr8Frd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Dang Thanh Tu <spherythanhtu at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spherythanhtu at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:37:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:37:24 +0000
Subject: [Koha-bugs] [Bug 29142] New: test
Message-ID: <bug-29142-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29142

            Bug ID: 29142
           Summary: test
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Websites, Mailing Lists, etc
          Assignee: wizzyrea at gmail.com
          Reporter: spherythanhtu at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:38:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:38:14 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-bdu7RGCIO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Should have been caught by tests...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:40:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:40:16 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-bBdSiqn1SL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_05_candidate
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
         Depends on|                            |27636

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Looks like it's in stable.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636
[Bug 27636] Replace Koha::Account::pay with a simpler method
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:40:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:40:16 +0000
Subject: [Koha-bugs] [Bug 27636] Replace Koha::Account::pay with a simpler
 method
In-Reply-To: <bug-27636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27636-70-NsYOllI7JR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29139


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
[Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 08:41:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 06:41:18 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-7rzlmNQoVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I totally get the usability issue Joy point out. 

I just have a hard time about the "accidentally creating", because I believe
the form that pops up makes it clear what you are doing there and will only
appear if you have the permission to d the same thing in the administration
module. 

What if we didn't suggest to create a new one on not finding a perfect match,
but moved the option to the bottom of the list or outside the select2 pull
down? Next to the item field where it could also be hidden?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:01:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:01:57 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-HUs76LJ8f5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:02:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:02:01 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-2bchtzzMxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125473&action=edit
Bug 29137: Add new syspref to disable AV creation within the cataloguing module

"I don't like this patch at all!"
"We will see a cataloger revolt if we do not find a way to make this
optional for catalogers."

I imagined a hord of catalogers running behind me and I got scared.

This patch will allow to turn the new feature added by bug 25728 off.

Test plan:
Confirm that the new CreateAVFromCataloguing will permit to turn the
feature off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:03:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:03:13 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-DIUq0QBMG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |29030

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> I totally get the usability issue Joy point out. 
> 
> I just have a hard time about the "accidentally creating", because I believe
> the form that pops up makes it clear what you are doing there and will only
> appear if you have the permission to d the same thing in the administration
> module. 

Same here, with bug 29030 I don't see how it could still be a problem.

But here you go, this patch will permit to turn the feature off.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030
[Bug 29030] Problems introduced by bug 25728
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:03:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:03:13 +0000
Subject: [Koha-bugs] [Bug 29030] Problems introduced by bug 25728
In-Reply-To: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29030-70-KCS6AgFtta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137
[Bug 29137] Unwanted authorised values are too easily created via the
cataloging module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:06:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:06:20 +0000
Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and
 needs refactoring
In-Reply-To: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27032-70-FfG7TMPJIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Joonas Kylmälä from comment #16)
> (In reply to Jonathan Druart from comment #15)
> Also clarifying the return "no" since you mentioned it: it is to keep intact
> the 
> 
> > my $auto_renew = "no";
> 
> value assigned in the beginning of CanBookBeRenewed.

Indeed, I missed that. Looking forward follow-up bugs to continue the cleaning
of this module!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:09:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:09:41 +0000
Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles
 of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-9uaFsvQ1lb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Julian Maurice from comment #6)
> Looking good so far :)
> I've followed the test plan and everything works as expected.

Thanks for testing and your comments Julian, very helpful.

In reverse order... 
* Weird, I didn't see that QA failure, but will look into it.. C3 Merge always
confuses me when I see it.
* UI, I was thinking similar thoughts. I'm not sure whether to move it into the
modal, or just try to somehow highlight the dropdown row background more to
distinguish between the tables.  The customer I have suggested they would like
to be able to expand multiple rows so they can see two bundles together.. but I
do agree at the moment it's a bit confusing.
* Regarding the different level, I was also a bit confused by this. They are
certainly keen to have it at the item level but I had thought it would be 'pick
list at the biblio level' and then create bundles from that pick list at the
item level.  The didn't want the pick list at all?!  I still temped to make
that an option, allowing bib->bib constructs at the bib level and then when
adding a bundle at the item level displaying the pick list of linked bibs for
one to go and build the bundle up from the shelves.  The main thing that I
struggled with was finding a sensible marc field.
* I'm aware the inventory side of this is missing and intend to do that in the
next bug (It was already getting big here so I was trying to be pragmatic.. are
there any other functions I've missed.. more than happy to accommodate them).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:24:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:24:53 +0000
Subject: [Koha-bugs] [Bug 28929] No filtering on borrowers.flags on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28929-70-eBVNoWNs9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28929

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
              Group|Koha security               |
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:24:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:24:55 +0000
Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC
In-Reply-To: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28941-70-AfnMUv7gbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:24:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:24:57 +0000
Subject: [Koha-bugs] [Bug 28947] OPAC user can create new users
In-Reply-To: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28947-70-Rk9K5mRBer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28947

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:24:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:24:59 +0000
Subject: [Koha-bugs] [Bug 28935] No filtering on patron's data on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28935-70-FIbg4QJKjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
            Product|Koha security               |Koha
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:25:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:25:01 +0000
Subject: [Koha-bugs] [Bug 28759] Users with pretty basic staff interface
 permissions can see/add/remove API keys of any other user
In-Reply-To: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28759-70-amsAwMqTbk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28759

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
              Group|Koha security               |
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
            Product|Koha security               |Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:25:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:25:03 +0000
Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see
 API keys of any other user
In-Reply-To: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28772-70-efh5d3BdFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
              Group|Koha security               |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:40:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:40:07 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-eeHmsYva5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

--- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> ---
Oh no. It seems that I made a terrible mistake here. However, it's not that
simple. The timestamp of a deleted item is still relevant for a live biblio.
The latest timestamp of any change, be that change or deletion, must be used as
the timestamp since everything affects what's in the returned record. So it's
not as simple as removing the statements for non-deleted records.

I'll take this with a high priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:40 +0000
Subject: [Koha-bugs] [Bug 28759] Users with pretty basic staff interface
 permissions can see/add/remove API keys of any other user
In-Reply-To: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28759-70-y49L4H0rgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28759

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:43 +0000
Subject: [Koha-bugs] [Bug 28759] Users with pretty basic staff interface
 permissions can see/add/remove API keys of any other user
In-Reply-To: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28759-70-RAU6vHHMTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28759

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:46 +0000
Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see
 API keys of any other user
In-Reply-To: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28772-70-sTiuEVfWwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:49 +0000
Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see
 API keys of any other user
In-Reply-To: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28772-70-Oz0H4u8LAX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772

--- Comment #82 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:52 +0000
Subject: [Koha-bugs] [Bug 28929] No filtering on borrowers.flags on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28929-70-y2soWg4it1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28929

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:51:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:51:56 +0000
Subject: [Koha-bugs] [Bug 28929] No filtering on borrowers.flags on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28929-70-B0nEClM7SG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28929

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:00 +0000
Subject: [Koha-bugs] [Bug 28935] No filtering on patron's data on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28935-70-BAkceFkpwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:04 +0000
Subject: [Koha-bugs] [Bug 28935] No filtering on patron's data on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28935-70-30MhR5IB1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935

--- Comment #112 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:08 +0000
Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC
In-Reply-To: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28941-70-wGTDJVdLhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:11 +0000
Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC
In-Reply-To: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28941-70-jaJqFECNLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:14 +0000
Subject: [Koha-bugs] [Bug 28947] OPAC user can create new users
In-Reply-To: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28947-70-RR4cjSo3rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28947

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|21.05.04, 20.11.10,         |21.11.00,21.05.04,
        released in|20.05.16, 19.11.22          |20.11.10, 20.05.16,
                   |                            |19.11.22

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:18 +0000
Subject: [Koha-bugs] [Bug 28947] OPAC user can create new users
In-Reply-To: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28947-70-KjFsfZDM1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28947

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:29 +0000
Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see
 API keys of any other user
In-Reply-To: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28772-70-ApM7RFL0Dr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772

--- Comment #83 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
> Created attachment 124700 [details] [review]
> Bug 28722: Regression tests

Wrong bug number, caught it too late..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:52:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:52:51 +0000
Subject: [Koha-bugs] [Bug 28772] Any user that can work with reports can see
 API keys of any other user
In-Reply-To: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28772-70-y4kG323MAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:53:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:53:45 +0000
Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC
In-Reply-To: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28941-70-j3szwNIJk8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
         Version(s)|21.11.00,21.05.04,          |21.05.04, 20.11.10,
        released in|20.11.10, 20.05.16,         |20.05.16, 19.11.22
                   |19.11.22                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:53:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:53:57 +0000
Subject: [Koha-bugs] [Bug 28947] OPAC user can create new users
In-Reply-To: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28947-70-Wq0mL45Wmv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28947

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:54:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:54:01 +0000
Subject: [Koha-bugs] [Bug 28935] No filtering on patron's data on member
 entry pages (OPAC, self registration, staff interface)
In-Reply-To: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28935-70-WuSsMNfDXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 09:54:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 07:54:07 +0000
Subject: [Koha-bugs] [Bug 28759] Users with pretty basic staff interface
 permissions can see/add/remove API keys of any other user
In-Reply-To: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28759-70-tE1zYQcn1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28759

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 10:16:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 08:16:43 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-ZZg0ZnnOb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125464|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125474&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context

Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:

my @account_offsets = $payment->debit_offsets;

This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.

To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:

ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 10:16:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 08:16:46 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-WJRHq1j3yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125475&action=edit
Bug 29139: Fix incorrect relation call

The bug here was worse than originally thought. We were calling the
wrong relation too.. we should probably add some exceptions to catch
this, it confuses me every single time!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 10:17:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 08:17:21 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-E873XddCsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Tomas told me he's working on tests already.. to save duplication of work I'll
wait to see what he produces and take a look at those,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 10:31:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 08:31:54 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-xNpuRTbtl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125476&action=edit
Bug 29139: Add exceptions to relation accessors

We already had exceptions on the many-to-many links, but we didn't have
them for the middle table. The underlying dbic relations make it clear
which id's are being used for linking.  A 'credit' has 'credit_offsets',
a 'debit' has 'debit_offsets'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 10:34:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 08:34:40 +0000
Subject: [Koha-bugs] [Bug 29143] New: test
Message-ID: <bug-29143-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29143

            Bug ID: 29143
           Summary: test
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: spherythanhtu at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:16:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:16:59 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-BnvPzmlIcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:16:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:16:59 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-logVcsSIar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29139


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
[Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:22:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:22:30 +0000
Subject: [Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use
 GetPreparedLetter
In-Reply-To: <bug-28374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28374-70-JrWDfKvEGf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|26734                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734
[Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:22:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:22:30 +0000
Subject: [Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use
 GetPreparedLetter
In-Reply-To: <bug-26734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26734-70-PnKkY7iZ9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28374                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374
[Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:59:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:59:23 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-v4WOknFGeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125358|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125477&action=edit
Bug 29121: Add new plugin exceptions

This patch introduces two new exceptions:

- Koha::Exceptions::Plugin::InstallDied
- Koha::Exceptions::Plugin::UpgradeDied

Tests are added for their stringification output.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:59:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:59:27 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-qFxoaAbnPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125359|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125478&action=edit
Bug 29121: Regression tests

This patch adds regression tests for broken ->install and ->upgrade
methods on plugins.

It adds two dummie plugins named BrokenInstall and BrokenUpgrade, for
convenience.

Tests are added to catch the warnings that will be logged when trying to
load this plugins on different scenarios.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:59:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:59:31 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-vkvVz2eBhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125360|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125479&action=edit
Bug 29121: Catch errors in ->install and ->upgrade calls on plugins

This patch adds a try/catch block when instantiating plugins. Calling
->new on a plugin eventually triggers a call to ->install (this has
always been like this since bug 7804). If the ->install method is
somehow borked, then the process dies. We need to prevent that, and
report back some error took place. That's what this patch does.

The same happens to the ->upgrade.

To test:
1. Install any plugin you like
2. Restart plack (just in case)
=> SUCCESS: All good
3. Manually change its install method to:

sub install {
    die "plugin, die!";
}

4. Run:
   $ koha-mysql kohadev
   > DELETE FROM plugin_data;
(to make sure there's no __INSTALLED__ entry, do on a safe to delete DB).
5. Point your browser to the plugins-home.pl page
=> FAIL: Boom
6. Apply up to the regression tests
7. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/Plugins.t \
           t/Koha/Exceptions.t
=> FAIL: Tests fail!
8. Apply this patch
9. Repeat 2
=> SUCCESS: Tests pass!
10. Run:
    $ restart_all
11. Repeat 5
=> SUCCESS: The page is not broken
12. Sign off :-D

Note: I used
    $ kshell
   k$ perl misc/devel/install_plugins.pl
to test as well.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:59:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:59:34 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-3DDNoKHMEH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125361|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125480&action=edit
Bug 29121: Add POD to plugins

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 11:59:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 09:59:57 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-UuoC82hZrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, code is clear and passes qa scripts

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:00:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:00:03 +0000
Subject: [Koha-bugs] [Bug 29121] Plugins with broken ->install prevent
 access to the plugins list
In-Reply-To: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29121-70-RrNbWPurJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:04:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:04:24 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-jmwWbsNahS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Patch doesn't apply

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry guys, patch doesn't apply right now.. could we get a rebase please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:21:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:21:22 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-dJo3xiP9Lc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125095|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125481&action=edit
Bug 25716: Add ability to specify additional options in koha-conf.xml for
z3950_responder.pl when using koha-z3950-responder

The z39.50 responder has a number of command line options that are not
accessible if using the debian scripts to control it. We should be able
to set those options in the koha conf file to be passed to the script
itself.

Test Plan:
1) Apply this patch
2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder
if necessary
3) Add "<z3950_responder_options>--add-item-status k</z3950_responder_options>"
inside your <config> block in your koha-conf.xml file
4) Use koha-z3950-responder to start/restart the z39.50 responder, note the
item status is now in subfield k!

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:21:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:21:26 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-VyRQ1shRs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125096|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125482&action=edit
Bug 25716: Don't exit if config doesn't exist in Koha conf file

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:23:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:23:25 +0000
Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options
 in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
In-Reply-To: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25716-70-WR8igpJm86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I can't really fail this.. but I would have preferred to see it as options in
the z3950 specific config file rather than this somewhat obscure pass a param
into the config.. it feels weird having `--add-item-status k--` inside a config
line

But.. the code does indeed work and although we get a noisy warning about XML
issues in the qa scripts it doesn't appear to actually cause an issue with the
feature.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:25:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:25:13 +0000
Subject: [Koha-bugs] [Bug 29107] item_type should be item_type_id on item
 response object
In-Reply-To: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29107-70-pSkQ1qoePN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial string fix.. going straight for PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:26:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:26:02 +0000
Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from
 5.0.16 to 5.5.1
In-Reply-To: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26949-70-dMvyo2yY3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
The remote branch has been updated to add David's signoff. Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:26:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:26:28 +0000
Subject: [Koha-bugs] [Bug 29108] Add q parameters to items routes
In-Reply-To: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29108-70-nGhlmn4Bbg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is another trivial really.. going straight for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:29:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:29:05 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-QGyL6AVCvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125428|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125483&action=edit
Bug 29128: Remove whitespace in browse shelf link

To test:
-Turn on OPACShelfBrowser and make sure you have some itemcallnumbers
-Go to detail page and see the link: (Browse shelf )
-Apply patch and look at the link again, it should be: (Browse shelf)

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:29:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:29:08 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-AUI6ImBX4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125484&action=edit
Bug 29128: Remove the other whitespace in browse shelf link

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:29:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:29:30 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-QyaCgfDStM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice string fix.. PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:29:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:29:42 +0000
Subject: [Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on
 opac-detail.tt
In-Reply-To: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29128-70-qrqUvUTczs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125429|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:39:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:39:08 +0000
Subject: [Koha-bugs] [Bug 29142] test
In-Reply-To: <bug-29142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29142-70-xVKKo6W2lT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29142

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:39:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:39:23 +0000
Subject: [Koha-bugs] [Bug 29143] test
In-Reply-To: <bug-29143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29143-70-Wj2Tb0YjHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29143

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:40:12 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-DTw8uYVHWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:40:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:40:28 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-Gke87a5qol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry, another one that doesn't apply any more :(.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:45:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:45:13 +0000
Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option
 for modules in action_logs
In-Reply-To: <bug-18631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18631-70-rWkozZ6U2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123857|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125485&action=edit
Bug 18631: Add option to specify logs to preserve or delete in
cleanup_database.pl

This adds two new parameters:
--log_module
--preserve_log

These can be repeated to include or exclude specific modules from the cleanup

To test:
0 - Apply patch
1 - Enable cataloging log and borrowers log
2 - Make some changes to borrowers and records
3 - run cleanup databse with --logs 0 --preserve_log=MEMBERS
--preserve_log=CATALOGUING
4 - nothing is removed
5 - run cleanup databse with --logs 0 --log_module=MEMBERS
6 - the borrower logs are removed, the record changes remain
7 - run cleanup database with --logs 0
8 - record changes are removed (all other logs too)

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:45:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:45:55 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-foDifpOi9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:46:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:46:00 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-h6kTygCNWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125314|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125486&action=edit
Bug 29006: Make GoogleOpenIDConnect options consistent in the OPAC

This patch makes modifications to OPAC templates to make the Google
login options more consistent.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- In the staff interface, enable the GoogleOpenIDConnect preference, and
  populate the GoogleOAuth2ClientID the GoogleOAuth2ClientSecret with
  values (they don't need to be valid).
- On the OPAC main page you should see a "Log in with Google" button
  above the Koha login form.
- If you click the "Log in to your account" link at the top of the page
  you should see a "Log in with Google" button in the modal window
- If you navigate directly to /cgi-bin/koha/opac-user.pl when not logged
  in you should see the same "Log in with Google" button on that page.
- In each case the Google button should point to
/cgi-bin/koha/svc/auth/googleopenidconnect
- If you disable GoogleOpenIDConnect the buttons should disappear.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:46:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:46:18 +0000
Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option
 for modules in action_logs
In-Reply-To: <bug-18631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18631-70-Cc7uI3TCoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice improvement... I fixed up the patch to drop the unintended
Koha/XSLT/Base.pm debugging.. they were clearly an errant part of the commit.
;)

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 12:46:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 10:46:28 +0000
Subject: [Koha-bugs] [Bug 29006] Make GoogleOpenIDConnect options consistent
 in the OPAC
In-Reply-To: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29006-70-TyewAWRJ4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #7)
> Please resubmit without the changes to opac.css

Whoops, sorry about that!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:05:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:05:52 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-aR4ZwP2Rsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:05:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:05:55 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-4LpXf1QEzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125062|0                           |1
        is obsolete|                            |
 Attachment #125091|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125487&action=edit
Bug 29058: Add 'Always show holds' checkbox to request.pl

This patch adds a new cookie 'awalys_show_holds' and utlises it on request.pl
to determine if the existing holds table should be loaded.

If the cookie does not exist, the table is loaded to preserve exiting
behaviour.
If the cookie exists and is set to 'DONT' a new button 'Show holds' is added to
the page to allow force loading the table

To test:
1 - Place some holds on a record
2 - Click 'Holds' tab or 'Place a hold' from details page
3 - Note search box to place hold and table of existing holds
4 - Apply patch
5 - Reload the holds page and note new checkbox 'Always show holds'
6 - Confirm the box is checked
7 - Uncheck it
8 - Reload the page and confirm holds do not automatically load
9 - Click the new 'Show holds' button
10 - Confirm the existing holds load, and that 'Always show holds' is unchecked
11 - Check 'Always show holds'
12 - Reload page and confirm holds don't show
13 - Uncheck the box, load holds for another record, confirm it remains
unchecked
14 - Bring up browser console (F12)
15 - In 'Storage' tab, under 'Cookies', delete the cookie for
'always_show_holds'
16 - Reload holds page, confirm holds load and check box is checked

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:05:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:05:59 +0000
Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table
 automatically
In-Reply-To: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29058-70-iURPHHKnoP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125488&action=edit
Bug 29058: (follow-up) Add hold count and don't display show options if no
holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:06:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:06:47 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-6XiIIV2nbL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I can't see that one can search on the new preferred name.. I think that's a
must for this.

I also find it a little confusing on the patron page.. I think I'd actually
prefer to display 'Legal name' as a distinct and clear field if we're falling
through to preferred name for the main display.

We also don't appear to catch the the dropdown for 'PatronAutoComplete'.

Sorry dude.. I think this is a great start, but it need a little more work ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:09:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:09:43 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-sqnyCvaEoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Nind from comment #5)
> I attempted to test (using koha-testing-docker - started with ku).
> 
> For whatever reason, the SQL in step 1 didn't add the new patrons to the
> database - I still just have the standard 53 patrons you normally get with
> KTD.

That was a typo, it should be:"
INSERT into borrowers(surname, firstname, branchcode, categorycode) SELECT
surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM
borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY rand()
) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT
categorycode FROM borrowers ORDER BY rand() ) d LIMIT 50000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:25:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:25:19 +0000
Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
In-Reply-To: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26764-70-DZOgrBOdaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 I'd love this proposed change. The added paging is really making the schema
much harder to use with our big tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:32:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:32:00 +0000
Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
In-Reply-To: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26764-70-mbRoXXU1d1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, the config is not very clear there :( Not sure if it's possible.

https://schemaspy.readthedocs.io/en/v6.0.0/configuration.html

There is:

[-nopages]
    Just list data as one long list instead of pages.

But I think that's not what we are looking for, meaning that the tables would
all be in one document.

This appears to be the change that added the dreadful paging:

https://github.com/schemaspy/schemaspy/pull/168

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:32:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:32:37 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-ajKXzXQRRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:32:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:32:40 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-2bURufaiq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125413|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125489&action=edit
Bug 15812: Use patron search in place of circ search

The 'Checkout' search hijacks some of the DataTables searching code used for
'Search patrons'
Rather than try to implement the search again on another page, we can simply
send the user
to the patron search if the cardnumber is not found

Additionally, this patch adds a 'Check out' button to the patron search results
to allow
going to checkotus directly

To test:
1 - Apply patch
2 - Perform a 'Checkout' search from the header
3 - Note that:
    For a cardnumber, you are redirected directly to checkouts page for the
borrower
    For a search with one result, you are redirected directly to the checkout
page for the borrower
    For a search with many results, you are redirected to the patron search
results
    and there is a 'Checkout' button under the cardnumber
4 - Confirm circulation page works as expected (i.e. checkout to a patron)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:32:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:32:44 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-OMpT01MiVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125490&action=edit
Bug 15812: (follow-up) Add permission check for 'Check out' button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:34:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:34:21 +0000
Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
In-Reply-To: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26764-70-KtQqbcmHmd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There already is an issue filed:
https://woshi.monster/schemaspy/schemaspy/issues/771

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 13:51:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 11:51:40 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-MWWdWmeldv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #338 from David Gustafsson <glasklas at gmail.com> ---
Regarding the level of confidence in this patch regarding stability we have
been running this for a pretty large University Library (Gothenburg University
Library) in production for a couple of years, about three I think, and not
encountered any major issues. We have not merged in the latest upstream changes
from this issue, but I don't think much have changed when it comes to the core
logic/functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:01:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:01:56 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To: <bug-13388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13388-70-dheCRvSweq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Actually just discovered this link on the homepage.
Heh it appears to be rather unnoticeable ;)
Nice.

My first thought here is though: Shouldnt we call it "Library info" ?
At least for a single branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:02:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:02:31 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-p9l10mRluk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #339 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
There are several questions waiting for answers, see comments 321-333.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:03:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:03:02 +0000
Subject: [Koha-bugs] [Bug 29124] Load existing holds requests using API
In-Reply-To: <bug-29124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29124-70-4q6SLqO1cd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29124

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:25:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:25:43 +0000
Subject: [Koha-bugs] [Bug 29144] New: Make branches.opac_info suitable for
 multi language use
Message-ID: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144

            Bug ID: 29144
           Summary: Make branches.opac_info suitable for multi language
                    use
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

opac-library page shows opac_info

Would be nice to have in more than one language.
What would be the best way to achieve that?

[1] Move opac_info out of branches and add a table with branchcode, language
and opac_info. Needs a separate admin page.

[2] css/js fiddling: All stuff in opac_info. Show/hide blocks etc.

[3] Your solution ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:35:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:35:53 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-pCQcDVffV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not all that familiar with C4::Utils::DataTables::Members, but I having had
a quick read I'm not averse to Nick approach of having it 'all sql'.

With that said, I'd really love to wrap my head around what that module is used
for at all.. it feels like we should be able to move to using the patron API
and our datatables wrapper for this now in most cases?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:41:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:41:07 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-l1jlUqbPFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124748|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125491&action=edit
Bug 28945: Use Flatpickr on administration pages

This patch updates administration templates to use Flatpickr instead of
jQueryUI datepickers.

To test, apply the patch and test date fields on the following pages:

- Administration -> Budgets ->
  - New budget: Linked "Start date" and "End  date" fields.
  - Duplicate budget: Linked "Start date" and "End  date" fields.
- Acquisitions -> Vendor -> New contract: Linked "Start date" and "End
  date" fields.
- Administration -> Circulation and fine rules: "Hard due date" and "No
  automatic renewal after" fields.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:41:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:41:23 +0000
Subject: [Koha-bugs] [Bug 28945] Use Flatpickr on administration pages
In-Reply-To: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28945-70-U39rt7dskJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great work, PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:44:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:44:08 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-GaJogkqmWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124785|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125492&action=edit
Bug 28949: Use Flatpickr on reports pages

This patch replaces the use of jQueryUI's datepicker on reports pages.

To test, apply the patch and test the following reports pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Acquisitions statistic wizard: Linked pairs of fields for
  "placed on" and "received on."
- Patrons with the most checkouts: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Patrons who haven't checked out: "Not checked out since"
  field.
- Cash register statistics wizard: Linked "From" and "To"
  fields.
- Most-circulated items: Linked pairs of fields for
  "Checkout date from" and "Check-in date from"
- Catalog statistics wizard: Linked pairs of fields for "Date acquired
  (item)" and "Date deleted (item)" The latter is shown by checking the
  "Count deleted items" radio button.
- View dictionary -> New definition:
  - Enter a definition name
  - Select table Circulation
  - Choose a date column, e.g. "Date of birth" or "Registration date"
  - Select "Date range"
    - Test that the "Start of date range" and "End of date range" fields
      are linked correctly.
- Create guided report:
  - Module: catalog
  - Type: Tabular
  - Select columns (any)
  - Select criteria to limit on: There should be three pairs of linked
    fields, "Creation date," "Modification date," and "Due date."
  - Confirm that the report is saved correctly with the dates you chose.
- Create from SQL -> Test a report with one or more date
  fields, e.g.
https://wiki.koha-community.org/wiki/SQL_Reports_Library#Items_added_by_Collection
- Average loan time: Linke pairs of fields for "Checkout
  date" and "Returns."
- Reports -> Circulation statistics wizard: Linked "Period" fields.
- Reports -> Holds statistics wizard: Linked pairs of fields "Hold
  date," "Notification date," "Reminder date," "Waiting date," and
  "Cancellation date."

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:44:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:44:47 +0000
Subject: [Koha-bugs] [Bug 28949] Use Flatpickr on reports pages
In-Reply-To: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28949-70-BOCJ1iol5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work, all works well.

PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:48:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:48:11 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-Tv6U7ZlPjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124848|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125493&action=edit
Bug 28942: Use Flatpickr on acquisitions pages

This patch modifies several acquisitions pages replacing jQuery
datepickers with Flatpickr widgets.

To test, apply the patch and test datepickers on the following
Acquisitions pages:

 - Acquisitions -> Late orders (linked date fields in the sidebar)
 - Acquisitions -> Invoices (linked date fields in the sidebar)
 - Acquisitions -> Invoices -> Invoice details (shipment date and
   billing date)
 - Acquisitions -> Vendor -> Receive shipment (shipment date)
 - Acquisitions -> Vendor -> Receive shipment -> Receive (on order line)
   -> Date received field under "Accounting details
 - Acquisitions -> Orders search tab in the header -> Advanced search:
   Linked date fields in the search form."

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:48:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:48:51 +0000
Subject: [Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages
In-Reply-To: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28942-70-wrKDR3EXfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great to see all these updates..

PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:51:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:51:55 +0000
Subject: [Koha-bugs] [Bug 29145] New: Allow patrons to have overdue items
 that would not result in debarment when removing overdue debarments
Message-ID: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

            Bug ID: 29145
           Summary: Allow patrons to have overdue items that would not
                    result in debarment when removing overdue debarments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The default behavior when returning an item, is to check if a patron is
debarred, in that case check if the patron has any other overdue items left,
and if not to lift the debarment. One might argue that it would be more logical
to lift the debarment on the same conditions on which the Patron was debarred,
so if the patron is in a state that would not cause debarment, the patron
should not be debarred. That is: only if the patron has items that are overdue
enough to cause restriction/debarment the debarment should be maintained.

This patch provides a system preference, that if set instead of checking for
any delayed items on returning an item, uses the delay used for restrictions to
check for items exceeding that limit, and if none are found lifts the
debarment.

(Stefan Berndtsson at Gothenburg University library is the original author of
this patch).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:52:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:52:14 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-hwfwbHqfL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124582|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125494&action=edit
Bug 28958: Use Flatpickr on serials pages

This patch replaces the use of jQueryUI's datepicker on serials pages.

To test, apply the patch and test the following serials pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Claims -> Choose vendor -> Filter missing issues (linked "from" and
  "to" fields).
- Check expiration -> "Expiring before" field.
- Manage numbering patterns -> New numbering pattern -> "First issue
  publication date" field.
- Serials advanced search -> "Expires before" field.
- Subscription search results -> Check multiple checkboxes -> Edit
  selected serials: "Expiration date" field.
- Subscription details -> Serial collection -> Edit serials ->
  "Published on" and "Expected on" fields.
- Subscription details -> Renew -> "Start date" field in the popup
  window.
- Subscription details -> Edit subscription -> Page 2 -> "First issue
  publication date," "Subscription start date," and "Subscription end
  date" fields.
- Locate a subscription with manual history enabled. From the
  subscription detail page, click the "Planning" tab, then "Edit
  history" -> Linked fields "Subscription start date" and "Subscription
  end date."

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:52:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:52:33 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-G8LPFRGhVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All cases work as expected.. going straight for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:52:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:52:38 +0000
Subject: [Koha-bugs] [Bug 28958] Use Flatpickr on serials pages
In-Reply-To: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28958-70-HtlBGjChF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:54:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:54:13 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-khK6ZQEO1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 125495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125495&action=edit
Bug 29145: use overdues restrict delays when removing overdues restriction upon
return

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:54:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:54:28 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-zQcVYzKAKJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #7)
> I'm not all that familiar with C4::Utils::DataTables::Members, but I having
> had a quick read I'm not averse to Nick approach of having it 'all sql'.
> 
> With that said, I'd really love to wrap my head around what that module is
> used for at all.. it feels like we should be able to move to using the
> patron API and our datatables wrapper for this now in most cases?

It's the first module that provided a JSON for DataTables in AJAX (so with
filter, ordering, etc.)
It does a lot of things, and using the REST API (with the DT wrapper) won't be
easy. It's used for the different patron searches

Nick wrote something on bug 29125, to remove the raw SQL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:54:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:54:46 +0000
Subject: [Koha-bugs] [Bug 29146] New: Should framework default values be
 applied to existing records?
Message-ID: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

            Bug ID: 29146
           Summary: Should framework default values be applied to existing
                    records?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If you open an existing record in the cataloguing editor, default framework
values are applied.
This may not always be the desired behavior.
For instance, when you created the record and the defaults were applied, you
did remove one value. When reopening the record, you dont like it to reappear?

Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:05 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-UcPQSJEiea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:17 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-6PAJOVcyRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124632|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125496&action=edit
Bug 28961: Use Flatpickr on tools pages

This patch replaces the use of jQueryUI's datepicker on tools pages.

To test, apply the patch and test the following tools pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

 - News -> New entry: Linked fields "Published date" and "Expiration
   date".
 - Batch extend due dates: Linked fields "Due date from" and  "Due date
   to"; "Hard due date" field.
 - Batch patron deletion: "who have not borrowed since," "whose
   expiration date is before," and "Permanently delete checkout history
   older than."
 - Export: Linked "Start date" and "End date" fields.
 - Import patrons -> Enter default values: "Date of birth,"
   "Registration date," and "Expiry date."
 - Inventory: "Set inventory date to."
 - Batch patron modification -> Submit a batch of cardnumbers or a
   patron list: "Registration date," "Expiry date," and "Restriction
   expiration."
 - Task scheduler: "Date" field.
 - Log viewer: "Display from" and "Display to" linked fields.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:39 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-GZjicvMsGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:43 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-akDZsKv6gN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123008|0                           |1
        is obsolete|                            |
 Attachment #123009|0                           |1
        is obsolete|                            |
 Attachment #123658|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125497&action=edit
Bug 28633: DB Update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:43 +0000
Subject: [Koha-bugs] [Bug 28961] Use Flatpickr on tools pages
In-Reply-To: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28961-70-LHnFlGipLF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another case of getting it all right.. PQA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:46 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-q6E8joERQk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125498&action=edit
Bug 28633: DO NOT PUSH Schema Changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:50 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-vr01ioxf9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125499&action=edit
Bug 28633: Add preferred name field to patrons

This patch adds a new field 'preferredname' to the patron record.

Additionally it adds a method 'effective_name' to choose the preferred name if
present
and fall back to firstname

To test:
1 - Apply patches
2 - Update database and restart all, clear browser cache
3 - Load a patron in staff module
4 - Confirm you see and can add a preferred name
5 - Confirm the preferred name now displays on patron details
6 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm
you can make
    new field required or hidden
7 - Sign in as patron to opac
8 - Confirm preferred name shows
9 - Edit account on opac and confirm field is present

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:55:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:55:53 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
 effective_name method to patrons
In-Reply-To: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28633-70-U3rR7XItRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125500&action=edit
Bug 28633: (follow-up) Show legal name and add preferredname to searches

This patch adds to the DB update a condition to add 'preferredname' to
DefaultPatronSearchFields. It also adjust the koha defaults to include it
if the pref is empty

The 'firstname' is displayed as 'Legal name' on the details page, with id/class
to allow ajusting via JS/CSS

PatronAutoComplete/ysearch is updated to use 'effective_name' method

To test:
1 - Aply patches and updatedatabase and restart_all
2 - Add a preferredname to a patron
3 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
firstname
    Add preferredname if not
4 - Perform checkout and patron search using preferredname, confirm patron is
found
5 - On patron's detail page confirm 'Legal name' shows
6 - Remove patron's first name, confirm 'Legal name' is no longer present
7 - Enable PatronAutoComplete system preference
8 - Type patron's surname into Checkout or patron search but don't hit enter
9 - Confirm patron is dsiplayed with 'preferredname' in the preview

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:56:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:56:12 +0000
Subject: [Koha-bugs] [Bug 28963] Use Flatpickr on calendar page
In-Reply-To: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28963-70-zQCzuTCPvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I changed my mind.. go for it here ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:57:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:57:36 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-CrKhlHQFlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124728|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125501&action=edit
Bug 28983: Use Flatpickr on various pages

This patch replaces the use of jQueryUI's datepicker on various
unrelated pages.

To test, apply the patch and test the following pages to confirm
that datepickers work correctly. "Linked" date fields should prevent a
"to" selection which preceeds the selected "from" date.

- Tools -> Patron clubs -> New club: Linked "start date" and "end date"
  fields.
- ILL requests: Two linked pairs of date fields in the sidebar, "Date
  placed between" and "Updated between." Each pair should work correctly
  and table filtering by date should work correctly.
- Tools -> Label creator -> Manage -> Layout batches -> Edit a batch ->
  Add items. This should trigger a popup window with a linked pair of
  date fields, "Added on or after date," and "Added on or before date."
- Point of sale -> Transaction history: "From" and "To" linked date
  field in the "Older transactions" section.
- Acquisitions -> Suggestions -> Add a suggestion: "Created by,"
  "Accepted on," and "Managed by" fields.
- Tools -> Tags -> Filter tags by date.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:57:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:57:52 +0000
Subject: [Koha-bugs] [Bug 28983] Use Flatpickr on various pages
In-Reply-To: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28983-70-7jjsvnEqiP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works, PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 14:57:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 12:57:54 +0000
Subject: [Koha-bugs] [Bug 29146] Should framework default values be applied
 to existing records?
In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29146-70-vbo03CvInx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree. I think it should only default on creation of a new record. If I
decide to remove the content of a field or the field itself, that should be
respected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:01:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:01:07 +0000
Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS
In-Reply-To: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28978-70-xdPuN8JgSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124665|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125502&action=edit
Bug 28978: Convert installer CSS to SCSS

This patch creates a new SCSS file, installer.scss, from which
installer.css will be compiled.

Most of the resulting CSS is unchanged, but some minor sections were
removed because they were obsolete. The jQueryUI-specific section isn't
fully converted to SCSS because it's going to go away with the addition
of Flatpickr.

To test, apply the patch and rebuild the staff client SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is
  updated.
- Go through the complete web installation process, including
  onboarding, to confirm that everything is styled as before.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:01:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:01:26 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-Zv3XiR3XOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124716|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125503&action=edit
Bug 28982: Use Flatpickr on onboarding pages

This patch replaces the use of jQueryUI's datepicker in the onboarding
templates. The addition of calendar.inc to the template requires that
some additions be made to the installer's header files, adding the i18n
JavaScript assets.

jQueryUI-specific CSS is removed from installer.scss, and inclusion of
Flatpickr's SCSS is added.

To test, apply the patch and rebuild the staff client SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Start the installation process.
- Continue through the installation process until you reach the stage in
  onboarding where you are creating a patron category.
- The "Enrollment period -> Until" field should be a Flatpickr calendar
  widget. The widget should look and work correctly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:01:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:01:45 +0000
Subject: [Koha-bugs] [Bug 28978] Convert installer CSS to SCSS
In-Reply-To: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28978-70-2gNvFiYQOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All looking good to me.. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:02:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:02:04 +0000
Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages
In-Reply-To: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28982-70-6jtf665qvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works for me.. Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:07:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:07:43 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-bPkYVnHrNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:07:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:07:49 +0000
Subject: [Koha-bugs] [Bug 29144] Make branches.opac_info suitable for multi
 language use
In-Reply-To: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29144-70-0JL3QyXEp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marcel de Rooy from comment #0)
> Would be nice to have in more than one language.
> What would be the best way to achieve that?
> 
> [3] Your solution ?

Add to "HTML customizations?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:07:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:07:55 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-5RdWoUGDze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125474|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:08:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:08:06 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-uGW1GdygV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125475|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:08:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:08:23 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-2SowWx1Ktw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125476|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:10:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:10:33 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-jq18xY3dR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125504&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context

Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:

my @account_offsets = $payment->debit_offsets;

This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.

To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:

ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:10:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:10:52 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-3mmoMywFKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125505&action=edit
Bug 29139: Fix incorrect relation call

The bug here was worse than originally thought. We were calling the
wrong relation too.. we should probably add some exceptions to catch
this, it confuses me every single time!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:11:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:11:15 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-eOo99grs5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125506&action=edit
Bug 29139: Add exceptions to relation accessors

We already had exceptions on the many-to-many links, but we didn't have
them for the middle table. The underlying dbic relations make it clear
which id's are being used for linking.  A 'credit' has 'credit_offsets',
a 'debit' has 'debit_offsets'.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:11:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:11:32 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-ndXmEf5Qfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125507&action=edit
Bug 29139: Add regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:11:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:11:51 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-A9hpj59Hpb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125508&action=edit
Bug 29139: Only pass the offsets for lines the credit was applied to

On writing the regression tests, I noticed the CREATE offset was added
to the template. The idea behind passing the offsets is that we can
print information about the lines that got the credit applied. Having
the CREATE offset is meaningless, and (worse) would require users to add
logic to skip it. And all the payment information is already passed in
the 'credit' variable anyway.

This patch filters the credit_offsets by type, leaving the APPLY ones
only.

To test:
1. Apply up to the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Account.t
=> FAIL: 3 offsets, including the CREATE one, boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Only the two APPLY offsets are returned!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:22:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:22:36 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
 allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-E6oF3Cx5m6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #50 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
(In reply to Aleisha Amohia from comment #49)
> Hi Andrew, it seems that bug exists regardless of this new work. I can work
> on Bug 21729 but waiting on that patch shouldn't hold up the signoff for
> this enhancement.
> 
> Thanks

You're absolutely correct! I didn't add 21729 as a blocker here as it doesn't
technically break this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:38:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:38:39 +0000
Subject: [Koha-bugs] [Bug 27467] Provide a static URL for tables
In-Reply-To: <bug-27467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27467-70-VF6kOEHaR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi all, I'm looking at this. It is an important addition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:40:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:40:11 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-hNfnyi3zs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:40:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:40:30 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27526-70-IoO4cNxjjI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:41:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:41:43 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-t85oEphHDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125504|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125509&action=edit
Bug 29139: $line->debit_offsets doesn't honor list context

Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:

my @account_offsets = $payment->debit_offsets;

This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.

To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:

ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23

6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:41:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:41:47 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-ecQKnFSFNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125505|0                           |1
        is obsolete|                            |

--- Comment #15 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125510&action=edit
Bug 29139: Fix incorrect relation call

The bug here was worse than originally thought. We were calling the
wrong relation too.. we should probably add some exceptions to catch
this, it confuses me every single time!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:41:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:41:51 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-PuP139n8qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125506|0                           |1
        is obsolete|                            |

--- Comment #16 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125511&action=edit
Bug 29139: Add exceptions to relation accessors

We already had exceptions on the many-to-many links, but we didn't have
them for the middle table. The underlying dbic relations make it clear
which id's are being used for linking.  A 'credit' has 'credit_offsets',
a 'debit' has 'debit_offsets'.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:41:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:41:55 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-T7GZTEgi1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125507|0                           |1
        is obsolete|                            |

--- Comment #17 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125512&action=edit
Bug 29139: Add regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:41:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:41:59 +0000
Subject: [Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is
 enabled
In-Reply-To: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29139-70-54KmOCdOfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125508|0                           |1
        is obsolete|                            |

--- Comment #18 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125513&action=edit
Bug 29139: Only pass the offsets for lines the credit was applied to

On writing the regression tests, I noticed the CREATE offset was added
to the template. The idea behind passing the offsets is that we can
print information about the lines that got the credit applied. Having
the CREATE offset is meaningless, and (worse) would require users to add
logic to skip it. And all the payment information is already passed in
the 'credit' variable anyway.

This patch filters the credit_offsets by type, leaving the APPLY ones
only.

To test:
1. Apply up to the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Account.t
=> FAIL: 3 offsets, including the CREATE one, boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Only the two APPLY offsets are returned!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:42:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:42:52 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-SOcteSmfew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> ---
When I apply this patch and go to create a new HTML customization on
additional-contents.pl I now get this error:

Can't call method "code" on an undefined value at
/kohadevbox/koha/tools/additional-contents.pl line 123

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:07 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-jSXJETU1wM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120582|0                           |1
        is obsolete|                            |

--- Comment #340 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125514&action=edit
Bug 14957: Merge rules system for merging of MARC records

Add a rule based system for merging MARC records to for example
prevent field data from being overwritten.

To test:
    1. Apply this patch.
    2. Log in to staff client.
    3. Enable new syspref MARCMergeRules.
    4. Click the new link "MARC merge rules" in the "Catalog"
       section of the Koha administration page.
    5. Create a new rule:
       Module: source, Filter: *, Tag: 245, Preset: Protect.
    6. Clicking "Edit" should allow you to edit corresponding rule.
    7. Clicking "Delete" should remove corresponding rule after confirmation.
    8. Selecting one or more rules followed by clicking "Delete
       selected" should remove all selected rules after confirmation.
    9. Try creating a rule with tag set to "**", the other options does
       not matter. Verify that saving this rule produces an error
       message complaining about invalid tag regular expression.
    10. Try creating a rule with tag set to "008" (or other control
        field) and set Appended: Append and Removed: Skip, the other
        options does not matter. Verify that saving this rule produces
        an error message complaining about invalid combination of actions
        for control field.
    11. With the 245 rule in step 5 in place, edit a bibliographic record,
        change 245a for example (which should be Title for MARC21) and save.
    12. Verify that the changes has not been saved.
    13. Create a new rule:
        Module: source, Filter: intranet, Tag: 245, Preset: Overwrite.
    14. Repeat step 12, and verify that the changes has now been saved.
    15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very
        that all tests pass.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenburg University Library
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:16 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-qfamhAf1RU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120583|0                           |1
        is obsolete|                            |

--- Comment #341 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125515&action=edit
Bug 14957: Updated schema files

Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:26 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-taT1bxcB9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120584|0                           |1
        is obsolete|                            |

--- Comment #342 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125516&action=edit
Bug 14957: fix context for batchmod and batchimport

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:36 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-Z2d5CaTIPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120585|0                           |1
        is obsolete|                            |

--- Comment #343 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125517&action=edit
Bug 14957: (QA follow-up) Button styling

This patch updates the action buttons to include btn-default and
switched from btn-sm to btn-xs to match other similar UI's found in
datatable based admin pages.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:45 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-4KpE76L8EY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120586|0                           |1
        is obsolete|                            |

--- Comment #344 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125518&action=edit
Bug 14957: (QA follow-up) Add tooltips

This patch adds an info-tooltip to the field rules in the table header
to expand on their meaning to reduce the need to read the documentation
each time you come to use the configuration tool

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:43:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:43:57 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-I8Vm4NbxZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120587|0                           |1
        is obsolete|                            |

--- Comment #345 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125519&action=edit
Bug 14957: (QA follow-up) Rename 'merge' => 'overlay'

This patch acknowledges the fact that 'merging' has a different meaning
in Koha than the behavior this great patchset introduces. The more
idiomatic way of describing the behavior is to talk about 'overlay rules'.

This patch also:
- Fixes kohastructure.sql missing table encoding a collation
- Fixes the atomic update completely missing a table
- Moves the syspref entry to 'Importing', probably a rebase issue

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:07 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-QPlwOfmd3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120588|0                           |1
        is obsolete|                            |

--- Comment #346 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125520&action=edit
Bug 14957: Feature hidden in menues if no other 'cagaloguing' permissions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:16 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-WRCYSmdvZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120589|0                           |1
        is obsolete|                            |

--- Comment #347 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125521&action=edit
Bug 14957: DBIC changes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:25 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-J7LJaNP72P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120590|0                           |1
        is obsolete|                            |

--- Comment #348 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125522&action=edit
Bug 14957: (follow-up) marc_merge_rules_modules removed

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:37 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-HLVIKWyXcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120591|0                           |1
        is obsolete|                            |

--- Comment #349 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125523&action=edit
Bug 14957: (QA follow-up) Clarify 'context' param

This patch renames the (passed through) 'context' param for
'overlay_context'. I propose doing so, because in Koha-land 'context'
has a special meaning, related to C4::Context and it reads ambigous.

The patch itself is pretty trivial.

Tests should pass:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Biblio/MarcOverlayRules.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:46 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-jYms31s0cM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120592|0                           |1
        is obsolete|                            |

--- Comment #350 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125524&action=edit
Bug 14957: (QA follow-up) Fix syntax error in atomicupdate

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:44:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:44:55 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-fhtvhaaaza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120593|0                           |1
        is obsolete|                            |

--- Comment #351 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125525&action=edit
Bug 14957: (QA follow-up) Fix translation issues

This patch fixes all the translation issues I could spot in the
marc-overlay-rules template.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:05 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-1mnP5Wg3C3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120594|0                           |1
        is obsolete|                            |

--- Comment #352 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125526&action=edit
Bug 14957: (QA follow-up) Rename and move admin link

This patch renames 'MARC overlay rules' to 'Record overlay rules' and
moves it up the list to just below 'Record matching rules' to make it
more contextually ordered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:14 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-Z1AtmIE9Ub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120595|0                           |1
        is obsolete|                            |

--- Comment #353 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125527&action=edit
Bug 14957: (QA follow-up) Comment 'bulkmarcimport' temporarily

It appears this patchset doesn't fully support bulkmarcimport (see bug
25539 for details).

At this time, to get this bug moving I think we should comment out the
ability to define rules that affect bulkmarcimport and then we can fix
and re-enable that feature at a later date.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:27 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-auAsRY77Gi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120596|0                           |1
        is obsolete|                            |

--- Comment #354 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125528&action=edit
Bug 14957: (QA follow-up) Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:36 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-8y90sNbDIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120597|0                           |1
        is obsolete|                            |

--- Comment #355 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125529&action=edit
Bug 14957: (QA follow-up) Update for bug 26703

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:47 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-qGizlRhhSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120598|0                           |1
        is obsolete|                            |

--- Comment #356 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125530&action=edit
Bug 14957: (QA follow-up) Update for bug 20054

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:45:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:45:59 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-qmEfJT2aA7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120599|0                           |1
        is obsolete|                            |

--- Comment #357 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125531&action=edit
Bug 14957: (QA follow-up) Update for bug 20053

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:46:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:46:09 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-pC5OtYs2as@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120600|0                           |1
        is obsolete|                            |

--- Comment #358 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125532&action=edit
Bug 14957: (QA follow-up) Update for bug 17858

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:46:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:46:19 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-d9GB6toKUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120601|0                           |1
        is obsolete|                            |

--- Comment #359 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125533&action=edit
Bug 14957: (QA follow-up) Update for bug 27846

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:46:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:46:29 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-G1moJjxOgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120602|0                           |1
        is obsolete|                            |

--- Comment #360 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125534&action=edit
Bug 14957: (QA follow-up) Fix template indentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:46:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:46:40 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-UFVVkjnOJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120603|0                           |1
        is obsolete|                            |

--- Comment #361 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125535&action=edit
Bug 14957: (QA follow-up) Update for bug 23271

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:46:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:46:50 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-cxcjpt6nOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120604|0                           |1
        is obsolete|                            |

--- Comment #362 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125536&action=edit
Bug 14957: (QA follow-up) Fix script name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:47:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:47:00 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-cIYYBb569M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120605|0                           |1
        is obsolete|                            |

--- Comment #363 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125537&action=edit
Bug 14957: (QA follow-up) Fix for jQuery undefined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:47:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:47:10 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-VuG8H5AwfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120671|0                           |1
        is obsolete|                            |

--- Comment #364 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125538&action=edit
Bug 14957: Clean controller

Too many imports and unecessary complicated init of $rules

There are certainly other things to improve, like the "op" handling,
standardize names of "op", etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:47:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:47:19 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-XHnGphHTPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120705|0                           |1
        is obsolete|                            |

--- Comment #365 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125539&action=edit
Bug 14957: Improve readbility of tests

Not saying that they were not readable before, but I had to do some
changes to compare the before/after records and it was easier that way.
Feel free to obsolete if you disagree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:47:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:47:29 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-XxIMlNoLGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #366 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 125540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125540&action=edit
Bug 14957: Fix imports in tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:48:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:48:04 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-gcQToao2HN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #367 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another rebase.. another follow-up to fix things that have moved on.

I'm not sure what more I can do... 6 years is too long for an important feature
like this to languish.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:53:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:53:52 +0000
Subject: [Koha-bugs] [Bug 29146] Should framework default values be applied
 to existing records?
In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29146-70-2JVs0JZ36T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
           Severity|enhancement                 |normal
             Status|NEW                         |ASSIGNED

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing enhancement to bug status normal. What Koha does for years, is
actually just wrong. The positive side is that many people will add the record,
and not edit it any longer ;)
But my cataloger tells me: I reopen the record, and remove the wrong defaults.
Which is obviously kind of job creation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:54:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:54:21 +0000
Subject: [Koha-bugs] [Bug 29146] Should framework default values be applied
 to existing records?
In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29146-70-gFMkuXHud3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:54:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:54:25 +0000
Subject: [Koha-bugs] [Bug 29146] Should framework default values be applied
 to existing records?
In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29146-70-SFqkrs2ept@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 125541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125541&action=edit
Bug 29146: Apply framework defaultvalue only to new records

This applies only to the 'regular' cataloguing editor.
Another report could be opened for the advanced one,
if needed.

Test plan:
[1] Add a default value to some field X in framework Y.
[2] Open an existing biblio record in that fw. Clear field X. Save.
[3] Reopen the record. The default should not be in field X.
[4] Add a new record in that fw. You should see default value in X.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:56:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:56:03 +0000
Subject: [Koha-bugs] [Bug 29146] Should framework default values be applied
 to existing records?
In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29146-70-5Y847cpFrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch makes Koha no
      release notes|                            |longer apply default values
                   |                            |to empty fields in an
                   |                            |existing biblio record in
                   |                            |the regular cataloguing
                   |                            |editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:59:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:59:23 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-AMTbOu4wF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 15:59:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 13:59:26 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-amzbUjB1yl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125473|0                           |1
        is obsolete|                            |

--- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125542&action=edit
Bug 29137: Add new syspref to disable AV creation within the cataloguing module

"I don't like this patch at all!"
"We will see a cataloger revolt if we do not find a way to make this
optional for catalogers."

I imagined a hord of catalogers running behind me and I got scared.

This patch will allow to turn the new feature added by bug 25728 off.

Test plan:
Confirm that the new CreateAVFromCataloguing will permit to turn the
feature off.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:02:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:02:30 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-WHMuvISMjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'll admit to a bit of pearl-clutching overreaction on this. I hadn't yet seen
29030 when I filed this. Like Joy and Jonathan, I also fear torch-wielding
catalogers. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:16:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:16:13 +0000
Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
In-Reply-To: <bug-25539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25539-70-oDFZJJmxjt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14957                       |
             Blocks|                            |14957


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
[Bug 14957] Write protecting MARC fields based on source of import
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:16:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:16:13 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-AwttK4f8oC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|25539                       |
         Depends on|                            |25539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
[Bug 25539] Remove AddBiblio "defer_marc_save" option
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:23:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:23:40 +0000
Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in
 Elasticsearch
In-Reply-To: <bug-25030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25030-70-tpyG61SwEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030

--- Comment #10 from Séverine Queune <severine.queune at bulac.fr> ---
Hi everyone !
Any chance to see this patch updated soon ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:31:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:31:25 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-weXr4a6wQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #368 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Jonathan Druart from comment #339)
> There are several questions waiting for answers, see comments 321-333.

I read through those comments again, and the questions where not addressing
stability issues but feature requests and refactoring suggestions. Probably one
of the reasons this has taken so long is that instead of concentrating on
minimal viable functionality there are continuous suggestions for new features
and improvements. Some of which are actually pretty complicated to implement
(like user feedback). As I said we have been running this in production for
years, and it more or less covers our needs (as pretty decently sized
university library with 200+ employees.

I did forget about one thing though, that actually is a show-stopper, and that
is if this bug is merged without the fix in bug 25539, this will trigger a bug
with this current patch. I discovered that bug 25539 was set as depending on
this bug when it should have been the other way around which I now fixed.

The reason everything works for us is that we use the fix in bug 25539. We also
have large and unruly patch for bulkmarcimport.pl (a which I believe is now
deactivated in the current iteration of this patch) so that also source works.
Can't remember at the top of my head what the issues in bulkmarcimport.pl was
that caused us to disable it, but the fix in bug 25539 will not solve this
issue I think (but is still needed to avoid the bug causing rules to be ignored
on updates. So I think focusing on sorting out the issue addressed in bug
25539, and possibly address the problems with bulkmarcimport.pl would be
reasonable thing to prioritize.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:32:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:32:53 +0000
Subject: [Koha-bugs] [Bug 29147] New: Add option to specify Zebra is not
 being used
Message-ID: <bug-29147-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29147

            Bug ID: 29147
           Summary: Add option to specify Zebra is not being used
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Zebra
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

During ES development it was advantageuos to preserve Zebra as a backup, and it
was necessary for the Z3950 server

We now have z3950_responder and Koha can be run without Zebra

There should be a switch that:
1 - Prevents ZebraQueue from being populated
2 - Removes Zebra info from about page (currently there is a warn if not
running)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:33:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:33:22 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-gun7amWNsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #81 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. +my $can_request = $borrower->can_request_article
$patron is better now

2. 
+    my $compdate = dt_from_string->add( days => -1 );
I don't understand, what are we doing here? Can you add a line in the POD about
that?

3. 

+    if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
+        push @messages, {type => 'error', code =>
'article_request_numeric_limit' };
+        $op = 'add_form';
+    } elsif ($article_request_limit ne '' && $article_request_limit < 0) {
+        push @messages, {type => 'error', code =>
'article_request_negative_limit' };
+        $op = 'add_form';
+    } else {

Why that?
I am expecting to see a JS validation and an exception raised in
Koha::Category->store. But not in the controller.

4.

circ/request-article.pl

+        error_message => 'Patron cannot request more articles for today'

<p>[% error_message | html %]</p>

Hum? Non translatable message.

Same for the exception actually:
+            error_message => $_->{message}

And same in opac-request-article.pl

5. opac-request-article.pl

+        exit unless $_->[0] && $_->[0] eq 'EXIT';

This is very awkward. Why not simply having the print+exit outside of the try?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:33:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:33:45 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-h3aUm56GRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
             Status|Passed QA                   |In Discussion

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. I don't understand why we pass patron_name when we have the patron_id (same
for biblio_title).
If you modify the patron's name, the name won't match.

If you cannot do it now, you may need Koha::BackgroundJob->additional_report
from "Bug 28445: Add the capability to provide more info to the background job
detail view"

2.
+            push @messages, {
+                type => 'error',
+                code => 'hold_not_cancelled',
+                patron_id => defined $patron?$patron->borrowernumber:'',
+                patron_name => defined
$patron?($patron->firstname?$patron->firstname.', ':'').$patron->surname:'',
+                biblio_id => defined $biblio?$biblio->biblionumber:'',
+                biblio_title => defined $biblio?$biblio->title:'',
+                hold_id => $hold_id,
+                error => defined $hold?($@ ? $@ : 0):'No hold with id
'.$hold_id.' found',
+            };

Erk, spaces, indentation? I can fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:33:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:33:52 +0000
Subject: [Koha-bugs] [Bug 27947] Add default cancellation reasons to article
 requests
In-Reply-To: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27947-70-z2zT0Z2D3H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Not blocker, but:
-    my ( $self, $notes ) = @_;
+    my ( $self, $cancellation_reason, $notes ) = @_;

You should have used a hashref, especially because we have Koha::Hold->cancel
that is getting a reason as well:

my $cancel_hold = $hold->cancel(
    {
        [ charge_cancel_fee => 1||0, ]
        [ cancellation_reason => $cancellation_reason, ]
    }
);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:33:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:33:58 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-k7jJW16oFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #84 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Missing POD in Koha::ArticleRequest

2. Koha::ArticleRequest->request is not covered by tests

3. Changes to Koha::ArticleRequest->cancel are not covered by tests

4. Koha::ArticleRequests->requested is not covered by tests

4. Not a big deal (not blocker of course) but
  $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av;
Is more readable (IMO) like:
  $reason = $av->lib_opac || $av->lib if $av;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:41:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:41:45 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-KMro1C2mjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:41:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:41:49 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-x8gPO3bANU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125471|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 125543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125543&action=edit
Bug 28717: Fix additional content logs

The logging for additional contents added by bug 26205 has been broken
by but 22544.

This patch is a revisited version as bug 24387 has been pushed.
It does not log MODIFY if no modification has been made on a template
(useful when only 1 version/lang of a content has been modified)

Test plan:
Turn on NewsLog
Add/modify and delete additional contents/News and confirm that
modification are logged.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:41:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:41:58 +0000
Subject: [Koha-bugs] [Bug 28717] NewsLog doesn't work
In-Reply-To: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28717-70-xE13BjjAU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Sorry, Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:46:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:46:33 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-IDckO4pLAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Thank you everyone!  This fix will really make 'hi-efficiency', keyboard
centric catalogers very happy.  :D

joy


(In reply to Andrew Fuerste-Henry from comment #9)
> I'll admit to a bit of pearl-clutching overreaction on this. I hadn't yet
> seen 29030 when I filed this. Like Joy and Jonathan, I also fear
> torch-wielding catalogers. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:49:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:49:24 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-OqyAZMpXXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #369 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I've spent a lost of time on this patch set to make it part of 21.05. Added
follow-ups and written test.

Then I had some questions, and didn't get the answers I needed to write the
missing bit. I was not asking anybody else to write anything.

I wish I had people asking me to write follow-up for my patches..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 16:57:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 14:57:54 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-hRpcTFmgnj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #85 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125544&action=edit
Bug 27944: (follow-up) Add POD

The library didn't contain real POD. This patch adds it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 17:06:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 15:06:18 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-7WXnxtjvAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #370 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
> I did forget about one thing though, that actually is a show-stopper, and
> that is if this bug is merged without the fix in bug 25539, this will
> trigger a bug with this current patch. I discovered that bug 25539 was set
> as depending on this bug when it should have been the other way around which
> I now fixed.

Pretty sure we reversed the dependencies deliberately to unblock this.. we
disable this feature for use with bulkmarcimport in one of the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 17:32:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 15:32:12 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-gpSjokuTqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #371 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Martin Renvoize from comment #370)
> > I did forget about one thing though, that actually is a show-stopper, and
> > that is if this bug is merged without the fix in bug 25539, this will
> > trigger a bug with this current patch. I discovered that bug 25539 was set
> > as depending on this bug when it should have been the other way around which
> > I now fixed.
> 
> Pretty sure we reversed the dependencies deliberately to unblock this.. we
> disable this feature for use with bulkmarcimport in one of the patches.

Yes, now I remember. I mistakenly misremembered the bug in bug 25539 appearing
when saving using the staff interface. In that case there should be no blockers
for this patch (with bulkmarcimport.pl disabled, which would be a show-stopper
for us, but we would in case this got merged address with a local patch).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 17:41:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 15:41:10 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-0icCGakpaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124867|0                           |1
        is obsolete|                            |

--- Comment #55 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125545&action=edit
Bug 24387: Entries with parent are missing a code

We executed the same 2 queries, we want to adjust the code for the
parent and the language specific row.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 17:41:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 15:41:39 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24387-70-kSVqZ1fHd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #56 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #54)
> Created attachment 124867 [details] [review]
> Bug 24387: Entries with parent are missing a code
> 
> We executed the same 2 queries, we want to adjust the code for the
> parent and the language specific row.

(In reply to Nick Clemens from comment #55)
> Created attachment 125545 [details] [review]
> Bug 24387: Entries with parent are missing a code
> 
> We executed the same 2 queries, we want to adjust the code for the
> parent and the language specific row.
> 
> Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Read code, did not test, but the change makes logical sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:06:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:06:37 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-QsLxI8sKmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:06:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:06:40 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-N4lxtvUsQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125542|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 125546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125546&action=edit
Bug 29137: Add new syspref to disable AV creation within the cataloguing module

"I don't like this patch at all!"
"We will see a cataloger revolt if we do not find a way to make this
optional for catalogers."

I imagined a hord of catalogers running behind me and I got scared.

This patch will allow to turn the new feature added by bug 25728 off.

Test plan:
Confirm that the new CreateAVFromCataloguing will permit to turn the
feature off.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:14:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:14:47 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-qUpFSaqWmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #84)
> 1. Missing POD in Koha::ArticleRequest
> 
> 2. Koha::ArticleRequest->request is not covered by tests
> 
> 3. Changes to Koha::ArticleRequest->cancel are not covered by tests
> 
> 4. Koha::ArticleRequests->requested is not covered by tests
> 
> 4. Not a big deal (not blocker of course) but
>   $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av;
> Is more readable (IMO) like:
>   $reason = $av->lib_opac || $av->lib if $av;

Can this be pushed as is? I move the tests to another file in a later bug and
can happily add tests. Some already exist on Article requests.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:19:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:19:47 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-fmu8cOto4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119830|0                           |1
        is obsolete|                            |
 Attachment #119832|0                           |1
        is obsolete|                            |
 Attachment #119834|0                           |1
        is obsolete|                            |
 Attachment #119835|0                           |1
        is obsolete|                            |
 Attachment #119836|0                           |1
        is obsolete|                            |
 Attachment #119837|0                           |1
        is obsolete|                            |
 Attachment #119838|0                           |1
        is obsolete|                            |
 Attachment #119839|0                           |1
        is obsolete|                            |
 Attachment #119840|0                           |1
        is obsolete|                            |
 Attachment #119841|0                           |1
        is obsolete|                            |
 Attachment #119842|0                           |1
        is obsolete|                            |
 Attachment #119843|0                           |1
        is obsolete|                            |
 Attachment #120191|0                           |1
        is obsolete|                            |
 Attachment #121469|0                           |1
        is obsolete|                            |
 Attachment #121470|0                           |1
        is obsolete|                            |
 Attachment #121522|0                           |1
        is obsolete|                            |
 Attachment #121559|0                           |1
        is obsolete|                            |

--- Comment #45 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125547&action=edit
Bug 27631: Changed <h1> around logo to <div>

To test:
1) Look at Staff Client and the logo
2) Apply patch
3) Check Koha logo moves to the middle of the page when zooming in
4) Ensure page source shows logo inside <div> and not <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:19:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:19:51 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-VSUgRF3NXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #46 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125548&action=edit
Bug 27631: circ folder

Changed each of the pages in the circ folder to have one <h1> tag
showing that describes the page, rather than the <h1> describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the circ folder and check that they have
   an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:19:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:19:55 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-mEw6WSLnCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #47 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125549&action=edit
Bug 27631: labels and members folders

Changed each of the pages in the labels and members folders to have one
<h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the labels and members folders and check
   that they have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:19:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:19:59 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-a3GbNv6QST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #48 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125550&action=edit
Bug 27631: authorities, clubs, common, course_reserves folders

Changed each of the pages in the authorities, clubs, common,
course_reserves folders to have one <h1> tag showing that describes
the page, rather than the <h1> describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the authorities, clubs, common,
   course_reserves folders and check that they have an obvious and
   descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:03 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-OnYvGDFfrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #49 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125551&action=edit
Bug 27631: installer and onboarding folders

Changed each of the pages in the installer and onboarding folders to
have one <h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Ensure that the page source shows logo inside <div> and not inside
   <h1>
4) Go to each of the pages in the installer and onboarding folders and
   check that they have an obvious and descriptive heading
5) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:07 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-QLHXCwgpdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #50 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125552&action=edit
Bug 27631: offline_circ, patroncards, plugins, pos, reserve,
rotating_collections folders

Changed each of the pages in the offline_circ, patroncards, plugins,
pos, reserve, rotating_collections folders to have one <h1> tag showing
that describes the page, rather than the <h1> describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the offline_circ, patroncards, plugins,
   pos, reserve, rotating_collections folders and check that they have
   an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:11 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-dJMXoylh05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #51 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125553&action=edit
Bug 27631: catalogue and tags folders

Changed each of the pages in the catalogue and tags folders to have one
<h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the catalogue and tags folders and check
   that they have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:16 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-nuedgWREpf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #52 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125554&action=edit
Bug 27631: tools and virtualshelves folders

Changed each of the pages in the tools and virtualshelves folders to
have one <h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the tools and virtualshelves folders and
   check that they have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:20 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-0hmrdkXHJC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #53 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125555&action=edit
Bug 27631: reports and serials folders

Changed each of the pages in the reports and serials folders to
have one <h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the reports and serials folders and
   check that they have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:24 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-BTxKKhxlI9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #54 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125556&action=edit
Bug 27631: cataloguing folder

Changed each of the pages in the cataloguing folder to have one <h1>
tag showing that describes the page, rather than the <h1> describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this will
be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the cataloguing folder and check that they
   have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:29 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-HfGVvxHBDN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #55 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125557&action=edit
Bug 27631: acqui folder

Changed each of the pages in the acqui folder to have one <h1> tag
showing that describes the page, rather than the <h1> describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the acqui folder and check that they have
   an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:35 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-Cc553DGBmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #56 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125558&action=edit
Bug 27631: Hidden <h1> on intranet-main.tt

This patch visually hides a <h1> on intranet-main.tt so that the
heading is available to be read out by screenreaders in the summary of
headings on the page.

Test plan:

1) Ensure the <h1> "Koha home" heading on the staff client main/home
   page is hidden visually, but in the source code you can see it

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:40 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-HL30pinxvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #57 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125559&action=edit
Bug 27631: admin folder

Changed each of the pages in the admin folder to have one <h1> tag
showing that describes the page, rather than the <h1> describing the
logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the admin folder and check that they have
   an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:44 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-4pdDIKxV2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #58 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125560&action=edit
Bug 27631: (follow-up) course_reserves/course-details.tt

Changed file to have one <h1> tag showing that describes the page,
rather than the <h1> around the logo.

The hierarchy of other heading tags may be wrong, but this will be
dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to course_reserves/course-details and check that it has an obvious
   and descriptive heading
4) Ensure that the heading is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:49 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-RUY5MVjK8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #59 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125561&action=edit
Bug 27631: (follow-up) tools/marc_modification_templates.tt

Changed file to have one <h1> tag showing that describes the page,
rather than the <h1> around the logo.

The hierarchy of other heading tags may be wrong, but this will be
dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to tools/marc_modification_templates and check that it has an
   obvious and descriptive heading
4) Ensure that the heading is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:53 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-Bs9MRhcVus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #60 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125562&action=edit
Bug 27631: (follow-up) reports/guided_reports_start.tt

Changed file to have one <h1> tag showing that describes the page,
rather than the <h1> around the logo.

The hierarchy of other heading tags may be wrong, but this wil be dealt
with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to reports/guided_reports_start and check that it has an obvious
   and descriptive heading
4) Ensure that the heading is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:20:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:20:57 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-RIrF1B1Gpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #61 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125563&action=edit
Bug 27631: (follow-up) circ/branchtransfers.tt

Changed file to have one <h1> tag showing that describes the page,
rather than the <h1> around the logo.

The hierarchy of other heading tags may be wrong, but this will be
dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to circ/branchtransfers and check that it has an obvious and
   descriptive heading
4) Ensure that the heading is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:21:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:21:02 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-SMoAvbbDzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #62 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 125564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125564&action=edit
Bug 27631: (follow-up) Some minor corrections

This patch makes some corrections to issues found during testing:

Some duplicate headings, a markup error in labeledMARCdetail.tt, a
change of the transfers heading from "Branch transfers" to "Item
transfers."

This patch also undoes the changes to the position of the toolbar on
several pages. I think those changes don't belong in this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:28:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:28:09 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-qp7Gdnt2bw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #87 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Can be done on a follow-up bug, yes. But I will wait for the tests to push.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:29:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:29:22 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff Client - <h1> on each
 page is Logo but should be page description/title
In-Reply-To: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27631-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27631-70-Y1c5l54zvG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:50:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:50:32 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-ilkltZzIPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #372 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Jonathan Druart from comment #369)
> I've spent a lost of time on this patch set to make it part of 21.05. Added
> follow-ups and written test.
> 
> Then I had some questions, and didn't get the answers I needed to write the
> missing bit. I was not asking anybody else to write anything.
> 
> I wish I had people asking me to write follow-up for my patches..

Sorry I missed some of those questions (i for some reason read comment 221-333
so I was not referring to you regarding requesting new features).

Regarding the question in comment 324:

> 4. We need a wiki page, or at least more info/examples for the release notes.
There is only 2 very succinct example in the test plan but the feature allows
much more.

I have written a manual entry, it might now be partly out dated since it was 2
years ago, there are some links to it further up in the thread:
https://gitlab.com/gnucifer/koha-manual/-/commit/eb07dd1abcb357de27d294cee49c287c6f5bfe6c


The reason I pointed out that we have been running this in production for a
long time is that there appears to be great hesitancy in merging this which is
understandable due to the large surface area of changes and and relative high
complexity. That serious bugs could lurk is not impossible, but is highly
unlikely as we would probably have encountered them by now. There are for
example certain contexts that we do not use, like batchmod, z3950 and
import_lexile, but it can be good to know that the core functionality appears
to be pretty solid. The scariest part of this by far is the potential for
unexpected data loss or corruption when records are taken apart and put back
together again, and that part appears to be solid. As a side note I don't
really get why MergeRules were renamed to OverlayRules, it's not that much
worse than merge, but is it really better? To me merge is more intuitive as we
basically have to revisions of a record and use certain rules to resolve the
diff, merging the two.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:51:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:51:41 +0000
Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings
 should have correct tags and hierarchy
In-Reply-To: <bug-27741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27741-70-hFJjoyqIJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #39 from Owen Leonard <oleonard at myacpl.org> ---
I'm not sure if it was my rebase of Bug 27631 or something else, but this
doesn't apply: 

Applying: Bug 27741: admin folder
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 27741: admin folder

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:52:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:52:44 +0000
Subject: [Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions
 to tables
In-Reply-To: <bug-28243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28243-70-UTW9h6iTZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 18:56:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 16:56:11 +0000
Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce
 heading redundancy
In-Reply-To: <bug-27877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27877-70-NPVP27n6HE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 19:01:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 17:01:02 +0000
Subject: [Koha-bugs] [Bug 28988] Reindent calendar template
In-Reply-To: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28988-70-jwio8rYhX6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #8)
> Unfortunately there are several accessibility patches in the queue currently
> that are modifying this template.

I've tried to move Bug 27631 along (Accessibility: Staff Client - <h1> on each
page is Logo but should be page description/title). I rebased and signed off on
the existing patches and submitted a follow-up that addresses the concerns
which led me to mark it Failed QA.

Other patches in that series don't apply anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:07:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:07:26 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-gDjuhKRIol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #88 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125565&action=edit
Bug 27944: Add missing tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:07:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:07:48 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-luSpxfJ0yF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:13:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:13:30 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-ZeeITOL2dX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

--- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> ---
And yes, you're both right about the deleted records. I had missed the most
logical shortcut that a deleted biblio can't have items deleted later. I think
I have a fix which mostly just makes things more simple, but I'm still working
on adding tests to cover all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:15:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:15:29 +0000
Subject: [Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from
 5.0.16 to 5.9.2
In-Reply-To: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26949-70-v4xdrK4v4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Upgrade TinyMCE in the      |Upgrade TinyMCE in the
                   |staff interface from 5.0.16 |staff interface from 5.0.16
                   |to 5.5.1                    |to 5.9.2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:16:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:16:47 +0000
Subject: [Koha-bugs] [Bug 29148] New: Holds to Pull doesn't reflect
 item-level holds
Message-ID: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

            Bug ID: 29148
           Summary: Holds to Pull doesn't reflect item-level holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To test:
- have an item with multiple copies
- place an item-level hold on one of the copies
- go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl)
- confirm it shows "[one of the barcodes] or any available" when it should show
specifically the barcode of the item on which your hold was placed and should
not show "or any available"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:23:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:23:47 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
 holds
In-Reply-To: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29148-70-6avAKRCymq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:23:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:23:51 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
 holds
In-Reply-To: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29148-70-o9JdG3Sh0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 125566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125566&action=edit
Bug 29148: Check reserves.item_level_hold in Holds to Pull

To test:
1 - place an item level hold
2 - go to Holds to Pull, see it shows "[barcode] or any available"
3- apply patch, restart
4- reload Holds to Pull, see it shows "only [barcode]"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:25:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:25:24 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
 holds
In-Reply-To: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29148-70-pGjzVwrGt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm honestly not sure why the existing code started to fail here, but I changed
it to check for item_level_hold=1, rather than presence of an itemnumber. It
seems like a more reliable check anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:28:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:28:33 +0000
Subject: [Koha-bugs] [Bug 26646] Holds to Pull should show distinct
 item-level holds
In-Reply-To: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26646-70-izXwjTaTKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:36:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:36:37 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-chE3EysrBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125565|0                           |1
        is obsolete|                            |

--- Comment #89 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125567&action=edit
Bug 27944: Add missing tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:37:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:37:42 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-3zzOQonpX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:37:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:37:53 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-LPfRyu1XQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125451|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 125568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125568&action=edit
Bug 29134: Use a subquery to increase performance of patron attributes search

This patch generates a subquery and checks if a borrowrnumber is in the results
to add patrons
to search results

To test:
 1 - Generate a bunch of patrons:
    SELECT surname, firstname, branchcode, categorycode FROM ( SELECT surname
FROM borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY
rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT
categorycode FROM borrowers ORDER BY rand() ) d LIMIT 50000
 2 - Add a patron attribute to the system and make it searchable - I used code
'TEST'
 3 - Add a value for this attribute to many patrons:
   INSERT INTO borrower_attributes (borrowernumber,code,attribute) SELECT
borrowernumber, 'TEST','alphabet' FROM borrowers LIMIT 10000;
 4 - In staff client got 'Patrons'
 5 - Open the browser console (F12) and view the netwrok tab
 6 - Perform a patron search for 'a'
 7 - Note the time it takes for 'search' to complete in console
 8 - Apply patch, restart_all
 9 - Repeat search
10 - Note it is much faster
11 - prove -v t/db_dependent/Utils/Datatables_Members.t

NOTE: I tested with 500k patrons and 100k attributes - search returned in ~2
seconds with patch
and did not return before I got impatient without patch

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:38:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:38:20 +0000
Subject: [Koha-bugs] [Bug 27944] Add new stages to the article request
 process
In-Reply-To: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27944-70-YW63ULv9DR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

--- Comment #90 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #84)
> 1. Missing POD in Koha::ArticleRequest

Done.

> 2. Koha::ArticleRequest->request is not covered by tests

Done.

> 3. Changes to Koha::ArticleRequest->cancel are not covered by tests

Done.

> 4. Koha::ArticleRequests->requested is not covered by tests

Done.

> 4. Not a big deal (not blocker of course) but
>   $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av;
> Is more readable (IMO) like:
>   $reason = $av->lib_opac || $av->lib if $av;

This is another bug, will fix in the right place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:42:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:42:56 +0000
Subject: [Koha-bugs] [Bug 29134] Patron search has poor performance when
 ExtendedAttributes enabled and many attributes match
In-Reply-To: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29134-70-dfuAgz36Hc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134

--- Comment #10 from David Nind <david at davidnind.com> ---
(In reply to Nick Clemens from comment #6)
> (In reply to David Nind from comment #5)
..
> That was a typo, it should be:"
> INSERT into borrowers(surname, firstname, branchcode, categorycode) SELECT
> surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM
> borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY
> rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT
> categorycode FROM borrowers ORDER BY rand() ) d LIMIT 50000

Thanks Nick - now works as expected, and was able to test.

Before patch applied (koha-testing-docker): 19.71 s
After: 1.81 s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 20:59:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 18:59:53 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-XzsgZR4R1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #82 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125569&action=edit
Bug 27945: (QA follow-up) Clarify behavior in POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:00:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:00:34 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-urwylPHFAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #83 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #81)
> 1. +my $can_request = $borrower->can_request_article
> $patron is better now

Done.

> 2. 
> +    my $compdate = dt_from_string->add( days => -1 );
> I don't understand, what are we doing here? Can you add a line in the POD
> about that?

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:36:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:36:34 +0000
Subject: [Koha-bugs] [Bug 11723] Message "A refund has been applied" on all
 lost item returns
In-Reply-To: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11723-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11723-70-bbtPw0TKOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:40:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:40:44 +0000
Subject: [Koha-bugs] [Bug 29137] Unwanted authorised values are too easily
 created via the cataloging module
In-Reply-To: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29137-70-UYDjuNclp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137

Jason Vasche <jvasche at roundrocktexas.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jvasche at roundrocktexas.gov

--- Comment #12 from Jason Vasche <jvasche at roundrocktexas.gov> ---
Joy described my (and my RRPL colleagues') need for efficiency in cataloging
workflow perfectly in comment 4.  We would love to have a way to completely
turn off AV creation in the cataloging module, thanks to all involved for
patching this bug!

*hides unlit torch behind back and whistles nonchalantly*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:53:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:53:52 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-YpvcFlqUlr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:53:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:53:56 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-II98DfZXHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

--- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 125570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125570&action=edit
Bug 29135: Fix handling of deleted items in OAI-PMH provider

Test plan:
1. Make sure this scenario now works properly:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0
2. Run prove -v t/db_dependent/OAI/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 21:55:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 19:55:35 +0000
Subject: [Koha-bugs] [Bug 29135] OAI should not include biblionumbers from
 deleteditems when determining deletedbiblios
In-Reply-To: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29135-70-X2gHdvG5oE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

--- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> ---
This should fix the issues. I haven't had a chance to manually test much yet,
but at least the tests added failed miserably without the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:00:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:00:28 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
 holds
In-Reply-To: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29148-70-vt0jwWasen@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

Azucena Aguayo <azucena.aguayo at uvu.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |azucena.aguayo at uvu.edu

--- Comment #3 from Azucena Aguayo <azucena.aguayo at uvu.edu> ---
Patch solves the item-level hold issue.

However, patch breaks title-level hold barcode display.

To test:
- have an 2 records with multiple copies
- place an item-level hold on one of the copies for record A
- place a title-level hold for record B
- go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl)
- confirm it shows "only barcode" on BOTH holds when it should show
specifically the barcode of one item on the hold for record A, but show the
same on the title hold for record B.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:07:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:07:04 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9097-70-gREM5EOVhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:07:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:07:22 +0000
Subject: [Koha-bugs] [Bug 14771] Allow patrons to pick a username
In-Reply-To: <bug-14771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14771-70-IM2n7eOamW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:07:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:07:50 +0000
Subject: [Koha-bugs] [Bug 18543] Emails for new patron accounts with the
 AutoEmailOpacUser preference require to enter password manually
In-Reply-To: <bug-18543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18543-70-tcC3vNkCgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:09:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:09:00 +0000
Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/page for terms
 and conditions of use in the opac
In-Reply-To: <bug-13376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13376-70-fJ1vmYlFar@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:10:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:10:26 +0000
Subject: [Koha-bugs] [Bug 29062] Patron check-in slip repeats data
In-Reply-To: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29062-70-Xvy83mnvSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:24:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:24:17 +0000
Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level
 holds
In-Reply-To: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29148-70-9q3hCHCWIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:34:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:34:16 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-d7Mc5CV4ox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #84 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #81)
> 3. 
> 
> +    if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
> +        push @messages, {type => 'error', code =>
> 'article_request_numeric_limit' };
> +        $op = 'add_form';
> +    } elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> +        push @messages, {type => 'error', code =>
> 'article_request_negative_limit' };
> +        $op = 'add_form';
> +    } else {
> 
> Why that?
> I am expecting to see a JS validation and an exception raised in
> Koha::Category->store. But not in the controller.

Is this a blocker for inclusion?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 22:54:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 20:54:23 +0000
Subject: [Koha-bugs] [Bug 27945] Limit the number of active article requests
 per patron category
In-Reply-To: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27945-70-glWO8YcBKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #85 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 125571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125571&action=edit
Bug 27945: (QA follow-up) Validate the input in the form

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Sep 30 23:06:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Sep 2021 21:06:52 +0000
Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results
 (single character search) causes poor performance or timeout
In-Reply-To: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15812-70-v9vTvHMIJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812

--- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Super, permission is OK now.

(In reply to Fridolin Somers from comment #6)
> Note than cardnumber column may be hidden.
> 
Isn't that a problem ?

Also for consistency, everywhere in tables buttons are in actions column.

But it is minor.
It is a great change.

-- 
You are receiving this mail because:
You are watching all bug changes.