[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Sep 1 13:47:16 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Tomás Cohen Arazi from comment #19)
> > $template->param(
> >     outstanding_debits => scalar $patron->account->outstanding_debits,
> >     items              => scalar $biblio->items,
> > );
> 
> I'd personally prefer to not have to forget the "scalar" (and almost always
> use iterator) and explicitly ask for the list when I need it (->as_list).
> 
> Not blocking, just expressing my opinion :)

I'm of two minds.. in some ways perls contextual returns are lovely and DWIM..
but in other cases I'd really rather it required me to be specific.

DBIC actually gets around this by having a context ignorant accessor.. adding
_rs to accessor methods (search, relationships) will force list context and
give you back an iterator rather than getting clever with wantarray.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list