[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #92 from Andrew Nugged <nugged at gmail.com> ---
1: yes, naming can be added

2: this is a "placeholder" which:
    a) first: part of text removed and replaced by placeholders (~~XI1~~ /
~~LC1~~ for example and others, life "LC for LeftCurly" and so on). This is for
temporary hiding out current brackets from "next RegExs"
    b) then text processed expecting that all others curly/square brackets and
regex and what must be kept – removed and hidden, so we can clean up and be
brave with all other not-replaced-by-placeholders brackets,
    c) so we cleaning up text, screening, removing or whatever those special
characters,
    d) and now we replacing BACK those placeholders with their saved in step a)
values back to keep unscreened and working special characters we wanted to be
kept

3: because it has " .. ? .. : .." depending of what bracket was found, but
otherwise if you speaking security-wise and don't want to have "e"'s at all
this RE probably can be split to few "just with different brackets" each,
should Petro split this regex to two without "e"? We discussed this too, I also
pointed that this is less secure "if something changes", but in this case, I
don't see how this can be hacked (how?)

4: for sure, this is good point. And some more comments in code. Let's do this.

-- 
You are receiving this mail because:
You are watching all bug changes.