[Koha-bugs] [Bug 28927] Id opacmainuserblock used twice in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Thanks, I think this change looks reasonable, though some things to fix.

1) Could you fix up the commit message, you mention that this fixes a bug but
don't say which one, also mention in the commit message what the change does
and use the format "Bug XXXX: Change X thing". I'm guessing you are doing this
change to simplify (custom) CSS rules?

2) It seems to break the OpacHeader / opacheader CSS rule defined in the line

koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {

-- 
You are receiving this mail because:
You are watching all bug changes.